Re: [opensource-dev] (no subject)

[Yoz Grahame]

I've just heard from another resident who experienced this with Viewer 2. If
you can file a JIRA with a repro and a screenshot (or as much useful
information as you have, anyway) I'll pass it on to the Search team.

On 25 January 2011 15:29, Yoz Grahame  wrote:

> Which viewer was this in? As far as I know, there's no such limit in viewer
> 2 search.
>
>
> On 25 January 2011 06:47, Malachi  wrote:
>
>>
>> Curious as to why when looking in the land section of search, if you
>> reorder the list of areas too quickly it says you are blocked from
>> searching because you have done too many searches. Please try again in a
>> few minutes. I only ran one search. all i did was sort by name or by size.
>> Shouldn't this be pulling the list and storing it. instead of researching
>> each time the list is sorted?
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>>
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] (no subject)

[Yoz Grahame]

Which viewer was this in? As far as I know, there's no such limit in viewer
2 search.

On 25 January 2011 06:47, Malachi  wrote:

>
> Curious as to why when looking in the land section of search, if you
> reorder the list of areas too quickly it says you are blocked from
> searching because you have done too many searches. Please try again in a
> few minutes. I only ran one search. all i did was sort by name or by size.
> Shouldn't this be pulling the list and storing it. instead of researching
> each time the list is sorted?
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/
---

(Updated Jan. 25, 2011, 3:09 p.m.)


Review request for Viewer.


Changes
---

Thanks Boroondas,
Removed 'disable', 'push', 'default' after pop.
Cleaned and Rebuilt lscript_compile project Compiled with out error.


Summary
---

Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
applies workaround documented at:
http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings

Depends on vwr-24610 which should be applied first.


This addresses bug vwr-24612.
http://jira.secondlife.com/browse/vwr-24612


Diffs (updated)
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/122/diff


Testing
---

Before (snip)
1>C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\stdint.h(81): 
warning C4005: 'UINT32_MAX' : macro redefinition
1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
After patch applied:
1>-- Build started: Project: lscript_compile, Configuration: Release Win32 
--
1>  lscript_bytecode.cpp
1>  lscript_error.cpp
1>  lscript_resource.cpp
1>  lscript_scope.cpp
1>  lscript_tree.cpp
1>  lscript_typecheck.cpp
1>  indra.y.cpp
1>  indra.l.cpp
1>  lscript_compile.vcxproj -> 
C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: TestCapabilityProvider build fix.

[Nyx Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/123/#review256
---

Ship it!


Looks good to me

- Nyx


On Jan. 25, 2011, 1:26 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/123/
> ---
> 
> (Updated Jan. 25, 2011, 1:26 p.m.)
> 
> 
> Review request for Viewer and Nyx Linden.
> 
> 
> Summary
> ---
> 
> Fixed TestCapabilityProvider build issue.
> 
> 
> Diffs
> -
> 
>   indra/newview/tests/llcapabilitylistener_test.cpp 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/123/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/
---

Review request for Viewer.


Summary
---

This patch fulfils STORM-643 by putting a copy of the mini-map control into the 
top of the Nearby tab of the People panel.  Both this and the mini-map can be 
open at the same time.  While working on this a bug was noticed in the hovertip 
of the minimap and a solution proposed for that as well although that adds a 
translation task.  Some of the code from llfloatermap.cpp is actually 
duplicated here without removing the code from there.  This doesn't have an 
effect since the control is pushed to the back in llfloatermap.cpp.  The code 
duplication could be removed from llfloatermap.cpp (the original source) but 
that may affect something I'm not aware of.


This addresses bug STORM-643.
http://jira.secondlife.com/browse/STORM-643


Diffs
-

  indra/newview/llfloatermap.cpp 26c09ad4293e 
  indra/newview/llnetmap.h 26c09ad4293e 
  indra/newview/llnetmap.cpp 26c09ad4293e 
  indra/newview/llpanelpeople.h 26c09ad4293e 
  indra/newview/llpanelpeople.cpp 26c09ad4293e 
  indra/newview/skins/default/xui/en/floater_map.xml 26c09ad4293e 
  indra/newview/skins/default/xui/en/panel_people.xml 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/124/diff


Testing
---

This patch seems to work fine and tested under by compiling and running under 
Windows 7.0 (64) and Ubuntu Linux.

Tested by having all combinations of mini-map (existing) open and closed, 
having the people panel open on all of the different tabs with the only effect 
on the Nearby tab, and having the panel docked in sidebar and not docked.  The 
highlighting of avatars that are selected in the avatar list only affect the 
copy of the mini-map displayed there.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: TestCapabilityProvider build fix.

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/123/
---

Review request for Viewer and Nyx Linden.


Summary
---

Fixed TestCapabilityProvider build issue.


Diffs
-

  indra/newview/tests/llcapabilitylistener_test.cpp 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/123/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-2 test build

[Garmin Kawaguichi]

I wrote

>>> but you could do the same for Advanced Debug Settings 

I'm bad there :((

Advanced Debug Settings works fine

GCI___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Tuesday, January 25

[Anya Kanevsky]

Tuesday, January 25, 2011 General Notes
--

   - MMOTD: Oz
   - Q is on the way to SF so OOO all day.
  - “Q flies through sheer force of will, the plane just follows” © Gez

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-745 : Perf baseline : Completed for all platforms. Updated wiki.
   Moved to review.
   - STORM-748 : Use KDU_X86_INTRINSICS : Results were actually worse with
   than without (i.e. KDU slower with that option). We won't be using it then.
   Updated wiki. Moved to review for closing.
   - SH-761, etc : rapidly checked the merge done by Bao

*FUTURE*

   - OH and SNOW triaging
   - STORM-749 : Alpha in KDU

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - More updates to Third Party Viewer Directory
   - Merge Monkey
   - Patch triage from codereview
   - Cataloging viewer dependencies

*FUTURE*

   - Merge Monkey
   - Review viewer autobuild usage & docs

*IMPEDIMENTS*

   - none

Q Linden
--

   - OOO - travel

Paul ProductEngine
--

*PAST*

   - Finished with configuring SL in Ubuntu
   - BUG STORM-351 (Scrolling flat list by mouse wheel changes zoom level
   in-world)
  - WIP. For now it's hard to give any estimates, I'm investigating this
  issue. But don't think it'll take much time.

*FUTURE*

   - BUG STORM-351 (Scrolling flat list by mouse wheel changes zoom level
   in-world)
   - BUG STORM-513 ("Allow media to auto - play" check-box is enable after
   Media check-box was unchecked)

*IMPEDIMENTS*

   - none

Seth Productengine
--

*PAST*

   - Story (STORM-526) Log out failure during Login causes loss of pending
   offers, including inventory
  - Investigating new logs provided in jira. Could not figure out the
  cause of the problem.
   - BUG (STORM-843) Inventory incremental string search not working (search
   starts over)
  - Fixed. Sent for review.

*FUTURE*

   - BUG (STORM-397) Dropping wearables from a notecard to COF should be
   prohibited
  - Estimated: 4 hours.
   - BUG (STORM-379) Content permissions aren't refreshed in the "Buy copy
   of" floater
  - Estimated: 6-8 hours.

*IMPEDIMENTS*

   - BUG (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by
   Name/System Folders to Top Do not apply and settings changes do not persist
   after relogging.
  - Waiting for product owner answers.

Vadim Productengine
--

*PAST*

   - Bug STORM-610 (Changes to Environment Editor: water color change is not
   saved):
  - working on solution. It's a bit more than just fixing a bug: I'm
  effectively implementing persistent preset selection
(STORM-326), but there
  seems to be no other way.
   - Filed SVC-6706 (No way to determine whether a script in agent inventory
   is compiled to Mono).

*FUTURE*

   - STORM-610 (ETA: 1-2d)

*IMPEDIMENTS*

   - Need PO answer in STORM-2 (Customizable viewer layouts).

Andrey ProductEngine
--

*PAST*

   - picked up 2.5.0 Beta2 219342 build
   - smoke & integrity tests have been passed
   - started Beta2 bug-fixes verification

*FUTURE*

   - run regression suite against Beta2

*IMPEDIMENTS*

   - clarify regression scope with Bambers

Jonathan Yap
--

*PAST*

   - STORM-845 (Up arrow icon on nearby chat for "Shows/hides nearby chat
   log" always shows as an up arrow. Should change to down arrow to indicate
   close when log is open)
  - Done.

*FUTURE*

*IMPEDIMENTS*

   - None

Wolfpup Lowenhar
--

*PAST*

   - Worked @ RL and in world.
   - STORM-236 : now is fully working and had Oz do test builds on TC. also
   worked on debuging issue with loss of resizability when disabeling
   Voice(hiding Speak button)

*FUTURE*

   - Work @ RL and in world.
   - STORM-236 :Conttinue deguning loss of resize of nearby chat.
   - VWR-24256 : continue to monitor.

*IMPEDIMENTS*

   - Not enough time between working in-world and at real job to actually
   work on code.


Cummere Mayo
--

*PAST*

   - followed up on some vwr issues
   - tested the storm-2 test build and provided feedback on the jira.
   - created VWR-24611 as a result of storm-2 testing
   - tested firestorm test build for comparison to currant snowstorm builds.
   Noted some nice features I would like to see imported into snowstorm
   - wrote two guest entries for JayR's blog about 1.5/1.6

*FUTURE*

   - viewer testing for develper, developement, and firestorm
   - more jira organization/cleanup
   - more followups on jira

*IMPEDIMENTS*

   - exhausted
   - rl work
   - other commitments
   -
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to ke

Re: [opensource-dev] STORM-2 test build

[Garmin Kawaguichi]

STORM-2 Managed User Interface

I've tested this interesting feature:

Are not managed:
- Button Speak (Enabled or not)
- Edit window (saved open for Build, but not open when Build loaded)
- Advanced Rendering Types and Rendering Features states (I often uncheck 
several items during build)

Feature managed but with little issue:
- I detached the Inventory for Build and People for Chat; they are well 
displayed when I select these states, but for Walking without detached windows 
the last displayed remains (Build, Chat and Walking are categories created for 
the test)

Appreciated:
- Preferences window managed
==>> but you could do the same for Advanced Debug Setting and detached (or 
fixed... er when I click the double line at the top of the menu :) menus to 
create a Tweak Interface

GCI
  - Original Message - 
  From: Philippe (Merov) Bossut 
  To: opensource-dev@lists.secondlife.com 
  Sent: Tuesday, January 25, 2011 3:34 AM
  Subject: [opensource-dev] STORM-2 test build


  Hi,

  Oz build binaries for this project (STORM-2 : As a User, I want to set my own 
default views with specific UI layout so I can tailor my Viewer experience to 
the activities I'm most interested in). 

  They are available here:
 
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-3/rev/219546/index.html

  Cheers,
  - Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Boroondas Gupte]

> On Jan. 25, 2011, 11:30 a.m., Boroondas Gupte wrote:
> > indra/llcommon/llpreprocessor.h, lines 164-167
> > 
> >
> > Isn't the 'pop' sufficient for restoring the previous warning settings? 
> > What purpose do the 'disable', 'push' and 'default' after that serve?
> > 
> > See also OlafvdSpek's comment about the proposed workaround on the page 
> > you linked.
> 
> Nicky Perian wrote:
> I thought I followed the second comment. I could not tell from 
> OlafvdSpek's comments if that was the complete solution or a added to 
> solution.
> 
> Nicky Perian wrote:
> I think the 'disable" 'push", 'default' are to correct later includes 
> causing warnings. But, I can take them out and test it.

As I read it, OlafvdSpek's comment is neither a complete solution, nor does it 
just add something to Maxime Chamley's workaround. It *replaces* a part of 
Maxime's solution:
Instead of
push, disable, (do something for which the warning needs to be 
disabled,) push, default
one should do
push, disable, (do something for which the warning needs to be 
disabled,) pop
so the second 'push' and the 'default' are replaced by just 'pop'.

This makes sense under the assumption that (an educated guess) 'push' records 
the current state of what warnings are enabled and disabled and places it on a 
stack (a FIFO data structure) and 'pop' takes such a record from the stack 
(i.e., reads it and removes it from the stack) and restores the respective 
state. 'default' probably just restores the default value for the specified 
warning type.

So the original workaround has two problems:
* It leaves two recorded states on the stack which might never be used. (Or 
worse, they might not be the ones expected to be on the stack where they'll get 
used.)
* If the enable/disable warning 4005 setting was at its default value before 
this part of the code, everything is fine, as the default will be restored. But 
if the value wasn't the default one, that previous value will be lost and the 
default restored instead anyway.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/#review251
---


On Jan. 25, 2011, 11:12 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/122/
> ---
> 
> (Updated Jan. 25, 2011, 11:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
> applies workaround documented at:
> http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings
> 
> Depends on vwr-24610 which should be applied first.
> 
> 
> This addresses bug vwr-24612.
> http://jira.secondlife.com/browse/vwr-24612
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/122/diff
> 
> 
> Testing
> ---
> 
> Before (snip)
> 1>C:\Program Files (x86)\Microsoft Visual Studio 
> 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition
> 1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
> == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
> After patch applied:
> 1>-- Build started: Project: lscript_compile, Configuration: Release 
> Win32 --
> 1>  lscript_bytecode.cpp
> 1>  lscript_error.cpp
> 1>  lscript_resource.cpp
> 1>  lscript_scope.cpp
> 1>  lscript_tree.cpp
> 1>  lscript_typecheck.cpp
> 1>  indra.y.cpp
> 1>  indra.l.cpp
> 1>  lscript_compile.vcxproj -> 
> C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
> == Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Nicky Perian]

> On Jan. 25, 2011, 11:30 a.m., Boroondas Gupte wrote:
> > indra/llcommon/llpreprocessor.h, lines 164-167
> > 
> >
> > Isn't the 'pop' sufficient for restoring the previous warning settings? 
> > What purpose do the 'disable', 'push' and 'default' after that serve?
> > 
> > See also OlafvdSpek's comment about the proposed workaround on the page 
> > you linked.
> 
> Nicky Perian wrote:
> I thought I followed the second comment. I could not tell from 
> OlafvdSpek's comments if that was the complete solution or a added to 
> solution.

I think the 'disable" 'push", 'default' are to correct later includes causing 
warnings. But, I can take them out and test it.


- Nicky


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/#review251
---


On Jan. 25, 2011, 11:12 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/122/
> ---
> 
> (Updated Jan. 25, 2011, 11:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
> applies workaround documented at:
> http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings
> 
> Depends on vwr-24610 which should be applied first.
> 
> 
> This addresses bug vwr-24612.
> http://jira.secondlife.com/browse/vwr-24612
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/122/diff
> 
> 
> Testing
> ---
> 
> Before (snip)
> 1>C:\Program Files (x86)\Microsoft Visual Studio 
> 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition
> 1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
> == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
> After patch applied:
> 1>-- Build started: Project: lscript_compile, Configuration: Release 
> Win32 --
> 1>  lscript_bytecode.cpp
> 1>  lscript_error.cpp
> 1>  lscript_resource.cpp
> 1>  lscript_scope.cpp
> 1>  lscript_tree.cpp
> 1>  lscript_typecheck.cpp
> 1>  indra.y.cpp
> 1>  indra.l.cpp
> 1>  lscript_compile.vcxproj -> 
> C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
> == Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Nicky Perian]

> On Jan. 25, 2011, 11:30 a.m., Boroondas Gupte wrote:
> > indra/llcommon/llpreprocessor.h, lines 164-167
> > 
> >
> > Isn't the 'pop' sufficient for restoring the previous warning settings? 
> > What purpose do the 'disable', 'push' and 'default' after that serve?
> > 
> > See also OlafvdSpek's comment about the proposed workaround on the page 
> > you linked.

I thought I followed the second comment. I could not tell from OlafvdSpek's 
comments if that was the complete solution or a added to solution.


- Nicky


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/#review251
---


On Jan. 25, 2011, 11:12 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/122/
> ---
> 
> (Updated Jan. 25, 2011, 11:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
> applies workaround documented at:
> http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings
> 
> Depends on vwr-24610 which should be applied first.
> 
> 
> This addresses bug vwr-24612.
> http://jira.secondlife.com/browse/vwr-24612
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/122/diff
> 
> 
> Testing
> ---
> 
> Before (snip)
> 1>C:\Program Files (x86)\Microsoft Visual Studio 
> 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition
> 1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
> == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
> After patch applied:
> 1>-- Build started: Project: lscript_compile, Configuration: Release 
> Win32 --
> 1>  lscript_bytecode.cpp
> 1>  lscript_error.cpp
> 1>  lscript_resource.cpp
> 1>  lscript_scope.cpp
> 1>  lscript_tree.cpp
> 1>  lscript_typecheck.cpp
> 1>  indra.y.cpp
> 1>  indra.l.cpp
> 1>  lscript_compile.vcxproj -> 
> C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
> == Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/#review251
---


I'm not a Windows person, but ...


indra/llcommon/llpreprocessor.h


Isn't the 'pop' sufficient for restoring the previous warning settings? 
What purpose do the 'disable', 'push' and 'default' after that serve?

See also OlafvdSpek's comment about the proposed workaround on the page you 
linked.


- Boroondas


On Jan. 25, 2011, 11:12 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/122/
> ---
> 
> (Updated Jan. 25, 2011, 11:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
> applies workaround documented at:
> http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings
> 
> Depends on vwr-24610 which should be applied first.
> 
> 
> This addresses bug vwr-24612.
> http://jira.secondlife.com/browse/vwr-24612
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/122/diff
> 
> 
> Testing
> ---
> 
> Before (snip)
> 1>C:\Program Files (x86)\Microsoft Visual Studio 
> 10.0\VC\include\stdint.h(81): warning C4005: 'UINT32_MAX' : macro redefinition
> 1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
> == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
> After patch applied:
> 1>-- Build started: Project: lscript_compile, Configuration: Release 
> Win32 --
> 1>  lscript_bytecode.cpp
> 1>  lscript_error.cpp
> 1>  lscript_resource.cpp
> 1>  lscript_scope.cpp
> 1>  lscript_tree.cpp
> 1>  lscript_typecheck.cpp
> 1>  indra.y.cpp
> 1>  indra.l.cpp
> 1>  lscript_compile.vcxproj -> 
> C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
> == Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24610 Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/
---

(Updated Jan. 25, 2011, 11:13 a.m.)


Review request for Viewer.


Changes
---

Link to jira added


Summary (updated)
---

Need additional eyes on this. My first RB.


This addresses bug VWR-24610.
http://jira.secondlife.com/browse/VWR-24610


Diffs
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/121/diff


Testing
---

Compiled with VS2010. Used with another patch around a microsoft bug. Have not 
used with VS 2005


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/122/
---

Review request for Viewer.


Summary
---

Correct marco redefinition warnings introduced in Visual Studio 10. Patch 
applies workaround documented at:
http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings

Depends on vwr-24610 which should be applied first.


This addresses bug vwr-24612.
http://jira.secondlife.com/browse/vwr-24612


Diffs
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/122/diff


Testing
---

Before (snip)
1>C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\stdint.h(81): 
warning C4005: 'UINT32_MAX' : macro redefinition
1>  indra.l.cpp(85) : see previous definition of 'UINT32_MAX'
== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
After patch applied:
1>-- Build started: Project: lscript_compile, Configuration: Release Win32 
--
1>  lscript_bytecode.cpp
1>  lscript_error.cpp
1>  lscript_resource.cpp
1>  lscript_scope.cpp
1>  lscript_tree.cpp
1>  lscript_typecheck.cpp
1>  indra.y.cpp
1>  indra.l.cpp
1>  lscript_compile.vcxproj -> 
C:\lindenhg\vcexpress2010build\indra\build-vc100\lscript\lscript_compile\Release\lscript_compile.lib
== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-643

[Oz Linden (Scott Lawrence)]

On 2011-01-25 1:05, Twisted Laws wrote:
Added a patch to https://jira.secondlife.com/browse/STORM-643 Embed 
Minimap into Nearby list of People Sidebar.   I know I never make the 
meetings that would probably help determine if this would be included 
in the viewer, but it does help make viewer 2 just a little better 
than it was in my opinion.  Additionally, selecting a user in the 
nearby avatar list will highlight the avatar on the minimap.  The 
patch also corrects an error I don't see in the Jira where the minimap 
hovertip is incorrect if double click teleport is enabled. 


This does look like an interesting feature.

It really makes it significantly easier to take patches if you:

   * Create a review on codereview.secondlife.com, properly linked to
 the jira issue (see instructions
 
)
   * Post a public mercurial repository based on viewer-development
 that has the change added.

If you do both, it really makes the process of review _much_ Faster, 
Easier, and More Fun.


I know that it probably seems like significant extra work, but really 
it's pretty simple, and if each contributor does that little bit of 
extra work, the much smaller number of us on the receiving end can 
handle more of them.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/
---

(Updated Jan. 25, 2011, 8:29 a.m.)


Review request for Viewer.


Changes
---

spelling edit


Summary
---

Need additional eyes on this. My first RB.


This addresses bug VWR-24610.
http://jira.secondlife.com/browse/VWR-24610


Diffs
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/121/diff


Testing (updated)
---

Compiled with VS2010. Used with another patch around a microsoft bug. Have not 
used with VS 2005


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/
---

(Updated Jan. 25, 2011, 8:27 a.m.)


Review request for Viewer.


Changes
---

Present in JIRA.


Summary
---

Need additional eyes on this. My first RB.


This addresses bug VWR-24610.
http://jira.secondlife.com/browse/VWR-24610


Diffs
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/121/diff


Testing
---

Complied with VS2010. Used with another patch around a microsoft bug. Have not 
used with VS 2005


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] (no subject)

[Malachi]

Curious as to why when looking in the land section of search, if you  
reorder the list of areas too quickly it says you are blocked from  
searching because you have done too many searches. Please try again in a  
few minutes. I only ran one search. all i did was sort by name or by size.  
Shouldn't this be pulling the list and storing it. instead of researching  
each time the list is sorted?
-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] from debug to prefences

[Oz Linden (Scott Lawrence)]

On 2011-01-24 20:45, Robert Martin wrote:
> On Mon, Jan 24, 2011 at 7:53 PM, Trilo Byte  wrote:
>> Perhaps the experimental/developer-related debug settings should be 
>> accessible from the Developer menu (further removing it from casual users).  
>> Then an 'Advanced Preferences' floater could be made available from the 
>> Advanced Menu.  This would allow for an effort to seriously streamline the 
>> main/basic SL preferences.
> what needs to happen is a full bore IRS level accounting needs to be
> done on which preferences are actually used and which are
> outdated 2.* series prefs (pull these out)
> outdated 1.* series prefs (pull these out)
> oddball but still used prefs
> dangerous prefs
> normal and menu accessable prefs
> power user prefs
> nonlinden admin prefs
> Linden Only Prefs
> TPV prefs that slipped into the stock viewer (was the feature added to 
> stock??)
>
> and then sit down and document what each one of those does (and
> safe/dangerous values for same

Which illustrates nicely the scope of the problem, and explains part of 
why adding options is costly down the road.

The plain fact is that usually the way we discover which preferences are 
used is to remove (or relocate) them and see who screams (we do get 
prefs settings as part of crash reports, but that only tells us what 
people who crash are using).  As far as we can tell, someone always 
does, and correctly or not thinks that we've hopelessly broken something 
critical.

The other problem is that some settings become "folklore": users, for 
whatever reason, become convinced that if you set preference X to Y then 
bad thing Z doesn't happen (or good thing Z does) when in fact there is 
no relationship at all (or, in fairness, we didn't think that there was 
and the relationship itself is a bug).

So... creating the categorized list you suggest is itself a very large 
job, the results of which will be at best controversial and more 
probably just wrong.   That doesn't mean it's not a noble undertaking 
(the most heroic quests are sometimes futile), but it's a tough sell.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-2 test build

[Trilo Byte]

On Jan 25, 2011, at 5:05 AM, Vadim Savchuk wrote:

> On 01/25/2011 02:19 PM, Trilo Byte wrote:
>> Aside from not being very useful in its current state (not being able to 
>> save/load sidebar, local chat text entry width, or save/load build menu 
>> floater), build 219546 (mac client) caused an entire system crash on exit, 
>> resulting in loss of data in other applications.
> Have you experienced such crashes with other builds?
No.  

Early builds of the Mesh Project Viewer experienced crash on exit (CTS-399) but 
that's long since been resolved and never caused a system crash/loss of data.  
The Viewer is known to crash spectacularly (causing entire system crash with 
loss of data in other applications) mid-session on Macs with ATI graphics if 
you try to enable shadows/deferred rendering, but the system I'm using doesn't 
have an ATI graphics card in it, and I made no graphics settings changes during 
the session. Machine was running OSX 10.6 for what that's worth.

>> 
>> The sidebar, local chat entry box, and builder's menu are all essential 
>> parts of the SL user interface.  If comments in the jira are to be believed 
>> and saving the sidebar isn't essential, then you're forcing users to do 
>> something that's not obvious or intuitive (forcing them to take the extra 
>> step of tearing off/positioning a sidebar tab), and making a strong case for 
>> the need to do away with the sidebar altogether.
> I didn't say it was not essential. I said that  it was not originally 
> required by the task description and thus should not prevent PO from 
> approving the first-pass implementation (which will of course be improved by 
> further changes).
So long as those elements are working by the time it makes it as far as beta, 
that should be fine.  Just that as tested, so few UI elements were saved/loaded 
it didn't appear to be of much value (at least in the few basic/common 
scenarios I tested.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] from debug to prefences

[Jonathan Welch]

I just did a little research on what is referenced in settings.xml
(aka debug settings).

I scanned the source code for "gsavedsettings." and then pulled out
the name of what was being accessed.

There are some faults in this approach:
1) some source code lines are split, so with my simple approach I
could not see those settings

2) some settings are accessed via a variable, not a hardcoded name, so
those are also skipped in my analysis

There are 1,106 settings.  I could easily find 800 of them being
accessed.  Thus approximately 25% of these settings appear to be
obsolete.

There are not too many places with split lines or where the setting is
accessed via a variable, so a thorough review could be done if someone
had the interest.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Nicky Perian]

> On Jan. 25, 2011, 3:28 a.m., Jonathan Yap wrote:
> > 1) You should fill in the Bugs field with a Jira number.
> > 
> > 2) Since VS2005 used the 80 code and VS2008 used 90, should you be using 
> > LL_MSVC100?

1. I had thought about jira but, it wasn't a bug of the current code.

2. vc80, vc90, and vc100 are passed to cmake from develop.py but, cmake output 
is MSVC80, MSVC90, AND MSVC10. So, either way is not consistent. The cmake 
output is used more frequently in code than the one time call in develop,py.  


- Nicky


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/#review249
---


On Jan. 25, 2011, 2:41 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/121/
> ---
> 
> (Updated Jan. 25, 2011, 2:41 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Need additional eyes on this. My first RB.
> 
> 
> This addresses bug LL_MSVC10.
> http://jira.secondlife.com/browse/LL_MSVC10
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/121/diff
> 
> 
> Testing
> ---
> 
> Complied with VS2010. Used with another patch around a microsoft bug. Have 
> not used with VS 2005
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-2 test build

[Vadim Savchuk]

On 01/25/2011 02:19 PM, Trilo Byte wrote:
> Aside from not being very useful in its current state (not being able 
> to save/load sidebar, local chat text entry width, or save/load build 
> menu floater), build 219546 (mac client) caused an entire system crash 
> on exit, resulting in loss of data in other applications.
Have you experienced such crashes with other builds?
>
> The sidebar, local chat entry box, and builder's menu are all 
> essential parts of the SL user interface.  If comments in the jira are 
> to be believed and saving the sidebar isn't essential, then you're 
> forcing users to do something that's not obvious or intuitive (forcing 
> them to take the extra step of tearing off/positioning a sidebar tab), 
> and making a strong case for the need to do away with the sidebar 
> altogether.
I didn't say it was not essential. I said that  it was not originally 
required by the task description and thus should not prevent PO from 
approving the first-pass implementation (which will of course be 
improved by further changes).

-- 
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-643

[Opensource Obscure]

Sounds great, could you please attach a snapshot?
Also, in a comment to STORM-643 someone is asking if this would be
meant to be an addition - or if the minimap is supposed to *move* to
the sidebar (ie not an independent floater anymore).

Opensource Obscure

On Tue, Jan 25, 2011 at 07:05, Twisted Laws  wrote:
> Added a patch to https://jira.secondlife.com/browse/STORM-643 Embed Minimap
> into Nearby list of People Sidebar.   I know I never make the meetings that
> would probably help determine if this would be included in the viewer, but
> it does help make viewer 2 just a little better than it was in my opinion.
> Additionally, selecting a user in the nearby avatar list will highlight the
> avatar on the minimap.  The patch also corrects an error I don't see in the
> Jira where the minimap hovertip is incorrect if double click teleport is
> enabled.
>
> I hope you find the patch useful.
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>



-- 
Opensource Obscure

Twitter [EN] - Twitter [IT] - Blog [IT] - YouTube - Photos - Second Life
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-2 test build

[Trilo Byte]

Aside from not being very useful in its current state (not being able to 
save/load sidebar, local chat text entry width, or save/load build menu 
floater), build 219546 (mac client) caused an entire system crash on exit, 
resulting in loss of data in other applications.

The sidebar, local chat entry box, and builder's menu are all essential parts 
of the SL user interface.  If comments in the jira are to be believed and 
saving the sidebar isn't essential, then you're forcing users to do something 
that's not obvious or intuitive (forcing them to take the extra step of tearing 
off/positioning a sidebar tab), and making a strong case for the need to do 
away with the sidebar altogether.

TriloByte Zanzibar

On Jan 24, 2011, at 6:34 PM, Philippe (Merov) Bossut wrote:

> Hi,
> 
> Oz build binaries for this project (STORM-2 : As a User, I want to set my own 
> default views with specific UI layout so I can tailor my Viewer experience to 
> the activities I'm most interested in). 
> 
> They are available here:
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-3/rev/219546/index.html
> 
> Cheers,
> - Merov
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] VWR-3156

[Opensource Obscure]

On Tue, Jan 25, 2011 at 11:17, Jonathan Welch  wrote:
> This functionality was only taken away by default years ago -- you can
> still enable it via (for viewer 2) the debug setting ShowNetStats

It seems to me that VWR-3156 can be safely closed again. It had
been closed in 2008 - I guess it was reopened because the Debug
Setting was renamed and people couldn't find it.

note:
ShowNetStats has currently no effect if Italian language is being used.
workaround:
- switch to English
- restart viewer
- toggle ShowNetStats to TRUE
- switch to Italian
- restart viewer
This clearly is a separate issue that should be filed separately.
It may also affect different languages.

Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/#review249
---


1) You should fill in the Bugs field with a Jira number.

2) Since VS2005 used the 80 code and VS2008 used 90, should you be using 
LL_MSVC100?

- Jonathan


On Jan. 25, 2011, 2:41 a.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/121/
> ---
> 
> (Updated Jan. 25, 2011, 2:41 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Need additional eyes on this. My first RB.
> 
> 
> This addresses bug LL_MSVC10.
> http://jira.secondlife.com/browse/LL_MSVC10
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llpreprocessor.h 26c09ad4293e 
> 
> Diff: http://codereview.secondlife.com/r/121/diff
> 
> 
> Testing
> ---
> 
> Complied with VS2010. Used with another patch around a microsoft bug. Have 
> not used with VS 2005
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] from debug to prefences

[Hitomi Tiponi]

I have been struggling with this on StarLight as well.  My design approach was 
to incorporate many of the debug settings that people seemed to like while also 
keeping a fairly simple approach.  The skill seems to be in allocating them 
into 
a sensible form - so in the end I settled for sub-tabs based on KirstenLee's 
approach - with the main options separated from additional, specific options.  
And can we please ditch ('can' for the Americans) the 'Advanced' tab - it is 
just there for stuff that didn't fit in the other tabs and is hardly 'advanced' 
- much better to give the option in sub-tabs for those that care to explore 
more.  Many of the debug settings don't work anymore so maybe it would be a 
good 
idea to ditch those first.
Hitomi


>one of the things that oz and q have been grousing (to use oz's word) about 
>lately is that there are LOTS of preferences in the debug menu that really 
>don't 
>have debug functions but are preferences.  Both oz and q feel that the 
>>preferences bar is already kind of full though many users want to see more 
>preferences.
>What I propose is kind of a compromise.
>Here's how it would work. We take the existing advanced preferences tab and 
>turn 
>it into a floater activated if you click on where the advanced tab is now. we 
>then bump many of the preferences that are in the debug over.  we >can do it 
>in 
>kinda a category form as the sketch here shows or break it up into tabs.  
>
>This would give the ui more of an mmo like presences control which would not 
>necessarily be a bad thing and give faster, very easy and intuitive access to 
>the more advanced features for those that want them and yet also >allow us to 
>keep both the preferences and debug consoles "clean."  with some careful 
>monitoring and feedback from the users we could then possibly narrow down what 
>settings are not really needed and eliminate them off >this panel and 
>conversely 
>have a space to add new preferences as well.
>I'm sure someone is going to argue that this would just make things more 
>complicated both in the short term and long term. I'm going to attempt to 
>answer 
>those as follows. 
>
>As far as the short term, yes it would. I'm sure it would involve quite a bit 
>of 
>code reworking and discussion and stuff. It would also take users a bit of 
>time 
>to adjust to the changes. 
>
>In the long term, I think it would actually be simpler this way and add to the 
>new user experience. by setting up things this way we could add ui hints 
>and/or 
>tool tips that explain what these preferences do, and if this one >panel gets 
>crowded, i don't think that most users will mind.  in fact those used to mmo's 
>will be kind of expecting it.  in the mean time it gives us a place to part 
>lesser used preferences from the prefences control, and clears >up the debug 
>menu while also making it easier to both move more used features back into the 
>preferences menu and setting up for eventually allowing us to pick and choose 
>what preferences we want where.  
>


  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/121/
---

Review request for Viewer.


Summary
---

Need additional eyes on this. My first RB.


This addresses bug LL_MSVC10.
http://jira.secondlife.com/browse/LL_MSVC10


Diffs
-

  indra/llcommon/llpreprocessor.h 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/121/diff


Testing
---

Complied with VS2010. Used with another patch around a microsoft bug. Have not 
used with VS 2005


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] VWR-3156

[Jonathan Welch]

This functionality was only taken away by default years ago -- you can
still enable it via (for viewer 2) the debug setting ShowNetStats
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] VWR-3156

[Nexii Malthus]

I somewhat agree, actually even brought it back in my own custom client and
added two more bars for time dilation and something else I can't remember at
the moment.

I find that it is mostly superceded by the statistics bar (ctrl-shift-1),
which is easier to relate to and can provide tons of information. Due to
handling numbers, which can provide a lot more information sometimes than a
graph bar.

It would be great if the mini bar graphs would make a comeback. But I think
they might need some improvement so they can be easier to "relate to".

The basic statistics are generally extremely useful for complex software
that cannot provide the utopian perfect experience at all times and are
liable to lag of any form, even for a ton of people that aren't techies and
don't understand the intrinsic nature of computer networks and such. If
people aren't given a source of cause to Lag they become frustrated and feel
helpless to explain to others what might turn out to be a local problem.

It all boils down to taking a quick glance to understand three sources of
most obvious problems that cause "Lag":
- There is a problem with your computer: [FPS]
- There is a problem with your connection: [Ping, Bandwidth, Packet Loss]
- There is a problem with the Sim/LL: [Time Dilation]

- Nexii


On Tue, Jan 25, 2011 at 7:26 AM, Erin Mallory
wrote:

>  VWR-3156 has over 200 votes.  Its asking for the return of the pre-2007
> bandwidth and packetloss quick-glance bars to the viewer toolbars, possibly
> beside search. personally, if there's a need for those, I usually go to the
> stats bar, but there are some compelling arguments in the comments for
> bringing back such a feature, and I myself am wondering if it might prove
> useful myself and other users as well.
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges