Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review463 --- So I've found some underlying problems with text extents measurement and clipping and I'm working on a fix now...hopefully I'll have something tomorrow - Richard On March 4, 2011, 10:30 a.m., Seth ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/ --- (Updated March 4, 2011, 10:30 a.m.) Review request for Viewer and Richard Nelson. Summary --- Fixed text editor to display the embedded widgets only if they are in the currently visible area of a text document. This addresses bug STORM-721. http://jira.secondlife.com/browse/STORM-721 Diffs - indra/llui/lltextbase.cpp 767feb16f05f Diff: http://codereview.secondlife.com/r/169/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Test Build (223545)
Sorry for the delay on this: 2011/3/11 Philippe (Merov) Bossut me...@lindenlab.com Hi there, Here's a new PO test build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/223545/index.html Fixes it contains: * STORM-28 : As a User, I want the ability to send my calling card to others (additional fixes) approved * STORM-357 : Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible approved with note to QA * STORM-399 : Users that has chatted within chat range of the user in-world are not added to Recent tab rejected: objects shouldn't be added to Recent list. * STORM-1019 : Add ability to display beacons for Media on a Prim objects no action: Jonathan made changes according to Ardy's comments. Needs a new build. * STORM-1021 : Viewer shows L$300 instead of object IM details if object sends an IM from another region approved * STORM-1064 : People sidebar panel elements have inconsistent widths and map is slightly too tall approved Thanks for your help in testing! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] A CALL FOR HHHEEELLLPPP
That error message is basically saying you can't assign to a const variable. Line 21 in your paste is reusing file_name, which is one of the method's arguments, and is const. You need a local variable which isn't const there. But, I don't think this makes sense otherwise. In what cases will from_id be null? I would guess you will have no way to recover a name in those cases. If that really happens, I think that's a server bug. I think a better approach is to look for the places that call this method, and make sure it is passed a username and not a legacy name or complete name as its first argument. You can convert a legacy name (but not a complete name!) to a username with the static method LLCacheName::buildUsername(), without needing to look it up in the name cache. I see these occurrences: llgiveinventory.cpp 314:LLIMModel::instance().logToFile(full_name, LLTrans::getString(SECOND_LIFE), im_session_id, LLTrans::getString(inventory_item_offered-im)); llimview.cpp 859:if (log2file) logToFile(session_id, from_name, from_id, utf8_text); 2471: LLIMModel::instance().logToFile(session_name, SYSTEM_FROM, LLUUID::null, message.getString()); llnotificationhandlerutil.cpp 278:LLIMModel::instance().logToFile(session_name, from, from_id, message); /* rant, please ignore... */ Considering the level of scrutiny trivial patches get here, how did the display names code got merged into the viewer in the first place? It made already messy code much more messy and inconsistent. Name-handling methods now rely on the caller knowing which of the different 4-5 kinds a name argument is expected to be (username, legacy (2 kinds of that?), complete, or display). Display and legacy names should have been banished to the lest steps of the chain, leaving them for display only, and everything else should have been converted to usernames, or preferably, a new type (not std::string.) Looks like there was some attempt to do that with LLAvatarName, but logic that depends on knowledge of internals of this class is all over the place. On Wednesday 16 March 2011 03:30:02 WolfPup Lowenhar wrote: First References: Jira : https://jira.secondlife.com/browse/STORM-941 Code Snippet : http://codepad.org/9cVTMJTD Now the problem: When I compile the code I get error C2678: binary '=' : no operator found which takes a left-hand operand of type 'const std::string' (or there is no acceptable conversion) in reference to line 21of the code snippet. I need to be able to force the user name in this case. Here is how this case can happen: PersonA dose not use Display Names or is on a non-Display Names viewer. PersonB dose use Display Names and also keeps logs of all chat, Group and P2P messages. PersonA offers PersonB and inventory item after PersonA has talked to PersonB in P2P conversation. PersonB checks their logs later to read about item again to discover there are now two logs for the same person one log is using the Legacy name and contains only the system message about the inventory offer while the other log that is named using the user name contains the conversation about that item. -- Thickbrick ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Daily Scrum Summary - Tuesday, March 15
Sprint 12, ends 03.21.11 Tuesday, March 15 General Notes
--
- MMOTD: Oz
Team Status
--
Merov Linden
--
*PAST*
- STORM-1023 and STORM-1022 : fmod : gave up on Copy3rdPartyLibs.cmake
changes. Posted an RB.
- Moved to review state.
- OPEN-22: discussed with Oz and assigned to him
- Merging viewer-autobuild:
- oz_linden/viewer-autobuild: Fixed Mac failures. Fixes done on cmake
scripts for cares and jpeg libs.
- viewer-autobuild2010: created a fork from
oz_linden/viewer-autobuild2010, pulled z_linden/viewer-autobuild, pulled
jenn_linden/viewer-vs2010, build locally OK, created TC tasks.
Mac build OK,
failures on Windows and Linux.
*FUTURE*
- viewer-autobuild2010: fix Linux and Windows build
- STORM-1023 : fmod : answer RB feedback
*IMPEDIMENTS*
- none
Oz Linden
--
*PAST*
- Merge Monkey - prepping next beta
- discussed autobuild integration strategy with Merov
*FUTURE*
- many meetings
- find something useful to do for autobuild integration
*IMPEDIMENTS*
- none
Bao Linden
--
*PAST*
- OOO
*FUTURE*
- wrap up STORM-973
- further investigation on STORM-948
- start STORM-946 if possible.
*IMPEDIMENTS*
- none
Wolf Linden
--
*PAST*
- Met with Grumpity
- Storm-1068
- Storm-1077
*FUTURE*
- Going through issues to update status
*IMPEDIMENTS*
- none
Grumpity ProductEngine
--
*PAST*
- VWRs don’t have TestPlan field. Any objections to all?
- review with Wolf: STORM-1065, “Voice Enabled” = STORM-1077, STORM-1068
- STORM-951 - bug queue
- tested PO build
*FUTURE*
- make sure PO build is processed
- triage STORM VWR
- meet with Geo
- discuss storm-1016 with Wolf
- add Bao to Snowstorm in jira
- everybody emails?
*IMPEDIMENTS*
- none
Paul ProductEngine
--
*PAST*
- BUG STORM-1057 ([TRUNCATION/LAYOUT] Make space larger for full strings
to appear in the Move View Preferences, ALL langs)
- WIP. 90%. Estimate ~ 1 hour.
*FUTURE*
- STORM-1057 ([TRUNCATION/LAYOUT] Make space larger for full strings to
appear in the Move View Preferences, ALL langs)
- STORM-1066 (Top Scripts/Top Colliders filter needs to be updated for
Display Names)
*IMPEDIMENTS*
- Go home earlier today. Very unproductive day. Fell ill.
Seth ProductEngine
--
*PAST*
- BUG (STORM-250) Unexpected More text appears in the About Landmark
panel after minimizing the floater
- Working on the expandable text box resizing behavior fix. The fix
needs some more testing.
*FUTURE*
- BUG (STORM-250) Unexpected More text appears in the About Landmark
panel after minimizing the floater
- Estimated: 3 - 4 hours
- BUG (STORM-1065) Shared calling card is placed into Friends/All folder
Estimated: 2 - 3 hours
*IMPEDIMENTS*
- BUG (STORM-721) Information about resident is displayed incorrectly in
mini-inspector if there are any resident or group SLURLs
- Waiting for Richard's feedback on the review board.
Vadim ProductEngine
--
*PAST*
- Bug STORM-971 ('Stop Tracking' after you stopped tracking in Nearby
mini-map):
-
Fixed; got it approved.
- Bug STORM-1016 (Crash: ctrl-shift-w hides undocked Side Bar panels if
almost any floater is opened):
-
Investigasted a related issue according to Grumpity's feedback and
haven't found a perfect solution. Need PO to decide how to fix
it (see JIRA
for details).
*FUTURE*
- Bugs.
- Code review.
*IMPEDIMENTS*
- Need a PO decision for STORM-1016 (Crash: ctrl-shift-w hides undocked
Side Bar panels if almost any floater is opened).
Andrey ProductEngine
--
*PAST*
- tested IQA-93, verified all tickets except 3 crashes. See IQA-93 for
more details
- continued with v-d regression testing
*FUTURE*
- lightweight viewer beta testing?
- verify couple of reviewing tickets
*IMPEDIMENTS*
- none
Wolfpup Lowenhar
--
*PAST*
- RL work.
- Trying to earn $L's inworld.
- OPEN-37: Works some what with NickyP's repository have not as yet
tested against Oz's as there are no VC10 setting there as yet.
- STORM-941 : testing viewer with patch
- STORM-1023 : edited my comment in jira to better explain the exact
steps I as an OS developer had to take to
*FUTURE*
- RL work.
- Trying to earn $L's inworld.
- OPEN-37: Run more local tests using NickyP's boost files
*IMPEDIMENTS*
- getting VS2010 autobuild environment to work on my system better,
Vs2005 autobuild works just fine.
- May need to upgrade personal system(CPU, System Board, and Memory) to
work better
Re: [opensource-dev] Review Request: a try fix and debug code for STORM-973:[crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/#review464 --- Just making sure I understood this: Are the changes indra/newview/llviewertexturelist.cpp http://codereview.secondlife.com/r/202/#comment343 and indra/newview/llviewertexturelist.cpp http://codereview.secondlife.com/r/202/#comment344 the actual fix? I.e. are all other changes in this review request just addition of debug code that will be removed again? - Boroondas On March 15, 2011, 1:54 p.m., Xiaohong Bao wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/ --- (Updated March 15, 2011, 1:54 p.m.) Review request for Viewer. Summary --- this is the fix including some debug code for STORM-973. The debug code will be removed after the fix is confirmed. This addresses bug STORM-973. http://jira.secondlife.com/browse/STORM-973 Diffs - indra/newview/llviewertexturelist.h 27984babd61a indra/newview/llviewertexturelist.cpp 27984babd61a Diff: http://codereview.secondlife.com/r/202/diff Testing --- Thanks, Xiaohong ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected More text appears in the About Landmark panel after minimizing the floater
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review465
---
Apart from the bugfix (calling hideExpandText before evaluating
(getTextPixelHeight() getRect().getHeight()), if I'm not mistaken), the
change between the first and second review request revision also changes an
if-else construct to a ternary conditional operator (:?) :
indra/newview/llexpandabletextbox.cpp
http://codereview.secondlife.com/r/198/#comment345
Here, if-else is in my opinion easier to read than the ternary conditional
operator. Usage of the ternary conditional operator is nice when only a small
part of a long expression depends on the condition and one doesn't want a
temporary variable for storing that conditional part, but that really isn't the
case here.
About the complete method after the second review revision:
indra/newview/llexpandabletextbox.cpp
http://codereview.secondlife.com/r/198/#comment346
Should hideExpandText really be called a second time? Or would it be
prudent to just do nothing when getTextPixelHeight() = getRect().getHeight()
after calling it the first time?
Also, the new method's name is somewhat confusing. From a function named
togglesome boolean property I'd expect to change some boolean property at
each call, i.e., always make it true if it previously was false and vice versa.
Name suggestions:
toggleExpandTextAsNeeded
toggleExpandTextIffNeeded
hideOrShowExpandTextAsNeeded
or maybe TextExpander instead of ExpandText in any of the above?
(Feel free to come up with better ones.)
So the new method might become something like
void LLExpandableTextBox::LLTextBoxEx::hideOrShowExpandTextAsNeeded()
{
// Restore the text box contents to calculate the text height properly,
// otherwise if a part of the text is hidden under More link
// getTextPixelHeight() returns only the height of currently visible
text
// including the More link.
hideExpandText();
// Show the expander if we need it, depending on text
// contents height. If not, keep it hidden.
if (getTextPixelHeight() getRect().getHeight())
{
showExpandText();
}
}
- Boroondas
On March 15, 2011, 9:21 a.m., Seth ProductEngine wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
(Updated March 15, 2011, 9:21 a.m.)
Review request for Viewer.
Summary
---
Fixed More link being toggled in expandable textbox after reshaping.
This addresses bug STORM-250.
http://jira.secondlife.com/browse/STORM-250
Diffs
-
indra/newview/llexpandabletextbox.h b761ed94eb26
indra/newview/llexpandabletextbox.cpp b761ed94eb26
Diff: http://codereview.secondlife.com/r/198/diff
Testing
---
Thanks,
Seth
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode
Just wanted to second OO's comments. I concur that this is a great step towards easing the newbie experience. The basic mode shows great promise. I too would like to see more on this subject. Well done to the Dev team! -- Tinsel Silvera Spoke n' Cog, Owner - Second Life Open Sim Virtual World Travels - http://www.tinselsilvera.com Spoke n' Cog Marketplace - https://marketplace.secondlife.com/stores/31?id=31 - Original Message - From: opensource-dev-requ...@lists.secondlife.com To: opensource-dev@lists.secondlife.com Sent: Wed, 16 Mar 2011 14:30:40 - (UTC) Subject: opensource-dev Digest, Vol 14, Issue 55 -- Message: 2 Date: Wed, 16 Mar 2011 15:13:42 +0100 From: Opensource Obscure opensourceobsc...@gmail.com Subject: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode To: OpenSource Mailing List opensource-dev@lists.secondlife.com Message-ID: aanlktikvf_qjrrtsqe9w_c8rgfj9tq1ry6fb4pehu...@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1 So I just read this Twitter message by notre ami Merov: Trying the last Snowstorm 2.6.1 (http://bit.ly/hEA4Y1) containing the new launch 'Mode' drop down. 3 'Basic' for discovering new places I downloaded that build and logged in Basic Mode. It's awesome. I feel this is a great idea that will work well for a lots of people and will make the first approach with SL easier. It took me by surprise, so I guess I must have missed some conversations about it. Where can I find more details about how it got designed? An approximative reference to subject of mailing list discussions or wiki pages would be enough. If you didn't do it yet, try Basic Mode by choosing it at Login screen. Be sure to use Latest Development Viewer http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/latest.html -- Opensource Obscure http://twitter.com/oobscure - http://opensourceobscure.com/lol ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1016: a call for comments
On Wed, Mar 16, 2011 at 11:06, Anya Kanevsky akanev...@productengine.com wrote: I'm trying to make a decision on the most logical behavior for ctrl-shift-w shortcut in STORM-1016. Currently we have some weird exceptions, most unexpected being that we have some floaters that only close on ctrl-shift-w if there's another, closeable floater present. My proposal is in the last comment to the jira. If you have an opinion on the matter and some usage scenarios to back it up, please let me know. I don't promise to make everyone happy, but I'm trying to see if there are use cases I'm missing. I'd love if ctrl-shift-w acted like a toggle - that is, press it once to make the floaters disappear; press it again to make them reappar (hopefully in the same place). I think this behaviour would be easy to understand for a number of users, because it mimics the Show Desktop feature offered by both Windows and Linux environments. Should this be filed as a separate request? Opensource Obscure ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Second Life 2.6.1 223988 fails to initialize
so... this is something I've not seen before... I have installed and reinstalled this version (2.6.1 223988)twice now and it still gives me this error: Secondlifedevelopment.exe: this application failed to initialize. Press OK to terminate application. Any thoughts or help? ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: a try fix and debug code for STORM-973:[crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/#review467 --- Please submit what the fix will be *without* the hacky code put in there for debugging (as it's unclear what it is really). Thanks! - Merov On March 15, 2011, 1:54 p.m., Xiaohong Bao wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/ --- (Updated March 15, 2011, 1:54 p.m.) Review request for Viewer. Summary --- this is the fix including some debug code for STORM-973. The debug code will be removed after the fix is confirmed. This addresses bug STORM-973. http://jira.secondlife.com/browse/STORM-973 Diffs - indra/newview/llviewertexturelist.h 27984babd61a indra/newview/llviewertexturelist.cpp 27984babd61a Diff: http://codereview.secondlife.com/r/202/diff Testing --- Thanks, Xiaohong ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected More text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 16, 2011, 5:19 p.m.) Review request for Viewer. Summary --- Fixed More link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs (updated) - indra/newview/llexpandabletextbox.h b761ed94eb26 indra/newview/llexpandabletextbox.cpp b761ed94eb26 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected More text appears in the About Landmark panel after minimizing the floater
On March 16, 2011, 7:30 a.m., Seth ProductEngine wrote:
So the new method might become something like
void LLExpandableTextBox::LLTextBoxEx::hideOrShowExpandTextAsNeeded()
{
// Restore the text box contents to calculate the text height properly,
// otherwise if a part of the text is hidden under More link
// getTextPixelHeight() returns only the height of currently visible
text
// including the More link.
hideExpandText();
// Show the expander if we need it, depending on text
// contents height. If not, keep it hidden.
if (getTextPixelHeight() getRect().getHeight())
{
showExpandText();
}
}
Yes, there's no need to call hideExpandText() for two times is a row. I like
this version of hideOrShowExpandTextAsNeeded(). Thanks!
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review465
---
On March 16, 2011, 5:19 p.m., Seth ProductEngine wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---
(Updated March 16, 2011, 5:19 p.m.)
Review request for Viewer.
Summary
---
Fixed More link being toggled in expandable textbox after reshaping.
This addresses bug STORM-250.
http://jira.secondlife.com/browse/STORM-250
Diffs
-
indra/newview/llexpandabletextbox.h b761ed94eb26
indra/newview/llexpandabletextbox.cpp b761ed94eb26
Diff: http://codereview.secondlife.com/r/198/diff
Testing
---
Thanks,
Seth
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode
I agree - this is definitely a very big step in the right direction for new residents. So many good things - especially the easy destination guide. But a few observations: 1 - a shame this wasn't implemented using proper skinning instead of a hack on the code. 2 - although you can 'detach' your hair etc. you can't add it back (unless I missed something). 3 - many places give you ncs when you arrive - it took me just 2 tps to find one, and then it tells you to upgrade to 'Advanced' to read it, confusing if you've only been inworld a short time. Maybe a very cut-down inventory may solve this and item 2. 4 - 'no' to point and click movement - there is one journalist in SL that likes that, and he is on his own. The standard way of walking should be introduced right at the start - it is not that difficult. But. all that said I do like it, and I think it should improve retention rates - it also has a nice side-effect of decreasing tp and rez times! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode
A viewer like this is good, but seriously should be part of the SAME viewer as the other use. Simply have it with a button to switch between the Easy, Fast and Fun mode or Advanced mode. The viewer is already like 30 meg to download so, 10 megs more should’nt be a big challenge for most of the users. With that said, its is nice to see an improvement on the UI for new users, but that viewer is VERY limited, with no inventory, no notecard and no landmark, its so limited, user will only be able to visit your spotlight places. There is not even group in that viewer. From: Hitomi Tiponi Sent: Wednesday, March 16, 2011 8:28 PM To: Opensource_dev Subject: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode I agree - this is definitely a very big step in the right direction for new residents. So many good things - especially the easy destination guide. But a few observations: 1 - a shame this wasn't implemented using proper skinning instead of a hack on the code. 2 - although you can 'detach' your hair etc. you can't add it back (unless I missed something). 3 - many places give you ncs when you arrive - it took me just 2 tps to find one, and then it tells you to upgrade to 'Advanced' to read it, confusing if you've only been inworld a short time. Maybe a very cut-down inventory may solve this and item 2. 4 - 'no' to point and click movement - there is one journalist in SL that likes that, and he is on his own. The standard way of walking should be introduced right at the start - it is not that difficult. But. all that said I do like it, and I think it should improve retention rates - it also has a nice side-effect of decreasing tp and rez times! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode
Played with it a bit more and am now less worried about my point 4 as the 'How To' describes walking the normal way. There is the oddity that you can get the inventory to appear if you get given an object, rather than a nc - but then there is no way to get it back again - can see that will need a bit more work. But am still pretty happy with it. From: Hitomi Tiponi hitomi.tip...@yahoo.co.uk To: Opensource_dev opensource-dev@lists.secondlife.com Sent: Thu, 17 March, 2011 0:28:51 Subject: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode I agree - this is definitely a very big step in the right direction for new residents. So many good things - especially the easy destination guide. But a few observations: 1 - a shame this wasn't implemented using proper skinning instead of a hack on the code. 2 - although you can 'detach' your hair etc. you can't add it back (unless I missed something). 3 - many places give you ncs when you arrive - it took me just 2 tps to find one, and then it tells you to upgrade to 'Advanced' to read it, confusing if you've only been inworld a short time. Maybe a very cut-down inventory may solve this and item 2. 4 - 'no' to point and click movement - there is one journalist in SL that likes that, and he is on his own. The standard way of walking should be introduced right at the start - it is not that difficult. But. all that said I do like it, and I think it should improve retention rates - it also has a nice side-effect of decreasing tp and rez times! ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected More text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review470 --- You're welcome, and thank you, too. :-) indra/newview/llexpandabletextbox.h http://codereview.secondlife.com/r/198/#comment350 Even if the name of the method is now more descriptive, its doxygen documentation should provide at least as much or even more information. Maybe 'Shows the More link if the text is too high to be completely visible without expanding the text box. Hides that link otherwise.' ( Inspired by both versions of this comment: ) indra/newview/llexpandabletextbox.cpp http://codereview.secondlife.com/r/198/#comment351 indra/newview/llexpandabletextbox.cpp http://codereview.secondlife.com/r/198/#comment348 The comments speak of a 'More link' and a 'expander', but never mention that those terms actually mean the same thing. (Or that one is an example for the other, or whatever the case is.) Appending 'a.k.a. More link' after the word 'expander' on line 198 would probably be sufficient to hint at the relationship. - Boroondas On March 16, 2011, 5:19 p.m., Seth ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 16, 2011, 5:19 p.m.) Review request for Viewer. Summary --- Fixed More link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs - indra/newview/llexpandabletextbox.h b761ed94eb26 indra/newview/llexpandabletextbox.cpp b761ed94eb26 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/213/ --- Review request for Viewer and Alain Linden. Summary --- Extended the __call__ method of Executable to pass in the command type as a string and the dry_run flag so that the logging of the command being run could use the infrastructure there to exactly assemble the options and arguments for the logging of the command to be run. The callers then don't need to do the logging separately or do anything with dry_run other than pass it down to the executable. This addresses bug open-45. http://jira.secondlife.com/browse/open-45 Diffs - autobuild/autobuild_tool_build.py abc1014d5ad6 autobuild/autobuild_tool_configure.py abc1014d5ad6 autobuild/executable.py abc1014d5ad6 Diff: http://codereview.secondlife.com/r/213/diff Testing --- Thanks, Oz ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode
This is a great move, we've been looking forward to this for years. Am thinking hot swap between modes without a restart could be a plus, a separate smaller basic client could also be desirable ...I think. one thing though, when I launched 2.6.1 in the basic mode, clicking on myavatar just produces a frame which does not contain anything ... is this normal? How can I populate it with options ... R On Wed, Mar 16, 2011 at 9:25 PM, Yoz Grahame y...@lindenlab.com wrote: On 16 March 2011 17:45, Patnad Babii djs...@hotmail.com wrote: A viewer like this is good, but seriously should be part of the SAME viewer as the other use. Simply have it with a button to switch between the Easy, Fast and Fun mode or Advanced mode. The viewer is already like 30 meg to download so, 10 megs more should’nt be a big challenge for most of the users. Good news! It *is* part of the same viewer! (At least, that's the plan.) You can switch between Basic and Advanced mode on the login screen. Switching currently requires a viewer restart; we're looking into ways to make that easier, though that may not be achievable for the 2.6 release. With that said, its is nice to see an improvement on the UI for new users, but that viewer is VERY limited, with no inventory, no notecard and no landmark, its so limited, user will only be able to visit your spotlight places. There is not even group in that viewer. Yep - we're deliberately keeping it very simple so that newcomers aren't overwhelmed with controls, and have less to learn before being rewarded with a positive initial experience. The emphases are on basic movement, chatting, making friends and seeing the sights. Once they're comfortable and willing to explore further or get more involved, switching to Advanced mode only requires a restart. -- Yoz ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- 'Consider how the lilies grow. They do not labor or spin.' *Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho State University, Pocatello, ID 83209 Tel: 208-282-5333 Blog http://deepsemaphore.posterous.com/, LinkedInhttp://www.linkedin.com/in/rameshramloll , Play2Train http://www.play2train.org ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
