Re: [opensource-dev] Review Request: Fixes paste action in editor windows.
On May 11, 2012, 6:20 a.m., Oz Linden wrote: indra/llui/lltexteditor.h, line 242 http://codereview.secondlife.com/r/579/diff/1/?file=7859#file7859line242 It would be much clearer when reading calls to this method if the parameter were an enum rather than a boolean. Consider the readability difference between: addLineBreakChar(FALSE); and addLineBreakChar(DoNotGroupLines); This would require additional, and IMO, inelegant code to set an additional boolean variable in the function. A comment would make it equally, if not more, clear and not require unnecessary code or an enum. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/#review1219 --- On May 5, 2012, 8:06 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/ --- (Updated May 5, 2012, 8:06 p.m.) Review request for Viewer. Description --- Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting text is a single action as far as Undo is concerned. This is an updating of Satomi Ahn's patch to work with v3.3.1. This addresses bug VWR-20553. Diffs - doc/contributions.txt 3142ebd0bc5a indra/llui/lltexteditor.h 3142ebd0bc5a indra/llui/lltexteditor.cpp 3142ebd0bc5a Diff: http://codereview.secondlife.com/r/579/diff/diff Testing --- Tried pasting/undoing. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Fixes paste action in editor windows.
On May 11, 2012, 6:20 a.m., Oz Linden wrote: indra/llui/lltexteditor.h, line 242 http://codereview.secondlife.com/r/579/diff/1/?file=7859#file7859line242 It would be much clearer when reading calls to this method if the parameter were an enum rather than a boolean. Consider the readability difference between: addLineBreakChar(FALSE); and addLineBreakChar(DoNotGroupLines); Ima Mechanique wrote: This would require additional, and IMO, inelegant code to set an additional boolean variable in the function. A comment would make it equally, if not more, clear and not require unnecessary code or an enum. After adding the diff with comments, it occurred to me a constant could also be used. addLineBreakChar(GROUP_LINES); - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/#review1219 --- On May 13, 2012, 10:15 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/ --- (Updated May 13, 2012, 10:15 p.m.) Review request for Viewer. Description --- Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting text is a single action as far as Undo is concerned. This is an updating of Satomi Ahn's patch to work with v3.3.1. This addresses bug VWR-20553. Diffs - doc/contributions.txt 3142ebd0bc5a indra/llui/lltexteditor.h 3142ebd0bc5a indra/llui/lltexteditor.cpp 3142ebd0bc5a Diff: http://codereview.secondlife.com/r/579/diff/diff Testing --- Tried pasting/undoing. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Fixes paste action in editor windows.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/ --- Review request for Viewer. Description --- Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting text is a single action as far as Undo is concerned. This is an updating of Satomi Ahn's patch to work with v3.3.1. This addresses bug VWR-20553. Diffs - doc/contributions.txt 3142ebd0bc5a indra/llui/lltexteditor.h 3142ebd0bc5a indra/llui/lltexteditor.cpp 3142ebd0bc5a Diff: http://codereview.secondlife.com/r/579/diff/diff Testing --- Tried pasting/undoing. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Fixes paste action in editor windows.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/579/ --- (Updated May 5, 2012, 8:06 p.m.) Review request for Viewer. Description --- Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting text is a single action as far as Undo is concerned. This is an updating of Satomi Ahn's patch to work with v3.3.1. This addresses bug VWR-20553. Diffs - doc/contributions.txt 3142ebd0bc5a indra/llui/lltexteditor.h 3142ebd0bc5a indra/llui/lltexteditor.cpp 3142ebd0bc5a Diff: http://codereview.secondlife.com/r/579/diff/diff Testing --- Tried pasting/undoing. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] data_online's new requirements
I've heard DATA_ONLINE will now only work for the owner or the creator of the script. Shouldn't that be instead owner or compiler of the script? Any full permission script already written could be used and recoded as a status finder, and I have a feeling this will be what people move to for stalking if it goes by script creator. I share this concern whole heartedly. The idea of compiler instead of creator is a good one, I think. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 25, 2011, 3:15 p.m.) Review request for Viewer. Changes --- Updated to fix the Windows UI problem. It was caused by the dialogue filter info having been removed at some point. Hopefully, this fixes the problem *without* breaking anything else ;-) Description --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/llui/lltexteditor.h a1319d553db9 indra/llui/lltexteditor.cpp a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 indra/newview/skins/default/xui/en/strings.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Dec. 8, 2011, 11:08 a.m., Oz Linden wrote: indra/newview/skins/default/xui/en/strings.xml, line 430 http://codereview.secondlife.com/r/516/diff/6/?file=7488#file7488line430 fix indentation Unfortunately, I had to fix this manually, as VC10 is not using a tab here as it should. Consequently, on saving my plain text editor removed all the trailing white space, so you have more clean-up than expected ;-) - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1115 --- On Dec. 8, 2011, 2:45 a.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 8, 2011, 2:45 a.m.) Review request for Viewer. Description --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - doc/contributions.txt a1319d553db9 indra/llui/lltexteditor.h a1319d553db9 indra/llui/lltexteditor.cpp a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 indra/newview/skins/default/xui/en/strings.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 8, 2011, 2:45 a.m.) Review request for Viewer. Changes --- This is, hopefully, the final diff. It brings together the UI additions for Linux, Mac, and Windows. As discussed in IRC and here I've removed the TAB replacement code, as this is wider problem which needs to be addressed separately. Description --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/llui/lltexteditor.h a1319d553db9 indra/llui/lltexteditor.cpp a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 indra/newview/skins/default/xui/en/strings.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima Mechanique ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 22, 2011, 5:17 p.m.) Review request for Viewer. Changes --- This should complete the Windows functionality. Tabs are now dealt with (replaced with spaces) as per standard behaviour for the script editor. I'm starting work on adding the UI changes for Linux/Mac next. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/llui/lltexteditor.h a1319d553db9 indra/llui/lltexteditor.cpp a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Nov. 19, 2011, 5:54 a.m., Lance Corrimal wrote: I've put the last revision (4) in, and it still doesn't add .lsl to filenames on saving... I'm building on linux here, maybe that's the reason? This is mostly a Window's feature, at this time. The .lsl filter is part of a Window's only code path, there exists a Darwin code-path too, but I haven't done any work in that yet (no Mac to develop with). As far as I can see, there is no Linux specific code-path for the dialogues, so I'm not sure what can be done there. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1081 --- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: found another glitch: I'm developing scripts in eclipse with lslforge. When I compile a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 --- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: found another glitch: I'm developing scripts in eclipse with lslforge. When I compile a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). Ima Mechanique wrote: I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. Ima Mechanique wrote: Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 --- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: Built it into dolphin 3.2 beta, tested it. found a few issues: - main menu option Build/Upload/Script does nothing at all - saving a script that you open from your inventory to disk only works after you edit the script - saving a script to disk does not add .lsl to the filename by default Thanks for the feedback. - The Build = Upload = Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. - Hmm, .lsl should be added by default, I'll look into this. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 --- On Nov. 17, 2011, 3:08 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 17, 2011, 3:08 p.m.) Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 1:21 p.m.) Review request for Viewer. Changes --- Reverted Build = Upload menu change. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: Built it into dolphin 3.2 beta, tested it. found a few issues: - main menu option Build/Upload/Script does nothing at all - saving a script that you open from your inventory to disk only works after you edit the script - saving a script to disk does not add .lsl to the filename by default Ima Mechanique wrote: Thanks for the feedback. - The Build = Upload = Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. - Hmm, .lsl should be added by default, I'll look into this. Kelly Washington wrote: Unless opening the script from file automatically saves (uploads and compiles) the script then it makes more sense for the save button to be enabled as soon as the script is loaded. No need to wait for an edit to enable the save. @Kelly. No it doesn't upload and save, that would be the job for the Build = Upload = Script entry that I'm also working on separately. So far as my own testing, uploading a file into the window does automatically enable the save to inventory button. The saving that Lance mentioned is for saving to disc, which is not automatically enabled, currently, unless the script's state is not clean. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 --- On Nov. 18, 2011, 1:21 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 1:21 p.m.) Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 2:55 p.m.) Review request for Viewer. Changes --- * Removed some code associated with the reverted Build = Upload = Script changes. * Fixed the .lsl extension not being applied correctly. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Changes --- For those wanting to try the Save to file.. option without having to edit the file first, this version has that isDirty check commented out. otherwise it is the same as the previous diff. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) - doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- Review request for Viewer. Summary --- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs - indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing --- Successfully opened and saved scripts from/to local files. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.
On Oct. 29, 2011, 9:43 p.m., Tankmaster Finesmith wrote: .hgignore, line 69 http://codereview.secondlife.com/r/498/diff/4/?file=7292#file7292line69 why is this here? shouldn't this be a separate commit to exclude showing .diff files in hg working directory? Yes it should. I checked my repo and it went in as a separate commit, so I've no idea how it got into the diff :-( - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/498/#review1064 --- On Oct. 25, 2011, 6:03 p.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/498/ --- (Updated Oct. 25, 2011, 6:03 p.m.) Review request for Viewer. Summary --- Adding syntax highlighting for LSL multi-line comments. This has been sitting on my hard drive for months. I've redone the diff against current tip. This addresses bug STORM-959. http://jira.secondlife.com/browse/STORM-959 Diffs - .hgignore 08e65f3ead3d doc/contributions.txt 08e65f3ead3d indra/llui/llkeywords.h 08e65f3ead3d indra/llui/llkeywords.cpp 08e65f3ead3d indra/newview/app_settings/keywords.ini 08e65f3ead3d Diff: http://codereview.secondlife.com/r/498/diff Testing --- Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/498/ --- (Updated Oct. 16, 2011, 12:45 p.m.) Review request for Viewer. Changes --- diff2 seemed to break something on RB. Summary --- Adding syntax highlighting for LSL multi-line comments. This has been sitting on my hard drive for months. I've redone the diff against current tip. This addresses bug STORM-959. http://jira.secondlife.com/browse/STORM-959 Diffs (updated) - doc/contributions.txt 871963a3c7b9 indra/llui/llkeywords.h 871963a3c7b9 indra/llui/llkeywords.cpp 871963a3c7b9 indra/newview/app_settings/keywords.ini 871963a3c7b9 Diff: http://codereview.secondlife.com/r/498/diff Testing --- Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/498/ --- Review request for Viewer. Summary --- Adding syntax highlighting for LSL multi-line comments. This has been sitting on my hard drive for months. I've redone the diff against current tip. This addresses bug STORM-959. http://jira.secondlife.com/browse/STORM-959 Diffs - doc/contributions.txt 871963a3c7b9 indra/llui/llkeywords.h 871963a3c7b9 indra/llui/llkeywords.cpp 871963a3c7b9 indra/newview/app_settings/keywords.ini 871963a3c7b9 Diff: http://codereview.secondlife.com/r/498/diff Testing --- Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Compile errors (was: no subject)
I just tried to compile the viewer 2 source. Following the instructions on the wiki. And have come across a ton of errors. I do not have these errors while building snowglobe or 1.2x viewer source. Any help would be appreciated. Just want to start working on viewer 2 source. Have a bit of free time and would like something to keep me busy. Which wiki page. There are a few concerned with building on Windows. Some of them are more useful (and more up to date) than others. The one you should be reading is: http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds it assumes you are setting up from a clean system. So if you're not don't skip steps as that can mess things up if you used different instructions -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review viewer -- draw distance slider
On Fri, Jun 10, 2011 at 8:59 PM, a...@skyhighway.com wrote: The binocs idea for the icon is the best! It's totally like the average person is going to think about it. And it's the way our eyes work. I have serious concerns (based only on the screenshot posted earlier): * By elevating this option to the top bar, we would expect many more users to interact with the control than when it is buried in preferences. Yes, but only those that need/choose to adjust their draw distance regularly. The same could be said of the volume control, which I adjust once to an appropriate level and never touch again. I expect I would use the draw distance more often and find it more useful on the top bar. * Without textual cues, you rely on the users to associate the button with some meaning. While binoculars may be a good metaphor (and perhaps the best available), it's not a commonly used glyph. Contrast with play/pause/stop or speaker-as-volume, which are now nearly universal in audio controls. I would not expect many users to either go looking for it or easily understand what the control is affecting from just the icon. Binoculars is a commonly use icon in some applications. However, it is used for Find/Search hence it being a temporary choice here for demonstration purposes until a custom icon can be made. I liked Hitomi's eye, but would prefer it without the radiating lines, too easy to confuse that with an active speaker icon at small sizes or on large monitors. * In the mockup I've seen, the control will look similar and behave almost exactly like the nearby volume control. I would expect many novice users to click the icon by mistake, adjust the setting, then wonder why the volume didn't change, and thus leave the draw distance altered unexpectedly. * The negative side effects of setting a large draw distance are not obvious to most new users. By making the control so prominent, I would expect that many would discover the control, set it to the most aesthetically pleasing value (i.e. see more stuff), then forget about it and wonder why the world is suddenly reacting more sluggishly. Something best dealt with by education. The same problem exists with the current preferences, people will still ignore the recommended settings that SL sets up on startup, and turn up the quality. The only difference here is the ease with which it can be done. The same ease they have to turn it down again. Additionally this is only one setting, not all of those available in preferences. I think it's a very cool idea and conceptually love the design, but please proceed with caution. At the risk of making the implementation more difficult, I'd suggest adding labels along the lines of See More (Slower) See Less (Faster) at the top/bottom of the slider to alleviate the confusion. Agreed. Given Jonathan's recent comment regarding the tooltip, keeping it simple (More/Slower, Less/Faster) might be an idea. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-76 Fix autobuild so that --config-file option is honoured by subsequent (possibly recursive) commands
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/335/ --- (Updated June 10, 2011, 2:47 a.m.) Review request for Viewer. Changes --- After discussing with Boroondas on IRC we concluded that __INIT__ is a more sensible place for the environment variable to be set, after __load has finished checking its validity. Summary --- When running a command such as: autobuild configure --config-file ab-test.xml -c ReleaseOS the configuration is only partially completed correctly. When the installables are processed, it does not use the correct configuration file. This is due to cmake calling autobuild install to do the actual install, but not passing the --config-file option. Autobuild falls back to the default autobuild.xml, because the correct configuration file is not saved at any point, which is not the intention and can cause configuration to be done with incorrect libraries. If autobuild.xml is missing or corrupt, an error occurs (which is how I discovered this), stopping the configure command. This fix saves the current value of the configuration file into the AUTOBUILD_CONFIG_FILE environmental variable so that it becomes the default value should any subsequent command need it. I believe that something like this was the original intention when adding this environment variable as part of the default check, but was overlooked. This addresses bug OPEN-76. http://jira.secondlife.com/browse/OPEN-76 Diffs (updated) - autobuild/configfile.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/335/diff Testing --- Ran 'autobuild configure --config-file ab-test.xml -c ReleaseOS' successfully without any errors and was able to build the expected viewer afterwards. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Adding ability for Prebuilt.cmake to pass necessary additional options to 'autobuild install'
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/327/ --- Review request for Viewer. Summary --- This is primarily to allow the passing of '--config-file file-name' through cmake, so that 'autobuild configure' can work correctly. The options are passed by adding -- -DAUTOBUILD_EXTRA_ARGS:STRING=options-to-add to the end of the configure command. e.g. autobuild configure --config-file ab-custom.xml -c ReleaseOS -- -DAUTOBUILD_EXTRA_ARGS:STRING=--config-file=ab-custom.xml Thanks to Brad Linden, for most of the work. This addresses bugs OPEN-76 and OPEN-77. http://jira.secondlife.com/browse/OPEN-76 http://jira.secondlife.com/browse/OPEN-77 Diffs - indra/cmake/Prebuilt.cmake 1d4d568986e3 Diff: http://codereview.secondlife.com/r/327/diff Testing --- Successfully configured and built the viewer with a custom configuration and no autobuild.xml present. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: OPEN-78 Automate the process of passing additional arguments to prebuilt.cmake
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/331/ --- Review request for Viewer. Summary --- The fix in OPEN-77 allows configure to run correctly, but is cumbersome and not exactly pretty on the command line ;-) This fix allows autobuild itself, to automatically add the --config-file option when it determines the default (autobuild.xml) is not being used. This addresses bugs OPEN-76 and OPEN-78. http://jira.secondlife.com/browse/OPEN-76 http://jira.secondlife.com/browse/OPEN-78 Diffs - autobuild/autobuild_tool_configure.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/331/diff Testing --- Configure and built viewer-development with custom configuration and no default file present. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-77 Adding ability for Prebuilt.cmake to pass necessary additional options to 'autobuild install'
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/327/ --- (Updated June 7, 2011, 3:17 p.m.) Review request for Viewer. Changes --- Updated diff (includes contributions.txt change now) and summary (to include jira number). Summary (updated) --- This is primarily to allow the passing of '--config-file file-name' through cmake, so that 'autobuild configure' can work correctly. The options are passed by adding -- -DAUTOBUILD_EXTRA_ARGS:STRING=options-to-add to the end of the configure command. e.g. autobuild configure --config-file ab-custom.xml -c ReleaseOS -- -DAUTOBUILD_EXTRA_ARGS:STRING=--config-file=ab-custom.xml Thanks to Brad Linden, for most of the work. This addresses bugs OPEN-76 and OPEN-77. http://jira.secondlife.com/browse/OPEN-76 http://jira.secondlife.com/browse/OPEN-77 Diffs (updated) - doc/contributions.txt 1d4d568986e3 indra/cmake/Prebuilt.cmake 1d4d568986e3 Diff: http://codereview.secondlife.com/r/327/diff Testing --- Successfully configured and built the viewer with a custom configuration and no autobuild.xml present. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] quicktime
This was fixed is it now a do-over? From April 11,2011 message list archive: Quicktime SDK is an INSTALL_PROPRIETARY=TRUE archive download. The LL archive is modified to work with VS2010. The Apple Quicktime SDK has not been modified and fails compile. I cloned 3p-quicktime and with autobuild build and package have the libraries. The procedure worked extremely well.Then, I modified autobuild.xml to point to the local copy. Now the catch, since QuickTimePlugin.cmake has: if (INSTALL_PROPRIETARY) include(Prebuilt) use_prebuilt_binary(quicktime) endif(INSTALL_PROPRIETARY) What autobuild setup or command line switch do I use to access the local copy? I commented out the if(INSTALL_PROPRIETARY) and then it pulled from the local copy with autobuild.xml set to the location and md5sum printed as output of autobuild package command. What are the planned methods to use local copies of what at one time were proprietary or license restricted packages and now can be cloned and built on a local computer and used? Also, does INSTALL_PROPRIETARY make sense when the end result is the library is on the local computer and can be used? So far as I can tell there, currently isn't a switch for quicktime only. I've patched the Quicktime.Plugin.cmakeQuickTimePlugin.cmake file to add one (USE_QUICKTIME). I haven't found any problems with this yet, but I'm still checking for alternatives. Attached is a diff for the changes -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk USE_QUICKTIME-cmake-test_18426.diff Description: Binary data ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO review build
Hi STORM-941 http://jira.secondlife.com/browse/STORM-941 IM log naming should go by SL name, not DN. Tested with one person, but worked fine. STORM-1032 http://jira.secondlife.com/browse/STORM-1032 Artwork update for Appearance Editor Edit icon Looks good. STORM-1175 http://jira.secondlife.com/browse/STORM-1175 'Close' button doesn't work after setting Custom port in Preferences Setup Network yay it works \o/ STORM-1259 http://jira.secondlife.com/browse/STORM-1259 Sculpt dimension meta-data view missing from 2.x, was possible to see in 1.23 Works fine. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Update autobuilds default VC version to 2010
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/ --- Review request for Viewer. Summary --- Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is unset. Now that LL have moved to VC 2010 completely, shouldn't this become the default version? Diffs - autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 Diff: http://codereview.secondlife.com/r/305/diff Testing --- Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated May 12, 2011, 12:26 a.m.) Review request for Viewer. Changes --- Fixed the contributions entry, that sneaked in from my local repo, because it's missing in v-d. Thanks Boroondas. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs (updated) - doc/contributions.txt 5e349dbe9cc8 indra/llui/llnotifications.cpp 5e349dbe9cc8 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated May 12, 2011, 3:45 a.m.) Review request for Viewer. Changes --- Removed trailing whitespace per Boroondas' request. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs (updated) - doc/contributions.txt 5e349dbe9cc8 indra/llui/llnotifications.cpp 5e349dbe9cc8 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated May 11, 2011, 6:56 a.m.) Review request for Viewer. Changes --- Changes to patch per Vadim's reccomendation. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs (updated) - doc/contributions.txt 5e349dbe9cc8 indra/llui/llnotifications.cpp 5e349dbe9cc8 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
On May 11, 2011, 4:05 p.m., Boroondas Gupte wrote: doc/contributions.txt, line 367 http://codereview.secondlife.com/r/271/diff/2/?file=1982#file1982line367 OPEN-50 is unrelated, isn't it? Please clean your changesets. Oops, yes. Will fix that tomorrow. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review694 --- On May 11, 2011, 6:56 a.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated May 11, 2011, 6:56 a.m.) Review request for Viewer. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs - doc/contributions.txt 5e349dbe9cc8 indra/llui/llnotifications.cpp 5e349dbe9cc8 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
On April 20, 2011, 9:01 a.m., Vadim ProductEngine wrote: indra/llui/llnotifications.cpp, line 1536 http://codereview.secondlife.com/r/271/diff/1/?file=1484#file1484line1536 LLNotificationsUtil is a wrapper around LLNotifications. Calling a wrapper from the class it wraps doesn't look very nice to me. So I'd change this line to do the following: add(name.asString(), LLSD(), LLSD()); and remove the include. Both approaches trigger a run-time warning though. I'll address that in a separate review request (coming soon). I've been waiting for the separate review request before continuing with this. Any idea when soon will be? - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review637 --- On April 19, 2011, 7:57 a.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated April 19, 2011, 7:57 a.m.) Review request for Viewer. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs - doc/contributions.txt 584211e99147 indra/llui/llnotifications.cpp 584211e99147 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/ --- (Updated April 21, 2011, 2:18 p.m.) Review request for Viewer. Changes --- updated diff Summary --- The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs. On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used. If any one knows how it could use %systemroot% instead of the environment variable WINDIR I'd appreciate the info ;-) This addresses bug OPEN-61. http://jira.secondlife.com/browse/OPEN-61 Diffs (updated) - indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 Diff: http://codereview.secondlife.com/r/259/diff Testing --- Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
On April 19, 2011, 8:02 a.m., Vadim ProductEngine wrote: Could you please provide the patch description? I.e what the problem was and how you fixed it. I'm not sure what you want here. If you're asking what I did? I updated Kitty's two line patch to apply against the current code, then tested that it fixed the problem. If you're asking what Kitty's thinking was behind the solution? I can't answer that. - Ima --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review631 --- On April 19, 2011, 7:57 a.m., Ima Mechanique wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- (Updated April 19, 2011, 7:57 a.m.) Review request for Viewer. Summary --- Applying Kitty Barnett's patch against current code base. This addresses bug STORM-1175. http://jira.secondlife.com/browse/STORM-1175 Diffs - doc/contributions.txt 584211e99147 indra/llui/llnotifications.cpp 584211e99147 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] autobuild with VS2005
Thanks... this convinces me to go with VCE2010 (getting over the initial gripe I have about it, since it is the only sensible option I have to go ahead anyway). Right now it builds to the end, but it fails at the very last step with this error : 60 Looking for existing VisualStudio instance... 60Didn't find open solution, starting new background VisualStudio instance... 60Reading .sln file version... 60Using version: VC100... 60 Value cannot be null. 60 Parameter : type Seems to be vstool complaining that it cannot find the instance of VS when calling GetDTEAndSolution() in main.cs... although VCE is open. Autobuild does that too on the command line. What can I do to make it find VCE and modify the solution ? I'm thinking some path is missing from my PATH env variable but I can't figure out which. I can't swear to it (I don't use the 'official' autobuild.xml), but as I recall, that is a known problem for express, that should be fixed with the OPEN-50 stuff that's coming soon ;-) VCE can't modify the solution this way, it doesn't have the API required for it. This is one of the many differences between Express and full versions. Thanks again On 18/04/2011, Ima Mechanique ima.mechani...@blueyonder.co.uk wrote: Thank you all for the pointers. So if I get this right, VS2005 is to be left behind... not really kind to people who are used to it, and who find 2010 to be an unbearable bloatware that runs 4x slower than the old IDE. Not mentioning that with 2005, at least I could do something else while compiling. With this one, I can do something else... as long as it's away from my computer. Not so much that 2005 is being left behind, but that LL is moving forward. They cannot stay with the same environment when the Operating Systems are moving forward; for many reasons. How fast VC10 runs depends a LOT on your system and configuration. When I first used autobuild with it, it took the same time to build the viewer as 2005 had (approximately) However this turned out to be because I was not using some of the optimisations possible that 2005 had been using. With these enabled, it is now 35 minutes faster than 2005. Yes, it is a resource hog, but that's how it gets to be faster, you can change default values to prevent that if you want to, I make a cup of coffee and do something else ;-) Also, autobuild is designed to use the command line, not the IDE which is a great part of the resource eating. Intellisense is a pain in the ... RAM, disc I/O, etc. for example. As has been said already, autobuild started on the 2005 build, if you want to continue using it you will need to collect all the 2005 build versions of the libraries and create a configuration file that uses them instead of the default one which uses 2010 builds. If you are using the Express version of 2005 you will probably have to do more to get it to work. The initial version of autobuild was not express friendly. This is caused by many differences in how the full/express versions work. Start with the repo at https://bitbucket.org/oz_linden/viewer-autobuild/ That is the one started for 2005 builds, so should contain some if not all the library links I have no idea if those files are still available from the amazon servers though.Be aware it is considerably out of date with the main code base now, so you will have to import from viewer-development, being careful not to over write the autobuild.xml, best to rename it. And if I also get this right, VCexpressRelWithDebInfo is the only configuration that I should use, isn't it ? I am told to always use the OpenSource ones, except if I am on Windows (which is the case). Doesn't matter, I'll try both. IIRC the OpenSource* configurations are for full versions of VC only. They may work with a full version of 2005. VCexpressRelWithDebInfo is for VC10 Express versions. It uses commands not available on 2005, so probably will not work at all for you. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences Setup Network
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- Review request for Viewer. Summary --- Applying Kitty Barnett's patch against current code base. Diffs - doc/contributions.txt 584211e99147 indra/llui/llnotifications.cpp 584211e99147 Diff: http://codereview.secondlife.com/r/271/diff Testing --- Release build. tested preferences both in world and on the log in screen. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/ --- (Updated April 9, 2011, 6:27 p.m.) Review request for Viewer. Changes --- Changed the search to use a registry lookup for the %SystemRoot% instead of the environment variable WINDIR. Also added warning messages if the files are not located. Summary --- The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs. On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used. If any one knows how it could use %systemroot% instead of the environment variable WINDIR I'd appreciate the info ;-) This addresses bug OPEN-61. http://jira.secondlife.com/browse/OPEN-61 Diffs (updated) - indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 Diff: http://codereview.secondlife.com/r/259/diff Testing --- Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/ --- (Updated April 8, 2011, 7:43 a.m.) Review request for Viewer. Summary (updated) --- The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs. On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used. This addresses bug OPEN-61. http://jira.secondlife.com/browse/OPEN-61 Diffs - indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 Diff: http://codereview.secondlife.com/r/259/diff Testing --- Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/ --- (Updated April 8, 2011, 7:47 a.m.) Review request for Viewer. Summary (updated) --- The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs. On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used. If any one knows how it could use %systemroot% instead of the environment variable WINDIR I'd appreciate the info ;-) This addresses bug OPEN-61. http://jira.secondlife.com/browse/OPEN-61 Diffs - indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 Diff: http://codereview.secondlife.com/r/259/diff Testing --- Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location. Thanks, Ima ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] s3-proxy.lindenlab.com points to a private IP address?
Linden Lab should not be distributing either of these libraries, as they do not have a license that permits them to do so(from what I have heard from them in other dialogs). So this violates and possibly voids their license for Kakadu, as well as all of their careful planning to keep it out of every developers hands except for their own. I hope that they will take these down, and it is not an error that you should NOT be able to download them. The error here is that they are trying to be downloaded at all. This is something of a grey area. For KDU, this is not distributing per se, as it is only the headers and lib file to link against, not the final library being made available. I'm not privy to the license details so have no idea if this would be a breach of terms.. For FMOD, things are clearer. The contents of the FMOD distribution archive may not be redistributed, reproduced, modified, transmitted, broadcast, published or adapted in any way, shape or form, without the prior written consent of the owner, Firelight Technologies, be it by tangible or non tangible media. The fmod.dll file may be redistributed without the authors prior permission, and must remain unmodified. LL have both modified the archive (by creating a new one) and are redistributing that modified version, so I hope they have obtained written permission from Firelight Technologies I'd hope that FT would be happy to grant permission, as it relieves their servers of the download bandwidth required. On Wed, Apr 6, 2011 at 23:34, Glimmering Sands glimmering.sa...@gmail.com wrote: Well, I have discovered, through the wonders of Mr. Google, that there is an older copy autobuild.xml out there at: https://bitbucket.org/merov_linden/viewer-autobuild2010/src/44f214103cff/autobuild.xml and I was able to simply use the http://s3.amazonaws.com/viewer-source-downloads/install_pkgs/... lines for both fmod and kdu (would it be considered a bug that Linden Labs is distributing an autobuild.xml that uses internal only paths rather than using the external paths (that I guessed the used to have?) One can also wonder why you would let internal DNS records be allowed to external sites as well... Sometime later I will discover if this solves my grey goo box problem or not :-) Hugs, Glimmering -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] autobuild VS 2010 support merged to viewer-development
The autobuild and Visual Studio 2010 branch has been merged to viewer-development develop.py is dead, long live autobuild After half a day of fiddling I finally got this to work - yay! Setup: Windows 7 + VS2010 The only real bump on the road was that for some reason the file autobuild from the autobuild package needed to be copied manually to C:\Python26\Scripts. I have no clue why. After I figured that one out, and sorted a few BISON paths etc. everything now compiles perfectly inside VS2010! And there was much rejoicing :) Building from the VS command prompt? Not so lucky. I get this: devenv.com is not an internal command What were you trying to build. viewer-development shouldn't cause that error. You will run into that error trying to build the 3p-* libraries, as it uses a couple functions still coded to use devenv :-( This is only a problem for Express users as the Pro and higher version include devenv.com. On #opensl, we've been using autobuild for several weeks now. Please feel free to come ask for help and use our experience with it ;-) Well, I'll just stick to building inside VS2010 for now :) I even got a setup.exe (not with that name though) - I never got that with VS2005 since it always failed somewhere before that (after generating secondlife-bin.exe though, lucky me). Well done! -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Snowstorm PO review build
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/225458/index.html Here are the issues addressed in that build: STORM-399 http://jira.secondlife.com/browse/STORM-399 Users that has chatted within chat range of the user in-world are not added to Recent tab not tested STORM-1072 http://jira.secondlife.com/browse/STORM-1072 [TRANSLATED BUT IN EN] in Monde Profil du lieu propos des terrains Rlement : Estate / Full Region is in english. Not tested. STORM-1094 http://jira.secondlife.com/browse/STORM-1094 Chat preferences font size should increase size of input text in IM window Works beautifully. STORM-1095 http://jira.secondlife.com/browse/STORM-1095 Chat preferences font size should increase size of input text in the chat box Works beautifully now. STORM-1108 http://jira.secondlife.com/browse/STORM-1108 Enable Hints menu entry/preference is confusing Still there on Help \o/ and removed from Preferences = General. \o/ VWR-25269 http://jira.secondlife.com/browse/VWR-25269 [#STORM-1106] Set scripts to running on an object containing no scripts produces a unknown notification error Now produces a dialogue with Not able to set any scripts to 'running'. Select objects with scripts -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Build available
Ima, could you please add a comment to the jira with specific repro steps? (where to go, what to do, what should show a beacon, etc) Thanks! It's something of a misunderstanding. I expected this feature to highlight *all* objects that caused a connection to media, not only those set using the texture/media in the build/edit dialogue. In particular I was expecting media set using the Media tab in About Land to also be included, but it isn't. gr. 2011/3/25 Ima Mechanique ima.mechani...@blueyonder.co.uk * STORM-1019 : Add ability to display beacons for Media on a Prim objects Partial. Not sure what is supposed to be covered by this, but it doesn't show an HTML MoaP I have. It does identify a neighbour's TreetTV board. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] autobuild setting UNATTENDED questions
Thanks for replying Brad On Fri, Mar 25, 2011 at 11:04 AM, Ima Mechanique ima.mechani...@blueyonder.co.uk wrote: I'm trying to find out more information about this setting and the piece of code it controls. Non Windows devs can switch off now as it only affects them by causing a warning about it not being used. 1) Is it still needed. All configurations, even the TC ones, have it defaulting to off. This causes problems for VCE devs as the vstools program controlled by it causes an error for them. It's purpose appears to be to set the working directory for running the .exe. However, the .exe runs just fine without it being set. The working directory setting may no longer be necessary after this changehttps://bitbucket.org/merov_linden/viewer-autobuild2010/changeset/339c25d7046e. If so, that's good news. However, I believe that we also use it for setting the default configuration to RelWithDebInfo, which we still require. Could you expand on this? I'm assuming the it is vstool or UNATTENDED, but the only other references to either I can find in the source tree are part of the autobuild.xml configuration for Debug, RelWithDebInfo, and Release (which do seem to be setting configuration type for startup). If that is what you're referring to, then the CMakeLists.txt part could be safely removed and OS devs could remain happily oblivious to its use? 2) If it really is necessary, could we change the program run (vstools) to something more compatible with all VC versions. Now the project files are XML based, it should be possible to do this as part of autobuild itself. The source for vstool is herehttps://bitbucket.org/merov_linden/viewer-autobuild2010/src/tip/indra/tools/vstool/main.cs. (Yes, it's C#, don't ask me...) If there's a way to make it compatible with VCExpress I'd love to do so, but to my knowledge VCExpress doesn't expose the macro apis that this relies upon, so it's likely impossible to directly extend that script to this case. I don't think it makes sense to build support for tweaking these xml files into autobuild, as autobuild is intended to be as fully decoupled from the details of individual build systems as possible. Agreed about autobuild, I was thinking something like a python script that autobuild/cmake could use instead of vstool. However, it seems this is unnecessary now. An alternative is getting this kind of feature built into cmake. For example, this issue http://public.kitware.com/Bug/view.php?id=8884 is a feature request for making another kind of modification to the *.vcproj.*.user configuration file where these settings are saved. In the mean time, I would definitely recommend updating the VCExpress configurations to pass -DUNATTENDED:BOOL=ON on the command line until we find a better solution for this. Already done and in my repo, although it's not a VC Express configuration it's for any OS VC 2010 We used to do a lot more with the --unattended argument to develop.py, but I think this is all that remains of that cruft, so it's safe to use for this purpose. So if the autobuild.xml is what you were referring to above, could we safely remove all references to UNATTENDED (TC and OS), and remove lines 1581 - 1594 from indra/newview/CMakeLists.txt? -Brad -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] autobuild setting UNATTENDED questions
I'm trying to find out more information about this setting and the piece of code it controls. Non Windows devs can switch off now as it only affects them by causing a warning about it not being used. 1) Is it still needed. All configurations, even the TC ones, have it defaulting to off. This causes problems for VCE devs as the vstools program controlled by it causes an error for them. It's purpose appears to be to set the working directory for running the .exe. However, the .exe runs just fine without it being set. 2) If it really is necessary, could we change the program run (vstools) to something more compatible with all VC versions. Now the project files are XML based, it should be possible to do this as part of autobuild itself. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Build available
Hi, PO build of the day available at: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/225012/index.html Containing fixes/implementations for: * STORM-399 : Users that has chatted within chat range of the user in-world are not added to Recent tab Stalking Ahern just felt so tacky. But everyone typing appeared in nearby, as far as I could tell. * STORM-1019 : Add ability to display beacons for Media on a Prim objects Partial. Not sure what is supposed to be covered by this, but it doesn't show an HTML MoaP I have. It does identify a neighbour's TreetTV board. * STORM-1021 : Viewer shows L$300 instead of object IM details if object sends an IM from another region not tested * STORM-1030 : Main menu change: 'Me-Change Outfit' to 'Me-My Appearance' Good to go. * STORM-1068 : Add optional range ring(s) to the mini-map -- one centered on you with a radius of 20m to show local chat range Even zoomed in close I couldn't see this. Does it need any set up? * STORM-1077 : Change Voice Enabled/Disabled to Speak Button Oops forgot to check when I logged in, clicked it off automatically * STORM-1086 : Agent's own calling card created on startup is placed into Friends/All folder instead of Calling Cards Good to go * STORM-1095 : Chat preferences font size should increase size of input text in the chat box It does, after clicking back into the chat area. Cheers, - Merov -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Build available
On Fri, Mar 25, 2011 at 18:42, Ima Mechanique ima.mechani...@blueyonder.co.uk wrote: * STORM-1068 : Add optional range ring(s) to the mini-map -- one centered on you with a radius of 20m to show local chat range Even zoomed in close I couldn't see this. Does it need any set up? Yes, it's disabled by default - turn it on by right-clicking the mini-map. Should have mentioned I did that. still couldn't see anything. I was wondering if there was a way to change colour or something to make it more visible. Opensource Obscure http://twitter.com/oobscure - http://opensourceobscure.com/lol -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Review build
A number of people have written in saying they tested the latest PO build. I am curious about what you saw for storm-1077 -- the hint for voice chat. Did you get this hint only once or multiple times as Anya has reported? Please write back with your observation. Unfortunately, I'd clicked the 'x' before I knew it was one of the things I should be checking out :-( Which is why I didn't comment on it. Thank you, -jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Review build
A PO Review build is available at http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/224669/index.html for these issues: STORM-250 http://jira.secondlife.com/browse/STORM-250 Unexpected More text appears in the About Landmark panel after minimising the floater Good, didn't see a More... any where. STORM-659 http://jira.secondlife.com/browse/STORM-659 Viewer hangs when navigate in the Back/Fwd Teleport history by keyboard Good, no hanging ;-) STORM-971 http://jira.secondlife.com/browse/STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map Good STORM-1018 http://jira.secondlife.com/browse/STORM-1018 Documentation and error messaging for External Editor Feature in Viewer 2.5 Not tested STORM-1025 http://jira.secondlife.com/browse/STORM-1025 Chat preferences font size should increase size of input text as well Good STORM-1030 http://jira.secondlife.com/browse/STORM-1030 Main menu change: 'Me-Change Outfit' to 'Me-My Appearance' Good STORM-1035 http://jira.secondlife.com/browse/STORM-1035 Add Search to World menu Good STORM-1077 http://jira.secondlife.com/browse/STORM-1077 Change Voice Enabled/Disabled to Speak Button Not tested VWR-0 http://jira.secondlife.com/browse/VWR-0 [#STORM-1025] Chat preferences font size should increase size of input text as well Duplicate, see above. Incidentally, I couldn't use CTRL+ALT+G for the grid dropdown on the login screen. Is this intentional for the v2.6.x builds? -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] merov's viewer-autobuild2010
I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting yesterday and manually inserted fmod files and then ran autobuild --debug configure -c OpenSourceRelWithDebInfo autobuild --debug build -c OpenSourceRelWithDebInfo logged in with LindenDeveloper.exe in the RelWithDebInfo directory. I'm on Windows 7, with Visual Studio 10.0 Professional with a fresh pull from bitbucket.org/merov_linden/viewer-autobuild2010 with autobuild up to date YEAH! I tried the same, however this fails completely for VCE as the configuration (only one supporting VC 2010) uses devenv which is not available on any Express setup. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Experience with autobuilding 3p-libs on windows with VC Express
/unarchived. llqtwebkit Has a dependency on curl. ../build-cmd.sh: line 62: pushd: qt-everywhere-opensource-src-4.7.1: No such file or directory Appears that the extraction has been commented out at build-cmd.sh line 57. Even with this line restored there are errors for the -platform switch during configuration. openal The OpenAL.sln is not created xmlrpc-epi had to change |Win32 in build-cmd.sh lines 44 + 45 The expat installable is not installed, so includes fail - These fail to configure glh_linear google-perftools configure fails? had to change |Win32 in build-cmd.sh lines 32 + 33 autobuild configure does nothing, leading to errors looking for project files when building. - These repoes fail to package dbus-glib - These repoes are currently empty, so not tried. fontconfig gstreamer gtk-atk-pango-glib libmono libstrophe libuuid (not applicable to windows, I think) libxml mysql mysqlclient smartheap unistd - These do not apply to windows builds. i.e. they do not have windows configurations: elfio mesa -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Is 'STANDALONE' confusing?
On 2011-03-03 1:45, Philippe (Merov) Bossut wrote: Dropping privately built 3rd party libs though was always a bit of a black art. Now that most 3rd party libs have a public repo available at lindenlab/3p-package though, you have another possibility which is to build the package yourself and point autobuild.xml to it using a file:///path url (don't forget to also change the md5 hash...). That will extract libs and includes and drop them in build-plat/packages. I experimented with that in OPEN-6 and it works fine. I'd really like to some experiences from open devs trying to use this method. Essentially, it means maintaining your own version of the autobuild configuration file (either in autobuild.xml, being careful not to include those changes in any changeset meant to be merged to viewer-development, or by using a copy and pointing to the copy either with a --config-file option to autobuild or with the AUTOBUILD_CONFIG_FILE environment variable). Even if you build your own prebuilds, you probably won't need to do it very often - check them all out once, build each one, construct the packages portion of the autobuild.xml file and then copy it into any working copy you've got for doing viewer work. The only time you should need to rebuild any of them is when a package is modified either by you or from upstream. I spent 3-4 hours playing with this today. I started by updating local copies of the 3p repoes,and was encouraged to see several commits for VS2010 compatibility. That didn't last long though, as when I checked the autobuild.xml files there was nothing in them for Windows users :-( There are entries under platform claiming to be windows, but in reality all but one appear to be for cygwin only, and I'm not sure about the last. Cygwin really needs to be treated as a platform in its own right here. Otherwise when the OS community creates *real* windows configurations you will not be able to accept them because of a naming conflict. Not to mention it annoys Windows users to see a window entry and it doesn't work. ;-) I tried using the cygwin configs, but was unable to get any of them working because of errors calling python scripts. Pretty sure the path isn't being translated back into MSDOS style. I tried the note on the https://wiki.secondlife.com/wiki/Autobuild page, installing the module and including the Script directory in path, but that didn't work either. The note on https://wiki.secondlife.com/wiki/Autobuild about installing autobuild in cygwin led to a total misunderstanding on my part. After someone pointed out to me that using cygwin directly was a no-go, I tried again with this yesterday. This time using a command prompt (Windows SDK 7.1, currently the latest version). Things went somewhat better. Several of the build-cmd.sh script had a pass: unknown command error, the pass command being at the end of the script. Those scripts that didn't have this problem couldn't perform a build as they use devenv to start building, which is not available on VCExpress. I was able to open some of the solutions in the IDE, which complained that parts were corrupt. However, despite the corruption I was able to build a few libs from within the IDE. I intend to continue some more with this to see if I can get it working better. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Is 'STANDALONE' confusing?
On 2011-03-03 1:45, Philippe (Merov) Bossut wrote: Dropping privately built 3rd party libs though was always a bit of a black art. Now that most 3rd party libs have a public repo available at lindenlab/3p-package though, you have another possibility which is to build the package yourself and point autobuild.xml to it using a file:///path url (don't forget to also change the md5 hash...). That will extract libs and includes and drop them in build-plat/packages. I experimented with that in OPEN-6 and it works fine. I'd really like to some experiences from open devs trying to use this method. Essentially, it means maintaining your own version of the autobuild configuration file (either in autobuild.xml, being careful not to include those changes in any changeset meant to be merged to viewer-development, or by using a copy and pointing to the copy either with a --config-file option to autobuild or with the AUTOBUILD_CONFIG_FILE environment variable). Even if you build your own prebuilds, you probably won't need to do it very often - check them all out once, build each one, construct the packages portion of the autobuild.xml file and then copy it into any working copy you've got for doing viewer work. The only time you should need to rebuild any of them is when a package is modified either by you or from upstream. I spent 3-4 hours playing with this today. I started by updating local copies of the 3p repoes,and was encouraged to see several commits for VS2010 compatibility. That didn't last long though, as when I checked the autobuild.xml files there was nothing in them for Windows users :-( There are entries under platform claiming to be windows, but in reality all but one appear to be for cygwin only, and I'm not sure about the last. Cygwin really needs to be treated as a platform in its own right here. Otherwise when the OS community creates *real* windows configurations you will not be able to accept them because of a naming conflict. Not to mention it annoys Windows users to see a window entry and it doesn't work. ;-) I tried using the cygwin configs, but was unable to get any of them working because of errors calling python scripts. Pretty sure the path isn't being translated back into MSDOS style. I tried the note on the https://wiki.secondlife.com/wiki/Autobuild page, installing the module and including the Script directory in path, but that didn't work either. The note on https://wiki.secondlife.com/wiki/Autobuild about installing autobuild in cygwin led to a total misunderstanding on my part. After someone pointed out to me that using cygwin directly was a no-go, I tried again with this yesterday. This time using a command prompt (Windows SDK 7.1, currently the latest version). Things went somewhat better. Several of the build-cmd.sh script had a pass: unknown command error, the pass command being at the end of the script. Those scripts that didn't have this problem couldn't perform a build as they use devenv to start building, which is not available on VCExpress. I was able to open some of the solutions in the IDE, which complained that parts were corrupt. However, despite the corruption I was able to build a few libs from within the IDE. To clarify, devenv.com is called in the autobuild_tool_source_environment.py file.at lines 216, 233, and 235. I intend to continue some more with this to see if I can get it working better. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Setup a Release configuration for VS2010 build -- Need testers.
Applied change to autobuild.xml for -VC10msbuildRelease. Applied change to CMakeLists.txt to remove the Colon from /MAP the colon was being passed through cmake and causing a bad path. Failed in an attempt to place the CMakeList.txt change to Review Board. Oz's repository is out of sync with mine. And, mine isn't a review board repository. https://bitbucket.org/NickyP/viewer-autobuild2010-wip @ WolfPup Know you intended to work on this. I was trying to work 32 bit memory issues and was trying to see if release was better and it fell in place. Sorry, if I stepped on your toes. Memory is slightly better. On XP 32bit 1:20 minutes before crash. Nicky Don't know exactly what needed testing, but it compiled for me on Win XP Pro 64-bit, using VCE 2010. commands used autobuild configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF autobuild build --no-configure -c VC10msbuildRelWithDebInfo Managed to log into SL today with it (last night I couldn't stay connected for more than 30 seconds). All appears to work except for audio (I assumed FMOD was disabled). -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Is 'STANDALONE' confusing?
On 2011-03-03 1:45, Philippe (Merov) Bossut wrote: Dropping privately built 3rd party libs though was always a bit of a black art. Now that most 3rd party libs have a public repo available at lindenlab/3p-package though, you have another possibility which is to build the package yourself and point autobuild.xml to it using a file:///path url (don't forget to also change the md5 hash...). That will extract libs and includes and drop them in build-plat/packages. I experimented with that in OPEN-6 and it works fine. I'd really like to some experiences from open devs trying to use this method. Essentially, it means maintaining your own version of the autobuild configuration file (either in autobuild.xml, being careful not to include those changes in any changeset meant to be merged to viewer-development, or by using a copy and pointing to the copy either with a --config-file option to autobuild or with the AUTOBUILD_CONFIG_FILE environment variable). Even if you build your own prebuilds, you probably won't need to do it very often - check them all out once, build each one, construct the packages portion of the autobuild.xml file and then copy it into any working copy you've got for doing viewer work. The only time you should need to rebuild any of them is when a package is modified either by you or from upstream. I spent 3-4 hours playing with this today. I started by updating local copies of the 3p repoes,and was encouraged to see several commits for VS2010 compatibility. That didn't last long though, as when I checked the autobuild.xml files there was nothing in them for Windows users :-( There are entries under platform claiming to be windows, but in reality all but one appear to be for cygwin only, and I'm not sure about the last. Cygwin really needs to be treated as a platform in its own right here. Otherwise when the OS community creates *real* windows configurations you will not be able to accept them because of a naming conflict. Not to mention it annoys Windows users to see a window entry and it doesn't work. ;-) I tried using the cygwin configs, but was unable to get any of them working because of errors calling python scripts. Pretty sure the path isn't being translated back into MSDOS style. I tried the note on the https://wiki.secondlife.com/wiki/Autobuild page, installing the module and including the Script directory in path, but that didn't work either. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Is 'STANDALONE' confusing?
On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: If we are going to change it, the replacement term should, in addition to being more accurately descriptive of what it does, be an affirmative term - don't suggest any 'NO_* replacements. Would it be acceptable to invert the setting's semantic in order to avoid a negation? I.e., STANDALONE=OFF would become NEW_SETTING=ON and vice versa. That'd allow for easy-to-understand names like USE_PREBUILD_LIBS or DOWNLOAD_NEEDED_DEPENDENCIES. Off course, the default value should be inverted together with the setting's semantic, such that the default behavior does not change. Agree with changing the semantics. I'd prefer something shorter and somewhat more consistent with existing settings, like LL_LIBS_DOWNLOAD or LL_LIBS_FETCH However, it's not a strong preference. Cheers, Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Autobuild still requires cmake?
If the goal is to have a building tool why does it still require cmake? See Oz's original post. Short version Autobuild is a framework for maintaining and building libraries and other programs. It acts as director providing a common interface to build and package libraries and programs, but it is not a build system like make or cmake (it uses them under the covers). -- --- This email is a private and confidential communication. Any use of email may be subject to the laws and regulations of the United States. You may not Repost, Distribute nor reproduce any content of this message. --- --- -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using autobuild build -c VCexpressRelWithDebInfo If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
What is your windows OS? I may be able to Vbox/VM it to test. WinXP 64 bit. The following altered function from indra\lib\python\indra\util\test_win32_manifest.py fixes the issues for me. def find_vc_dir(): supported_versions = (r'8.0', r'9.0') supported_products = (r'VisualStudio', r'VCExpress') value_str = (r'ProductDir') for product in supported_products: for version in supported_versions: key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % (product, version)) try: return get_HKLM_registry_value(key_str, value_str) except WindowsError, err: if product == VisualStudio: reg_key = VS elif product == VCExpress: reg_key = VC else: raise Exception(Unknown package!) x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % (product, version, reg_key)) try: return get_HKLM_registry_value(x64_key_str, value_str) except: print sys.stderr, Didn't find MS %s version %s % (product,version) raise From: Ima Mechanique ima.mechani...@blueyonder.co.uk To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 1:15:31 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using autobuild build -c VCexpressRelWithDebInfo If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I tried making these changes... it did not do anything different or help me in my situation of not finding the windows.h and winsock2.h. That change is only for Win XP x64 environment, to allow the build process to identify the VC Express install directory. Otherwise build fails. It has nothing to do with the winsock2.h and windows.h problem, which I'm looking into now in response to Oz's mail. I'd start over and rebuild the dev environment but its not a good option for me at this time. Date: Sun, 6 Feb 2011 20:23:41 + From: ima.mechani...@blueyonder.co.uk To: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. What is your windows OS? I may be able to Vbox/VM it to test. WinXP 64 bit. The following altered function from indra\lib\python\indra\util\test_win32_manifest.py fixes the issues for me. def find_vc_dir(): supported_versions = (r'8.0', r'9.0') supported_products = (r'VisualStudio', r'VCExpress') value_str = (r'ProductDir') for product in supported_products: for version in supported_versions: key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' % (product, version)) try: return get_HKLM_registry_value(key_str, value_str) except WindowsError, err: if product == VisualStudio: reg_key = VS elif product == VCExpress: reg_key = VC else: raise Exception(Unknown package!) x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' % (product, version, reg_key)) try: return get_HKLM_registry_value(x64_key_str, value_str) except: print sys.stderr, Didn't find MS %s version %s % (product,version) raise From: Ima Mechanique ima.mechani...@blueyonder.co.uk To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 1:15:31 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using autobuild build -c VCexpressRelWithDebInfo If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
On 2011-02-06 14:15, Ima Mechanique wrote: Just to clarify. These errors are only generated when using autobuild build -c VCexpressRelWithDebInfo If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE; instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I remembered reading about some issues (don't ask me to expand) of not having the latest SDK's when using win64. I have both express and pro on my machine and my include settings for Pro reflect newer SDK's. Maybe you can try these includes. http://picpaste.com/vs2005proIncludes-2Fa11vp6.PNG I have all those directories (and more, see https://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds for complete list). I don't think the contents here are the issue. After all, those includes work for the GUI, for some reason the CLI is not getting them would seem more likely to me. From: Ima Mechanique ima.mechani...@blueyonder.co.uk To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 3:34:41 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. On 2011-02-06 14:15, Ima Mechanique wrote: Just to clarify. These errors are only generated when using autobuild build -c VCexpressRelWithDebInfo If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE; instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
