[opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

Review request for Viewer.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs
-

  doc/contributions.txt 7ae099f5a764 
  indra/newview/llpreviewscript.h 7ae099f5a764 
  indra/newview/llpreviewscript.cpp 7ae099f5a764 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7ae099f5a764 

Diff: http://codereview.secondlife.com/r/596/diff/diff


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/#review1251
---


Tested it in a viewer-development based build. Works fine for scripts in my inv 
as well as for scripts in objects.
One thing though, hitting enter when entering the line number shgould be 
enough, clicking the ok button is a bit of a pain.

- Lance Corrimal


On Sept. 11, 2012, 2:39 a.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/596/
> ---
> 
> (Updated Sept. 11, 2012, 2:39 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/bug-59
> 
> I more or less cloned the search-function and modified the floater via xml 
> (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
> Also I added a callback to prevalidate the input in the 'go to line' 
> line-editor, so that only numbers can be entered into it.
> 
> 
> This addresses bug BUG-59.
> https://jira.secondlife.com/browse/BUG-59
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 7ae099f5a764 
>   indra/newview/llpreviewscript.h 7ae099f5a764 
>   indra/newview/llpreviewscript.cpp 7ae099f5a764 
>   indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml 7ae099f5a764 
> 
> Diff: http://codereview.secondlife.com/r/596/diff/diff
> 
> 
> Testing
> ---
> 
> Tested on my local PC with a modded "3.3.4-release3" version.
> Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
> to line', enter a number less than 300 into the 'Go to' - field. Expected 
> result: the cursor jumps to the entered line number (column 0).
> Repeat the test with a script inside an object's content.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

> On Sept. 11, 2012, 3:24 a.m., Lance Corrimal wrote:
> > Tested it in a viewer-development based build. Works fine for scripts in my 
> > inv as well as for scripts in objects.
> > One thing though, hitting enter when entering the line number shgould be 
> > enough, clicking the ok button is a bit of a pain.

I wanted to keep the design close to the 'search' function. I know you are 
right about the Enter key, and I am missing that feature in the Search box, as 
well.
It would be cool if we could add that to both, the 'search' and the 'goto' 
window. Let's talk at the next UG meeting with Oz about that.
Thank you much for testing this / and your feedback.


- MartinRJ


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/#review1251
---


On Sept. 11, 2012, 2:39 a.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/596/
> ---
> 
> (Updated Sept. 11, 2012, 2:39 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/bug-59
> 
> I more or less cloned the search-function and modified the floater via xml 
> (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
> Also I added a callback to prevalidate the input in the 'go to line' 
> line-editor, so that only numbers can be entered into it.
> 
> 
> This addresses bug BUG-59.
> https://jira.secondlife.com/browse/BUG-59
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 7ae099f5a764 
>   indra/newview/llpreviewscript.h 7ae099f5a764 
>   indra/newview/llpreviewscript.cpp 7ae099f5a764 
>   indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml 7ae099f5a764 
> 
> Diff: http://codereview.secondlife.com/r/596/diff/diff
> 
> 
> Testing
> ---
> 
> Tested on my local PC with a modded "3.3.4-release3" version.
> Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
> to line', enter a number less than 300 into the 'Go to' - field. Expected 
> result: the cursor jumps to the entered line number (column 0).
> Repeat the test with a script inside an object's content.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 5:52 a.m.)


Review request for Viewer.


Changes
---

Added the proposed changes(kelly and lance): jumping to the next match on 
commit (search-and-replace-floater); jump to the line and close on commit 
(goto-floater).


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/diff


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 6:20 a.m.)


Review request for Viewer.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/diff


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 8:38 a.m.)


Review request for Viewer.


Changes
---

Fix: The current selection needs to be deselected before I can move the cursor 
to it's new position.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[Kelly Washington]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/#review1262
---



indra/newview/llpreviewscript.cpp


Please put new classes in a new file. (Don't mimic my bad code from years 
ago, please. :) )



indra/newview/llpreviewscript.cpp


Need null checks on mEditorCore and mEditor



indra/newview/llpreviewscript.cpp


Need null checks on mEditorCore, mEditor and sInstance



indra/newview/llpreviewscript.cpp


minor note: This comment is backwards from the code - you describe the 
unwritten else case instead of the implemented if case. It confused me at 
first. Something like '// only deselect, setfocus and close if the cursor 
actually moved' would match the code written, or moving the comment to after 
the if block with something like '// else do nothing '



indra/newview/llpreviewscript.cpp


Need null pointer checks on mEditorCore and mEditor.


- Kelly Washington


On Sept. 13, 2012, 8:38 a.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/596/
> ---
> 
> (Updated Sept. 13, 2012, 8:38 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/bug-59
> 
> I more or less cloned the search-function and modified the floater via xml 
> (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
> Also I added a callback to prevalidate the input in the 'go to line' 
> line-editor, so that only numbers can be entered into it.
> 
> 
> This addresses bug BUG-59.
> https://jira.secondlife.com/browse/BUG-59
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 7a056d7afeb2 
>   indra/newview/llpreviewscript.h 7a056d7afeb2 
>   indra/newview/llpreviewscript.cpp 7a056d7afeb2 
>   indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 
> 
> Diff: http://codereview.secondlife.com/r/596/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local PC with a modded "3.3.4-release3" version.
> Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
> to line', enter a number less than 300 into the 'Go to' - field. Expected 
> result: the cursor jumps to the entered line number (column 0).
> Repeat the test with a script inside an object's content.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 18, 2012, 4:11 p.m.)


Review request for Viewer.


Changes
---

I moved LLFloaterGotoLine into a new class file (llfloatergotoline.cpp with the 
header file llfloatergotoline.h), according to Kelly's review (and updated 
CMakeLists.txt),
added some null-checks in LLFloaterGotoLine and LLFloaterScriptSearch,
and I set "setCommitOnFocusLost" to FALSE (for the lineeditor in 
LLFloaterGotoLine::postBuild / LLFloaterScriptSearch::postBuild), to prevent 
unexpected commits/search.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/CMakeLists.txt 7a056d7afeb2 
  indra/newview/llfloatergotoline.h PRE-CREATION 
  indra/newview/llfloatergotoline.cpp PRE-CREATION 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 18, 2012, 4:12 p.m.)


Review request for Viewer.


Changes
---

New repository: https://bitbucket.org/MartinRJ/storm-1911


Description (updated)
---

Repository is here: https://bitbucket.org/MartinRJ/storm-1911

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/CMakeLists.txt 7a056d7afeb2 
  indra/newview/llfloatergotoline.h PRE-CREATION 
  indra/newview/llfloatergotoline.cpp PRE-CREATION 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges