[opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-14 Thread Aleric Inglewood 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/
---

Review request for Viewer.


Summary
---

Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)


This addresses bug VWR-24317.
http://jira.secondlife.com/browse/VWR-24317


Diffs
-

  doc/contributions.txt b0bd26c5638a 
  indra/llui/llnotifications.cpp b0bd26c5638a 

Diff: http://codereview.secondlife.com/r/87/diff


Testing
---


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/#review172
---



indra/llui/llnotifications.cpp


I don't like leaving in commented-out code.

I would prefer that this either be changed to a debug level message or 
deleted.


- Oz


On Jan. 14, 2011, 12:56 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/87/
> ---
> 
> (Updated Jan. 14, 2011, 12:56 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed a typo that I stumbled upon and added quotes,
> and changed the warning to print something that makes
> more sense ('replacement' is always empty, since we
> didn't find it!)
> 
> 
> This addresses bug VWR-24317.
> http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/llui/llnotifications.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/87/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Aleric Inglewood 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/
---

(Updated Jan. 17, 2011, 5:32 a.m.)


Review request for Viewer.


Changes
---

Got rid of commented out debug output in replaceSubstitutionStrings. Deleted 
the first llwarns and changed a second one into lldebugs.


Summary
---

Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)


This addresses bug VWR-24317.
http://jira.secondlife.com/browse/VWR-24317


Diffs (updated)
-

  doc/contributions.txt b0bd26c5638a 
  indra/llui/llnotifications.cpp b0bd26c5638a 

Diff: http://codereview.secondlife.com/r/87/diff


Testing
---


Thanks,

Aleric

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Tateru Nino 
I confess to not liking leaving in incorrectly spelled commented code. 
Just saying.


On 17/01/2011 11:31 PM, Oz Linden wrote:
This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/87/



indra/llui/llnotifications.cpp 
 
(Diff revision 1)

void replaceSubstitutionStrings(LLXMLNodePtr node, StringMap&  replacements)
1384
//llwarns<<  "replaceSubstituionStrings: value: "<<  value<<  " 
repl: "<<  replacement<<  llendl;
1384
//llinfos<<  "replaceSubstitutionStrings: value:\""<<  value<<  "\"  
repl:\""<<  replacement<<  "\"."<<  llendl;

I don't like leaving in commented-out code.

I would prefer that this either be changed to a debug level message or deleted.

- Oz


On January 14th, 2011, 12:56 p.m., Aleric Inglewood wrote:

Review request for Viewer.
By Aleric Inglewood.

/Updated Jan. 14, 2011, 12:56 p.m./


  Description

Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)

*Bugs: * VWR-24317 


  Diffs

* doc/contributions.txt (b0bd26c5638a)
* indra/llui/llnotifications.cpp (b0bd26c5638a)

View Diff 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


--
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-20 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/#review214
---

Ship it!


- Oz


On Jan. 17, 2011, 5:32 a.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/87/
> ---
> 
> (Updated Jan. 17, 2011, 5:32 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed a typo that I stumbled upon and added quotes,
> and changed the warning to print something that makes
> more sense ('replacement' is always empty, since we
> didn't find it!)
> 
> 
> This addresses bug VWR-24317.
> http://jira.secondlife.com/browse/VWR-24317
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/llui/llnotifications.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/87/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges