[openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
Hi, Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Cheers, Thomas Goirand (zigo) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
Hi Thomas, Thomas Goirand z...@debian.org wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Why is Selenium considered non-free? The code is Apache-licensed, including the Python bindings. FWIW only a few of the unit tests use Selenium (and those that do, need to), and they're not run by default unless you set a flag to do so. Julie ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 04/07/13 11:27, Thomas Goirand wrote: Hi, Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Thank you for the heads-up. Selenium is used for tests during development, it is not a runtime requirement at all. Would that still make it non-free for Debian? How did Horizon went into Debian packages at all, since the situation in this front is unchanged for at least a year (just curious). Matthias ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On Thu, Jul 04 2013, Julie Pichon wrote: Thomas Goirand z...@debian.org wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Why is Selenium considered non-free? The code is Apache-licensed, including the Python bindings. FWIW only a few of the unit tests use Selenium (and those that do, need to), and they're not run by default unless you set a flag to do so. Yes, that seems like a mistake from the Debian packager as far as I can tell. There's nothing that requires it to be in non-free. (Cc'ing Sascha, the maintainer) -- Julien Danjou ;; Free Software hacker ; freelance consultant ;; http://julien.danjou.info signature.asc Description: PGP signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 07/04/2013 02:34 PM, Sascha Peilicke wrote: On 07/04/2013 12:03 PM, Matthias Runge wrote: On 04/07/13 11:27, Thomas Goirand wrote: Hi, Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Thank you for the heads-up. Selenium is used for tests during development, it is not a runtime requirement at all. Would that still make it non-free for Debian? BTW. this is identical for openSUSE. How did Horizon went into Debian packages at all, since the situation in this front is unchanged for at least a year (just curious). At least here, our horizon test package just doesn't depend on selenium. This could help: https://review.openstack.org/#/c/35649/ -- Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
Hi Sascha, Sascha Peilicke speili...@suse.com wrote: On 07/04/2013 02:34 PM, Sascha Peilicke wrote: On 07/04/2013 12:03 PM, Matthias Runge wrote: On 04/07/13 11:27, Thomas Goirand wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Thank you for the heads-up. Selenium is used for tests during development, it is not a runtime requirement at all. Would that still make it non-free for Debian? BTW. this is identical for openSUSE. How did Horizon went into Debian packages at all, since the situation in this front is unchanged for at least a year (just curious). At least here, our horizon test package just doesn't depend on selenium. This could help: https://review.openstack.org/#/c/35649/ Could you explain why Selenium is considered to be non-free? Thanks, Julie ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On Thu, Jul 04 2013, Daniel P. Berrange wrote: Assuming you're referring to the 'python-selenum' package in Debian, Google throws up this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 the package ships some files which are not yet built from source. Whether this is still accurate or not, is another matter, since that bz is 2 years old... And the debian/copyright file doesn't mention that, so that seems somehow a policy violation to me. -- Julien Danjou /* Free Software hacker * freelance consultant http://julien.danjou.info */ signature.asc Description: PGP signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 07/04/2013 06:10 PM, Julien Danjou wrote: On Thu, Jul 04 2013, Julie Pichon wrote: Thomas Goirand z...@debian.org wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Why is Selenium considered non-free? The code is Apache-licensed, including the Python bindings. FWIW only a few of the unit tests use Selenium (and those that do, need to), and they're not run by default unless you set a flag to do so. Yes, that seems like a mistake from the Debian packager as far as I can tell. There's nothing that requires it to be in non-free. (Cc'ing Sascha, the maintainer) Well, see this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 There are files not built from source. Also, when looking at the package, it seems that it isn't maintained as good as it deserves. #700061 was opened in 08 Feb 2013, and there's no answer at all from Sascha to this bug (which is RC). That well may have been the reason why this package was removed from testing on the 6th of march (according to the Debian pts). IMO, the maintainer should have at least answered to the bug. Anyway, what isn't explained in #636677, is what is non-free. So I had a look. To me, what is not built from source is what is in py/selenium/webdriver: there is a webdriver.xpi in the firefox folder. Though the maintainer should have write about it, so we don't have to double-guess (it should be clearly documented in debian/copyright). Which part of Selenium is in use in the unit testings of Horizon? Could we imagine that this part of the unit testing be made optional? Like for example, only if python-selenium is installed, or else the tests are gracefully skipped? Cheers, Thomas Goirand (zigo) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 04/07/13 15:55, Daniel P. Berrange wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 the package ships some files which are not yet built from source. Whether this is still accurate or not, is another matter, since that bz is 2 years old... I remember that I filed a bug, because selenium shipped a binary web driver adapter for firefox. E.g there are prebuilt files checked into seleniums svn: http://selenium.googlecode.com/svn/tags/selenium-2.28.0/cpp/prebuilt/ which are/were required to build the whole thing. That was the point where I stopped packaging it for Fedora. Matthias ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 07/04/2013 03:55 PM, Daniel P. Berrange wrote: On Thu, Jul 04, 2013 at 09:34:01AM -0400, Julie Pichon wrote: Hi Sascha, Sascha Peilicke speili...@suse.com wrote: On 07/04/2013 02:34 PM, Sascha Peilicke wrote: On 07/04/2013 12:03 PM, Matthias Runge wrote: On 04/07/13 11:27, Thomas Goirand wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Thank you for the heads-up. Selenium is used for tests during development, it is not a runtime requirement at all. Would that still make it non-free for Debian? BTW. this is identical for openSUSE. How did Horizon went into Debian packages at all, since the situation in this front is unchanged for at least a year (just curious). At least here, our horizon test package just doesn't depend on selenium. This could help: https://review.openstack.org/#/c/35649/ Could you explain why Selenium is considered to be non-free? Assuming you're referring to the 'python-selenum' package in Debian, Google throws up this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 the package ships some files which are not yet built from source. This also matches our (as in openSUSE's) definition, python-selenium ships: /usr/lib/python2.7/site-packages/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so /usr/lib/python2.7/site-packages/selenium/webdriver/firefox/x86/x_ignore_nofocus.so /usr/lib/python2.7/site-packages/selenium/webdriver/firefox/webdriver.xpi While in theory they could be build from source, it's simply too much effort. Also, it depends on selenium (the Java thing) which to my knowledge isn't part of any OSS distro because building Java packages is the biggest PITA of all. Usually, such packages are available in 3rd-party repos. Still, we have to patch it away. -- Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
On 07/04/2013 04:06 PM, Thomas Goirand wrote: On 07/04/2013 06:10 PM, Julien Danjou wrote: On Thu, Jul 04 2013, Julie Pichon wrote: Thomas Goirand z...@debian.org wrote: Horizon seems to use python-selenium. The problem is that, in Debian, this package is in the non-free repository. So I strongly suggest to not use it for Havana. That otherwise would put Horizon into the contrib repository of Debian (eg: not officially in Debian), or eventually, remove any possibility to run the unit tests, which isn't nice. Why is Selenium considered non-free? The code is Apache-licensed, including the Python bindings. FWIW only a few of the unit tests use Selenium (and those that do, need to), and they're not run by default unless you set a flag to do so. Yes, that seems like a mistake from the Debian packager as far as I can tell. There's nothing that requires it to be in non-free. (Cc'ing Sascha, the maintainer) Well, see this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 There are files not built from source. Also, when looking at the package, it seems that it isn't maintained as good as it deserves. #700061 was opened in 08 Feb 2013, and there's no answer at all from Sascha to this bug (which is RC). I am sorry, but I'm an openSUSE guy. But I can tell you we had similar bugs :-) https://bugzilla.novell.com/show_bug.cgi?id=755619 That well may have been the reason why this package was removed from testing on the 6th of march (according to the Debian pts). IMO, the maintainer should have at least answered to the bug. Anyway, what isn't explained in #636677, is what is non-free. So I had a look. To me, what is not built from source is what is in py/selenium/webdriver: there is a webdriver.xpi in the firefox folder. Though the maintainer should have write about it, so we don't have to double-guess (it should be clearly documented in debian/copyright). Which part of Selenium is in use in the unit testings of Horizon? Could we imagine that this part of the unit testing be made optional? Like for example, only if python-selenium is installed, or else the tests are gracefully skipped? Cheers, Thomas Goirand (zigo) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
Matthias Runge mru...@redhat.com wrote: On 04/07/13 15:55, Daniel P. Berrange wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 the package ships some files which are not yet built from source. Whether this is still accurate or not, is another matter, since that bz is 2 years old... I remember that I filed a bug, because selenium shipped a binary web driver adapter for firefox. E.g there are prebuilt files checked into seleniums svn: http://selenium.googlecode.com/svn/tags/selenium-2.28.0/cpp/prebuilt/ which are/were required to build the whole thing. That was the point where I stopped packaging it for Fedora. Thanks for the link Daniel, and Matthias for the extra information. I assume this is the same issue openSUSE has with the package (my google-fu is failing me for finding a bug). Cheers, Julie ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] python-selenium is non-free, Horizon shouldn't use it
Sascha Peilicke speili...@suse.com wrote: On 07/04/2013 04:06 PM, Thomas Goirand wrote: On 07/04/2013 06:10 PM, Julien Danjou wrote: On Thu, Jul 04 2013, Julie Pichon wrote: Why is Selenium considered non-free? The code is Apache-licensed, including the Python bindings. FWIW only a few of the unit tests use Selenium (and those that do, need to), and they're not run by default unless you set a flag to do so. Yes, that seems like a mistake from the Debian packager as far as I can tell. There's nothing that requires it to be in non-free. (Cc'ing Sascha, the maintainer) Well, see this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 There are files not built from source. Also, when looking at the package, it seems that it isn't maintained as good as it deserves. #700061 was opened in 08 Feb 2013, and there's no answer at all from Sascha to this bug (which is RC). I am sorry, but I'm an openSUSE guy. But I can tell you we had similar bugs :-) I think Thomas was talking about Sascha Girrulat, the maintainer for the Debian package. https://bugzilla.novell.com/show_bug.cgi?id=755619 It looks like I am not authorised to access this bug, thanks for the link though. I understand the idea :) Julie ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
