Re: [openstack-dev] [neutron] [infra] Depends-on tag effect

[Hirofumi Ichihara]

On 2017/03/09 2:33, Armando M. wrote:



On 8 March 2017 at 07:39, Hirofumi Ichihara 
> wrote:




On 2017/03/08 23:59, Andreas Jaeger wrote:

On 2017-03-08 15:40, ZZelle wrote:

Hi,

iiuc, neutron uses a released version of neutron-lib not
neutron-lib
master ... So the change should depends on a change in
requirements repo
incrementing neutron-lib version

This is documented also at - together with some other caveats:


https://docs.openstack.org/infra/manual/developers.html#limitations-and-caveats



Thank you for the pointer. I understand.


You can do the reverse as documented in [1]: i.e. file a dummy patch 
against neutron-lib that pulls in both neutron's and neutron-lib 
changes. One example is [2]


[1] 
https://docs.openstack.org/developer/neutron-lib/review-guidelines.html

[2] https://review.openstack.org/#/c/386846/

That makes sense. I missed the documentation. Thank you for your help.




Hirofumi




Note a depends-on requirements won't work either - you really
need to
release it. Or you need to change the test to pull neutron-lib
from source,

Andreas

On Wed, Mar 8, 2017 at 3:16 PM, Hirofumi Ichihara

>> wrote:

 Hi,

 I thought that we can post neutron patch depending on
neutron-lib
 patch under review.
 However, I saw it doesn't work[1, 2]. In the patches,
neutron
 patch[1] has Depends-on tag with neutron-lib patch[2]
but the pep8
 and unit test fails because the test doesn't use the
neutron-lib patch.

 Please correct me if it's my misunderstanding.

 [1]: https://review.openstack.org/#/c/424340/

 >
 [2]: https://review.openstack.org/#/c/424868/

 >

 Thanks,
 Hirofumi



   
 __

 OpenStack Development Mailing List (not for usage
questions)
 Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe


   
 >
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

   
 >





__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe


http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev







__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev





__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 

Re: [openstack-dev] [neutron] [infra] Depends-on tag effect

[Hirofumi Ichihara]

On 2017/03/08 23:59, Andreas Jaeger wrote:

On 2017-03-08 15:40, ZZelle wrote:

Hi,

iiuc, neutron uses a released version of neutron-lib not neutron-lib
master ... So the change should depends on a change in requirements repo
incrementing neutron-lib version

This is documented also at - together with some other caveats:

https://docs.openstack.org/infra/manual/developers.html#limitations-and-caveats

Thank you for the pointer. I understand.

Hirofumi




Note a depends-on requirements won't work either - you really need to
release it. Or you need to change the test to pull neutron-lib from source,

Andreas

On Wed, Mar 8, 2017 at 3:16 PM, Hirofumi Ichihara
> wrote:

 Hi,

 I thought that we can post neutron patch depending on neutron-lib
 patch under review.
 However, I saw it doesn't work[1, 2]. In the patches, neutron
 patch[1] has Depends-on tag with neutron-lib patch[2] but the pep8
 and unit test fails because the test doesn't use the neutron-lib patch.

 Please correct me if it's my misunderstanding.

 [1]: https://review.openstack.org/#/c/424340/
 
 [2]: https://review.openstack.org/#/c/424868/
 

 Thanks,
 Hirofumi



 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe:
 openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev








__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [neutron] [infra] Depends-on tag effect

[Andreas Jaeger]

On 2017-03-08 15:40, ZZelle wrote:
> Hi,
> 
> iiuc, neutron uses a released version of neutron-lib not neutron-lib
> master ... So the change should depends on a change in requirements repo
> incrementing neutron-lib version

This is documented also at - together with some other caveats:

https://docs.openstack.org/infra/manual/developers.html#limitations-and-caveats


Note a depends-on requirements won't work either - you really need to
release it. Or you need to change the test to pull neutron-lib from source,

Andreas
> 
> On Wed, Mar 8, 2017 at 3:16 PM, Hirofumi Ichihara
>  > wrote:
> 
> Hi,
> 
> I thought that we can post neutron patch depending on neutron-lib
> patch under review.
> However, I saw it doesn't work[1, 2]. In the patches, neutron
> patch[1] has Depends-on tag with neutron-lib patch[2] but the pep8
> and unit test fails because the test doesn't use the neutron-lib patch.
> 
> Please correct me if it's my misunderstanding.
> 
> [1]: https://review.openstack.org/#/c/424340/
> 
> [2]: https://review.openstack.org/#/c/424868/
> 
> 
> Thanks,
> Hirofumi
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [neutron] [infra] Depends-on tag effect

[ZZelle]

Hi,

iiuc, neutron uses a released version of neutron-lib not neutron-lib master
... So the change should depends on a change in requirements repo
incrementing neutron-lib version

On Wed, Mar 8, 2017 at 3:16 PM, Hirofumi Ichihara <
ichihara.hirof...@lab.ntt.co.jp> wrote:

> Hi,
>
> I thought that we can post neutron patch depending on neutron-lib patch
> under review.
> However, I saw it doesn't work[1, 2]. In the patches, neutron patch[1] has
> Depends-on tag with neutron-lib patch[2] but the pep8 and unit test fails
> because the test doesn't use the neutron-lib patch.
>
> Please correct me if it's my misunderstanding.
>
> [1]: https://review.openstack.org/#/c/424340/
> [2]: https://review.openstack.org/#/c/424868/
>
> Thanks,
> Hirofumi
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [neutron] [infra] Depends-on tag effect

[Hirofumi Ichihara]

Hi,

I thought that we can post neutron patch depending on neutron-lib patch  
under review.
However, I saw it doesn't work[1, 2]. In the patches, neutron patch[1]  
has Depends-on tag with neutron-lib patch[2] but the pep8 and unit test  
fails because the test doesn't use the neutron-lib patch.


Please correct me if it's my misunderstanding.

[1]: https://review.openstack.org/#/c/424340/
[2]: https://review.openstack.org/#/c/424868/

Thanks,
Hirofumi



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev