Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 1/20/2017 9:20 AM, Jeremy Stanley wrote: Do you have example logs for those failures so we can compare them to the timeline for the fix landing? When a change enters a Zuul pipeline, it and its open parent changes are unconditionally merged to the current branch tip and then jobs are run against that state (and if the changes are unable to be merged to the branch tip without conflict, Zuul immediately reports back with a merge failure rather than running any jobs). Yeah, this is the failure in the gate before I rebased it [1]. This is the change that was needed for the rebase [2]. Looking at when [1] failed and [2] merged, it looks like it [2] merged an hour later, so yeah, I guess I thought the other was already merged when I rebased [1]. So the world isn't ruined. [1] http://logs.openstack.org/37/410737/5/gate/gate-nova-python35-db/1a828b8/console.html#_2017-01-19_23_23_36_271935 [2] https://review.openstack.org/#/c/421482/ -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 2017-01-20 08:53:19 -0600 (-0600), Matt Riedemann wrote: [...] > Yeah idk, but that wasn't working, I had already rechecked once > and those changes were failing on the thing noted above, and only > fixed once I rebased them. Do you have example logs for those failures so we can compare them to the timeline for the fix landing? When a change enters a Zuul pipeline, it and its open parent changes are unconditionally merged to the current branch tip and then jobs are run against that state (and if the changes are unable to be merged to the branch tip without conflict, Zuul immediately reports back with a merge failure rather than running any jobs). -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 1/20/2017 7:46 AM, Andreas Jaeger wrote: You shouldn't need to rebase changes - we always rebase in check and gate queue before running tests. So, a simple "recheck" should be enough. Andreas Yeah idk, but that wasn't working, I had already rechecked once and those changes were failing on the thing noted above, and only fixed once I rebased them. -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 2017-01-20 14:36, Matt Riedemann wrote:
> On 1/20/2017 2:22 AM, Sylvain Bauza wrote:
>>
>>
>> Le 20/01/2017 04:16, Matt Riedemann a écrit :
>>> On 1/19/2017 5:09 PM, Matt Riedemann wrote:
On 1/19/2017 10:56 AM, Matt Riedemann wrote:
> The py35 unit test job is broken for Nova until this patch is merged:
>
> https://review.openstack.org/#/c/422709/
>
> So please hold off on the rechecks until that happens.
>
We're good to go again for rechecks.
>>>
>>> Just a heads up that if you still see py35 unit test failures with a
>>> TypeError like this [1] then you need to rebase you patch.
>>>
>>> [1]
>>> http://logs.openstack.org/37/410737/5/check/gate-nova-python35-db/4fec66c/console.html#_2017-01-20_01_56_21_021702
>>>
>>>
>>>
>>
>> Just for understanding correctly the context, which merged change fixes
>> that, needing a rebase ?
>>
>>
>> __
>>
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> Not merged changes, changes in the check queue. I had noticed a couple
> of approved changes yesterday were failing on oslo.serialization 2.16.0
> in upper-constraints so those needed to be rebased to pick this up:
>
> https://github.com/openstack/nova/commit/161799edaab21ea7b4f577766764768fa6c39e5d
You shouldn't need to rebase changes - we always rebase in check and
gate queue before running tests. So, a simple "recheck" should be enough.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 1/20/2017 2:22 AM, Sylvain Bauza wrote: Le 20/01/2017 04:16, Matt Riedemann a écrit : On 1/19/2017 5:09 PM, Matt Riedemann wrote: On 1/19/2017 10:56 AM, Matt Riedemann wrote: The py35 unit test job is broken for Nova until this patch is merged: https://review.openstack.org/#/c/422709/ So please hold off on the rechecks until that happens. We're good to go again for rechecks. Just a heads up that if you still see py35 unit test failures with a TypeError like this [1] then you need to rebase you patch. [1] http://logs.openstack.org/37/410737/5/check/gate-nova-python35-db/4fec66c/console.html#_2017-01-20_01_56_21_021702 Just for understanding correctly the context, which merged change fixes that, needing a rebase ? __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Not merged changes, changes in the check queue. I had noticed a couple of approved changes yesterday were failing on oslo.serialization 2.16.0 in upper-constraints so those needed to be rebased to pick this up: https://github.com/openstack/nova/commit/161799edaab21ea7b4f577766764768fa6c39e5d -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
Le 20/01/2017 04:16, Matt Riedemann a écrit : > On 1/19/2017 5:09 PM, Matt Riedemann wrote: >> On 1/19/2017 10:56 AM, Matt Riedemann wrote: >>> The py35 unit test job is broken for Nova until this patch is merged: >>> >>> https://review.openstack.org/#/c/422709/ >>> >>> So please hold off on the rechecks until that happens. >>> >> >> We're good to go again for rechecks. >> > > Just a heads up that if you still see py35 unit test failures with a > TypeError like this [1] then you need to rebase you patch. > > [1] > http://logs.openstack.org/37/410737/5/check/gate-nova-python35-db/4fec66c/console.html#_2017-01-20_01_56_21_021702 > > Just for understanding correctly the context, which merged change fixes that, needing a rebase ? __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
For other failure on "expected_attr" error, we need this to merge - https://review.openstack.org/#/c/422323/ on nova side. -gmann > -Original Message- > From: Matt Riedemann [mailto:mriede...@gmail.com] > Sent: 20 January 2017 12:17 > To: openstack-dev@lists.openstack.org > Subject: Re: [openstack-dev] [nova] Do not recheck changes until 422709 is > merged > > On 1/19/2017 5:09 PM, Matt Riedemann wrote: > > On 1/19/2017 10:56 AM, Matt Riedemann wrote: > >> The py35 unit test job is broken for Nova until this patch is merged: > >> > >> https://review.openstack.org/#/c/422709/ > >> > >> So please hold off on the rechecks until that happens. > >> > > > > We're good to go again for rechecks. > > > > Just a heads up that if you still see py35 unit test failures with a > TypeError like > this [1] then you need to rebase you patch. > > [1] > http://logs.openstack.org/37/410737/5/check/gate-nova-python35- > db/4fec66c/console.html#_2017-01-20_01_56_21_021702 > > -- > > Thanks, > > Matt Riedemann > > __ > > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev- > requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 1/19/2017 5:09 PM, Matt Riedemann wrote: On 1/19/2017 10:56 AM, Matt Riedemann wrote: The py35 unit test job is broken for Nova until this patch is merged: https://review.openstack.org/#/c/422709/ So please hold off on the rechecks until that happens. We're good to go again for rechecks. Just a heads up that if you still see py35 unit test failures with a TypeError like this [1] then you need to rebase you patch. [1] http://logs.openstack.org/37/410737/5/check/gate-nova-python35-db/4fec66c/console.html#_2017-01-20_01_56_21_021702 -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] Do not recheck changes until 422709 is merged
On 1/19/2017 10:56 AM, Matt Riedemann wrote: The py35 unit test job is broken for Nova until this patch is merged: https://review.openstack.org/#/c/422709/ So please hold off on the rechecks until that happens. We're good to go again for rechecks. -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova] Do not recheck changes until 422709 is merged
The py35 unit test job is broken for Nova until this patch is merged: https://review.openstack.org/#/c/422709/ So please hold off on the rechecks until that happens. -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
