Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation
Any news here? Per-socket solution is a conservative solution that makes zeromq driver work for multiple-workers. Neutron-server has api-worker and rpc-worker. I'm not sure per-driver is applicable. I will try to figure it out soon. On Fri, Jan 23, 2015 at 7:53 PM, Oleksii Zamiatin ozamia...@mirantis.com wrote: 23.01.15, 13:22, Elena Ezhova пишет: On Fri, Jan 23, 2015 at 1:55 PM, Ilya Pekelny ipeke...@mirantis.com wrote: On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin ozamia...@mirantis.com wrote: IMHO It should be created once per Reactor/Client or even per driver instance. Per driver, sounds good. Wouldn't this create regression for Neutron? The original change was supposed to fix the bug [1], where each api-worker process got the same copy of the Context due to its singletony nature. It wouldn't be a singleton now, beacuse each process should have it's own driver instance. We of course will check this case. Each api-worker should take their own context. The purpose now is to have not more than one context per worker. By the way (I didn't check it yet with current implementation of the driver) such approach should break the IPC, because such kind of sockets should be produced from the same context. Please, check it. Looks like a potential bug. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev [1] https://bugs.launchpad.net/neutron/+bug/1364814 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Li Ma (Nick) Email: skywalker.n...@gmail.com __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation
23.01.15, 13:22, Elena Ezhova ?: On Fri, Jan 23, 2015 at 1:55 PM, Ilya Pekelny ipeke...@mirantis.com mailto:ipeke...@mirantis.com wrote: On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin ozamia...@mirantis.com mailto:ozamia...@mirantis.com wrote: IMHO It should be created once per Reactor/Client or even per driver instance. Per driver, sounds good. Wouldn't this create regression for Neutron? The original change was supposed to fix the bug [1], where each api-worker process got the same copy of the Context due to its singletony nature. It wouldn't be a singleton now, beacuse each process should have it's own driver instance. We of course will check this case. Each api-worker should take their own context. The purpose now is to have not more than one context per worker. By the way (I didn't check it yet with current implementation of the driver) such approach should break the IPC, because such kind of sockets should be produced from the same context. Please, check it. Looks like a potential bug. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev [1] https://bugs.launchpad.net/neutron/+bug/1364814 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation
Hi, Working on zmq driver I've noticed that for now zmq.Context is created per socket which is definitely redundant. That was introduced by the change https://review.openstack.org/#/c/126914/5/oslo/messaging/_drivers/impl_zmq.py It makes the correct thing reducing the global context variable, but I think the context is still should have more global scope than per socket. IMHO It should be created once per Reactor/Client or even per driver instance. By the way (I didn't check it yet with current implementation of the driver) such approach should break the IPC, because such kind of sockets should be produced from the same context. Regards, Oleksii Zamiatin __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation
On Fri, Jan 23, 2015 at 1:55 PM, Ilya Pekelny ipeke...@mirantis.com wrote: On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin ozamia...@mirantis.com wrote: IMHO It should be created once per Reactor/Client or even per driver instance. Per driver, sounds good. Wouldn't this create regression for Neutron? The original change was supposed to fix the bug [1], where each api-worker process got the same copy of the Context due to its singletony nature. By the way (I didn't check it yet with current implementation of the driver) such approach should break the IPC, because such kind of sockets should be produced from the same context. Please, check it. Looks like a potential bug. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev [1] https://bugs.launchpad.net/neutron/+bug/1364814 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo.messaging][zmq] Redundant zmq.Context creation
On Fri, Jan 23, 2015 at 12:46 PM, ozamiatin ozamia...@mirantis.com wrote: IMHO It should be created once per Reactor/Client or even per driver instance. Per driver, sounds good. By the way (I didn't check it yet with current implementation of the driver) such approach should break the IPC, because such kind of sockets should be produced from the same context. Please, check it. Looks like a potential bug. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
