Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Henry Nash]

Great, thanks.

Henry
> On 4 Sep 2015, at 09:17, Thierry Carrez  wrote:
> 
> Morgan Fainberg wrote:
>> 
>>>I would like to request an FFE for the remaining two patches that
>>>are already in review
>>>(https://review.openstack.org/#/c/153897/ and 
>>> https://review.openstack.org/#/c/154485/). 
>>>These contain only test code and no functional changes, and
>>>increase our test coverage - as well as enable other items to be
>>>re-use the list_role_assignment backend method.
>>> 
>>> Do we need a FFE for changes to tests?
>>> 
>> 
>> I would say "no". 
> 
> Right. Extra tests (or extra docs for that matter) don't count as a
> "feature" for the freeze. In particular it doesn't change the behavior
> of the software or invalidate testing that may have been conducted.
> 
> -- 
> Thierry Carrez (ttx)
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Morgan Fainberg]

Henry,

I've applied the -2 (for Feature Freeze) to a bunch of patchsets, I think I
excluded your testing ones, but if the testing ones got -2'd please let me
know so I can remove the -2.

--Morgan

On Fri, Sep 4, 2015 at 2:07 AM, Henry Nash 
wrote:

> Great, thanks.
>
> Henry
> > On 4 Sep 2015, at 09:17, Thierry Carrez  wrote:
> >
> > Morgan Fainberg wrote:
> >>
> >>>I would like to request an FFE for the remaining two patches that
> >>>are already in review
> >>>(https://review.openstack.org/#/c/153897/ and
> https://review.openstack.org/#/c/154485/).
> >>>These contain only test code and no functional changes, and
> >>>increase our test coverage - as well as enable other items to be
> >>>re-use the list_role_assignment backend method.
> >>>
> >>> Do we need a FFE for changes to tests?
> >>>
> >>
> >> I would say "no".
> >
> > Right. Extra tests (or extra docs for that matter) don't count as a
> > "feature" for the freeze. In particular it doesn't change the behavior
> > of the software or invalidate testing that may have been conducted.
> >
> > --
> > Thierry Carrez (ttx)
> >
> >
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Thierry Carrez]

Morgan Fainberg wrote:
> 
>> I would like to request an FFE for the remaining two patches that
>> are already in review
>> (https://review.openstack.org/#/c/153897/ and 
>> https://review.openstack.org/#/c/154485/). 
>> These contain only test code and no functional changes, and
>> increase our test coverage - as well as enable other items to be
>> re-use the list_role_assignment backend method.
>>
>> Do we need a FFE for changes to tests?
>>
> 
> I would say "no". 

Right. Extra tests (or extra docs for that matter) don't count as a
"feature" for the freeze. In particular it doesn't change the behavior
of the software or invalidate testing that may have been conducted.

-- 
Thierry Carrez (ttx)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Henry Nash]

The approved Keystone Blueprint (https://review.openstack.org/#/c/190996/ 
) for enhancing our testing of the 
assignment backend was split into 7 patches. 5 of these landed before the 
liberty-3 freeze, but two had not yet been approved.

I would like to request an FFE for the remaining two patches that are already 
in review (https://review.openstack.org/#/c/153897/ 
 and 
https://review.openstack.org/#/c/154485/ 
).  These contain only test code and 
no functional changes, and increase our test coverage - as well as enable other 
items to be re-use the list_role_assignment backend method.

Henry__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Morgan Fainberg]

> On Sep 3, 2015, at 19:48, Morgan Fainberg  wrote:
> 
> 
> 
> 
>> On Sep 3, 2015, at 19:28, David Stanek  wrote:
>> 
>> 
>>> On Thu, Sep 3, 2015 at 3:44 PM Henry Nash  wrote:
>>> 
>>> I would like to request an FFE for the remaining two patches that are 
>>> already in review (https://review.openstack.org/#/c/153897/ and 
>>> https://review.openstack.org/#/c/154485/).  These contain only test code 
>>> and no functional changes, and increase our test coverage - as well as 
>>> enable other items to be re-use the list_role_assignment backend method.
>> 
>> Do we need a FFE for changes to tests?
> 
> I would say "no". 

To clarify "no" a FFE is not needed here. Not "no" to the additional testing. __
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[Morgan Fainberg]

> On Sep 3, 2015, at 19:28, David Stanek  wrote:
> 
> 
>> On Thu, Sep 3, 2015 at 3:44 PM Henry Nash  wrote:
>> 
>> I would like to request an FFE for the remaining two patches that are 
>> already in review (https://review.openstack.org/#/c/153897/ and 
>> https://review.openstack.org/#/c/154485/).  These contain only test code and 
>> no functional changes, and increase our test coverage - as well as enable 
>> other items to be re-use the list_role_assignment backend method.
> 
> Do we need a FFE for changes to tests?
> 

I would say "no". 
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] FFE Request for completion of data driven assignment testing in Keystone

[David Stanek]

On Thu, Sep 3, 2015 at 3:44 PM Henry Nash  wrote:

>
> I would like to request an FFE for the remaining two patches that are
> already in review (https://review.openstack.org/#/c/153897/ and
> https://review.openstack.org/#/c/154485/).  These contain only test code
> and no functional changes, and increase our test coverage - as well as
> enable other items to be re-use the list_role_assignment backend method.
>

Do we need a FFE for changes to tests?

-- David
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev