Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review
On 2015-02-16 15:29:55 +0100 (+0100), Christian Berendt wrote: This way I can display review requests with -1 reviews, yes. On the overview page a +2 review will still hide any -1 reviews. But a -1 review will hide all +1 reviews. I think -1 reviews should be visible regardless of +2 reviews. As far as I can tell, changing that will require modifications in Gerrit, so probably worth opening a feature request bug at http://code.google.com/p/gerrit/issues/list if someone hasn't already. -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review
On 02/14/2015 04:46 PM, Anita Kuno wrote: Using gerrit queries might come in handy here. https://review.openstack.org/Documentation/user-search.html For a start, this gets me all reviews that are open for which I am not the author, where I voted +1 (or better) and someone else voted -1 (or lower). I just gave it a quick test to try it out, it might need refining. NOT owner:self status:open label:Code-Review=+1,self label:Code-Review=-1 This way I can display review requests with -1 reviews, yes. On the overview page a +2 review will still hide any -1 reviews. But a -1 review will hide all +1 reviews. I think -1 reviews should be visible regardless of +2 reviews. Christian. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review
At the moment there are three columns in the Gerrit overiew page showing the status of a review request: * CR (Code-Review) * V (Verified) * Workflow (WF). After a core reviewer +2 (CR) a review request there will be a green hook in the CR column in the overview page, regardless of -1 reviews. Sometimes I do not have the time to have a look in my Gerrit mail folder. Sometimes I do not have the time to manually monitor pending review requests. This is why I sometimes miss a new -1 of a reviewer because it is not shown in the Gerrit overview page when there is already a +2 of a core reviewer. Also a +2 of a core reviewer will overwrite an existing -1 in the Gerrit overview page. Sometimes I do not have the time to remove my +2 after a new -1 (at the moment it is necessary to remove a +2 after a new -1 to be able to see the new -1 on the Gerrit overview page). I would really like to have a fourth column in the Gerrit overview page showing a -1 on a review request even if there is already a +2 of a core reviewer. What do you think about this? And if this idea is appreciated how can this fourth column be added to the Gerrit overview page? Christian. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review
Awesome, I like the idea. On Sat, Feb 14, 2015 at 3:18 PM, Christian Berendt christ...@berendt.io wrote: At the moment there are three columns in the Gerrit overiew page showing the status of a review request: * CR (Code-Review) * V (Verified) * Workflow (WF). After a core reviewer +2 (CR) a review request there will be a green hook in the CR column in the overview page, regardless of -1 reviews. Sometimes I do not have the time to have a look in my Gerrit mail folder. Sometimes I do not have the time to manually monitor pending review requests. This is why I sometimes miss a new -1 of a reviewer because it is not shown in the Gerrit overview page when there is already a +2 of a core reviewer. Also a +2 of a core reviewer will overwrite an existing -1 in the Gerrit overview page. Sometimes I do not have the time to remove my +2 after a new -1 (at the moment it is necessary to remove a +2 after a new -1 to be able to see the new -1 on the Gerrit overview page). I would really like to have a fourth column in the Gerrit overview page showing a -1 on a review request even if there is already a +2 of a core reviewer. What do you think about this? And if this idea is appreciated how can this fourth column be added to the Gerrit overview page? Christian. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- *Regards,* *Romil * __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review
On 02/14/2015 07:12 AM, Romil Gupta wrote: Awesome, I like the idea. On Sat, Feb 14, 2015 at 3:18 PM, Christian Berendt christ...@berendt.io wrote: At the moment there are three columns in the Gerrit overiew page showing the status of a review request: * CR (Code-Review) * V (Verified) * Workflow (WF). After a core reviewer +2 (CR) a review request there will be a green hook in the CR column in the overview page, regardless of -1 reviews. Sometimes I do not have the time to have a look in my Gerrit mail folder. Sometimes I do not have the time to manually monitor pending review requests. This is why I sometimes miss a new -1 of a reviewer because it is not shown in the Gerrit overview page when there is already a +2 of a core reviewer. Also a +2 of a core reviewer will overwrite an existing -1 in the Gerrit overview page. Sometimes I do not have the time to remove my +2 after a new -1 (at the moment it is necessary to remove a +2 after a new -1 to be able to see the new -1 on the Gerrit overview page). I would really like to have a fourth column in the Gerrit overview page showing a -1 on a review request even if there is already a +2 of a core reviewer. What do you think about this? And if this idea is appreciated how can this fourth column be added to the Gerrit overview page? Christian. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Using gerrit queries might come in handy here. https://review.openstack.org/Documentation/user-search.html For a start, this gets me all reviews that are open for which I am not the author, where I voted +1 (or better) and someone else voted -1 (or lower). I just gave it a quick test to try it out, it might need refining. NOT owner:self status:open label:Code-Review=+1,self label:Code-Review=-1 Thanks, Anita. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
