Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/09/2014 02:24 PM, Sean Dague wrote: On 06/09/2014 01:38 PM, David Kranz wrote: On 06/02/2014 06:57 AM, Sean Dague wrote: Towards the end of the summit there was a discussion about us using a shared review dashboard to see if a common view by the team would help accelerate people looking at certain things. I spent some time this weekend working on a tool to make building custom dashboard urls much easier. My current proposal is the following, and would like comments on it: https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash All items in the dashboard are content that you've not voted on in the current patch revision, that you don't own, and that have passing Jenkins test results. 1. QA Specs - these need more eyes, so we highlight them at top of page 2. Patches that are older than 5 days, with no code review 3. Patches that you are listed as a reviewer on, but haven't voting on current version 4. Patches that already have a +2, so should be landable if you agree. 5. Patches that have no negative code review feedback on them 6. Patches older than 2 days, with no code review Thanks, Sean. This is working great for me, but I think there is another important item that is missing and hope it is possible to add, perhaps even as among the most important items: Patches that you gave a -1, but the response is a comment explaining why the -1 should be withdrawn rather than a new patch. So how does one automatically detect those using the gerrit query language? -Sean Based on the docs I looked at, you can't. The one downside of every one using a dashboard like this is that if a patch does not show in your view, it is as if it does not exist for you. So at least for now, if you want some one to remove a -1 based on some argument, you have to ping them directly. Not the end of the world. -David ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/09/2014 01:38 PM, David Kranz wrote: > On 06/02/2014 06:57 AM, Sean Dague wrote: >> Towards the end of the summit there was a discussion about us using a >> shared review dashboard to see if a common view by the team would help >> accelerate people looking at certain things. I spent some time this >> weekend working on a tool to make building custom dashboard urls much >> easier. >> >> My current proposal is the following, and would like comments on it: >> https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash >> >> All items in the dashboard are content that you've not voted on in the >> current patch revision, that you don't own, and that have passing >> Jenkins test results. >> >> 1. QA Specs - these need more eyes, so we highlight them at top of page >> 2. Patches that are older than 5 days, with no code review >> 3. Patches that you are listed as a reviewer on, but haven't voting on >> current version >> 4. Patches that already have a +2, so should be landable if you agree. >> 5. Patches that have no negative code review feedback on them >> 6. Patches older than 2 days, with no code review > Thanks, Sean. This is working great for me, but I think there is another > important item that is missing and hope it is possible to add, perhaps > even as among the most important items: > > Patches that you gave a -1, but the response is a comment explaining why > the -1 should be withdrawn rather than a new patch. So how does one automatically detect those using the gerrit query language? -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/02/2014 06:57 AM, Sean Dague wrote: Towards the end of the summit there was a discussion about us using a shared review dashboard to see if a common view by the team would help accelerate people looking at certain things. I spent some time this weekend working on a tool to make building custom dashboard urls much easier. My current proposal is the following, and would like comments on it: https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash All items in the dashboard are content that you've not voted on in the current patch revision, that you don't own, and that have passing Jenkins test results. 1. QA Specs - these need more eyes, so we highlight them at top of page 2. Patches that are older than 5 days, with no code review 3. Patches that you are listed as a reviewer on, but haven't voting on current version 4. Patches that already have a +2, so should be landable if you agree. 5. Patches that have no negative code review feedback on them 6. Patches older than 2 days, with no code review Thanks, Sean. This is working great for me, but I think there is another important item that is missing and hope it is possible to add, perhaps even as among the most important items: Patches that you gave a -1, but the response is a comment explaining why the -1 should be withdrawn rather than a new patch. -David These are definitely a judgement call on what people should be looking at, but this seems a pretty reasonable triaging list. I'm happy to have a discussion on changes to this list. The url for this is - http://goo.gl/g4aMjM (the long url is very long: https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d The url can be regenerated easily using the gerrit-dash-creator. -Sean ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/02/2014 01:05 PM, Sean Dague wrote: > On 06/02/2014 09:21 AM, Matthew Treinish wrote: > >>> The url for this is - http://goo.gl/g4aMjM >>> >>> (the long url is very long: >>> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d >>> >>> The url can be regenerated easily using the gerrit-dash-creator. >>> >> >> These generated URLs don't quite work as expected for me, I see a bunch of >> -1s >> from jenkins in all the sections. Other things like reviews with -2s showing >> up >> "in need final +2", or reviews with -2s and +2s from me being listed in the >> "but >> haven't voted in the current revision". Also the top section just seems to >> list >> every open QA program review regardless of it's current review state. >> >> I'll take a look at the code and see if I can help figure out what's going >> on. > > It appears that there is some issue in Firefox vs. Gerrit here where > Firefox is incorrectly over unescaping the URL, thus it doesn't work. > Chrome works fine. As I'm on Linux that's the extent of what I can > natively test. > > I filed a Firefox bug here - > https://bugzilla.mozilla.org/show_bug.cgi?id=1019073 The following updated url seems to work for firefox: https://goo.gl/oGYH4s Thanks to dtantsur for figuring out the extra escaping on commas you needed to work with firefox. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/02/2014 09:21 AM, Matthew Treinish wrote: >> The url for this is - http://goo.gl/g4aMjM >> >> (the long url is very long: >> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d >> >> The url can be regenerated easily using the gerrit-dash-creator. >> > > These generated URLs don't quite work as expected for me, I see a bunch of -1s > from jenkins in all the sections. Other things like reviews with -2s showing > up > "in need final +2", or reviews with -2s and +2s from me being listed in the > "but > haven't voted in the current revision". Also the top section just seems to > list > every open QA program review regardless of it's current review state. > > I'll take a look at the code and see if I can help figure out what's going on. It appears that there is some issue in Firefox vs. Gerrit here where Firefox is incorrectly over unescaping the URL, thus it doesn't work. Chrome works fine. As I'm on Linux that's the extent of what I can natively test. I filed a Firefox bug here - https://bugzilla.mozilla.org/show_bug.cgi?id=1019073 -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/02/2014 12:17 PM, Doug Hellmann wrote: > On Mon, Jun 2, 2014 at 6:57 AM, Sean Dague wrote: >> Towards the end of the summit there was a discussion about us using a >> shared review dashboard to see if a common view by the team would help >> accelerate people looking at certain things. I spent some time this >> weekend working on a tool to make building custom dashboard urls much >> easier. >> >> My current proposal is the following, and would like comments on it: >> https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash >> >> All items in the dashboard are content that you've not voted on in the >> current patch revision, that you don't own, and that have passing >> Jenkins test results. >> >> 1. QA Specs - these need more eyes, so we highlight them at top of page >> 2. Patches that are older than 5 days, with no code review >> 3. Patches that you are listed as a reviewer on, but haven't voting on >> current version >> 4. Patches that already have a +2, so should be landable if you agree. >> 5. Patches that have no negative code review feedback on them >> 6. Patches older than 2 days, with no code review >> >> These are definitely a judgement call on what people should be looking >> at, but this seems a pretty reasonable triaging list. I'm happy to have >> a discussion on changes to this list. >> >> The url for this is - http://goo.gl/g4aMjM >> >> (the long url is very long: >> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d >> >> The url can be regenerated easily using the gerrit-dash-creator. >> >> -Sean >> >> -- >> Sean Dague >> http://dague.net >> >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > What do you think about tying this to the list of repositories in the > governance repo (like https://review.openstack.org/#/c/92597/) and > generating similar dashboards for all of the programs that way? That would be possible, realistically I expect that different programs might think about their review flows differently. I consider the example dashboards there to be that, examples, which I find very useful (and actively use most of them on a daily basis). In the qa-program case we roughly agreed on that prioritizing criteria at the summit, so I feel like there is group buy in. I wouldn't want to assume that the review priorities we set automatically applied to other program's cultures. IIRC the swift team had some other queries they found useful, hopefully this would make it really easy for them to build a team dashboard (which could be in the tree or not, however they feel like it). -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On Mon, Jun 2, 2014 at 6:57 AM, Sean Dague wrote: > Towards the end of the summit there was a discussion about us using a > shared review dashboard to see if a common view by the team would help > accelerate people looking at certain things. I spent some time this > weekend working on a tool to make building custom dashboard urls much > easier. > > My current proposal is the following, and would like comments on it: > https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash > > All items in the dashboard are content that you've not voted on in the > current patch revision, that you don't own, and that have passing > Jenkins test results. > > 1. QA Specs - these need more eyes, so we highlight them at top of page > 2. Patches that are older than 5 days, with no code review > 3. Patches that you are listed as a reviewer on, but haven't voting on > current version > 4. Patches that already have a +2, so should be landable if you agree. > 5. Patches that have no negative code review feedback on them > 6. Patches older than 2 days, with no code review > > These are definitely a judgement call on what people should be looking > at, but this seems a pretty reasonable triaging list. I'm happy to have > a discussion on changes to this list. > > The url for this is - http://goo.gl/g4aMjM > > (the long url is very long: > https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d > > The url can be regenerated easily using the gerrit-dash-creator. > > -Sean > > -- > Sean Dague > http://dague.net > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > What do you think about tying this to the list of repositories in the governance repo (like https://review.openstack.org/#/c/92597/) and generating similar dashboards for all of the programs that way? Doug ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] shared review dashboard proposal
On 06/02/2014 09:21 AM, Matthew Treinish wrote: > On Mon, Jun 02, 2014 at 06:57:04AM -0400, Sean Dague wrote: >> Towards the end of the summit there was a discussion about us using a >> shared review dashboard to see if a common view by the team would help >> accelerate people looking at certain things. I spent some time this >> weekend working on a tool to make building custom dashboard urls much >> easier. >> >> My current proposal is the following, and would like comments on it: >> https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash > > I like this idea, it's definitely a good idea to try and help prioritize > certain > reviews to try and streamline reviewing. > > I'm wondering do you think we'll eventually bring this into infra? I > definitely > get JJB vibes from this too, and I think having a similar workflow for > creating > dashboards would be awesome. Site level dashboard support is proposed here for jeepyb - https://review.openstack.org/#/c/94260/ I'd also like project level dashboards that could be approved by the local core teams. A path to do that well hasn't been sorted yet. Until then I figure we can work with client dashboards. >> All items in the dashboard are content that you've not voted on in the >> current patch revision, that you don't own, and that have passing >> Jenkins test results. >> >> 1. QA Specs - these need more eyes, so we highlight them at top of page >> 2. Patches that are older than 5 days, with no code review >> 3. Patches that you are listed as a reviewer on, but haven't voting on >> current version >> 4. Patches that already have a +2, so should be landable if you agree. >> 5. Patches that have no negative code review feedback on them >> 6. Patches older than 2 days, with no code review >> >> These are definitely a judgement call on what people should be looking >> at, but this seems a pretty reasonable triaging list. I'm happy to have >> a discussion on changes to this list. > > I think this priority list is good for right now. I try to do this same basic > prioritization when I'm doing reviews. (although maybe not using exact day > counts) > Although, I'm hoping that eventually reviews on the qa-specs repo will be > active > enough that we won't need to prioritize it over other repos. But, until then I > think putting it at the top is the right move. > >> >> The url for this is - http://goo.gl/g4aMjM >> >> (the long url is very long: >> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d >> >> The url can be regenerated easily using the gerrit-dash-creator. >> > r > These generated URLs don't quite work as expected for me, I see a bunch of -1s > from jenkins in all the sections. They aren't Jenkins -1, they are other CI systems. https://review.openstack.org/#/settings/preferences (check - Display Person Name In Review Category) to see that. Other things like reviews with -2s showing up > "in need final +2", I tended not to filter out -2s for that to it would be more clear to see there was a conflict going on. Typically in those situations I vote -1 to say I agree with the -2 that's there, and move on. Then it's been voted on so drops from your list. > or reviews with -2s and +2s from me being listed in the "but > haven't voted in the current revision". That's odd, and definitely not intended. Also the top section just seems to list > every open QA program review regardless of it's current review state. The top section does list every qa-spec that is open and you don't have a vote on. That was intentional. The point being that everyone should read them and vote on them. Once you do they go away from your list. Unlike normal reviews I don't think that masking qa-specs once they have a single negative piece of feedback is the right workflow. Especially as there are a small enough number. > I'll take a look at the code and see if I can help figure out what's going on. Sure, pull requests welcomed. :) -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature
Re: [openstack-dev] [qa] shared review dashboard proposal
On Mon, Jun 02, 2014 at 06:57:04AM -0400, Sean Dague wrote: > Towards the end of the summit there was a discussion about us using a > shared review dashboard to see if a common view by the team would help > accelerate people looking at certain things. I spent some time this > weekend working on a tool to make building custom dashboard urls much > easier. > > My current proposal is the following, and would like comments on it: > https://github.com/sdague/gerrit-dash-creator/blob/master/dashboards/qa-program.dash I like this idea, it's definitely a good idea to try and help prioritize certain reviews to try and streamline reviewing. I'm wondering do you think we'll eventually bring this into infra? I definitely get JJB vibes from this too, and I think having a similar workflow for creating dashboards would be awesome. > > All items in the dashboard are content that you've not voted on in the > current patch revision, that you don't own, and that have passing > Jenkins test results. > > 1. QA Specs - these need more eyes, so we highlight them at top of page > 2. Patches that are older than 5 days, with no code review > 3. Patches that you are listed as a reviewer on, but haven't voting on > current version > 4. Patches that already have a +2, so should be landable if you agree. > 5. Patches that have no negative code review feedback on them > 6. Patches older than 2 days, with no code review > > These are definitely a judgement call on what people should be looking > at, but this seems a pretty reasonable triaging list. I'm happy to have > a discussion on changes to this list. I think this priority list is good for right now. I try to do this same basic prioritization when I'm doing reviews. (although maybe not using exact day counts) Although, I'm hoping that eventually reviews on the qa-specs repo will be active enough that we won't need to prioritize it over other repos. But, until then I think putting it at the top is the right move. > > The url for this is - http://goo.gl/g4aMjM > > (the long url is very long: > https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d > > The url can be regenerated easily using the gerrit-dash-creator. > These generated URLs don't quite work as expected for me, I see a bunch of -1s from jenkins in all the sections. Other things like reviews with -2s showing up "in need final +2", or reviews with -2s and +2s from me being listed in the "but haven't voted in the current revision". Also the top section just seems to list every open QA program review regardless of it's current review state. I'll take a look at the code and see if I can help figure out what's going on. -Matt Treinish pgp8MQd5G4C9D.pgp Description: PGP signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
