Re: [Openvpn-devel] patch for iproute

[Martin Hejl]

Hi James,

Thanks for the patch -- it looks good and I expect to merge it.  

Thanks - sounds good to me.


I see that
you hardwire the choice for iproute2 vs. vanilla ip route + ifconfig at build
time.  Do you think that makes sense, or would it be better to have an
--iproute2 run time flag?
Two reasons, basically. First of all, I'm lazy, so I wanted the patch to 
be as short as possible (and a runtime option probably would have meant 
having to make more changes than a define). It was simply very straight 
forward to add the code and then add the options to configure.ac
Besides, a run-time option would have meant having to "disturb" much 
more code - and I wanted to keep the change as isolated as possible. 
Easier to test if things still work, and less chances that I've screwed 
up something else.


And second, my guess is that at the moment, a plattform with only 
iproute2 is still pretty exotic (so the option would not be needed for 
most people) - and the plattforms that only have iproute2 (like LEAF) 
are focusing on minimizing the size of all packages - so I didn't want 
to increase the size of the binary if I could.


I know, both reasons aren't terribly good - if you feel that it would 
make life for you or package maintainers easier if it's a runtime 
option, feel free to change it (I know that compile time options are a 
pain for packagers). I guess for somebody familiar with the code, it 
should be rather simple (but I won't pretend I'm familiar with the 
OpenVPN sources - it was easy enough to find the places I needed to 
change that I didn't dig around in the other modules too much).


Martin

Re: [Openvpn-devel] patch for iproute

[James Yonan]

Martin,

Thanks for the patch -- it looks good and I expect to merge it.  I see that
you hardwire the choice for iproute2 vs. vanilla ip route + ifconfig at build
time.  Do you think that makes sense, or would it be better to have an
--iproute2 run time flag?

James

Martin Hejl  said:

> Hi everybody,
> 
> I am part of the LEAF project - a small distro for embedded environments 
> - at http://leaf.sourceforge.net (I'm actually only part of the "Bering 
> uClibc" branch, to be precise).
> 
> Since LEAF does not provide ifconfig and route by default (just 
> iproute2) I created a patch that allows using OpenVPN on LEAF boxes 
> without the need for ifconfig and route.
> 
> I would be very happy to see this integrated into OpenVPN at some point 
> (there's no hurry - we have a mostly automated build environment, so 
> applying the patch is no big deal).
> 
> I've tested the patch using a LEAF box plus a regular Fedora box (both 
> tun and tap devices) and everything seems to be working nicely.
> 
> If the patch doesn't make it onto the list (the LEAF lists trim all 
> attachments), it can also be found at:
>
http://cvs.sourceforge.net/viewcvs.py/leaf/src/bering-uclibc/apps/openvpn/iproute.patch
> 
> Let me know if you have any questions.
> 
> Martin
> 



--