Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 06/03/12 12:13, Alon Bar-Lev wrote:
> Not exactly. This file is needed for VERY old libc implementations. I
> don't think these exists anymore in supported configurations. If we
> find memcmp() is missing, we add it properly to compat.

Agreed, and I also ACKed this one in the first round.  This is basically
dead code in the vast majority of platforms.  Bear in mind that OpenVPN
was released about a decade ago,  "a few" things have changed since then ;-)

This patch goes in.


kind regards,

David Sommerseth


> 2012/3/6 Samuli Seppänen :
>> 
>>> Signed-off-by: Alon Bar-Lev  --- 
>>> configure.ac |3 --- memcmp.c |   43
>>> --- 2 files changed, 0
>>> insertions(+), 46 deletions(-) delete mode 100644 memcmp.c
[..snip..]
>> 
>> My C-fu is fairly low, but this still seems to make sense as there's
>> no memcmp.h. The memcmp function calls in other source files seem to
>> use memcmp function stored elsewhere (gcc[1], libc[2], etc.).
>> 
>> ACK.
>> 
>> -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc
>> 
>> irc freenode net: mattock
>> 
>> 
>> [1]  
>> [2] 
>> 
>
>> 
> --
>
> 
Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft
> developers is just $99.99! Visual Studio, SharePoint, SQL - plus
> HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when
> you subscribe now! http://p.sf.net/sfu/learndevnow-d2d 
> ___ Openvpn-devel mailing
> list Openvpn-devel@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9WC1sACgkQDC186MBRfrpwggCfahRiNIZZrCssyxWqOgCJPi+c
r0gAoJeO5E5MqyggxsCPNSDXPy9SC6eU
=Em9/
-END PGP SIGNATURE-

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

[Alon Bar-Lev]

Not exactly.
This file is needed for VERY old libc implementations.
I don't think these exists anymore in supported configurations.
If we find memcmp() is missing, we add it properly to compat.

2012/3/6 Samuli Seppänen :
>
>> Signed-off-by: Alon Bar-Lev 
>> ---
>>  configure.ac |    3 ---
>>  memcmp.c     |   43 ---
>>  2 files changed, 0 insertions(+), 46 deletions(-)
>>  delete mode 100644 memcmp.c
>>
>> diff --git a/configure.ac b/configure.ac
>> index 25dcc37..1c4d66c 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -564,9 +564,6 @@ else
>>
>>  fi
>>
>> -dnl Required library functions
>> -AC_FUNC_MEMCMP
>> -
>>  dnl
>>  dnl Check for res_init
>>  dnl
>> diff --git a/memcmp.c b/memcmp.c
>> deleted file mode 100644
>> index d921aac..000
>> --- a/memcmp.c
>> +++ /dev/null
>> @@ -1,43 +0,0 @@
>> -/*
>> - *  OpenVPN -- An application to securely tunnel IP networks
>> - *             over a single TCP/UDP port, with support for SSL/TLS-based
>> - *             session authentication and key exchange,
>> - *             packet encryption, packet authentication, and
>> - *             packet compression.
>> - *
>> - *  Copyright (C) 2002-2010 OpenVPN Technologies, Inc. 
>> - *
>> - *  This program is free software; you can redistribute it and/or modify
>> - *  it under the terms of the GNU General Public License version 2
>> - *  as published by the Free Software Foundation.
>> - *
>> - *  This program is distributed in the hope that it will be useful,
>> - *  but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - *  GNU General Public License for more details.
>> - *
>> - *  You should have received a copy of the GNU General Public License
>> - *  along with this program (see the file COPYING included with this
>> - *  distribution); if not, write to the Free Software Foundation, Inc.,
>> - *  59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>> - */
>> -
>> -#include "syshead.h"
>> -
>> -#include "memdbg.h"
>> -
>> -int
>> -memcmp (const void *s1, const void *s2, size_t n)
>> -{
>> -  unsigned const char *p1 = s1, *p2 = s2;
>> -  int d;
>> -
>> -  if (n)
>> -    while (n-- > 0)
>> -      {
>> -     d = *p1++ - *p2++;
>> -     if (d != 0)
>> -       return d;
>> -      }
>> -  return 0;
>> -}
>
> My C-fu is fairly low, but this still seems to make sense as there's no
> memcmp.h. The memcmp function calls in other source files seem to use
> memcmp function stored elsewhere (gcc[1], libc[2], etc.).
>
> ACK.
>
> --
> Samuli Seppänen
> Community Manager
> OpenVPN Technologies, Inc
>
> irc freenode net: mattock
>
>
> [1] 
> [2]
> 

[Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

[Alon Bar-Lev]

Signed-off-by: Alon Bar-Lev 
---
 configure.ac |3 ---
 memcmp.c |   43 ---
 2 files changed, 0 insertions(+), 46 deletions(-)
 delete mode 100644 memcmp.c

diff --git a/configure.ac b/configure.ac
index 25dcc37..1c4d66c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -564,9 +564,6 @@ else

 fi

-dnl Required library functions
-AC_FUNC_MEMCMP
-
 dnl
 dnl Check for res_init
 dnl
diff --git a/memcmp.c b/memcmp.c
deleted file mode 100644
index d921aac..000
--- a/memcmp.c
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- *  OpenVPN -- An application to securely tunnel IP networks
- * over a single TCP/UDP port, with support for SSL/TLS-based
- * session authentication and key exchange,
- * packet encryption, packet authentication, and
- * packet compression.
- *
- *  Copyright (C) 2002-2010 OpenVPN Technologies, Inc. 
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2
- *  as published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program (see the file COPYING included with this
- *  distribution); if not, write to the Free Software Foundation, Inc.,
- *  59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- */
-
-#include "syshead.h"
-
-#include "memdbg.h"
-
-int
-memcmp (const void *s1, const void *s2, size_t n)
-{
-  unsigned const char *p1 = s1, *p2 = s2;
-  int d;
-
-  if (n)
-while (n-- > 0)
-  {
-   d = *p1++ - *p2++;
-   if (d != 0)
- return d;
-  }
-  return 0;
-}
-- 
1.7.3.4