-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/03/12 12:13, Alon Bar-Lev wrote: > Not exactly. This file is needed for VERY old libc implementations. I > don't think these exists anymore in supported configurations. If we > find memcmp() is missing, we add it properly to compat.
Agreed, and I also ACKed this one in the first round. This is basically dead code in the vast majority of platforms. Bear in mind that OpenVPN was released about a decade ago, "a few" things have changed since then ;-) This patch goes in. kind regards, David Sommerseth > 2012/3/6 Samuli Seppänen <sam...@openvpn.net>: >> >>> Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- >>> configure.ac | 3 --- memcmp.c | 43 >>> ------------------------------------------- 2 files changed, 0 >>> insertions(+), 46 deletions(-) delete mode 100644 memcmp.c [..snip..] >> >> My C-fu is fairly low, but this still seems to make sense as there's >> no memcmp.h. The memcmp function calls in other source files seem to >> use memcmp function stored elsewhere (gcc[1], libc[2], etc.). >> >> ACK. >> >> -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc >> >> irc freenode net: mattock >> >> >> [1] <http://justin.harmonize.fm/index.php/2009/05/exploring-memcmp> >> [2] >> <http://www.slac.stanford.edu/comp/unix/package/rtems/doc/html/libc/libc.info.memcmp.html> > >> > ------------------------------------------------------------------------------ > > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft > developers is just $99.99! Visual Studio, SharePoint, SQL - plus > HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when > you subscribe now! http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ Openvpn-devel mailing > list Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9WC1sACgkQDC186MBRfrpwggCfahRiNIZZrCssyxWqOgCJPi+c r0gAoJeO5E5MqyggxsCPNSDXPy9SC6eU =Em9/ -----END PGP SIGNATURE-----
