Re: [Openvpn-devel] [PATCH applied] Re: interactive.c: Resolve MSVC C4996 warning
Hi, On Sun, Mar 21, 2021 at 06:05:19PM +0100, Gert Doering wrote: > commit 709c3810a1d67e2c4049e852529a0a0d1338c797 > Author: Simon Rozman via Openvpn-devel Yeah. Right. So, apologies for not catching this in time and fixing the Author: line, but this is exactly why I brought up the DMARC issue with Max Fillinger yesterday. And it royally messes up patchwork as well, because patchwork only cares about mail addresses internally, and shows the name "last seen with that address" - so the Patch from Steffan / Max is now listed as "Simon Rozman via Openvpn-devel" as well... https://patchwork.openvpn.net/patch/1628/ *sigh* gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: interactive.c: Resolve MSVC C4996 warning
I seem to remember we had that discussion in the context of openpvpn-gui already - Problems with the "POSIX compatible" function names, which end up acting on narrow or wide strings depending on compiler settings, compiler version, phase of the moon... can't find that commit, but if MS docs says "this is how windows code should look like", so be it... I have test compiled stuff on Ubuntu 18 / MinGW, and it compiles. Not tested. Your patch has been applied to the master branch. commit 709c3810a1d67e2c4049e852529a0a0d1338c797 Author: Simon Rozman via Openvpn-devel Date: Sun Mar 21 15:46:25 2021 +0100 interactive.c: Resolve MSVC C4996 warning Signed-off-by: Simon Rozman Acked-by: Arne Schwabe Message-Id: <20210321144627.1621-3-si...@rozman.si> URL: https://www.mail-archive.com/search?l=mid=20210321144627.1621-3-si...@rozman.si Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
