Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/06/12 16:11, Alon Bar-Lev wrote: > On Tue, Jun 26, 2012 at 5:06 PM, Gert Doering > wrote: >> Hi, >> >> On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: >>> You are more than welcome to maintain the build system and do >>> whatever you like. >> >> I'm not exactly sure what I did wrong this time - I particularily >> did *not* want to start a fight. >> >> You offered to rewrite the build system, so please accept >> feedback if something is not working the way people envision it >> to work - and please accept if the majority of developers agree >> about a certain way how configure should behave, even if it's not >> the way you would have done it. > > Yes. You get this wrong. "Whoever undertakes to set himself up as a judge of Truth and Knowledge is shipwrecked by the laughter of the gods." (Albert Einstein) > Majority != wisdom. Maintainer = credit. "Try not to become a man of success, but rather try to become a man of value." (Albert Einstein) - --- Seriously. This kind of argumentation is really not going to be productive. Can we please discuss *why* something is wrong instead of just *blaming* people for being wrong? Then we can all learn something. Throwing crap at each other will just be make things messier. Having a humble attitude will always open up doors, while being arrogant closes them. I have higher expectations of this community than what such responses contains. Most of us here is not here to receive credits. We are here because we want to make things better - through co-operation! And to co-operate, we need to show each other respect. Then we, as a group, can get wiser and the result will be better. kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/p59UACgkQDC186MBRfroxhACfd9hJI0MXTbnX/O3+WYlry4UG tXIAnjXS8bREAiks8TNQ7gFyAainRwLs =2ieZ -END PGP SIGNATURE-
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
On Tue, Jun 26, 2012 at 5:06 PM, Gert Doering wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: >> You are more than welcome to maintain the build system and do whatever you >> like. > > I'm not exactly sure what I did wrong this time - I particularily did > *not* want to start a fight. > > You offered to rewrite the build system, so please accept feedback if > something is not working the way people envision it to work - and please > accept if the majority of developers agree about a certain way how > configure should behave, even if it's not the way you would have done it. Yes. You get this wrong. Majority != wisdom. Maintainer = credit. Alon.
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
Hi, On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: > You are more than welcome to maintain the build system and do whatever you > like. I'm not exactly sure what I did wrong this time - I particularily did *not* want to start a fight. You offered to rewrite the build system, so please accept feedback if something is not working the way people envision it to work - and please accept if the majority of developers agree about a certain way how configure should behave, even if it's not the way you would have done it. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgprkM_eeJAew.pgp Description: PGP signature
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
On Tue, Jun 26, 2012 at 4:50 PM, Gert Doering wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:41:49PM +0300, Alon Bar-Lev wrote: >> This is exactly the reason why *ALL* plugins should be disabled by default. >> We are left with only Linux enabled... and distro maintainer can take >> care of that anyway. >> But again... my opinion is not matter, right... sending a new patch. > > FreeBSD, NetBSD and OpenSolaris have PAM and build just fine, it's just > OpenBSD that does not. > > (*My* opinion wasn't taken into account either - I proposed to auto-build > if possible, and if libraries are not found, just don't make a fuzz and > do not build the corresponding plugin, instead of erroring out - but I'm > not feeling strongly about this, so I'll accept what's there, and not > enter a lengthy discussion) > You are more than welcome to maintain the build system and do whatever you like. Alon.
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
Hi, On Tue, Jun 26, 2012 at 04:41:49PM +0300, Alon Bar-Lev wrote: > This is exactly the reason why *ALL* plugins should be disabled by default. > We are left with only Linux enabled... and distro maintainer can take > care of that anyway. > But again... my opinion is not matter, right... sending a new patch. FreeBSD, NetBSD and OpenSolaris have PAM and build just fine, it's just OpenBSD that does not. (*My* opinion wasn't taken into account either - I proposed to auto-build if possible, and if libraries are not found, just don't make a fuzz and do not build the corresponding plugin, instead of erroring out - but I'm not feeling strongly about this, so I'll accept what's there, and not enter a lengthy discussion) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgptoCCKYgcHk.pgp Description: PGP signature
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
This is exactly the reason why *ALL* plugins should be disabled by default. We are left with only Linux enabled... and distro maintainer can take care of that anyway. But again... my opinion is not matter, right... sending a new patch. On Tue, Jun 26, 2012 at 4:35 PM, Gert Doering wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:02:06PM +0300, Alon Bar-Lev wrote: >> Both plugins cannot be compiled on Windows anyway. > > Can you auto-disable plugin-auth-pam for OpenBSD as well, please? > > We ran into this on the OpenBSD buildslave today - OpenBSD has no PAM > whatsoever, so it would be nice to not have to care. > > (Leaving the ACK on the windows patch to Samuli - looks good to me, but > I can't test right now) > > thanks. > > gert > -- > USENET is *not* the non-clickable part of WWW! > //www.muc.de/~gert/ > Gert Doering - Munich, Germany g...@greenie.muc.de > fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows
Hi, On Tue, Jun 26, 2012 at 04:02:06PM +0300, Alon Bar-Lev wrote: > Both plugins cannot be compiled on Windows anyway. Can you auto-disable plugin-auth-pam for OpenBSD as well, please? We ran into this on the OpenBSD buildslave today - OpenBSD has no PAM whatsoever, so it would be nice to not have to care. (Leaving the ACK on the windows patch to Samuli - looks good to me, but I can't test right now) thanks. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgpuNA9QkEdDf.pgp Description: PGP signature
