Re: [OpenWrt-Devel] [OpenWrt-Devel 1/4] Add kernel support for Sagemcom F@ST2704V2 ADSL router

2013-10-22 Thread Marcin Jurkowski 
On Mon, Oct 21, 2013 at 10:42:03PM +0100, Florian Fainelli wrote:
 Please use C99 style comments: /* Front LEDs */ other than that, this
 looks good to me.

Thank you for pointing this out. 
Apart from style issues also board_FAST2704V2 reference was in a wrong
#ifdef branch.

I resubmitted this patch with (hopefully) correct style and
board_FAST2704V2 reference in a right place.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [OpenWrt-Devel 1/4] Add kernel support for Sagemcom F@ST2704V2 ADSL router

2013-10-21 Thread Marcin Jurkowski 
This adds kernel support support for Sagemcom F@st 2704 wireless ADSL
router.
It's a BCM6328-based 802.11n wireless router with USB port and ADSL2+
modem equipped with 64 MiB RAM and 8 MiB flash.

Signed-off-by: Marcin Jurkowski marci...@gmail.com
---
 .../brcm63xx/patches-3.10/803-board_fast2704.patch | 133 +
 1 file changed, 133 insertions(+)
 create mode 100644 target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch

diff --git a/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch 
b/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch
new file mode 100644
index 000..69a024f
--- /dev/null
+++ b/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch
@@ -0,0 +1,133 @@
+--- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
 b/arch/mips/bcm63xx/boards/board_bcm963xx.c
+@@ -1501,6 +1501,122 @@ static struct board_info __initdata boar
+   },
+ };
+ 
++static struct board_info __initdata board_FAST2704V2 = {
++  .name   = F@ST2704V2,
++  .expected_cpu_id= 0x6328,
++
++  .has_uart0  = 1,
++  .has_pci= 1,
++  .has_ohci0  = 1,
++  .has_ehci0  = 1,
++  .has_usbd   = 1,
++
++  .has_enetsw = 1,
++
++  .enetsw = {
++  .used_ports = {
++  [0] = {
++  .used   = 1,
++  .phy_id = 1,
++  .name   = Port 1,
++  },
++  [1] = {
++  .used   = 1,
++  .phy_id = 2,
++  .name   = Port 2,
++  },
++  [2] = {
++  .used   = 1,
++  .phy_id = 3,
++  .name   = Port 3,
++  },
++  [3] = {
++  .used   = 1,
++  .phy_id = 4,
++  .name   = Port 4,
++  },
++  },
++  },
++
++  .leds = {
++  // Front LEDs
++  {
++  .name   = F@ST2704V2:green:power,
++  .gpio   = 4,
++  .active_low = 1,
++  .default_trigger= default-on,
++  },
++  {
++  .name   = F@ST2704V2:red:power,
++  .gpio   = 5,
++  .active_low = 1,
++  },
++  {
++  .name   = F@ST2704V2:red:inet,
++  .gpio   = 2,
++  .active_low = 1,
++  },
++  {
++  .name   = F@ST2704V2:green:dsl,
++  .gpio   = 3,
++  .active_low = 1,
++  },
++  {
++  .name   = F@ST2704V2:green:inet,
++  .gpio   = 11,
++  .active_low = 1,
++  },
++  {
++  .name   = F@ST2704V2:green:usb,
++  .gpio   = 1,
++  .active_low = 1,
++  },
++
++  // Side button LEDs
++  {
++  .name   = F@ST2704V2:green:wps,
++  .gpio   = 10,
++  .active_low = 1,
++  },
++  
++  /*  
++  // TODO LED emits dim light when GPIO line is set to out state, 
regardless of GPIO output level
++  {
++  .name   = F@ST2704V2:green:rfkill,
++  .gpio   = 0,
++  .active_low = 1,
++  },
++  */  
++
++  },
++  .buttons = {
++  {
++  .desc   = reset,
++  .gpio   = 23,
++  .active_low = 1,
++  .type   = EV_KEY,
++  .code   = KEY_RESTART,
++  .debounce_interval  = 
BCM963XX_KEYS_DEBOUNCE_INTERVAL,
++  },
++  {
++  .desc   = wps,
++  .gpio   = 24,
++  .active_low = 1,
++  .type   = EV_KEY,
++

Re: [OpenWrt-Devel] [OpenWrt-Devel 1/4] Add kernel support for Sagemcom F@ST2704V2 ADSL router

2013-10-21 Thread Florian Fainelli 
2013/10/21 Marcin Jurkowski marci...@gmail.com:
 This adds kernel support support for Sagemcom F@st 2704 wireless ADSL
 router.
 It's a BCM6328-based 802.11n wireless router with USB port and ADSL2+
 modem equipped with 64 MiB RAM and 8 MiB flash.

 Signed-off-by: Marcin Jurkowski marci...@gmail.com
 ---
  .../brcm63xx/patches-3.10/803-board_fast2704.patch | 133 
 +
  1 file changed, 133 insertions(+)
  create mode 100644 
 target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch

 diff --git a/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch 
 b/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch
 new file mode 100644
 index 000..69a024f
 --- /dev/null
 +++ b/target/linux/brcm63xx/patches-3.10/803-board_fast2704.patch
 @@ -0,0 +1,133 @@
 +--- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
  b/arch/mips/bcm63xx/boards/board_bcm963xx.c
 +@@ -1501,6 +1501,122 @@ static struct board_info __initdata boar
 +   },
 + };
 +
 ++static struct board_info __initdata board_FAST2704V2 = {
 ++  .name   = F@ST2704V2,
 ++  .expected_cpu_id= 0x6328,
 ++
 ++  .has_uart0  = 1,
 ++  .has_pci= 1,
 ++  .has_ohci0  = 1,
 ++  .has_ehci0  = 1,
 ++  .has_usbd   = 1,
 ++
 ++  .has_enetsw = 1,
 ++
 ++  .enetsw = {
 ++  .used_ports = {
 ++  [0] = {
 ++  .used   = 1,
 ++  .phy_id = 1,
 ++  .name   = Port 1,
 ++  },
 ++  [1] = {
 ++  .used   = 1,
 ++  .phy_id = 2,
 ++  .name   = Port 2,
 ++  },
 ++  [2] = {
 ++  .used   = 1,
 ++  .phy_id = 3,
 ++  .name   = Port 3,
 ++  },
 ++  [3] = {
 ++  .used   = 1,
 ++  .phy_id = 4,
 ++  .name   = Port 4,
 ++  },
 ++  },
 ++  },
 ++
 ++  .leds = {
 ++  // Front LEDs

Please use C99 style comments: /* Front LEDs */ other than that, this
looks good to me.
-- 
Florian
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel