Re: [OpenWrt-Devel] [PATCH] Wallys DR-344 support

2015-11-02 Thread John Crispin 
Hi,

On 29/10/2015 12:55, Philippe DUCHEIN wrote:
> This patch is for Wallys DR344 support under OpenWRT
> need ar8035-a patch for gigabit ethernet : [OpenWrt-Devel] [PATCH] Atheros 
> AR8035-A support
> 

i cannot see the phy patch in the patchwork list. also this patch should
have a prefix of ar71xx: in the subject.

please fix and resend both patches together

John


> Signed-off-by: Philippe DUCHEIN 
> 
> —
> 
> diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh 
> b/target/linux/ar71xx/base-files/etc/diag.sh
> --- a/target/linux/ar71xx/base-files/etc/diag.sh  2015-10-27 
> 18:57:41.368735097 +0100
> +++ b/target/linux/ar71xx/base-files/etc/diag.sh  2015-10-29 
> 12:05:58.995324966 +0100
> @@ -92,6 +92,9 @@
>   dlan-pro-1200-ac)
>   status_led="devolo:status:wlan"
>   ;;
> + dr344)
> + status_led="dr344:green:status"
> + ;;
>   dragino2)
>   status_led="dragino2:red:system"
>   ;;
> diff -Nru a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network 
> b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
> --- a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network  
> 2015-10-27 18:57:41.363735040 +0100
> +++ b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network  
> 2015-10-29 12:05:58.995324966 +0100
> @@ -17,6 +17,7 @@
>  case "$board" in
>  all0315n |\
>  all0258n |\
> +dr344 |\
>  ja76pf2|\
>  rocket-m-ti |\
>  ubnt-unifi-outdoor)
> diff -Nru a/target/linux/ar71xx/base-files/lib/ar71xx.sh 
> b/target/linux/ar71xx/base-files/lib/ar71xx.sh
> --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh2015-10-27 
> 18:57:41.341734786 +0100
> +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh2015-10-29 
> 12:05:58.996324978 +0100
> @@ -456,6 +456,9 @@
>   *"dLAN pro 1200+ WiFi ac")
>   name="dlan-pro-1200-ac"
>   ;;
> + *DR344)
> + name="dr344"
> + ;;
>   *"Dragino v2")
>   name="dragino2"
>   ;;
> diff -Nru a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
> b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh  2015-10-27 
> 18:57:41.329734649 +0100
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh  2015-10-29 
> 12:06:23.597611781 +0100
> @@ -183,6 +183,7 @@
>   ap96 | \
>   bxu2000n-2-a1 | \
>   db120 | \
> + dr344 | \
>   f9k1115v2 |\
>   hornet-ub | \
>   mr12 | \
> diff -Nru a/target/linux/ar71xx/config-4.1 b/target/linux/ar71xx/config-4.1
> --- a/target/linux/ar71xx/config-4.1  2015-10-27 18:57:41.379735223 +0100
> +++ b/target/linux/ar71xx/config-4.1  2015-10-29 12:05:58.996324978 +0100
> @@ -64,6 +64,7 @@
>  CONFIG_ATH79_MACH_DIR_825_C1=y
>  CONFIG_ATH79_MACH_DLAN_PRO_1200_AC=y
>  CONFIG_ATH79_MACH_DLAN_PRO_500_WP=y
> +CONFIG_ATH79_MACH_DR344=y
>  CONFIG_ATH79_MACH_DRAGINO2=y
>  CONFIG_ATH79_MACH_EAP300V2=y
>  CONFIG_ATH79_MACH_EAP7660D=y
> diff -Nru a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c 
> b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c
> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c  1970-01-01 
> 01:00:00.0 +0100
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c  2015-10-29 
> 12:05:58.996324978 +0100
> @@ -0,0 +1,160 @@
> +/*
> + * Wallys DR344 board support
> + *
> + * Copyright (c) 2011 Qualcomm Atheros
> + * Copyright (c) 2011-2012 Gabor Juhos 
> + * Copyright (c) 2015 Philippe DUCHEIN 
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + *
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include 
> +#include 
> +#include "common.h"
> +#include "pci.h"
> +#include "dev-ap9x-pci.h"
> +#include "dev-gpio-buttons.h"
> +#include "dev-eth.h"
> +#include "dev-usb.h"
> +#include "dev-leds-gpio.h"
> +#include "dev-m25p80.h"
> +#include "dev-spi.h"
> +#include "dev-wmac.h"
> +#include "machtypes.h"
> +
> +#define DR344_GPIO_LED_SIG1  15
> +#define DR344_GPIO_LED_SIG2  20
> +#define DR344_GPIO_LED_SIG3  21
> +#define DR344_GPIO_LED_SIG4  22
> +#define DR344_GPIO_EXTERNAL_LNA0 18
> +#define

[OpenWrt-Devel] [PATCH] Wallys DR-344 support

2015-10-29 Thread Philippe DUCHEIN 
This patch is for Wallys DR344 support under OpenWRT
need ar8035-a patch for gigabit ethernet : [OpenWrt-Devel] [PATCH] Atheros 
AR8035-A support

Signed-off-by: Philippe DUCHEIN 

—

diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh 
b/target/linux/ar71xx/base-files/etc/diag.sh
--- a/target/linux/ar71xx/base-files/etc/diag.sh2015-10-27 
18:57:41.368735097 +0100
+++ b/target/linux/ar71xx/base-files/etc/diag.sh2015-10-29 
12:05:58.995324966 +0100
@@ -92,6 +92,9 @@
dlan-pro-1200-ac)
status_led="devolo:status:wlan"
;;
+   dr344)
+   status_led="dr344:green:status"
+   ;;
dragino2)
status_led="dragino2:red:system"
;;
diff -Nru a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network 
b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
--- a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
2015-10-27 18:57:41.363735040 +0100
+++ b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
2015-10-29 12:05:58.995324966 +0100
@@ -17,6 +17,7 @@
 case "$board" in
 all0315n |\
 all0258n |\
+dr344 |\
 ja76pf2|\
 rocket-m-ti |\
 ubnt-unifi-outdoor)
diff -Nru a/target/linux/ar71xx/base-files/lib/ar71xx.sh 
b/target/linux/ar71xx/base-files/lib/ar71xx.sh
--- a/target/linux/ar71xx/base-files/lib/ar71xx.sh  2015-10-27 
18:57:41.341734786 +0100
+++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh  2015-10-29 
12:05:58.996324978 +0100
@@ -456,6 +456,9 @@
*"dLAN pro 1200+ WiFi ac")
name="dlan-pro-1200-ac"
;;
+   *DR344)
+   name="dr344"
+   ;;
*"Dragino v2")
name="dragino2"
;;
diff -Nru a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
--- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh2015-10-27 
18:57:41.329734649 +0100
+++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh2015-10-29 
12:06:23.597611781 +0100
@@ -183,6 +183,7 @@
ap96 | \
bxu2000n-2-a1 | \
db120 | \
+   dr344 | \
f9k1115v2 |\
hornet-ub | \
mr12 | \
diff -Nru a/target/linux/ar71xx/config-4.1 b/target/linux/ar71xx/config-4.1
--- a/target/linux/ar71xx/config-4.12015-10-27 18:57:41.379735223 +0100
+++ b/target/linux/ar71xx/config-4.12015-10-29 12:05:58.996324978 +0100
@@ -64,6 +64,7 @@
 CONFIG_ATH79_MACH_DIR_825_C1=y
 CONFIG_ATH79_MACH_DLAN_PRO_1200_AC=y
 CONFIG_ATH79_MACH_DLAN_PRO_500_WP=y
+CONFIG_ATH79_MACH_DR344=y
 CONFIG_ATH79_MACH_DRAGINO2=y
 CONFIG_ATH79_MACH_EAP300V2=y
 CONFIG_ATH79_MACH_EAP7660D=y
diff -Nru a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c 
b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c1970-01-01 
01:00:00.0 +0100
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c2015-10-29 
12:05:58.996324978 +0100
@@ -0,0 +1,160 @@
+/*
+ * Wallys DR344 board support
+ *
+ * Copyright (c) 2011 Qualcomm Atheros
+ * Copyright (c) 2011-2012 Gabor Juhos 
+ * Copyright (c) 2015 Philippe DUCHEIN 
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include "common.h"
+#include "pci.h"
+#include "dev-ap9x-pci.h"
+#include "dev-gpio-buttons.h"
+#include "dev-eth.h"
+#include "dev-usb.h"
+#include "dev-leds-gpio.h"
+#include "dev-m25p80.h"
+#include "dev-spi.h"
+#include "dev-wmac.h"
+#include "machtypes.h"
+
+#define DR344_GPIO_LED_SIG115
+#define DR344_GPIO_LED_SIG220
+#define DR344_GPIO_LED_SIG321
+#define DR344_GPIO_LED_SIG422
+#define DR344_GPIO_EXTERNAL_LNA0   18
+#define DR344_GPIO_EXTERNAL_LNA1   19
+#define DR344_GPIO_LED_STATUS  14
+
+#define DR344_GPIO_BTN_RESET   12
+
+#define DR344_KEYS_POLL_INTERVAL   20  /* msecs */
+#define DR344_KEYS_DEBOUNCE_INTERVAL   (3 * DR344_KEYS_POLL_INTERVAL)
+
+#define DR344_MAC0_OFFSET  0
+#define DR344_MAC1_OFFSET  6
+#define DR344_WMAC_CALDATA_OFFSET  0x1000
+#define DR344_PCIE_CALDATA_OFFSET  0x5000
+

Re: [OpenWrt-Devel] [PATCH] Wallys DR-344 support

2015-10-27 Thread Karl Palsson 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Shouldn't the atheros phy additions be in their own patch? It
seems out of scope to just have it buried inside a "support "
with no further details in your commit comment.

More comments inline...

Sincerely,
Karl Palsson

Philippe DUCHEIN  wrote:
> This patch is for Wallys DR344 support under OpenWRT
> 
> Signed-off-by: Philippe DUCHEIN 
> 
> —
> 
> diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh
> b/target/linux/ar71xx/base-files/etc/diag.sh
> --- a/target/linux/ar71xx/base-files/etc/diag.sh  2015-10-27 
> 11:22:05.851103540 +0100
> +++ b/target/linux/ar71xx/base-files/etc/diag.sh  2015-10-27 
> 11:27:41.138057656 +0100
> @@ -347,6 +347,9 @@
>   wp543)
>   status_led="wp543:green:diag"
>   ;;
> + dr344)
> + status_led="dr344:green:status"
> + ;;
>   wpj344)
>   status_led="wpj344:green:status"
>   ;;
> diff -Nru
> a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
> b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
> --- a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network  
> 2015-10-27 11:22:05.846103482 +0100
> +++ b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network  
> 2015-10-27 11:30:35.631113903 +0100
> @@ -404,6 +404,10 @@
>   ucidef_set_interfaces_lan_wan "eth1" "eth0"
>   ;;
>  
> +dr344)
> + ucidef_set_interface_lan "eth0 eth1"
> + ;;
> +

There's a lot of precedent in this file for stacking entries,
even if they are from different vendors. Is there any reason not
to just add this to the set of devices at line 23 that have this
same networking configuration?


>  wpj344)
>   ucidef_set_interfaces_lan_wan "eth0.1" "eth0.2"
>   ucidef_add_switch "switch0" "1" "1"
> diff -Nru a/target/linux/ar71xx/base-files/lib/ar71xx.sh
> b/target/linux/ar71xx/base-files/lib/ar71xx.sh
> --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh2015-10-27 
> 11:22:05.874103812 +0100
> +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh2015-10-27 
> 11:27:41.138057656 +0100
> @@ -889,6 +889,9 @@
>   *WPJ344)
>   name="wpj344"
>   ;;
> + *DR344)
> + name="dr344"
> + ;;

This list is _mostly_ sorted alphabetically.  There's definitely out of place 
devices, but if you're adding new ones, why not add them in order?  around line 
450, by the Dragino board would seem to be the most appropriate place for this. 
 


>   *WPJ531)
>   name="wpj531"
>   ;;
> diff -Nru
> a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh  2015-10-27 
> 11:22:05.862103670 +0100
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh  2015-10-27 
> 11:27:41.139057668 +0100
> @@ -240,6 +240,7 @@
>   wpj531 | \
>   wndap360 | \
>   wpj344 | \
> + dr344 | \

Same here. It's not really relevant in this file that the wpj344
and this one are virtually the same.

>   wzr-hp-g300nh2 | \
>   wzr-hp-g300nh | \
>   wzr-hp-g450h | \
> diff -Nru a/target/linux/ar71xx/config-4.1
> b/target/linux/ar71xx/config-4.1
> --- a/target/linux/ar71xx/config-4.1  2015-10-27 11:22:06.234108060 +0100
> +++ b/target/linux/ar71xx/config-4.1  2015-10-27 11:27:41.139057668 +0100
> @@ -18,6 +18,7 @@
>  CONFIG_ARCH_SUSPEND_POSSIBLE=y
>  CONFIG_ARCH_WANT_IPC_PARSE_VERSION=y
>  CONFIG_AT803X_PHY=y
> +CONFIG_ATHEROS_PHY=y
>  CONFIG_ATH79=y
>  CONFIG_ATH79_DEV_AP9X_PCI=y
>  CONFIG_ATH79_DEV_DSA=y
> @@ -158,6 +159,7 @@
>  CONFIG_ATH79_MACH_WP543=y
>  CONFIG_ATH79_MACH_WPE72=y
>  CONFIG_ATH79_MACH_WPJ344=y
> +CONFIG_ATH79_MACH_DR344=y
>  CONFIG_ATH79_MACH_WPJ531=y
>  CONFIG_ATH79_MACH_WPJ558=y
>  CONFIG_ATH79_MACH_WRT160NL=y
> diff -Nru
> a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c
> b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c
> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c  1970-01-01 
> 01:00:00.0 +0100
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c  2015-10-27 
> 11:27:41.139057668 +0100
> @@ -0,0 +1,183 @@
> +/*
> + * Wallys DR344 board support
> + *
> + * Copyright (c) 2015 Philippe DUCHEIN 
> + * Copyright (c) 2011 Qualcomm Atheros
> + * Copyright (c) 2011-2012 Gabor Juhos 
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT,

[OpenWrt-Devel] [PATCH] Wallys DR-344 support

2015-10-27 Thread Philippe DUCHEIN 
This patch is for Wallys DR344 support under OpenWRT

Signed-off-by: Philippe DUCHEIN 

—

diff -Nru a/target/linux/ar71xx/base-files/etc/diag.sh 
b/target/linux/ar71xx/base-files/etc/diag.sh
--- a/target/linux/ar71xx/base-files/etc/diag.sh2015-10-27 
11:22:05.851103540 +0100
+++ b/target/linux/ar71xx/base-files/etc/diag.sh2015-10-27 
11:27:41.138057656 +0100
@@ -347,6 +347,9 @@
wp543)
status_led="wp543:green:diag"
;;
+   dr344)
+   status_led="dr344:green:status"
+   ;;
wpj344)
status_led="wpj344:green:status"
;;
diff -Nru a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network 
b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
--- a/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
2015-10-27 11:22:05.846103482 +0100
+++ b/target/linux/ar71xx/base-files/etc/uci-defaults/02_network
2015-10-27 11:30:35.631113903 +0100
@@ -404,6 +404,10 @@
ucidef_set_interfaces_lan_wan "eth1" "eth0"
;;
 
+dr344)
+   ucidef_set_interface_lan "eth0 eth1"
+   ;;
+
 wpj344)
ucidef_set_interfaces_lan_wan "eth0.1" "eth0.2"
ucidef_add_switch "switch0" "1" "1"
diff -Nru a/target/linux/ar71xx/base-files/lib/ar71xx.sh 
b/target/linux/ar71xx/base-files/lib/ar71xx.sh
--- a/target/linux/ar71xx/base-files/lib/ar71xx.sh  2015-10-27 
11:22:05.874103812 +0100
+++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh  2015-10-27 
11:27:41.138057656 +0100
@@ -889,6 +889,9 @@
*WPJ344)
name="wpj344"
;;
+   *DR344)
+   name="dr344"
+   ;;
*WPJ531)
name="wpj531"
;;
diff -Nru a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
--- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh2015-10-27 
11:22:05.862103670 +0100
+++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh2015-10-27 
11:27:41.139057668 +0100
@@ -240,6 +240,7 @@
wpj531 | \
wndap360 | \
wpj344 | \
+   dr344 | \
wzr-hp-g300nh2 | \
wzr-hp-g300nh | \
wzr-hp-g450h | \
diff -Nru a/target/linux/ar71xx/config-4.1 b/target/linux/ar71xx/config-4.1
--- a/target/linux/ar71xx/config-4.12015-10-27 11:22:06.234108060 +0100
+++ b/target/linux/ar71xx/config-4.12015-10-27 11:27:41.139057668 +0100
@@ -18,6 +18,7 @@
 CONFIG_ARCH_SUSPEND_POSSIBLE=y
 CONFIG_ARCH_WANT_IPC_PARSE_VERSION=y
 CONFIG_AT803X_PHY=y
+CONFIG_ATHEROS_PHY=y
 CONFIG_ATH79=y
 CONFIG_ATH79_DEV_AP9X_PCI=y
 CONFIG_ATH79_DEV_DSA=y
@@ -158,6 +159,7 @@
 CONFIG_ATH79_MACH_WP543=y
 CONFIG_ATH79_MACH_WPE72=y
 CONFIG_ATH79_MACH_WPJ344=y
+CONFIG_ATH79_MACH_DR344=y
 CONFIG_ATH79_MACH_WPJ531=y
 CONFIG_ATH79_MACH_WPJ558=y
 CONFIG_ATH79_MACH_WRT160NL=y
diff -Nru a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c 
b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c1970-01-01 
01:00:00.0 +0100
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-dr344.c2015-10-27 
11:27:41.139057668 +0100
@@ -0,0 +1,183 @@
+/*
+ * Wallys DR344 board support
+ *
+ * Copyright (c) 2015 Philippe DUCHEIN 
+ * Copyright (c) 2011 Qualcomm Atheros
+ * Copyright (c) 2011-2012 Gabor Juhos 
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "common.h"
+#include "pci.h"
+#include "dev-ap9x-pci.h"
+#include "dev-gpio-buttons.h"
+#include "dev-eth.h"
+#include "dev-usb.h"
+#include "dev-leds-gpio.h"
+#include "dev-m25p80.h"
+#include "dev-spi.h"
+#include "dev-wmac.h"
+#include "machtypes.h"
+
+#define DR344_GPIO_LED_SIG115
+#define DR344_GPIO_LED_SIG220
+#define DR344_GPIO_LED_SIG321
+#define DR344_GPIO_LED_SIG422
+#define DR344_GPIO_EXTERNAL_LNA0   18
+#define DR344_GPIO_EXTERNAL_LNA1   19
+#define DR344_GPIO_LED_STATUS  14
+
+#define DR344_GPIO_BTN_RESET   12
+
+#define DR344_KEYS_POLL_INTERVAL   20  /* msecs */
+#define DR344_KEYS_DEBOUNCE_INTERVAL   (3 * DR344_KEYS_POLL_INTERVAL)
+