Re: [OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
Josef Schlehofer [2020-06-03 15:50:59]: Hi, > Other guys who have commit access it seems that they are not doing that and > merging it fine with me, it's their decision. > I think that your policy should be applied to all not just someone and > should be followed by everyone. it's not mine policy, it's a good habbit, best practice and I can go on for next dozen lines or more. Anyway, I'm just trying to be consistent so I do the same and demand the same. If in doubt, read project's Patch checklist[1]. 1. https://openwrt.org/submitting-patches#patch_checklist -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
Hello, On 03. 06. 20 14:53, Petr Štetiar wrote: > Pali Rohár [2020-06-03 14:48:23]: > >> What do you suggest to put into commit description of such small change >> where commit title already contains description of the whole change? > lspci output as in your other patch, simply something, otherwise it means > additional work for me I am looking into previous commits in iwinfo and there are not many commits which have the description, which you suggested at all. So, what has been changed? Other guys who have commit access it seems that they are not doing that and merging it as I think in the commit message is everything that you need. I think that your policy should be applied to all not just someone and should be followed by everyone. Just my two cents. For example, I was looking into these commits: https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=eba5a204f776f49b9948b41e41c03560dbd307c8 https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=bb216982951698833bbdf4a88872e9b5ccd026a5 https://git.openwrt.org/?p=project/iwinfo.git;a=commit;h=e59f9253aa09a340d235dac074a10a4fe48b62fd and many others as well. Regards, Josef > > -- ynezz > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
Pali Rohár [2020-06-03 14:48:23]: > What do you suggest to put into commit description of such small change > where commit title already contains description of the whole change? lspci output as in your other patch, simply something, otherwise it means additional work for me -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
On Wednesday 03 June 2020 13:30:01 Petr Štetiar wrote: > Pali Rohár [2020-05-20 14:33:05]: > > Hi, please next time don't forget to add commit description as it's > mandatory. Thanks. Hello Petr, thank you for taking these patches! What do you suggest to put into commit description of such small change where commit title already contains description of the whole change? > > Signed-off-by: Pali Rohár > > --- > > hardware.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hardware.txt b/hardware.txt > > index 07f61b7..64ab708 100644 > > --- a/hardware.txt > > +++ b/hardware.txt > > @@ -174,6 +174,7 @@ > > 0x11ab 0x2a55 0x11ab 0x0 0 "Marvell" "88W8864" > > 0x02df 0x9135 0x 0x0 0 "Marvell" "88W8887" > > 0x11ab 0x2b40 0x11ab 0x0 0 "Marvell" "88W8964" > > +0x02df 0x9141 0x 0x0 0 "Marvell" "88W8997" > > 0x14c3 0x7603 0x14c3 0x76030 0 "MediaTek" "MT7603E" > > 0x14c3 0x7610 0x14c3 0x76100 0 "MediaTek" "MT7610E" > > 0x14c3 0x7612 0x14c3 0x76120 0 "MediaTek" "MT7612E" > > -- > > 2.20.1 > > > > > > -- > ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
Pali Rohár [2020-05-20 14:33:05]: Hi, please next time don't forget to add commit description as it's mandatory. Thanks. > Signed-off-by: Pali Rohár > --- > hardware.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hardware.txt b/hardware.txt > index 07f61b7..64ab708 100644 > --- a/hardware.txt > +++ b/hardware.txt > @@ -174,6 +174,7 @@ > 0x11ab 0x2a55 0x11ab 0x0 0 "Marvell" "88W8864" > 0x02df 0x9135 0x 0x0 0 "Marvell" "88W8887" > 0x11ab 0x2b40 0x11ab 0x0 0 "Marvell" "88W8964" > +0x02df 0x9141 0x 0x0 0 "Marvell" "88W8997" > 0x14c3 0x7603 0x14c3 0x76030 0 "MediaTek" "MT7603E" > 0x14c3 0x7610 0x14c3 0x76100 0 "MediaTek" "MT7610E" > 0x14c3 0x7612 0x14c3 0x76120 0 "MediaTek" "MT7612E" > -- > 2.20.1 > > -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH iwinfo] iwinfo: add device id for Marvell 88W8997 SDIO wifi card
Signed-off-by: Pali Rohár --- hardware.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/hardware.txt b/hardware.txt index 07f61b7..64ab708 100644 --- a/hardware.txt +++ b/hardware.txt @@ -174,6 +174,7 @@ 0x11ab 0x2a55 0x11ab 0x0 0 "Marvell" "88W8864" 0x02df 0x9135 0x 0x0 0 "Marvell" "88W8887" 0x11ab 0x2b40 0x11ab 0x0 0 "Marvell" "88W8964" +0x02df 0x9141 0x 0x0 0 "Marvell" "88W8997" 0x14c3 0x7603 0x14c3 0x76030 0 "MediaTek" "MT7603E" 0x14c3 0x7610 0x14c3 0x76100 0 "MediaTek" "MT7610E" 0x14c3 0x7612 0x14c3 0x76120 0 "MediaTek" "MT7612E" -- 2.20.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
