Re: [OpenWrt-Devel] [PATCH 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Comman Kang]

Done, Thanks for the comment, please take a look at V2




在 15/9/28 下午7:25，“Piotr Dymacz” 写入:

>Hello,
>
>Please, take a look at other dts files in ramips target and follow the
>general convention, like:
>- use only model name for dts filename
>- keep empty lines between nodes and between nodes and properties (ex. [1])
>
>[1] 
>https://dev.openwrt.org/browser/trunk/target/linux/ramips/dts/WIZFI630A.dts#L126
>
>Cheers,
>Piotr
>
>2015-09-28 12:45 GMT+02:00 Comman Kang :
>> HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. 
>> These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). 
>> This patch adds support for them.
>>
>> The original author is Justin Liu (rss...@gmail.com). I ported the patch to 
>> trunk and submitted it here with his approval.
>>
>> Signed-off-by: Xiaoning Kang 
>>
>>
>>
>> diff --git a/target/linux/ramips/dts/HiWiFi-HC5661.dts 
>> b/target/linux/ramips/dts/HiWiFi-HC5661.dts
>> new file mode 100644
>> index 000..f3ca70c
>> --- /dev/null
>> +++ b/target/linux/ramips/dts/HiWiFi-HC5661.dts
>> @@ -0,0 +1,162 @@
>> +/dts-v1/;
>> +
>> +/include/ "mt7620a.dtsi"
>> +
>> +/ {
>> +   compatible = "HiWiFi-HC5661", "ralink,mt7620a-soc";
>> +   model = "HiWiFi HC5661";
>> +
>> +   chosen {
>> +   bootargs = "console=ttyS0,115200";
>> +   };
>> +
>> +   palmbus@1000 {
>> +   sysc@0 {
>> +   ralink,gpiomux = "i2c", "jtag";
>> +   ralink,uartmux = "gpio";
>> +   ralink,wdtmux = <1>;
>> +   };
>> +   gpio0: gpio@600 {
>> +   status = "okay";
>> +   };
>> +   gpio2: gpio@660 {
>> +   status = "okay";
>> +   };
>> +   gpio3: gpio@688 {
>> +   status = "okay";
>> +   };
>> +
>> +   spi@b00 {
>> +   status = "okay";
>> +
>> +   m25p80@0 {
>> +   #address-cells = <1>;
>> +   #size-cells = <1>;
>> +   compatible = "w25q128";
>> +   reg = <0 0>;
>> +   linux,modalias = "m25p80", "w25q128";
>> +   spi-max-frequency = <1000>;
>> +
>> +   partition@0 {
>> +   label = "u-boot";
>> +   reg = <0x0 0x3>;
>> +   };
>> +
>> +   partition@3 {
>> +   label = "u-boot-env";
>> +   reg = <0x3 0x1>;
>> +   read-only;
>> +   };
>> +
>> +   factory: partition@4 {
>> +   label = "factory";
>> +   reg = <0x4 0x1>;
>> +   };
>> +
>> +   partition@5 {
>> +   label = "firmware";
>> +   reg = <0x5 0xf8>;
>> +   };
>> +
>> +   partition@fd {
>> +   label = "hwf_config";
>> +   reg = <0xfd 0x1>;
>> +   };
>> +
>> +   bdinfo: partition@fe {
>> +   label = "bdinfo";
>> +   reg = <0xfe 0x1>;
>> +   };
>> +
>> +   partition@ff {
>> +   label = "backup";
>> +   reg = <0xff 0x1>;
>> +   };
>> +   };
>> +   };
>> +   };
>> +
>> +   ehci@101c {
>> +   status = "okay";
>> +   };
>> +
>> +   ohci@101c1000 {
>> +   status = "okay";
>> +   };
>> +
>> +   ethernet@1010 {
>> +   pinctrl-names = "default";
>> +   pinctrl-0 = <_pins>;
>> +   mtd-mac-address = < 0x4>;
>> +   ralink,port-map = "w";
>> +   };
>> +
>> +   sdhci@1013 {
>> +   status = "okay";
>> +   };
>> +
>> +   wmac@1018 {
>> +   ralink,mtd-eeprom = < 0>;
>> +   };
>> +
>> +   pcie@1014 {
>> +   status = "okay";
>> +   };
>> +
>> +   pinctrl {
>> +   state_default: pinctrl0 {
>> +   gpio {
>> +   ralink,group = "uartf", "wled", "nd_sd";
>> +   

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Piotr Dymacz]

Hello,

Please, take a look at other dts files in ramips target and follow the
general convention, like:
- use only model name for dts filename
- keep empty lines between nodes and between nodes and properties (ex. [1])

[1] 
https://dev.openwrt.org/browser/trunk/target/linux/ramips/dts/WIZFI630A.dts#L126

Cheers,
Piotr

2015-09-28 12:45 GMT+02:00 Comman Kang :
> HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. 
> These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). 
> This patch adds support for them.
>
> The original author is Justin Liu (rss...@gmail.com). I ported the patch to 
> trunk and submitted it here with his approval.
>
> Signed-off-by: Xiaoning Kang 
>
>
>
> diff --git a/target/linux/ramips/dts/HiWiFi-HC5661.dts 
> b/target/linux/ramips/dts/HiWiFi-HC5661.dts
> new file mode 100644
> index 000..f3ca70c
> --- /dev/null
> +++ b/target/linux/ramips/dts/HiWiFi-HC5661.dts
> @@ -0,0 +1,162 @@
> +/dts-v1/;
> +
> +/include/ "mt7620a.dtsi"
> +
> +/ {
> +   compatible = "HiWiFi-HC5661", "ralink,mt7620a-soc";
> +   model = "HiWiFi HC5661";
> +
> +   chosen {
> +   bootargs = "console=ttyS0,115200";
> +   };
> +
> +   palmbus@1000 {
> +   sysc@0 {
> +   ralink,gpiomux = "i2c", "jtag";
> +   ralink,uartmux = "gpio";
> +   ralink,wdtmux = <1>;
> +   };
> +   gpio0: gpio@600 {
> +   status = "okay";
> +   };
> +   gpio2: gpio@660 {
> +   status = "okay";
> +   };
> +   gpio3: gpio@688 {
> +   status = "okay";
> +   };
> +
> +   spi@b00 {
> +   status = "okay";
> +
> +   m25p80@0 {
> +   #address-cells = <1>;
> +   #size-cells = <1>;
> +   compatible = "w25q128";
> +   reg = <0 0>;
> +   linux,modalias = "m25p80", "w25q128";
> +   spi-max-frequency = <1000>;
> +
> +   partition@0 {
> +   label = "u-boot";
> +   reg = <0x0 0x3>;
> +   };
> +
> +   partition@3 {
> +   label = "u-boot-env";
> +   reg = <0x3 0x1>;
> +   read-only;
> +   };
> +
> +   factory: partition@4 {
> +   label = "factory";
> +   reg = <0x4 0x1>;
> +   };
> +
> +   partition@5 {
> +   label = "firmware";
> +   reg = <0x5 0xf8>;
> +   };
> +
> +   partition@fd {
> +   label = "hwf_config";
> +   reg = <0xfd 0x1>;
> +   };
> +
> +   bdinfo: partition@fe {
> +   label = "bdinfo";
> +   reg = <0xfe 0x1>;
> +   };
> +
> +   partition@ff {
> +   label = "backup";
> +   reg = <0xff 0x1>;
> +   };
> +   };
> +   };
> +   };
> +
> +   ehci@101c {
> +   status = "okay";
> +   };
> +
> +   ohci@101c1000 {
> +   status = "okay";
> +   };
> +
> +   ethernet@1010 {
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_pins>;
> +   mtd-mac-address = < 0x4>;
> +   ralink,port-map = "w";
> +   };
> +
> +   sdhci@1013 {
> +   status = "okay";
> +   };
> +
> +   wmac@1018 {
> +   ralink,mtd-eeprom = < 0>;
> +   };
> +
> +   pcie@1014 {
> +   status = "okay";
> +   };
> +
> +   pinctrl {
> +   state_default: pinctrl0 {
> +   gpio {
> +   ralink,group = "uartf", "wled", "nd_sd";
> +   ralink,function = "gpio";
> +   };
> +   pa {
> +   ralink,group = "pa";
> +   ralink,function = "pa";
> +   };
> +