Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
On 9 May 2017 at 10:24, Rafał Miłecki wrote:
> On 8 May 2017 at 13:43, Smith, Pieter wrote:
>> I am still hoping to get confirmation from you on this patch. Is this
>> acceptable for upstreaming?
>>
>>> Hi Rafał,
>>>
>>> > > On 03/29/2017 11:53 AM, Smith, Pieter wrote:
>>> > > > My apologies. I am not able to get mutt working with our corporate
>>> > > > infrastructure. I hope it arrives unmangled as an attachment. If
>>> > > > not, I'll use my personal mail.
>>> > >
>>> > > This would be acceptable for me to pick patch sent as attachment,
>>> > > but you really need to sign it off with your name. Please add a
>>> > > proper
>>> > > Signed-off-by:
>>> > > line and resend.
>>> >
>>> > Off-course! My bad...
>>>
>>> In adding more logging so that you can diagnose the issue, I tracked down
>>> the root cause and fixed the issue. Attached, > please find an updated
>>> patch with sign-off and a problem description.
>
> Sorry, it took me more time than it was supposed to. Your patch went
> into the fstools repository.
>
> 1) LEDE master branch
> We'll bump package after fixing regression caused by commit
> a19f2b3c21288 ("build: disable the format-truncation warning error to
> fix gcc 7 build errors") which results in:
> cc1: error: -Werror=format-truncation: no option -Wformat-truncation
commit 65a3dc277f3f4 ("fstools: update to the latest version")
> 2) LEDE lede-17.01 branch:
> I sent patch to backport your fix:
> https://patchwork.ozlabs.org/patch/759957/
commit 0bef8f8011d11 ("fstools: backport regression fix for volume_identify")
> 3) OpenWrt 15.05 branch:
> I don't really want to mess with that. I don't know if I have
> privileges nor if my patch could be accepted. We need someone working
> on OpenWrt to handle this.
--
Rafał
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
Hi Rafał,
On 09 May 2017 at 10:25, Rafał Miłecki wrote:
> On 8 May 2017 at 13:43, Smith, Pieter wrote:
> > I am still hoping to get confirmation from you on this patch. Is this
> > acceptable for upstreaming?
> >
> >> Hi Rafał,
> >>
> >> > > On 03/29/2017 11:53 AM, Smith, Pieter wrote:
> >> > > > My apologies. I am not able to get mutt working with our
> >> > > > corporate infrastructure. I hope it arrives unmangled as an
> >> > > > attachment. If not, I'll use my personal mail.
> >> > >
> >> > > This would be acceptable for me to pick patch sent as attachment,
> >> > > but you really need to sign it off with your name. Please add a
> >> > > proper
> >> > > Signed-off-by:
> >> > > line and resend.
> >> >
> >> > Off-course! My bad...
> >>
> >> In adding more logging so that you can diagnose the issue, I tracked down
> >> the root cause and fixed the issue. Attached, > > please find an updated
> >> patch with sign-off and a problem description.
>
> Sorry, it took me more time than it was supposed to. Your patch went into the
> fstools repository.
>
> 1) LEDE master branch
> We'll bump package after fixing regression caused by commit
> a19f2b3c21288 ("build: disable the format-truncation warning error to fix gcc
> 7 build errors") which results in:
> cc1: error: -Werror=format-truncation: no option -Wformat-truncation
>
> 2) LEDE lede-17.01 branch:
> I sent patch to backport your fix:
> https://patchwork.ozlabs.org/patch/759957/
>
> 3) OpenWrt 15.05 branch:
> I don't really want to mess with that. I don't know if I have privileges nor
> if my patch could be accepted. We need someone > working on OpenWrt to handle
> this.
>
> --
> Rafał
Thanks for the confirmation!
- Pieter
The information contained in this message may be confidential and legally
protected under applicable law. The message is intended solely for the
addressee(s). If you are not the intended recipient, you are hereby notified
that any use, forwarding, dissemination, or reproduction of this message is
strictly prohibited and may be unlawful. If you are not the intended recipient,
please contact the sender by return e-mail and destroy all copies of the
original message.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
On 8 May 2017 at 13:43, Smith, Pieter wrote:
> I am still hoping to get confirmation from you on this patch. Is this
> acceptable for upstreaming?
>
>> Hi Rafał,
>>
>> > > On 03/29/2017 11:53 AM, Smith, Pieter wrote:
>> > > > My apologies. I am not able to get mutt working with our corporate
>> > > > infrastructure. I hope it arrives unmangled as an attachment. If
>> > > > not, I'll use my personal mail.
>> > >
>> > > This would be acceptable for me to pick patch sent as attachment,
>> > > but you really need to sign it off with your name. Please add a
>> > > proper
>> > > Signed-off-by:
>> > > line and resend.
>> >
>> > Off-course! My bad...
>>
>> In adding more logging so that you can diagnose the issue, I tracked down
>> the root cause and fixed the issue. Attached, > please find an updated patch
>> with sign-off and a problem description.
Sorry, it took me more time than it was supposed to. Your patch went
into the fstools repository.
1) LEDE master branch
We'll bump package after fixing regression caused by commit
a19f2b3c21288 ("build: disable the format-truncation warning error to
fix gcc 7 build errors") which results in:
cc1: error: -Werror=format-truncation: no option -Wformat-truncation
2) LEDE lede-17.01 branch:
I sent patch to backport your fix:
https://patchwork.ozlabs.org/patch/759957/
3) OpenWrt 15.05 branch:
I don't really want to mess with that. I don't know if I have
privileges nor if my patch could be accepted. We need someone working
on OpenWrt to handle this.
--
Rafał
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
Hi Rafał, I am still hoping to get confirmation from you on this patch. Is this acceptable for upstreaming? > Hi Rafał, > > > > On 03/29/2017 11:53 AM, Smith, Pieter wrote: > > > > My apologies. I am not able to get mutt working with our corporate > > > > infrastructure. I hope it arrives unmangled as an attachment. If > > > > not, I'll use my personal mail. > > > > > > This would be acceptable for me to pick patch sent as attachment, > > > but you really need to sign it off with your name. Please add a > > > proper > > > Signed-off-by: > > > line and resend. > > > > Off-course! My bad... > > In adding more logging so that you can diagnose the issue, I tracked down the > root cause and fixed the issue. Attached, > please find an updated patch with > sign-off and a problem description. > > - Pieter Regards, Pieter The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
Hi Rafał, > > On 03/29/2017 11:53 AM, Smith, Pieter wrote: > > > My apologies. I am not able to get mutt working with our corporate > > > infrastructure. I hope it arrives unmangled as an attachment. If not, > > > I'll use my personal mail. > > > > This would be acceptable for me to pick patch sent as attachment, but you > > really need to sign it off with your name. Please add a proper > > Signed-off-by: > > line and resend. > > Off-course! My bad... In adding more logging so that you can diagnose the issue, I tracked down the root cause and fixed the issue. Attached, please find an updated patch with sign-off and a problem description. - Pieter The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message. 0001-fix-factory-flashed-startup-issue-with-jffs2-on-ubi-.patch Description: 0001-fix-factory-flashed-startup-issue-with-jffs2-on-ubi-.patch ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
> On 03/29/2017 11:53 AM, Smith, Pieter wrote: > > My apologies. I am not able to get mutt working with our corporate > > infrastructure. I hope it arrives unmangled as an attachment. If not, > > I'll use my personal mail. > > This would be acceptable for me to pick patch sent as attachment, but you > really need to sign it off with your name. Please add a proper > Signed-off-by: > line and resend. Off-course! My bad... The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
> On 03/28/2017 03:26 PM, Smith, Pieter wrote: > > The refactoring in ba019965 eliminated an unneeded call to > > volume_find() when > > done() calls jffs2_switch(). Unfortunately the refactoring did not > > take into account that volume_identify() has side-effects with the mtd > > driver implementation and a second call to volume_identify() on the > > same struct volume may render a different result. > > AFAIU this is about mtd driver, so volume_identify basically means > mtd_volume_identify. > > Can you do some extra debugging for me and check which exact part of > mtd_volume_identify has this side effect? I don't see which part of this > function would affect volume identification in further calls. I will see what I can do tomorrow. > This may be a bit tricky to debug as you can't call volume_identify inside > (at least without some recursive check). Can you handle this somehow? > > I'd like to make sure I understand this bug fully before pushing a fix. > > Also: which target uses jffs2 with ubi?! A concession I grudgingly had to accept from Qualcomm on their IoE platform in order to hit our market release. OpenWRT at that point in time still lacked a lot of infrastructure, putting UBI/FS out of reach given the time constraints. - Pieter The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
On 03/29/2017 11:53 AM, Smith, Pieter wrote: My apologies. I am not able to get mutt working with our corporate infrastructure. I hope it arrives unmangled as an attachment. If not, I'll use my personal mail. This would be acceptable for me to pick patch sent as attachment, but you really need to sign it off with your name. Please add a proper Signed-off-by: line and resend. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
On 03/28/2017 03:26 PM, Smith, Pieter wrote: The refactoring in ba019965 eliminated an unneeded call to volume_find() when done() calls jffs2_switch(). Unfortunately the refactoring did not take into account that volume_identify() has side-effects with the mtd driver implementation and a second call to volume_identify() on the same struct volume may render a different result. AFAIU this is about mtd driver, so volume_identify basically means mtd_volume_identify. Can you do some extra debugging for me and check which exact part of mtd_volume_identify has this side effect? I don't see which part of this function would affect volume identification in further calls. This may be a bit tricky to debug as you can't call volume_identify inside (at least without some recursive check). Can you handle this somehow? I'd like to make sure I understand this bug fully before pushing a fix. Also: which target uses jffs2 with ubi?! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
Hi Rafał, My apologies. I am not able to get mutt working with our corporate infrastructure. I hope it arrives unmangled as an attachment. If not, I'll use my personal mail. Regards, Pieter -Original Message- From: Rafał Miłecki [mailto:zaj...@gmail.com] Sent: 28 March 2017 16:52 To: Smith, Pieter Cc: John Crispin ; openwrt-devel@lists.openwrt.org Subject: Re: Factory startup issues since mount_root / libfstools improvements in Chaos Calmer On 28 March 2017 at 15:26, Smith, Pieter wrote: > I need your help in confirming a bug that I suspect can be traced back > to a patch you authored / merged. This is what I am observing: > > Commit ba01996534d15dc725a2dcc56a59fbfb24b58787 in > git://git.openwrt.org/project/fstools.git seems to have broken startup > for factory-flashed jffs2 OpenWRT systems, causing substantial > slowdown in factory environments. I'll research on that, but could you meanwhile send a patch that is not white space mangled? This one can't really be applied cleanly. The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message. 0003-fix-startup-with-empty-rootfs_data-UBI-volume.patch Description: 0003-fix-startup-with-empty-rootfs_data-UBI-volume.patch ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Factory startup issues since mount_root / libfstools improvements in Chaos Calmer
On 28 March 2017 at 15:26, Smith, Pieter wrote: > I need your help in confirming a bug that I suspect can be traced back to a > patch you authored / merged. This is what I am observing: > > Commit ba01996534d15dc725a2dcc56a59fbfb24b58787 in > git://git.openwrt.org/project/fstools.git seems to have broken startup for > factory-flashed jffs2 OpenWRT systems, causing substantial slowdown in factory > environments. I'll research on that, but could you meanwhile send a patch that is not white space mangled? This one can't really be applied cleanly. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
