Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Hi,
On Thursday 19 June 2008 23:10, Rick Pingry wrote:
Subject says it. Might have forgotten to SVN add OpenThreads\Config.
Try the attached change to the top level cmake file.
That change just did not make it into svn.
In source tree builds will work without the patch. Out of source builds
hopefully when Robert has merged that :)
GReetings
Mathias
--
Dr. Mathias Fröhlich, science + computing ag, Software Solutions
Hagellocher Weg 71-75, D-72070 Tuebingen, Germany
Phone: +49 7071 9457-268, Fax: +49 7071 9457-511
--
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Florian Geyer,
Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Prof. Dr. Hanns Ruder
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196
Index: CMakeLists.txt
===
--- CMakeLists.txt (revision 8468)
+++ CMakeLists.txt (working copy)
@@ -99,6 +99,7 @@
# Make the headers visible to everything
INCLUDE_DIRECTORIES(
+${PROJECT_BINARY_DIR}/include
${OpenSceneGraph_SOURCE_DIR}/include
${OPENGL_INCLUDE_DIR}
)
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
* Melchior FRANZ -- Friday 20 June 2008: $OSG/include/OpenThreads/Atomic:140: error: \ ‘oldPtr’ was not declared in this scope OK, so this should be ptrOld now? As in: --- include/OpenThreads/Atomic (revision 8468) +++ include/OpenThreads/Atomic (working copy) @@ -132,12 +132,12 @@ return ptrOld == InterlockedCompareExchangePointer(_ptr, ptrNew, ptrOld); #elif defined(_OPENTHREADS_ATOMIC_USE_MUTEX) ScopedLockMutex lock(_mutex); -if (_ptr != oldPtr) +if (_ptr != ptrOld) return false; _ptr = ptrNew; return true; #else -if (_ptr != oldPtr) +if (_ptr != ptrOld) return false; _ptr = ptrNew; return true; m. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Hi Guys, On Fri, Jun 20, 2008 at 7:08 AM, Mathias Fröhlich [EMAIL PROTECTED] wrote: That change just did not make it into svn. In source tree builds will work without the patch. Out of source builds hopefully when Robert has merged that :) Now merged and submitted to SVN. I'm entirely clear/happy with this solution yet though so it might be so that it might be revised later on. Right now we needs to compile though... Let me know how you get on. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Robert Osfield wrote: Hi Guys, On Fri, Jun 20, 2008 at 7:08 AM, Mathias Fröhlich [EMAIL PROTECTED] wrote: That change just did not make it into svn. In source tree builds will work without the patch. Out of source builds hopefully when Robert has merged that :) Now merged and submitted to SVN. I'm entirely clear/happy with this solution yet though so it might be so that it might be revised later on. Right now we needs to compile though... Robert Osfield wrote: Hi Guys, On Fri, Jun 20, 2008 at 7:08 AM, Mathias Fröhlich [EMAIL PROTECTED] wrote: That change just did not make it into svn. In source tree builds will work without the patch. Out of source builds hopefully when Robert has merged that :) Now merged and submitted to SVN. I'm entirely clear/happy with this solution yet though so it might be so that it might be revised later on. Right now we needs to compile though... Nope, still not working with r8469 10:41|[EMAIL PROTECTED]:/usr/paul/osg-build make [ 0%] Built target OpenThreads [ 0%] Building CXX object src/osg/CMakeFiles/osg.dir/AlphaFunc.o /home/paul/c/osg-svn/include/OpenThreads/Atomic: In member function 'bool OpenThreads::AtomicPtrT::assign(T*, const T*)': /home/paul/c/osg-svn/include/OpenThreads/Atomic:140: error: 'oldPtr' was not declared in this scope make[2]: *** [src/osg/CMakeFiles/osg.dir/AlphaFunc.o] Error 1 make[1]: *** [src/osg/CMakeFiles/osg.dir/all] Error 2 make: *** [all] Error 2 Paul ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Hi Melchior, Your change looks correct, now applied and checked into SVN. I am a bit surprised that _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS path wasn't selected on your machine, perhaps the checks for support need to be tweaked. Robert. On Fri, Jun 20, 2008 at 7:45 AM, Melchior FRANZ [EMAIL PROTECTED] wrote: * Melchior FRANZ -- Friday 20 June 2008: $OSG/include/OpenThreads/Atomic:140: error: \ 'oldPtr' was not declared in this scope OK, so this should be ptrOld now? As in: --- include/OpenThreads/Atomic (revision 8468) +++ include/OpenThreads/Atomic (working copy) @@ -132,12 +132,12 @@ return ptrOld == InterlockedCompareExchangePointer(_ptr, ptrNew, ptrOld); #elif defined(_OPENTHREADS_ATOMIC_USE_MUTEX) ScopedLockMutex lock(_mutex); -if (_ptr != oldPtr) +if (_ptr != ptrOld) return false; _ptr = ptrNew; return true; #else -if (_ptr != oldPtr) +if (_ptr != ptrOld) return false; _ptr = ptrNew; return true; m. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Paul Melis wrote: Robert Osfield wrote: Hi Guys, On Fri, Jun 20, 2008 at 7:08 AM, Mathias Fröhlich [EMAIL PROTECTED] wrote: That change just did not make it into svn. In source tree builds will work without the patch. Out of source builds hopefully when Robert has merged that :) Now merged and submitted to SVN. I'm entirely clear/happy with this solution yet though so it might be so that it might be revised later on. Right now we needs to compile though... Robert Osfield wrote: Hi Guys, On Fri, Jun 20, 2008 at 7:08 AM, Mathias Fröhlich [EMAIL PROTECTED] wrote: That change just did not make it into svn. In source tree builds will work without the patch. Out of source builds hopefully when Robert has merged that :) Now merged and submitted to SVN. I'm entirely clear/happy with this solution yet though so it might be so that it might be revised later on. Right now we needs to compile though... Nope, still not working with r8469 But with r8470 it now does ;-) Paul 10:41|[EMAIL PROTECTED]:/usr/paul/osg-build make [ 0%] Built target OpenThreads [ 0%] Building CXX object src/osg/CMakeFiles/osg.dir/AlphaFunc.o /home/paul/c/osg-svn/include/OpenThreads/Atomic: In member function 'bool OpenThreads::AtomicPtrT::assign(T*, const T*)': /home/paul/c/osg-svn/include/OpenThreads/Atomic:140: error: 'oldPtr' was not declared in this scope make[2]: *** [src/osg/CMakeFiles/osg.dir/AlphaFunc.o] Error 1 make[1]: *** [src/osg/CMakeFiles/osg.dir/all] Error 2 make: *** [all] Error 2 Paul ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Robert, On Friday 20 June 2008 10:43, Robert Osfield wrote: I am a bit surprised that _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS path wasn't selected on your machine, perhaps the checks for support need to be tweaked. i386 (=32 bit) builds do not use that for now. The problem is that gcc assumes to have the i386 (read i386 != i486 or anything newer) avaliable when it compiles a 32 bit binary. With that instruction set, it does not have atomic operations available. INstead of the inline stuff, gcc then emits a library call that ends in an unresolved symbol. If you specify any -march=whatevernewertargettocompilefor to gcc the builtin is inlined with something usable. But since the default is different we might run into trouble more often than not. I am thinking how to solve that without braking anything. So this will come in some time, but for now 32 bit gcc linux builds do not get that. GReetings MAthias -- Dr. Mathias Fröhlich, science + computing ag, Software Solutions Hagellocher Weg 71-75, D-72070 Tuebingen, Germany Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196 ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
* Mathias Fröhlich -- Friday 20 June 2008: [Performing Test _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS - Failed] If you specify any -march=whatevernewertargettocompilefor to gcc the builtin is inlined with something usable. I was using -march=pentium4 already, so it should have worked? m. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
On Friday 20 June 2008 11:31, Melchior FRANZ wrote: * Mathias Fröhlich -- Friday 20 June 2008: [Performing Test _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS - Failed] If you specify any -march=whatevernewertargettocompilefor to gcc the builtin is inlined with something usable. I was using -march=pentium4 already, so it should have worked? No. Since we cannot ensure that during compile time of sources including osg/* or OpenThreads/*, -march=newenough is specified on the command line this is currently disabled completely. There are ways around, but not yet implemented. GReetings Mathias -- Dr. Mathias Fröhlich, science + computing ag, Software Solutions Hagellocher Weg 71-75, D-72070 Tuebingen, Germany Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196 ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] Build 8458 Problem with OpenThreads\Atomic wanting to include a missing OpenThreads\Config
Subject says it. Might have forgotten to SVN add OpenThreads\Config. -- Thanks, Rick Check us out at http://fringe-online.com/ ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
