Re: [osg-users] Bug in Collada reader

2014-12-23 Thread Robert Osfield
Hi Mark,

Thanks for the rest model.  I have finally had the time to look into this
issue and have resolved it by added a fallback of reading the color array
as a Vec3Array if only rgb colours are available.  The fix is checked into
svn/trunk.

Cheers,
Robert.

On 27 March 2014 at 14:35, Bolstad, Mark bolst...@janelia.hhmi.org wrote:

 While trying to map some functionality to color per vertex, I came across
 a bug in that colors aren't loaded properly.

 At daeReader::resolveMeshArrays:931 (daeRGeometry.cpp) it calls out to
 createGeometryArrays with types of Vec4Array. If you trace this down into
 the daeSourceReader call to getArray, you'll find that it reads the data
 into a Vec3Array, then returns the Vec4Array resulting in no colors.

 Anyone have a quick fix? (I'm currently attempting to change the array to
 Vec3, then convert it to a Vec4 in resolve MeshArrays).

 Attached is a small collada file created in Blender that shows the problem.

 Mark

 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Bug in Collada reader

2014-03-27 Thread Trajce Nikolov NICK
from what you are stating if the color array is Vec4Array in creation you
should cast to the same in the reading portion - I guess the 4th component
is alpha of the color which is the proper way to have the colors stored. So
the fix would be casting to Vec4array in the reading part to get valid
array object

Nick


On Thu, Mar 27, 2014 at 3:35 PM, Bolstad, Mark bolst...@janelia.hhmi.orgwrote:

 While trying to map some functionality to color per vertex, I came across
 a bug in that colors aren't loaded properly.

 At daeReader::resolveMeshArrays:931 (daeRGeometry.cpp) it calls out to
 createGeometryArrays with types of Vec4Array. If you trace this down into
 the daeSourceReader call to getArray, you'll find that it reads the data
 into a Vec3Array, then returns the Vec4Array resulting in no colors.

 Anyone have a quick fix? (I'm currently attempting to change the array to
 Vec3, then convert it to a Vec4 in resolve MeshArrays).

 Attached is a small collada file created in Blender that shows the problem.

 Mark

 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




-- 
trajce nikolov nick
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Bug in Collada reader

2014-03-27 Thread Trajce Nikolov NICK
I read the code fast, actually it is the other way around I think. In the
reader it should read Vec4Array. Can you point me to the reading part
(file:line) where to look?

Nick


On Thu, Mar 27, 2014 at 4:21 PM, Trajce Nikolov NICK 
trajce.nikolov.n...@gmail.com wrote:

 from what you are stating if the color array is Vec4Array in creation you
 should cast to the same in the reading portion - I guess the 4th component
 is alpha of the color which is the proper way to have the colors stored. So
 the fix would be casting to Vec4array in the reading part to get valid
 array object

 Nick


 On Thu, Mar 27, 2014 at 3:35 PM, Bolstad, Mark 
 bolst...@janelia.hhmi.orgwrote:

 While trying to map some functionality to color per vertex, I came across
 a bug in that colors aren't loaded properly.

 At daeReader::resolveMeshArrays:931 (daeRGeometry.cpp) it calls out to
 createGeometryArrays with types of Vec4Array. If you trace this down into
 the daeSourceReader call to getArray, you'll find that it reads the data
 into a Vec3Array, then returns the Vec4Array resulting in no colors.

 Anyone have a quick fix? (I'm currently attempting to change the array to
 Vec3, then convert it to a Vec4 in resolve MeshArrays).

 Attached is a small collada file created in Blender that shows the
 problem.

 Mark

 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




 --
 trajce nikolov nick




-- 
trajce nikolov nick
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org