Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

[aserdean]

> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> În numele Ben Pfaff
> Trimis: Wednesday, January 23, 2019 5:33 PM
> Către: Alin Gabriel Serdean 
> Cc: d...@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet
buffering' on
> Windows
> 
> On Wed, Jan 23, 2019 at 12:41:10PM +0200, Alin Gabriel Serdean wrote:
> > The test fails on Windows because of:
> > <--cut-->
> > ovn-nbctl: sw0: invalid network address: 2001;1\64
> > ovn-nbctl: sw1: invalid network address: 2002;1\64 <--cut-->
> >
> > This is due to the fact msys converts '::1' into ';1'.
> >
> > Use IPv6 long form instead of its short variant.
> >
> > Signed-off-by: Alin Gabriel Serdean 
> 
> Acked-by: Ben Pfaff 
> ___

Thanks applied on master and branch-2.11

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

[Ben Pfaff]

On Wed, Jan 23, 2019 at 12:41:10PM +0200, Alin Gabriel Serdean wrote:
> The test fails on Windows because of:
> <--cut-->
> ovn-nbctl: sw0: invalid network address: 2001;1\64
> ovn-nbctl: sw1: invalid network address: 2002;1\64
> <--cut-->
> 
> This is due to the fact msys converts '::1' into ';1'.
> 
> Use IPv6 long form instead of its short variant.
> 
> Signed-off-by: Alin Gabriel Serdean 

Acked-by: Ben Pfaff 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

[Alin Gabriel Serdean]

> On 23 Jan 2019, at 12:58, Numan Siddique  wrote:
> 
> 
> 
> On Wed, Jan 23, 2019 at 4:14 PM Alin Gabriel Serdean  > wrote:
> The test fails on Windows because of:
> <--cut-->
> ovn-nbctl: sw0: invalid network address: 2001;1\64
> ovn-nbctl: sw1: invalid network address: 2002;1\64
> <--cut-->
> 
> This is due to the fact msys converts '::1' into ';1'.
> 
> Use IPv6 long form instead of its short variant.
> 
> Signed-off-by: Alin Gabriel Serdean  >
> 
> Acked-by: Numan Siddique mailto:nusid...@redhat.com>>
> 
No worries :)
I’m trying to bring up Cirrus CI for Windows which should give some
more visibility.
> We generally tend to use the short form and we don't even realize it
> breaks windows.  Probably checkpatch can check it and flag an error.
> I will give it a try to add this check in checkpatch utility.
That would be a nice addition. Thanks for giving it a try!
> 
> Thanks
> Numan
> 
> 


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

[Numan Siddique]

On Wed, Jan 23, 2019 at 4:14 PM Alin Gabriel Serdean 
wrote:

> The test fails on Windows because of:
> <--cut-->
> ovn-nbctl: sw0: invalid network address: 2001;1\64
> ovn-nbctl: sw1: invalid network address: 2002;1\64
> <--cut-->
>
> This is due to the fact msys converts '::1' into ';1'.
>
> Use IPv6 long form instead of its short variant.
>
> Signed-off-by: Alin Gabriel Serdean 
>

Acked-by: Numan Siddique 

We generally tend to use the short form and we don't even realize it
breaks windows.  Probably checkpatch can check it and flag an error.
I will give it a try to add this check in checkpatch utility.

Thanks
Numan




> ---
>  tests/ovn.at | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 5f387fc07..f54f24c74 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -11858,12 +11858,12 @@ ovn-nbctl create Logical_Router name=lr0
> options:chassis=hv1
>  ovn-nbctl ls-add sw0
>  ovn-nbctl ls-add sw1
>
> -ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24 2001::1/64
> +ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24
> 2001:0:0:0:0:0:0:1/64
>  ovn-nbctl lsp-add sw0 rp-sw0 -- set Logical_Switch_Port rp-sw0 \
>  type=router options:router-port=sw0 \
>  -- lsp-set-addresses rp-sw0 router
>
> -ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24 2002::1/64
> +ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24
> 2002:0:0:0:0:0:0:1/64
>  ovn-nbctl lsp-add sw1 rp-sw1 -- set Logical_Switch_Port rp-sw1 \
>  type=router options:router-port=sw1 \
>  -- lsp-set-addresses rp-sw1 router
> --
> 2.16.1.windows.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

[Alin Gabriel Serdean]

The test fails on Windows because of:
<--cut-->
ovn-nbctl: sw0: invalid network address: 2001;1\64
ovn-nbctl: sw1: invalid network address: 2002;1\64
<--cut-->

This is due to the fact msys converts '::1' into ';1'.

Use IPv6 long form instead of its short variant.

Signed-off-by: Alin Gabriel Serdean 
---
 tests/ovn.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ovn.at b/tests/ovn.at
index 5f387fc07..f54f24c74 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -11858,12 +11858,12 @@ ovn-nbctl create Logical_Router name=lr0 
options:chassis=hv1
 ovn-nbctl ls-add sw0
 ovn-nbctl ls-add sw1
 
-ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24 2001::1/64
+ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24 
2001:0:0:0:0:0:0:1/64
 ovn-nbctl lsp-add sw0 rp-sw0 -- set Logical_Switch_Port rp-sw0 \
 type=router options:router-port=sw0 \
 -- lsp-set-addresses rp-sw0 router
 
-ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24 2002::1/64
+ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24 2002:0:0:0:0:0:0:1/64
 ovn-nbctl lsp-add sw1 rp-sw1 -- set Logical_Switch_Port rp-sw1 \
 type=router options:router-port=sw1 \
 -- lsp-set-addresses rp-sw1 router
-- 
2.16.1.windows.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev