Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
On 8/3/22 16:58, Mike Pattrick wrote:
> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
>>
>> $NC_EOF_OPT should be used to avoid some netcat implementations
>> to wait indefinitely.
>>
>> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
>>
>> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
>> Signed-off-by: Ilya Maximets
>
> Acked-by: Mike Pattrick
Thanks! Applied this one to master and branch-3.0.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
On 8/3/22 17:19, Mike Pattrick wrote:
> On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets wrote:
>>
>> On 8/3/22 16:58, Mike Pattrick wrote:
>>> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
$NC_EOF_OPT should be used to avoid some netcat implementations
to wait indefinitely.
This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
Signed-off-by: Ilya Maximets
>>>
>>> Should we also add these flags to the other system tests?
>>
>> I thought all other client-side nc calls already have them.
>> Did I miss some?
>
> tests/system-traffic.at:5263:NS_CHECK_EXEC([at_ns0], [echo "TEST" | nc
> -p 3 10.1.1.2 80 > nc-1.log])
> tests/system-traffic.at:5269:NS_CHECK_EXEC([at_ns0], [echo "TEST2" |
> nc -p 30001 172.1.1.2 80 > nc-2.log])
> tests/system-traffic.at:5270:NS_CHECK_EXEC([at_ns0], [echo "TEST3" |
> nc -p 30001 10.1.1.2 80 > nc-3.log])
> tests/system-traffic.at:6659:NS_CHECK_EXEC([at_ns1], [echo "TEST1"
> | nc -p 4100$i 10.1.1.64 80 > nc-1-$i.log])
> tests/system-traffic.at:6660:NS_CHECK_EXEC([at_ns5], [echo "TEST5"
> | nc -p 4100$i 10.1.1.64 80 > nc-5-$i.log])
Hmm. OK. We should probably fix those too in a separate patch.
>
>>
>>>
>>> Acked-by: Mike Pattrick
>>>
---
tests/system-offloads-traffic.at | 8
1 file changed, 4 insertions(+), 4 deletions(-)
>>
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets wrote:
>
> On 8/3/22 16:58, Mike Pattrick wrote:
> > On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
> >>
> >> $NC_EOF_OPT should be used to avoid some netcat implementations
> >> to wait indefinitely.
> >>
> >> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
> >>
> >> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
> >> Signed-off-by: Ilya Maximets
> >
> > Should we also add these flags to the other system tests?
>
> I thought all other client-side nc calls already have them.
> Did I miss some?
tests/system-traffic.at:5263:NS_CHECK_EXEC([at_ns0], [echo "TEST" | nc
-p 3 10.1.1.2 80 > nc-1.log])
tests/system-traffic.at:5269:NS_CHECK_EXEC([at_ns0], [echo "TEST2" |
nc -p 30001 172.1.1.2 80 > nc-2.log])
tests/system-traffic.at:5270:NS_CHECK_EXEC([at_ns0], [echo "TEST3" |
nc -p 30001 10.1.1.2 80 > nc-3.log])
tests/system-traffic.at:6659:NS_CHECK_EXEC([at_ns1], [echo "TEST1"
| nc -p 4100$i 10.1.1.64 80 > nc-1-$i.log])
tests/system-traffic.at:6660:NS_CHECK_EXEC([at_ns5], [echo "TEST5"
| nc -p 4100$i 10.1.1.64 80 > nc-5-$i.log])
>
> >
> > Acked-by: Mike Pattrick
> >
> >> ---
> >> tests/system-offloads-traffic.at | 8
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
On 8/3/22 16:58, Mike Pattrick wrote:
> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
>>
>> $NC_EOF_OPT should be used to avoid some netcat implementations
>> to wait indefinitely.
>>
>> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
>>
>> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
>> Signed-off-by: Ilya Maximets
>
> Should we also add these flags to the other system tests?
I thought all other client-side nc calls already have them.
Did I miss some?
>
> Acked-by: Mike Pattrick
>
>> ---
>> tests/system-offloads-traffic.at | 8
>> 1 file changed, 4 insertions(+), 4 deletions(-)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
>
> $NC_EOF_OPT should be used to avoid some netcat implementations
> to wait indefinitely.
>
> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
>
> Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
> Signed-off-by: Ilya Maximets
Should we also add these flags to the other system tests?
Acked-by: Mike Pattrick
> ---
> tests/system-offloads-traffic.at | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/system-offloads-traffic.at
> b/tests/system-offloads-traffic.at
> index 834d444f0..1e1012965 100644
> --- a/tests/system-offloads-traffic.at
> +++ b/tests/system-offloads-traffic.at
> @@ -203,7 +203,7 @@ AT_CHECK([ovs-ofctl -O OpenFlow13 del-flows br0])
> AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0
> "priority=10,in_port=ovs-p0,udp actions=meter:1,normal"])
> AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=1 actions=normal"])
>
> -NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
> +NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
> 6789])
> AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
> [0], [dnl
> in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
> bytes:0, used:0.001s, actions:meter(0),3
> ])
> @@ -211,7 +211,7 @@
> in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
> bytes:0
> sleep 1
>
> for i in `seq 10`; do
> -NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
> +NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
> 6789])
> done
>
> AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
> [0], [dnl
> @@ -252,7 +252,7 @@ AT_CHECK([ovs-ofctl -O OpenFlow13 del-flows br0])
> AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0
> "priority=10,in_port=ovs-p0,udp actions=meter:1,normal"])
> AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=1 actions=normal"])
>
> -NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
> +NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
> 6789])
> AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
> [0], [dnl
> in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
> bytes:0, used:0.001s, actions:meter(0),3
> ])
> @@ -260,7 +260,7 @@
> in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
> bytes:0
> sleep 1
>
> for i in `seq 10`; do
> -NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
> +NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
> 6789])
> done
>
> AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
> [0], [dnl
> --
> 2.34.3
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.
$NC_EOF_OPT should be used to avoid some netcat implementations
to wait indefinitely.
This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action")
Signed-off-by: Ilya Maximets
---
tests/system-offloads-traffic.at | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index 834d444f0..1e1012965 100644
--- a/tests/system-offloads-traffic.at
+++ b/tests/system-offloads-traffic.at
@@ -203,7 +203,7 @@ AT_CHECK([ovs-ofctl -O OpenFlow13 del-flows br0])
AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=10,in_port=ovs-p0,udp
actions=meter:1,normal"])
AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=1 actions=normal"])
-NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
+NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
6789])
AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
[0], [dnl
in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
bytes:0, used:0.001s, actions:meter(0),3
])
@@ -211,7 +211,7 @@
in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0, bytes:0
sleep 1
for i in `seq 10`; do
-NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
+NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
6789])
done
AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
[0], [dnl
@@ -252,7 +252,7 @@ AT_CHECK([ovs-ofctl -O OpenFlow13 del-flows br0])
AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=10,in_port=ovs-p0,udp
actions=meter:1,normal"])
AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 "priority=1 actions=normal"])
-NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
+NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
6789])
AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
[0], [dnl
in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0,
bytes:0, used:0.001s, actions:meter(0),3
])
@@ -260,7 +260,7 @@
in_port(2),eth(macs),eth_type(0x0800),ipv4(proto=17,frag=no), packets:0, bytes:0
sleep 1
for i in `seq 10`; do
-NS_CHECK_EXEC([at_ns0], [echo "mark" | nc -u 10.1.1.2 5678 -p 6789])
+NS_CHECK_EXEC([at_ns0], [echo "mark" | nc $NC_EOF_OPT -u 10.1.1.2 5678 -p
6789])
done
AT_CHECK([ovs-appctl dpctl/dump-flows | grep "meter" | DUMP_CLEAN_SORTED],
[0], [dnl
--
2.34.3
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
