Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.
On 8/8/22 22:36, Numan Siddique wrote: On Tue, Aug 9, 2022 at 4:22 AM Mark Michelson wrote: On 8/4/22 15:55, Numan Siddique wrote: On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote: This is a backport of Han Zhou's patch series "Avoid unnecessary deletion & recreation during restart" for branch-21.12. The original series can be found at https://patchwork.ozlabs.org/project/ovn/list/?series=311230 . Apologies if I did not handle the sign-offs on the commits correctly. I'm not sure what the protocol is when backporting a patch series authored by someone else. Since it's a backport I suppose you can also add the Acked-by tags from the main commit while applying. Also please add the original commits in the commit message. Normally I'd do - git cherry-pick -x and it would add the below line in the commit message (cherry picked from commit x) Please note that you also need to backport this commit https://github.com/ovn-org/ovn/commit/db15cf29a1f9857b55389f424c5d747406550cb7 to fix a regression caused by this patch series. With the commit db15cf29 also backported - For the entire series Acked-by: Numan Siddique Thanks Numan Thank you Numan. I added the previous Acked-by tags, added your ack, added the "cherry picked from" lines, and added the final commit to the series. I pushed the change to branch-21.12. I'll work on a branch-22.03 version next. Looks like you've not pushed the changes to branch-21.12 yet - https://github.com/ovn-org/ovn/commits/branch-21.12 Numan Whoops, looks like my push script failed silently and I didn't notice. It should be pushed now. Han Zhou (4): ofctrl: Wakeup when entering S_UPDATE_FLOWS. ofctrl: Support ovn-ofctrl-wait-before-clear to reduce down time during upgrade. ofctrl.c: Include group changes to bundle. ofctrl.c: Use bundle to avoid data plane downtime during the first flow installation. controller/ofctrl.c | 275 +--- controller/ofctrl.h | 4 +- controller/ovn-controller.8.xml | 34 controller/ovn-controller.c | 6 +- tests/ovn-controller.at | 55 ++- 5 files changed, 277 insertions(+), 97 deletions(-) -- 2.37.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.
On Tue, Aug 9, 2022 at 4:22 AM Mark Michelson wrote: > > On 8/4/22 15:55, Numan Siddique wrote: > > On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote: > >> > >> This is a backport of Han Zhou's patch series "Avoid unnecessary > >> deletion & recreation during restart" for branch-21.12. The original > >> series can be found at > >> https://patchwork.ozlabs.org/project/ovn/list/?series=311230 . > >> > >> Apologies if I did not handle the sign-offs on the commits correctly. > >> I'm not sure what the protocol is when backporting a patch series > >> authored by someone else. > > > > Since it's a backport I suppose you can also add the Acked-by tags > > from the main commit while applying. > > > > Also please add the original commits in the commit message. > > > > Normally I'd do - git cherry-pick -x and it > > would add the below line in the commit message > > > > (cherry picked from commit x) > > > > Please note that you also need to backport this commit > > https://github.com/ovn-org/ovn/commit/db15cf29a1f9857b55389f424c5d747406550cb7 > > to fix a regression caused by this patch series. > > > > With the commit db15cf29 also backported - > > For the entire series Acked-by: Numan Siddique > > > > Thanks > > Numan > > Thank you Numan. I added the previous Acked-by tags, added your ack, > added the "cherry picked from" lines, and added the final commit to the > series. > > I pushed the change to branch-21.12. I'll work on a branch-22.03 version > next. > Looks like you've not pushed the changes to branch-21.12 yet - https://github.com/ovn-org/ovn/commits/branch-21.12 Numan > > > > > >> > >> Han Zhou (4): > >>ofctrl: Wakeup when entering S_UPDATE_FLOWS. > >>ofctrl: Support ovn-ofctrl-wait-before-clear to reduce down time > >> during upgrade. > >>ofctrl.c: Include group changes to bundle. > >>ofctrl.c: Use bundle to avoid data plane downtime during the first > >> flow installation. > >> > >> controller/ofctrl.c | 275 +--- > >> controller/ofctrl.h | 4 +- > >> controller/ovn-controller.8.xml | 34 > >> controller/ovn-controller.c | 6 +- > >> tests/ovn-controller.at | 55 ++- > >> 5 files changed, 277 insertions(+), 97 deletions(-) > >> > >> -- > >> 2.37.1 > >> > >> ___ > >> dev mailing list > >> d...@openvswitch.org > >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >> > > > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.
On 8/4/22 15:55, Numan Siddique wrote: On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote: This is a backport of Han Zhou's patch series "Avoid unnecessary deletion & recreation during restart" for branch-21.12. The original series can be found at https://patchwork.ozlabs.org/project/ovn/list/?series=311230 . Apologies if I did not handle the sign-offs on the commits correctly. I'm not sure what the protocol is when backporting a patch series authored by someone else. Since it's a backport I suppose you can also add the Acked-by tags from the main commit while applying. Also please add the original commits in the commit message. Normally I'd do - git cherry-pick -x and it would add the below line in the commit message (cherry picked from commit x) Please note that you also need to backport this commit https://github.com/ovn-org/ovn/commit/db15cf29a1f9857b55389f424c5d747406550cb7 to fix a regression caused by this patch series. With the commit db15cf29 also backported - For the entire series Acked-by: Numan Siddique Thanks Numan Thank you Numan. I added the previous Acked-by tags, added your ack, added the "cherry picked from" lines, and added the final commit to the series. I pushed the change to branch-21.12. I'll work on a branch-22.03 version next. Han Zhou (4): ofctrl: Wakeup when entering S_UPDATE_FLOWS. ofctrl: Support ovn-ofctrl-wait-before-clear to reduce down time during upgrade. ofctrl.c: Include group changes to bundle. ofctrl.c: Use bundle to avoid data plane downtime during the first flow installation. controller/ofctrl.c | 275 +--- controller/ofctrl.h | 4 +- controller/ovn-controller.8.xml | 34 controller/ovn-controller.c | 6 +- tests/ovn-controller.at | 55 ++- 5 files changed, 277 insertions(+), 97 deletions(-) -- 2.37.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.
On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote: > > This is a backport of Han Zhou's patch series "Avoid unnecessary > deletion & recreation during restart" for branch-21.12. The original > series can be found at > https://patchwork.ozlabs.org/project/ovn/list/?series=311230 . > > Apologies if I did not handle the sign-offs on the commits correctly. > I'm not sure what the protocol is when backporting a patch series > authored by someone else. Since it's a backport I suppose you can also add the Acked-by tags from the main commit while applying. Also please add the original commits in the commit message. Normally I'd do - git cherry-pick -x and it would add the below line in the commit message (cherry picked from commit x) Please note that you also need to backport this commit https://github.com/ovn-org/ovn/commit/db15cf29a1f9857b55389f424c5d747406550cb7 to fix a regression caused by this patch series. With the commit db15cf29 also backported - For the entire series Acked-by: Numan Siddique Thanks Numan > > Han Zhou (4): > ofctrl: Wakeup when entering S_UPDATE_FLOWS. > ofctrl: Support ovn-ofctrl-wait-before-clear to reduce down time > during upgrade. > ofctrl.c: Include group changes to bundle. > ofctrl.c: Use bundle to avoid data plane downtime during the first > flow installation. > > controller/ofctrl.c | 275 +--- > controller/ofctrl.h | 4 +- > controller/ovn-controller.8.xml | 34 > controller/ovn-controller.c | 6 +- > tests/ovn-controller.at | 55 ++- > 5 files changed, 277 insertions(+), 97 deletions(-) > > -- > 2.37.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn branch-21.12 0/4] Avoid unnecessary deletion & recreation during restart.
This is a backport of Han Zhou's patch series "Avoid unnecessary deletion & recreation during restart" for branch-21.12. The original series can be found at https://patchwork.ozlabs.org/project/ovn/list/?series=311230 . Apologies if I did not handle the sign-offs on the commits correctly. I'm not sure what the protocol is when backporting a patch series authored by someone else. Han Zhou (4): ofctrl: Wakeup when entering S_UPDATE_FLOWS. ofctrl: Support ovn-ofctrl-wait-before-clear to reduce down time during upgrade. ofctrl.c: Include group changes to bundle. ofctrl.c: Use bundle to avoid data plane downtime during the first flow installation. controller/ofctrl.c | 275 +--- controller/ofctrl.h | 4 +- controller/ovn-controller.8.xml | 34 controller/ovn-controller.c | 6 +- tests/ovn-controller.at | 55 ++- 5 files changed, 277 insertions(+), 97 deletions(-) -- 2.37.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
