[GitHub] [hadoop-ozone] maobaolong commented on pull request #1231: HDDS-3994. Make retry policy can be set by configuration.
maobaolong commented on pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231#issuecomment-667481634 @lokeshj1703 Thanks for your review. I put the config into ratisclientconfig, and changed the names of limtedretrypolicy ralated configs, it make the old config key cannot works from then on, so are you sure we should modify the key name of limitedretrypolicy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1231: HDDS-3994. Make retry policy can be set by configuration.
maobaolong commented on a change in pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231#discussion_r463928974 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java ## @@ -112,6 +112,18 @@ public static final String DFS_CONTAINER_RATIS_LEADER_PENDING_BYTES_LIMIT_DEFAULT = "1GB"; + public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_POLICY = + "dfs.ratis.client.request.retry.policy"; + + public static final String DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_KEY = + "dfs.ratis.client.request.max.retries"; + public static final int DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_DEFAULT = 180; + public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_KEY = + "dfs.ratis.client.request.retry.interval"; + public static final TimeDuration + DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_DEFAULT = + TimeDuration.valueOf(1000, TimeUnit.MILLISECONDS); + Review comment: Yeah，Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1270: HDDS-4044. Deprecate ozone.s3g.volume.name.
elek commented on pull request #1270:
URL: https://github.com/apache/hadoop-ozone/pull/1270#issuecomment-667478035
> As the bucket link feature is available now.
As I wrote in my previous comment, bucket link is not a replacement of this
configuration. This configuration can expose an other volume and **all**
buckets.
With bucket links you should updated your links in case of the creation of
any new bucket.
> Get it. So not really deprecating it as the title says? @bharatviswa504
It is deprecating but not removing:
```
if (!volumeName.equals(OZONE_S3_VOLUME_NAME_DEFAULT)) {
LOG.warn(OZONE_S3_VOLUME_NAME + " is deprecated. Consider using bucket
" +
"link command to access volume/buckets created via ozone shell " +
"through S3Gateway and also to access buckets created by S3Gateway
" +
"version less than or equal to 0.5.0");
}
```
Which means that a warning will be printed out without alternatives (linking
new bucket every day is not the same). As this feature is used by our early
adopters (who started to use s3g with the old scheme) I think it's important to
keep this functionality as is, without warning.
As I wrote, I can accept the consensus proposal from @arp7: Let's remove it
from the s3g doc page but keep the same code. (Later we can create a separated
page about powerful but risky configuration, and it can be added back to
there...)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4021) Organize Recon DBs into a 'DBDefinition'.
[ https://issues.apache.org/jira/browse/HDDS-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4021: -- Fix Version/s: 0.7.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Organize Recon DBs into a 'DBDefinition'. > - > > Key: HDDS-4021 > URL: https://issues.apache.org/jira/browse/HDDS-4021 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Recon >Affects Versions: 0.5.0 >Reporter: Vivek Ratnavel Subramanian >Assignee: Aravindan Vijayan >Priority: Major > Labels: pull-request-available > Fix For: 0.7.0 > > > * ReconNodeManager uses node db in an old format which is not part of > ReconDBDefinition. Move the definition to ReconDBDefinition. > * Create DB Definition for Recon Container DB. > * Modify DBScanner tool to allow it to read Recon DBs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1255: HDDS-4021. Organize Recon DBs into a 'DBDefinition'.
elek merged pull request #1255: URL: https://github.com/apache/hadoop-ozone/pull/1255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1231: HDDS-3994. Make retry policy can be set by configuration.
maobaolong closed pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-2949) mkdir : store directory entries in a separate table
[ https://issues.apache.org/jira/browse/HDDS-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDDS-2949: Status: Patch Available (was: Open) > mkdir : store directory entries in a separate table > --- > > Key: HDDS-2949 > URL: https://issues.apache.org/jira/browse/HDDS-2949 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Supratim Deka >Assignee: Rakesh Radhakrishnan >Priority: Major > Labels: backward-incompatible, pull-request-available > > As of HDDS-2940, all the directories from the path prefix get created as > entries in the key table. as per the namespace proposal attached to > HDDS-2939, directory entries need to be stored in a separate "directory" > table. Files will continue to be stored in the key table, which can be > thought of as the "file" table. > The advantage of a separate directory table is to make directory lookup more > efficient - the entire table would fit into memory for a typical file based > dataset. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-3976) KeyValueBlockIterator#nextBlock skips valid blocks
[ https://issues.apache.org/jira/browse/HDDS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDDS-3976: Status: Patch Available (was: Open) > KeyValueBlockIterator#nextBlock skips valid blocks > -- > > Key: HDDS-3976 > URL: https://issues.apache.org/jira/browse/HDDS-3976 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Ethan Rose >Assignee: Ethan Rose >Priority: Major > Labels: pull-request-available > > HDDS-3854 fixed a bug in KeyValueBlockIterator#hasNext, but introduced > another one in KeyValueBlockIterator#nextBlock, which depends on the behavior > of that method. When the first key encountered does not pass the filter, the > internal nextBlock field is never intialized. Then a call to nextBlock() > results in call to hasNext() which returns true, which recursively calls > nextBlock(), again calling hasNext(), etc until the end of the set is reached > and an exception is thrown. This skips all valid keys that may occur past the > first invalid key. > Additionally, the current implementation of KeyValueBlockIterator#seekLast > depends on the internal RocksDB iterators seekLast() method, which will skip > to the last key in the DB regardless of whether it matches the filter or not. > This could be different from last key according to the filter. > This bug was identified while working on HDDS-3869, which adds a strong > typing layer before objects are serialized into RocksDB for datanode. Due to > RocksDB internals, this changes the database layout so that all prefixed keys > are returned at the beginning of the key set, instead of in the end. Since > the original layout returned all prefixed keys at the end of the key set, > this bug was not evident in any of the original unit tests, since the > behavior described above could not occur. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4052) Remove master/slave terminology from Ozone
[ https://issues.apache.org/jira/browse/HDDS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated HDDS-4052: - Resolution: Fixed Status: Resolved (was: Patch Available) > Remove master/slave terminology from Ozone > -- > > Key: HDDS-4052 > URL: https://issues.apache.org/jira/browse/HDDS-4052 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Eric Badger >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1281: HDDS-4052. Remove master/slave terminology from Ozone
vivekratnavel commented on pull request #1281: URL: https://github.com/apache/hadoop-ozone/pull/1281#issuecomment-667301949 @adoroszlai Thanks for working on this! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1281: HDDS-4052. Remove master/slave terminology from Ozone
vivekratnavel merged pull request #1281: URL: https://github.com/apache/hadoop-ozone/pull/1281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1282: HDDS-4055. Cleanup GitHub workflow
vivekratnavel commented on pull request #1282: URL: https://github.com/apache/hadoop-ozone/pull/1282#issuecomment-667300818 @adoroszlai Thanks for working on this! I am not merging this yet since you assigned it to yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4055) Cleanup GitHub workflow
[
https://issues.apache.org/jira/browse/HDDS-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4055:
---
Status: Patch Available (was: In Progress)
> Cleanup GitHub workflow
> ---
>
> Key: HDDS-4055
> URL: https://issues.apache.org/jira/browse/HDDS-4055
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Major
> Labels: pull-request-available
>
> Cleanup GitHub workflow definition:
> # Provide name for all steps
> # Apply HDDS-4038 to new {{bats}} and {{kubernetes}} checks
> # Apply HDDS-3877 to new {{bats}} check
> # Fix mixed use of 2, 3, 4 spaces indentation
> # Remove unnecessary job names (where job name and ID are the same)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4052) Remove master/slave terminology from Ozone
[ https://issues.apache.org/jira/browse/HDDS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-4052: --- Status: Patch Available (was: In Progress) > Remove master/slave terminology from Ozone > -- > > Key: HDDS-4052 > URL: https://issues.apache.org/jira/browse/HDDS-4052 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Eric Badger >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4055) Cleanup GitHub workflow
[
https://issues.apache.org/jira/browse/HDDS-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4055:
-
Labels: pull-request-available (was: )
> Cleanup GitHub workflow
> ---
>
> Key: HDDS-4055
> URL: https://issues.apache.org/jira/browse/HDDS-4055
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Major
> Labels: pull-request-available
>
> Cleanup GitHub workflow definition:
> # Provide name for all steps
> # Apply HDDS-4038 to new {{bats}} and {{kubernetes}} checks
> # Apply HDDS-3877 to new {{bats}} check
> # Fix mixed use of 2, 3, 4 spaces indentation
> # Remove unnecessary job names (where job name and ID are the same)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1282: HDDS-4055. Cleanup GitHub workflow
adoroszlai opened a new pull request #1282: URL: https://github.com/apache/hadoop-ozone/pull/1282 ## What changes were proposed in this pull request? Cleanup GitHub workflow definition: * Provide name for all steps * Apply HDDS-4038 to new `bats` and `kubernetes` checks * Apply HDDS-3877 to new `bats` check * Fix mixed use of 2, 3, 4 spaces indentation * Remove unnecessary job names (where job name and ID are the same) https://issues.apache.org/jira/browse/HDDS-4055 ## How was this patch tested? https://github.com/adoroszlai/hadoop-ozone/actions/runs/190005120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Created] (HDDS-4056) Refactor WithScmClient to mixin
Attila Doroszlai created HDDS-4056:
--
Summary: Refactor WithScmClient to mixin
Key: HDDS-4056
URL: https://issues.apache.org/jira/browse/HDDS-4056
Project: Hadoop Distributed Data Store
Issue Type: Improvement
Components: Ozone CLI
Reporter: Attila Doroszlai
Assignee: Attila Doroszlai
Ozone Shell's {{OzoneAdmin}} implements {{WithScmClient}} interface to be able
to provide SCM client to sub-commands. We can convert it to a {{Mixin}}, which
would allow converting {{OzoneAdmin}} to the pluggable model in HDDS-4046.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on pull request #1281: HDDS-4052. Remove master/slave terminology from Ozone
cxorm commented on pull request #1281: URL: https://github.com/apache/hadoop-ozone/pull/1281#issuecomment-667110465 Thank you for the contribution. Agree the changes IMHO, +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Created] (HDDS-4055) Cleanup GitHub workflow
Attila Doroszlai created HDDS-4055:
--
Summary: Cleanup GitHub workflow
Key: HDDS-4055
URL: https://issues.apache.org/jira/browse/HDDS-4055
Project: Hadoop Distributed Data Store
Issue Type: Improvement
Components: build
Reporter: Attila Doroszlai
Assignee: Attila Doroszlai
Cleanup GitHub workflow definition:
# Provide name for all steps
# Apply HDDS-4038 to new {{bats}} and {{kubernetes}} checks
# Apply HDDS-3877 to new {{bats}} check
# Fix mixed use of 2, 3, 4 spaces indentation
# Remove unnecessary job names (where job name and ID are the same)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4052) Remove master/slave terminology from Ozone
[ https://issues.apache.org/jira/browse/HDDS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4052: - Labels: pull-request-available (was: ) > Remove master/slave terminology from Ozone > -- > > Key: HDDS-4052 > URL: https://issues.apache.org/jira/browse/HDDS-4052 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Eric Badger >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1281: HDDS-4052. Remove master/slave terminology from Ozone
adoroszlai opened a new pull request #1281:
URL: https://github.com/apache/hadoop-ozone/pull/1281
## What changes were proposed in this pull request?
Replace "slave" with "worker", which is already established terminology, but
there were a few leftover occurrences.
https://issues.apache.org/jira/browse/HDDS-4052
## How was this patch tested?
The only remaining occurrences are deprecation warnings:
```
$ rg --ignore-case --no-ignore slave
hadoop-ozone/dist/src/shell/hdds/hadoop-config.sh
122:hadoop_deprecate_envvar HADOOP_SLAVES HADOOP_WORKERS
123:hadoop_deprecate_envvar HADOOP_SLAVE_NAMES HADOOP_WORKER_NAMES
124:hadoop_deprecate_envvar HADOOP_SLAVE_SLEEP HADOOP_WORKER_SLEEP
hadoop-ozone/dist/src/shell/hdds/hadoop-functions.sh
1016:elif [[ -f "${HADOOP_CONF_DIR}/slaves" ]]; then
1017: hadoop_error "WARNING: 'slaves' file has been deprecated. Please
use 'workers' file instead."
1018: worker_file=${HADOOP_CONF_DIR}/slaves
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #1231: HDDS-3994. Make retry policy can be set by configuration.
lokeshj1703 commented on a change in pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231#discussion_r463539752 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java ## @@ -112,6 +112,18 @@ public static final String DFS_CONTAINER_RATIS_LEADER_PENDING_BYTES_LIMIT_DEFAULT = "1GB"; + public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_POLICY = + "dfs.ratis.client.request.retry.policy"; + + public static final String DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_KEY = + "dfs.ratis.client.request.max.retries"; + public static final int DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_DEFAULT = 180; + public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_KEY = + "dfs.ratis.client.request.retry.interval"; + public static final TimeDuration + DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_DEFAULT = + TimeDuration.valueOf(1000, TimeUnit.MILLISECONDS); + Review comment: Can we add these configs to RatisClientConfig class? I would also suggest renaming some of the configs to match the existing configs like hdds.ratis.client.retrylimited.retry.interval or sth similar. This would make it easier to distinguish between the configs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] captainzmc commented on pull request #1280: HDDS-4054. Remove duplicate judgments in allocateBlockInKey.
captainzmc commented on pull request #1280: URL: https://github.com/apache/hadoop-ozone/pull/1280#issuecomment-667041335 Hi @bharatviswa504 @arp7 Could you help to review this？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] captainzmc closed pull request #1280: HDDS-4054. Remove duplicate judgments in allocateBlockInKey.
captainzmc closed pull request #1280: URL: https://github.com/apache/hadoop-ozone/pull/1280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Assigned] (HDDS-4052) Remove master/slave terminology from Ozone
[ https://issues.apache.org/jira/browse/HDDS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-4052: -- Assignee: Attila Doroszlai > Remove master/slave terminology from Ozone > -- > > Key: HDDS-4052 > URL: https://issues.apache.org/jira/browse/HDDS-4052 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Eric Badger >Assignee: Attila Doroszlai >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Assigned] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai reassigned HDDS-4054:
--
Assignee: mingchao zhao
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
>Reporter: mingchao zhao
>Assignee: mingchao zhao
>Priority: Major
> Labels: pull-request-available
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439].
> So this size must be >0.
> {code:java}
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480].
> The key must be greater than 0, so the "if (size > 0){}" in
> allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4054:
-
Labels: pull-request-available (was: )
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
>Reporter: mingchao zhao
>Priority: Major
> Labels: pull-request-available
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439].
> So this size must be >0.
> {code:java}
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480].
> The key must be greater than 0, so the "if (size > 0){}" in
> allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] captainzmc opened a new pull request #1280: HDDS-4054. Remove duplicate judgments in allocateBlockInKey.
captainzmc opened a new pull request #1280:
URL: https://github.com/apache/hadoop-ozone/pull/1280
## What changes were proposed in this pull request?
In HDDS-1666 we have [changed the value of the key
size](https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439).
So this size must be >0.
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
We [pass this size when we call
allocateBlockInKey](https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480).
The key must be greater than 0, so the "if (size > 0){}" in allocateBlockInKey
is redundant and should be removed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4054
## How was this patch tested?
use existing UT
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] aryangupta1998 commented on a change in pull request #1264: HDDS-4035. Update logs of HadoopDirGenerator.
aryangupta1998 commented on a change in pull request #1264:
URL: https://github.com/apache/hadoop-ozone/pull/1264#discussion_r463480659
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -301,6 +301,18 @@ public void printReport() {
messages.forEach(print);
}
+ /**
+ * Print out reports with the given message.
+ */
+ public void print(String msg){
+List messages = new LinkedList<>();
+messages.add(msg);
Review comment:
Thanks @xiaoyuyao. Fixed the print function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingchao zhao updated HDDS-4054:
Issue Type: Improvement (was: Bug)
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
>Reporter: mingchao zhao
>Priority: Major
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439].
> So this size must be >0.
> {code:java}
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480].
> The key must be greater than 0, so the "if (size > 0){}" in
> allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingchao zhao updated HDDS-4054:
Description:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439].
So this size must be >0.
{code:java}
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We [pass this size when we call
allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480].
The key must be greater than 0, so the "if (size > 0){}" in allocateBlockInKey
is redundant and should be removed.
was:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We [pass this size when we call
allocateBlockInKey|#diff-2d061b57a9838854d07da9e0eca64f31R480]]. The key must
be greater than 0, so the "if (size > 0){}" in allocateBlockInKey is redundant
and should be removed.
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: mingchao zhao
>Priority: Major
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R439].
> So this size must be >0.
> {code:java}
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480].
> The key must be greater than 0, so the "if (size > 0){}" in
> allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingchao zhao updated HDDS-4054:
Description:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We [pass this size when we call
allocateBlockInKey|#diff-2d061b57a9838854d07da9e0eca64f31R480]]. The key must
be greater than 0, so the "if (size > 0){}" in allocateBlockInKey is redundant
and should be removed.
was:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
//代码占位符
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We [pass this size when we call
allocateBlockInKey|[https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480]].
The key must be greater than 0, so the "if (size > 0){}" in allocateBlockInKey
is redundant and should be removed.
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: mingchao zhao
>Priority: Major
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
> So this size must be >0.
> {code:java}
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|#diff-2d061b57a9838854d07da9e0eca64f31R480]]. The key must
> be greater than 0, so the "if (size > 0){}" in allocateBlockInKey is
> redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
[
https://issues.apache.org/jira/browse/HDDS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingchao zhao updated HDDS-4054:
Description:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
//代码占位符
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We [pass this size when we call
allocateBlockInKey|[https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480]].
The key must be greater than 0, so the "if (size > 0){}" in allocateBlockInKey
is redundant and should be removed.
was:
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
//代码占位符
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We pass this size when you call allocateBlockInKey. The key must be greater
than 0, so the "if (size > 0){}" in allocateBlockInKey is redundant and should
be removed.
> Remove duplicate judgments in allocateBlockInKey
>
>
> Key: HDDS-4054
> URL: https://issues.apache.org/jira/browse/HDDS-4054
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: mingchao zhao
>Priority: Major
>
> In HDDS-1666 we have [changed the size of the key
> size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
> So this size must be >0.
> {code:java}
> //代码占位符
> final long size = args.getDataSize() > 0 ?
> args.getDataSize() : scmBlockSize;
> {code}
> We [pass this size when we call
> allocateBlockInKey|[https://github.com/apache/hadoop/pull/943/files#diff-2d061b57a9838854d07da9e0eca64f31R480]].
> The key must be greater than 0, so the "if (size > 0){}" in
> allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[jira] [Created] (HDDS-4054) Remove duplicate judgments in allocateBlockInKey
mingchao zhao created HDDS-4054:
---
Summary: Remove duplicate judgments in allocateBlockInKey
Key: HDDS-4054
URL: https://issues.apache.org/jira/browse/HDDS-4054
Project: Hadoop Distributed Data Store
Issue Type: Bug
Reporter: mingchao zhao
In HDDS-1666 we have [changed the size of the key
size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438].
So this size must be >0.
{code:java}
//代码占位符
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We pass this size when you call allocateBlockInKey. The key must be greater
than 0, so the "if (size > 0){}" in allocateBlockInKey is redundant and should
be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant edited a comment on pull request #1154: HDDS-3867. Extend the chunkinfo tool to display information from all nodes in the pipeline.
bshashikant edited a comment on pull request #1154: URL: https://github.com/apache/hadoop-ozone/pull/1154#issuecomment-666245556 > Thanks to create this patch @sadanand48 > > I have one design concern related to this change. I am not sure what is the good answer, but trying to share my view: > > This patch modifies the `client` interface to provide more functionality for a `debug` tool. I like this more functionality, but I think we shouldn't add any debug specific feature to the main client API. Client API should be backward compatible between releases and it might have multiple implementations. > > I would prefer to separate the `client` api from the `admin` api (used by this tool). > > As an example: Let's say I would like to implement a new client for Erasure Coding. If the client interface contains debug specific methods I need to implement all of them, which makes introduce any new feature harder. > > I am not sure how is it possible to keep this separation (I need your feedback). One possible solution is ot move the logic of looping over the datanodes to the `ChunkKeyHandler`. But it's not clear how can it work with RATIS pipeline. Or do you use STANDALONE client to read the data which is persisted with RATIS? I think we should remove XceiverClient interface altogether. Read and write path client functionality seem to diverge a lot . Adding a new functionality in XceiverClientGrpc will just be fine then. There is alredy a jira filed for the same https://issues.apache.org/jira/browse/HDDS-998. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1269: HDDS-4042. Update documentation for the GA release
adoroszlai commented on a change in pull request #1269:
URL: https://github.com/apache/hadoop-ozone/pull/1269#discussion_r463447507
##
File path: hadoop-hdds/docs/content/interface/Cli.md
##
@@ -0,0 +1,209 @@
+---
+title: Command Line Interface
+weight: 4
+menu:
+ main:
+ parent: "Client Interfaces"
+---
+
+
+
+ Ozone shell is the primary interface to interact with Ozone. It provides a
command shell interface to work against Ozone. It uses the [Java API]({{< ref
"interface/JavaApi.md">}}).
+
+ There are some functionality which couldn't be accessed without using `ozone
sh` commands. For example:
+
+ 1. Creating volumes with quota
+ 2. Managing internal ACLs
+ 3. Creating buckets with encryption key
+
+All of these are one-time, administration tasks. Applications can use Ozone
without this CLI using other interface like Hadoop Compatible File System (o3fs
or ofs) or S3 interface.
+
+
+Ozone shell help can be invoked at _object_ level or at _action_ level.
+
+For example:
+
+```bash
+ozone sh volume --help
+```
+
+This will show all possible actions for volumes.
+
+or it can be invoked to explain a specific action like
+
+```bash
+ozone sh volume create --help
+```
+
+This command will give you command line options of the create command.
+
+## General Command Format
+
+The Ozone shell commands take the following format.
+
+> _ozone sh object action url_
+
+**ozone** script is used to invoke all Ozone sub-commands. The ozone shell is
+invoked via ```sh``` command.
+
+The object can be a volume, bucket or a key. The action is various verbs like
Review comment:
```suggestion
Object can be volume, bucket or key. Actions are various verbs like
```
##
File path: hadoop-hdds/docs/content/interface/Cli.md
##
@@ -0,0 +1,209 @@
+---
+title: Command Line Interface
+weight: 4
+menu:
+ main:
+ parent: "Client Interfaces"
+---
+
+
+
+ Ozone shell is the primary interface to interact with Ozone. It provides a
command shell interface to work against Ozone. It uses the [Java API]({{< ref
"interface/JavaApi.md">}}).
Review comment:
```suggestion
Ozone shell is the primary interface to interact with Ozone from the command
line. Behind the scenes it uses the [Java API]({{< ref
"interface/JavaApi.md">}}).
```
##
File path: hadoop-hdds/docs/content/interface/Cli.md
##
@@ -0,0 +1,209 @@
+---
+title: Command Line Interface
+weight: 4
+menu:
+ main:
+ parent: "Client Interfaces"
+---
+
+
+
+ Ozone shell is the primary interface to interact with Ozone. It provides a
command shell interface to work against Ozone. It uses the [Java API]({{< ref
"interface/JavaApi.md">}}).
+
+ There are some functionality which couldn't be accessed without using `ozone
sh` commands. For example:
+
+ 1. Creating volumes with quota
+ 2. Managing internal ACLs
+ 3. Creating buckets with encryption key
+
+All of these are one-time, administration tasks. Applications can use Ozone
without this CLI using other interface like Hadoop Compatible File System (o3fs
or ofs) or S3 interface.
+
+
+Ozone shell help can be invoked at _object_ level or at _action_ level.
+
+For example:
+
+```bash
+ozone sh volume --help
+```
+
+This will show all possible actions for volumes.
+
+or it can be invoked to explain a specific action like
+
+```bash
+ozone sh volume create --help
+```
+
+This command will give you command line options of the create command.
+
+## General Command Format
+
+The Ozone shell commands take the following format.
+
+> _ozone sh object action url_
+
+**ozone** script is used to invoke all Ozone sub-commands. The ozone shell is
+invoked via ```sh``` command.
+
+The object can be a volume, bucket or a key. The action is various verbs like
+create, list, delete etc.
+
+Ozone URL can point to a volume, bucket or keys in the following format:
+
+_\[schema\]\[server:port\]/volume/bucket/key_
+
+
+Where,
+
+1. **Schema** - This should be `o3` which is the native RPC protocol to access
+ Ozone API. The usage of the schema is optional.
+
+2. **Server:Port** - This is the address of the Ozone Manager. If the port is
+omitted the default port from ozone-site.xml will be used.
+
+Depending on the call, the volume/bucket/key names will be part of the URL.
+Please see volume commands, bucket commands, and key commands section for more
+detail.
+
+## Volume operation
+
+Volume is the top level element of the hierarchy and supposed to managed only
by the administrators. Quota and the owner user can be defined.
+
+Example commands:
+
+```shell
+> ozone sh volume create /vol1
+```
+
+```shell
+bash-4.2$ ozone sh volume info /vol1
+{
+ "metadata" : { },
+ "name" : "vol1",
+ "admin" : "hadoop",
+ "owner" : "hadoop",
+ "creationTime" : "2020-07-28T12:31:50.112Z",
+ "modificationTime" : "2020-07-28T12:31:50.112Z",
+ "acls" : [ {
+"type" : "USER",
+"name" : "hadoop",
+"aclScope" : "ACCESS",
+"aclList" : [ "ALL" ]
+
[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…
maobaolong commented on a change in pull request #1033:
URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r463452504
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##
@@ -708,6 +707,21 @@ private void updateNodeState(DatanodeInfo node,
Predicate condition,
}
}
+ /**
+ *
+ * @param datanodeDetails
+ */
+ public void stopNode(DatanodeDetails datanodeDetails)
+ throws NodeNotFoundException {
+UUID uuid = datanodeDetails.getUuid();
+NodeState state = nodeStateMap.getNodeState(uuid);
+DatanodeInfo node = nodeStateMap.getNodeInfo(uuid);
+nodeStateMap.updateNodeState(datanodeDetails.getUuid(), state,
+NodeState.DEAD);
+node.updateLastHeartbeatTime(0L);
Review comment:
Ok, so would you like to create a ticket an paste it as a TODO comment
here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1228: HDDS-3995. Fix s3g met NPE exception while write file by multiPartUpload
maobaolong closed pull request #1228: URL: https://github.com/apache/hadoop-ozone/pull/1228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
