Re: [Pacemaker] Correct order of meta/params in crm

2013-03-03 Thread David Coulson 


On 3/2/13 8:22 AM, Lars Marowsky-Bree wrote:

Unless it annoys you, this is actually harmless.

Otherwise, params first is what I tend to use.


Regards,
 Lars

We've seen instances where failure-timeout is set, but Pacemaker never 
seems to clean up the failure. First thought was it didn't actually 
utilize the meta failure-timeout parameter if it was in the wrong place. 
Probably need to troubleshoot it further and try to reproduce the issue.


David

___
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org

Re: [Pacemaker] Correct order of meta/params in crm

2013-03-03 Thread Lars Marowsky-Bree 
On 2013-03-03T12:29:55, David Coulson da...@davidcoulson.net wrote:

 We've seen instances where failure-timeout is set, but Pacemaker never seems
 to clean up the failure. First thought was it didn't actually utilize the
 meta failure-timeout parameter if it was in the wrong place. Probably need
 to troubleshoot it further and try to reproduce the issue.

My memory may be very faulty, but I thought this didn't lead to the
failure actually be cleaned up automatically, but merely ignored
post-timeout.


Regards,
Lars

-- 
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 
21284 (AG Nürnberg)
Experience is the name everyone gives to their mistakes. -- Oscar Wilde


___
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org

Re: [Pacemaker] Correct order of meta/params in crm

2013-03-03 Thread David Coulson 

On 3/3/13 1:00 PM, Lars Marowsky-Bree wrote:

My memory may be very faulty, but I thought this didn't lead to the
failure actually be cleaned up automatically, but merely ignored
post-timeout.

Perhaps 'clean up' is the wrong phrase. But I've absolutely seen it 
remove the failure out of 'crm_mon -1fr', which is perhaps the same as a 
cleanup, but maybe not.


___
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org

[Pacemaker] [pacemaker][openais]timer_attributes.type is missing

2013-03-03 Thread zhuyj 



Hi,

  If req_lib_tmr_timerreschedule-timer_attributes.type is
  SA_TIME_ABSOLUTE, an absolute time value must be higher
  than the current absolute time.According to the type, we
  will compare the current time with an absolute time. If
  the type is SA_TIME_ABSOLUTE, we will compare. Or else,
  we do nothing;

diff -urpN a/services/tmr.c b/services/tmr.c
--- a/services/tmr.c
+++ b/services/tmr.c
@@ -442,7 +442,8 @@ static void message_handler_req_lib_tmr_

 current_time = (SaTimeT)(api-timer_time_get());

-if (current_time 
req_lib_tmr_timerreschedule-timer_attributes.initialExpirationTime) {
+if ((SA_TIME_ABSOLUTE ==
req_lib_tmr_timerreschedule-timer_attributes.type) 
+(current_time 
req_lib_tmr_timerreschedule-timer_attributes.initialExpirationTime)) {
 error = SA_AIS_ERR_INVALID_PARAM;
 goto error_put;
 }
diff -urpN a/test/testtmr.c b/test/testtmr.c
--- a/test/testtmr.c
+++ b/test/testtmr.c
@@ -86,8 +86,8 @@ int main (void)
 SaTmrHandleT handle;
 SaSelectionObjectT select_obj;
 SaTmrTimerAttributesT attrs;
-SaTmrTimerAttributesT attrs_a = { SA_TIME_DURATION, TMR_30_SECONDS,
0 };
-SaTmrTimerAttributesT attrs_b = { SA_TIME_DURATION, TMR_30_SECONDS,
0 };
+SaTmrTimerAttributesT attrs_a = { SA_TIME_DURATION, TMR_30_SECONDS,
TMR_30_SECONDS };
+SaTmrTimerAttributesT attrs_b = { SA_TIME_DURATION, TMR_30_SECONDS,
TMR_30_SECONDS };
 SaTmrTimerAttributesT new_attrs_a = { SA_TIME_DURATION,
TMR_10_SECONDS, TMR_10_SECONDS };
 SaTmrTimerAttributesT new_attrs_b = { SA_TIME_DURATION,
TMR_20_SECONDS, TMR_20_SECONDS };
 SaTmrTimerIdT id_a;




___
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org