[Bug 567542] New: Review Request: perl-App-cpanminus - Get, unpack, build and install modules from CPAN

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-App-cpanminus - Get, unpack, build and install 
modules from CPAN

https://bugzilla.redhat.com/show_bug.cgi?id=567542

   Summary: Review Request: perl-App-cpanminus - Get, unpack,
build and install modules from CPAN
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmasl...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://mmaslano.fedorapeople.org/review/perl-App-cpanminus.spec
SRPM URL:
http://mmaslano.fedorapeople.org/review/perl-App-cpanminus-0.09-1.fc12.src.rpm
Description: cpanminus is a script to get, unpack, build and install modules
from CPAN. Its catch? Deps-free, zero-conf, standalone ~350 LOC script (i.e.
hackable) and requires 8MB of RAM. See below for its cons.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 556556] Review Request: geronimo-parent-poms - Parent POM files for geronimo-specs

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556556

--- Comment #10 from Alexander Kurtakov akurt...@redhat.com 2010-02-23 
03:28:50 EST ---
Can we close the bug and all the other geronimo bugs now that it's in rawhide?
I assume that you will not push this to F-12.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566962

--- Comment #10 from Chen Lei supercy...@163.com 2010-02-23 04:03:24 EST ---
(In reply to comment #9)
  rpmbuild --rebuild
  http://dl.dropbox.com/u/1338197/1/polipo-1.0.4.1-2.fc12.src.rpm
  
  Please test the initscript and RPM post scripts to see if them work fine on
  your PC.
 The reviewer should test the software, not only the build and installation
 process to verify the software works correct (or at least as designed).
 
 Did you inform upstream? There seem to exist more than one fedora-package for
 polipo, e.g. http://devil.homelinux.org/Tor_related/polipo/
The software is only one file, so the verification of polipo itself is easy to
do.


Upstream will be informed until polipo is pushed to the repo of fedora.
The polipo rpms provided by some third repos didn't meet fedora packaging
guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567234

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE

--- Comment #11 from Richard W.M. Jones rjo...@redhat.com 2010-02-23 04:13:11 
EST ---
Thanks Jason!

I've only built this in Rawhide for the moment, because otherwise it will
conflict with existing libguestfs in stable branches.  When I upgrade
libguestfs over time in those stable branches, I will build hivex there
too.

Rawhide build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2008060

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566977] Review Request: libSNL - library for manipulating NURBS surfaces

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566977

--- Comment #2 from Dan Horák d...@danny.cz 2010-02-23 04:18:04 EST ---
Again few notes:
- preferred way to obtain a snapshot is to use svn export (and use the svn
revision id because it uniquely identifies the snapshot) and we have a wrapper
that simplifies the process in the fedora-packager package, its usage is
fedora-getsvn libsnl https://libsnl.svn.sourceforge.net/svnroot/libsnl/trunk
18
- the version/release tags should use the snapshot package versioning - see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
- would be useful if the maintainance would be coordinated with other distros
carrying/wanting to carry Calculix and eventually take over the upstream
development/maintainance, I see subtle difference between the upstream libSNL
code and the version packaged in cgx sources

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 565844] Review Request: intellij-idea - IntelliJ IDEA Community Edition IDE

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565844

--- Comment #7 from Lubomir Rintel lkund...@v3.sk 2010-02-23 04:23:13 EST ---
Made it build without bundled jps. It depends on jps (bug #567419) which in
turn itself depends on idea itself, therefore both were made optionaly
bootstrapable (with prebuilt blobs).

SPEC: http://v3.sk/~lkundrak/SPECS/intellij-idea.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/intellij-idea-9.0.1.94.310-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567234

Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

 CC||fed...@matbooth.co.uk

--- Comment #12 from Mat Booth fed...@matbooth.co.uk 2010-02-23 04:41:04 EST 
---
Hi Richard,

You've added the wrong Matthew Booth to the list of package owners. My FAS
account name is mbooth, but I did not review this package. You wanted the
*other* Matthew Booth's FAS account name... :-)

I will relinquish co-maintainership of this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567234

--- Comment #13 from Richard W.M. Jones rjo...@redhat.com 2010-02-23 04:46:06 
EST ---
Ah, sorry 'bout that.  It's very confusing ...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567563] New: Review request: tikiwiki

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review request: tikiwiki

https://bugzilla.redhat.com/show_bug.cgi?id=567563

   Summary: Review request: tikiwiki
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jgo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://jgorig.fedorapeople.org/tikiwiki.spec
SRPM URL: http://jgorig.fedorapeople.org/tikiwiki-4.1-1.fc12.src.rpm

Description: TikiWiki is a powerful web-based application created by large team
of developers from the TikiWiki CMS/Groupware project. TikiWiki is the perfect
tool for you to build and maintain your
Website/Wiki/Groupware/CMS/Forum/Blog/Bug Tracker or any other project you can
imagine running in your browser window

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567234

--- Comment #14 from Mat Booth fed...@matbooth.co.uk 2010-02-23 04:50:30 EST 
---
(In reply to comment #13)
 Ah, sorry 'bout that.  It's very confusing ...

Heh, tell me about it. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567563] Review request: tikiwiki

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567563

Michal Marciniszyn mmarc...@redhat.com changed:

   What|Removed |Added

 CC||mmarc...@redhat.com
 AssignedTo|nob...@fedoraproject.org|mmarc...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566962

--- Comment #11 from Matthias Runge mru...@fedoraproject.org 2010-02-23 
05:16:13 EST ---
And how do I verify? Is there a test(-suite)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 505360] Review Request: JSCookMenu - Javascript GUI-like web menus

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505360

--- Comment #7 from Patrick Monnerat p...@datasphere.ch 2010-02-23 05:51:24 
EST ---
Sorry to tell you, but I do not agree with this suggestion for the following
reasons:
_ Although these macros are effectively defined in the /usr/lib/rpm/macros
file, they are mainly intended to ease porting specs from the old Mandrake
distribution. The 2 years-old page you reference to is annotated This page
could probably be deleted... Doesn't seem to be much useful information and
the referring page
(https://fedoraproject.org/wiki/Packaging:RPMMacros#Reference) lists it only as
a conversion aid from Mandrake spaces (altough not forbidding use of this
macros, I conceed to you).
_ I did not find usage references to these macros in the packaging guidelines, 
neither as a requirement nor even as a recommandation.
_ The use of these macros is not very frequent in current Fedora spec files.
_ Finally, I do not like them: they lower the spec file readability and they
introduce a dependency to their definitions while it is unlikely that their
defined value changes sometime.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566962

--- Comment #12 from Chen Lei supercy...@163.com 2010-02-23 06:15:46 EST ---
service polipo start
service polipo stop
service polipo status
service polipo restart


You can test if the local webserver (http://localhost:8123/) works fine after
you start polipo.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561430] Review Request: geronimo-jta - J2EE JTA v1.1 API

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561430

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567257] Review Request: libfm - GIO-based library for file manager-like programs

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567257

--- Comment #4 from Christoph Wickert cwick...@fedoraproject.org 2010-02-23 
07:24:43 EST ---
Thanks for picking this up.

I talked to PCMan yesterday and he said he can't follow your concerns. If
someone asked him 6 months ago, he maybe would have renamed the package, but
now he is not willing to do it any longer. I guess we have to accept this and
follow upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 225700] Merge Review: docbook-dtds

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225700

--- Comment #2 from Kamil Dudka kdu...@redhat.com 2010-02-23 07:42:20 EST ---
Created an attachment (id=395701)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=395701)
fix rpmlint warnings about unapplied patches

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #31 from Marcela Mašláňová mmasl...@redhat.com 2010-02-23 
08:16:12 EST ---
Let's move it a little:
[ma...@caladan devel]$ rpmlint sendmail-8.14.4-3.fc13.x86_64.rpm 
sendmail.x86_64: W: only-non-binary-in-usr-lib
 This should be fixed.
sendmail.x86_64: E: file-in-usr-marked-as-conffile
/usr/lib64/sasl2/Sendmail.conf
 Probably can't fix
sendmail.x86_64: W: conffile-without-noreplace-flag
/usr/lib64/sasl2/Sendmail.conf
 Use noreplace flag if user can lost settings.
sendmail.x86_64: E: setgid-binary /usr/sbin/sendmail.sendmail smmsp 02755
sendmail.x86_64: E: non-standard-executable-perm /usr/sbin/sendmail.sendmail
02755
sendmail.x86_64: E: zero-length /var/log/mail/statistics
sendmail.x86_64: E: executable-marked-as-config-file /etc/mail/make
sendmail.x86_64: E: non-standard-dir-perm /var/spool/mqueue 0700
sendmail.x86_64: E: non-standard-dir-perm /var/spool/clientmqueue 0770
 Strange, but probably ok in this case.
sendmail.x86_64: W: log-files-without-logrotate /var/log/mail
 Couldn't be lograted?
sendmail.x86_64: W: dangerous-command-in-%post chown
sendmail.x86_64: W: service-default-enabled /etc/rc.d/init.d/sendmail
sendmail.x86_64: E: incoherent-subsys /etc/rc.d/init.d/sendmail sm-client
sendmail.x86_64: E: incoherent-subsys /etc/rc.d/init.d/sendmail sm-client
sendmail.x86_64: W: service-default-enabled /etc/rc.d/init.d/sendmail
 Ok in this case
1 packages and 0 specfiles checked; 9 errors, 6 warnings.
[ma...@caladan devel]$ rpmlint sendmail-8.14.4-3.fc13.src.rpm 
sendmail.src:59: W: unversioned-explicit-provides MTA
sendmail.src:59: W: unversioned-explicit-provides smtpdaemon
sendmail.src:59: W: unversioned-explicit-provides server(smtp)
 Ok in this case.
sendmail.src:60: W: unversioned-explicit-provides %{_sbindir}/sendmail
sendmail.src:60: W: unversioned-explicit-provides %{_bindir}/mailq
sendmail.src:60: W: unversioned-explicit-provides %{_bindir}/newaliases
sendmail.src:61: E: hardcoded-library-path in /usr/lib/sendmail
sendmail.src:61: W: unversioned-explicit-provides %{_bindir}/rmail
sendmail.src:61: W: unversioned-explicit-provides /usr/lib/sendmail
sendmail.src:62: W: unversioned-explicit-provides %{_sysconfdir}/pam.d/smtp
sendmail.src:63: W: unversioned-explicit-provides %{_mandir}/man1/mailq.1.gz
sendmail.src:63: W: unversioned-explicit-provides
%{_mandir}/man1/newaliases.1.gz
sendmail.src:64: W: unversioned-explicit-provides %{_mandir}/man5/aliases.5.gz
sendmail.src:64: W: unversioned-explicit-provides %{_mandir}/man8/sendmail.8.gz
 It was mentioned before, you can use ghost for these.
sendmail.src:269: E: hardcoded-library-path in %{buildroot}/usr/lib
sendmail.src:308: E: hardcoded-library-path in
%{buildroot}/usr/lib/sendmail.sendmail
sendmail.src:429: E: hardcoded-library-path in /usr/lib/sendmail.sendmail
sendmail.src:478: E: hardcoded-library-path in /usr/lib/sendmail.sendmail
 Ok in this case.
1 packages and 0 specfiles checked; 5 errors, 13 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 485652] Review Request: navit - Car navigation system with routing engine

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485652

--- Comment #60 from Karel Volný kvo...@redhat.com 2010-02-23 08:37:38 EST ---
(In reply to comment #59)
 I did file an upstream ticket:
 
 http://trac.navit-project.org/ticket/508
 
 no reply yet :(

just a note, the ticket got assigned meanwhile

it has milestone 0.2.0, but I'm unable to find any release schedule ...
however, Trac Roadmap says 53% complete, more than half, woohoo :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 225700] Merge Review: docbook-dtds

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225700

--- Comment #3 from Kamil Dudka kdu...@redhat.com 2010-02-23 08:37:30 EST ---
considered OK
=
- almost silent rpmlint with the the patch applied:

docbook-dtds.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 299, tab: line
269)
docbook-dtds.noarch: W: dangerous-command-in-%post chmod
docbook-dtds.noarch: W: dangerous-command-in-%postun rm

- sane summary/description
- valid project URL and source URL
- upstream zip archives are match the ones from look-aside cache
- dist tag OK
- license tag OK
- %prep OK
- %clean OK
- %defattr OK
- %files OK
- %doc OK, the hack with cp --parents is IMO a bit subtle, but it works


may be better
=
- BuildRoot tag should be %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XX)

- all explicit (Build)Requires may be eliminated (far beyond Fedora 11)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #32 from Marcela Mašláňová mmasl...@redhat.com 2010-02-23 
08:43:32 EST ---
? rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
OK The sources used to build the package must match the upstream source.
 1b23d5000c8e7bfe82ec1a27f2f5fdc5
OK successful koji compilation.
OK correct BuildRequires, Requires.
- proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
- static libraries must be in a -static package.
- pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
 in this case separate packages -milter
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
- GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

%defattr(-,root,root)
Should be %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 529861] Review Request: userspace-rcu - RCU (read-copy-update) in user space

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529861

Dan Horák d...@danny.cz changed:

   What|Removed |Added

   Flag||needinfo?(k...@fi.muni.cz)

--- Comment #4 from Dan Horák d...@danny.cz 2010-02-23 08:56:56 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 549496] Review Request: bakefile - A cross-platform, cross-compiler native makefiles generator

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549496

Dan Horák d...@danny.cz changed:

   What|Removed |Added

   Flag||needinfo?(rosset.fil...@gma
   ||il.com)

--- Comment #7 from Dan Horák d...@danny.cz 2010-02-23 08:55:37 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 563480] Review Request: aduna-commons-concurrent - Extensions to the Java Concurrency package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563480

--- Comment #4 from Mary Ellen Foster mefos...@gmail.com 2010-02-23 09:07:59 
EST ---
New version:
- Remove BuildRequirements that are pulled in by aduna-commons POM
- Require the main package in the javadoc

http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-concurrent.spec
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-concurrent-2.6.0-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563477] Review Request: aduna-commons-io - Extensions to the Java IO functionality

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563477

--- Comment #2 from Mary Ellen Foster mefos...@gmail.com 2010-02-23 09:08:03 
EST ---
New version:
- Remove BuildRequirements that are pulled in by aduna-commons POM
- Require the main package in the javadoc

http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-io.spec
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-io-2.8.0-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563483] Review Request: aduna-commons-lang - Extensions to the Java lang package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563483

--- Comment #2 from Mary Ellen Foster mefos...@gmail.com 2010-02-23 09:08:06 
EST ---
New version:
- Remove BuildRequirements that are pulled in by aduna-commons POM
- Require the main package in the javadoc

http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-lang.spec
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-lang-2.8.0-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki: Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

Kevin Wright kwri...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Kevin Wright kwri...@redhat.com 2010-02-23 09:12:40 EST 
---
New Package CVS Request
===
Package Name: dogtag-pki
Short Description: Meta-package for Dogtag Public Key Infrastructure (PKI) Suit 
Owners: kwright
Branches: F-11, F-12, F-13, EL-5
InitialCC: ausil

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562504

--- Comment #24 from Lisandro Dalcin dalc...@gmail.com 2010-02-23 09:30:16 
EST ---
(In reply to comment #23)
  I also saw that rpmlint complains (signaling an error, not a warning) about
  empty files. What's wrong with empty files to that being an error? If 
  required,
  I could add a comment line at the start of these files, in order to 'fill' 
  them
  and make rpmlint stop complaining.
 
 http://fedoraproject.org/wiki/Common_Rpmlint_issues#zero-length
 I guess, this is a  packaging guidelines, because this broke something
 somewhere.
 rpmlint sometimes shows false positives, so it would be ok to leave the 
 errors.
 

OK. After looking around in my F12 box, I can see many empty __init__.py files
inside the system Python install. So I'll leave my *.pyx/*.pyd empty, too.

  BTW, Thomas... Could you make sure that the MPE extension module actually 
  works
  on MPICH2+x86_64 ??
 
 $ PYTHONPATH=/usr/lib64/python2.6/site-packages/mpich2/ make -C
 demo/mpe-logging
 make: Entering directory
 `/home/tom/rpmbuild/MOPENED/mpi4py/mpi4py-1.2/demo/mpe-logging'
 mpiexec -n 8 python cpilog.py
 Writing logfile
 Enabling the Default clock synchronization...
 Finished writing logfile cpilog.clog2.
 mpiexec -n 8 python ring.py
 Writing logfile
 Enabling the Default clock synchronization...
 Finished writing logfile ring.clog2.
 mpiexec -n 8 python threads.py
 Writing logfile
 Enabling the Default clock synchronization...
 Finished writing logfile threads.clog2.
 rm -f *.[cs]log2
 make: Leaving directory
 `/home/tom/rpmbuild/MOPENED/mpi4py/mpi4py-1.2/demo/mpe-logging'
 

OK. It works.

  If this does not work, that's surely related to libmpe.a from MPICH2 not 
  being
  built with -fPIC.
 
 From the spec file of mpich2, you can see, that on x86_64, it's explicit build
 with -fPIC, but not on any other platform.


OK. I've mailed mpich2-dev about this issue some time ago. They more or less
agreed that -fPIC should be used for building objects going to libmpe.a in the
case of sharedlib-enabled MPICH2 build.

 But because this fails on x86_64 in the buildsystem too, this should be
 something different :(

Sorry, could you point to any link where I can take a look?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 225617] Merge Review: bitmap-fonts

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225617

Pravin Satpute psatp...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(psatp...@redhat.c |
   |om) |

--- Comment #36 from Pravin Satpute psatp...@redhat.com 2010-02-23 09:50:45 
EST ---
sorry, i missed this for long time
better to fix this before f13



fixed blocking things
fixed macro in changelog
added empty build section

SRPM: http://pravins.fedorapeople.org/bitmap-fonts-0.3-15.fc12.src.rpm
SPEC : http://pravins.fedorapeople.org/bitmap-fonts.spec

how can we fix
rpmlint warning
bitmap-fonts.src: W: no-url-tag
bitmap-fonts.src: W: invalid-url Source1: fixfont-3.5.tar.bz2
bitmap-fonts.src: W: invalid-url Source0: bitmap-fonts-0.3.tar.bz2

do we have any upstream link for this
http://websvn.kde.org/tags/KDE/3.5.9/kdebase/konsole/

else, may be we can add some notes in spec file

nicholas please guide

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567654] New: Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Infobright Community Edition - Columnar database for 
analytics

https://bugzilla.redhat.com/show_bug.cgi?id=567654

   Summary: Review Request: Infobright Community Edition -
Columnar database for analytics
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mark.wind...@infobright.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.infobright.org/downloads/ice/infobright.spec
SRPM URL: http://www.infobright.org/downloads/ice/infobright-3.3.1-0.src.rpm
Description: Infobright Community Edition (ICE)  combines a column-oriented
database with our Knowledge Grid architecture to deliver a self-managing
database optimized for analytics.

This is our first package, and we need a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567652] New: Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Infobright Community Edition - Columnar database for 
analytics

https://bugzilla.redhat.com/show_bug.cgi?id=567652

   Summary: Review Request: Infobright Community Edition -
Columnar database for analytics
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mark.wind...@infobright.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.infobright.org/downloads/ice/infobright.spec
SRPM URL: http://www.infobright.org/downloads/ice/infobright-3.3.1-0.src.rpm
Description: Infobright Community Edition (ICE)  combines a column-oriented
database with our Knowledge Grid architecture to deliver a self-managing
database optimized for analytics.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567654] Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567654

Mark Windrim mark.wind...@infobright.com changed:

   What|Removed |Added

 CC||mark.wind...@infobright.com
   Platform|All |x86_64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567654] Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567654

Mark Windrim mark.wind...@infobright.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567654] Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567654

--- Comment #1 from Mark Windrim mark.wind...@infobright.com 2010-02-23 
10:42:36 EST ---
Infobright Community Edition is based upon OEM code from MySQL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567668] New: aide package rebase

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: aide package rebase

https://bugzilla.redhat.com/show_bug.cgi?id=567668

   Summary: aide package rebase
   Product: Red Hat Enterprise Linux 6
   Version: 6.1
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: aide
AssignedTo: sgr...@redhat.com
ReportedBy: sgr...@redhat.com
 QAContact: qe-baseos-secur...@redhat.com
CC: nott...@redhat.com, m...@redhat.com,
sgr...@redhat.com, fedora-package-rev...@redhat.com
Depends on: 561128
 Group: rhel_beta
   Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
  Clone Of: 561128


+++ This bug was initially created as a clone of Bug #561128 +++

(There probably used to be a review in Extras.)

* Licensing problems:
  * src/fopen.c contains:
 2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
- the BSD advertising clause, incompatible with GPL
  * src/snprintf.c uses the Frontier Artistic License, AFAICS never approved
for Fedora (http://fedoraproject.org/wiki/Licensing)
  (In both cases the functionality is probably unnecessary and the files could
  be removed from the source tarball)
  * LICENSE-snprintf.txt is not provided in %doc

* rpmlint:
   aide.x86_64: W: log-files-without-logrotate /var/log/aide
  Can the log file grow without bounds?

* Uses %makeinstall, is it necessary? Makefile.in seems to support DESTDIR.

* Uses %define, should use %global instead

* Low-severity:
  * The nostatic macro is defined, but not used
  *
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

--- Additional comment from sgr...@redhat.com on 2010-02-19 13:34:20 EST ---

All findings have been addressed in aide-0.13.1-16 except the license issues.
This is going to be handled by a new upstream release.

--- Additional comment from sgr...@redhat.com on 2010-02-22 20:23:42 EST ---

aide-0.14-0.1.rc1 was built to address all problems found in this package
review. Please let me know if there is anything else that needs attention.
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567654] Review Request: Infobright Community Edition - Columnar database for analytics

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567654

--- Comment #2 from Mark Windrim mark.wind...@infobright.com 2010-02-23 
10:52:19 EST ---
*** Bug 567652 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561128] Package review: aide

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561128

Steve Grubb sgr...@redhat.com changed:

   What|Removed |Added

 Blocks||567668

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567668] aide package rebase

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567668

Dan Horák dho...@redhat.com changed:

   What|Removed |Added

 CC|fedora-package-rev...@redha |
   |t.com   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 566163] Review Request: sugar-logos - Boot splash imagery for Sugar on a Stick

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566163

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
11:07:32 EST ---
sugar-logos-2-1.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 555843] Review Request: pam_radius - PAM Module for RADIUS Authentication

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555843

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2010-02-23 11:06:45 EST ---
pam_radius-1.3.17-2.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516528

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2010-02-23 11:04:48 EST ---
globus-gram-client-tools-7.3-1.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 555843] Review Request: pam_radius - PAM Module for RADIUS Authentication

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555843

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||pam_radius-1.3.17-2.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567107] Review Request: perl-Net-SSLGlue - Add/extend SSL support for common perl modules

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567107

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
11:05:56 EST ---
perl-Net-SSLGlue-0.2-1.fc13 has been pushed to the Fedora 13 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Net-SSLGlue'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2638

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567038] Review Request: perl-Mixin-ExtraFields - Add extra stashes of data to your objects

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567038

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
11:06:01 EST ---
perl-Mixin-ExtraFields-0.008-1.fc13 has been pushed to the Fedora 13 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Mixin-ExtraFields'.  You
can provide feedback for this update here:
http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2640

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566163] Review Request: sugar-logos - Boot splash imagery for Sugar on a Stick

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566163

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||sugar-logos-2-1.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516528

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||globus-gram-client-tools-7.
   ||3-1.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567110

Thomas Janssen thom...@fedoraproject.org changed:

   What|Removed |Added

 CC||thom...@fedoraproject.org
 AssignedTo|nob...@fedoraproject.org|thom...@fedoraproject.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567109] Review Request: libunicap - Library to access different kinds of (video) capture devices

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567109

Thomas Janssen thom...@fedoraproject.org changed:

   What|Removed |Added

 CC||thom...@fedoraproject.org
 AssignedTo|nob...@fedoraproject.org|thom...@fedoraproject.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 554714] Review Request: python-psutil - A process utilities module for Python

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554714

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2010-02-23 11:10:27 EST ---
python-psutil-0.1.2-4.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 554714] Review Request: python-psutil - A process utilities module for Python

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554714

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||python-psutil-0.1.2-4.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 565916] Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565916

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
11:09:03 EST ---
php-ezc-Graph-1.5-1.fc13 has been pushed to the Fedora 13 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-ezc-Graph'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2684

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] New: Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Cameramonitor - Notification icon when webcam is active

https://bugzilla.redhat.com/show_bug.cgi?id=567678

   Summary: Review Request: Cameramonitor - Notification icon when
webcam is active
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ading...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


This is my first package for Fedora, so I will need a sponsor. I've tried to
comply with the guidelines as published on the web, but I won't be shocked or
offended when it needs fixed.

Spec URL: http://people.redhat.com/adingman/cameramonitor/cameramonitor.spec
SRPM URL:
http://people.redhat.com/adingman/cameramonitor/cameramonitor-0.2-2.src.rpm
Description: 
Camera Monitor is a little tray system icon that notifies you when your web cam
is on.

It is designed for the GNOME desktop, but will work as well on KDE and XFCE.
Camera Monitor is released under the terms of the GNU General Public License

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

Andrew Dingman ading...@redhat.com changed:

   What|Removed |Added

URL||http://people.redhat.com/ad
   ||ingman/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

Andrew Dingman ading...@redhat.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 562997] Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562997

--- Comment #4 from Mohammed Morsi mmo...@redhat.com 2010-02-23 11:52:35 EST 
---
(In reply to comment #3)
 Please address
  - directory ownership issue
  - rake test failure (at least BR: rubygem(rake) is needed.
Also it seems Gem::manage_gems in Rakefile seems deprecated)

All three issues are resolved.

Updated and uploaded new rubygem-maruku spec / srpm

Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-3.fc12.src.rpm 

There are a few tests that fail when rake test is run, though the majority
pass. The same tests fail when I install the upstream gem via the normal 'gem
install' means and run rake test in the default installation dir.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566687] Review Request: perl-MooseX-Types-DateTimeX - Extensions to MooseX::Types::DateTime::ButMaintained

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566687

--- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 12:07:01 EST 
---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 553281] Review Request: netsniff-ng - high performance linux network sniffer for packet inspection

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553281

--- Comment #14 from James Findley s...@gmx.com 2010-02-23 12:32:24 EST ---
Thanks for the review!  I've changed the way the sources work some, in the hope
of getting it to be a bit cleaner.

### Short background ###
Until very recently this app used a unix domain socket, to allow stats
reporting in daemon mode (an essential part of daemon mode).  This is now a
deprecated feature in the latest svn revisions, and is scheduled to be replaced
by a better method, namely a netlink multicast group.  However this is not yet
implemented, and so temporarily the latest upstream misses an essential part of
daemon mode.  As we are building an unreleased svn version, to fix (many)
issues with the latest stable, upstream aren't interested in keeping the unix
domain socket around until the new method is functional.

So there are basically 3 options:
1) continue to ship the buggy 0.5.4 code
2) ship the latest upstream, and put up with daemon mode being not terribly
useful
3) ship this svn revision until 0.5.5.0 is final, patching the UDS server code
to make it work, and packaging the client to read statistics from an older
version of the source.

I am proposing to do 3 - this svn revision is (after the patch) good code and
has been stable across a wide range of test environments, so makes a good stop
while I wait for 0.5.5.0.

So what I now do is svn export the correct revision, tar it up and use that as
source 0.  I also use the 0.5.3 source to provide the client for the UDS.

I hope that explains the reasoning behind this spec madness, and why these
patches aren't appropriate for upstream.

### Short background ###

Sources are fixed.

Requires/Buildrequires are also fixed.

I've got rid of the check_packets.tar.gz

I've stopped using the macros for rm, make and install.

However, rpmlint now produces some errors.

SPECS/netsniff-ng.spec: W: invalid-url Source3:
http://netsniff-ng.googlecode.com/files/netsniff-ng-0.5.3.tar.gz HTTP Error
404: Not Found
SPECS/netsniff-ng.spec: W: invalid-url Source0: netsniff-ng-0.5.5.0.tar.gz

The first is an odd error.  Possibly a bug in rpmlint (I will investigate this
more fully when I have time) as a wget of that URL works fine.
The second is explained by the comments above, in accordance with:
http://fedoraproject.org/wiki/Packaging/SourceURL
Therefore I am proposing to ignore these warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 553281] Review Request: netsniff-ng - high performance linux network sniffer for packet inspection

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553281

--- Comment #15 from James Findley s...@gmx.com 2010-02-23 12:34:40 EST ---
like an idiot I left out the actual rpm...


koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2009586
spec: http://sixy.myzen.co.uk/netsniff-ng.spec
srpm: http://sixy.myzen.co.uk/netsniff-ng-0.5.5.0-0.4.211svn.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567713

Filipe Rosset rosset.fil...@gmail.com changed:

   What|Removed |Added

 CC||d...@danny.cz
 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549496] Review Request: bakefile - A cross-platform, cross-compiler native makefiles generator

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549496

Filipe Rosset rosset.fil...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?(rosset.fil...@gma |
   |il.com) |

--- Comment #8 from Filipe Rosset rosset.fil...@gmail.com 2010-02-23 13:13:26 
EST ---
comment #6
- includes a copy of empy python module, this one must be packaged
independently


I open new review request to python-empy on:
https://bugzilla.redhat.com/show_bug.cgi?id=567713

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

--- Comment #1 from R P Herrold herr...@owlriver.com 2010-02-23 13:25:37 EST 
---
A build requirement for the package providing notify-python seems to be missing

I might add:

BuildRequires: notify-python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499491] Review Request: libtdb - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499491

Stephen Gallagher sgall...@redhat.com changed:

   What|Removed |Added

 CC||sgall...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #7 from Stephen Gallagher sgall...@redhat.com 2010-02-23 13:56:45 
EST ---
Package Change Request
==
Package Name: libtdb
New Branches: EL-5
Owners: sgallagh

This is being branched in preparation for building the SSSD in EPEL. (libtdb is
a dependency)

I have simo's permission to become the EPEL maintainer for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499469] Review Request: libtalloc - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499469

Stephen Gallagher sgall...@redhat.com changed:

   What|Removed |Added

 CC||sgall...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #7 from Stephen Gallagher sgall...@redhat.com 2010-02-23 14:00:41 
EST ---
Package Change Request
==
Package Name: libtalloc
New Branches: EL-5
Owners: sgallagh

This is being branched in preparation for building the SSSD in EPEL. (libtalloc
is
a dependency)

I have simo's permission to become the EPEL maintainer for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 564466] Review Request: ubuntutitle-fonts - decorative font of Ubuntu logo

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564466

Paul Flo Williams p...@frixxon.co.uk changed:

   What|Removed |Added

   Flag|needinfo?(p...@frixxon.co.u |
   |k)  |

--- Comment #8 from Paul Flo Williams p...@frixxon.co.uk 2010-02-23 14:28:22 
EST ---
Thank you for the review.

Spec URL: http://hisdeedsaredust.com/pkg/ubuntu-title-fonts.spec
SRPM URL:
http://hisdeedsaredust.com/pkg/ubuntu-title-fonts-002.000-2.fc12.src.rpm

Changes:
1. Changed package name to ubuntu-title-fonts
2. Coverage information removed from description

rpmlint has now been updated and it complains about the spelling of the font
creator's name; other than that it's clean.

Builds in mock.

repo-font-audit runs fontlint and its complaints are already acknowledged by
upstream in the BUGS.txt file which is in the distribution.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567733] New: Review Request: marave - A Simple text editor

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: marave - A Simple text editor

https://bugzilla.redhat.com/show_bug.cgi?id=567733

   Summary: Review Request: marave - A Simple text editor
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rdie...@math.unl.edu
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rdieter.fedorapeople.org/rpms/marave/marave.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/marave/marave-0.6-1.fc12.src.rpm
Description:
Marave is a text editor whose goal is to help you focus on writing.

It's inspired by ommwriter, Darkroom and many other simple text
editors, with a few twists.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567109] Review Request: libunicap - Library to access different kinds of (video) capture devices

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567109

Thomas Janssen thom...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+

--- Comment #1 from Thomas Janssen thom...@fedoraproject.org 2010-02-23 
14:38:00 EST ---
Ok, this is a re-review request due to upstream name change.

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
48b97308fc8bb949f4ac34cbeaf1dbec  libunicap-0.9.8.tar.gz
NN - Package needs ExcludeArch
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
NN - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .so files in -devel subpackage.
OK - .pc files in -devel subpackage/requires pkgconfig
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.

NN - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
XX - No rpmlint output.
Some warnings about spelling errors. Can be ignored.
One warning about obsolete-not-provided unicap-devel
Due to the nature of that rename and split into 3 packages ignorable.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs (tested with rawhide)
OK - Should have sane scriptlets.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version

Issues:
None.

I have checked for obsoletes and provides. I had a chat in IRC with the
maintainer and this seems to be the sane way.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567733] Review Request: marave - A Simple text editor

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567733

--- Comment #1 from Rex Dieter rdie...@math.unl.edu 2010-02-23 14:39:05 EST 
---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2009780

$ rpmlint *.rpm noarch/*.rpm
marave.src: W: spelling-error %description -l en_US ommwriter - copywriter,
songwriter, ghostwriter
marave.src: W: non-standard-group Unspecified
marave.src: W: invalid-url URL: http://marave.googlecode.com/ IncompleteRead(0
bytes read)
marave.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3)
marave.src: W: invalid-url Source0:
http://marave.googlecode.com/files/marave-0.6.tar.gz HTTP Error 404: Not Found
marave.noarch: W: spelling-error %description -l en_US ommwriter - copywriter,
songwriter, ghostwriter
marave.noarch: W: non-standard-group Unspecified
marave.noarch: W: invalid-url URL: http://marave.googlecode.com/
IncompleteRead(0 bytes read)
marave.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/marave/spelltextedit.py 0644 /usr/bin/env
2 packages and 0 specfiles checked; 1 errors, 8 warnings.

Not sure what's up with the Url/Source warnings, they work ok for me

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555991

--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2010-02-23 14:46:40 EST 
---
ping, was this ever imported, can we close this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 531040] Review Request: jsmath-fonts - A collection of Math symbol fonts

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531040

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Rex Dieter rdie...@math.unl.edu 2010-02-23 14:50:06 EST 
---
New Package CVS Request
===
Package Name: jsmath-fonts
Short Description: A collection of Math symbol fonts
Owners: rdieter
Branches: EL-5 F-11 F-12
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563479

Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Mat Booth fed...@matbooth.co.uk 2010-02-23 15:01:40 EST 
---
Thanks for the easy review.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 531040] Review Request: jsmath-fonts - A collection of Math symbol fonts

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531040

--- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 14:58:24 EST 
---
This review ticket is assigned to the person submitting it, which points to
potential weirdness that I'd like to figure out before doing CVS.  What's going
on here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499469] Review Request: libtalloc - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499469

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:01:44 EST 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 521947] Review Request: libtevent - talloc based event library

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521947

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:00:10 EST 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499491] Review Request: libtdb - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499491

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:01:10 EST 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

Summary|Review Request: dogtag-pki: |Review Request: dogtag-pki
   |Meta-package for Dogtag PKI |- Meta-package for Dogtag
   |Suite   |PKI Suite

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 521947] Review Request: libtevent - talloc based event library

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521947

--- Comment #11 from Stephen Gallagher sgall...@redhat.com 2010-02-23 
15:03:48 EST ---
I wanted both. That was a copy-paste error. (I submitted the request for libtdb
first)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 521947] Review Request: libtevent - talloc based event library

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521947

--- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:04:37 EST 
---
CVS done on libtevent as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 531040] Review Request: jsmath-fonts - A collection of Math symbol fonts

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531040

--- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:10:30 EST 
---
CVS done (by process-cvs-requests.py).

I added an F-13 branch as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

--- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:10:51 EST 
---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 531040] Review Request: jsmath-fonts - A collection of Math symbol fonts

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531040

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 AssignedTo|rdie...@math.unl.edu|nicolas.mail...@laposte.net

--- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2010-02-23 15:08:46 EST 
---
OK, checking the history (the CVS processing tool doesn't have a way to show
that) I see that for whatever reason Nicholas reassigned this to Rex.  Please
don't do that.  I've assigned it back and will take care of CVS now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499469] Review Request: libtalloc - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499469

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
15:31:11 EST ---
libtalloc-2.0.1-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libtalloc-2.0.1-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 499491] Review Request: libtdb - spin off of samba4 package

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499491

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
15:42:33 EST ---
libtdb-1.2.0-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libtdb-1.2.0-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561448] Review Request: jffi - Java Foreign Function Interface

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561448

--- Comment #4 from Mohammed Morsi mmo...@redhat.com 2010-02-23 16:54:19 EST 
---
(In reply to comment #3)
 For 0.6.5-1:
 
 * Compilation issue
   A First of all, now build fails:
 http://koji.fedoraproject.org/koji/taskinfo?taskID=1996972
 This is because -Werror.

Patched the source to remove -Werror

 
   B Even after -Werror is removed, build fails on ppc64:
 http://koji.fedoraproject.org/koji/taskinfo?taskID=1997040
 The failing command is:
 Well, -m32 is wrong for ppc64. This is because {jni/libtest}/GNUmakefile
 does not check if the arch is ppc64 or not however
 this check is anyway not needed anyway.

I see the same thing, this isn't a blocker since it builds fine of i686 and
x86_64 correct?

 
 * Test
   - Forgot to mention this, however please check if some test programs
 are available or not (as this package contains test/ directory)
 

Package now includes a check section which runs the test suite. All tests run
fine.

 * Empty debuginfo
 ---
 jffi-debuginfo.i686: E: debuginfo-without-sources
 ---
   - Well, I don't know how Java packages treat this by default,
 however generally to create debuginfo rpm corretly, libjffi-0.6.so
 should not be stripped in build process itself and should
 be handled by find-debuginfo.sh and so on.

I'm not getting this error. Instead I get 

W: unstripped-binary-or-object /usr/lib/jffi/libjffi-0.6.so

Removing the call to strip in the makefile and marking the shared object as
executable does not seem to generate the debuginfo package as detailed online.
Unless you know of the fix, I'm leaving this as is as there seem to be other
packages that have been approved / accepted in lieu of this warning.

Update spec and srpm:
Spec URL: http://mo.morsi.org/files/jruby/jffi.spec
SRPM URL: http://mo.morsi.org/files/jruby/jffi-0.6.5-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561985] Review Request: php-phpunit-phpdcd - Dead Code Detector (DCD) for PHP code

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561985

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
17:00:14 EST ---
php-phpunit-phpdcd-0.9.2-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/php-phpunit-phpdcd-0.9.2-1.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561981] Review Request: php-phpunit-PHP-TokenStream - Wrapper around PHP's tokenizer extension

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561981

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
17:01:58 EST ---
php-phpunit-PHP-TokenStream-0.9.1-2.fc13 has been submitted as an update for
Fedora 13.
http://admin.fedoraproject.org/updates/php-phpunit-PHP-TokenStream-0.9.1-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561985] Review Request: php-phpunit-phpdcd - Dead Code Detector (DCD) for PHP code

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561985

--- Comment #4 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
16:59:27 EST ---
php-phpunit-phpdcd-0.9.2-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/php-phpunit-phpdcd-0.9.2-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
17:23:33 EST ---
dogtag-pki-1.3.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/dogtag-pki-1.3.0-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561482] Review Request: joni - Java port of Oniguruma regexp library

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561482

Mohammed Morsi mmo...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #6 from Mohammed Morsi mmo...@redhat.com 2010-02-23 17:33:27 EST 
---
Claimed ownership of devel branch in pkgdb, and successfully pushed changes to
devel via cvs. Also need F-12 and F-13 branches

Package Change Request
==
Package Name: joni
New Branches: F-12, F-13
Owners: mmorsi
Updated Description: A Java port of the Oniguruma regular expressions library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
17:31:31 EST ---
dogtag-pki-1.3.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/dogtag-pki-1.3.0-1.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-02-23 
17:39:06 EST ---
dogtag-pki-1.3.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/dogtag-pki-1.3.0-1.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566342

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2010-02-23 17:46:52 EST ---
dogtag-pki-1.3.0-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/dogtag-pki-1.3.0-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

--- Comment #2 from Andrew Dingman ading...@redhat.com 2010-02-23 18:10:05 
EST ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=2010347

Thanks. It does build better with that dependency fixed :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 548482] Review Request: gnome-dvb-daemon - Digital Television manager

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548482

Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 556988] Review Request: ibus-fbterm - IBus front-end for fbterm

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556988

--- Comment #11 from Ding-Yi Chen dc...@redhat.com 2010-02-23 18:13:30 EST ---
1.  Please remove the chmod /dev/fd0 line, as Jens suggests.

It is noble to make it usable out-of-the-box, however, it irritates the nerve
of security sense.


2.  Have you noticed that you swapped spec and srpm?  :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 551911] Review Request: monodevelop-boo - A boo plugin for monodevelop

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551911

Christian Krause c...@plauener.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #13 from Christian Krause c...@plauener.de 2010-02-23 18:22:51 
EST ---
I've tested the latest package and it works as expected.

There are two very minor issues left:

1. the line in the spec file 
mkdir -p %{buildroot}%{_datadir}/locale
is a left-over. Althought it does not harm anyone, it is not necessary - please
delete it.

2. In the description of the -devel package is one spelling error left: Addin
- Add-in

Since otherwise all important issues were addressed:
- APPROVED

Please fix the minor issues right after the import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 548482] Review Request: gnome-dvb-daemon - Digital Television manager

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548482

--- Comment #7 from Matthias Clasen mcla...@redhat.com 2010-02-23 18:29:57 
EST ---
package name: ok
spec file name: ok
packaging guidelines: ok, could maybe loose the BuildRoot (since rpmbuild
handles that itself nowadays)
license: ok
license field: seems wrong, COPYING is GPLv3, but you say LGPLv3+
license file: ok
spec file language: ok
spec file readable: ok
upstream sources: ok
buildable: ok
ExcludeArch: ok
BuildRequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: no, ok
directory ownership: need to add a totem dep for /usr/lib/totem/plugins
duplicate files: ok
file permissions: see above
%clean: ok
macro use: ok
content: permissible
large docs: none, ok
%doc content: ok
headers: ok
static libs: ok
pc files: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
directory ownership: ok
%install: ok
utf8 filenames: ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555991

--- Comment #6 from leigh scott leigh123li...@googlemail.com 2010-02-23 
18:51:21 EST ---
(In reply to comment #5)
 ping, was this ever imported, can we close this?

Yes it was.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 CC||cwick...@fedoraproject.org

--- Comment #3 from Christoph Wickert cwick...@fedoraproject.org 2010-02-23 
20:33:13 EST ---
(In reply to comment #0)
 Camera Monitor is released under the terms of the GNU General Public License  
   

Remove this sentence from the description, it's already in the License tag.


The license of the package is GPLv2+. The + means GPLv2 or any later version
(in contrast to version 2 only = GPLv2). You need look at the headers of the
python files in order to distinguish this because COPYING wont tell.


BuildRequires: python should be python-devel, see
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires


There are a lot of missing Requires: Usually rpmbuild will generate them
automatically, but not for python. You should look at the import statements
of the python files, I guess you will need at least pygtk2 and notify-python.


Remove the macro for %{!?python_sitearch, it's not needed for a noarch package

Move the python_sitelib to the top of the spec.

GConf schemas are no config files, remove %config(noreplace) and ignore the
warning that rpmlint will return.

GConf schemas must be (un)installed properly, see 
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

%configure --prefix=%{_prefix} --libdir=%{_libdir}

can be substituted with a simple

%configure

the rest is added automatically, use 'rpm --eval %configure' to check what the
macro does.


Use the %doc macro to install the doc. Simply use 

%doc AUTHORS ChangeLog COPYING NEWS README

in the %files section, rpmbuild will install the docs and include them in the
package.


Your package owns all the files in %{python_sitelib}/cameramonitor/, but not
the dir itself, thus it will be left behind after uninstall. Instead of listing
all the files, you could simply use 

%{python_sitelib}/cameramonitor/

If you want to make sure to only include python files, you could use

%dir %{python_sitelib}/cameramonitor/
%{python_sitelib}/cameramonitor/*.py*

Same goes for %{_datadir}/cameramonitor/, it's unowned too.


The *.desktop files need to be installed or validated, see
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage


Typo in the spec: coppies  - copies

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567678

--- Comment #4 from Christoph Wickert cwick...@fedoraproject.org 2010-02-23 
20:34:37 EST ---
(In reply to comment #3)

 I guess you will need at least pygtk2 and notify-python.

Not to forget gnome-python2-gconf

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 553717] Review Request: libcrystalhd - Broadcom Crystal HD device interface library

2010-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553717

Chris Shoemaker c.shoema...@cox.net changed:

   What|Removed |Added

 CC||c.shoema...@cox.net

--- Comment #23 from Chris Shoemaker c.shoema...@cox.net 2010-02-23 20:35:25 
EST ---
I'm interested in this library and was wondering if anyone could give a status
update on this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   >