[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604500 --- Comment #7 from fujiwara 2010-06-23 01:30:30 EDT --- New Package CVS Request === Package Name: ibus-input-pad Short Description: Input Pad for IBus Owners: fujiwara Branches: F-12 F-13 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604500 fujiwara changed: What|Removed |Added Flag||fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604500 fujiwara changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604500 Parag AN(पराग) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Parag AN(पराग) 2010-06-23 01:06:11 EDT --- Thanks for understanding suggestions. I am getting mixed replies on fedora-devel channel and fedora packaging mailing list like removing BR: pkgconfig is not creating any harm and someone said we should have it. I am approving new SRPM. If someone sees any problem, please report here. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2266521 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600638] Review Request: seed - GNOME JavaScript interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600638 --- Comment #10 from Mamoru Tasaka 2010-06-23 00:44:00 EDT --- You can request rel-eng team to get gnome-js-common tagged as dist-f13-override. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 602042] Review Request (rename): perl-Config-MVP-Reader-INI - MVP config reader for .ini files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602042 Iain Arnell changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Iain Arnell 2010-06-22 23:11:49 EDT --- Thanks for the review, Petr. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606666] Review Request: sselp - Prints X selection to standard out
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=60
ELMORABITY Mohamed changed:
What|Removed |Added
CC||pikachu.2...@gmail.com
--- Comment #2 from ELMORABITY Mohamed 2010-06-22
22:21:14 EDT ---
Hi,
some comments before a potential review:
- libX11-devel at least is missing as a BuildRequires
- sselp is not compiled using the Fedora standard flags. CFLAGS must be set to
%{optflags}. To fix it, you can add this line in your %prep section:
sed -i "s/CFLAGS = .*/CFLAGS = %{optflags} \${INCS} \${CPPFLAGS}/" config.mk
- your patch can be dropped if you call "make install" like this in your
%install section:
make install DESTDIR=%{buildroot} PREFIX=%{_prefix}
- no debuginfos are generated, because of the "-s" option set in LDFLAGS (see
config.mk). To fix it, add also this line in %prep:
sed -i "/LDFLAGS/ s/-s//" config.mk
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606432] Review Request: ditaa - Diagrams Through Ascii Art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606432 --- Comment #5 from Kevin Fenzi 2010-06-22 21:53:38 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604653] Review Request: perl-Test-NoTabs - Check the presence of tabs in your project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604653 --- Comment #3 from Kevin Fenzi 2010-06-22 21:53:19 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603846] Review Request: libpeas - Plug-ins implementation convenience library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603846 --- Comment #7 from Kevin Fenzi 2010-06-22 21:52:16 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 601585] Review Request: perl-mime-construct - Construct/send MIME messages from the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601585 --- Comment #7 from Kevin Fenzi 2010-06-22 21:50:11 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 602042] Review Request (rename): perl-Config-MVP-Reader-INI - MVP config reader for .ini files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602042 --- Comment #3 from Kevin Fenzi 2010-06-22 21:50:48 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604093] Review Request: perl-Test-Synopsis - Test your SYNOPSIS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604093 --- Comment #3 from Kevin Fenzi 2010-06-22 21:52:34 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600682] Review Request: R-GenomicFeatures - A transient package to store various Genomic Features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600682 --- Comment #4 from Kevin Fenzi 2010-06-22 21:48:03 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599715] Review Request: python26-eventlet - Highly concurrent networking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599715 --- Comment #10 from Kevin Fenzi 2010-06-22 21:47:32 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 602674] Review Request: perl-POE-Filter-HTTP-Parser - HTTP POE filter for HTTP clients or servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=602674 --- Comment #7 from Kevin Fenzi 2010-06-22 21:51:30 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #13 from Kevin Fenzi 2010-06-22 21:46:40 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578480] Review Request: spectrum - XMPP transport/gateway
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #54 from Kevin Fenzi 2010-06-22 21:46:01 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 595637] Review Request: qoauth- Qt-based C++ library for OAuth authorization scheme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595637 --- Comment #4 from Kevin Fenzi 2010-06-22 21:47:20 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 550690] Review Request: libsurl - A library for generating shortened URLs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550690 --- Comment #11 from Kevin Fenzi 2010-06-22 21:45:10 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516281] Review Request: perl-Config-Model-TkUI - Tk GUI to edit config data through Config::Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516281 --- Comment #10 from Kevin Fenzi 2010-06-22 21:44:41 EDT --- CVS done (by process-cvs-requests.py). Would you also like a EL-6 branch? If so, add a new request and set the flag again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600835] Review Request: modplugtools - Command line mod music players
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600835 --- Comment #5 from Kevin Fenzi 2010-06-22 21:48:39 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505354 --- Comment #11 from Kevin Fenzi 2010-06-22 21:43:37 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486529] Review Request: perl-HTTP-Response-Encoding - Adds encoding() to HTTP::Response
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486529 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2010-06-22 21:43:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 485586] Review Request: perl-Test-Kwalitee - Test the Kwalitee of a distribution before you release it
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485586 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi 2010-06-22 21:42:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 471231] Review Request: WebCalendar - Single/multi-user web-based calendar application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471231 --- Comment #28 from Kevin Fenzi 2010-06-22 21:40:13 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 475661] Review Request: google-droid-fonts - General-purpose fonts released by Google as part of Android
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475661 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi 2010-06-22 21:41:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 191623] Review Request: perl-Expect-Simple - Wrapper around the Expect module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=191623 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi 2010-06-22 21:34:31 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 329331] Review Request: python-gdata - A Python module for accessing online Google services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=329331 --- Comment #21 from Kevin Fenzi 2010-06-22 21:36:16 EDT --- Have you asked the fedora owner if they would like to maintain in EPEL? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 407571] Review Request: tinyxml - A simple, small, C++ XML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=407571 --- Comment #21 from Kevin Fenzi 2010-06-22 21:38:08 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606714] Review Request: eekboard - A Virtual Keyboard for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606714 --- Comment #2 from Daiki Ueno 2010-06-22 21:14:49 EDT --- Thanks. Fixed in: Spec URL: http://ueno.fedorapeople.org/eekboard/eekboard.spec SRPM URL: http://ueno.fedorapeople.org/eekboard/eekboard-0.0.2-2.fc13.src.rpm I also reduced the number of subpackages into 4: - eekboard - eekboard-libs - eekboard-devel - eekboard-devel-docs Previously I subpackaged them by library dependencies (gtk, clutter, xkl, etc). Now I think this rough splitting is better because the only application "eekboard" requires all of them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605373] Review Request: qgis - A user friendly Open Source Geographic Information System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=605373
--- Comment #2 from Kevin Kofler 2010-06-22 19:48:20
EDT ---
So, before I start reviewing the package against the packaging criteria, I'm
comparing it with the current (orphaned) qgis.spec, mainly to check for upgrade
path issues (and found one of those among other things, see point 3 below).
1. I see you're putting the %description entries all after the %package
entries. It's more common to list both %package and %description for each
subpackage together like the old specfile did it. (But the way you're putting
them is not incorrect, just unusual.)
2. The Summary entries in %package python and %package grass are swapped.
Please fix them.
3. You dropped the theme subpackages. If you drop a subpackage from an existing
Fedora package, you have to Obsolete it for upgrade paths. Please add:
Obsoletes: qgis-theme-classic < 1.1
Obsoletes: qgis-theme-gis < 1.1
Obsoletes: qgis-theme-nkids < 1.1
to the main package.
4. One bizarre thing which was already in the old specfile is that
BuildRequires are listed per subpackage. This doesn't make much sense,
BuildRequires are per SRPM, not per subpackage. The grass BRs are even listed
twice (once in the main package and once with the subpackage). While this is
not strictly required, I'd suggest listing all the BuildRequires together.
5. You're setting GRASS_PREFIX twice, once with the snippet copied from the
original specfile and once with your GRASS_PREFIX=/usr/lib64/. The last setting
prevails, so please remove the unused snippet. And you must fix the hardcoded
/usr/lib64/ to %{_libdir} or it won't build on 32-bit.
6. VERBOSE=1 in the make command line (which you added) is not needed because
the %cmake macro already sets -DCMAKE_VERBOSE_MAKEFILE=ON, i.e. VERBOSE=1 is
the default anyway.
7. You changed the chrpath call to (i) zap the rpath from the libraries and
(ii) not zap any rpath from the executables, are you sure this is right? If in
doubt, please use chrpath on everything (both the libraries and the
executables). But then I'd like to know where the rpath is coming from in the
first place. (Have you actually checked whether there's an rpath?) Also try
just using %{_cmake_skip_rpath} in the %cmake call and see if that makes the
rpaths go away. (It's better to not generate rpaths in the first place than to
remove them.)
8. You added an additional chmod +x on libraries, are you sure this (and the
one which was already there) is needed? The current CMake should be installing
shared libraries with +x permissions already!
9. The devel subpackage doesn't need any ldconfig calls (ldconfig calls are
only needed for shared libraries, not devel symlinks to them), please remove
the 2 scriptlets you added.
10. Just a hint: instead of:
%dir %{_libdir}/%{name}
%{_libdir}/%{name}/*
you can just list:
%{_libdir}/%{name}/
in the file list, it will have the same effect (and yes, %exclude also works on
that).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 607015] Review Request: hcs_utils - A collection of useful python snippets for hcs's projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607015 --- Comment #2 from Howard Ning 2010-06-22 19:38:38 EDT --- Sorry, I have posted wrong link to the SRPM. http://helloworld1.fedorapeople.org/hcs_utils-1.2-0.1.rc4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 607015] New: Review Request: hcs_utils - A collection of useful python snippets for hcs's projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hcs_utils - A collection of useful python snippets for hcs's projects https://bugzilla.redhat.com/show_bug.cgi?id=607015 Summary: Review Request: hcs_utils - A collection of useful python snippets for hcs's projects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mrlhwlibe...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://helloworld1.fedorapeople.org/goobook.spec SRPM URL: http://helloworld1.fedorapeople.org/hcs_utils-1.2-0.1.rc4.fc13.noarch.rpm Description: This collection of python snippets includes: * memoize decorator (caching) * a storage class wrapping a dict. * unittest assert functions. * Functions for handling large JSON documents. * list_dir(path) –> (dirnames, filenames) * PID file locking * A synchronization decorator Note: This package is needed by goobook. Reviewers please review them together. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606288] Review Request: bfast - Blat-like Fast Accurate Search Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606288 --- Comment #4 from ELMORABITY Mohamed 2010-06-22 19:38:18 EDT --- Great :) The package looks technically good now :) Just two little things now: - it seems that a header (bfast/kseq.h) is licensed under the MIT license. Maybe the License tag should reflect this: License: GPLv2 and MIT - Maybe the project URL should point to http://bfast.sourceforge.net/. This URL redirects to the mediawiki link you used. It's just a nonmandatory suggestion, for convenience, in case the project decides to leave mediawiki ^^. Once the license corrected, I will approve this package :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 607016] Review Request: goobook - Abook-style interface for google contacts for mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607016 --- Comment #1 from Howard Ning 2010-06-22 19:38:19 EDT --- Sorry I have posted wrong link to the srpm. Here it is: http://helloworld1.fedorapeople.org/goobook-1.3-0.1.a1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 607015] Review Request: hcs_utils - A collection of useful python snippets for hcs's projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607015 --- Comment #1 from Howard Ning 2010-06-22 19:36:50 EDT --- goobook's review request is here: https://bugzilla.redhat.com/show_bug.cgi?id=607016 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 607016] New: Review Request: goobook - Abook-style interface for google contacts for mutt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: goobook - Abook-style interface for google contacts for mutt https://bugzilla.redhat.com/show_bug.cgi?id=607016 Summary: Review Request: goobook - Abook-style interface for google contacts for mutt Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mrlhwlibe...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL:http://helloworld1.fedorapeople.org/goobook.spec SRPM URL: http://helloworld1.fedorapeople.org/goobook-1.3-0.1.a1.fc13.noarch.rpm Description: Command-line interface to Google contacts. It includes * Searching contacts * Mutt integration (the same way as for abook) * Adding new contacts (very basic) Goobook depend on hcs_utils. I have made another package. I hope reviewers can review these two packages together. https://bugzilla.redhat.com/show_bug.cgi?id=607015 Note python-simplejson > 2.1.0 is needed. It is here: http://koji.fedoraproject.org/koji/buildinfo?buildID=179069 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606288] Review Request: bfast - Blat-like Fast Accurate Search Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606288 --- Comment #3 from Adam Huffman 2010-06-22 19:20:14 EDT --- There's a new release with the suggested fix at: http://verdurin.org.uk/~verdurin/fedora/reviews/bfast/bfast.spec and http://verdurin.org.uk/~verdurin/fedora/reviews/bfast/bfast-0.6.4d-4.fc13.src.rpm I've contacted upstream about this problem and the pthread patch. It builds for the i686 arch now: http://koji.fedoraproject.org/koji/taskinfo?taskID=2266299 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added CC||morphe...@fedoraproject.org --- Comment #4 from Nathanael Noblet 2010-06-22 17:40:21 EDT --- *** Bug 555059 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555059] Review Request: clamsmtp - 1.10-1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555059 Nathanael Noblet changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Comment #29 from Nathanael Noblet 2010-06-22 17:40:21 EDT --- *** This bug has been marked as a duplicate of bug 557011 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|DUPLICATE | --- Comment #3 from Nathanael Noblet 2010-06-22 17:40:07 EDT --- re-opening... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600638] Review Request: seed - GNOME JavaScript interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600638 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #9 from Michel Alexandre Salim 2010-06-22 17:17:56 EDT --- 2.31.1 has been built for Rawhide; 2.30.0 will be built for F-13 when gnome-js-common reaches stable updates -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606127] Review Request: colortool - useful tool for web-designers/graphic artists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606127 --- Comment #2 from Tobias Vogel 2010-06-22 16:32:32 EDT --- I am sorry for the incorrect build. Hopefully, this one is better... SPEC: http://colortool.googlecode.com/files/colortool-0-0.1.20102006svn0042.fc13.spec SRPM: http://colortool.googlecode.com/files/colortool-0-0.1.20102006svn0042.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606432] Review Request: ditaa - Diagrams Through Ascii Art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606432 Terje Røsten changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Terje Røsten 2010-06-22 16:15:50 EDT --- Thanks for a quick and nice review! New Package CVS Request === Package Name: ditaa Short Description: Diagrams Through Ascii Art Owners: terjeros Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606432] Review Request: ditaa - Diagrams Through Ascii Art
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606432
ELMORABITY Mohamed changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from ELMORABITY Mohamed 2010-06-22
16:06:36 EDT ---
Great, this should be OK :)
Here is the review.
* MUST: rpmlint must be run on every package. The output should be posted in
the review.
No serious warnings on binary and source packages (only warnings about man
pages not provided by upstream and false-positive mispelling)
* MUST: The package must be named according to the Package Naming Guidelines .
OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
* MUST: The package must meet the Packaging Guidelines
OK
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
OK (GPLv2 or more)
* MUST: The License field in the package spec file must match the actual
license.
OK
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
* MUST: The spec file must be written in American English.
OK
* MUST: The spec file for the package MUST be legible.
OK
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK (RPM source archive has the same MD5 sum than the one downloaded:
d7230273bf4c28c5029d350842278cf9)
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK (see koji links above)
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
N/A
* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A
* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A
* MUST: Packages must NOT bundle copies of system libraries.
OK
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
N/A
* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK
* MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK
* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK
* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
OK
* MUST: Each package must consistently use macros.
OK
* MUST: The package must contain code, or permissable content.
OK
* MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
N/A
* MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
OK
* MUST: Header files must be in a -devel package.
N/A
* MUST: Static libraries must be in a -static package.
N/A
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A
* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
N/A
* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #69 from Fedora Update System 2010-06-22 15:58:43 EDT --- josm-0-0.8.3329svn.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #70 from Fedora Update System 2010-06-22 16:00:48 EDT --- josm-0-0.8.3329svn.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/josm-0-0.8.3329svn.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 456353] Review Request: libffado - Free firewire audio driver library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456353 Brian Pepple changed: What|Removed |Added Flag|fedora-review?, | |needinfo?(bdpep...@gmail.co | |m) | --- Comment #21 from Brian Pepple 2010-06-22 15:01:18 EDT --- (In reply to comment #20) > Brian, are you still reviewing this package as you have set the fedora‑review > flag to "?" a while ago. Or shall I try to find another reviewer? We want to > have this package in by F-14 since we want to build jack2 with ffado support. > I'm fairly busy with work, and probably won't have time to review this so you should look for another reviewer. Sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508351
--- Comment #68 from Cédric OLIVIER 2010-06-22
14:54:27 EDT ---
Thanks a lot for this report.
jakarta-commons-codec is included in the official josm-tested.jar, but it seems
to be never used :
$ find . -name '*' -exec grep org.apache.commons.codec '{}' \; | wc -l
0
I removed josm-0-bzip2.patch and metadata-extractor-2.3.1-nosun.jar in
build.xml
Josm wrapper script has been improved as you suggested
$ rpmlint SRPMS/josm-0-0.8.3329svn.fc13.src.rpm
josm.src: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
josm.src: W: strange-permission josm-generate-tarball.sh 0755L
josm.src: W: invalid-url Source0: josm-0.3329svn.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
http://cedric.olivier.free.fr/rpms/josm-3329-8/josm.spec
http://cedric.olivier.free.fr/rpms/josm-3329-8/josm-0-0.8.3329svn.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 475661] Review Request: google-droid-fonts - General-purpose fonts released by Google as part of Android
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475661 --- Comment #8 from Nicolas Mailhot 2010-06-22 14:38:58 EDT --- BTW if you have time to spend on the Fedora package, co-maintainers are welcome there too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606071 --- Comment #2 from Fabian Affolter 2010-06-22 14:41:05 EDT --- My bad. Next time I should check the upstream bug tracker first and not let the reviewer find bugs. Sorry for that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606127] Review Request: colortool - useful tool for web-designers/graphic artists
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=606127
Michael Schwendt changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #1 from Michael Schwendt 2010-06-22 14:34:34
EDT ---
Only a brief look at the spec:
> Release: 20102006svn%{?dist}
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
> Requires: qt
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> %description
The guidelines are not very specific, but you are supposed to construct _full
sentences_ in the description. Would not be a blocker criterion, though.
> /usr/bin/colortool
> /usr/share/pixmaps/colortool.xpm
> /usr/share/applications/ColorTool.desktop
> /usr/share/applnk/Graphics/ColorTool.kdelnk
> /usr/share/colortool/translations/*
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
and
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> /usr/share/colortool/translations/*
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606019] Review Request: python-distribute - Distribute is a drop-in replacement for Setuptools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606019 Andrew Colin Kissa changed: What|Removed |Added CC||and...@topdog.za.net --- Comment #5 from Andrew Colin Kissa 2010-06-22 14:31:56 EDT --- If python-setuptools is already distribute based, why do we need a python-distribute in fedora ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599720] Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599720 --- Comment #3 from Lev Shamardin 2010-06-22 14:07:05 EDT --- I've picked CherryPy and Twisted as references because they do essentially the same thing: they provide a web-server, which can be used as a python library, and at the same time they contribute some commands to /usr/bin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 456353] Review Request: libffado - Free firewire audio driver library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456353 Orcan 'oget' Ogetbil changed: What|Removed |Added Flag||needinfo?(bdpep...@gmail.co ||m) --- Comment #20 from Orcan 'oget' Ogetbil 2010-06-22 13:51:04 EDT --- Brian, are you still reviewing this package as you have set the fedora‑review flag to "?" a while ago. Or shall I try to find another reviewer? We want to have this package in by F-14 since we want to build jack2 with ffado support. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599720] Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599720 --- Comment #2 from Kevin Fenzi 2010-06-22 13:40:26 EDT --- Well, I don't know that I consider this to be a python add-on or library. It provides a /usr/sbin/Spawning26 command, so it seems to me to be an application that happens to be written in python. Does that make sense? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599715] Review Request: python26-eventlet - Highly concurrent networking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599715 Kevin Fenzi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Kevin Fenzi 2010-06-22 13:36:00 EDT --- Thanks! I can apply the patch here as well before import to build the docs. New Package CVS Request === Package Name: python26-eventlet Short Description: Highly concurrent networking library Owners: kevin Branches: EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505354 --- Comment #10 from Patrick Monnerat 2010-06-22 13:34:38 EDT --- No problem: I'm myself on vacation this week ! Many thanks for your review, Spot. New Package CVS Request === Package Name: php-captchaphp Short Description: PHP very user-friendly CAPTCHA Owners: monnerat Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505354 Patrick Monnerat changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 471231] Review Request: WebCalendar - Single/multi-user web-based calendar application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471231 Patrick Monnerat changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #67 from Alex Lancaster 2010-06-22 13:26:18 EDT --- Likewise issues with commons-codec (provided within the jakarta-commons-codec package): $ jar tvf josm.jar |grep apache|head -10 0 Tue Jan 01 00:00:00 EST 1980 org/apache/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/ 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryDecoder.class 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryEncoder.class 588 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/CharEncoding.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Decoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/DecoderException.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Encoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/EncoderException.class $ jar tvf /usr/share/java/commons-codec.jar|grep apache|head -10 0 Tue Jan 01 00:00:00 EST 1980 org/apache/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/ 0 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/ 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryDecoder.class 268 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/BinaryEncoder.class 588 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/CharEncoding.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Decoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/DecoderException.class 248 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/Encoder.class 822 Tue Jan 01 00:00:00 EST 1980 org/apache/commons/codec/EncoderException.class -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 --- Comment #33 from Fedora Update System 2010-06-22 13:19:08 EDT --- openvas-client-3.0.0-7.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578480] Review Request: spectrum - XMPP transport/gateway
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||spectrum-0.3-0.9.git2010061 ||4.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||openvas-client-3.0.0-7.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578480] Review Request: spectrum - XMPP transport/gateway
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 --- Comment #53 from Fedora Update System 2010-06-22 13:18:41 EDT --- spectrum-0.3-0.9.git20100614.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #66 from Alex Lancaster 2010-06-22 13:17:38 EDT --- Just to show the duplication: $ jar tvf /usr/share/java/josm.jar |grep metadata|head -10 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/ 1128 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/DefaultTagDescriptor.class 12498 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Directory.class 1947 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Metadata.class 695 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataException.class 247 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataReader.class 2936 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/SampleUsage.class 1801 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Tag.class 574 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/TagDescriptor.class 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/exif/ $ jar tvf /usr/share/java/metadata-extractor.jar|grep metadata|head -10 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/ 1128 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/DefaultTagDescriptor.class 12498 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Directory.class 1947 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Metadata.class 695 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataException.class 247 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/MetadataReader.class 2936 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/SampleUsage.class 1801 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/Tag.class 574 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/TagDescriptor.class 0 Tue Jan 01 00:00:00 EST 1980 com/drew/metadata/exif/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 Fedora Update System changed: What|Removed |Added Fixed In Version|openvas-client-3.0.0-7.fc13 |openvas-client-3.0.0-7.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 --- Comment #34 from Fedora Update System 2010-06-22 13:21:12 EDT --- openvas-client-3.0.0-7.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #43 from Fedora Update System 2010-06-22 13:18:18 EDT --- wicd-1.7.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 Fedora Update System changed: What|Removed |Added Fixed In Version|wicd-1.7.0-1.fc12 |wicd-1.7.0-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599316] Review Request: input-pad - Input Pad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 --- Comment #19 from Fedora Update System 2010-06-22 13:15:32 EDT --- input-pad-0.1.0.20100622-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100622-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #65 from Alex Lancaster 2010-06-22 13:16:18 EDT --- (In reply to comment #64) > (In reply to comment #62) > > Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger > > than the one generated by the authors (4 MB)? > Because this package is not valid, accorded to the guidelines. It embeds > dependencies, whereas it is forbidden: > > https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software That shouldn't be the case according to the review in comment #49, it claims: "+ The package does NOT bundle copies of system libraries." It appears that the reviewer may have missed that jars were still being bundled, even though it seems that from comment #2 some bundled jars were identified and (apparently) removed around comment #4, but some may have been added since. > 4) add ant and metadata-extractor as Requires. Actually the installation pulls in the metadata-extractor as a separate package so the "Requires" appear OK, it's just that the .class files for that package are duplicated inside josm.jar, so apparently the packager didn't remove them properly from the created josm.jar This needs to be fixed before this bug is closed as it appears the package passed review prematurely. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599316] Review Request: input-pad - Input Pad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 --- Comment #18 from Fedora Update System 2010-06-22 13:12:44 EDT --- input-pad-0.1.0.20100622-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100622-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #42 from Fedora Update System 2010-06-22 13:13:27 EDT --- wicd-1.7.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 605808] Review Request: gtick - A Graphical Metronome Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605808 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Fedora Update System 2010-06-22 13:12:26 EDT --- gtick-0.4.2-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gtick'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/gtick-0.4.2-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 Fedora Update System changed: What|Removed |Added Fixed In Version|wicd-1.7.0-1|wicd-1.7.0-1.fc12 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599720] Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599720 Lev Shamardin changed: What|Removed |Added CC||shamar...@gmail.com --- Comment #1 from Lev Shamardin 2010-06-22 13:10:21 EDT --- May be this is a bit late, but: don't you think that this package should be named "python26-spawning"? (and it's counterpart in Fedora/EPEL5-python24 to be renamed to python-spawning?) Compare to CherryPy or Twisted: the packages are named python-cherrypy and python-twisted-blah, so this renaming should make package naming more consistent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599715] Review Request: python26-eventlet - Highly concurrent networking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599715 --- Comment #8 from Lev Shamardin 2010-06-22 13:04:10 EDT --- I think it does not worth to wait for python-sphinx. I've created this bug (https://bugzilla.redhat.com/show_bug.cgi?id=606893) to make sure that the patch will be applied :) Now for the formal review part. MUST items: * OK - rpmlint outputs no errors, all warnings can be ignored. See at the end of the review. * OK - package is named according to guidelines. * OK - package spec file is named correctly. * OK - package does meet the packaging guidelines. * OK - package licensed under MIT License * OK - License field in the spec file matches the actual license. * OK - License is included to the package. * OK - spec file is written in American English. * OK - spec file is legible. * OK - the sources for the package match the upstream. 95d01864a053ec67e08d57fc369152f8 eventlet-0.9.9.tar.gz 95d01864a053ec67e08d57fc369152f8 eventlet-0.9.9.tar.gz.orig * OK - checked that package does compile on i386 and x86_64. * OK - architectures where the package does not work are unknown. * OK - package lists sane BuildRequires. * OK - package does not use locales. * OK - package does not contain dynamic libraries. * OK - package does not bundle copies of system libraries. * OK - package is not relocatable. * OK - package owns all directories it creates. * OK - %files listings are correct. * OK - permissons on files are set correctly, %defattr is included in all %files sections. * OK - package contains code or permissible content. * OK - large documentation is stripped off (provided in fedora builds in a separate subpackage). * OK - package %doc contents does not affect it's runtime. * OK - package does not provide header files. * OK - package does not provided static libraries. * OK - package does not provide libraries with a suffix. * OK - package does not have a -devel subpackage. * OK - package does not contain .la files. * OK - package does not contain a GUI application. * OK - package does not own files or directories owned by other packages. * OK - all file names are UTF-8. SHOULD items: * OK - the package builds in mock. * OK - the pacakge functions as described. * OK - the package does not use scriplets. * OK - the package does not provide pkgconfig files. * OK - the package does not have file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin. rpmlint output: $ rpmlint python26-eventlet.spec python26-eventlet-0.9.9-1.el5.src.rpm python26-eventlet-0.9.9-1.el5.noarch.rpm python26-eventlet.src: W: spelling-error %description -l en_US scalability -> availability, sociability, inviolability python26-eventlet.src: W: spelling-error %description -l en_US io -> oi, Io, ii python26-eventlet.src: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, subroutines python26-eventlet.noarch: W: spelling-error %description -l en_US scalability -> availability, sociability, inviolability python26-eventlet.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii python26-eventlet.noarch: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, subroutines 2 packages and 1 specfiles checked; 0 errors, 6 warnings. All can be ignored. I'm approving this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599715] Review Request: python26-eventlet - Highly concurrent networking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599715 Lev Shamardin changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 ELMORABITY Mohamed changed: What|Removed |Added CC||pikachu.2...@gmail.com --- Comment #64 from ELMORABITY Mohamed 2010-06-22 12:30:33 EDT --- (In reply to comment #62) > Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger > than the one generated by the authors (4 MB)? Because this package is not valid, accorded to the guidelines. It embeds dependencies, whereas it is forbidden: https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software Upstream voluntarily embeds metadata-extractor.jar (see build.xml). This should not be the case. Moreover, I don't understand why you also embed commons-codec.jar and ant.jar with your patch josm-0-bzip2.patch. Please don't embed dependencies, you'd better modify your wrapper to set these dependencies in the classpath. By the way, is commons-codec really required? If ant is called in the code, I can't find any call to commons-codec. So: 1) remove the patch josm-0-bzip2.patch 2) try to remove (with a patch for example) the following line in build.xml: 3) replace your wrapper script with the one attached in this review (josm.wrapper) 4) add ant and metadata-extractor as Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #63 from ELMORABITY Mohamed 2010-06-22 12:28:49 EDT --- Created an attachment (id=426002) --> (https://bugzilla.redhat.com/attachment.cgi?id=426002) Wrapper script for josm, with classpath definition -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589482] Review Request: perl-IO-Compress-Lzma - Read and write lzma compressed data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589482 --- Comment #6 from Fedora Update System 2010-06-22 11:36:30 EDT --- perl-IO-Compress-Lzma-2.027-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-IO-Compress-Lzma-2.027-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 407571] Review Request: tinyxml - A simple, small, C++ XML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=407571 Rakesh Pandit changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE | Flag|fedora-cvs+ |fedora-cvs? --- Comment #20 from Rakesh Pandit 2010-06-22 11:30:10 EDT --- This is request for EL-6 branch. Once cvs is done I will close it again. Thanks, New Package CVS Request === Package Name: tinyxml Short Description: A simple, small, C++ XML parser Owners:rakesh Branches: EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 405171] Review Request: CriticalMass - SDL/OpenGL space shoot'em up game also known as critter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=405171 Bug 405171 depends on bug 407571, which changed state. Bug 407571 Summary: Review Request: tinyxml - A simple, small, C++ XML parser https://bugzilla.redhat.com/show_bug.cgi?id=407571 What|Old Value |New Value Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 554647] Review Request: wbfs-manager - Manager for Nintendo RAW File System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554647 Jussi Lehtola changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|177841(FE-NEEDSPONSOR), |201449(FE-DEADREVIEW) |182235(FE-Legal)| Resolution||WONTFIX Flag|fedora-review? | --- Comment #11 from Jussi Lehtola 2010-06-22 11:27:02 EDT --- No activity in 5 months, closing review. Removing FE-LEGAL and FE-NEEDSPONSOR, adding FE-DEADREVIEW. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570424] Review Request: transmission-remote-cli - A console client for the Transmission BitTorrent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570424 Ville Skyttä changed: What|Removed |Added CC||ville.sky...@iki.fi --- Comment #15 from Ville Skyttä 2010-06-22 11:28:07 EDT --- Is it intentional that there are no files (except the ones created while doing the branch) for this in devel branch in CVS? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600835] Review Request: modplugtools - Command line mod music players
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600835 Ville Skyttä changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Ville Skyttä 2010-06-22 11:05:01 EDT --- New Package CVS Request === Package Name: modplugtools Short Description: Command line mod music players Owners: scop Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #62 from Benjamín Valero Espinosa 2010-06-22 10:59:51 EDT --- (In reply to comment #61) > It's done : > > https://admin.fedoraproject.org/updates/josm-0-0.7.3329svn.fc13 This works! Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger than the one generated by the authors (4 MB)? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606714] Review Request: eekboard - A Virtual Keyboard for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606714 Chen Lei changed: What|Removed |Added CC||supercyp...@gmail.com --- Comment #1 from Chen Lei 2010-06-22 10:54:40 EDT --- One suggestion: It'll be better to merge libxxx subpackages to a -libs subpackage, libxxx subpackage looks like the debian style. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #61 from Cédric OLIVIER 2010-06-22 10:41:19 EDT --- It's done : https://admin.fedoraproject.org/updates/josm-0-0.7.3329svn.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #60 from Leif Gruenwoldt 2010-06-22 10:15:00 EDT --- Trying josm from fedora updates-testing repo this morning On startup I get: "$ josm Warning: the revision file '/REVISION' is missing. Warning: no preference 'proxy.policy' found. The proxy will not be used." The side effect of this seems to be that the splash screen on startup says "Version UNKNOWN" and then the intial intro help window pane says "Strange version - You should update!" FYI, $ rpm -q josm josm-0-0.6.3329svn.fc13.noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557969] Review Request: sugar-socialcalc - A spreadsheet activity for the Sugar environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557969 Sebastian Dziallas changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DEFERRED --- Comment #13 from Sebastian Dziallas 2010-06-22 10:04:18 EDT --- There are a few things apparently being moved around with regard to the JaveScript backend this relies on. I'm closing this until we've an appropriate strategy for Sugar on a Stick to move forward with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 Sebastian Dziallas changed: What|Removed |Added Summary|Review Request: jbcrypt - |Review Request: jBCrypt - |Strong password hashing for |Strong password hashing for |Java|Java --- Comment #11 from Sebastian Dziallas 2010-06-22 09:38:54 EDT --- (In reply to comment #10) > Sebastian? I suppose you don't mind the naming that much...so one more release > number with changed name and test run? I can't exactly recall why I used lowercase-only letters in the first place, so yes, I'm more than alright with changing it. It's also compiling the test cases now. :) Spec URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt-0.3-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] Review Request: jBCrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594806 --- Comment #12 from Sebastian Dziallas 2010-06-22 09:39:44 EDT --- New Package CVS Request === Package Name: jBCrypt Short Description: Strong password hashing for Java Owners: sdz Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 475661] Review Request: google-droid-fonts - General-purpose fonts released by Google as part of Android
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475661 Mark Chappell changed: What|Removed |Added CC||trem...@tremble.org.uk Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from Mark Chappell 2010-06-22 09:38:53 EDT --- Package Change Request == Package Name: google-droid-fonts New Branches: EL-6 Owners: tremble nim listed as welcoming EPEL maintainers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606759] New: Review Request: nvi - 4.4BSD re-implementation of vi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nvi - 4.4BSD re-implementation of vi https://bugzilla.redhat.com/show_bug.cgi?id=606759 Summary: Review Request: nvi - 4.4BSD re-implementation of vi Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mc...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://mcepl.fedorapeople.org/rpms/nvi.spec SRPM URL: http://mcepl.fedorapeople.org/rpms/nvi-1.81.6-1.el6.src.rpm Description: Vi is the original screen based text editor for Unix systems. It is considered the standard text editor, and is available on almost all Unix systems. Nvi is intended as a "bug-for-bug compatible" clone of the original BSD vi editor. As such, it doesn't have a lot of snazzy features as do some of the other vi clones such as elvis and vim. However, if all you want is vi, this is the one to get. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537640] Review Request: pdfmod - A simple application for modifying PDF documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537640 --- Comment #10 from Sebastian Dziallas 2010-06-22 08:33:16 EDT --- That's awesome, thank you! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537640] Review Request: pdfmod - A simple application for modifying PDF documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537640 --- Comment #9 from Claudio Rodrigo Pereyra DIaz 2010-06-22 07:58:18 EDT --- Yes I will try go to finish, and correct the fails, and split the dependencies. I will update this request soon with necesary changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604500 --- Comment #5 from fujiwara 2010-06-22 06:39:33 EDT --- After I investigated 2) suggestion, I found ibus-libs doesn't have the dependency of ibus. Now I accepted the 2) suggestion. 1) and 3) seem recommendations but not requirements in Fedora packaging. http://fedoraproject.org/wiki/PackagingGuidelines#Pkgconfig_Files Updated the spec file: http://github.com/fujiwarat/ibus-input-pad/commit/09563be22d1936b1966c19a52b765621beb05a71 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/ibus-input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/ibus-input-pad-0.1.0.20100611-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
