[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612719 --- Comment #22 from Terje Røsten terje...@phys.ntnu.no 2010-08-10 02:59:11 EDT --- Thanks for the tip, Jason. Package Change Request == Package Name: recoll New Branches: F12 Owners: terjeros InitialCC: Forgot F12 branch in the initial request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622272 --- Comment #7 from Chen Lei supercyp...@gmail.com 2010-08-10 03:32:00 EDT --- (In reply to comment #5) Thanks for the quick review. I know about buildroot, but as far as EL-5 exists, as I like to keep the same spec for all branch when possible, I prefer to keep it. Can mysql-connect-c++ work on EL5? As of MySQL Connector/C++ version 1.1.0 it is necessary to have the Boost C++ libraries 1.34.0 or newer installed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620177] Review Request: uprof - Profiling toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620177 Adel Gadllah adel.gadl...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622272 --- Comment #8 from Remi Collet fed...@famillecollet.com 2010-08-10 03:39:41 EDT --- Arg, you're right (I should have check before)... boost-1.41 is in RHEL-6beta2 New Package SCM Request === Package Name: mysql-connector-c++ Short Description: MySQL database connector for C++ Owners: remi Branches: F-13 F-14 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622270] Review Request: elementary-icon-theme - icons from the Elementary Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622270 --- Comment #6 from Tajidin Abdullah tajidin...@archlinux.us 2010-08-10 04:15:04 EDT --- waiting for response from upstream in regards to changing name of source package to reflect version number. yes that tip did work German thanks for that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #11 from Tajidin Abdullah tajidin...@archlinux.us 2010-08-10 04:16:46 EDT --- well waiting for response from upstream about renaming the source package so in holding pattern til then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617592] Review Request: libaccounts-qt - Library for handling the account storage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617592 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617610] Review Request: messagingframework - Qt Messaging Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617610 Bug 617610 depends on bug 617592, which changed state. Bug 617592 Summary: Review Request: libaccounts-qt - Library for handling the account storage https://bugzilla.redhat.com/show_bug.cgi?id=617592 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617610] Review Request: messagingframework - Qt Messaging Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617610 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #1 from Chen Lei supercyp...@gmail.com 2010-08-10 04:30:32 EDT --- Now, messagingframework is ready for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621898
--- Comment #8 from Petr Pisar ppi...@redhat.com 2010-08-10 04:57:29 EDT ---
New spec and SRPM uploaded:
Spec URL: http://ppisar.fedorapeople.org/libwbxml/libwbxml.spec
SRPM URL:
http://ppisar.fedorapeople.org/libwbxml/libwbxml-0.10.8-1.fc13.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2390930
$ rpmlint libwbxml.spec ../SRPMS/libwbxml-0.10.8-1.fc13.src.rpm
../RPMS/x86_64/libwbxml-*
libwbxml-devel.x86_64: W: no-documentation
libwbxml.x86_64: W: obsolete-not-provided wbxml2
libwbxml.x86_64: W: no-manual-page-for-binary xml2wbxml
libwbxml.x86_64: W: no-manual-page-for-binary wbxml2xml
4 packages and 1 specfiles checked; 0 errors, 4 warnings.
Diff to old spec file:
--- libwbxml.spec 2010-08-09 09:59:53.0 +0200
+++ /home/petr/rpmbuild/SPECS/libwbxml.spec 2010-08-10 10:47:49.005302937 +0200
@@ -12,7 +12,6 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: cmake, expat-devel, perl
-Provides: wbxml2 = %{version}-%{release}
Obsoletes: wbxml2 = 0.9.3
%description
@@ -43,24 +42,21 @@
%build
# Upstream does not support in-source-directory building
-SRCDIR=$PWD
-%define builddir ../build
-rm -rf %{builddir}
-mkdir %{builddir}
-cd %{builddir}
-%cmake $SRCDIR
-make %{?_smp_mflags}
+mkdir -p %{_target_platform}
+pushd %{_target_platform}
+%cmake ..
+popd
+make -C %{_target_platform} %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-cd %{builddir}
-make install DESTDIR=$RPM_BUILD_ROOT
+make -C %{_target_platform} install/fast DESTDIR=$RPM_BUILD_ROOT
rm -r $RPM_BUILD_ROOT/usr/share/doc/%{name}
%check
-cd %{builddir}
+cd %{_target_platform}
ctest
@@ -77,17 +73,16 @@
%defattr(-,root,root,-)
%doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS
TODO
%{_bindir}/*
-%{_libdir}/libwbxml2.so.0*
+%{_libdir}/libwbxml2.so.*
%files devel
%defattr(-,root,root,-)
-%doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS
TODO
%{_includedir}/*
%{_libdir}/libwbxml2.so
%{_libdir}/pkgconfig/libwbxml2.pc
%changelog
-* Fri Aug 06 2010 Petr Pisar ppi...@redhat.com - 0.10.8-1
+* Tue Aug 10 2010 Petr Pisar ppi...@redhat.com - 0.10.8-1
- 0.10.8 import
- based on and obsoletes wbxml2-0.9.2-16
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619518] Review Request: aajohan-comfortaa-fonts - Modern style true type font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619518 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 512323] Review Request: mingw32-gc - MinGW Windows port of the gc library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512323 Felipe Contreras felipe.contre...@gmail.com changed: What|Removed |Added CC||felipe.contre...@gmail.com --- Comment #2 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10 06:31:15 EDT --- This package needs to be separated into: mingw32-gc, mingw32-gc-devel, mingw32-gc-static, and so on. Also, what's the deal with --disable-static? Is static really disabled or not? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532163] Review Request: crosstool-ng - Build toolchains for cross-compilation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532163 Felipe Contreras felipe.contre...@gmail.com changed: What|Removed |Added CC||felipe.contre...@gmail.com --- Comment #4 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10 06:37:37 EDT --- Looks like you are missing $RPM_OPT_FLAGS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604971] Review Request: jwm - Joe's Window Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604971 Felipe Contreras felipe.contre...@gmail.com changed: What|Removed |Added CC||felipe.contre...@gmail.com --- Comment #3 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10 06:46:49 EDT --- Looks like it's missing $RPM_OPT_FLAGS. Also, since it's supposed to work on GNOME, shouldn't it have a jwm-gnome.desktop? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474802] Review Request: vacation - Automatic mail answering program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474802 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #23 from Nils Philippsen nphil...@redhat.com 2010-08-10 06:58:34 EDT --- Closing this since CVS is done. Till, that would've been your job ;-). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852
Felipe Contreras felipe.contre...@gmail.com changed:
What|Removed |Added
CC||felipe.contre...@gmail.com
--- Comment #10 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10
07:05:57 EDT ---
(In reply to comment #9)
%define gstreamer_version 0.10
%define dbus-glib_version 0.70
BuildRequires: gstreamer-devel gstreamer_version
BUildRequires: dbus-glib-devel dbus-glib_version
Requires: gstreamer gstreamer_version
This won't work. Did it even build and install?
Above you defined two macros, but below you didn't use them. So:
BuildRequires: gstreamer-devel %{gstreamer_version}
BUildRequires: dbus-glib-devel %{dbus-glib_version}
Requires: gstreamer %{gstreamer_version}
Further, using '' and not '=' is somewhat unclear. GStreamer is still in the
0.10 series for a long time, so would 0.10 be sufficient? Or does it strictly
need to be 0.10?
There is no GStreamer 0.10; should be =.
I recommend:
BuildRequires: gstreamer-devel = 0.10
BUildRequires: dbus-glib-devel = 0.70
This is not needed:
Requires: gstreamer %{gstreamer_version}
Because the binary would be linked to libgstreamer, so that would be automatic.
Obsoletes: epris 0.2
A comment would be good here. There is no such epris provided in the Fedora
package collection. *This* package is called epris. What's the reason for
the
Obsoletes tag?
Yeah, this should go away.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604971] Review Request: jwm - Joe's Window Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604971 --- Comment #4 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10 07:10:34 EDT --- (In reply to comment #3) Looks like it's missing $RPM_OPT_FLAGS. Er, %configure deals with that, sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619012] Review Request: cagibi - SSDP (UPnP discovery) cache/proxy daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619012 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-08-10 07:16:58 EDT --- cagibi-0.1.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/cagibi-0.1.1-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619012] Review Request: cagibi - SSDP (UPnP discovery) cache/proxy daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619012 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-08-10 07:17:48 EDT --- cagibi-0.1.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/cagibi-0.1.1-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619012] Review Request: cagibi - SSDP (UPnP discovery) cache/proxy daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619012 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-08-10 07:18:33 EDT --- cagibi-0.1.1-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/cagibi-0.1.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611454] Review Request: python-bcrypt - Python bindings for OpenBSD's Blowfish password hashing code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611454 --- Comment #8 from David Riches davi...@ultracar.co.uk 2010-08-10 07:25:12 EDT --- Thanks for the comments, I'm not sure on the %name issue though, as if I remove the tag, and manually add it to setup, then rpmlint fails :-/ so I have kept that for now, and see if there are any more comments/suggestions. Regarding the rest, I have renamed the package, removed the CFLAGS, updated the changelog, buildrequires and included the latest source. Thanks again for all the feedback, its much appreciated. SPEC: http://dcr226.fedorapeople.org/SPECS/py-bcrypt.spec SRPM: http://dcr226.fedorapeople.org/SRPMS/py-bcrypt-0.2-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474802] Review Request: vacation - Automatic mail answering program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474802 --- Comment #24 from Till Bubeck t.bub...@reinform.de 2010-08-10 07:42:34 EDT --- Oh, sorry. I didn't know, that I have to close it, although it is now quite obvious... :-) Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618985] Review Request: swift - XMPP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618985 Jan Kaluža jkal...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #13 from Jan Kaluža jkal...@redhat.com 2010-08-10 07:40:01 EDT --- Thanks for the review and Git branch. Everything is done, so I'm closing this review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 610794] Review Request: meego-panel-zones - Meego zones panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610794 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #17 from Peter Robinson pbrobin...@gmail.com 2010-08-10 08:43:29 EDT --- build for rawhide. Thanks Jonathon for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618761] Review request: Gold Allocation Manager for HPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618761 Jessica Jones fed...@zaniyah.org changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618761] Review request: Gold Allocation Manager for HPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618761 --- Comment #14 from Jessica Jones fed...@zaniyah.org 2010-08-10 08:58:41 EDT --- New Package SCM Request === Package Name: gold Short Description: allocation manager Owners: zaniyah Branches: f13 f14 el6 InitialCC: zaniyah -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #76 from Jessica Jones fed...@zaniyah.org 2010-08-10 09:02:45 EDT --- (In reply to comment #75) (In reply to comment #74) Output from the Fedora rpmlint - newer than the one on RHEL, which I used before, and also more fussy and used by everyone else: coot.src: W: spelling-error %description -l en_US gui - GUI, goo, gi coot.src: W: spelling-error %description -l en_US mmdb - mm db, mm-db, Mme coot.src: W: spelling-error %description -l en_US modelling - modeling, model ling, model-ling Fixed these. coot.src:171: E: files-attr-not-set Oops, fixed that. The error (files-attr-not-set) will need fixing too. The SRPM is still uploading to koji for the scratch build so I will post the results of that later. I ran a koji scratch build as well on f14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2382998 Great. Also, I received word that upstream is working on the make check problem for 0.6.2, so once that is released I'll try again. Don't suppose you have any idea how fast they might move on this? It's not a show-stopper anyway, but it would be good to get it sorted. Spec URL: http://www.stanford.edu/~fenn/packs/coot.spec SRPM URL: http://www.stanford.edu/~fenn/packs/coot-0.6.1-3.20100127svn2740.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518546] Review Request: libva - VAAPI video playback acceleration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518546 --- Comment #37 from Bastien Nocera bnoc...@redhat.com 2010-08-10 09:05:03 EDT --- (In reply to comment #23) At a minimum, the i965 code in this package is not acceptable for inclusion in Fedora. That begs the question of whether it would be better to separate it out or simply push it all to rpmfusion. Could you explain why? The code there seems to be a demuxer, and at worst, a simple parser, which matches things we already ship in gstreamer-plugins-bad-free (we ship MPEG demuxers, parsers, but not decoders). Most of that code seems to me like it's just pushing bits of data to the GPU, nothing more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621559] Review Request: perl-Data-Properties - Perl equivalent of java.util.Properties
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621559 --- Comment #2 from Jessica Jones fed...@zaniyah.org 2010-08-10 09:15:41 EDT --- http://search.cpan.org/dist/Data-Properties/ - License: UNKNOWN is not very helpful. I've sent an email to the upstream author at the address mentioned in the source and asked for clarification. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 Jessica Jones fed...@zaniyah.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #77 from Jessica Jones fed...@zaniyah.org 2010-08-10 09:20:56 EDT --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622820] New: Review Request: acgvision-agent - Monitoring client for ACGVision
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: acgvision-agent - Monitoring client for ACGVision https://bugzilla.redhat.com/show_bug.cgi?id=622820 Summary: Review Request: acgvision-agent - Monitoring client for ACGVision Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: debay.r...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent.spec SRPM URL: http://launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent-5.1.6-1.fc15.src.rpm Description: Hi all, I just finished packaged acgvision-agent. Could anyone review my package so that I could get it onto Fedora repositories? ACGVision is a monitoring sofware (like nagios) and this is the client software. It's my really first fedora package (and RPM)so please tell me about anything s going wrong with my package. Thanks Rémi Debay -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622820] Review Request: acgvision-agent - Monitoring client for ACGVision
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622820 Rémi Debay debay.r...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622630] Review Request: pcalc - A program for calculating and converting between different bases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622630 Xia Shing Zee xiash...@gmail.com changed: What|Removed |Added CC||fedora-package-rev...@redha ||t.com, nott...@redhat.com Component|distribution|Package Review AssignedTo|nott...@redhat.com |nob...@fedoraproject.org QAContact|nott...@redhat.com |extras...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621898 --- Comment #9 from Chen Lei supercyp...@gmail.com 2010-08-10 09:56:06 EDT --- The spec is sane except one minor issue: # no line terminator, add one echo THANKS echo BUGS You should either move those two lines or keep timestamps after modifying those two files, otherwise it'll cause multilib conflict. Since no line terminator is not a warning or error in rpmlint, I suggest to simply move those lines from spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622820] Review Request: acgvision-agent - Monitoring client for ACGVision
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622820 Rémi Debay debay.r...@gmail.com changed: What|Removed |Added URL||http://launchpad.net/acgvis ||ion-agent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527250] Review Request: dumpet - A tool to dump and debug bootable CD images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527250 Peter Jones pjo...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Peter Jones pjo...@redhat.com 2010-08-10 10:11:35 EDT --- SPECS/dumpet.spec: W: no-buildroot-tag I'm ignoring this because it's actually a worst practice not a best practice. SPECS/dumpet.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) And I'm not fixing this now because it's completely inconsequential, and this isn't a blocker bug so checking in such fixes is not allowed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622820] Review Request: acgvision-agent - Monitoring client for ACGVision
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622820 Rémi Debay debay.r...@gmail.com changed: What|Removed |Added See Also||https://launchpad.net/bugs/ ||590988 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621898 --- Comment #10 from Petr Pisar ppi...@redhat.com 2010-08-10 10:30:15 EDT --- I choose to preserve the time stamps. I replaced spec and SRPM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622566] create slf4j branch in epel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622566 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532163] Review Request: crosstool-ng - Build toolchains for cross-compilation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532163 --- Comment #5 from Oron Peled o...@actcom.co.il 2010-08-10 10:45:03 EDT --- Thanks, 1. I'll add it when packaging new upstream version (they just released 1.8.x) 2. Do you want to review it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 520808] Review Request: slf4j - Simple Logging Facade for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520808 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Dennis Gilmore den...@ausil.us 2010-08-10 10:44:54 EDT --- Package Change Request == Package Name: slf4j New Branches: el5 el6 Owners: shughes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622293] Review Request: erlang-erlydtl - Django Templates for Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622293 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Version|13 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621713
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-08-10
10:56:01 EDT ---
Okay.
One additional comment:
--
cp -R ./Faenza/ $RPM_BUILD_ROOT%{_datadir}/icons
cp -R ./Faenza-Dark/ $RPM_BUILD_ROOT%{_datadir}/icons
--
- Please change this to cp -a to keep timestamps on installed
files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
---
This pacakge (faenza-icon-theme) is APPROVED by mtasaka
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617405] Review Request: poezio - An IRC-like jabber (XMPP) console client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617405
Christoph Wickert cwick...@fedoraproject.org changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Christoph Wickert cwick...@fedoraproject.org 2010-08-10
10:53:32 EDT ---
Sorry it took so long.
OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
poezio.noarch: W: no-manual-page-for-binary poezio
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv3
only)
OK - MUST: License field in spec file matches the actual license
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
4cca396fe4d520f9884a65c546100b76
OK - MUST: successfully compiles and builds into binary rpms on x86_64 (noarch
package)
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}.
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
N/A - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: all filenames valid UTF-8
SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are used, those scriptlets must be sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
N/A - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Other items:
OK - latest stable version
OK - SourceURL valid
Some minor issues. None of them is really important, this more meant to be a
little education for Tom.
Please change the %global at the beginning of the spec as per
https://fedoraproject.org/wiki/Packaging:Python#Macros
Please don't use articles like A or An in the summary, just IRC-like
jabber (XMPP) console client is fine.
mkdir -p %{buildroot}%{_datadir}/%{name}
mkdir -p %{buildroot}%{_datadir}/%{name}/data
mkdir -p %{buildroot}%{_datadir}/%{name}/src
at least the first line is not necessary. The whole thing could be boiled down
to
mkdir -p %{buildroot}%{_datadir}/%{name}/{data,src}
Please preserve timestamps during %install with install -p, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
Also preserve the timestamps when removing the shebangs from files, see
[Bug 532163] Review Request: crosstool-ng - Build toolchains for cross-compilation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532163 --- Comment #6 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10 11:00:45 EDT --- Well, I already reviewed this, I don't see anything else wrong. BTW. I'm no packager. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 479598] Review Request: aopalliance - AOP offers a better solution to many problems than do existing technologies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479598 Chen Lei supercyp...@gmail.com changed: What|Removed |Added CC||supercyp...@gmail.com --- Comment #26 from Chen Lei supercyp...@gmail.com 2010-08-10 11:23:59 EDT --- (In reply to comment #24) So is anyone still working on this and seeing any type of progress? If not I'm going to close this. Would mind to contact Cédric Beust? It seems he is still active now. http://beust.com/weblog/ http://twitter.com/cbeust -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608069] Review Request: tango - standard library for D language of d1 specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #64 from Kevin Fenzi ke...@tummy.com 2010-08-10 12:02:40 EDT --- It was only pushed out to updates-testing this morning (2010-08-10). ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #11 from hannes johannes.l...@googlemail.com 2010-08-10 12:17:33 EDT --- Hello, my fas username is: hannes I'll fix that warning when I get home and will upload a version without that code snippet. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Tajidin Abdullah tajidin...@archlinux.us changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Tajidin Abdullah tajidin...@archlinux.us 2010-08-10 12:35:04 EDT --- New Package SCM Request === Package Name: faenza-icon-theme Short Description: icon theme for Equinox GTK theme Owners: tajidinabd Branches: f12 f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #78 from Tim Fenn f...@stanford.edu 2010-08-10 13:41:31 EDT --- (In reply to comment #76) (In reply to comment #75) (In reply to comment #74) Output from the Fedora rpmlint - newer than the one on RHEL, which I used before, and also more fussy and used by everyone else: coot.src: W: spelling-error %description -l en_US gui - GUI, goo, gi coot.src: W: spelling-error %description -l en_US mmdb - mm db, mm-db, Mme coot.src: W: spelling-error %description -l en_US modelling - modeling, model ling, model-ling Fixed these. coot.src:171: E: files-attr-not-set Oops, fixed that. The error (files-attr-not-set) will need fixing too. The SRPM is still uploading to koji for the scratch build so I will post the results of that later. I ran a koji scratch build as well on f14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2382998 Great. Also, I received word that upstream is working on the make check problem for 0.6.2, so once that is released I'll try again. Don't suppose you have any idea how fast they might move on this? It's not a show-stopper anyway, but it would be good to get it sorted. the make check now builds the appropriate tests, but there are still some edits required to get them to run. I've talked with upstream, but all the changes are in the unstable pre 0.6.2 branch. Once 0.6.2 is released it should be ready to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #12 from hannes johannes.l...@googlemail.com 2010-08-10 13:48:19 EDT --- Fixed: http://dl.dropbox.com/u/3917796/texmakerx-1.9.9a-2.fc13.src.rpm Greetings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 520808] Review Request: slf4j - Simple Logging Facade for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520808 --- Comment #13 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:54:08 EDT --- Have you asked the existing Fedora maintainers if they would like to maintain this package in EPEL? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612719 --- Comment #23 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:56:33 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601577 --- Comment #28 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:55:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618761] Review request: Gold Allocation Manager for HPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618761 --- Comment #15 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:58:07 EDT --- Is this package 'gold' or 'Gold'? The review bug summary says Gold, but the package spec/src.rpm is 'gold'. Can you fix the summary and re-request, or fix the package and rerequest? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622272 --- Comment #9 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:59:33 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2010-08-10 13:58:27 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622904] New: Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class https://bugzilla.redhat.com/show_bug.cgi?id=622904 Summary: Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: guillermo.go...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://gomix.fedorapeople.org/rubygem-state_machine/rubygem-state_machine.spec SRPM URL: http://gomix.fedorapeople.org/rubygem-state_machine/rubygem-state_machine-0.9.4-1.fc13.src.rpm Description: Adds support for creating state machines for attributes on any : Ruby class $ rpmlint -i SPECS/rubygem-state_machine.spec SRPMS/rubygem-state_machine-0.9.4-1.fc13.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622904] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622904 --- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-08-10 14:37:01 EDT --- rubygem-state_machine is already in Fedora. Is it correct that this review request is for recheck of this, because it is long (actually almost one year) since the last rubygem-state_machine is built on koji? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 520808] Review Request: slf4j - Simple Logging Facade for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520808 --- Comment #14 from Alexander Kurtakov akurt...@redhat.com 2010-08-10 14:47:50 EDT --- Yes, He asked me and I can't dedicate any time to maintain it in EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #79 from Tim Fenn f...@stanford.edu 2010-08-10 15:07:52 EDT --- I ran a scratch build for EPEL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2391853 some of the packages required for coot aren't available or are too old: guile-lib refmac-dictionary mmdb ssm clipper so I'll have to leave off EPEL for the branch request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622904] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622904 --- Comment #2 from Guillermo Gómez guillermo.go...@gmail.com 2010-08-10 15:16:58 EDT --- I understand that it has to be treated as a new pkg since the last update its one year old. quote Re-review required for older packages If a package was last updated more than three months ago (running cvs log -r HEAD *.spec can show you this information), you will need to submit a review request and have the package approved by a reviewer as if it were new to Fedora. am i getting it wrong ? http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #80 from Tim Fenn f...@stanford.edu 2010-08-10 15:21:26 EDT --- New Package SCM Request === Package Name: coot Short Description: crystallographic macromolecular building toolkit Owners: timfenn Branches: f13 f14 InitialCC: timfenn -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621416] Review Request: libgeotiff -- GeoTIFF format library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621416
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #2 from Martin Gieseking martin.giesek...@uos.de 2010-08-10
15:40:23 EDT ---
Here are some more comments:
- the license of the EPSG data files contains the following restriction:
The data may not be distributed for profit by any third party
I think this clause might be a problem. FE-Legal should have a look.
- drop BR: gzip and the call of gzip in %install as manpages are compressed
automatically
- %setup -q should be sufficient in %prep
- I suggest to keep the timestamps of the csv files, e.g. by changing the for
loop like this:
for f in `find csv -type f | grep -q ISO-8859` ; do
chmod 644 $f
iconv -f ISO-8859-1 -t UTF-8 $f ${f}.tmp
touch -r $f $f.tmp
mv -f $f.tmp $f
done
- don't mix $RPM_BUILD_ROOT and %{buildroot}, use only one of them
- Delete the libtool archives (.la) and the static library (.a) in %install and
remove both from %file (add --disable-static to %configure). If the static
lib is required by some reason, it should go to a -static package.
- I would remove, or at least prefix the generated manpages because some of the
filenames, like index.1, are too generic and could conflict. Also, the man
section should be 3 instead of 1. To me, it would be sufficient to provide the
html docs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621416] Review Request: libgeotiff -- GeoTIFF format library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621416 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #3 from Kevin Kofler ke...@tigcc.ticalc.org 2010-08-10 15:48:02 EDT --- The data may not be distributed for profit by any third party Yeah, this is not acceptable for Fedora. :-( How this slipped through initial review, I don't know. Unfortunately, this is going to be a serious problem because several other packages depend on this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612719 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #24 from Terje Røsten terje...@phys.ntnu.no 2010-08-10 16:30:47 EDT --- Thanks again, Kevin. recoll imported, built and pushed for all active branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622946] New: Review Request: rubygem-bcrypt-ruby - Wrapper Around bcrypt() password hashing algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-bcrypt-ruby - Wrapper Around bcrypt() password hashing algorithm https://bugzilla.redhat.com/show_bug.cgi?id=622946 Summary: Review Request: rubygem-bcrypt-ruby - Wrapper Around bcrypt() password hashing algorithm Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mmo...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://mo.morsi.org/files/gems/rubygem-bcrypt-ruby.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-bcrypt-ruby-2.1.2-1.fc13.src.rpm Description: bcrypt() is a sophisticated and secure hash algorithm designed by The OpenBSD project for hashing passwords. bcrypt-ruby provides a simple, humane wrapper for safely handling passwords. $ rpmlint \ rpmbuild/SRPMS/rubygem-bcrypt-ruby-2.1.2-1.fc13.src.rpm \ rpmbuild/RPMS/x86_64/rubygem-bcrypt-ruby-2.1.2-1.fc13.x86_64.rpm\ rpmbuild/RPMS/x86_64/rubygem-bcrypt-ruby-debuginfo-2.1.2-1.fc13.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji build:http://koji.fedoraproject.org/koji/taskinfo?taskID=2392161 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621015] Review Request: rubygem-authlogic - A simple ruby authentication solution
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621015
--- Comment #2 from Mohammed Morsi mmo...@redhat.com 2010-08-10 17:04:09 EDT
---
(In reply to comment #1)
Some notes:
* Unused macro
- %ruby_sitelib seems to be used nowhere.
Removed
* Latest version
- Latest version seems 2.1.6.
Updated
* Requires
- = 0 part on R: rubygem(activesupport) is redundant.
- R: ruby(abi) = 1.8 is mandatory
Done
* Documents
- %{geminstdir}/test should be marked as %doc
- Also %{geminstdir}/Rakefile can be marked as %doc (this is
like Makefile in autotools system).
Done
* %check
- rubygem(jeweler) is not strictly needed for $ rake test,
so please enable $ rake test.
Done
! Some notes:
- Without rubygem(ruby-debug) being installed, $ rake test
aborts like
$ rake test --trace
snip
However, in fact ruby-debug does not seem to be needed.
- After commenting out 'require ruby-debug' from ./test/test_helper.rb,
some tests fails like
Done, patch0 added to do this.
$ rake test --trace
snip
---
Maybe it is better that you package bcrypt-ruby?
http://bcrypt-ruby.rubyforge.org/
Package review request submitted
http://bugzilla.redhat.com/show_bug.cgi?id=622946
rubygem(bcrypt-ruby) is added as a BR(check) dependency. Once added, rake test
successfully completes.
Updated SRPM / Spec here:
pec URL: http://mo.morsi.org/files/gems/rubygem-authlogic.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-authlogic-2.1.6-1.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608069] Review Request: tango - standard library for D language of d1 specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #65 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:32:07 EDT --- tango-0.99.9-15.20100802svn5517.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608069] Review Request: tango - standard library for D language of d1 specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||tango-0.99.9-15.20100802svn ||5517.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577975] Review Request: kde-plasma-daisy - A versatile application launcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577975 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:38:11 EDT --- kde-plasma-daisy-0.0.4.23-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603904] Review Request: xautomation - Tools to automate tasks in X, even detecting on screen images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603904 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:37:59 EDT --- xautomation-1.03-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577975] Review Request: kde-plasma-daisy - A versatile application launcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577975 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|kde-plasma-daisy-0.0.4.23-2 |kde-plasma-daisy-0.0.4.23-2 |.fc13 |.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603904] Review Request: xautomation - Tools to automate tasks in X, even detecting on screen images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||xautomation-1.03-3.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506431] Review Request: eclipse-texlipse - Eclipse-based Latex plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506431 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #15 from Chitlesh GOORAH chitl...@gmail.com 2010-08-10 17:42:52 EDT --- Package Change Request == Package Name: eclipse-texlipse Short Description: Eclipse-based Latex plugin New Branches: EL-5 EL-6 Owners:chitlesh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603904] Review Request: xautomation - Tools to automate tasks in X, even detecting on screen images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|xautomation-1.03-3.fc12 |xautomation-1.03-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603904] Review Request: xautomation - Tools to automate tasks in X, even detecting on screen images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603904 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:43:23 EDT --- xautomation-1.03-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506174] Review Request: qtdmm - a digital multimeter readout software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506174 --- Comment #22 from Chitlesh GOORAH chitl...@gmail.com 2010-08-10 17:46:51 EDT --- Ok then, please do it :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578480] Review Request: spectrum - XMPP transport/gateway
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 --- Comment #59 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:45:10 EDT --- spectrum-0.3.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578480] Review Request: spectrum - XMPP transport/gateway
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|spectrum-0.3-0.9.git2010061 |spectrum-0.3.1-1.fc12 |4.fc13 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505017] Review Request: eclipse-veditor - Eclipse-based Verilog/VHDL plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505017 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #13 from Chitlesh GOORAH chitl...@gmail.com 2010-08-10 17:44:56 EDT --- Package Change Request == Package Name: eclipse-veditor Short Description: Eclipse-based Verilog/VHDL plugin New Branches: EL-5 EL-6 Owners:chitlesh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599097 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2010-08-10 17:43:36 EDT --- libgexiv2-0.1.90-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libgexiv2'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libgexiv2-0.1.90-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621416] Review Request: libgeotiff -- GeoTIFF format library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621416 --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2010-08-10 18:03:12 EDT --- This does, however, beg the question of why this issue isn't documented in the spec. It certainly should have been, if only to avoid all of this confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591365] Review Request: libexplain - Library functions to explain system call errors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591365 --- Comment #3 from Eric Smith e...@brouhaha.com 2010-08-10 18:17:12 EDT --- I still find that I cannot download using the standard SF URL. If you are able to get that to work, please give me the EXACT URL you use. In particular, for the latest version, which is 0.34.D001. I'll check with the author about the LGPLv3+ vs. GPLv3+ issue. It built fine for me with mock on F12 x86_64 before I uploaded it. I've since upgraded to 0.34.D001, which builds fine on F12 i386 and x86_64 with mock, and for f12-dist with koji. It looks like something much have changed in the headers for F13 since that problem didn't occur with F12. I'll see if I can find more of the missing includes, and report the problem upstream. Thanks! Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621416] Review Request: libgeotiff -- GeoTIFF format library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621416 --- Comment #6 from Volker Fröhlich volke...@gmx.at 2010-08-10 18:36:57 EDT --- I've contacted upstream about the license and they'll change the file LICENSE. I altered the loop a tad, since the chmod wouldn't catch it's target. The manpages in an rpm-package don't have to be compressed? Are there different opinions on whether to keep the devel-manpages at all? Having this question pending, I haven't sorted out all issues associated with the manpages, Martin has pointed out. Sadly there are some binaries that completely lack documentation. They are new for the release. I guess, I can drop -r from the rm -rf, that only removes a single file, can I? Spec URL: http://geofrogger.net/review/libgeotiff.spec SRPM URL: http://geofrogger.net/review/libgeotiff-1.3.0-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622904] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622904
Michael Stahnke mastah...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mastah...@gmail.com
--- Comment #4 from Michael Stahnke mastah...@gmail.com 2010-08-10 18:40:04
EDT ---
Macro %sitelib is not used anywhere. It can be removed.
Package builds in mock without issues.
rpmlint lists normal warnings about macros.
I have a small wish that there was a -doc package as 573 files of 737 are
documentation, but it doesn't take up that much space.
In some of my packages %{geminstdir}/test is marked as %doc and not in others.
I am guessing we need to agree on this one. I'll ask on the list.
This package looks like it is in pretty good shape.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621017] Review Request: rubygem-scruffy - A powerful, clean graphing library for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621017
--- Comment #2 from Mohammed Morsi mmo...@redhat.com 2010-08-10 18:37:18 EDT
---
(In reply to comment #1)
Some notes:
* Unused macros
- Defined %ruby_sitelib macro seems used nowhere
Removed
* License
-
CC-BY
./website/javascripts/lightbox.js
LGPLv2+
./website/javascripts/rounded_corners_lite.inc.js
-
- License tag should be MIT and CC-BY and LGPLv2+
(also see below)
Since these files have been added to the docs package, these additional
licenses have only been applied to that.
* Requires
- R: ruby(abi) = 1.8 is a must item.
- rubygem(hoe) is for development dependency (for
Rakefile) and is not needed for runtime
(Also hoe is marked as s.add_development_dependency
in installed .gemspec file)
Changed to a BR(check) dependency.
- lib/scruffy.rb contains:
17 require 'rubygems'
18 gem 'builder', '= 2.0'
19 require 'builder'
So this package should have Requires: rubygem(builder).
Added.
* Documents
- I guess the following files / directories can be
moved to -doc subpackage (after creating -doc subpackage).
Would you consider this?
--
%{geminstdir}/Rakefile
%{geminstdir}/config
%{geminstdir}/script
%{geminstdir}/spec
%{geminstdir}/test
%{geminstdir}/website
%{geminstdir}/tasks
%{geminstdir}/setup.rb
%{gemdir}/doc/%{gemname}-%{version}
--
Done
* %check
- As this gem contains spec/ and test/ directories, please
add %check section and execute some test programs
($ rake test and $ rake spec) there.
Done.
Updated:
Spec URL: http://mo.morsi.org/files/gems/rubygem-scruffy.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-scruffy-0.2.6-2.fc13.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2392215
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622979] Review Request: libassuan1 - GnuPG IPC library v1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622979 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||573796 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622979] Review Request: libassuan1 - GnuPG IPC library v1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622979 --- Comment #1 from Rex Dieter rdie...@math.unl.edu 2010-08-10 19:29:46 EDT --- Applications still needing libassuan v1 include: gpa opensc kdepim (I'll take care of patching these to use libassuan1) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622979] New: Review Request: libassuan1 - GnuPG IPC library v1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libassuan1 - GnuPG IPC library v1 https://bugzilla.redhat.com/show_bug.cgi?id=622979 Summary: Review Request: libassuan1 - GnuPG IPC library v1 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rdie...@math.unl.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://rdieter.fedorapeople.org/rpms/libassuan1/libassuan1.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/libassuan1/libassuan1-1.0.5-5.fc13.src.rpm Description: This is the GnuPG IPC v1 library This is a compat library for applications not yet ported to use libassuan-2.0.0, see also bug #573796 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622979] Review Request: libassuan1 - GnuPG IPC library v1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622979 --- Comment #2 from Rex Dieter rdie...@math.unl.edu 2010-08-10 19:31:06 EDT --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2392240 rpmlint: $ rpmlint *.rpm x86_64/*.rpm libassuan1-devel.x86_64: W: obsolete-not-provided libassuan-static libassuan1-devel.x86_64: W: no-manual-page-for-binary libassuan1-config 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 616193] Review Request: freerdp - X Remote Desktop Protocol Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=616193
--- Comment #7 from Mads Kiilerich m...@kiilerich.com 2010-08-10 19:34:37 EDT
---
(In reply to comment #6)
Can you be more specific? Which library/binary, and where are the
statements of
BSD license?
Sorry, it's actually MIT, to be precise
https://fedoraproject.org/wiki/Licensing/MIT#Modern_Style_with_sublicense
* in asn1 everything is BSD
* in channels/cliprdr everything is MIT
* in channels/common everything it MIT except chan_stream.{c,h} (GPLv2+)
* in channels/rdpdr everything is GPLv2+, except rdpdr_main.c (MIT)
* in channels/rdpsnd we have rdpsnd.h/rdpsnd_dsp.h (MIT) and
rspsnd_alsa.c/rdpsnd_main.c (GPLv2+)
* in include/freerdp everything is MIT except kbd.h and rdpset.h (GPLv2+)
* in libfreerdp everything is GPLv2+ except frdp.h (MIT)
* libfreerdpchanman is MIT
* in libfreerdpkbd everything is GPLv2+
* in X11 everything is MIT
I think that xfreedrp is MIT, so if there is a separate package for xfreerdp,
it should have MIT as license tag.
The rest is a mess, but I think it will come down to GPLv2+. The plugins are
compiling against the things from common, right?
Yes, so everything is either BSD or MIT or GPLv2+, but the xfreerdp and all
libs contains or links against GPLv2+ headers and libraries, so effectively
everything is GPLv2+, right?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603481] Review Request: freerdp - remote desktop protocol client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603481 --- Comment #15 from Mads Kiilerich m...@kiilerich.com 2010-08-10 19:40:37 EDT --- (In reply to comment #14) Regarding the plugins, the package should IMHO just be called freerdp-plugins. Or you package them completely separated as freerdp-plugin-foo. Couldn't the plugins be included in the libs package together with the libs linked directly from xfreerdp/remmina? You almost argued/agreed that everybody needed everything anyway, so fine-grained packaging had no benefit? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506431] Review Request: eclipse-texlipse - Eclipse-based Latex plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506431 --- Comment #16 from Jason Tibbitts ti...@math.uh.edu 2010-08-10 22:04:45 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505017] Review Request: eclipse-veditor - Eclipse-based Verilog/VHDL plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505017 --- Comment #14 from Jason Tibbitts ti...@math.uh.edu 2010-08-10 22:04:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472150 --- Comment #81 from Jason Tibbitts ti...@math.uh.edu 2010-08-10 22:05:32 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619012] Review Request: cagibi - SSDP (UPnP discovery) cache/proxy daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619012 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-08-10 22:55:39 EDT --- cagibi-0.1.1-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cagibi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cagibi-0.1.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621898 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|supercyp...@gmail.com Flag|fedora-review? |fedora-review+ --- Comment #11 from Chen Lei supercyp...@gmail.com 2010-08-10 22:25:47 EDT --- OK, this package is approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
