[Bug 635453] Review Request: deafshell - Deaf Shell is used for system accounts dedicated to ssh port forwarding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635453 --- Comment #2 from François Cami f...@fcami.net 2010-09-20 02:03:19 EDT --- Hi Mark, Thanks for the comments. 1. Fixed 2. I don't think so, 88674c3 comes from git and is bound to change at each release tag - what I did will alleviate the problem. 3. I don't think so either - if we strip the binaries during the build, rpmbuild won't generate the debuginfo rpm, which is a bug. Do you have the exact error message? 4. Thanks, fixed. Spec URL: http://fcami.fedorapeople.org/srpms/deafshell.spec SRPM URL: http://fcami.fedorapeople.org/srpms/deafshell-0.1-2.fc13.src.rpm Thank you -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635511
--- Comment #3 from Ralf Corsepius rc040...@freenet.de 2010-09-20 02:04:58
EDT ---
(In reply to comment #2)
Thanks for taking a look Ralf.
I added the doxygen-generated API reference to the -devel package as
documentation. There are also doxygen docs for the assimp binary, but they
don't contain any more information than running assimp --help does so I
opted
to exclude them.
Part of the reason I repackaged the archive was because the .zip file the
project provides doesn't unzip cleanly into a single directory.
[FWIW: I implemented an assimp*spec for local use sometime last week]
My way to overcome this is:
%setup -q -c -T -n %{name}-%{version}
%setup -q -T -D -n %{name}-%{version} -a0
New spec and SRPM are located at:
I intend to return to them later today.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635511 --- Comment #4 from Ralf Corsepius rc040...@freenet.de 2010-09-20 02:19:56 EDT --- Partial review: * Remove BuildRequires: ccache assimp does not build-require ccache. * Remove from *-devel Requires: pkgconfig cmake assimp doesn't ship pkgconfig files nor cmake files. * Consider building the doxygen docs from sources. Apart of these, the package seems basically fine to me. One outstanding issue, I haven't checked for yet: The *devel package's deps likely are incomplete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568968] Review Request: spyder - Scientific Python Development Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568968 Radek Novacek rnova...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rnova...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568968] Review Request: spyder - Scientific Python Development Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568968 Radek Novacek rnova...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Radek Novacek rnova...@redhat.com 2010-09-20 02:47:54 EDT --- I reviewed the package and it looks good. Only issue I found is missing %clean section. This section is needed for Fedora 12. So if the package will be only in Fedora 13 and higher, it is OK, but I would recommend to add it. I haven't found any other issues, so I set review+. I would also ask to be a co-maintainer of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518317] Review Request: perdition - Mail Retrieval Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518317 Jan-Frode Myklebust janfr...@tanso.net changed: What|Removed |Added CC||janfr...@tanso.net Bug 518317 depends on bug 518315, which changed state. Bug 518315 Summary: Review Request: vanessa_logger - Generic logging layer https://bugzilla.redhat.com/show_bug.cgi?id=518315 What|Old Value |New Value Status|ASSIGNED|ON_QA Status|ON_QA |CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634515] Review Request: python-zope-i18n - Zope Internationalization Support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634515 Bug 634515 depends on bug 632554, which changed state. Bug 632554 Summary: Review Request: python-zope-component - Zope Component Architecture https://bugzilla.redhat.com/show_bug.cgi?id=632554 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632554] Review Request: python-zope-component - Zope Component Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632554 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||python-zope-component-3.9.5 ||-2.fc15 Resolution||RAWHIDE Last Closed||2010-09-20 05:06:36 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634515] Review Request: python-zope-i18n - Zope Internationalization Support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634515 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||python-zope-i18n-3.7.4-2.fc ||15 Resolution||RAWHIDE Last Closed||2010-09-20 05:23:43 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629332] Review Request: GoAccess - Apache web log analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629332 --- Comment #6 from Marco Ziesing no5...@fedoraproject.org 2010-09-20 05:25:50 EDT --- Update: Spec URL: http://marco-ziesing.de/wp-content/uploads/2010/09/goaccess.spec SRPM URL: http://marco-ziesing.de/wp-content/uploads/2010/09/goaccess-0.3.2-2.fc13.src.rpm The author of GoAccess will fix the path on sf.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226096] Merge Review: libXxf86vm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226096 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-09-20 05:26:34 --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-09-20 05:26:34 EDT --- As Ajax has already given permission to cleanup his packages by provenpackagers, I have cleaned it up and built it in libXxf86vm-1.1.0-2.fc15 Commit I used to clean this package is at http://pkgs.fedoraproject.org/gitweb/?p=libXxf86vm.git;a=commitdiff;h=HEAD;hp=f512510a6ef7d896347b5bb1edd4625ab310637a -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226087] Merge Review: libXScrnSaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226087 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-09-20 05:26:28 --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-09-20 05:26:28 EDT --- As Ajax has already given permission to cleanup his packages by provenpackagers, I have cleaned it up and built it in libXScrnSaver-1.2.0-2.fc15 Commit I used to clean this package is at http://pkgs.fedoraproject.org/gitweb/?p=libXScrnSaver.git;a=commitdiff;h=HEAD;hp=6003ad5d5d23c71a7e10c9953faca57b9bcaef12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226095] Merge Review: libXxf86misc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226095 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-09-20 05:26:31 --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2010-09-20 05:26:31 EDT --- As Ajax has already given permission to cleanup his packages by provenpackagers, I have cleaned it up and built it in libXxf86misc-1.0.2-2.fc15 Commit I used to clean this package is at http://pkgs.fedoraproject.org/gitweb/?p=libXxf86misc.git;a=commitdiff;h=HEAD;hp=867bc1dd6469933c5bcedf6f7b8bde0103b692a5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589866] Review Request: darktable - Utility to organize and develop raw images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589866 --- Comment #35 from Edouard Bourguignon ma...@linuxed.net 2010-09-20 05:50:06 EDT --- Thank you Peter for your review, I will fix that as soon as possible. Note sure to know how to fix 4. and 7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589866] Review Request: darktable - Utility to organize and develop raw images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589866 --- Comment #36 from Peter Lemenkov lemen...@gmail.com 2010-09-20 05:58:58 EDT --- (In reply to comment #35) Thank you Peter for your review, I will fix that as soon as possible. Note sure to know how to fix 4. and 7. Regarding 4 - I just cheched sources - it adds more verbose output somewhere in sources. I believe it's safe for uns to NOT to enable this option since it has nothing with debugging symbols for GDB. As for --disable-schemas - just remove this configure switch. It seems that it was removed entirely. I'll take a look at the №7 issue more closely in a couple of hours. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589866] Review Request: darktable - Utility to organize and develop raw images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589866 --- Comment #37 from Edouard Bourguignon ma...@linuxed.net 2010-09-20 06:17:52 EDT --- Done or fixed: 2. 3. 5. 6. What remains: 1. if I remove this directory rpmbuild complains that it can't find files in /usr/share/doc/darktable 4. Will look at the log asap 7. Will try to check that asap Spec: http://www.linuxed.net/~madko/fedora/darktable.spec SRPM: http://www.linuxed.net/~madko/fedora/darktable-0.6-8.fc13.src.rpm i386: http://www.linuxed.net/~madko/fedora/darktable-0.6-8.fc13.i686.rpm x64 : http://www.linuxed.net/~madko/fedora/darktable-0.6-8.fc12.x86_64.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634906] Review Request: http-parser - HTTP request/response parser for C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634906
--- Comment #2 from Peter Lemenkov lemen...@gmail.com 2010-09-20 06:19:37 EDT
---
Koji scratch build for F-13:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2476815
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- rpmlint isnt' silent:
work ~: rpmlint ~/Desktop/http-parser-*
http-parser.i686: W: spelling-error %description -l en_US syscalls - miscalls,
systemically, scallops
http-parser.i686: E: no-ldconfig-symlink /usr/lib/libhttp_parser.so.0.3
http-parser.i686: E: library-without-ldconfig-postin
/usr/lib/libhttp_parser.so.0.3
http-parser.i686: E: library-without-ldconfig-postun
/usr/lib/libhttp_parser.so.0.3
http-parser-devel.i686: W: spelling-error %description -l en_US htt - ht, hit,
hat
http-parser-devel.i686: W: no-documentation
3 packages and 0 specfiles checked; 3 errors, 3 warnings.
work ~:
In particular, ldconfig-related messages are definitely must be addressed (see
my notes below).
- The package must be named according to the Package Naming Guidelines.
Please, mention particular git commit ID in the package's version.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
- The package doesn't fully meet the Packaging Guidelines:
1. The mentioned above issue with missing ldconfig invocation in %post and
%postun sections
2. The package's versioning scheme must contain git commit id.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license. (MIT)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must match the upstream source, as
provided in the spec URL. I can't use md5/sha256 here since tarball contains
timestamps, uids, gids and other mutable data. I just diffed them against local
copy (fetched as described in spec).
Sulaco ~/rpmbuild/BUILD: diff -ru http-parser.orig/ http-parser
Sulaco ~/rpmbuild/BUILD:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
- Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. See my notes above.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are in a -devel package.
0 No static libraries.
+ The library files that end in .so (without suffix) placed in a -devel
package.
+ The devel package requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ All filenames in the package are valid UTF-8.
OK, sommarizing things - I've found only two issues - ldconfig and git id in
version. Please fix them and I'll finish my review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589866] Review Request: darktable - Utility to organize and develop raw images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=589866
--- Comment #38 from Peter Lemenkov lemen...@gmail.com 2010-09-20 06:33:06
EDT ---
Again regarding №4 - you already addressed all my complaints by removing
obsolete configure switch. My concerns were that not using debug-related switch
may cause issues with generating debuginfo but I checked ant it seems that this
switch has nothing to do with GDB data.
So just proceed with issue №7.
As for №1, I'll take a look again, but I'm suspecting that you removed it in
the wrong way (for example, only from %files but not from rpm_build_root).
One more (mostly cosmetic) issue - please consistently use macros. Sometimes
you;re using %{buildroot} and sometimes $RPM_BUILD_ROOT. Please use only one
of these two.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634543] Review Request:animal-sniffer - Tools to assist verifying backward compatibility of Java classes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634543 --- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2010-09-20 06:46:07 EDT --- Another relase bump (patch pom.xml to include asm-all dependency) Spec URL: http://sochotni.fedorapeople.org/packages/animal-sniffer.spec SRPM:http://sochotni.fedorapeople.org/packages/animal-sniffer-1.6-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630932 --- Comment #3 from Naveen Kumar nku...@redhat.com 2010-09-20 08:10:59 EDT --- (In reply to comment #2) I'd like to see this package to be splitted into more subpackages. yep, I will do that, just give me some time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635453] Review Request: deafshell - Deaf Shell is used for system accounts dedicated to ssh port forwarding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635453 --- Comment #3 from Mark McKinstry mmcki...@nexcess.net 2010-09-20 08:37:24 EDT --- François, 3. Whoops, my bad. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634908] Review Request: libeio - Event-based fully asynchronous I/O library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634908 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com Version|14 |rawhide AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2010-09-20 08:41:22 EDT --- Taking this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 --- Comment #7 from Alexander Kurtakov akurt...@redhat.com 2010-09-20 08:41:08 EDT --- I would prefer to see license listed directly so it didn't get missed by some future changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635654] New: Review Request: perl-Text-Hunspell - Perl interface to the Hunspell library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Text-Hunspell - Perl interface to the Hunspell library https://bugzilla.redhat.com/show_bug.cgi?id=635654 Summary: Review Request: perl-Text-Hunspell - Perl interface to the Hunspell library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: p...@city-fan.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Text-Hunspell/branches/fedora/perl-Text-Hunspell.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Text-Hunspell/perl-Text-Hunspell-2.01-2.fc15.src.rpm Description: This module provides a Perl interface to the Hunspell library. This module is to meet the need of looking up many words, one at a time, in a single session, such as spell-checking a document in memory. This package is needed to migrate Text::SpellChecker from aspell to hunspell. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634908] Review Request: libeio - Event-based fully asynchronous I/O library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634908 --- Comment #2 from Peter Lemenkov lemen...@gmail.com 2010-09-20 09:06:59 EDT --- Koji scratchbuild for F-13 (w.i.p. currently): http://koji.fedoraproject.org/koji/taskinfo?taskID=2477115 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634908] Review Request: libeio - Event-based fully asynchronous I/O library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634908
--- Comment #3 from Peter Lemenkov lemen...@gmail.com 2010-09-20 09:47:20 EDT
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- rpmlint is not silent
work ~/Desktop: rpmlint libeio-*
libeio.i686: W: spelling-error %description -l en_US modelled - modeled, model
led, model-led
libeio.i686: W: spelling-error %description -l en_US libev - liber, libel,
Liberia
libeio.i686: W: spelling-error %description -l en_US fdatasync - fantasy,
asynchronous, asynchronism
libeio.i686: W: spelling-error %description -l en_US mknod - mk nod, mk-nod,
monody
libeio.i686: W: spelling-error %description -l en_US readdir - read dir,
read-dir, readily
libeio.i686: W: spelling-error %description -l en_US sendfile - send file,
send-file, Sendai
libeio.i686: W: spelling-error %description -l en_US solaris - solaria,
solarism, Polaris
libeio.i686: W: spelling-error %description -l en_US linux - Linux
libeio.i686: W: spelling-error %description -l en_US ux - xu, ix, u
libeio.i686: W: spelling-error %description -l en_US freebsd - freebased,
freebase, freeboard
libeio.i686: W: spelling-error %description -l en_US everywehere - everywhere,
everyway, everything
libeio.i686: W: spelling-error %description -l en_US readahead - read ahead,
read-ahead, readable
libeio.i686: E: library-without-ldconfig-postin /usr/lib/libeio.so.1.0.0
libeio.i686: E: library-without-ldconfig-postun /usr/lib/libeio.so.1.0.0
libeio-debuginfo.i686: E: debuginfo-without-sources
libeio-devel.i686: W: no-documentation
3 packages and 0 specfiles checked; 3 errors, 13 warnings.
work ~/Desktop:
In particular these two messages regarding ldconfig indicating real issues -
see my messages below.
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
- The package must meet the Packaging Guidelines. Please, add ldconfig
invocation in %post and %postun.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file must match the actual license.
(MIT or GPLv2+)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.
Sulaco ~/rpmbuild/BUILD: diff -ru libeio.orig/ libeio
Sulaco ~/rpmbuild/BUILD:
+ The package successfully compiles and builds into binary rpms on at least
one primary architecture. See koji link(s) above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
- Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
+ Packages does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are in a -devel package.
+ No static libraries packaged.
+ The library files that end in .so (without suffix) stored in a -devel
package.
+ The devel packages requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application
+ The package does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.
So, please, fix ldconfig issue and I;ll continue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 --- Comment #8 from Peter Oliver fedoraproject@mavit.org.uk 2010-09-20 10:32:17 EDT --- Okay, I've named the doc files explicitly. This means the reference documentation can no longer be in the same directory (since it gets deleted by %doc), and some users might not want the documentation anyway, so I've moved it into a separate subpackage. Updated files at http://www.triv.org.uk/~mavit/rpm/specs/arduino.spec, http://www.triv.org.uk/~mavit/rpm/fedora-13/SRPMS/arduino-0019-6.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Alexander Kurtakov akurt...@redhat.com 2010-09-20 10:44:05 EDT --- Thanks, This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2010-09-20 11:18:17 EDT --- One of the issue here is to determine if libbluray is useful without libaacs and libbdplus, as it would not meet the following guideline : https://fedoraproject.org/wiki/Packaging:Guidelines#Packages_which_are_not_useful_without_external_bits In others words, are we in a similar situation as for DVDs : libdvread is acceptable while libdvdcss is not. Indeed the commercial bluray discs offering is mostly composed of encrypted discs, and thus useless w/o libaacs and libbdplus. However there are now FOSS BD authoring tool and as such, we'll likely have more and more non-encrypted BDs. This post links to such a BD, made from well known free content (Elephant's Dream and Big Bug Bunny) : http://x264dev.multimedia.cx/?p=328 Just some food for thought when this bug will be reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #10 from Alexander Kurtakov akurt...@redhat.com 2010-09-20 11:23:35 EDT --- Dropping FE-NEEDSPONSOR. I've sponsored this contributor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633879] Review Request: perl-Test-Inter - Framework for more readable interactive test scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633879 Marcela Mašláňová mmasl...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633879] Review Request: perl-Test-Inter - Framework for more readable interactive test scripts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633879
Marcela Mašláňová mmasl...@redhat.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2010-09-20 11:36:00
EDT ---
Not needed:
BuildRequires: perl = 0:5.004
Not needed since F-12:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
rm -rf $RPM_BUILD_ROOT
Everything else is okay, no blockers. Please fix these BR before push.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619799 Adam Stokes asto...@redhat.com changed: What|Removed |Added CC||asto...@redhat.com --- Comment #1 from Adam Stokes asto...@redhat.com 2010-09-20 11:56:01 EDT --- I'm taking over this package from Ryan, he's moved onto other projects Updated SRPM: http://repos.fedorapeople.org/repos/beekhof/matahari/fedora-13/SRPMS/mingw32-pcre-8.10-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633879] Review Request: perl-Test-Inter - Framework for more readable interactive test scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633879 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633879] Review Request: perl-Test-Inter - Framework for more readable interactive test scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633879 --- Comment #2 from Petr Pisar ppi...@redhat.com 2010-09-20 11:57:53 EDT --- New Package SCM Request === Package Name: perl-Test-Inter Short Description: Framework for more readable interactive test scripts Owners: ppisar, mmaslano, psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=63 --- Comment #8 from g.da...@assyoma.it 2010-09-20 11:59:42 EDT --- Hi, thanks to all for the suggestions! I've submitted a hosting request to fedorahosted.org. If my request will be accepted, I will update the RPM package with Mark suggestions. Regards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=63 --- Comment #9 from Stephen Gallagher sgall...@redhat.com 2010-09-20 12:05:23 EDT --- That's not how it works. You need to sort out your specfile issues and attach the changes to this review bug. You won't be granted permission to build in Fedora until you pass this review. Your first step needs to be to create an upstream project and make a release tarball from it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 Peter Oliver fedoraproject@mavit.org.uk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Peter Oliver fedoraproject@mavit.org.uk 2010-09-20 12:49:23 EDT --- New Package SCM Request === Package Name: arduino Short Description: An IDE for Arduino-compatible electronics prototyping platforms Owners: mavit Branches: f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617340] Review Request: throttle - copy stdin to stdout at the specified speed (or lower)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617340 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|needinfo?(ke...@tummy.com) | --- Comment #12 from Kevin Fenzi ke...@tummy.com 2010-09-20 12:55:02 EDT --- No word from upstream then I take it? :( I guess it's a reasonable bet that they mean GPLv2+, but it sure would be nice to at least confirm that in an email. ;( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 617340] Review Request: throttle - copy stdin to stdout at the specified speed (or lower)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617340 --- Comment #13 from François Cami f...@fcami.net 2010-09-20 13:02:33 EDT --- upstream appears mute :/ I can maintain the code myself, so I don't have a problem with submitting and maintaining the package, but the license issue bites... I would flag the license as GPLv2 since upstream's original spec mentions GPLv2, not v2+. What do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635788] New: Review Request : nautilus-terminal - Terminal embedded in Nautilus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request : nautilus-terminal - Terminal embedded in Nautilus https://bugzilla.redhat.com/show_bug.cgi?id=635788 Summary: Review Request : nautilus-terminal - Terminal embedded in Nautilus Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: hicham.haou...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora SPEC URL : http://hicham.fedorapeople.org/nautilus-terminal/nautilus-terminal.spec SRPM URL : http://hicham.fedorapeople.org/nautilus-terminal/nautilus-terminal-0.6-1.fc13.src.rpm Description: Nautilus Terminal is a terminal embedded in Nautilus, the GNOME's file browser. It is always open in the current folder, and follows the navigation (like an automated cd command). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619799 Andrew Beekhof and...@beekhof.net changed: What|Removed |Added CC||and...@beekhof.net Flag|fedora-review? |fedora-review+, fedora-cvs? --- Comment #4 from Andrew Beekhof and...@beekhof.net 2010-09-20 14:16:37 EDT --- Switching to my alternate identity which is allowed to set the review flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619799 Andrew Beekhof abeek...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||abeek...@redhat.com AssignedTo|nob...@fedoraproject.org|abeek...@redhat.com Flag||fedora-review? --- Comment #2 from Andrew Beekhof abeek...@redhat.com 2010-09-20 14:12:02 EDT --- Looks like no-one set the review flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619799 --- Comment #5 from Andrew Beekhof and...@beekhof.net 2010-09-20 14:18:20 EDT --- New Package SCM Request === Package Name: mingw32-pcre Short Description: MinGW Windows pcre library Owners: astokes Branches: f13 f14 devel InitialCC: beekhof pmyers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=619799
--- Comment #3 from Andrew Beekhof abeek...@redhat.com 2010-09-20 14:13:48
EDT ---
As far as I can see, this package passes the review criteria for inclusion.
Go ahead and request the CVS flag.
rpmlint ../SPECS/mingw32-pcre.spec mock/*pcre*
mingw32-pcre.noarch: I: enchant-dictionary-not-found en_US
mingw32-pcre-debuginfo.noarch: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 0 warnings.
Using https://bugzilla.redhat.com/show_bug.cgi?id=499987 as a precedent, the
Error is considered harmless
MUST
+ rpmlint errors / warnings above are harmless and can be ignored.
+ Package is named according to the Fedora MinGW naming guidelines
+ Package follows the Fedora MinGW packaging guideliens
+ The stated license (BSD) is a Fedora approved license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
9524f0ff50b9093c02c81f911e41b066 pcre-8.10.tar.gz
9524f0ff50b9093c02c81f911e41b066 SOURCES/pcre-8.10.tar.gz
+ Package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane, except that BR pkgconfig is probably not needed.
n/a The spec file MUST handle locales properly
+ Packages does not bundle copies of system libraries
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package contains code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries are in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
SHOULD:
n/a If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it
- The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available
+ The reviewer should test that the package builds in mock
+ The package should compile and build into binary rpms on all supported
architectures
+ The reviewer should test that the package functions as described
n/a If scriptlets are used, those scriptlets must be sane
n/a Usually, subpackages other than devel should require the base package
+ The placement of pkgconfig(.pc) files
- your package should contain man pages for binaries/scripts
Fedora MinGW guidelines indicate not to duplicate documentation found in
Fedora native packages
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634388] Review Request: python-chameleon - XML-based template compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634388 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-09-20 14:40:16 EDT --- python-chameleon-1.2.12-4.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-chameleon'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-chameleon-1.2.12-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633089] Review Request: rubygem-fakeweb - A tool for faking responses to HTTP requests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633089 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-09-20 14:41:15 EDT --- rubygem-fakeweb-1.3.0-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-fakeweb'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623425] Review Request: python-pyside - Python bindings for Qt4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623425 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #32 from Fedora Update System upda...@fedoraproject.org 2010-09-20 14:40:31 EDT --- shiboken-0.5.0-2.fc14, generatorrunner-0.6.1-1.fc14, apiextractor-0.8.0-1.fc14, python-pyside-0.4.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update shiboken generatorrunner apiextractor python-pyside'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/shiboken-0.5.0-2.fc14,generatorrunner-0.6.1-1.fc14,apiextractor-0.8.0-1.fc14,python-pyside-0.4.1-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622314
Damian Wrobel dwro...@ertelnet.rybnik.pl changed:
What|Removed |Added
CC||dwro...@ertelnet.rybnik.pl,
||martin.giesek...@uos.de
--- Comment #1 from Damian Wrobel dwro...@ertelnet.rybnik.pl 2010-09-20
14:45:08 EDT ---
Hi, I did an un-official(informal) package review for the 3Depict, please find
some initial comments.
As it's one of my first package review please be understanding if something is
not perfect.
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint 3Depict-0.0.1-1.fc13.src.rpm 3Depict-0.0.1-1.fc13.i686.rpm
3Depict-debuginfo-0.0.1-1.fc13.i686.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK
- MUST: The package must be named according to the Package Naming Guidelines.
OK
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
- MUST: The package must meet the Packaging Guidelines.
$rpmls 3Depict-0.0.1-1.fc13.i686.rpm | grep .so | wc -l
0
a) As the package do not provide any shared libraries[1], it seems to be not
necessary to have in the spec file the following lines:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
b) There is a binary blob (3Depict-0.0.1/src/FreeSans.ttf) which should be
removed from tarball or at least in the %prep section.
c) The configure seems to check for existance of GL and PNG libraries but
there is a following definition in the spec file, which shouldn't be necessary:
export LDFLAGS=-lGL -lpng
NOT OK
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
OK, GPLv3+
- MUST: The License field in the package spec file must match the actual
license.
OK.
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
- MUST: The spec file must be written in American English.
OK. With remark that it's probably reasonable to consider to change the
Summary:
-Summary: Valued 3D point cloud visualization and analysis
with
+Summary: 3D point cloud visualization and analysis program
- MUST: The spec file for the package MUST be legible.
OK
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$spectool 3Depict.spec | grep Source0 | awk '{print $2}' | wget -i - -O - -o
/dev/null | md5sum
3040bc31eb884c7882fc8c446d1f2a34 -
$ rpmdev-md5 3Depict-0.0.1-1.fc13.src.rpm | grep .tar
3040bc31eb884c7882fc8c446d1f2a34 3Depict-0.0.1.tar.gz
OK
- MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Frankly speaking it compiles, but only thanks to the following hack in the spec
file:
export LDFLAGS=-lGL -lpng
which should be removed and the configure itself using appropriately pkg-config
tool should compose compiler/linker command line adequately.
To automatically check for existance of the libpng, please consider to use to
PKG_CHECK_MODULES macro:
PKG_CHECK_MODULES(PNG, libpng = 1.2)
Then you can obtain linker and compiler options in the PNG_LIBS and PNG_CFLAGS
variables respectively.
This should allows you to remove some of the #ifdefs in the code like the
followings:
#if defined(__WIN32) || defined(__WIN64) || defined(__CYGWIN__)
#include libpng/png.h
#else
#include png.h
#endif
and
#if PNG_LIBPNG_VER 10200
#error Requires libpng version 1.2.0 or greater!
#endif
Apart from that there are a lot of warnings which is worth to consider to be
corrected. Notably:
a) no return statement in function returning non-void (e.g. scene.h:276:69),
b) variable may be used uninitialized in this function (e.g. uniqueID in
3Depict.cpp:624:16),
c) dereferencing type-punned pointer will break strict-aliasing rules (e.g.
endianTest.h:57:32).
NOT OK
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Ditto.
NOT OK.
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622314 --- Comment #2 from D Haley my...@yahoo.com 2010-09-20 14:57:33 EDT --- Thanks for the review. You have raised many points which I need to address. However, I am planning on a 0.0.2 release this weekend, so I think it would be best if I address most of these concerns in the next tarball I generate, and upload a .spec thereafter. If you have any additional concerns here, or wish to have a review cycle before I do the next tarball release, please let me know. Just one point concerning the summary comment; the idea is to show the program does not just work on point clouds, but rather point clouds with an associated scalar value (hence valued point clouds) -- any ideas how this could be improved? Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622314 --- Comment #3 from D Haley my...@yahoo.com 2010-09-20 15:06:31 EDT --- Sorry for the duplicate posts: Can you please clarify your NOT OK for ExcludeArch? Is there an arch missing? I thought fedora dropped ppc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634700 Dave Malcolm dmalc...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|dmalc...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587198] Review Request: jgraphx - Java Graph Drawing Component
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=587198
--- Comment #11 from Lubomir Rintel lkund...@v3.sk 2010-09-20 15:09:58 EDT ---
(In reply to comment #8)
Just a few things for now.
According to https://fedoraproject.org/wiki/Packaging:Java
At a minimum, Java packages MUST:
BuildRequires: java-devel [= specific_version]
BuildRequires: jpackage-utils
Requires: java = specific_version
Requires: jpackage-utils
Group for javadoc should be Development/Documentation
Think about adding Requires: Requires: %{name}-%{version}-%{release}
to javadoc subpackage.
SOURCE0 is not a vaild URL. Try using:
http://www.jgraph.com/downloads/jgraphx/archive/%{name}-%(echo %{version}
|sed
's/\./_/g').zip
All of above fixed. Thanks!
Your BuildRoot seams a little odd. Think about using
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) instead.
It's not. It's one of the permitted forms, and actually a preferred one. Not
that it would matter, just the above one makes concurrent package builds racy
with older rpm.
find -name '*.jar' -delete and rm -rf docs/api should be moved to %prep.
It is also a good idea to add find -name '*.class' -delete too.
I could not find a definitive reason to do this and am keeping it as it is for
consistency with existing packages (and a personal bias :); until I'm convinced
otherwise (by a guideline or piece of rpm documentation).
(In reply to comment #9)
For your information, jgraphx is regularly breaking backward compatibility
(the
compilation will work but the application based on jgraphx will fails).
If you package jgraphx 1.4.0.2, it will break some behavior of Scilab. Scilab
5.2.2 expects jgraphx 1.2.0.8.
I can ask to the developer of the Scilab jgraphx-based component for a patch.
I quite honestly don't care. I won't mind a compatibility patch though, nor a
compat package if needed, nor helping out anywhere (if needed).
SPEC: http://v3.sk/~lkundrak/jgraphx.spec
SRPM: http://v3.sk/~lkundrak/jgraphx-1.4.1.0-1.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634700 --- Comment #7 from Dave Malcolm dmalc...@redhat.com 2010-09-20 15:14:01 EDT --- Scratch build: $ koji build --scratch dist-f15 python3-cairo-1.8.10-1.fc13.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2477876 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622314 --- Comment #4 from Damian Wrobel dwro...@ertelnet.rybnik.pl 2010-09-20 15:13:59 EDT --- (In reply to comment #3) I've marked it as a NOT OK, just because it almost don't compile for the primary architecture (see PNG BR problem). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634908] Review Request: libeio - Event-based fully asynchronous I/O library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634908 --- Comment #4 from Lubomir Rintel lkund...@v3.sk 2010-09-20 15:21:51 EDT --- Thank you! SPEC: http://v3.sk/~lkundrak/SPECS/libeio.spec SRPM: http://v3.sk/~lkundrak/SRPMS/libeio-3.65-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-09-20 15:50:28 EDT --- iodine-0.6.0-0.rc1.4.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/iodine-0.6.0-0.rc1.4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-09-20 15:50:58 EDT --- iodine-0.6.0-0.rc1.4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/iodine-0.6.0-0.rc1.4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-09-20 15:49:42 EDT --- iodine-0.6.0-0.rc1.4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/iodine-0.6.0-0.rc1.4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 --- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2010-09-20 15:55:55 EDT --- (In reply to comment #15) Might be, but 'standard de facto' means usual practice. There no also de facto standard - one prefer use tabs 4 space with, another spaces, I prefer tabs with 5 spaces width... (Actually on your page the 'cat' usage in sample is useless) Why?? http://en.wikipedia.org/wiki/Cat_%28Unix%29#Useless_use_of_cat May be. But in nowadays cat usage is standard de facto ;) In any case it interesting, thanks. Primary we need stability - Stability _and_ compatibility (as much as possible of course) with other Linux distributions I had ask but you are did not answer. Was this version incompatible and interoperability broken? http://hubbitus.net.ru/rpm/Fedora13/iodine/iodine.spec I have read the Russian translations inside spec. The language is used there is too slangy and stylistically broken a bit. I rather prefer to don't see such translations at all than keep user confused. What sentence seamed broken for you? I ready fix errors if it reasonable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634700 --- Comment #8 from Dave Malcolm dmalc...@redhat.com 2010-09-20 16:04:04 EDT --- Scratch build succeeded. BTW, I noticed in: http://koji.fedoraproject.org/koji/getfile?taskID=2477877name=build.log numerous tracebacks of the form: parsing /builddir/build/BUILD/pycairo-1.8.10/src/cairomodule.c failed Traceback (most recent call last): File /builddir/build/BUILD/pycairo-1.8.10/.waf3-1.5.18-a7b91e2a913ce55fa6ecdf310df95752/wafadmin/Tools/preproc.py, line 475, in addlines lines=filter_comments(filepath) File /builddir/build/BUILD/pycairo-1.8.10/.waf3-1.5.18-a7b91e2a913ce55fa6ecdf310df95752/wafadmin/Tools/preproc.py, line 47, in filter_comments code=Utils.readf(filename) File /builddir/build/BUILD/pycairo-1.8.10/.waf3-1.5.18-a7b91e2a913ce55fa6ecdf310df95752/wafadmin/Utils.py, line 411, in readf txt=f.read() File /usr/lib64/python3.2/encodings/ascii.py, line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 54: ordinal not in range(128) Any idea what's up with that, and if it's serious? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634700 --- Comment #9 from Dave Malcolm dmalc...@redhat.com 2010-09-20 16:08:17 EDT --- Created attachment 448540 -- https://bugzilla.redhat.com/attachment.cgi?id=448540 rpmlint output on a local build on an F13 box -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634700 --- Comment #10 from Dave Malcolm dmalc...@redhat.com 2010-09-20 16:13:48 EDT --- Notable rpmlint issues: python3-cairo-debuginfo.x86_64: E: empty-debuginfo-package python3-cairo.x86_64: W: unstripped-binary-or-object /usr/lib64/python3.1/site-packages/cairo/_cairo.so I see this also in the scratch build above: the debuginfo subpackage is empty. Other rpmlint issues: python3-cairo.src:50: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib Looks like a false positive relating to the lib64 fix in the %install The spurious-executable-perm: these seem to have 755, which doesn't strike me as a problem. Not sure what's up with the doc-file-dependency -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622314
--- Comment #5 from Martin Gieseking martin.giesek...@uos.de 2010-09-20
17:17:46 EDT ---
Hi D Haley and Damian,
Since I'm sponsoring Damian, here are some comments on his remarks. :)
Just one point concerning the summary comment; the idea is to show the
program does not just work on point clouds, but rather point clouds with an
associated scalar value (hence valued point clouds) -- any ideas how this
could be improved?
I'm not a native English speaker, but maybe something like
Application to visualize and analyze valued 3D point clouds
could be a possible variant.
Damian, I agree with most of your comments. Here are just a couple of
additional notes and corrections.
- MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Frankly speaking it compiles, but only thanks to the following hack in the
spec
file:
export LDFLAGS=-lGL -lpng
which should be removed and the configure itself using appropriately
pkg-config
tool should compose compiler/linker command line adequately.
NOT OK
These are things to be fixed by upstream, and the packager usually don't need
to address them as long as a simple addition of explicit LDFLAGS leads to a
working binary RPM. But since D Haley is the upstream developer, he might want
to fix these issues anyway.
- MUST: If the package does not successfully compile, build or work ...
Ditto.
NOT OK.
The package compiles, builds and works properly, so this MUST item is OK.
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
There is no BR: for libpng.
NOT OK.
BR: libpng-devel is not required as it's added as an indirect dependency of
wxGTK-devel. If a package builds in mock/koji, usually all necessary BRs are
present.
%{_mandir}/man1/%{name}.1.gz
The .gz suffix of manpages should be avoided since the compression format
applied by rpmbuild might change. Thus, %{_mandir}/man1/%{name}.1* is more
appropriate.
- MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed ...
NOT OK. See note about macro consistency.
The .desktop file is present and it is installed properly with
desktop-file-install. = OK so far.
However, the icon 3Depict referenced in the .desktop file is missing. It
should be added to the package.
Finally, the spec file should get a short comment above Patch0 describing the
purpose of the patch.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635875] New: Review Request: mawk - An interpreter for the AWK programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mawk - An interpreter for the AWK programming language https://bugzilla.redhat.com/show_bug.cgi?id=635875 Summary: Review Request: mawk - An interpreter for the AWK programming language Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mmcki...@nexcess.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://mmckinst.nexcess.net/mawk/mawk.spec SRPM URL: http://mmckinst.nexcess.net/mawk/mawk-1.3.4.20100625-1.fc13.src.rpm Description: mawk is an interpreter for the AWK programming language. The AWK language is useful for manipulation of data files, text retrieval and processing, and for prototyping and experimenting with algorithms. The FTP server is slow to respond sometimes. If you wget the tarball it works. [mmcki...@fedora13 SRPMS]$ rpmlint mawk-1.3.4.20100625-1.fc13.src.rpm mawk.src: W: invalid-url Source0: ftp://invisible-island.net/mawk/mawk-1.3.4-20100625.tgz urlopen error ftp error: timed out 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [mmcki...@fedora13 SRPMS]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635875] Review Request: mawk - An interpreter for the AWK programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635875 Mark McKinstry mmcki...@nexcess.net changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635515] Review Request: libphidget - Drivers and API for Phidget devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=635515
--- Comment #3 from Rich Mattes richmat...@gmail.com 2010-09-20 20:48:55 EDT
---
Thanks for taking on the review!
I've enabled zeroconf, zeroconf-lookup, and am now using the ldconfig switch.
I added the patch to keep the buildsystem from trying to rm old versions of
itself, and commented out the ldconfig stuff cause i was already in there.
I've dropped the patches (and the calls to aclocal and libtoolize.) I've also
installed the udev rules.
--enable-jni didn't seem to do anything, but I did a little digging and the
.jar file has a separate make target. I've enabled it and installed the .jar
file to the jnidir. I'm not really sure what to do with the resulting .jar
file: the packaging guidelines say that the .jar file should be installed in
%{_libdir}/%{name}, but then it goes on to outline the %{_jnidir}. I've put
the .jar in the jnidir for now. If it's wrong, I'll fix or remove it.
Spec URL: http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/libphidget/libphidget-2.1.7.20100621-2.fc13.src.rpm
$ rpmlint ../RPMS/x86_64/libphidget-* ../SRPMS/libphidget*
libphidget.x86_64: W: spelling-error %description -l en_US Phidgets - Fidgets,
Midgets, Widgets
libphidget-devel.x86_64: W: no-documentation
libphidget.src: W: spelling-error %description -l en_US Phidgets - Fidgets,
Midgets, Widgets
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635511 --- Comment #5 from Rich Mattes richmat...@gmail.com 2010-09-20 21:10:28 EDT --- I've removed the extra BuildRequires and got the documentation building manually. The new spec and srpm are at: Spec URL: http://rmattes.fedorapeople.org/RPMS/assimp/assimp.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/assimp/assimp-1.1.700-3.fc13.src.rpm $ rpmlint ../RPMS/x86_64/assimp-* ../SRPMS/assimp-* assimp.x86_64: W: shared-lib-calls-exit /usr/lib64/libassimp.so.1.0.0 e...@glibc_2.2.5 assimp.x86_64: W: no-manual-page-for-binary assimp 4 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2010-09-20 21:31:04 EDT --- iodine-0.6.0-0.rc1.4.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update iodine'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/iodine-0.6.0-0.rc1.4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629645] Review Request: perl-Math-Base36 - Encoding and decoding of base36 strings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629645 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-09-20 21:35:55 EDT --- perl-Math-Base36-0.07-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629645] Review Request: perl-Math-Base36 - Encoding and decoding of base36 strings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629645 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Math-Base36-0.07-2.fc1 ||3 Resolution||ERRATA Last Closed||2010-09-20 21:35:59 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568968] Review Request: spyder - Scientific Python Development Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568968 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Chen Lei supercyp...@gmail.com 2010-09-20 23:29:36 EDT --- OK, sections which are needed for F12 only are added to the spec. New Package SCM Request === Package Name: spyder Short Description: Scientific Python Development Environment Owners: supercyper rnovacek Branches: f12 f13 f14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631558] Review Request: arduino - An IDE for Arduino-compatible electronics prototyping platforms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=631558 --- Comment #12 from Kevin Fenzi ke...@tummy.com 2010-09-20 23:43:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619799] Review Request: mingw32-pcre - Perl-compatible regular expression library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619799 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-09-20 23:42:46 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634258] Review Request: spew - I/O performance measurement and load generation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634258 --- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-09-20 23:44:51 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633879] Review Request: perl-Test-Inter - Framework for more readable interactive test scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633879 --- Comment #3 from Kevin Fenzi ke...@tummy.com 2010-09-20 23:44:01 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635126] Review Request: rubygem-test-unit - Improved version of Test::Unit bundled in Ruby 1.8.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635126 --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-09-20 23:45:39 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634908] Review Request: libeio - Event-based fully asynchronous I/O library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634908 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2010-09-21 00:10:40 EDT --- OK, I don't see any other issues here - this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634906] Review Request: http-parser - HTTP request/response parser for C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634906 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Peter Lemenkov lemen...@gmail.com 2010-09-21 00:11:46 EDT --- Ok, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
