[Bug 165930] Review Request: check : A unit test framework for C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=165930 Jerry James changed: What|Removed |Added CC||loganje...@gmail.com Flag||fedora-cvs? --- Comment #4 from Jerry James 2010-12-24 00:04:27 EST --- Check is available in all current Fedora releases and in RHEL 5 and 6. Paul Howarth needs it in EPEL 4 for the proftpd test suite. Package Change Request == Package Name: check New Branches: el4 Owners: jjames pghmcfc InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 --- Comment #9 from Jason Tibbitts 2010-12-23 21:03:17 EST --- Looks OK to me. I didn't save the previous package so I don't know if you were running the original cron job as clamupdate instead of root. That might be something to consider (since it avoids exposing a root-owned process to whatever might come in over the network) but . And just to be clear, my comments relating to ownership were just about the two files in /usr/bin, not the /var/lib and /var/log stuff, and I certainly didn't intend for you to undo any "run as something other than root" setup if that's what was in place originally. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652257] Review Request: focuswriter - A fullscreen, distraction-free writing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652257 --- Comment #8 from Jason Tibbitts 2010-12-23 20:43:33 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652257] Review Request: focuswriter - A fullscreen, distraction-free writing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652257 Jean-Francois Saucier changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Jean-Francois Saucier 2010-12-23 20:25:52 EST --- New Package SCM Request === Package Name: focuswriter Short Description: A fullscreen, distraction-free writing program Owners: jfsaucier Branches: f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652257] Review Request: focuswriter - A fullscreen, distraction-free writing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652257 --- Comment #6 from Jean-Francois Saucier 2010-12-23 20:24:15 EST --- Thanks a lot for the review. I will try to talk with upstream for adding a manpage to this package as I think it would be useful. I made the two other changes to the spec file that I will push into git. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592487] Review Request: ffgtk - A solution for controlling Fritz!Box or compatible routers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592487 --- Comment #11 from Louis Lagendijk 2010-12-23 18:59:43 EST --- Re: fails to build: I was sure that I checked this recently. Apparently not: my bad, sorry! Re: spool directory permissions: I did not like the solution myself either. I had another look at it and found out that I was doing things unnecessarily complicated: the old spooler code is still there. This will use a socket between CUPS and ffgtk. I am working on some patches to make that work properly(done). I just need to test things to make sure it all works as expected. Expect an update pretty soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664154] Review Request: python-babel-BabelGladeExtractor - This is a Babel extractor plug-in which extracts translatable messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664154 Paul W. Frields changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-12-23 18:50:32 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664154] Review Request: python-babel-BabelGladeExtractor - This is a Babel extractor plug-in which extracts translatable messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664154 --- Comment #6 from Jason Tibbitts 2010-12-23 18:32:19 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664154] Review Request: python-babel-BabelGladeExtractor - This is a Babel extractor plug-in which extracts translatable messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664154 Paul W. Frields changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Paul W. Frields 2010-12-23 18:25:38 EST --- New Package SCM Request === Package Name: python-babel-BabelGladeExtractor Short Description: This is a Babel extractor plug-in which extracts translatable messages. Owners: pfrields Branches: f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664303] Review Request: drupal6-auto_nodetitle - "auto_nodetitle" is a small and efficient module that allows hiding of the content title
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664303 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(peter.bo...@gmail ||.com) --- Comment #3 from Paul W. Frields 2010-12-23 18:22:23 EST --- No, you must include the binary RPM package as well. Different tests apply to this package from the other files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664303] Review Request: drupal6-auto_nodetitle - "auto_nodetitle" is a small and efficient module that allows hiding of the content title
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664303 Peter Borsa changed: What|Removed |Added Flag|needinfo?(peter.bo...@gmail | |.com) | --- Comment #2 from Peter Borsa 2010-12-23 16:57:20 EST --- Is it necessary? Isn't enough the src.rpm file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 660393] Review Request: netxen-firmware - QLogic Linux Intelligent Ethernet (3000 and 3100 Series) Adapter Firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=660393 --- Comment #6 from Tom "spot" Callaway 2010-12-23 15:53:17 EST --- Thanks Peter. New package with the two issue resolved is here: New SRPM: http://www.auroralinux.org/people/spot/review/new/netxen-firmware-4.0.534-3.fc14.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/netxen-firmware.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588941] Review Request: pypy - Implementation of the Python language, using Python itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588941 --- Comment #47 from Dave Malcolm 2010-12-23 15:27:08 EST --- (In reply to comment #46) > I was sorta waiting for the dust to settle before doing another review pass. :) > Is it ready for that now? The built package should now actually work, so: yes please - I'd appreciate someone taking a look. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661436 --- Comment #31 from Minnikhanov 2010-12-23 15:14:39 EST --- (In reply to comment #29) > For rubygem-heroku side, one comment > > - Please put one line between each %changelog entry (because > it is useful when using Fedora git system) like: > --- > * Tue Dec 21 2010 - 1.15.0-1 > - Initial package > > * Thu Dec 21 2010 - 1.14.10-3 > - Fix Comment 23 #661436 (Review Request) > - Remove '/.yardoc'. > > * Thu Dec 18 2010 - 1.14.10-2 > - Fix Comment 18 #661436 (Review Request) > - Set Release: 2 > --- Fix it. Spec URL: http://dl.dropbox.com/u/14118661/rubygem-heroku.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-heroku-1.15.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664298] Review Request: autojump - A fast way to navigate your filesystem from the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664298 --- Comment #11 from Jason Tibbitts 2010-12-23 15:14:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661961] Review Request: kyotocabinet - A lightweight database library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661961 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||kyotocabinet-1.2.29-1.fc14 Resolution||ERRATA Last Closed||2010-12-23 14:57:45 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661961] Review Request: kyotocabinet - A lightweight database library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661961 --- Comment #9 from Fedora Update System 2010-12-23 14:57:41 EST --- kyotocabinet-1.2.29-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620191] Review Request: clawsker - Dialog to edit Claws Mail's hidden preferences
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620191
--- Comment #7 from Michael Schwendt 2010-12-23 14:44:39
EST ---
> Requires: perl(Gtk2)
> Requires: perl(Locale::gettext)
Aren't these added automatically?
$ rpm -qR clawsker|grep ^perl
perl(Glib)
perl(Gtk2)
perl(Gtk2)
perl(Locale::gettext)
perl(Locale::gettext)
perl(POSIX)
perl(constant)
perl(encoding)
perl(strict)
> Source1:%{name}.desktop
It's surprisingly well-hidden in the System > Preferences menu, which IMO is
the wrong location for an application. Yes, it is an application. An
application which does nothing else than editing another application's
configuration file. It doesn't do anything related to the system environment.
It should go into the Applications > Internet menu where Claws Mail is found,
too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 --- Comment #8 from Andrew Colin Kissa 2010-12-23 14:33:37 EST --- Updated the spec and srpm with the fixes rpmlint is now cleaner. http://topdog-software.com/oss/SRPMS/fedora/clamav-unofficial-sigs/clamav-unofficial-sigs.spec http://topdog-software.com/oss/SRPMS/fedora/clamav-unofficial-sigs/clamav-unofficial-sigs-3.7.1-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588941] Review Request: pypy - Implementation of the Python language, using Python itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588941 Kevin Fenzi changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|ke...@tummy.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588941] Review Request: pypy - Implementation of the Python language, using Python itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588941 Kevin Fenzi changed: What|Removed |Added Component|0x |Package Review AssignedTo|ke...@tummy.com |nob...@fedoraproject.org --- Comment #46 from Kevin Fenzi 2010-12-23 14:14:47 EST --- I was sorta waiting for the dust to settle before doing another review pass. Is it ready for that now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664154] Review Request: python-babel-BabelGladeExtractor - This is a Babel extractor plug-in which extracts translatable messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664154 Kevin Fenzi changed: What|Removed |Added Summary|Review Request: |Review Request: |python-babel-glade - This |python-babel-BabelGladeExtr |is a Babel extractor|actor - This is a Babel |plug-in which extracts |extractor plug-in which |translatable messages. |extracts translatable ||messages. Flag|fedora-review?, |fedora-review+ |needinfo?(ke...@tummy.com) | --- Comment #4 from Kevin Fenzi 2010-12-23 14:05:16 EST --- 1. Yeah, to me having the upstream name in there is good, but I agree it looks kinda redundant, but I think it will do. 2. Seems fine. 3. :) ok, looks good. I don't see any further blockers, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 --- Comment #7 from Andrew Colin Kissa 2010-12-23 13:59:19 EST --- * Upstream have named the command with a .sh because its a shell script, would linking /usr/bin/clamav-unofficial-sigs.sh to /usr/bin/clamav-unofficial-sigs be acceptable ? * On the ownership you are correct about that will fix * will fix the post scriptlet -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: libcprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #7 from Philip Prindeville 2010-12-23 13:48:03 EST --- (In reply to comment #6) > > %if %with postgres > > BuildRequires: postgresql-devel > > Requires: postgresql > > %endif > > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Not sure I get this part. If I mock build, configure doesn't detect the library because it's not installed by default. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656892] (ghc-augeas) Review Request: ghc-augeas - Haskell bindings for the augeas library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656892 JudeNagurney changed: What|Removed |Added Alias||ghc-augeas -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 Jason Tibbitts changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review? --- Comment #6 from Jason Tibbitts 2010-12-23 13:29:23 EST --- Sure, I can review it. There's not really much to this package; it builds fine and rpmlint has only the expected complaints about nonstandard uid and gits, as well as two complaints about missing manpages. There is actually a manpage, but for some reason it has a different name than the actual executable. Is there any specific reason for that? Seems to be something of a mistake by upstream. I'm pretty sure I traced down the clamav dependencies properly to make sure that the user will be present before this package is installed. The clamav package is so terrible, however, that I might have missed something. I'm not entirely sure why the executables in /usr/bin need to be owned by the clamupdate user. Can you clarify? The current situation leads to them being writable by clamupdate, which I don't think is a particularly good idea. The %post scriptlet is decidedly not sane. Every time this package is updated, a file which you've explicitly marked as %config(noreplace) will be modified if it includes the string "45". Why not use the existing random wait functionality already in the software? * source files match upstream. sha256sum: 7f8de46da43d8edd06ee1dcd1bc4563e61b23c9bbd368ccf0265576e46f4d90c clamav-unofficial-sigs-3.7.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: config(clamav-unofficial-sigs) = 3.7.1-1.fc15 clamav-unofficial-sigs = 3.7.1-1.fc15 = /bin/sh bind-utils clamav config(clamav-unofficial-sigs) = 3.7.1-1.fc15 curl diffutils gnupg rsync * no bundled libraries. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files X scriptlets are not sane. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656892] (ghc-augeas) Review Request: ghc-augeas - Haskell bindings for the augeas library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656892 JudeNagurney changed: What|Removed |Added Summary|Review Request: ghc-augeas |(ghc-augeas) Review |- Haskell bindings for the |Request: ghc-augeas - |augeas library |Haskell bindings for the ||augeas library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656892] Review Request: ghc-augeas - Haskell bindings for the augeas library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656892 JudeNagurney changed: What|Removed |Added Summary|(ghc-augeas) Review |Review Request: ghc-augeas |Request: ghc-augeas - |- Haskell bindings for the |Haskell bindings for the|augeas library |augeas library | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: libcprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656082
--- Comment #6 from Michael Schwendt 2010-12-23 13:31:35
EST ---
Just a brief look at the spec file (no full review):
> Source0: http://downloads.sourceforge.net/cprops/libcprops-0.1.8.tar.bz2
Nowadays when there are tools to parse a spec file in order to retrieve a
download URL, it isn't beneficial anymore to hardcode the version number. It's
more convenient and less error-prone to use %{version} instead. Occasionally,
a packager updates just the "Version:" tag to 0.1.9 and that works accidentally
if the old tarball is still available.
> %if %with postgres
> BuildRequires:postgresql-devel
> Requires: postgresql
> %endif
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> %files devel
> %defattr(-,root,root,-)
> %doc %{_mandir}/man3/*
Files below %_mandir are %doc by default.
> %dir %{_includedir}/cprops/
> %{_includedir}/cprops/*
Since the '*' wildcard catches all files, you could replace the two lines with
just
%{_includedir}/cprops/
which includes the directory and its contents. The trailing slash is optional
and just for increased readability. To make it more explicit that the entry is
a directory tree and not a single file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664624] Review Request: libdmapsharing3 - A DMAP client and server library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664624 Michael Schwendt changed: What|Removed |Added CC||mschwe...@gmail.com --- Comment #1 from Michael Schwendt 2010-12-23 13:22:00 EST --- After looking at "repoquery --whatrequires libdmapsharing", why not upgrade the existing libdmapsharing package in Fedora and port the existing API users to the new API? Instead of introducing a parallel installable package. And frankly, it there's a compelling reason to keep both, it wouldn't hurt to package both libraries in the same src.rpm, especially if headers, libraries and sonames are designed in a way they don't conflict. I think it's overhead to request a review of something that is in Fedora already as an older version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665395] Review Request: firewalld - A firewall daemon with D-BUS interface providing a dynamic firewall
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665395 Michael Schwendt changed: What|Removed |Added Summary|A firewall daemon with |Review Request: firewalld - |D-BUS interface providing a |A firewall daemon with |dynamic firewallReview |D-BUS interface providing a |Request: firewalld -|dynamic firewall -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545047] Review Request: NearTree - An API for finding nearest neighbors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545047 --- Comment #35 from Fedora Update System 2010-12-23 12:25:44 EST --- NearTree-2.3.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545047] Review Request: NearTree - An API for finding nearest neighbors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545047 Fedora Update System changed: What|Removed |Added Fixed In Version|NearTree-2.3.2-1.1.fc13 |NearTree-2.3.2-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 Magnus Tuominen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Magnus Tuominen 2010-12-23 11:56:48 EST --- All issues fixed. Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664303] Review Request: drupal6-auto_nodetitle - "auto_nodetitle" is a small and efficient module that allows hiding of the content title
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664303 Paul W. Frields changed: What|Removed |Added CC||sticks...@gmail.com Flag||needinfo?(peter.bo...@gmail ||.com) --- Comment #1 from Paul W. Frields 2010-12-23 11:49:56 EST --- Please post complete rpmlint output including the binary (built) RPM package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664154] Review Request: python-babel-glade - This is a Babel extractor plug-in which extracts translatable messages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664154 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(ke...@tummy.com) --- Comment #3 from Paul W. Frields 2010-12-23 11:47:50 EST --- 1. Yeah, I was trying too hard to avoid redundancy. Fixed. 2. The "dev" doesn't seem too useful since "0.N" in the release field already indicates a pre-release -- but I used r288 since that indicates the specific SVN revision. Does that work for you? 3. Yes -- in fact I fixed that and copied up a new spec file shortly after the original, but you must have started the review super-quickly! :-) Thanks for your help, and here are the new files: http://pfrields.fedorapeople.org/packages/SPECS/python-babel-BabelGladeExtractor.spec http://pfrields.fedorapeople.org/packages/SRPMS/python-babel-BabelGladeExtractor-0.2-0.2.r288.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #9 from Siddharth Sharma 2010-12-23 11:31:00 EST --- Spec URL: http://siddharths.fedorapeople.org/SPECS/kpassgen.spec SRPM URL: http://siddharths.fedorapeople.org/SRPMS/kpassgen-1.3-1.fc14.src.rpm Description: Random password creater -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609638] Review Request: kpassgen - Random password creater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609638 --- Comment #8 from Siddharth Sharma 2010-12-23 11:24:10 EST --- Thanks alot Magnus :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 653805] Review Request: drupal6-ctools - This suite is primarily a set of APIs and tools to improve the developer experience.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=653805 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(peter.bo...@gmail ||.com) --- Comment #14 from Paul W. Frields 2010-12-23 10:56:11 EST --- $ rpmlint rpmbuild/SPECS/drupal6-ctools.spec rpmbuild/SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-ctools-1.8-1.fc14.noarch.rpm drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/stylizer.help.ini drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/plugins/access/node.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/views_content/views_content.admin.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/base-styles.html drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/base-style-types.html 2 packages and 1 specfiles checked; 5 errors, 0 warnings. Once again, you need to run rpmlint on all three components -- the specfile, the SRPM, and the built RPM. Please correct the zero-length errors here. http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 659005] Review Request: drupal6-job_scheduler - Simple API for scheduling tasks once at a predetermined time or periodically at a fixed interval
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=659005 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(peter.bo...@gmail ||.com) --- Comment #4 from Paul W. Frields 2010-12-23 10:53:25 EST --- Peter, this review was previously approved, so you can now request git branches. Keep in mind that your define of %drupaldir will not work for Fedora 14 or lower, so you should make appropriate changes before building for those branches if you decide to build there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664963] Rename Request: libmcs - Configuration file abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664963 --- Comment #1 from Michael Schwendt 2010-12-23 10:57:30 EST --- Spec URL: http://mschwendt.fedorapeople.org/libmcs.spec SRPM URL: http://mschwendt.fedorapeople.org/libmcs-0.7.2-2.fc14.src.rpm Update to let -utils subpackage require explicit EVR of base library package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575498] Review Request: plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575498 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2010-12-23 10:49:38 --- Comment #6 from Jason Tibbitts 2010-12-23 10:49:38 EST --- Chris has become inactive, I think, so this ticket should probably just be closed. *** This bug has been marked as a duplicate of bug 664910 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664910] Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664910 Jason Tibbitts changed: What|Removed |Added CC||cw...@alumni.drew.edu --- Comment #2 from Jason Tibbitts 2010-12-23 10:49:38 EST --- *** Bug 575498 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575498] Review Request: plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575498 Jason Tibbitts changed: What|Removed |Added Status Whiteboard|NotReady| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628665] Review Request: Mars - An interactive development environment for programming in MIPS assembly language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628665 --- Comment #5 from W. Michael Petullo 2010-12-23 10:46:59 EST --- Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.0.1-1.fc14.src.rpm - New upstream version - Remove clean section - Use SOURCE1 to install - Add MARSlicense.txt - Remove classpath definition from MANIFEST.MF -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642857] Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642857 Paul W. Frields changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Paul W. Frields 2010-12-23 10:41:54 EST --- Sven, since git is now complete you can clone from git and build this package. Remember that in F-15 and/or EPEL, you may need to adjust the specfile to account for changes in the drupal6 base package. Once it's built and pushed for the appropriate branches, you can mark this bug CLOSED NEXTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575498] Review Request: plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575498 Emmanuel Seyman changed: What|Removed |Added CC||emmanuel.sey...@club-intern ||et.fr, rc040...@freenet.de --- Comment #5 from Emmanuel Seyman 2010-12-23 10:38:29 EST --- Note that Ralf Corsepius has submitted his own request review for Plack in #664910. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642858] Review Request: drupal6-footnotes - Allows to easily create automatically numbered footnote references
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642858 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(s...@lank.es) --- Comment #9 from Paul W. Frields 2010-12-23 10:42:57 EST --- Sven, you can now do a git request at any time (as in bug 642857). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619380] Review Request: giis - Solution to undelete files "gET iT i sAY"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619380 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) 2010-12-23 10:25:38 EST --- You also refer to color of my eyes :) I just have not enough free time to do many review for swap and force that process. Sorry, I try do that in new year. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=63 --- Comment #20 from g.da...@assyoma.it 2010-12-23 10:03:21 EST --- Hi Jason, thanks for your suggestions. I am not unwilling to regenerate my srpm/SPEC file; the point is that I did no changes from the first release because it seems to work fine to me :) As soon as possible, I will upload the srpm file. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665395] New: A firewall daemon with D-BUS interface providing a dynamic firewallReview Request: firewalld -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: A firewall daemon with D-BUS interface providing a dynamic firewallReview Request: firewalld - https://bugzilla.redhat.com/show_bug.cgi?id=665395 Summary: A firewall daemon with D-BUS interface providing a dynamic firewallReview Request: firewalld - Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: twoer...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://twoerner.fedorapeople.org/firewalld/firewalld.spec SRPM URL: http://twoerner.fedorapeople.org/firewalld/firewalld-0.1-1.fc14.src.rpm Description: firewalld is a firewall service daemon that provides a dynamic customizable firewall with a D-BUS interface. For more information, please have a look at: http://twoerner.fedorapeople.org/firewalld and git://git.fedorahosted.org/git/firewalld.git -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611285] Review Request: pyvcs - A lightweight abstraction layer over multiple VCSs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611285 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter Bug 611285 depends on bug 605423, which changed state. Bug 605423 Summary: Review Request: python-dulwich - A python implementation of the Git file formats and protocols https://bugzilla.redhat.com/show_bug.cgi?id=605423 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611100] Review Request: python-multiprocessing - Backport of the multiprocessing package to Python 2.4 and 2.5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611100 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611054] Review Request: python-carrot - AMQP Messaging Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611054 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=63 --- Comment #19 from Jason Tibbitts 2010-12-23 09:44:04 EST --- There are many review requests needing sponsors, and few sponsors with time to review them all. The fact that you seem unwilling to regenerate your srpm when you make changes to the spec, along with the attaching of the spec and not posting links to the updated files, makes this difficult to review so of course it's going to get passed over. You need to make it as easy as possible for potential sponsors to look at your package. If you make it difficult, we'll just spend our time on other tickets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467001] Review Request: litmus - WebDAV Test Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467001 Jason Tibbitts changed: What|Removed |Added Blocks||201449(FE-DEADREVIEW) Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664298] Review Request: autojump - A fast way to navigate your filesystem from the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664298 Thibault North changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Thibault North 2010-12-23 09:41:23 EST --- Sorry I missed that step :) New Package SCM Request === Package Name: autojump Short Description: A fast way to navigate your filesystem from the command line Owners: tnorth Branches: f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619380] Review Request: giis - Solution to undelete files "gET iT i sAY"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619380 --- Comment #2 from Jason Tibbitts 2010-12-23 09:42:41 EST --- Well, most people are not even going to bother looking at this review, because the submitter uses that insane five-space tab thing and explicitly asks people not to start reviewing it because of that. So his package reviews just sit around forever. Too bad, really, but it's his choice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625558] Review Request: configure-trackpoint - trackpoint configuration utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625558 Jason Tibbitts changed: What|Removed |Added Blocks||201449(FE-DEADREVIEW) Status Whiteboard|StalledSubmitter| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628665] Review Request: Mars - An interactive development environment for programming in MIPS assembly language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628665 --- Comment #4 from Stanislav Ochotnicky 2010-12-23 09:25:06 EST --- Oh, and %files should include %doc MARSlicense.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628665] Review Request: Mars - An interactive development environment for programming in MIPS assembly language
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=628665
Stanislav Ochotnicky changed:
What|Removed |Added
CC||socho...@redhat.com
--- Comment #3 from Stanislav Ochotnicky 2010-12-23
09:19:36 EST ---
Quick look at the spec:
* New version is available
* Source0: should be normal URL, most probably:
http://courses.missouristate.edu/KenVollmar/MARS/MARS_4_0_1_Oct2010/Mars_4_0_1.jar
* clean section/buildroot definition and rm -rf in the beginning of %install
is not needed anymore (unless you plan to do EPEL-5 build)
* You should remove classpath from manifest before including it in output jar
* instead of:
install -Dpm 755 %{_sourcedir}/Mars $RPM_BUILD_ROOT/%{_bindir}/Mars
do:
install -Dpm 755 %{SOURCE1} $RPM_BUILD_ROOT/%{_bindir}/Mars
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 --- Comment #5 from Andrew Colin Kissa 2010-12-23 08:15:28 EST --- I have some free time during the xmas holidays, i will use that time to fix all my outstanding bugs as NO proven packager has taken them up. So if you can review it i will work on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 647885] Review Request: apache-rat - Apache Release Audit Tool (RAT)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647885 --- Comment #13 from Stanislav Ochotnicky 2010-12-23 07:35:22 EST --- Ah, sorry that was supposed to be -Dmaven.test.failure.ignore=true. About those failures...They could be caused by new/old plexus-container-default. Quick look didn't give me much more info. Feel free to ignore the failures, IMO they shouldn't cause trouble in runtime. It's most probably due to our use of local repo and other things... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555018] Review Request: gnac - An audio converter for GNOME (first package, seeking sponsor)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555018 --- Comment #23 from Taylon 2010-12-23 07:23:50 EST --- Sorry, I don't know why, but I didn't received e-mails informing about updates here. I want to continue but until the next year (it's very close =D) I'll not be able. I'll send updates as soon as possible ok? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657795] Review Request: libspatialite - Enables SQLite to support spatial data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657795 --- Comment #13 from Volker Fröhlich 2010-12-23 06:53:48 EST --- Upstream's response on the exit calls: "I've found a single exit() reference, related with some flex auto-generated code (WKT parser), and is intended to terminate the parser just in the case of some absolutely unexpected catastrophic failure." -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467001] Review Request: litmus - WebDAV Test Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467001 Paulo Roma Cavalcanti changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG Last Closed||2010-12-23 06:43:44 --- Comment #9 from Paulo Roma Cavalcanti 2010-12-23 06:43:44 EST --- I am closing this review request because it is stalled for two years now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664493] Review Request: httpcomponents-client - HTTP agent implementation based on httpcomponents HttpCore
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664493 Stanislav Ochotnicky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-12-23 06:16:58 --- Comment #5 from Stanislav Ochotnicky 2010-12-23 06:16:58 EST --- Built in rawhide. Thanks for review & repos http://koji.fedoraproject.org/koji/taskinfo?taskID=2686340 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664465] Review Request: httpcomponents-core - Set of low level Java HTTP transport components for HTTP services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664465 Stanislav Ochotnicky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-12-23 06:17:09 --- Comment #6 from Stanislav Ochotnicky 2010-12-23 06:17:09 EST --- Built in rawhide. Thanks for review & repos http://koji.fedoraproject.org/koji/taskinfo?taskID=2686340 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664493] Review Request: httpcomponents-client - HTTP agent implementation based on httpcomponents HttpCore
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664493 Bug 664493 depends on bug 664465, which changed state. Bug 664465 Summary: Review Request: httpcomponents-core - Set of low level Java HTTP transport components for HTTP services https://bugzilla.redhat.com/show_bug.cgi?id=664465 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664493] Review Request: httpcomponents-client - HTTP agent implementation based on httpcomponents HttpCore
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664493 Stanislav Ochotnicky changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655457] Review Request: codemirror - In-browser code editing made bearable
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=655457
--- Comment #1 from Michael Schwendt 2010-12-23 05:43:49
EST ---
A brief look at the spec file (no full review):
> #==
> # Macro definitions
> #==
> %global url http://codemirror.net/
> %global pub http://aikiframework.org/files/codemirror/
> %global name codemirror
> %global version 0.91
> %global revision 1
> %global pkgdist %{name}-%{version}.zip
> %global pkgdistdir CodeMirror-%{version}
> %global httpdconf%{name}.conf
> %global httpdconfdir %{_sysconfdir}/httpd/conf.d
> %global httpdservice /sbin/service httpd
>
> #
> # Package definitions
> #
> Name: %{name}
> Version: %{version}
> Release: %{revision}%{?dist}
> Summary: In-browser code editing made bearable
> Group: Applications/Internet
> License: zlib
> URL: %{url}
> Source0: %{url}/%{pkgdist}
> Source1: %{httpdconf}
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> BuildArch: noarch
In my opinion, these two sections are a superfluous overuse of variables. I
highly recommend trimming down the spec preamble to improve readability and to
remove ambiguities.
The spec file is "huge enough" because of many subpackages that during update
preparations it will be necessary to spend time on (re-reviewing) the
individual subpackage definition sections anyway (e.g. the various licences and
URLs). Having to deal with macros that are used only once, e.g. %pub, isn't
helpful. The various licenses could be summed up near the top of the spec, btw.
> %global name codemirror
> Name: %{name}
The "Name:" tag already defines %name, so what you do here is redundant. Simply
Name: codemirror
near the top of the spec file would be very clear and sufficient.
> %global version 0.91
> Version: %{version}
Same here. Plus, you'll get into trouble whenever you will need to apply
special pre-release/post-release versioning schemes (such as Fedora's).
> %global revision 1
> Release: %{revision}%{?dist}
Worse even. It would be necessary to modify both lines for a least-significant
%release bump, such as 2%{?dist}.1 Apart from that, %revision is not used
elsewhere, so why introduce it at all? "Release:" already defines %release.
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Note that several details related to BuildRoot are not needed anymore in Fedora
13 and newer: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
> #=
> # Requirements
> #=
> Requires: httpd
The fat header is superfluous. Better add a brief comment that explains this
explicit dependency on "httpd", and possibly answer why a dependency on the
virtual "webserver" package wouldn't work.
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
That Wiki section focuses on library Requires a bit, but also applies to
explicit Requires in general.
> %package doc
> Summary: CodeMirror documentation
> Group:Documentation
> Requires: %{name} = %{version}-%{release}
Here, a comment would explain why a Documentation package needs the base
package. I see the some of the HTML pages refer to .js files on localhost, so
that's sort of what a comment in the spec should cover.
> %{__mkdir} -p -m 0755 %{buildroot}%{_defaultdocdir}/%{name}-%{version}
> %{__install} -p -m 0644 *.html
> %{buildroot}%{_defaultdocdir}/%{name}-%{version}
Caution! Manually filling %_defaultdocdir/%{name}-%{version} with files
conflicts with %doc. It's a pitfall that packagers run into regularly during
review. If in a later release, a %doc line is added to the files list for
%name, it would lead to killing/overriding the contents of the manually filled
directory. Possible work-arounds: 1) Using a different docdir. 2) Adding a
warning to the %files list that %doc MUST NOT be used.
> #=
> # Post process
> #=
> %post
> %{httpdservice} condrestart &> /dev/null || :
> %postun
> %{httpdservice} condrestart &> /dev/null || :
>
> #==
> # Files included in package
> #==
These fat headers here bite you. Examine the output of:
rpm -qp --scripts codemirror-0.91-1.fc14.noarch.rpm
This has bitten other packagers before, even worse when using non-Shell
scriptlet sections.
> $ rpmls -p codemirror-0.91-1.fc14.noarch.rpm|grep ^d
> $
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
For example, directory entries /usr/share/codemirror/ and
/usr/share/doc/codemirror-0.91/ are not included in the package. Mistake may
apply to other subpackages, too.
> #
> http://svn.exoplatform.org/projects/gwt/trunk/exo-gwtframework-editor/src/main/resources/org/exoplatform/gwtframework/editor/public/codemirror/css/gr
[Bug 619380] Review Request: giis - Solution to undelete files "gET iT i sAY"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619380 --- Comment #1 from Lakshmipathi 2010-12-23 05:01:16 EST --- it's almost six months now - In general,I would like to know how long will it take to include/reject package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665331] Review Request: perl-Imager - Perl extension for Generating 24 bit Images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665331 Ralf Corsepius changed: What|Removed |Added Blocks||665096 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665331] New: Review Request: perl-Imager - Perl extension for Generating 24 bit Images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Imager - Perl extension for Generating 24 bit Images https://bugzilla.redhat.com/show_bug.cgi?id=665331 Summary: Review Request: perl-Imager - Perl extension for Generating 24 bit Images Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rc040...@freenet.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Imager.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Imager-0.79-1.fc15.src.rpm Description: Imager is a module for creating and altering images. It can read and write various image formats, draw primitive shapes like lines,and polygons, blend multiple images together in various ways, scale, crop, render text and more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646789] Review Request: openturns - C++ reliability library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=646789
--- Comment #3 from Michael Schwendt 2010-12-23 04:42:40
EST ---
* Please enter your real name in your bugzilla.redhat.com account preferences.
Currently, you are listed as "(none)" on the NEEDSPONSOR list, which isn't
helpful.
* Also maintain your own %changelog entries in the RPM spec files. For example,
openturns.spec only lists two entries where your name/email doesn't appear at
all. The package review ought to start with an added changelog entry that marks
the start of the packaging for Fedora.
* A brief look at the spec (not a full review):
> Summary:Uncertainty treatment library
> Group: Development/Libraries
Run-time library packages typically go into group "System
Environment/Libraries".
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
Note that several details related to BuildRoot are not necessary anymore in
Fedora 13 and newer:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
> Patch0: typedefs.patch
It is common practice to add the package name and software version to Patch
file names, e.g. openturns-0.13.2-typedefs.patch
Not only does that make clear which package the separate patch files belong
into and "when" they have been created, it also reduces the risk of conflicts
(especially when working in environments where multiple releases may use the
same SOURCES directory).
> Requires: lapack
>
> Requires: R-rot = 1.4.4
> Requires: R-sensitivity >= 1.3.0
[...and more...]
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> Obsoletes: %{name} < %{version}
Even if self-Obsoletes like this may be harmless, there ought to be a comment
in the spec file explaining them. Also mention when this Obsoletes tag has been
added and when/whether it may be removed again.
> %package examples
> Summary:OpenTURNS examples
> Group: Development/Libraries
Really?
> %package validation
> Summary:OpenTURNS validation files
> Group: Development/Libraries
Really?
> %build
> %configure --disable-python
>
> %if 0%{?mdkversion}
> ...
> ./configure
> ...
So, for Mandriva the configure script would be called twice? Once as
%configure, then as ./configure. Doesn't look correct and adds to the fact that
the attempt at writing multi-dist spec files often introduces errors.
> %check
> export LD_LIBRARY_PATH=%{buildroot}%{_libdir}/%{name}
> ...
Good effort.
> %files
> ...
> %config %{_sysconfdir}/%{name}/%{name}.conf
> ...
> %{_libdir}/%{name}/*.so.*
The directories
%{_sysconfdir}/%{name}/
%{_libdir}/%{name}/
are not included in the package.
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
> %files devel
> ...
> %{_datadir}/%{name}/m4/
Here, %_datadir/name is not included. The -examples and -validation subpackages
also depend on that directory.
> %doc AUTHORS COPYING README
In all four packages? Bad choice. Including these %doc files in just the main
library package is sufficient.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620156] Review Request: mango - It is a collection of D packages with an orientation toward network programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620156 --- Comment #3 from MERCIER Jonathan 2010-12-23 04:27:20 EST --- yes i agree but i had not enough space on fedorapeople for put it 0AD take too space. I will send again a scratch build after 27 December. You too take a look in D repo Thanks for all -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618668] Review Request: Derelict - a collection of D bindings to C shared libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618668 --- Comment #4 from MERCIER Jonathan 2010-12-23 04:16:22 EST --- Thanks Jason for this reply i will send again scratch build after 27 december you can too take rpm and src.rpm from: * http://repos.fedorapeople.org/repos/bioinfornatics/D/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625558] Review Request: configure-trackpoint - trackpoint configuration utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625558 David Riches changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2010-12-23 04:12:51 --- Comment #2 from David Riches 2010-12-23 04:12:51 EST --- No time for this, and I think its been superseded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=63 --- Comment #18 from g.da...@assyoma.it 2010-12-23 04:10:22 EST --- Hi Jason, you don't see any new release because I didn't apply any new change - to me, the package works as expected. However, I almost forgot di review request, because many month passed and nobody care... I did something wrong? Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 660393] Review Request: netxen-firmware - QLogic Linux Intelligent Ethernet (3000 and 3100 Series) Adapter Firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=660393
--- Comment #5 from Peter Lemenkov 2010-12-23 04:06:49 EST
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is not silent but all its messages are just a false positives
sulaco ~/rpmbuild/SPECS: rpmlint
../RPMS/noarch/netxen-firmware-4.0.534-2.fc12.noarch.rpm
netxen-firmware.noarch: W: spelling-error Summary(en_US) QLogic -> Q Logic,
Logic, Logistic
netxen-firmware.noarch: W: spelling-error %description -l en_US QLogic -> Q
Logic, Logic, Logistic
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license
(redistributable w/o modifications).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
- The sources used to build the package, MUST match the upstream source, as
provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum phanfw.bin* LICENCE.phanfw*
e1444f55fb6a06d5580dd65f4c5e4c0e58b39e8d92833db12e7cb05cf712aa0f phanfw.bin
e1444f55fb6a06d5580dd65f4c5e4c0e58b39e8d92833db12e7cb05cf712aa0f phanfw.bin.1
95e24016be3ed63247fe9cb34011c20008217216934375118d9a77d799d6b7b5
LICENCE.phanfw
d71de4bbee2641d2901b7a8e9155c36da4d862803a92d633e0e2391a6b66cd03
LICENCE.phanfw.1
sulaco ~/rpmbuild/SOURCES:
The LICENSE.phanfw file differs from downloaded copy. Although the changes are
just cosmetic (cheched with diff), I'd really prefer to deal with the file
provided by upstream.
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
- The package does not own files or directories already owned by other
packages. However there is one unowned directory - /lib/firmware (which is
owned by udev). Please add "Requires: udev".
+ All filenames in rpm packages are valid UTF-8.
Please, address the two issues mentioned above and I'll continue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
