[Bug 670451] Review Request: async-http-client - Asynchronous Http Client for Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670451

Stanislav Ochotnicky  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from Stanislav Ochotnicky  2011-01-27 
03:02:01 EST ---
Thanks for the review. I'll just explain the javadoc subpackage for future
reference :-) Normally subpackages need to require main package. Javadoc
subpackages are a special case (similar to -manual). They contain (more-less)
only html files (API documentation) so there is no binary requirement on main
package. Some javadoc subpackages do have requires on main package, we don't
enforce it one way or the other (but my opinion is that people should be able
to install documentation even without main package installed).

btw I see sonatype-oss-parent in rawhide (I actually built with it). I am
guessing you were too fast and something didn't happen to be in buildroot yet.
Anyway..I tested in mock so all should be OK.

New Package SCM Request
===
Package Name: async-http-client
Short Description:  Asynchronous Http Client for Java
Owners: sochotni
Branches: f14
InitialCC: java-sig

(f14 branch just to workaround fedpkg bug when only 1 branch is present)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 646836] Review Request: rubygem-bundler - The best way to manage your application's dependencies

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646836

Vít Ondruch  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #16 from Vít Ondruch  2011-01-27 04:18:06 EST 
---
===
Package Name: rubygem-bundler
Short Description: Library and utilities to manages a Ruby application's gem
dependencies
Owners: vondruch
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 646836] Review Request: rubygem-bundler - The best way to manage your application's dependencies

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646836

--- Comment #17 from Vít Ondruch  2011-01-27 04:20:36 EST 
---
BTW I have finally found how to execute the test suite:
RUBYOPT="$RUBYOPT I/usr/lib/ruby/gems/1.8/gems/thor-0.14.6/lib" spec spec

I just have finish conversion for RSpec 1.3 and integrate it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

Petr Pisar  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Petr Pisar  2011-01-27 04:30:47 EST ---
Spec file changes:

--- perl-Perl-OSType.spec   2011-01-26 16:19:02.353995456 +0100
+++ perl-Perl-OSType.spec.1 2011-01-26 19:34:59.0 +0100
@@ -1,12 +1,12 @@
 # We don't really need ExtUtils::MakeMaker > 6.31
-%global old_eumm %(%{__perl} -MExtUtils::MakeMaker -e 'printf "%d\\n",
$ExtUtils::MakeMaker::VERSION < 6.31 ? 1 : 0;' 2>/dev/null || echo 0)
+%global old_eumm %(perl -MExtUtils::MakeMaker -e 'printf "%d\\n",
$ExtUtils::MakeMaker::VERSION < 6.31 ? 1 : 0;' 2>/dev/null || echo 0)

 # Test suite needs patching if we have Test::More < 0.88
-%global old_test_more %(%{__perl} -MTest::More -e 'printf "%d\\n",
$Test::More::VERSION < 0.88 ? 1 : 0;' 2>/dev/null || echo 0)
+%global old_test_more %(perl -MTest::More -e 'printf "%d\\n",
$Test::More::VERSION < 0.88 ? 1 : 0;' 2>/dev/null || echo 0)

 Name:  perl-Perl-OSType
 Version:   1.002
-Release:   2%{?dist}
+Release:   3%{?dist}
 Summary:   Map Perl operating system names to generic types
 License:   GPL+ or Artistic
 Group: Development/Libraries
@@ -16,7 +16,10 @@
 Patch1:Perl-OSType-1.002-old-Test::More.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch: noarch
+BuildRequires: perl(constant)
+BuildRequires: perl(Exporter)
 BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(File::Temp)
 # Pod::Coverage::TrustPod not yet in EPEL-4
 %if "%{?rhel}" != "4"
 BuildRequires: perl(Pod::Coverage::TrustPod)
@@ -75,6 +78,10 @@
 %{_mandir}/man3/Perl::OSType.3pm*

 %changelog
+* Wed Jan 26 2011 Paul Howarth  - 1.002-3
+- BR: perl(constant), perl(Exporter), perl(File::Temp) in case they are
+  dual-lived at some point (#672801)
+
 * Wed Jan 26 2011 Paul Howarth  - 1.002-2
 - Sanitize for Fedora submission


> FIX: BuildRequire perl(File::Temp) (t/00-compile.t:16) as it can dual-live in
> the future (http://search.cpan.org/~tjenness/File-Temp/).
+BuildRequires: perl(File::Temp)
Ok.

> FIX: BuildRequire perl(constant) (t/OSType.t:6) as it can dual-live in the
> future (http://search.cpan.org/~saper/constant/).
+BuildRequires: perl(constant)
Ok.

> FIX: BuildRequire perl(Exporter) (lib/Perl/OSType.pm:17) as it can dual-live
> in the future (http://search.cpan.org/~ferreira/Exporter/).
+BuildRequires: perl(Exporter)
Ok.


$ rpmlint perl-Perl-OSType.spec ../SRPMS/perl-Perl-OSType-1.002-3.fc15.src.rpm
../RPMS/noarch/perl-Perl-OSType-1.002-3.fc15.noarch.rpm 
perl-Perl-OSType.src: W: spelling-error %description -l en_US linux -> Linux
perl-Perl-OSType.src: W: spelling-error %description -l en_US freebsd ->
freebased, freebase, freebie
perl-Perl-OSType.noarch: W: spelling-error %description -l en_US linux -> Linux
perl-Perl-OSType.noarch: W: spelling-error %description -l en_US freebsd ->
freebased, freebase, freebie
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

rpmlint Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2745094). Ok.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664817] Review Request: perl-HTML-Selector-XPath - CSS Selector to XPath compiler

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664817

--- Comment #3 from Petr Pisar  2011-01-27 05:17:07 EST ---
Perl packaging guidelines

says:

> It is recommended to buildrequire core modules explicitly, because they can
> move between sub-packages or disappear from core perl.

I agree with guidelines that relying on fact the module is currently provided
by perl-core is silly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

Paul Howarth  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

--- Comment #5 from Paul Howarth  2011-01-27 05:19:23 EST ---
Just for future reference, my packages for submission are maintained in an svn
repo so you can check the revision history using regular svn commands, e.g.

SPECREPO=http://subversion.city-fan.org/repos/cfo-repo/perl-Perl-OSType
svn log $SPECREPO/branches/fedora/perl-Perl-OSType.spec
svn diff -c 1749 $SPECREPO/branches/fedora/perl-Perl-OSType.spec

Thanks for the review.

New Package SCM Request
===
Package Name: perl-Perl-OSType
Short Description: Map Perl operating system names to generic types
Owners: pghmcfc
Branches: f13 f14 el4 el5 el6
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672764

--- Comment #2 from Paul Howarth  2011-01-27 07:22:00 EST ---
I've attached suggested changes to perl-JSON in Bug #665621; if you think they
look right I can get that pushed and built to avoid conflicts when this package
appears.

I've updated the perl-JSON-PP spec to add the versioned conflict.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673096] New: Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus 
server

https://bugzilla.redhat.com/show_bug.cgi?id=673096

   Summary: Review Request: bamf-qt - Qt bindings and QML plugin
for Bamf DBus server
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jrez...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rezza.hofyland.cz/fedora/packages/bamf-qt/bamf-qt.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/bamf-qt/bamf-qt-0.1-0.1.bzr371.fc14.src.rpm
Description: Qt bindings and QML plugin for Bamf DBus server.

rpmlint bamf-qt-0.1-0.1.bzr371.fc14.src.rpm 
bamf-qt.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in,
plugging
bamf-qt.src: W: invalid-url Source0: bamf-qt-0.1.bzr371.tar.gz

Source URL - pre-release snaphot.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2745311

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673099] New: Review Request: perl-Perl-Critic-Lax - Policies that let you slide on common exceptions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Perl-Critic-Lax - Policies that let you slide on 
common exceptions

https://bugzilla.redhat.com/show_bug.cgi?id=673099

   Summary: Review Request: perl-Perl-Critic-Lax - Policies that
let you slide on common exceptions
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Lax/perl-Perl-Critic-Lax.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Lax/perl-Perl-Critic-Lax-0.008-1.fc15.src.rpm
Description:
The Perl-Critic-Lax distribution includes versions of core Perl::Critic
modules with built-in exceptions. If you really like a Perl::Critic policy,
but find that you often violate it in a specific way that seems pretty darn
reasonable, maybe there's a Lax policy. If there isn't, send one in!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 576591] Review Request: iptraf-ng

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576591

--- Comment #16 from Nikola Pajkovsky  2011-01-27 07:50:11 
EST ---
what do you think? Is it ok with you?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672764

--- Comment #3 from Iain Arnell  2011-01-27 07:57:01 EST ---
The perl-JSON changes look good to me. And the Conflict is good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672986] Review Request: freeipa - The Identity, Policy and Audit system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672986

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
 AssignedTo|nob...@fedoraproject.org|sgall...@redhat.com
   Flag||fedora-review?,
   ||needinfo?(rcritten@redhat.c
   ||om)

--- Comment #1 from Stephen Gallagher  2011-01-27 08:03:19 
EST ---
# MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
-= FAIL =-

freeipa-admintools.i686: W: obsolete-not-provided ipa-admintools
 * Obvious

freeipa-admintools.i686: W: non-conffile-in-etc /etc/bash_completion.d/ipa
 * This should be specified as %config (arguable whether this belongs as
(noreplace) or not)

freeipa-client.i686: W: obsolete-not-provided ipa-client
 * Obvious

freeipa-python.i686: W: obsolete-not-provided ipa-python
 * Obvious

freeipa-python.i686: E: zero-length /etc/ipa/default.conf
 * Could this be a bug?

freeipa-server.i686: E: explicit-lib-dependency libcap
 * RPM should autodetect library dependencies. Unless you need a specific
version, in which case that should be specified separately.

freeipa-server.i686: W: obsolete-not-provided ipa-server
 * Obvious

freeipa-server.i686: E: non-standard-dir-perm /var/lib/ipa/sysrestore 0700L
 * Safe to ignore. This directory is intentionally root-only

freeipa-server.i686: E: non-standard-dir-perm /var/cache/ipa/kpasswd 0700L
 * Safe to ignore. This directory is intentionally root-only

freeipa-server.i686: E: non-standard-dir-perm /var/cache/ipa/sessions 0700L
 * Safe to ignore. This directory is intentionally root-only

freeipa-server.i686: W: no-manual-page-for-binary ipa-upgradeconfig
 * Upstream does not provide this manual

freeipa-server.i686: W: dangerous-command-in-%post mv
 * I don't know what the purpose of this is, so I can't say whether this is
valid.

freeipa-server.i686: E: incoherent-subsys /etc/rc.d/init.d/ipa dirsrv
 * ipa.init lists /var/lock/subsys/dirsrv, but it should be
/var/lock/subsys/ipa (it needs to match the initscript name)

freeipa-server.i686: W: no-reload-entry /etc/rc.d/init.d/ipa
 * Acceptable

freeipa-server-selinux.i686: E: explicit-lib-dependency libsemanage
 * RPM should autodetect library dependencies. Unless you need a specific
version, in which case that should be specified separately.

freeipa-server-selinux.i686: W: no-documentation
 * This should contain COPYING, README and Contributors.txt

freeipa-server-selinux.i686: W: dangerous-command-in-%pre cp
freeipa-server-selinux.i686: W: dangerous-command-in-%post rm
freeipa-server-selinux.i686: W: dangerous-command-in-%preun cp
freeipa-server-selinux.i686: W: dangerous-command-in-%postun rm
 * Please comment on this.



# MUST: The package must be named according to the Package Naming Guidelines .
The package name is wrong for this review. As pre-release material, it needs to
follow:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
which describes how to name a pre-release package from a source-control
snapshot so that it is clear what version of the sources it is based on.

In short, the package name, version and release here should be:
Name: freeipa
Version: 2.0.0
Release: 0.1.beta.git80e87e7

For future snapshots, you would increment release to 0.2.beta.git

# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
-= PASS =-

# MUST: The package must meet the Packaging Guidelines .
-= FAIL =-

The python sitelib and sitearch should be defines as follows:

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
-= PASS =-
License is GPLv3

# MUST: The License field in the package spec file must match the actual
license. [3]
-= PASS =-

# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
-= FAIL =-
This is missing from the freeipa-server-selinux subdirectory

# MUST: The spec file must be written in American English. [5]
-= PASS =-

# MUST: The spec file for the package MUST be legible. [6]

[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672764

Paul Howarth  changed:

   What|Removed |Added

 Depends on||665621
   Flag||fedora-cvs?

--- Comment #4 from Paul Howarth  2011-01-27 08:19:52 EST ---
Thanks for the review; I'll not request branches for older releases due to the
perl-JSON conflict.

New Package SCM Request
===
Package Name: perl-JSON-PP
Short Description: JSON::XS compatible pure-Perl module
Owners: pghmcfc
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672764

Bug 672764 depends on bug 665621, which changed state.

Bug 665621 Summary: perl-JSON-2.50 is available
https://bugzilla.redhat.com/show_bug.cgi?id=665621

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|NEW |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 646874] Review Request: rubygem-sequel - database toolkit for ruby

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646874

Guillermo Gómez  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE
Last Closed||2011-01-27 08:27:14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673115] New: Review Request: dee-qt - Qt bindings and QML plugin for Dee

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: dee-qt - Qt bindings and QML plugin for Dee

https://bugzilla.redhat.com/show_bug.cgi?id=673115

   Summary: Review Request: dee-qt - Qt bindings and QML plugin
for Dee
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jrez...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/dee-qt/dee-qt-0.1-0.1.bzr25.fc14.src.rpm
Description: Qt bindings and QML plugin for Dee.

rpmlint dee-qt-0.1-0.1.bzr25.fc14.src.rpm 
dee-qt.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in,
plugging
dee-qt.src: W: invalid-url Source0: dee-qt-0.1.bzr25.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source URL - pre-release snapshot.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2745501

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 576591] Review Request: iptraf-ng

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576591

--- Comment #17 from Terje Røsten  2011-01-27 08:50:35 
EST ---
Yes, seems good, thanks.

Will try to find free time to do the formal review soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673116] New: Review Request: perl-Test-Perl-Critic-Progressive - Gradually enforce coding standards

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Test-Perl-Critic-Progressive - Gradually enforce 
coding standards

https://bugzilla.redhat.com/show_bug.cgi?id=673116

   Summary: Review Request: perl-Test-Perl-Critic-Progressive -
Gradually enforce coding standards
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://ppisar.fedorapeople.org/perl-Test-Perl-Critic-Progressive/perl-Test-Perl-Critic-Progressive.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Test-Perl-Critic-Progressive/perl-Test-Perl-Critic-Progressive-0.03-1.fc15.src.rpm
Description: 
Applying coding standards to large amounts of legacy code is a daunting
task. Often times, legacy code is so non-compliant that it seems downright
impossible. But, if you consistently chip away at the problem, you will
eventually succeed! Test::Perl::Critic::Progressive uses the Perl::Critic
engine to prevent further deterioration of your code and gradually steer it
towards conforming with your chosen coding standards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

Paul Howarth  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Paul Howarth  2011-01-27 09:02:24 EST ---
I've trimmed the description in the spec now.

Thanks for the review.

New Package SCM Request
===
Package Name: perl-CPAN-Meta-YAML
Short Description: Read and write a subset of YAML for CPAN Meta files
Owners: pghmcfc
Branches: f13 f14 el4 el5 el6
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673115] Review Request: dee-qt - Qt bindings and QML plugin for Dee

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673115

Radek Novacek  changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||rnova...@redhat.com
 AssignedTo|nob...@fedoraproject.org|rnova...@redhat.com
   Flag||fedora-review+

--- Comment #1 from Radek Novacek  2011-01-27 09:21:27 EST 
---
This package looks alright. Setting review+.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672953] Review Request: python26-jsonschema - JSON Schema is a specification for defining the structure of JSON data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672953

--- Comment #2 from Jeffrey Ness  2011-01-27 
09:23:16 EST ---
Hello BJ,

Thanks for reviewing this package.

Spec URL: http://flip-edesign.com/source/junk/python26-jsonschema.spec
SRPM URL:
http://flip-edesign.com/source/junk/python26-jsonschema-0.2a-2.el5.src.rpm

Below is the rpmlint for SPEC and RPM:

---
$ rpmlint SPECS/python26-jsonschema.spec sh: /usr/bin/python2.6: No such file
or directorysh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
SPECS/python26-jsonschema.spec: W: invalid-url Source0:
http://jsonschema.googlecode.com/files/jsonschema-0.2a.tar.gz HTTP Error 404:
Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
/var/lib/mock/epel-5-i386-jeffrey.ness/result/python26-jsonschema-0.2a-2.el5.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
---

This package built successfully in mock using epel-5-i386
---

I have corrected each check you mentioned above, however I had to leave the
explicit attr on the .py files to resolves rpmlint errors:

$ rpmlint
/var/lib/mock/epel-5-i386-jeffrey.ness/result/python26-jsonschema-0.2a-2.el5.noarch.rpm
 
python26-jsonschema.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/jsonschema/__init__.py 0644L /usr/bin/env
python26-jsonschema.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/jsonschema/validator.py 0644L /usr/bin/env
1 packages and 0 specfiles checked; 2 errors, 0 warnings.
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673115] Review Request: dee-qt - Qt bindings and QML plugin for Dee

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673115

Jaroslav Reznik  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Jaroslav Reznik  2011-01-27 09:27:33 
EST ---
New Package SCM Request
===
Package Name: dee-qt
Short Description: Qt bindings and QML plugin for Dee
Owners: jreznik
Branches: f14
InitialCC: 

PS: f14 branch only for fedpkg bug, no intentions to push it there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673096] Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673096

Radek Novacek  changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||rnova...@redhat.com
 AssignedTo|nob...@fedoraproject.org|rnova...@redhat.com
   Flag||fedora-review+

--- Comment #1 from Radek Novacek  2011-01-27 09:42:53 EST 
---
This package looks alright. Setting review+.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672764

--- Comment #5 from Jason Tibbitts  2011-01-27 10:06:03 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

--- Comment #6 from Jason Tibbitts  2011-01-27 10:06:16 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664615] Review Request: vorbisspi - Java Service Provider Interface for the OGG Vorbis audio format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664615

--- Comment #6 from Jason Tibbitts  2011-01-27 10:04:57 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 646836] Review Request: rubygem-bundler - The best way to manage your application's dependencies

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646836

--- Comment #18 from Jason Tibbitts  2011-01-27 10:04:44 EST 
---
Please submit a proper SCM request and re-raise the fedora-cvs flag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 670451] Review Request: async-http-client - Asynchronous Http Client for Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670451

--- Comment #8 from Jason Tibbitts  2011-01-27 10:05:49 EST 
---
Git done (by process-git-requests).

There's a simpler workaround than making a branch you don't need, though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

--- Comment #3 from Jason Tibbitts  2011-01-27 10:06:28 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655

--- Comment #102 from Jason Tibbitts  2011-01-27 10:03:49 
EST ---
The requested package name doesn't match what's in the ticket summary.
Please fix either the ticket summary or the SCM request and re-raise the
fedora-cvs flag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673115] Review Request: dee-qt - Qt bindings and QML plugin for Dee

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673115

Jason Tibbitts  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs-

--- Comment #3 from Jason Tibbitts  2011-01-27 10:08:49 EST 
---
Could we get some actual review here?  Given that the package fails to meet the
naming guidelines (as there's no date in the package version), I'm not sure how
much review was actually done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 467655] Review Request: YafaRay - A free open-source raytracing render engine

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655

Paulo Roma Cavalcanti  changed:

   What|Removed |Added

Summary|Review Request: yafaray - a |Review Request: YafaRay - A
   |raytracer for Blender.  |free open-source raytracing
   ||render engine

--- Comment #103 from Paulo Roma Cavalcanti  2011-01-27 
10:13:19 EST ---
New Package SCM Request
===
Package Name: YafaRay
Short Description: A free open-source raytracing render engine
Owners: roma
Branches: f13 f14 el5 el6
InitialCC:roma

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 467655] Review Request: YafaRay - A free open-source raytracing render engine

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655

Paulo Roma Cavalcanti  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673096] Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673096

--- Comment #2 from Jason Tibbitts  2011-01-27 10:17:13 EST 
---
This one fails to meet the naming guidelines as well.  Come on, the package
review process isn't supposed to be a mere formality.

Won't be processing any SCM requests for package you're reviewed in this
manner.  Please do proper reviews.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 467655] Review Request: YafaRay - A free open-source raytracing render engine

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655

--- Comment #104 from Jason Tibbitts  2011-01-27 10:27:15 
EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664615] Review Request: vorbisspi - Java Service Provider Interface for the OGG Vorbis audio format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664615

--- Comment #7 from Fedora Update System  2011-01-27 
10:46:49 EST ---
vorbisspi-1.0.3-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/vorbisspi-1.0.3-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664615] Review Request: vorbisspi - Java Service Provider Interface for the OGG Vorbis audio format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664615

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673172] New: Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies 
which have been superseded by others

https://bugzilla.redhat.com/show_bug.cgi?id=673172

   Summary: Review Request: perl-Perl-Critic-Deprecated -
Perl::Critic policies which have been superseded by
others
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Deprecated/perl-Perl-Critic-Deprecated.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Deprecated/perl-Perl-Critic-Deprecated-1.108-1.fc15.src.rpm
Description: 
The included policies are:
  - Write "$my_variable = 42" instead of "$MyVariable = 42".
  - Write "sub my_function{}" instead of "sub MyFunction{}".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 634911] Review Request: nodejs - Evented I/O for v8 JavaScript

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634911

--- Comment #15 from Patrice FERLET  2011-01-27 11:15:06 EST 
---
Hi,

Sorry for my late answer, I'm currently moving out into a new apartment and my
network connexion wasn't fully working.

I looked the comment #8 and I can say that 99% of points you underlined are
corrects with my spec file.

Only one is complex: lib dir.

In fact, every files are "javascript sources", so they are not platform
depedents... I wonder if I can move it to "/usr/share" directory... I'm looking
how it's setup.

I made 3 packages because devel files are not required to develop some
applications with node.js

I use another name, according to an already existing package named "node". Can
you check my spec file ?

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673175] New: Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mnogosearch - Web indexing and search system for a 
small domain or intranet

https://bugzilla.redhat.com/show_bug.cgi?id=673175

   Summary: Review Request: mnogosearch - Web indexing and search
system for a small domain or intranet
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: g...@egidy.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://developer.intra2net.com/git/?p=mnogosearch-rpm;a=blob_plain;f=mnogosearch.spec;h=9a9eda60d14b34b08f5508154efab408c691760b
SRPM URL:
http://developer.intra2net.com/git/?p=mnogosearch-rpm;a=blob;f=mnogosearch-3.3.11-1.src.rpm;h=57b987c7d8b12a5d432d58c7b3464da6d1ad8932

Gitweb for all packaging related files:
http://developer.intra2net.com/git/?p=mnogosearch-rpm

Description:

I packaged the mnogosearch search engine and it would be nice if someone
could review it so it can be included in Fedora Extras.

mnogosearch was considered for use in the Fedora search infrastructure, see
http://fedoraproject.org/wiki/Infrastructure/Search

This is my first Fedora package, so I'm looking for a sponsor too.

While packaging I worked closely together with the upstream maintainer,
Alexander Barkov. He helped me to make mnogosearch adhere to the FHS
and meet other requirements from the Fedora packaging guidelines. The
fixes we developed are all included in the upstream release 3.3.11.

Description of the program as in the .spec:

mnoGoSearch (formerly known as UdmSearch) is a full-featured Web search engine
that you can use to build search engines over HTTP, HTTPS, FTP, and NTTP
servers, local files, and database big text fields. It supports Oracle, MS SQL
Server, MySQL, PostgreSQL, InterBase/Firebird, Openlink Virtuoso, Intersystems
Cach, iODBC, EasySoft ODBC, and unixODBC database backends. It has XML, HTML,
and TEXT built-in support, and external converters support for other document
types. An automatic language/charset guesser for more 70 language/charset
combinations is included, along with basic authorization support, and you may
index password-protected intranet HTTP servers with proxy authorization
support.

mnoGoSearch is built with support for mysql (including fulltext extension),
sqlite, postgresql, firebird, unixODBC and freetds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673175] Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673175

Gerd v. Egidy  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 566598] Review Request: cover-thumbnailer - Display music cover and more in nautilus

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566598

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673175] Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673175

--- Comment #1 from Gerd v. Egidy  2011-01-27 11:24:50 EST ---
Testing done:

I have successfully built the package on i686 and x86_64.

I manually checked the program on both architectures in the default
configuration and everything seemed fine.

The upstream maintainer Alexander Barkov checked and approved the default
configuration and other issues like file permissions.

rpmlint run on the installed rpms:

mnogosearch.i686: W: spelling-error %description -l en_US iODBC -> ABC, ADC,
OTB
mnogosearch.i686: W: spelling-error %description -l en_US unixODBC -> exotic,
animistic, inexorable
mnogosearch.i686: W: spelling-error %description -l en_US backends -> back
ends, back-ends, bookends
mnogosearch.i686: W: spelling-error %description -l en_US charset -> char set,
char-set, chaste
mnogosearch.i686: W: spelling-error %description -l en_US fulltext -> full
text, full-text, faultiest
mnogosearch.i686: W: spelling-error %description -l en_US postgresql ->
picturesquely, paradoxical, paradoxically
mnogosearch.i686: W: spelling-error %description -l en_US firebird -> fire
bird, fire-bird, forebode
mnogosearch.i686: W: spelling-error %description -l en_US freetds -> frets,
ferrets, fretted

> I'd say these are all false positives and the spelling is ok.

mnogosearch.i686: W: non-standard-gid /etc/mnogosearch mnogosearch
mnogosearch.i686: E: non-standard-dir-perm /etc/mnogosearch 0750L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/search.htm mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/search.htm 0640L
mnogosearch.i686: W: non-standard-uid /var/lib/mnogosearch mnogosearch
mnogosearch.i686: W: non-standard-gid /var/lib/mnogosearch mnogosearch
mnogosearch.i686: E: non-standard-dir-perm /var/lib/mnogosearch 0750L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/stopwords.conf
mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/stopwords.conf 0640L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/node.xml mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/node.xml 0640L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/indexer.conf mnogosearch
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/langmap.conf mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/langmap.conf 0640L

> There is a reason I don't allow world read access to the config files:
> Usually there are database access credentials in plaintext contained in them.
> This is stated as comment in the .spec

mnogosearch.i686: E: executable-marked-as-config-file
/etc/mnogosearch/indexer.conf

> This is a feature of the mnogosearch default config:
> it contains a shebang, so you can directly call it. It then uses this config 
> to
> call the indexer.
> This is stated as comment in the .spec

mnogosearch.i686: W: no-manual-page-for-binary mguesser
mnogosearch.i686: W: no-manual-page-for-binary mconv
mnogosearch.i686: W: no-manual-page-for-binary mnogosearch-reindex

> mnogosearch does not provide these man pages. The upstream maintainer told me
> he'll look into improving the man pages.

mnogosearch.i686: W: dangerous-command-in-%post chown

> The mnogosearch user must be owner of the default database. Otherwise 
> searching
> and indexing won't work as expected.

mnogosearch-libs.i686: W: no-documentation
mnogosearch-devel.i686: W: no-documentation

> The documentation is all in the %doc section of the main package.

mnogosearch-devel.i686: W: no-manual-page-for-binary udm-config

> mnogosearch does not provide a man page for the devel-configuration program.

mnogosearch-php.i686: W: no-documentation

> The documentation is all in the %doc section of the main package.

mnogosearch-php.i686: W: non-conffile-in-etc /etc/php.d/mnogosearch.ini

> The file is to inform php about a new extension. There is no need for a user
> to ever modify this file.

rpmlint run on the src.rpm:

mnogosearch.src: W: spelling-error %description -l en_US iODBC -> iodic,
iodous, iodism
mnogosearch.src: W: spelling-error %description -l en_US unixODBC -> unixism,
Unicode, unilobed
mnogosearch.src: W: spelling-error %description -l en_US backends -> backbends,
back ends, back-ends
mnogosearch.src: W: spelling-error %description -l en_US charset -> char set,
char-set, chars et
mnogosearch.src: W: spelling-error %description -l en_US combinations ->
combination, combination's, comminations
mnogosearch.src: W: spelling-error %description -l en_US mysql -> mys ql,
mys-ql, myself
mnogosearch.src: W: spelling-error %description -l en_US fulltext -> full text,
full-text, Fullerton
mnogosearch.src: W: spelling-error %description -l en_US sqlite -> sq lite,
sq-lite, stylite
mnogosearch.src: W: spelling-error %description -l en_US postgresql ->
postgraduate, postglacial, postmistress
mnogosearch.src: W: spelling-error %description -l en_US freetds ->

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 633333] Review Request: iosum - An I/O bandwidth and syscall summarizer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=63

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 619228] Review Request: shellinaboxd - AJAX based terminal emulator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619228

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

--- Comment #5 from Fedora Update System  2011-01-27 
11:30:12 EST ---
perl-CPAN-Meta-YAML-0.003-3.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 635256] Review Request: qtop - tool for monitoring PBS systems

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635256

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 627637] Review Request: qroneko - A front end of crontab application

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627637

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 633104] Review Request: monkeysphere - Use the OpenPGP web of trust to verify ssh connections

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633104

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

--- Comment #6 from Fedora Update System  2011-01-27 
11:30:19 EST ---
perl-CPAN-Meta-YAML-0.003-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672807] Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672807

--- Comment #4 from Fedora Update System  2011-01-27 
11:30:06 EST ---
perl-CPAN-Meta-YAML-0.003-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 642547] Review Request: ucd - Property data for the Unicode data set

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642547

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

--- Comment #8 from Fedora Update System  2011-01-27 
11:37:45 EST ---
perl-Perl-OSType-1.002-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Perl-OSType-1.002-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

--- Comment #9 from Fedora Update System  2011-01-27 
11:37:51 EST ---
perl-Perl-OSType-1.002-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Perl-OSType-1.002-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

--- Comment #7 from Fedora Update System  2011-01-27 
11:37:38 EST ---
perl-Perl-OSType-1.002-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Perl-OSType-1.002-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672801] Review Request: perl-Perl-OSType - Map Perl operating system names to generic types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672801

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673175] Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673175

Gerd v. Egidy  changed:

   What|Removed |Added

  Alias||mnogosearch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 619228] Review Request: shellinaboxd - AJAX based terminal emulator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619228

--- Comment #7 from Jochen Wiedmann  2011-01-27 
12:06:01 EST ---
That's a little bit unfair, to consider me "stalled" after basically one week.
I am doing my best, but like most of you, I am involved in a lot of open source
projects and it's difficult to find some spare cycles.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 619228] Review Request: shellinaboxd - AJAX based terminal emulator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619228

--- Comment #8 from Jason Tibbitts  2011-01-27 12:16:06 EST 
---
Not unfair at all.  The process is stalled on you; nobody should invest their
time reviewing this further if they don't know that you will reply.  There are
far too many package review tickets in the queue to expect someone to read one,
determine that things are waiting on you, and go onto another, so I annotate
them as such.

The ticket is still open, though even if it were closed it would still be
possible to reopen it.  I just don't see what the big deal is.  Work on it on
your schedule, clear the whiteboard when you're done.  Just don't expect us to
keep looking at the ticket until you've done that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 671024] Review Request: wallpaperd - Background setter supporting random images and per-workspace images

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671024

--- Comment #3 from Germán Racca  2011-01-27 12:23:17 EST ---
Hi Mohamed:

I've compiled the package with libXrandr-devel as BR, so please check that it
works as intended, because I don't have that possibility now.

SPEC: http://skytux.fedorapeople.org/packages/wallpaperd.spec
SRPM: http://skytux.fedorapeople.org/packages/wallpaperd-0.2.0-2.fc14.src.rpm

Cheers,
Germán.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665560] Review Request: rubygem-mail - A Really Ruby Mail Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665560

--- Comment #16 from Minnikhanov  2011-01-27 12:18:56 
EST ---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-mail.spec
SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.14-5.fc14.src.rpm

(In reply to comment #14)
> * Could you put the BuildRequires you just added onto separate lines. A style
> things yes, and not a blocker, but still I feel it makes it more legible

+ Fixed. (I saw like that anywhere, nothing else)

> * Why did you add the sections in %prep to "fix anything executable that
> doesn't have a shebang" and "find files with a shebang that don't have
> executable permissions". Looking at the gem there are no executable files nor
> files that should be so I'm not sure what these blocks are trying to 
> accomplish
> 

+ Fixed. Remove these.

> * rpmlint complains about a missing %clean section, could you please add it,
> even if it is empty
> 

- Not need by Comment 15.

> * building the rpm results in an error stating the LICENSE.rdoc file cannot be
> found. Where are you getting this? If no such file exists could you please
> remove it from the %files section
> 

+ Fixed. (sorry)

> * additionally building the rpm outputs that the Gemfile.lock file is not
> listed in %files. Furthermore the Gemfile is listed as a file in the doc
> subpackage, which is incorrect as its needed by the mail runtime. Please put
> both Gemfile and Gemfile.lock in the main package %files section (not marked 
> as
> %doc either)

+ Fixed. 
There is not 'Gemfile.lock' in upstream - create this file by 'touch' in %prep.
Is this right?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673172

Petr Pisar  changed:

   What|Removed |Added

 Blocks||673197

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673197] Review Request: perl-Perl-Critic-Bangs - Collection of handy Perl::Critic policies

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673197

Petr Pisar  changed:

   What|Removed |Added

 Depends on||673172

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673197] New: Review Request: perl-Perl-Critic-Bangs - Collection of handy Perl::Critic policies

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Perl-Critic-Bangs - Collection of handy 
Perl::Critic policies

https://bugzilla.redhat.com/show_bug.cgi?id=673197

   Summary: Review Request: perl-Perl-Critic-Bangs - Collection of
handy Perl::Critic policies
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Bangs/perl-Perl-Critic-Bangs.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Perl-Critic-Bangs/perl-Perl-Critic-Bangs-1.06-1.fc15.src.rpm
Description:
The rules included with the Perl::Critic::Bangs group include:
  - Commented-out code is usually noise.  It should be removed.
  - Watch for comments like "XXX", "TODO", etc.
  - Tests should have a plan.
  - Variables like $user and $user2 are insufficiently distinguished.
  - Determining the class in a constructor by using "ref($proto) || $proto".
  - Adding modifiers to a regular expression made up entirely of a variable
  created with qr() is usually not doing what you expect.
  - Vague variables like $data or $info are not descriptive enough.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672986] Review Request: freeipa - The Identity, Policy and Audit system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672986

Rob Crittenden  changed:

   What|Removed |Added

   Flag|needinfo?(rcritten@redhat.c |
   |om) |

--- Comment #2 from Rob Crittenden  2011-01-27 12:36:00 
EST ---
Spec URL: http://rcritten.fedorapeople.org/freeipa.spec
SRPM URL:
http://rcritten.fedorapeople.org/freeipa-2.0.0-0.2.beta.git442d6ad.fc14.src.rpm

For the Obsoletes the way I read the packaging guidelines is if it is not an
upgradable package then having just Obsoletes is ok.

I went without noreplace on the bash_completion.d script, our update should
take priority.

The zero-length /etc/ipa/default.conf is our package owns the file. It should
have been ghosted but was actually referenced twice in the spec file, once in
the server subpackage and once in the python subpackage. I removed the server
reference and added ghost to the python subpackage.

I added comments about the "dangerous" mv and cp references. They are primarily
for maintaining proper state while we load custom SELinux policy.

One mv was removed as it is no longer needed.

I added the python conditionals, it seems that we could remove this whole block
completely since we don't support older versions of RHEL or Fedora. It doesn't
hurt anything though.

I added a %doc to the server-selinux package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 596138] Review Request: nss-gui - A graphical user interface for NSS security databases

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596138

Jason Tibbitts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu
   Flag|needinfo?(nott...@redhat.co |fedora-review?
   |m)  |

--- Comment #17 from Jason Tibbitts  2011-01-27 12:35:20 EST 
---
Sorry for the wait; my time is limited and there are very many package review
tickets that need attention.

Indeed, the 0.3.6 version starts in rawhide and seems to function well enough.

I note that there's only the MPL license text included.  It's not essential,
but generally in that situation I'd ask you to ask upstream to consider adding
the other valid license texts as well (GPL and LGPL).  Since you're upstream,
though, I guess that skips a step.

I assume you want to push this to el5, since it appears to have a sufficiently
new xulrunner.  If not, however, you can remove BuildRoot, %clean and the first
line of %install.

It is not necessary for you to manually specify a dependency on
boost-program-options; rpm finds that out on its own.

This needs a .desktop file. 
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files


* source files match upstream.  sha256sum:
  907e3b93d17470fc0625376057e6b88ffd5213eea76aa3fb19820c9b03059ee4
   nss-gui-0.3.6.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package (though not all license texts are
available).
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
X final provides and requires:
   nss-gui = 0.3.6-1.fc15
   nss-gui(x86-64) = 0.3.6-1.fc15
  =
X  boost-program-options (unnecessary)
   libboost_program_options.so.1.44.0()(64bit)  
   libgcc_s.so.1()(64bit)  
   libgcc_s.so.1(GCC_3.0)(64bit)  
   libstdc++.so.6()(64bit)  
   libstdc++.so.6(CXXABI_1.3)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4)(64bit)  
   xulrunner >= 1.9.2.2

* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X This is a GUI application, but the .desktop file is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 592487] Review Request: ffgtk - A solution for controlling Fritz!Box or compatible routers

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592487

--- Comment #19 from Jason Tibbitts  2011-01-27 12:38:44 EST 
---
Finally FPC was able to discuss this, and this md5 implementation was exempted
from the rule about bundled libraries.  Please add:
  Provides: bundled(md5-deutsch)
to the package and I'll approve this.

The provide makes it easy for us to look for packages that bundle this code in
case a security issue is found, or in case someone packages up a compatible
library and is looking to port packages over to using it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

--- Comment #5 from Andrew McNabb  2011-01-27 12:46:41 EST 
---
I also don't see a %files section.  Is that somehow included by
%{?ghc_lib_package}?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

--- Comment #6 from Andrew McNabb  2011-01-27 13:05:25 EST 
---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > 1) These errors from rpmlint should be fixed if possible:
> > > > 
> > > > ghc-pcre-light-prof.x86_64: E: devel-dependency ghc-pcre-light-devel
> > > > ghc-pcre-light-prof.x86_64: W: devel-file-in-non-devel-package
> > > > /usr/lib64/ghc-6.12.3/pcre-light-0.4/libHSpcre-light-0.4_p.a
> > > 
> > > Standard Haskell packaging things. These files are used when profiling 
> > > the code
> > > which implies that the -devel package exist.
> > 
> > Shouldn't the libHSpcre-light-0.4_p.a appear in the devel package rather 
> > than
> > in the main package?
> 
> The _p is the profiling library. The -devel library does not have it.

So it looks like RPM is complaining because the ghc-pcre-light-prof package
contains a .a file, but ghc-pcre-light-prof isn't a devel package.  This seems
like a legitimate error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672953] Review Request: python26-jsonschema - JSON Schema is a specification for defining the structure of JSON data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672953

--- Comment #3 from BJ Dierkes  2011-01-27 13:06:54 EST 
---
It appears that rpmlint is throwing those warnings because those two files have
a shebang line of #!/usr/bin/env (making rpmlint think they are a script and
need 755).  Python library files should not have a sheband line... it is
required to patch/sed/etc the files to remove the shebang, and also recommended
to notify upstream to influence them to remove the shebang from all library
files (not scripts... just the modules).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 667155] Review Request: python26-httplib2 - A comprehensive HTTP client library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=667155

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System  
2011-01-27 13:22:41 EST ---
python26-httplib2-0.6.0-2.el5 has been pushed to the Fedora EPEL 5 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python26-httplib2'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/python26-httplib2-0.6.0-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668591

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System  
2011-01-27 13:23:37 EST ---
python26-markupsafe-0.11-3.el5 has been pushed to the Fedora EPEL 5 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python26-markupsafe'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/python26-markupsafe-0.11-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 668588] Review Request: python26-imaging - Python's own image processing library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668588

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2011-01-27 
13:23:43 EST ---
python26-imaging-1.1.7-4.el5 has been pushed to the Fedora EPEL 5 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python26-imaging'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/python26-imaging-1.1.7-4.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 620385] Review Request: BEDTools - A flexible suite of utilities for comparing genomic features

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620385

--- Comment #23 from Fedora Update System  
2011-01-27 13:24:09 EST ---
BEDTools-2.10.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 620385] Review Request: BEDTools - A flexible suite of utilities for comparing genomic features

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620385

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version||BEDTools-2.10.1-1.el5
 Resolution|CURRENTRELEASE  |ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 673175] Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673175

--- Comment #2 from Gerd v. Egidy  2011-01-27 13:28:39 EST ---
I have made some last-minute fixes, updated files can be found here:

SPEC:
http://developer.intra2net.com/git/?p=mnogosearch-rpm;a=blob_plain;f=mnogosearch.spec;h=3e64967ad28a08b0976822d5a4f5278fee48bc24

SRPM:
http://developer.intra2net.com/git/?p=mnogosearch-rpm;a=blob;f=mnogosearch-3.3.11-2.src.rpm;h=eed4c297f028fdceaf52db4cbea88ade15e70167

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672953] Review Request: python26-jsonschema - JSON Schema is a specification for defining the structure of JSON data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672953

--- Comment #4 from Jeffrey Ness  2011-01-27 
13:48:13 EST ---
Hey BJ,

Thanks for clearing a few things up as far as Python modules and executables, I
have followed the Fedora Documentation to remove the shebang:

 
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries

Spec URL: http://flip-edesign.com/source/junk/python26-jsonschema.spec
SRPM URL:
http://flip-edesign.com/source/junk/python26-jsonschema-0.2a-3.el5.src.rpm
--

$ rpmlint SPECS/python26-jsonschema.spec 
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
SPECS/python26-jsonschema.spec: W: invalid-url Source0:
http://jsonschema.googlecode.com/files/jsonschema-0.2a.tar.gz HTTP Error 404:
Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
/var/lib/mock/epel-5-i386-jeffrey.ness/result/python26-jsonschema-0.2a-3.el5.noarch.rpm
 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--

Upstream has been notified:
http://code.google.com/p/jsonschema/issues/detail?id=22

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 652987] Review Request: go - The Go programming language

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652987

--- Comment #23 from Renich Bon Ciric  2011-01-27 
13:48:18 EST ---
Guys, for what is worth, here's a spec that builds.
http://fedorapeople.org/~renich/go.spec


Can somebody tell me what to do with the go/src dir? It seems applications
need, at least, the Make.inc and Make.pkg files in order to compile:

Example:
http://www.getwebgo.com/ (this one is used by other go projects as well)
  -> https://github.com/hoisie/web.go/blob/master/Makefile#L1

I could put it in /usr/share/go and add a symlink maybe? Or put the Make.* in
/usr/lib64/go/src ???

/me is a newbie packager!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 205269] Review Request: perl-Sub-Exporter - Sophisticated exporter for custom-built routines

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=205269

--- Comment #3 from Fedora Update System  2011-01-27 
14:03:17 EST ---
perl-Package-Generator-0.100-2.el4 has been submitted as an update for Fedora
EPEL 4.
https://admin.fedoraproject.org/updates/perl-Package-Generator-0.100-2.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 205249] Review Request: perl-Data-OptList - Parse and validate simple name/value option pairs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=205249

--- Comment #5 from Fedora Update System  2011-01-27 
14:06:44 EST ---
perl-Data-OptList-0.101-2.el4 has been submitted as an update for Fedora EPEL
4.
https://admin.fedoraproject.org/updates/perl-Data-OptList-0.101-2.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 205267] Review Request: perl-Package-Generator - Generate new packages quickly and easily

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=205267

--- Comment #5 from Fedora Update System  2011-01-27 
14:04:37 EST ---
perl-Package-Generator-0.100-2.el4 has been submitted as an update for Fedora
EPEL 4.
https://admin.fedoraproject.org/updates/perl-Package-Generator-0.100-2.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

Jason Tibbitts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu
   Flag||fedora-review?

--- Comment #39 from Jason Tibbitts  2011-01-27 14:09:51 EST 
---
As much as I think this kind of thing is distasteful, I can't think of a better
way to avoid the bundling issue while still allowing upx in the distribution. 
Not that I really see the point of upx, but that's not up to me.

Not sure if this submission is sufficiently old that it predates the new
unnecessity of buildroot, but just to be sure: if you don't want to build this
for el4 or el5, you can remove BuildRoot:, %clean and the first line of
%install.

Is there any file in this package that should remain executable?  If not,
perhaps simply all of the find calls with just
  find . -type f -exec chmod -x {} \;
or whatever your preferred variant is?

And while I'm in %prep:
Why not use %setup -c instead of doing everything manually?  Seems that would
simply things a good bit.

There are a few line endings that need encoding:
  lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
   /usr/share/doc/lzma-sdk-4.6.5/7zFormat.txt
   /usr/share/doc/lzma-sdk-4.6.5/7zC.txt
   /usr/share/doc/lzma-sdk-4.6.5/history.txt
   /usr/share/doc/lzma-sdk-4.6.5/lzma.txt
   /usr/share/doc/lzma-sdk-4.6.5/Methods.txt
   /usr/share/doc/lzma-sdk-4.6.5/7zFormat.txt
   /usr/share/doc/lzma-sdk-4.6.5/7zC.txt
   /usr/share/doc/lzma-sdk-4.6.5/history.txt
   /usr/share/doc/lzma-sdk-4.6.5/lzma.txt
   /usr/share/doc/lzma-sdk-4.6.5/Methods.txt

I really hate thinking about this kind of thing, but any time you see "Public
Domain" you have to worry.  I've asked the legal list if this is properly
public domain.

I think the perl(SevenZip) provide is bogus.  I can't imagine where it's coming
from, unless rpm is on enough crack to parse
  package SevenZip;
out of Java/SevenZip/CRC.java or Java/SevenZip/LzmaAlone.java.  Actually, I
think that is where it comes from.  Needs to be filtered in any case.

* source files match upstream.  sha256sum:
  c935fd04dd8e0e8c688a3078f3675d699679a90be81c12686837e0880aa0fa1e
   lzma465.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
? license field matches the actual license.
* BuildRequires are proper (none).
* package builds in mock (rawhide, x86_64).
* package installs properly.
X rpmlint has valid complaints.
X final provides and requires:
X  perl(SevenZip)  
   lzma-sdk = 4.6.5-1.fc15
  =
   (no requires)

* no bundled libraries.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 609817] Review Request: dojo - Modular JavaScript toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609817

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

--- Comment #40 from Jason Tibbitts  2011-01-27 14:24:23 EST 
---
And it's looking like the answer is no, this is not public domain software. 
The effects of this are unpleasant.  I think at this point spot is trying to
get in contact with the author to get a permissive license placed on the code.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 620112] Review Request: udpxy - UDP-to-HTTP multicast traffic relay daemon

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620112

--- Comment #7 from Jason Tibbitts  2011-01-27 14:31:59 EST 
---
The current version seems to be 1.0-Cuipmunk-19, whatever that is.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

--- Comment #7 from Ben Boeckel  2011-01-27 14:32:40 EST ---
(In reply to comment #6)
> So it looks like RPM is complaining because the ghc-pcre-light-prof package
> contains a .a file, but ghc-pcre-light-prof isn't a devel package.  This seems
> like a legitimate error.

It's standard Haskell packaging. I'll have Jens verify.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664615] Review Request: vorbisspi - Java Service Provider Interface for the OGG Vorbis audio format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664615

Alexander Kurtakov  changed:

   What|Removed |Added

 Blocks|652183(FE-JAVASIG)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

--- Comment #41 from Jon Ciesla  2011-01-27 14:49:34 EST ---
Bah.  Thank you.  Let me know the outcome.  If that fails, I'll just have to
withdraw this and pull upx.  And then probably ucl, since upx is the only thing
using it. . .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #8 from Minnikhanov  2011-01-27 15:13:46 EST 
---
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-5.fc14.src.rpm 

koji scratch build: green
http://koji.fedoraproject.org/koji/taskinfo?taskID=2746333 
TEST DON'T PASS. 
Packages built.


(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> To get around the failed tests you will need the following which I've added to
> all the other rails 3 rpms:
> 
> --- test/abstract_unit.rb.orig  2011-01-26 22:08:06.697352089 -0500
> +++ test/abstract_unit.rb   2011-01-26 22:53:04.463351981 -0500
> @@ -1,4 +1,4 @@
> -require File.expand_path("../../../load_paths", __FILE__)
> +require 'rubygems'
> 
>  require 'stringio'
>  require 'test/unit'

+ Fixed.

> 
> This will only get you to another set of errors. Looking into those its
> apparent that the railties test suite is dependent on the rails gem itself to
> work, introducing a circular dependency, thus cannot be included in the rpm. I
> verified the functionality though through use via the rubygem-rails package.
> 
> With this you can remove (or at least comment out) quite a few things relating
> to the test suite. Also remove the bits deleting the .empty_directory files.
> After that I'll approve.

I saw test suite and look only circular dependency to rails's gems. I am not
ready break these loops.

May I offer:
1. Remove all test suite.
2. Build clear gem rpm.
3. Prepare test suite rpm. 
3. After build all rpms, build test suite rpm and run it.

Source 'railties' found in the same git-repo where found 'rails' and other
basis of rails.
Rails's developer tests all together.
My opinion we must go the same way - 
1 - Build all, 2 - Install all, 3 - Test all after all.

PS. Packages that can test separately, build with test suite. For another
packages make separate post-build/installation test-suite rpm.
railties-test-rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672986] Review Request: freeipa - The Identity, Policy and Audit system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672986

Stephen Gallagher  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Stephen Gallagher  2011-01-27 15:28:37 
EST ---
This package has passed review. Next step is to request an SCM branch.

http://fedoraproject.org/wiki/Package_SCM_admin_requests

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 672986] Review Request: freeipa - The Identity, Policy and Audit system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672986

Rob Crittenden  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Rob Crittenden  2011-01-27 15:49:32 
EST ---
New Package SCM Request
===
Package Name: freeipa
Short Description: The Identity, Policy and Audit system
Owners: rcritten simo
Branches:
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669868] Review Request: perl-Bencode - BitTorrent serialization format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669868

--- Comment #7 from Fedora Update System  2011-01-27 
15:54:49 EST ---
perl-Bencode-1.4-1.fc14 has been pushed to the Fedora 14 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669868] Review Request: perl-Bencode - BitTorrent serialization format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669868

--- Comment #8 from Fedora Update System  2011-01-27 
15:58:43 EST ---
perl-Bencode-1.4-1.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669872] Review Request: perl-Convert-Bencode_XS - Faster conversions to/from Bencode format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669872

--- Comment #7 from Fedora Update System  2011-01-27 
15:56:58 EST ---
perl-Convert-Bencode_XS-0.06-1.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669868] Review Request: perl-Bencode - BitTorrent serialization format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669868

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Bencode-1.4-1.fc14
 Resolution||ERRATA
Last Closed||2011-01-27 15:54:56

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669869

--- Comment #7 from Fedora Update System  2011-01-27 
15:57:30 EST ---
perl-Convert-Bencode-1.03-1.fc14 has been pushed to the Fedora 14 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669869

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Convert-Bencode-1.03-1
   ||.fc14
 Resolution||ERRATA
Last Closed||2011-01-27 15:57:35

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 669872] Review Request: perl-Convert-Bencode_XS - Faster conversions to/from Bencode format

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669872

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Convert-Bencode_XS-0.0
   ||6-1.fc13
 Resolution||ERRATA
Last Closed||2011-01-27 15:57:03

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review