[Bug 677297] New: Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding https://bugzilla.redhat.com/show_bug.cgi?id=677297 Summary: Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: terje...@phys.ntnu.no QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora spec: http://terjeros.fedorapeople.org/php-pear-Net-IDNA2/php-pear-Net-IDNA2.spec srpm: http://terjeros.fedorapeople.org/php-pear-Net-IDNA2/php-pear-Net-IDNA2-0.1.1-2.fc14.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2838611 desc: This package helps you to encode and decode punycode strings easily in PHP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677297] Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677297 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Blocks||673572 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677300] New: Review Request: gtksourviewmm3 - A C++ wrapper for gtksourceview3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gtksourviewmm3 - A C++ wrapper for gtksourceview3 https://bugzilla.redhat.com/show_bug.cgi?id=677300 Summary: Review Request: gtksourviewmm3 - A C++ wrapper for gtksourceview3 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: karlthe...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://hguemar.fedorapeople.org/packages/gtksourceviewmm3.spec SRPM URL: http://hguemar.fedorapeople.org/packages/gtksourceviewmm3-2.91.5-1.fc15.src.rpm Description: gtksourceviewmm is a C++ wrapper for the gtksourceview widget library. It offers all the power of gtksourceview with an interface familiar to c++ developers, including users of the gtkmm library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added CC||karlthe...@gmail.com AssignedTo|nob...@fedoraproject.org|karlthe...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672764] Review Request: perl-JSON-PP - JSON::XS compatible pure-Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672764 Paul Howarth p...@city-fan.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-JSON-PP-2.27104-3.fc15 Resolution||RAWHIDE Last Closed||2011-02-14 05:19:53 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-02-14 07:03:02 EST --- gxneur-0.12.0-3.svn859.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gxneur-0.12.0-3.svn859.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2011-02-14 07:04:27 EST --- gxneur-0.12.0-3.svn859.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/gxneur-0.12.0-3.svn859.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673839] Review Request: boost141 - The free peer-reviewed portable C++ source libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673839 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added CC||denis.arnaud_fed...@m4x.org --- Comment #18 from Denis Arnaud denis.arnaud_fed...@m4x.org 2011-02-14 08:55:35 EST --- Note that (sorted from the most recent to the oldest) bug #656410, bug #607615 and bug #529563 may be worth a look, as they track Fedora packaging for Boost. FYI, we (Petr Machata and Benjamin Koznik, the official packagers, and I) are now packaging Boost-1.46 (or, at least, attempting to do so), thanks to a cmake-ify patch, which does the job. I do not see any reason why you could not re-use that work. Of course, whether there will be an upgrade of Boost on RHEL/EPEL is another story... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #4 from Martin Gieseking martin.giesek...@uos.de 2011-02-14 09:54:50 EST --- The source archive contains prebuilt binaries in src/. These must be removed to ensure that all binaries are newly created during the build process. Thus, add the following lines to %prep: cd src rm -rf .libs .deps *.o *.lo *.la I also recommend to checkout the sources with svn export to avoid creating .svn directories. Since you grabbed the sources from the svn trunk, the package provides a snapshot release. Please see here how to reflect this in the Release field: http://fedoraproject.org/wiki/PackageNamingGuidelines#Snapshot_packages If you want to maintain this package for EPEL 6 too, you must add a %clean section. Otherwise, don't remove %clean only but also drop the BuildRoot tag and rm -rf $RPM_BUILD_ROOT (in %install). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] (fritzing) Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 Ed Marshall esm+red...@logic.net changed: What|Removed |Added Alias||fritzing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] (fritzing) Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 Ed Marshall esm+red...@logic.net changed: What|Removed |Added Summary|Review Request: fritzing - |(fritzing) Review Request: |Intuitive EDA platform from |fritzing - Intuitive EDA |prototype to product|platform from prototype to ||product -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 Ed Marshall esm+red...@logic.net changed: What|Removed |Added Summary|(fritzing) Review Request: |Review Request: fritzing - |fritzing - Intuitive EDA|Intuitive EDA platform from |platform from prototype to |prototype to product |product | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600529] Review Request: R-rjags - Bayesian graphical models using MCMC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600529 Bug 600529 depends on bug 600467, which changed state. Bug 600467 Summary: Review Request: jags - Just Another Gibbs Sampler https://bugzilla.redhat.com/show_bug.cgi?id=600467 What|Old Value |New Value Resolution||NOTABUG Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 600467] Review Request: jags - Just Another Gibbs Sampler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600467 chris desjardins cddesjard...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG Last Closed||2011-02-14 10:28:00 --- Comment #21 from chris desjardins cddesjard...@gmail.com 2011-02-14 10:28:00 EST --- Sorry I don't have time to do this anymore. Graduate school!!! So I have to close this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 --- Comment #2 from Ed Marshall esm+red...@logic.net 2011-02-14 10:30:47 EST --- Spec URL: http://esm.logic.net/public/fedora/fritzing/fritzing.spec SRPM URL: http://esm.logic.net/public/fedora/fritzing/fritzing-0.5.0b-1.fc14.src.rpm Here you go; you must want the new autorouter pretty badly. :) I've confirmed that it builds cleanly with mock on i686; I'll test a build on x86_64 later today; both are/will be available here: http://esm.logic.net/public/fedora/fritzing/ I'm still in need of review and a sponsor if anyone is willing to spare a few minutes to take a look. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677391] Review Request: lovelock-kde-theme - Lovelock KDE Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677391 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Priority|medium |urgent --- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2011-02-14 10:38:25 EST --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2839180 rpmlint lovelock-kde-theme-14.90.1-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint lovelock-kde-theme-14.90.1-1.fc14.noarch.rpm lovelock-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/Lovelock/lovelock-640x480.png ../../../../../backgrounds/lovelock/default/standard/lovelock.png ... 1 packages and 0 specfiles checked; 0 errors, 29 warnings. Waived as it is the only way how to achieve the goal of theming. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677391] New: Review Request: lovelock-kde-theme - Lovelock KDE Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: lovelock-kde-theme - Lovelock KDE Theme https://bugzilla.redhat.com/show_bug.cgi?id=677391 Summary: Review Request: lovelock-kde-theme - Lovelock KDE Theme Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jrez...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://rezza.hofyland.cz/fedora/packages/lovelock-kde-theme/lovelock-kde-theme.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/lovelock-kde-theme/lovelock-kde-theme-14.90.1-1.fc14.src.rpm Description: This is Lovelock KDE Theme Artwork containing KDM theme, KSplash theme and Plasma Workspaces theme. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673839] Review Request: boost141 - The free peer-reviewed portable C++ source libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673839 --- Comment #19 from Robert Scheck redhat-bugzi...@linuxnetz.de 2011-02-14 10:50:07 EST --- Denis, I'm sorry, but I'm not interested in creating new work to myself. That is why I will stick with the version from RHEL 6 and not use Fedora as base. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added CC||methe...@gmail.com --- Comment #21 from Rahul Sundaram methe...@gmail.com 2011-02-14 10:53:46 EST --- You will have to report it upstream since this package is not in Fedora yet. You might have to try the latest version first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676187
--- Comment #9 from William Lima wl...@primate.com.br 2011-02-14 11:00:15 EST
---
(In reply to comment #6)
OK, I will remove the pem files as this is a step that needs to be done by the
user (http://oss.linbit.com/csync2/paper.pdf).
According to http://oss.linbit.com/csync2/ site:
The csync2 releases also have a copy of the 'paper.pdf' file
(and the TeX source) bundled in the csync2 source tarball.
I suggest you to include this file on %doc.
BuildRequires on openssl is also useless since you don't call make cert.
BuildRequires on xinetd looks the same. Keep the Requires only.
###
make %{?_smp_mflags} all
###
This is the default target for makefiles. There is no need to call all
target.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676187
--- Comment #10 from Ian Weller i...@ianweller.org 2011-02-14 11:13:09 EST ---
(In reply to comment #9)
BuildRequires on xinetd looks the same. Keep the Requires only.
Agreed, sorry I had you add this when it wasn't necessary (had a slip of what
the heck RPM did) :)
###
make %{?_smp_mflags} all
###
This is the default target for makefiles. There is no need to call all
target.
Not that this matters too much, but it's important to note that all is *not
necessarily* the default target for Makefiles; it is simply the *first* target
that is the default. (It just so happens that all is the first one here.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #23 from Kevin Kofler ke...@tigcc.ticalc.org 2011-02-14 12:48:10 EST --- Re FAAC, while the following won't change anything for Fedora because FFmpeg is also not suitable for Fedora, we really should get AAC encoding support through the native FFmpeg AAC encoder enabled in gstreamer-ffmpeg, that way we could support AAC encoding with Free (though patent-encumbered) software. (FAAC is both non-Free and patent-encumbered.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 --- Comment #24 from Kevin Kofler ke...@tigcc.ticalc.org 2011-02-14 12:49:35 EST --- (Of course, apps asking for FAAC explicitly would need to be fixed to work with that, too.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 --- Comment #25 from Kevin Kofler ke...@tigcc.ticalc.org 2011-02-14 13:06:28 EST --- So I double-checked: gstreamer-ffmpeg actually already supports AAC encoding. I was confused because I was looking for something like encoder-audio/aac, but it's actually called gstreamer0.10(encoder-audio/mpeg)(mpegversion=4). So if Arista cannot encode AAC with just gstreamer-ffmpeg installed (and no gstreamer-plugins-bad-nonfree), then somebody needs to fix Arista (ideally upstream) to support any element providing an encoder for audio/mpeg with mpegversion=4, not just the faac element explicitly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608332] Review Request: rootplot - Plots ROOT data with matplotlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608332 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2011-02-14 13:11:37 EST --- rootplot-2.2.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rootplot-2.2.1-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675628] Review Request: python26-jinja2 - General purpose template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675628 Steve Traylen steve.tray...@cern.ch changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch Flag||fedora-review? Bug 675628 depends on bug 668591, which changed state. Bug 668591 Summary: Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python https://bugzilla.redhat.com/show_bug.cgi?id=668591 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676187 Ian Weller i...@ianweller.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Ian Weller i...@ianweller.org 2011-02-14 13:52:48 EST --- Just did one last look, the only issue is the BuildRequires that William mentioned, so -- This package csync2 is APPROVED by ianweller -- and we'll just go on faith that you'll fix the BuildRequires section and bump the release before you check it into the VCS. Let's go finish that last package and get you sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675628] Review Request: python26-jinja2 - General purpose template engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=675628
Steve Traylen steve.tray...@cern.ch changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Steve Traylen steve.tray...@cern.ch 2011-02-14 13:58:11
EST ---
Review of EPEL5 only python-jinga, bug #675628
Builds in an EPEL5 mock okay.
- Package meets naming and packaging guidelines
$ rpmlint /var/lib/mock/epel-5-x86_64/result/*.rpm
python26-jinja2.noarch: W: spelling-error %description -l en_US sandboxed -
sandboxes, sand boxed, sand-boxed
python26-jinja2.noarch: W: spelling-error %description -l en_US templating -
contemplating, template's, template
python26-jinja2.src: W: spelling-error %description -l en_US sandboxed -
sandboxes, sand boxed, sand-boxed
python26-jinja2.src: W: spelling-error %description -l en_US templating -
contemplating, template's, template
python26-jinja2.src:2: E: hardcoded-library-path in
/usr/lib/python2.6/site-packages
2 packages and 0 specfiles checked; 1 errors, 4 warnings.
The last is fine for python26 package where it can't easily be determined
dynamically
and spec file is very hard coded anyway to python2.6.
sandboxed and templating are both verbisms so okay.
- Spec file matches base package name.
It does.
- Spec has consistant macro usage.
Yes.
- Meets Packaging Guidelines.
Yes.
- License
BSD
- License field in spec matches
3 clause BSD, all files contain :license: BSD..
- License file included in package
LICENSE file included.
- Spec in American English
It is.
- Spec is legible.
It Is.
- Sources match upstream md5sum:
$ md5sum Jinja2-2.5.5.tar.gz ../SOURCES/Jinja2-2.5.5.tar.gz
83b20c1eeb31f49d8e6392efae91b7d5 Jinja2-2.5.5.tar.gz
83b20c1eeb31f49d8e6392efae91b7d5 ../SOURCES/Jinja2-2.5.5.tar.gz
- Package needs ExcludeArch
It does.
- BuildRequires correct
They are.
- Spec handles locales/find_lang
None present.
- Package is relocatable and has a reason to be.
Not relocatable.
- Package has %defattr and permissions on files is good.
They are.
- Package has a correct %clean section.
Yep.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Doc subpackage needed/used.
Not needed.
- Packages %doc files don't affect runtime.
They don't/
- Package compiles and builds on at least one arch.
Mock build
- Package has no duplicate files in %files.
It does not.
- Package doesn't own any directories other packages own.
Nope.
- Package owns all the directories it creates.
It does.
- final provides and requires are sane:
$ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires
$i; echo; done
python26-jinja2-2.5.5-4.el5.noarch.rpm
python26-jinja2 = 2.5.5-4.el5
=
python26-babel = 0.8
python26-markupsafe
python26-jinja2-2.5.5-4.el5.src.rpm
=
python26-devel
python26-distribute
python26-markupsafe
Looks good to me.
SHOULD Items:
- Should build in mock.
It does.
- Should build on all supported archs
It's no arch.
- Should function as described.
Test suite runs.
- Should have sane scriptlets.
None needed.
- Should have dist tag
It does.
- Should package latest version
2.5.5 is latests.
Issues:
NONE
Straightforward python package - approved.
Thanks for the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675798] Review Request: liblzf - Small data compression library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675798 --- Comment #1 from Steve Traylen steve.tray...@cern.ch 2011-02-14 15:03:53 EST --- Spec URL: http://cern.ch/straylen/rpms/liblzf/liblzf.spec SRPM URL: http://cern.ch/straylen/rpms/liblzf/liblzf-3.6-2.fc14.src.rpm Adds a pkg-config file. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676187 --- Comment #12 from Angus Salkeld asalk...@redhat.com 2011-02-14 15:13:11 EST --- Thank you! I'll sort that BuildRequires out and add the paper.pdf to doc. -Angus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676188
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com 2011-02-14
15:15:44 EST ---
I think it's OK to leave arpeggiator untouched, because not all dictionaries
know about all existing words.
The package has properly built on my system. Some issues regarding the spec
file:
- Please use macros consistently. In Source2 and in the %files section, you
should replace the original package name with %{name}, as you already did in
the other rows.
- If you are using spaces within key/value pairs such as Name: or Version:
please use a whitespace count which leads to a better readability. I would
recommend using tabs instead of normal whitespace characters here.
- Although your package doesn't install SVG icons, the %post and %postun macros
refer to the SVG folder. Don't know what to do in this case, I assume the
folder path has to be changed to the correct installation folder of the icon.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675947] Review Request: sanlock - a shared disk lock manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675947 --- Comment #3 from Angus Salkeld asalk...@redhat.com 2011-02-14 15:28:23 EST --- Thank you Ian, I appreciate it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672955] Review Request: iwl100-firmware - Firmware for Intel(R) Wireless WiFi Link 100 Series Adapters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672955 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-02-14 15:30:48 EST --- iwl100-firmware-39.31.5.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672955] Review Request: iwl100-firmware - Firmware for Intel(R) Wireless WiFi Link 100 Series Adapters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672955 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||iwl100-firmware-39.31.5.1-1 ||.fc14 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646612] Rename review: drupal-date - drupal6-date
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646612 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Jon Ciesla l...@jcomserv.net 2011-02-14 15:33:06 EST --- New Package SCM Request === Package Name: drupal6-date Short Description: This package contains both the Date module and a Date API module Owners: limb Branches: EL-5 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2011-02-14 15:29:05 EST --- gxneur-0.12.0-3.svn859.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gxneur'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/gxneur-0.12.0-3.svn859.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646614] Rename review: drupal-calendar - drupal6-calendar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646614 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Jon Ciesla l...@jcomserv.net 2011-02-14 15:34:27 EST --- New Package SCM Request === Package Name: drupal6-calendar Short Description: This module will display any Views date field in calendar formats Owners: limb Branches: EL-5 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676146 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||cwick...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677297] Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677297 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||cwick...@fedoraproject.org QAContact|extras...@fedoraproject.org |cwick...@fedoraproject.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676188
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #2 from Martin Gieseking martin.giesek...@uos.de 2011-02-14
15:57:42 EST ---
(In reply to comment #1)
- Although your package doesn't install SVG icons, the %post and %postun
macros
refer to the SVG folder. Don't know what to do in this case, I assume the
folder path has to be changed to the correct installation folder of the icon.
Right. The spec file in the SRPM differs from the one given as a separate URL.
The latter installs an SVG rather than a PNG.
The proper scriptlets to update the icon cache are listed here:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
Here are some additional comments:
- according to the source file headers, the license is GPLv2+
- adapt Source0 according to
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
- replace the suffix .1.gz with .1* in %files since we should not rely on a
concrete compression format
- I recommend to replace %{_datadir}/man with %{_mandir}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676146 --- Comment #2 from Christoph Wickert cwick...@fedoraproject.org 2011-02-14 16:51:35 EST --- One more thing: Please use the bzipped source instead of tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676146
--- Comment #1 from Christoph Wickert cwick...@fedoraproject.org 2011-02-14
16:50:11 EST ---
REVIEW FOR b1759276bf8aec03a09306b1683894ab trace-gui-1.0.4-1.fc13.src.rpm
FIX - MUST: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
trace-gui.src: W: spelling-error Summary(en_US) cmd - cm, cd, cad
trace-gui.src: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.src: W: spelling-error %description -l en_US cmd - cm, cd, cad
trace-gui.src: W: spelling-error %description -l en_US debugfs - debugs,
debuggers, debugged
trace-gui.src: W: no-version-in-last-changelog
trace-gui.src:51: W: macro-in-comment %{_bindir}
trace-gui.src:55: W: macro-in-comment %{_datadir}
trace-gui.src:55: W: macro-in-comment %{upstream_name}
trace-gui.src:56: W: macro-in-comment %{_mandir}
trace-gui.src:57: W: macro-in-comment %{_mandir}
trace-gui.src: W: invalid-url Source0: %{URL}/trace-cmd-1.0.4.tar.gz
trace-gui.x86_64: W: spelling-error Summary(en_US) cmd - cm, cd, cad
trace-gui.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.x86_64: W: spelling-error %description -l en_US cmd - cm, cd, cad
trace-gui.x86_64: W: spelling-error %description -l en_US debugfs - debugs,
debuggers, debugged
trace-gui.x86_64: W: no-version-in-last-changelog
trace-gui.x86_64: W: no-manual-page-for-binary trace-graph
trace-gui.x86_64: W: no-manual-page-for-binary kernelshark
trace-gui.x86_64: W: no-manual-page-for-binary trace-view
trace-gui-debuginfo.x86_64: W: no-version-in-last-changelog
You can ignore spelling-error and no-manual-page-for-binary and
summary-not-capitalized, but the rest needs fixing.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
FIX - MUST: package does not meet the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (GPLv2)
OK - MUST: License field in spec file matches the actual license
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible (could be more legible if properly formatted with
indention)
OK - MUST: sources match the upstream source by MD5
a91e23aa860359d5c4b8359ba45cef5b
OK - MUST: successfully compiles and builds into binary rpms on x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates (none)
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
FIX - MUST: The package contains a GUI application but does not include a
%{name}.desktop file, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
OK - MUST: package does not own files or directories already owned by other
packages.
OK - Should: at the beginning of %install, the package runs rm -rf
%{buildroot}.
OK - MUST: all filenames valid UTF-8
SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc,
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676187 Angus Salkeld asalk...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676187] Review Request: csync2 - Cluster sync tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676187 --- Comment #13 from Angus Salkeld asalk...@redhat.com 2011-02-14 17:11:19 EST --- New Package SCM Request === Package Name: csync2 Short Description: Csync2 is a cluster synchronization tool. Owners: asalkeld Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668243] Review Request: libqb - An IPC library for high performance servers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668243 Angus Salkeld asalk...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #24 from Angus Salkeld asalk...@redhat.com 2011-02-14 17:14:18 EST --- New Package SCM Request === Package Name: libqb Short Description: libqb provides high performance client server reusable features. Owners: asalkeld Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675947] Review Request: sanlock - a shared disk lock manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675947 --- Comment #4 from Angus Salkeld asalk...@redhat.com 2011-02-14 17:19:46 EST --- New Package SCM Request === Package Name: sanlock Short Description: sanlock uses disk paxos to manage leases on shared storage. Owners: asalkeld cfeist Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675947] Review Request: sanlock - a shared disk lock manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675947 Angus Salkeld asalk...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677297] Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=677297
Christoph Wickert cwick...@fedoraproject.org changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Christoph Wickert cwick...@fedoraproject.org 2011-02-14
18:00:04 EST ---
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines (LGPLv2+)
OK - MUST: License field in spec file matches the actual license
N/A - MUST: license file included in %doc (common for pear packages)
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
d998750a832d6d1487c2c1acc4a7d439
OK - MUST: successfully compiles and builds into binary rpms on all arches
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - Should: at the beginning of %install, the package runs rm -rf
%{buildroot}.
OK - MUST: all filenames valid UTF-8
SHOULD Items:
N/A - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
OK - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
N/A - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
N/A - SHOULD: package should contain man pages for binaries/scripts.
Other items:
OK - latest stable version
OK - SourceURL valid
N/A - Compiler flags ok
N/A - Debuginfo complete
OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot}.
N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
APPROVED!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677496] New: Review Request: nbc - Next Byte Codes (NBC) and Not Exactly C (NXC)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nbc - Next Byte Codes (NBC) and Not Exactly C (NXC) https://bugzilla.redhat.com/show_bug.cgi?id=677496 Summary: Review Request: nbc - Next Byte Codes (NBC) and Not Exactly C (NXC) Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: richmat...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://rmattes.fedorapeople.org/RPMS/nbc/nbc.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/nbc/nbc-1.2.1.r3-2.fc14.src.rpm Description: Next Byte Codes (NBC) is a simple language with an assembly language syntax that can be used to program LEGO's NXT programmable brick (from the new LEGO Mindstorms NXT set). Not Exactly C (NXC) is a high level language, similar to C, built on top of the NBC compiler. It can also be used to program the NXT brick. NXC is basically NQC (Not Quite C) for the NXT. rpmlint: $ rpmlint nbc.spec ../RPMS/x86_64/nbc* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2840574 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674007
--- Comment #3 from Rich Mattes richmat...@gmail.com 2011-02-14 21:34:25 EST
---
I'm getting the following output from rpmlint:
$ rpmlint openni-primesense.spec ../RPMS/x86_64/openni-primesense-*
openni-primesense.spec: W: invalid-url Source0:
openni-primesense-5.0.0.25-git894cea01.tar.gz
OK
openni-primesense.x86_64: W: incoherent-version-in-changelog
5.0.0.24-0.1gitc0e70ea1 ['5.0.0.25-0.1_git894cea01.fc14',
'5.0.0.25-0.1_git894cea01']
The Release: field should read 0.1.git%{gitrev}%{?dist} and changelog entry
should read 5.0.0.24-0.1.gitc0e70ea1 as per the examples given in
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
(the SVN snapshots examples are most relevant here)
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceSensorV2.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnCore.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnFormats.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceFile.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDDK.so
If these are plugin libraries akin to the openni package, this should be ok.
openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/LGPL.txt
openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/README
dos2unix or sed can fix these.
openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L
openni-primesense.x86_64: E: non-standard-executable-perm
/usr/bin/XnSensorServer 04755L
Why does the sensor server binary need a setuid bit? Device permissions should
be handled by the udev rule, is there some other reason it needs to be there?
openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense
If there are going to be logs accumulating, you should have a rule to rotate
and delete them every so often. It looks like XnSensorServer is creating a
folder called XnSensorServer under /var/log/primesense, but I can't get it to
add any logfiles.
openni-primesense.x86_64: W: no-manual-page-for-binary XnSensorServer
This is OK
2 packages and 1 specfiles checked; 2 errors, 11 warnings.
A few other things:
* The udev rules file mixes ATTRS and SYSFS. SYSFS generates a lot of warning
messages at bootup, you should switch to using ATTRS consistently.
* The package has a udev rule, so it needs a Requires: on udev
* LibJPEG is bundled with openni-primesense, in Source/External. This should
be removed in setup.
* The README file doesn't contain any useful end-user information, it's just
instructions for building and installing. You don't need to include it as
documentation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 --- Comment #5 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-02-14 23:39:00 EST --- Fixed all the issue which Mr. Martin Gieseking pointed out, here is updated spec file and srpm Spec URL : http://kumarpraveen.fedorapeople.org/pidgin-logviewer/pidgin-logviewer.spec SRPM URL : http://kumarpraveen.fedorapeople.org/pidgin-logviewer/pidgin-logviewer-0.2-3.20110208svn.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666311
Rich Mattes richmat...@gmail.com changed:
What|Removed |Added
CC||richmat...@gmail.com
--- Comment #3 from Rich Mattes richmat...@gmail.com 2011-02-15 00:02:41 EST
---
I'm very interested in this package making it into Fedora. I'm not a sponsor
so I cannot complete a review of this package, but I'd still like to give you
some feedback on some problems I see.
* You do not need to call strip on the Fritzing binary, rpmbuild will take
care of that.
* It looks like the package is building against a bundled boost-1.43, quazip,
and qtlockedfile (located under src/lib in the source.) Bundling libraries
that are available system-wide is not acceptable as per
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries You'll need to
remove the bundled libraries during %prep as per
http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries and
patch the buildsystem so it detects and builds against system-installed
libraries.
A folder called ff also exists with a couple of source files, but I cannot
find an upstream project that provides them.
* You should export CXXFLAGS=%{optflags} before calling qt4_qmake so the
package is built with Fedora's default flags (optimization level, debug level,
etc.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677297] Review Request: php-pear-Net-IDNA2 - PHP library for punycode encoding and decoding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677297 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Terje Røsten terje...@phys.ntnu.no 2011-02-15 02:02:58 EST --- Thanks Christoph! New Package SCM Request === Package Name: php-pear-Net-IDNA2 Short Description: PHP library for punycode encoding and decoding Owners: terjeros Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
