[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694287
--- Comment #36 from Hans de Goede 2011-04-27 01:38:38
EDT ---
(In reply to comment #33)
> (In reply to comment #28)
> > - Add -p to invocation of cp for installation of header files to preserve
> > the
> > timestamps on the files
>
> This is already recursive. Would it be appropriate to just use -a here?
Yes
(In reply to comment #34)
> New problem. I'm getting rpath's in the resultant libraries.
> I added CMAKE_SKIP_RPATH to the cmake command but don't have time to build the
> package just yet to see if it works. Hopefully it's that simple.
I woke up thinking this morning if we don't use cmake for make install, we need
to add this magic value to disable rpath, I'm happy to see you already figured
this out yourself :)
(In reply to comment #35)
> openCOLLADA.x86_64: E: invalid-soname
> /usr/lib64/libOpenCOLLADABaseUtils.so.0.838.0
> libOpenCOLLADABaseUtils.so.svn838
The lib files should be installed under the same name as you can find them
under the ./lib dir, actually you can just do:
mkdir -p $RPM_BUILD_ROOT%{_libdir}
cp -a lib/* $RPM_BUILD_ROOT%{_libdir}
For the so files (still need to also cp the include dirs) from %install since
cmake also puts the needed symlinks, etc. under ./lib. Talking about the
include dirs, you should now no longer install the include dirs for libBuffer,
libftoa and libUTF.
The %files entry for the so files in the main package then becomes:
%{_libdir}/lib*.so.svn%{AGE}
Oh, one other small thing I just noticed, instead of:
%post -n openCOLLADA -p /sbin/ldconfig
%postun -n openCOLLADA -p /sbin/ldconfig
You can just write:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
There is no need for the -n openCOLLADA since that is the main package's name.
With all previous fixes + the just cp -a lib thingie I think we're 99% there,
if you can provide a new spec file + srpm I'll check it out and either approve
it right away or make a hopefully small list of things left to fix :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699902] Review Request: python-manuel - Build tested documentation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699902
Robin Lee changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||robinlee.s...@gmail.com
AssignedTo|nob...@fedoraproject.org|robinlee.s...@gmail.com
Flag||fedora-review?
--- Comment #1 from Robin Lee 2011-04-27 00:16:28 EDT
---
Here is the review:
+:ok, =:needs attention, -:needs fixing
MUST Items:
[+] MUST: rpmlint must be run on every package.
$ rpmlint ./RPMS/noarch/python-manuel-1.5.0-1.fc15.noarch.rpm
./SRPMS/python-manuel-1.5.0-1.fc14.src.rpm ./SPECS/python-manuel.spec
python-manuel.noarch: W: spelling-error %description -l en_US doctests -> doc
tests, doc-tests, doctorates
python-manuel.src: W: spelling-error %description -l en_US doctests -> doc
tests, doc-tests, doctorates
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
$ md5sum manuel-1.5.0.tar.gz
644fe14c164a6e78bcbc346fefbcd7a6 manuel-1.5.0.tar.gz
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: Packages should try to preserve timestamps of original installed
files.
Other Items:
[-] According to setup.py, this package does not require python-zope-testing at
runtime.
[=] Group better be Development/Libraries
[-] The text files in python site path are compiled to html by sphinx and
included in %doc. They should be excluded from python site path.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 685008] Review Request: rubygem-cloudservers - A Ruby API to the Rackspace Cloud Servers product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=685008 --- Comment #10 from Fedora Update System 2011-04-26 22:38:23 EDT --- rubygem-cloudservers-0.4.1-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 685008] Review Request: rubygem-cloudservers - A Ruby API to the Rackspace Cloud Servers product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=685008 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-cloudservers-0.4.1- ||2.fc15 Resolution||ERRATA Last Closed||2011-04-26 22:38:28 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696052] Review Request: texlive-tetex-cmsuper - The CM-Super font set
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696052 --- Comment #3 from Mohamed El Morabity 2011-04-26 20:59:53 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696357] Review Request: fedora-logo-gnome-shell-extension - adds a Fedora logo to Gnome shell's Activities button
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696357 --- Comment #4 from Mohamed El Morabity 2011-04-26 20:58:38 EDT --- Really really sorry for this late answer. I may reconsider my views about system-logos, since there is in fact no generic equivalent of the fedora-logo file in the generic-logos package. So I tried to find an alternative. The proper way to get the logo whatever the distribution may be to refer to start-here; this is by the way the icon grabbed by gnome-panel in GNOME 2. The fedora-logos package contains start-here.* icon files, as symbolink links to fedora-icon.*, in /usr/share/icons/hicolor/, since any theme inherits from the hicolor theme. In Fedora<=14, the default theme used in GNOME was the "fedora" one, based on mist which doesn't provide any start-here icon, so start-here was grabbed in hicolor. generic-logos doesn't provide any start-here.* icon, so the "fallback" GNOME start-here.* icon was used instead (the foot logo). In Fedora 15, it seems the default icon theme is "gnome", which provides its own start-here icon, that is to say the foot logo. Some heuristics to grab a path to the distribution logo whatever the current icon theme may exist. It may be an evolution for this extension, one day ^^. Anyway I'm OK to approve this package as it is currently if you rename it to gnome-shell-extension-fedora-logo, which seems to me finally the most appropriate name according to the guidelines. Be *very* careful also with the GNOME Shell version set in metadata.json: you set the shell-version key to 3.0.0.2 whereas the latest version available of GS in the repos is 3.0.1. As a result, your extension won't work in GS > 3.0.0.2. A workaround would be to set shell-version to 3.0, which seems to work for any GS version 3.0.*. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682666] Review Request: DeTex - A program to remove TeX constructs from a text file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682666 --- Comment #5 from Mohamed El Morabity 2011-04-26 21:00:16 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694287 --- Comment #35 from Richard Shaw 2011-04-26 18:48:00 EDT --- Rebuilt now that I'm home from work. Here's the new rpmlint output from the installed package: (MUCH SMALLER!) # rpmlint openCOLLADA openCOLLADA.x86_64: W: spelling-error Summary(en_US) Collada -> Collard, Collate, Collage openCOLLADA.x86_64: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource openCOLLADA.x86_64: W: spelling-error %description -l en_US validator -> invalidator, validation, validate openCOLLADA.x86_64: W: spelling-error %description -l en_US xml -> XML, cml, ml openCOLLADA.x86_64: W: incoherent-version-in-changelog 0.0-3 ['0-4.svn838.fc14', '0-4.svn838'] openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libOpenCOLLADABaseUtils.so.0.838.0 libOpenCOLLADABaseUtils.so.svn838 openCOLLADA.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libOpenCOLLADABaseUtils.so.0.838.0 /usr/lib64/libpcreposix.so.0 openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libOpenCOLLADAStreamWriter.so.0.838.0 libOpenCOLLADAStreamWriter.so.svn838 openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libMathMLSolver.so.0.838.0 libMathMLSolver.so.svn838 openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libGeneratedSaxParser.so.0.838.0 libGeneratedSaxParser.so.svn838 openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libOpenCOLLADASaxFrameworkLoader.so.0.838.0 libOpenCOLLADASaxFrameworkLoader.so.svn838 openCOLLADA.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libOpenCOLLADASaxFrameworkLoader.so.0.838.0 /usr/lib64/libpcreposix.so.0 openCOLLADA.x86_64: E: invalid-soname /usr/lib64/libOpenCOLLADAFramework.so.0.838.0 libOpenCOLLADAFramework.so.svn838 openCOLLADA.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libOpenCOLLADAFramework.so.0.838.0 /usr/lib64/libMathMLSolver.so.svn838 1 packages and 0 specfiles checked; 6 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632856
--- Comment #4 from Robert Scheck 2011-04-26
18:27:13 EDT ---
Fedora dislikes the usage of %global for %{name}, %{version}, %{release} and
other basic things, because "Name: xinput_calibrator" brings the same result
as "%global name xinput_calibrator", so please correct this accordingly.
There is no need to set %{_prefix} for yourself, because did you ever have a
look to what %configure expands? And there is also no need for the parameters
you added, because of this:
$ rpm --eval '%configure'
CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export
CFLAGS ;
CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export
CXXFLAGS ;
FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules}" ; export FFLAGS ;
./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
\
--program-prefix= \
--disable-dependency-tracking \
--prefix=/usr \
--exec-prefix=/usr \
--bindir=/usr/bin \
--sbindir=/usr/sbin \
--sysconfdir=/etc \
--datadir=/usr/share \
--includedir=/usr/include \
--libdir=/usr/lib64 \
--libexecdir=/usr/libexec \
--localstatedir=/var \
--sharedstatedir=/var/lib \
--mandir=/usr/share/man \
--infodir=/usr/share/info
%
If the expansion does not fit for you, your build system is misconfigured or
not set up as it should be.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699168] Review Request: routino - Router for OpenStreetMap Data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699168 Kevin Kofler changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 18:03:38 --- Comment #15 from Kevin Kofler 2011-04-26 18:03:38 EDT --- Imported, built for Rawhide, builds and Bodhi updates for the releases coming soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-daemon_controller-0 |rubygem-daemon_controller-0 |.2.6-1.fc14 |.2.6-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-file-tail-1.0.5-3.f |rubygem-file-tail-1.0.5-3.f |c15 |c13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 --- Comment #17 from Fedora Update System 2011-04-26 17:51:42 EDT --- rubygem-file-tail-1.0.5-3.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 --- Comment #18 from Fedora Update System 2011-04-26 17:53:31 EDT --- rubygem-file-tail-1.0.5-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-file-tail-1.0.5-3.f |rubygem-file-tail-1.0.5-3.f |c13 |c14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-spruz-0.2.5-3.fc13 |rubygem-spruz-0.2.5-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-spruz-0.2.5-3.fc15 |rubygem-spruz-0.2.5-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 --- Comment #15 from Fedora Update System 2011-04-26 17:50:14 EDT --- rubygem-spruz-0.2.5-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 --- Comment #16 from Fedora Update System 2011-04-26 17:53:55 EDT --- rubygem-spruz-0.2.5-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 --- Comment #16 from Fedora Update System 2011-04-26 17:52:24 EDT --- rubygem-daemon_controller-0.2.6-1.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 --- Comment #15 from Fedora Update System 2011-04-26 17:50:41 EDT --- rubygem-daemon_controller-0.2.6-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697697 --- Comment #7 from Dennis Gilmore 2011-04-26 17:49:52 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-daemon_controller-0 |rubygem-daemon_controller-0 |.2.6-1.fc15 |.2.6-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694287 --- Comment #34 from Richard Shaw 2011-04-26 17:40:03 EDT --- Ok, small update. Apparently cmake installs all the libs a ./lib directory in the build dir so the find command was no longer necessary. Took that out and it built fine. New problem. I'm getting rpath's in the resultant libraries. I added CMAKE_SKIP_RPATH to the cmake command but don't have time to build the package just yet to see if it works. Hopefully it's that simple. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699902] New: Review Request: python-manuel - Build tested documentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-manuel - Build tested documentation https://bugzilla.redhat.com/show_bug.cgi?id=699902 Summary: Review Request: python-manuel - Build tested documentation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: loganje...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://jjames.fedorapeople.org/python-manuel/python-manuel.spec SRPM URL: http://jjames.fedorapeople.org/python-manuel/python-manuel-1.5.0-1.fc14.src.rpm Description: Manuel lets you mix and match traditional doctests with custom test syntax. Several plug-ins are included that provide new test syntax. You can also create your own plug-ins. This package is needed to test the documentation builds of python-ZODB3; i.e., it is a build-time-only dependency of python-ZODB3. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697697 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678955] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678955 --- Comment #11 from Jerry James 2011-04-26 16:10:58 EDT --- Jeff, do you intend to continue with this review? Please respond. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694287
--- Comment #33 from Richard Shaw 2011-04-26 16:09:25
EDT ---
(In reply to comment #28)
> Needs work:
> ===
>
> Ok, I'm going to divide this into 2 lists, one with small things and one with
> large things. First the small things:
> - rpmlint checks return:
> openCOLLADA.src:108: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab:
> line 108)
> Please don't use tabs in spec files.
I couldn't find the tab but I ran across 'expand' which seemed to work quite
nicely to fix the problem.
> openCOLLADA.x86_64: W: file-not-utf8 /usr/share/doc/openCOLLADA-0/AUTHORS
> You will need to convert this to utf8, add the following to %prep:
> iconv -f ISO_8859-1 -t utf-8 COLLADAStreamWriter/AUTHORS > \
> COLLADAStreamWriter/AUTHORS.tmp
> touch -r COLLADAStreamWriter/AUTHORS COLLADAStreamWriter/AUTHORS.tmp
> mv COLLADAStreamWriter/AUTHORS.tmp COLLADAStreamWriter/AUTHORS
Done.
> - please drop the following comment (it is the same as Source0, so I see no
> use for it):
> #Source0:%{name}-svn%{AGE}.tar.xz
Already gone. Sorry, I left that in there when I was playing with different
compression (gz, xz, bz2)
> - please drop the following (already commented) command from the spec file:
> #strip --strip-debug *.so.*
> Stripping should *never* be done inside the spec file.
That's left over from Suse. It was always commented out for me. Fixed.
> - please add -p to the invocation of cp for the doc files, to keep the
> original
Fixed.
> timestamps. Also why do you cp LICENSE, where as for AUTHORS you reference
> it with its full path ? This seems inconsistent.
Not sure, unless Dave just wanted AUTHORS in the subdir and LICENSE in the
root. I don't see why AUTHORS couldn't be moved to the install root (is that
the right terminology?)
> - please add -k to the invocation of dos2unix to keep the original timestamps
> on the files
Done.
> - Group: Applications/Productivity
> Is not really appropriate, please use:
> Group: System Environment/Libraries
> For the main package instead.
Apparently Suse has A LOT MORE groups than we do. I guessed on this one but
that was before I really knew what I was doing :)
> - # copy CHANGES.txt
> install -p -m 0644 %{S:1} ./
> This belongs in %prep IMHO
Done.
> - Add -p to invocation of cp for installation of header files to preserve the
> timestamps on the files
This is already recursive. Would it be appropriate to just use -a here?
> - devel does not requires base package n-v-r
> Please change the:
> Requires: %{name} = %{version}
> For the -devel sub-package into:
> Requires: %{name} = %{version}-%{release}
Done.
> - I don't like the way the changelog is formatted, here is a copy paste from
> another review with similar issues:
Done.
Richard
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 658450] Review Request: ATpy - Astronomical Tables in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658450 --- Comment #3 from Sergio Pascual 2011-04-26 15:48:01 EDT --- With python3 support Spec URL: http://sergiopr.fedorapeople.org/ATpy.spec SRPM URL: http://sergiopr.fedorapeople.org/ATpy-0.9.4-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646686] Review Request: mod_xsendfile - Apache module to send files efficiently
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646686 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 15:42:10 --- Comment #9 from Orion Poplawski 2011-04-26 15:42:10 EDT --- Checked in and built. Thanks all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699025] Review Request: jchardet - Automatic charset detection algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699025 Orion Poplawski changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 15:41:08 --- Comment #6 from Orion Poplawski 2011-04-26 15:41:08 EDT --- Checked in and built. Thanks all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694287 --- Comment #32 from Richard Shaw 2011-04-26 15:39:49 EDT --- (In reply to comment #31) > Using cmake with this patch seems to fix all "large things" mentioned in my > full review comment :) I hope you're ok with moving to cmake for building ... Not at all! In fact Dave and I both prefer it but he hadn't had time to learn more cmake so he could figure out what was missing and I don't know it near well enough to take it on. I'll try it out tonight! Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699168] Review Request: routino - Router for OpenStreetMap Data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699168 --- Comment #14 from Jason Tibbitts 2011-04-26 15:35:49 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694287
--- Comment #31 from Hans de Goede 2011-04-26 15:30:29
EDT ---
Created attachment 495019
--> https://bugzilla.redhat.com/attachment.cgi?id=495019
PATCH: add soname to cmake build files, hide util libs
Hi,
So I've been working on the weak non resolved symbols issue, and I noticed
there were CMakeList files already present, and they already contained all the
bits needed to properly link the libs to each other to avoid the weak non
resolved symbols issue.
So I gave the cmake buildsys a spin and it works well, working with cmake is so
much easier then scons :)
So I did a small patch fixing 2 things with the cmake buildsys:
1) Add a proper soname to the build libraries
2) the libBuffer libftoa and libUTF8 libs were only being used in one other
openCOLLADA lib each, and have very generic names. So instead of building
them as libs, I've changed the buildsys to embed them into the libs using
them.
If you use the attached patch (and drop the sconstruct patches) and replace the
%build section with:
%cmake -DUSE_STATIC=OFF -DUSE_SHARED=ON -Dsoversion=svn%{AGE}
# Note building with _smp_mflags does not work for some reason ...
make
Then you'll find properly build libs (including soname + symlinks) under the
lib subdir, make install does not work, it looks like the cmake files need some
work to get this to work, but we can just do it manually for now.
Using cmake with this patch seems to fix all "large things" mentioned in my
full review comment :) I hope you're ok with moving to cmake for building ...
Regards,
Hans
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699025] Review Request: jchardet - Automatic charset detection algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699025 --- Comment #5 from Jason Tibbitts 2011-04-26 14:41:54 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699843] New: Review Request: dsi - Invading aliens type game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: dsi - Invading aliens type game https://bugzilla.redhat.com/show_bug.cgi?id=699843 Summary: Review Request: dsi - Invading aliens type game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: d...@interlinux.co.uk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://dspaceinvadors.svn.sourceforge.net/viewvc/dspaceinvadors/dsi.spec SRPM URL: http://sourceforge.net/projects/dspaceinvadors/files/dsi-1.0.7-beta2/dsi-1.0.7.tar.gz Description: dsi is a simple game of invading aliens. You must stop those aliens from landing on you. It features: smooth scrolling, high scores, 5 levels, simple controls, sound effects, strategic game play, and a tiny footprint. The graphics can be customized out of the box, without requiring any recompiling. A simple definition file can be customized for coders. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699025] Review Request: jchardet - Automatic charset detection algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699025 Orion Poplawski changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Orion Poplawski 2011-04-26 14:37:28 EDT --- New Package SCM Request === Package Name: jchardet Short Description: Automatic charset detection algorithm Owners: orion Branches: f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699843] Review Request: dsi - Invading aliens type game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699843 Damian changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573910] Review Request: dcmtk - Offis DICOM Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573910 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dcmtk-3.6.0-5.fc15 Resolution||ERRATA Last Closed||2011-04-26 12:26:34 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697401] Review Request: perl-Ouch - Exceptions that don't hurt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697401 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Ouch-0.0300-1.fc15 Resolution||ERRATA Last Closed||2011-04-26 12:25:34 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166481] Review Request: ngrep - network grep
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=166481 Fedora Update System changed: What|Removed |Added Fixed In Version||ngrep-1.45-7.el6 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 --- Comment #16 from Fedora Update System 2011-04-26 12:25:41 EDT --- rubygem-file-tail-1.0.5-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697401] Review Request: perl-Ouch - Exceptions that don't hurt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697401 --- Comment #9 from Fedora Update System 2011-04-26 12:25:29 EDT --- perl-Ouch-0.0300-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648007] Review Request: ghc-binary-shared - Haskell library for sharing binary elements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648007 --- Comment #15 from Fedora Update System 2011-04-26 12:25:12 EDT --- ghc-binary-shared-0.8.1-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-file-tail-1.0.5-3.f ||c15 Resolution||ERRATA Last Closed||2011-04-26 12:25:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166481] Review Request: ngrep - network grep
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=166481 Fedora Update System changed: What|Removed |Added Fixed In Version|ngrep-1.45-7.el6|ngrep-1.45-8.1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648007] Review Request: ghc-binary-shared - Haskell library for sharing binary elements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648007 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-binary-shared-0.8.1-2.f ||c15 Resolution||ERRATA Last Closed||2011-04-26 12:25:18 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-spruz-0.2.5-3.fc15 Resolution||ERRATA Last Closed||2011-04-26 12:22:42 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573910] Review Request: dcmtk - Offis DICOM Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573910 --- Comment #40 from Fedora Update System 2011-04-26 12:26:27 EDT --- dcmtk-3.6.0-5.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698953] Review Request: Brazilian Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698953
--- Comment #5 from William Lima 2011-04-26 12:46:43 EDT
---
You can also remove BuildRoot tag [1] and %clean section [2].
[1] - https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[2] - https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
Looking at spec:
Obsoletes: aspell-pt <= 50:0.50
Provides: aspell-pt = %{epoch}:%{version}
is it right? since it's a pt-br package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166481] Review Request: ngrep - network grep
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=166481 --- Comment #21 from Fedora Update System 2011-04-26 12:27:25 EDT --- ngrep-1.45-8.1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166481] Review Request: ngrep - network grep
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=166481 --- Comment #20 from Fedora Update System 2011-04-26 12:26:38 EDT --- ngrep-1.45-7.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698952] Review Request: European Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698952 --- Comment #6 from William Lima 2011-04-26 12:44:48 EDT --- You can also remove BuildRoot tag [1] and %clean section [2]. [1] - https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [2] - https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698953] Review Request: Brazilian Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698953 --- Comment #4 from Dennis Gilmore 2011-04-26 12:31:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698952] Review Request: European Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698952 --- Comment #5 from Dennis Gilmore 2011-04-26 12:26:02 EDT --- Git done (by process-git-requests). no branchs is valid you get devel only -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 --- Comment #14 from Fedora Update System 2011-04-26 12:22:36 EDT --- rubygem-spruz-0.2.5-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698952] Review Request: European Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698952 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs- --- Comment #4 from Jason Tibbitts 2011-04-26 12:16:53 EDT --- An SCM request without branches is perfectly valid (as the devel branch is created implicitly). However, we won't process requests where the ticket summary is not in the proper format (as we use that as a guard against creating the wrong package name due to typos). So, please fix the summary and I'll process the SCM request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694651] Review Request: IBSimu - Ion beam simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694651 --- Comment #11 from Fedora Update System 2011-04-26 12:06:12 EDT --- IBSimu-1.0.4-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694651] Review Request: IBSimu - Ion beam simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694651 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||IBSimu-1.0.4-4.fc15 Resolution||ERRATA Last Closed||2011-04-26 12:06:17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-daemon_controller-0 ||.2.6-1.fc15 Resolution||ERRATA Last Closed||2011-04-26 12:03:19 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 --- Comment #7 from Fedora Update System 2011-04-26 12:02:08 EDT --- perl-CPAN-Changes-0.17-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 --- Comment #14 from Fedora Update System 2011-04-26 12:03:13 EDT --- rubygem-daemon_controller-0.2.6-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699168] Review Request: routino - Router for OpenStreetMap Data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699168 Kevin Kofler changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Kevin Kofler 2011-04-26 11:42:40 EDT --- New Package SCM Request === Package Name: routino Short Description: Router for OpenStreetMap Data Owners: kkofler Branches: f15 f14 f13 el6 InitialCC: We can reassign ownership in pkgdb afterwards… -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699168] Review Request: routino - Router for OpenStreetMap Data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699168 --- Comment #12 from Jason Tibbitts 2011-04-26 11:39:09 EDT --- These things are processed by scripts. The scripts look only at the last request in the ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698455] Review Request: eclipse-mylyn-docs - Eclipse Mylyn Documentation Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698455 --- Comment #6 from Jason Tibbitts 2011-04-26 11:37:57 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698380] Review Request: eclipse-mylyn-versions - Eclipse Mylyn Versions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698380 --- Comment #7 from Jason Tibbitts 2011-04-26 11:37:41 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699209] Review Request: perl-ORLite-Mirror - Extend ORLite to support remote SQLite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699209 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-04-26 11:32:31 EDT --- perl-ORLite-Mirror-1.20-3.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #32 from Fedora Update System 2011-04-26 11:32:56 EDT --- protobuf-c-0.15-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691096] Review Request: iperf3 - Measurement tool for TCP/UDP bandwidth performance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691096 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2011-04-26 11:35:20 EDT --- iperf3-3.0-0.0.b4.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693117] Review Request: drupal6-backup_migrate - Database backup, restore, and migrate module for Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693117 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System 2011-04-26 11:34:13 EDT --- drupal6-backup_migrate-2.4-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692543] Review Request: sawfish - An extensible window manager for the X Window System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692543 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2011-04-26 11:32:44 EDT --- sawfish-1.8.0-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693204] Review Request: php-bartlett-PHP-CompatInfo - Find out version and the extensions required for a piece of code to run
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693204 --- Comment #1 from Remi Collet 2011-04-26 11:01:23 EDT --- Update to 2.0.0RC4 https://github.com/remicollet/remirepo/commit/a65f8ebd8e8c973c4c44db4616ccf7bebfce337c SRPM: http://rpms.famillecollet.com/SRPMS/php-bartlett-PHP-CompatInfo-2.0.0-0.3.RC4.remi.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693200] Review Request: php-bartlett-PHP-Reflect - Adds the ability to reverse-engineer PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693200 --- Comment #3 from Remi Collet 2011-04-26 11:00:27 EDT --- Update to 1.0.0RC1 (no change, in code, since 0.7.0) https://github.com/remicollet/remirepo/commit/2079cc120ffc57c453c3cd26534739e42c6f7be0 SRPM: http://rpms.famillecollet.com/SRPMS/php-bartlett-PHP-Reflect-1.0.0-0.1.RC1.remi.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682544 --- Comment #5 from Ken Dreyer 2011-04-26 10:47:36 EDT --- Looks like you've documented things in README.fedora. Can you can transform this into a shell script so it's easily repeatable? Something like !#/bin/sh VERSION=$1 unzip gargoyle-$VERSION-sources.zip # non-free license # (non-commercial use only and cannot modify the source code), it's # displayed in the Windows installer available at # http://www.generalcoffee.com/hugo/gethugo.html rm -r gargoyle-$VERSION/terps/hugo rm gargoyle-$VERSION/licenses/HUGO License.txt # non-free license (cannot modify the font) rm gargoyle-$VERSION/garglk/fonts/LuxiMonoBoldOblique.pfb rm gargoyle-$VERSION/garglk/fonts/LuxiMonoBold.pfb # etc. tar -cjf gargoyle-$VERSION-free.tar.bz2 gargoyle-$VERSION -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682544 --- Comment #4 from Ken Dreyer 2011-04-26 10:35:19 EDT --- You've included a URL in the comments to the original source zip file, great. Can you include a script that documents how you are transforming upstream's .zip to what you're proposing in your .tar.bz2? https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682544 --- Comment #3 from Ken Dreyer 2011-04-26 10:26:48 EDT --- Whoops, I see you've already blocked FE-NEEDSPONSOR, sorry about that! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682544 Ken Dreyer changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #2 from Ken Dreyer 2011-04-26 10:18:57 EDT --- Hi Carlo, I see that you're in FAS as "carlo", but I don't see that you're in the packagers group yet. Do you need a sponsor? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675009] Review Request: c3p0 - JDBC DataSources/Resource Pools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=675009
--- Comment #6 from Spike 2011-04-26 10:15:19 EDT ---
Thanks. But you also have to include jpackage-utils as R in post and postun
according to http://fedoraproject.org/wiki/Java/JPPMavenReadme
You can also skip the clean section and remove the 'rm -rf %{buildroot}' from
%install.
And you're missing the license file in the javadoc subpackage ->
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698380] Review Request: eclipse-mylyn-versions - Eclipse Mylyn Versions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698380 Severin Gehwolf changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Severin Gehwolf 2011-04-26 09:56:41 EDT --- New Package SCM Request === Package Name: eclipse-mylyn-versions Short Description: Provides a framework for accessing team providers for Eclipse Mylyn. Owners: jerboaa akurtakov Branches: f15 InitialCC: overholt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693425
--- Comment #44 from Alec Leamas 2011-04-26 09:54:41
EDT ---
As for server, the source rpm is missing. Reviewing based on old source +
updated spec file.
MUST
- rpmlint must be run on the source rpm and all binary rpms...
+ Should be run on 4 files, not 2; see server review. Also, please separate
output from server and client.
+ Fix changelog version; see server.
+ obsolete-not-provided: Presuming that openerp is incompatible w tinyerp,
this could be ignored.
- The spec file name must match the base package %{name} NOK
+ The name should be openerp-client.spec; see server review.
- The package must meet the Packaging Guidelines. TBD
+ Some deps listed in setup.py are missing in spec file. Is this as intended?
- The package must be licensed with a Fedora approved license...: OK
- The License field in the package spec file must match the actual license: NOK
+ No overall copyright clause in README or separate copyright file,
acceptable but "odd".
+ License: field is AGPLv3, README.txt says all files are GPL.
+ mydistutils.py is GPLv2+
+ GUI (openerp.glade) talks about GPLv3
+ msgfmt.py has a Tiny SPRL copyright, but is *very* similar to msgfmt.py as
of python-tools, which has another author reference but no copyright info.
Since the copyright is questionable, I suggest that the file is removed and
build depends on python-tools instead.
See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines
- Separate License file must be in %doc...: OK
- The spec file must be written in American English: TBD
+ Being a Swede, I really don't know. Looks fine to me, though :)
- The spec file for the package MUST be legible: OK
- The sources used to build the package must match the upstream source...TBD
- The package MUST successfully compile and build into binary rpms...: TBD
- All build dependencies must be listed in BuildRequires...TBD
+ No source submitted
+ gettext build req missing; see
http://fedoraproject.org/wiki/PackagingGuidelines#Handling_Locale_Files
- The spec file MUST handle locales properly...: OK
- Packages must NOT bundle copies of system libraries: NOK
+ contains bundled SpiffGtkWidgets
- A package must own all directories that it creates. OK
- A Fedora package must not list a file more than once in %file lists...: OK
- Permissions on files must be set properly...: OK
- Each package must consistently use macros : NOK
+ Defining macros prefixed w _, like _iconsdir, is bad practise, reserved
for internal use.
- The package must contain code, or permissable content: OK
- %doc must not affect the runtime of the application..: OK
- Header files must be in a -devel package
- Packages containing GUI applications must include a .desktop file...: OK
- Packages must not own files or directories owned by other packages...OK
- All filenames in rpm packages must be valid UTF-8.: OK
SHOULD:
- Package built on koji/mock. TBD
- Testing...
No source submitted
- Scriptlets should be sane...: NOK
+ Icons are not handled properly, use of _iconsdir, no icon cache mgmt,
possibly odd icon location. See
https://bugzilla.redhat.com/show_bug.cgi?id=495412 and
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
+ Since postun requires desktop-file-utils, the test for
.../update-desktop-database is not required. OTOH, it's wise to add a '|| : '
just in case these tools return an error code.
OTHER REMARKS:
- The for BIN in... loop could be be written in one line using 'sed -i'.
- The copyright info in debian/copyright is outdated, SpiffGtkWidtgets is now
AGPL, other updates.
- The files debian/ and setup.* should be removed; they make no sense in a
Fedora package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698455] Review Request: eclipse-mylyn-docs - Eclipse Mylyn Documentation Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698455 Severin Gehwolf changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Severin Gehwolf 2011-04-26 09:57:43 EDT --- New Package SCM Request === Package Name: eclipse-mylyn-docs Short Description: Eclipse Mylyn Documentation Tools Owners: jerboaa akurtakov Branches: f15 InitialCC: overholt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697697 Peter Robinson changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #6 from Peter Robinson 2011-04-26 09:46:23 EDT --- New Package GIT Request === Package Name: sugar-surf Short Description: Web Browser activity for Sugar Owners: pbrobinson Branches: F-15 F-14 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697139] Review Request: apache-commons-email - Apache Commons Email Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697139 Alexander Kurtakov changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697697 Sergio Pascual changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Sergio Pascual 2011-04-26 09:34:46 EDT --- Upss, done! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698952] Review Request: European Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698952 William Lima changed: What|Removed |Added CC||wl...@primate.com.br --- Comment #3 from William Lima 2011-04-26 09:32:21 EDT --- Same here... Next time, please fix your Review Summary. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request You also made a SCM Request with no branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698953] Review Request: Brazilian Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698953 William Lima changed: What|Removed |Added CC||wl...@primate.com.br --- Comment #3 from William Lima 2011-04-26 09:30:18 EDT --- Next time, please fix your Review Summary. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request You also made a SCM Request with no branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697139] Review Request: apache-commons-email - Apache Commons Email Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697139 Spike changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 09:25:43 --- Comment #5 from Spike 2011-04-26 09:25:43 EDT --- Package built, closing. https://koji.fedoraproject.org/koji/taskinfo?taskID=3026321 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618985] Review Request: swift - XMPP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618985 --- Comment #15 from Fedora Update System 2011-04-26 09:05:12 EDT --- swift-1.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/swift-1.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697697 --- Comment #4 from Peter Robinson 2011-04-26 08:35:09 EDT --- (In reply to comment #3) > Package is APPROVED, anyway there's one thing that should be fixed. Can you set the review flag to approved. > COPYING appears twice, once in doc and another one in > /usr/share/sugar/activities/Surf.activity/COPYING I'll fix it before i commit it (I've fixed it locally). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226209] Merge Review: nut
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226209 --- Comment #6 from Michal Hlavinka 2011-04-26 08:28:22 EDT --- pong I'll look at this soon, but I have some higher priority tasks right now. Also we are discussing some changes with upstream that will change packaging (probably significantly), so it's not that bad if we wait a little with spec review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226209] Merge Review: nut
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226209 --- Comment #5 from Vitezslav Crhonek 2011-04-26 08:20:00 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 654583] Review Request: pywcs - Python World Coordinate System routines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654583 Sergio Pascual changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-26 08:15:50 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693425
--- Comment #43 from Alec Leamas 2011-04-26 08:13:26
EDT ---
Easter holiday is over, here we go! First, a server review:
The submission is not complete: there should be a source RPM which is missing.
The source URL in the spec file seems to be invalid. This review is based on
the previous submitted sources + the updated spec file. Please submit source
rpm + spec file urls next time.
MUST
- rpmlint must be run on the source rpm and all binary rpms... NOK
+ Only 2 packages are checked, should be 4 (2 srpms + 2 noarch rpms)
+ The "Non standard uid/gid" warnings can be ignored.
+ The warning on URL http://www.openerp.com/ seems to be a temporary server
problem.
+ The error on zero-length file (.../office.dtd): Is this file required?
+ Fedora init scripts does normally not enable services by default. See
http://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_chkconfig:_line
+ The changelog version should be fixed. See
http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs
- The spec file name must match the base package %{name} NOK
+ The spec file should be named openerp-server.spec; see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
- The package must meet the Packaging Guidelines. TBD
+ The dependency list looks incomplete. Samples like user_ldap indicates that
some module dependencies are missing. Also, there are references to pytz and
matplotlib, but these are not required. Datetutil is used (imported), no
dependency on python-dateutil. Some deps listed in setup.py seems not to be
included. An overall review of the dependencies is needed.
- The package must be licensed with a Fedora approved license...: OK
- The License field in the package spec file must match the actual license: NOK
+ No overall copyright clause in README or separate copyright file, acceptable
but "odd".
+ License: field is AGPLv3
+ ./bin/addons/document_ftp/ftpserver is MIT, part of bundled pyftpdlib.
+ ./build/lib/openerp-server/addons/wiki/web/widgets/rss/feedparser.py is MIT.
+ ./bin/addons/resource/faces/* are GPLv2+.
+ ./build/lib/openerp-server/addons/document/dict_tools.py is LGPL 2.0, (C) by
you :)
+ The thunderbird plugin is "OpenERP Public License"
+ 'grep -ir license . | grep -v Affero | grep -i "version 2"' lists files
which are not AGPLv3, mostly LGPL 2.1+.
See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines
- Separate License file must be in %doc...: OK
- The spec file must be written in American English: TBD
+ Being a Swede, I really don't know. Looks fine to me, though :)
- The spec file for the package MUST be legible: OK
- The sources used to build the package must match the upstream source...TBD
No source submitted.
- The package MUST successfully compile and build into binary rpms...: TBD
No source submitted.
- All build dependencies must be listed in BuildRequires...TBD
No source submitted.
- The spec file MUST handle locales properly...: OK
- Packages must NOT bundle copies of system libraries: NOK
+ contains bundled ftpserver (in Fedora: pyftpdlib)
+ contains bundled rml2pdf (in Fedora: python-trml2pdf)
- A package must own all directories that it creates. OK
- A Fedora package must not list a file more than once in %file lists...: OK
- Permissions on files must be set properly...: OK
- Each package must consistently use macros : NOK
+ The _iconsdir macro is not used in the server spec file, remove definition.
+ _initrddir is deprecated, replaced by _initddir; see
http://fedoraproject.org/wiki/Packaging/SysVInitScript
- The package must contain code, or permissable content: OK
- %doc must not affect the runtime of the application...: OK
- Header files must be in a -devel package OK
- Packages must not own files or directories owned by other packages...OK
- All filenames in rpm packages must be valid UTF-8.: OK
SHOULD:
- Package built on koji/mock. TBD
No source submitted
- Testing...TBD
- Scriptlets should be sane...: OK
OTHER REMARKS:
- The for BIN in... loop could be written using 'sed -i' in just one line
- Remove setup.cfg together with setup.inf. These files are just not relevant
in a Fedora package.
- The copyright info in debian/copyright is outdated, SpiffGtkWidtgets is now
AGPL, missing licenses.
- As for your question: Fedora init scripts just should be 755, see
http://fedoraproject.org/wiki/Packaging/SysVInitScript.
- Since you want to retain %clean, you can remove the ifdef's around it. %clean
is not required, but certainly allowed.
- The %description should expand on the summary. It's now really short, a few
sentences about this being part of an ERP application and perhaps an URL would
be nice :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because:
[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699697 --- Comment #1 from Paul W. Frields 2011-04-26 08:09:24 EDT --- $ rpmlint rpmbuild/SPECS/drupal6-diff.spec rpmbuild/SRPMS/drupal6-diff-2.1-1.fc15.src.rpm rpmbuild/RPMS/noarch/drupal6-diff-2.1-1.fc15.noarch.rpm drupal6-diff.src: W: spelling-error %description -l en_US permissioned -> permission ed, permission-ed, permission drupal6-diff.noarch: W: spelling-error %description -l en_US permissioned -> permission ed, permission-ed, permission 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 658450] Review Request: ATpy - Astronomical Tables in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658450 --- Comment #2 from Sergio Pascual 2011-04-26 08:06:13 EDT --- Hi, the license in the SPEC comes from the tarball. I know the license in git is MIT, but the tarball is not a git checkout. As soon as upstream make a new release, I will update the licensing information. Now the %files section is more verbose. Spec URL: http://sergiopr.fedorapeople.org/ATpy.spec SRPM URL: http://sergiopr.fedorapeople.org/ATpy-0.9.4-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699697] New: Review Request: drupal6-diff - Show diff-type changes in Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: drupal6-diff - Show diff-type changes in Drupal 6 https://bugzilla.redhat.com/show_bug.cgi?id=699697 Summary: Review Request: drupal6-diff - Show diff-type changes in Drupal 6 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pfrie...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL:http://pfrields.fedorapeople.org/packages/SPECS/drupal6-diff.spec SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/drupal6-diff-2.1-1.fc15.src.rpm Description: This module adds a tab for sufficiently permissioned users. The tab shows all revisions like standard Drupal but it also allows pretty viewing of all added/changed/deleted words between revisions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699697 Paul W. Frields changed: What|Removed |Added Blocks||662103(InsightReviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567131] Review Request: shibboleth - Web Single Sign On
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567131 Steve Traylen changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2011-04-26 07:33:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 --- Comment #31 from Fedora Update System 2011-04-26 07:25:09 EDT --- protobuf-c-0.15-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/protobuf-c-0.15-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 --- Comment #30 from Fedora Update System 2011-04-26 07:22:54 EDT --- protobuf-c-0.15-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/protobuf-c-0.15-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
