[Bug 684475] Review Request: wmblob - Dockapp which shows funny moving `blobs'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684475 --- Comment #6 from Mario Blättermann 2011-05-08 05:52:37 EDT --- (In reply to comment #5) > You should inform upstream about the incorrect fsf address in COPYING, but no > further action necessary. Upstream is only available from the dockapp pool at dockapps.org, no real homepage found. Well, I will try to send a mail to the author Jean-Luc-Herren, but I don't think to get a response. Thanks for your review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479669 Iain Arnell changed: What|Removed |Added CC||iarn...@gmail.com --- Comment #9 from Iain Arnell 2011-05-08 05:52:21 EDT --- Marcela, perl-File-pushd appears to be in RHEL6 optional for some archs, but missing from ppc. Would you mind branching for el6 and re-building using the upstream srpm ftp://ftp.redhat.com/pub/redhat/linux/enterprise/6Server/en/os/SRPMS/perl-File-pushd-1.00-3.1.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684475] Review Request: wmblob - Dockapp which shows funny moving `blobs'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684475 Mario Blättermann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Mario Blättermann 2011-05-08 05:55:27 EDT --- New Package SCM Request === Package Name: wmblob Short Description: Dockapp which shows funny moving `blobs' Owners: mariobl Branches: f14 f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697425] Review Request: sound-theme-beethoven-fifth - Sound theme based on Beethoven's fifth symphony
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=697425
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
Flag||fedora-review+
--- Comment #6 from Mario Blättermann 2011-05-08 06:15:19
EDT ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3057939
No further issues from rpmlint after the last change.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
Public Domain
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
From the licensing guidelines:
"Being in the public domain is not a license; rather, it means the material
is not copyrighted and no license is needed. "
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
11d6c7a4ab8ad843500656199c15caf3 sound-theme-beethoven-fifth-1.0.tar.bz2
11d6c7a4ab8ad843500656199c15caf3
sound-theme-beethoven-fifth-1.0.tar.bz2.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
No BuildRequires needed at all. Basic build environment is sufficient.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
Tested on F14, works for me.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.
PACKAGE APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.c
[Bug 697425] Review Request: sound-theme-beethoven-fifth - Sound theme based on Beethoven's fifth symphony
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697425 Elad Alfassa changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Elad Alfassa 2011-05-08 06:30:54 EDT --- New Package SCM Request === Package Name: sound-theme-beethoven-fifth Short Description: Sound theme based on Beethoven's fifth symphony Owners: elad Branches: f14 f15 InitialCC: elad -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697425] Review Request: sound-theme-beethoven-fifth - Sound theme based on Beethoven's fifth symphony
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697425 --- Comment #8 from Elad Alfassa 2011-05-08 06:32:01 EDT --- Thank you for the review! I hope the triage signature that was added automatically won't confuse the scm system. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696527] Review Request: django-kombu - Kombu transport using the Django database as a message store
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696527 Rahul Sundaram changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696527] Review Request: django-kombu - Kombu transport using the Django database as a message store
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696527 --- Comment #2 from Rahul Sundaram 2011-05-08 06:47:17 EDT --- It is code under the same license and hence no incompatibility between licenses. Doesn't require a note anywhere else but thanks for the thorough check. It would be helpful if you can review bug 691115 as well since it is a dependency that needs to be built first. New Package SCM Request === Package Name: django-kombu Short Description: Kombu transport using the Django database as a message store Owners: sundaram Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697680] Review Request: surf-geometry - visualizer for real algebraic geometry
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=697680
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
Flag||fedora-review?
--- Comment #6 from Mario Blättermann 2011-05-08 06:51:14
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3057965
$ rpmlint -v *
surf-geometry.src: I: checking
surf-geometry.src: W: spelling-error %description -l en_US codimension -> co
dimension, co-dimension, dimensional
surf-geometry.src: I: checking-url http://surf.sourceforge.net/ (timeout 10
seconds)
surf-geometry.src: I: checking-url
http://downloads.sourceforge.net/project/surf/surf/1.0.6/surf-1.0.6.tar.gz
(timeout 10 seconds)
surf-geometry.i686: I: checking
surf-geometry.i686: W: spelling-error %description -l en_US codimension -> co
dimension, co-dimension, dimensional
surf-geometry.i686: I: checking-url http://surf.sourceforge.net/ (timeout 10
seconds)
surf-geometry.i686: E: incorrect-fsf-address
/usr/share/doc/surf-geometry-1.0.6/COPYING
surf-geometry.i686: W: no-manual-page-for-binary surf-geometry
surf-geometry-debuginfo.i686: I: checking
surf-geometry-debuginfo.i686: I: checking-url http://surf.sourceforge.net/
(timeout 10 seconds)
surf-geometry.spec: I: checking-url
http://downloads.sourceforge.net/project/surf/surf/1.0.6/surf-1.0.6.tar.gz
(timeout 10 seconds)
3 packages and 1 specfiles checked; 1 errors, 3 warnings.
OK so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
598142168e940a818c7b5a7a66b35082 surf-1.0.6.tar.gz
598142168e940a818c7b5a7a66b35082 surf-1.0.6.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[x] MUST: A package must own all directories that it creates.
%{_datadir}/surf-geometry
just put a / after this entry to let the package own this folder and its
content.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstr
[Bug 700587] Review Request: surfer - visualization of algebraic geometry
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700587
Mario Blättermann changed:
What|Removed |Added
CC||mari...@freenet.de
--- Comment #1 from Mario Blättermann 2011-05-08 07:00:38
EDT ---
%{_datadir}/surfer
%exclude %{_datadir}/surfer/gallery
These directories and their contents are not properly owned by your package.
Please put a / after the name to do so.
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695026] Review Request: opendict - free multiplatform dictionary program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695026 --- Comment #4 from Aurimas Černius 2011-05-08 07:31:55 EDT --- Thanks for comments. I've uploaded new versions of both files, corrected accordingly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 --- Comment #2 from Adam Huffman 2011-05-08 08:01:13 EDT --- (In reply to comment #1) > Just some comments: Thanks for looking > > Please include the license file. The postal addresses of the FSF are outdated > in several files. > File included and I'll contact upstream about the out of data FSF address. > Use -p on the install commands, at least for the scripts. One of the scripts > uses the samtools binary, so you'll need an explicit Require on that, as RPM > will only install samtools-libs > Done. > Besides the first part of the package description is pretty generic, it says, > it would contain instructions. I can't see any and especially the mmseq binary > is especially sparse on saying anything. Why does the description not have the > word "Haplotype"? > I was trying to differentiate the description from the summary but have improved it now. > Why did you choose to not install the Perl script? > Fixed. > You might want to add "-b .name_of_the_patch" to the patch macros. Please also > comment on the patches. Done. I've also updated to the latest upstream release. http://verdurin.fedorapeople.org/reviews/mmseq/mmseq.spec http://verdurin.fedorapeople.org/reviews/mmseq/mmseq-0.9.10b-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691189] Review Request: wmbinclock - Dockapp which shows the actual system time as binary clock
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691189
Iain Arnell changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||iarn...@gmail.com
AssignedTo|nob...@fedoraproject.org|iarn...@gmail.com
Flag||fedora-review?
--- Comment #1 from Iain Arnell 2011-05-08 08:24:09 EDT ---
At first glance, this looks to be mostly okay; just a couple of minor issues.
You need to pass CFLAGS="%{?optflags}" to the build.
And there is inconsistent use of macros vs variables - but since we don't need
to clean buildroot in %install, you can just remove the offending line.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691115] Review Request: python-kombu - AMQP Messaging Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691115 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691115] Review Request: python-kombu - AMQP Messaging Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691115 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696527] Review Request: django-kombu - Kombu transport using the Django database as a message store
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696527 --- Comment #3 from Lakshmi Narasimhan 2011-05-08 08:28:45 EDT --- I have taken the dependency bug for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691189] Review Request: wmbinclock - Dockapp which shows the actual system time as binary clock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691189 --- Comment #2 from Mario Blättermann 2011-05-08 08:37:47 EDT --- Thanks for your hints. Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmbinclock.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmbinclock-0.5-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696485] Review Request: django-countries - Provides a country field for Django models
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696485 --- Comment #1 from Arun SAG 2011-05-08 08:49:48 EDT --- Hi Rahul, Every thing seems fine except the rpmlint on the binary rpm [zer0c00l@gnubox SPECS]$ rpmlint ~/rpmbuild/RPMS/noarch/django-countries-1.0.5-1.fc14.noarch.rpm django-countries.noarch: E: zero-length /usr/lib/python2.7/site-packages/django_countries/models.py 1 packages and 0 specfiles checked; 1 errors, 0 warnings. It is completely OK to have an empty models.py in a django app, On the other hand i tried removing this models.py and reinstalled this app, the test application worked fine without any issues. Please remove the empty files by using 'find $RPM_BUILD_ROOT -size 0 -delete' at the end of install section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604971] Review Request: jwm - Joe's Window Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604971 --- Comment #10 from Mario Blättermann 2011-05-08 09:07:26 EDT --- Any news about this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699205] Review Request: perl-Graph-Easy - Convert or render graphs as ASCII, HTML, SVG or via Graphviz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699205 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #1 from Mario Blättermann 2011-05-08 09:05:29 EDT --- I've repeated the builds successfully for f14 and f15 to see if it builds there: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058077 http://koji.fedoraproject.org/koji/taskinfo?taskID=3058081 $ rpmlint -v * perl-Graph-Easy.noarch: I: checking perl-Graph-Easy.noarch: W: spelling-error %description -l en_US layouter -> lay outer, lay-outer, layout er perl-Graph-Easy.noarch: I: checking-url http://search.cpan.org/dist/Graph-Easy/ (timeout 10 seconds) perl-Graph-Easy.src: I: checking perl-Graph-Easy.src: W: spelling-error %description -l en_US layouter -> lay outer, lay-outer, layout er perl-Graph-Easy.src: I: checking-url http://search.cpan.org/dist/Graph-Easy/ (timeout 10 seconds) perl-Graph-Easy.src: I: checking-url http://www.cpan.org/authors/id/S/SH/SHLOMIF/Graph-Easy-0.70.tar.gz (timeout 10 seconds) perl-Graph-Easy.spec: I: checking-url http://www.cpan.org/authors/id/S/SH/SHLOMIF/Graph-Easy-0.70.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Just a spelling error. But in my mind, "layouter" is a common spelling, too. Could be kept as is. I'm not sure at all if "examples" in %doc should be followed by a / to let the package own the whole folder including its contents. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702861] Review Request: libidn2 - Library to support IDNA2008 internationalized domain names
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702861 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #1 from Mario Blättermann 2011-05-08 09:30:40 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058125 $ rpmlint -v * libidn2.i686: I: checking libidn2.i686: I: checking-url http://www.josefsson.org/libidn2/ (timeout 10 seconds) libidn2.src: I: checking libidn2.src: I: checking-url http://www.josefsson.org/libidn2/ (timeout 10 seconds) libidn2.src: I: checking-url http://www.josefsson.org/libidn2/releases/libidn2-0.3.tar.gz (timeout 10 seconds) libidn2-debuginfo.i686: I: checking libidn2-debuginfo.i686: I: checking-url http://www.josefsson.org/libidn2/ (timeout 10 seconds) libidn2-devel.i686: I: checking libidn2-devel.i686: I: checking-url http://www.josefsson.org/libidn2/ (timeout 10 seconds) libidn2.spec: I: checking-url http://www.josefsson.org/libidn2/releases/libidn2-0.3.tar.gz (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 0 warnings. No issues so far. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694998] Review Request: cufflinks - RNA-Seq transcript assembly, differential expression/regulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694998 --- Comment #1 from Adam Huffman 2011-05-08 09:40:55 EDT --- New version with various fixes and latest upstream release: http://verdurin.fedorapeople.org/reviews/cufflinks/cufflinks.spec http://verdurin.fedorapeople.org/reviews/cufflinks/cufflinks-1.0.1-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676853] Review Request: goocanvasmm2 - goocanvasmm2 goodness for Gtk3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676853 Bug 676853 depends on bug 676791, which changed state. Bug 676791 Summary: Review Request: goocanvas2 - goocanvas goodness for Gtk3 https://bugzilla.redhat.com/show_bug.cgi?id=676791 What|Old Value |New Value Resolution||NEXTRELEASE Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676791] Review Request: goocanvas2 - goocanvas goodness for Gtk3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676791 Haïkel Guémar changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE Last Closed||2011-05-08 10:06:00 --- Comment #8 from Haïkel Guémar 2011-05-08 10:06:00 EDT --- already imported into fedora packages collection (F15+) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626004 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #9 from Mario Blättermann 2011-05-08 10:04:20 EDT --- Koji scratch build was not successful for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058186 From build.log: autoreconf: running: aclocal -I m4 --output=aclocal.m4t Can't exec "aclocal": Permission denied at /usr/share/autoconf/Autom4te/FileUtils.pm line 326. autoreconf: failed to run aclocal: Permission denied error: Bad exit status from /var/tmp/rpm-tmp.xZSPvl (%build) Same problem in F16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058191 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700814] Review Request: din - A musical instrument using multiple Bezier curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700814 --- Comment #4 from Adam Huffman 2011-05-08 10:12:50 EDT --- New upstream release: http://verdurin.fedorapeople.org/reviews/din/din.spec http://verdurin.fedorapeople.org/reviews/din/din-1.5.9-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689870] Review Request: tabix - Generic indexer for TAB-delimited genome position files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689870 --- Comment #2 from Adam Huffman 2011-05-08 10:21:52 EDT --- New upstream release: http://verdurin.fedorapeople.org/reviews/tabix/tabix.spec http://verdurin.fedorapeople.org/reviews/tabix/tabix-0.2.5-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702861] Review Request: libidn2 - Library to support IDNA2008 internationalized domain names
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702861 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702861] Review Request: libidn2 - Library to support IDNA2008 internationalized domain names
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702861
Mario Blättermann changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Mario Blättermann 2011-05-08 11:17:54
EDT ---
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
98f3f31312376e398f6e51aff2ac93c1 libidn2-0.3.tar.gz
98f3f31312376e398f6e51aff2ac93c1 libidn2-0.3.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available, see above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[+] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[+] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
Explicitely called with INSTALL='install -p'
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
PACKAGE APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701284] Review Request: python-py2pack - Generate distribution packages from Python packages on PyPI
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701284
--- Comment #2 from Haïkel Guémar 2011-05-08 11:35:42
EDT ---
Preliminary pass:
MUST: rpmlint must be run on src.rpm and rpm: KO
$ rpmlint -iv python-py2pack-0.3.15-1.fc14.src.rpm
python-py2pack.src: I: checking
python-py2pack.src: W: spelling-error %description -l en_US dsc -> dc, disc,
doc
The value of this tag appears to be misspelled. Please double-check.
python-py2pack.src: W: spelling-error %description -l en_US changelogs ->
change logs, change-logs, changelings
The value of this tag appears to be misspelled. Please double-check.
python-py2pack.src: I: checking-url http://github.com/saschpe/py2pack (timeout
10 seconds)
python-py2pack.src:41: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab:
line 41)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
python-py2pack.src: W: invalid-url Source0: py2pack-0.3.15.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint -iv python-py2pack-0.3.15-1.fc15.noarch.rpm
python-py2pack.noarch: I: checking
python-py2pack.noarch: W: spelling-error %description -l en_US dsc -> dc, disc,
doc
The value of this tag appears to be misspelled. Please double-check.
python-py2pack.noarch: W: spelling-error %description -l en_US changelogs ->
change logs, change-logs, changelings
The value of this tag appears to be misspelled. Please double-check.
python-py2pack.noarch: I: checking-url http://github.com/saschpe/py2pack
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please provide download url in Source field, in your case, that should be:
http://pypi.python.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz
Though not explicitly mandatory, fix the tabs issue, real editors can do that
automagically.
MUST: package named accordingly to package naming guidelines: OK
MUST: spec file name match %{name}: OK
MUST: licensed according a Fedora compliant license: OK (GPLv2 - license file
included)
MUST: License field in spec match actual license: OK
MUST: spec in legible american english: OK
MUST: sources provided match upstream's OK
provided sources md5sum: 8a9aceba034a96cfa9d622971cb697e4
upstream sources md5sum: 8a9aceba034a96cfa9d622971cb697e4
MUST: package sucessfully compiles on at least one primary architecture (all of
them: x86 and x86_64 under mock for fedora-devel)
MUST: all build dependencies are listed in BR: OK
MUST: package does not list a file more than once in %files section: OK
MUST: permissions are properly set: OK
MUST: package consistenly uses macros: OK
MUST: package contains permissable content: OK
MUST: all filenames are valid UTF-8: OK
SHOULD: the module provided works (tested with python 2.7)
Note: does not build on python 3.2 as stated by the reviewee in the spec
few remarks:
* inconsistent use of macros: %{_mandir} | /usr/man/man1/ %{_docdir} |
/usr/share/doc ==> please use the macro
choose either $RPM_BUILD_ROOT or %{buildroot}.
* can you state the reasons why you disabled the %check part ? If you're not
planning to fix this, you should at least comment the whole part.
* about python3 support bits, what's the current situation ? is it supported
upstream or a work-in-progress ? are you working on a patch to fix build issues
?
* probably a matter of style, but i'd prefer that you explicitely set
permissions for chmod commands (0755 for the scripts). I advise you to do the
same for the man pages (0644).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696485] Review Request: django-countries - Provides a country field for Django models
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696485 --- Comment #2 from Rahul Sundaram 2011-05-08 11:40:51 EDT --- I am not sure deleting this file isn't affecting the functionality somehow but for now let's go ahead with this. Doing what you suggest would screw around with the byte code files. I have done it differently with the same end result http://sundaram.fedorapeople.org/packages/django-countries.spec http://sundaram.fedorapeople.org/packages/django-countries-1.0.5-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467507] Review Request: Rufscript-fonts - Rufscripts is a decorative handwriting based font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467507 Paul Flo Williams changed: What|Removed |Added CC||p...@frixxon.co.uk --- Comment #7 from Paul Flo Williams 2011-05-08 11:38:02 EDT --- Is Rahul with you taking over this package? (The passage of time suggests yes, but you never know.) 1. The spec name must be the same as the package name. 2. The license in the source file is GPLv3+ with exceptions 3. The SFD contains the line "Version: 0.1.0" and this is consistent with Hiran's other font under review at the moment, Perizia, but version control of fonts is notoriously bad so 0.100, pulled from the name table, is OK. 4. The fontconfig is very wrong, as you've said that the font "Sans" is the same as the font "Rufscript". Please use the basic fontconfig template and declare this as a cursive font. 5. From Nicolas's previous comment #2, points 6 and 7 still apply. Other than those, this is a simple package, and almost ready for approval. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689797] Review Request: perl-Task-Kensho-Toolchain - Task::Kensho::Toolchain Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689797 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #1 from Mario Blättermann 2011-05-08 11:54:27 EDT --- Koji scratch build for f15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058311 $ rpmlint -v * perl-Task-Kensho-Toolchain.src: I: checking perl-Task-Kensho-Toolchain.src: W: spelling-error %description -l en_US Kenshō perl-Task-Kensho-Toolchain.src: W: spelling-error %description -l en_US nonduality -> non duality, non-duality, individuality perl-Task-Kensho-Toolchain.src: I: checking-url http://search.cpan.org/dist/Task-Kensho-Toolchain/ (timeout 10 seconds) perl-Task-Kensho-Toolchain.src: I: checking-url http://www.cpan.org/authors/id/A/AP/APEIRON/Task-Kensho-Toolchain-0.27.tar.gz (timeout 10 seconds) perl-Task-Kensho-Toolchain.noarch: I: checking perl-Task-Kensho-Toolchain.noarch: W: spelling-error %description -l en_US Kenshō perl-Task-Kensho-Toolchain.noarch: W: spelling-error %description -l en_US nonduality -> non duality, non-duality, individuality perl-Task-Kensho-Toolchain.noarch: I: checking-url http://search.cpan.org/dist/Task-Kensho-Toolchain/ (timeout 10 seconds) perl-Task-Kensho-Toolchain.spec: I: checking-url http://www.cpan.org/authors/id/A/AP/APEIRON/Task-Kensho-Toolchain-0.27.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 4 warnings. A spelling error. I would recommend the proposed "non-duality". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694950 --- Comment #9 from Michal Nowak 2011-05-08 12:06:09 EDT --- torrent-search_0.9.2.3 is out, update the spec file, please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689212] Review Request: hunspell-tpi - Tok Pisin hunspell dictionaries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689212
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mari...@freenet.de
AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
Flag||fedora-review+
--- Comment #1 from Mario Blättermann 2011-05-08 12:18:36
EDT ---
$ rpmlint -v *
hunspell-tpi.noarch: I: checking
hunspell-tpi.noarch: W: spelling-error Summary(en_US) Tok -> Tod, Tom, Tob
hunspell-tpi.noarch: W: spelling-error %description -l en_US Tok -> Tod, Tom,
Tob
hunspell-tpi.noarch: I: checking-url
http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker
(timeout 10 seconds)
hunspell-tpi.noarch: W: invalid-url URL:
http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker
hunspell-tpi.src: I: checking
hunspell-tpi.src: W: spelling-error Summary(en_US) Tok -> Tod, Tom, Tob
hunspell-tpi.src: W: spelling-error %description -l en_US Tok -> Tod, Tom, Tob
hunspell-tpi.src: I: checking-url
http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker
(timeout 10 seconds)
hunspell-tpi.src: I: checking-url
http://extensions.services.openoffice.org/e-files/4824/2/hunspell-tpi-0.05.oxt
(timeout 10 seconds)
hunspell-tpi.spec: I: checking-url
http://extensions.services.openoffice.org/e-files/4824/2/hunspell-tpi-0.05.oxt
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
No issues so far. At least nothing we should be aware of. The spelling error
could be ignored.
Koji scratch build for f15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058321
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
39619bd8a95265e9501e1c438ea1d290 hunspell-tpi-0.05.oxt
39619bd8a95265e9501e1c438ea1d290 hunspell-tpi-0.05.oxt.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
No BuildRequires at all.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SH
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694950 --- Comment #10 from Michal Nowak 2011-05-08 12:26:11 EDT --- Also noted I don't see icon in Menu->Internet->Torrent Search, seems like a problem with desktop file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668204] Review Request: buzzbird - Twitter and identi.ca desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668204 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #9 from Mario Blättermann 2011-05-08 12:28:21 EDT --- (In reply to comment #7) > this does not apply to source tarball as far as I know, no > bundled/pre-compiled > binary file is present in final rpm. But you have to make sure that no one of the prebuilt binaries will be used during the build process. Otherwise, the resulting binaries would be affected by these libraries anyway. The solution is to remove the binaries before you do anything in your package. If it doesn't build anymore, we have a problem. If it builds properly again, then we know that all is OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702957] New: Review Request: pclock - WindowMaker dockapp which displays an analog clock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pclock - WindowMaker dockapp which displays an analog clock https://bugzilla.redhat.com/show_bug.cgi?id=702957 Summary: Review Request: pclock - WindowMaker dockapp which displays an analog clock Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mari...@freenet.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/pclock.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/pclock-0.13.1-1.fc14.src.rpm Description: pclock is a simple analog clock program designed primarily to run under the Window Maker window manager. Any 64x64 pixmap may be used as a background, including tiles. One current limitation is that the clock hands are drawn within the mask of the background XPM file. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058358 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696485] Review Request: django-countries - Provides a country field for Django models
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=696485
Arun SAG changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #3 from Arun SAG 2011-05-08 13:18:21 EDT ---
Rahul,
I got that trick from
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files
You are correct __init__ files in python packages can be empty, if we remove
those files that will screw up the package.
On the other hand, If the upstream chooses to have some code inside models.py
in future (unlikely), you _might_ accidentally end up deleting it :-)
complete review:
+ = OK
- = NA
? = issue
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum
b3c0ac13c382ac41bff786231dc20e79
/home/zer0c00l/rpmbuild/SOURCES/django-countries-1.0.5.tar.gz
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058140
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk and
anything provided by glibc.)
SHOULD Items:
+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Package tested and working fine with Django-1.2.5
===
In [2]: from users import models
In [3]from users.models import Person
In [4]:person = Person(name='Arun',country='IN')
In [5]: person.country
Out[5]: Country(code=u'IN')
In [6]: person.country.flag
Out[6]: u'/flags/in.gif'
=
XX APPROVED XXX
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701450] Review Request: pygtkchart - A GTK chart widget written in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701450 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de --- Comment #2 from Mario Blättermann 2011-05-08 13:23:02 EDT --- $ rpmlint -v * pygtkchart.src: I: checking pygtkchart.src: I: checking-url http://notmyname.github.com/pygtkChart/ (timeout 10 seconds) pygtkchart.src: I: checking-url https://github.com/notmyname/pygtkChart/tarball/beta/notmyname-pygtkChart-beta-0-g8a56364.tar.gz (timeout 10 seconds) pygtkchart.noarch: I: checking pygtkchart.noarch: I: checking-url http://notmyname.github.com/pygtkChart/ (timeout 10 seconds) pygtkchart.spec: I: checking-url https://github.com/notmyname/pygtkChart/tarball/beta/notmyname-pygtkChart-beta-0-g8a56364.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. No issues. Would be nice to add a comment to the spec what the patch does. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701450] Review Request: pygtkchart - A GTK chart widget written in Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701450
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #3 from Martin Gieseking 2011-05-08
13:55:43 EDT ---
Some things are still to be fixed:
- The package seems to provide a pre-release as the tarball is tagged as beta.
Thus, the Release field should look like this: 0.1.git%{git}%{?dist}
http://fedoraproject.org/wiki/PackageNamingGuidelines#Pre-Release_packages
- Prefix the patch name with %{name}- or %{name}-%{version}- and, as Mario
already mentioned, add a comment about what the patch does.
- The package currently doesn't own %{_datadir}/%{name}/
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700587] Review Request: surfer - visualization of algebraic geometry
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700587 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #2 from Martin Gieseking 2011-05-08 14:12:43 EDT --- (In reply to comment #1) > These directories and their contents are not properly owned by your package. > Please put a / after the name to do so. The trailing slash is optional. It doesn't add any semantics to the path expression. However, it could help packagers to visually distinguish between files and folders. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702103] Review Request: python-osmgpsmap - Python bindings for osm-gps-map GTK+ widget
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702103 --- Comment #3 from Michael Schwendt 2011-05-08 14:19:14 EDT --- Needed BuildRequires for pygobject2-devel pygtk2-devel to build here in Plague. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701982 Michael Schwendt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Michael Schwendt 2011-05-08 14:19:10 EDT --- The added BuildRequires cairo-gobject-devel isn't needed, is it? Other than that, the rpmdev-diff output looks fine. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702143] Review Request: wallaby - configuration service for Condor pools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702143 Mario Blättermann changed: What|Removed |Added CC||mari...@freenet.de Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Mario Blättermann 2011-05-08 14:27:28 EDT --- If you use the "copy" command for the installation, add always the switch -p to keep timestamps. If you need a sponsor, you have to add FE-NEEDSPONSOR to "Blocks:". I did this for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702846] Review Request: mingw32-gdb - MinGW Windows port of the GDB debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702846 Peter Lemenkov changed: What|Removed |Added CC||lemen...@gmail.com --- Comment #1 from Peter Lemenkov 2011-05-08 14:55:53 EDT --- I'm curious - what's the purpose of this package? I mean I don't think it's intended to run on Fedora machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688421] Review Request: pyicu - Python extension wrapping IBM's ICU C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688421 --- Comment #4 from PRABIN KUMAR DATTA 2011-05-08 14:56:01 EDT --- > This package has no requires - are you sure? It may not - 1. It is working fine in my case. Tested using aarddict and aardtool. 2. Used https://launchpadlibrarian.net/70790028/pyicu_1.1-1.diff.gz as a reference * Updated rest part: Spec file: http://prabindatta.fedorapeople.org/SPECS/PyICU.spec SRPMS file: http://prabindatta.fedorapeople.org/SRPMS/PyICU-1.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700587] Review Request: surfer - visualization of algebraic geometry
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700587 --- Comment #3 from Mario Blättermann 2011-05-08 15:00:16 EDT --- (In reply to comment #2) > (In reply to comment #1) > > > These directories and their contents are not properly owned by your package. > > Please put a / after the name to do so. > > The trailing slash is optional. It doesn't add any semantics to the path > expression. However, it could help packagers to visually distinguish between > files and folders. Anyway, this is the style as mentioned in the packaging guidelines. And yes, it helps packagers and reviewers, really. Sometimes it is difficult to keep track of the validity in the filelist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 Robert Scheck changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|redhat-bugzilla@linuxnetz.d ||e Flag||fedora-review? --- Comment #1 from Robert Scheck 2011-05-08 14:59:56 EDT --- $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm aswvdial.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage aswvdial.src: W: spelling-error Summary(en_US) wvdial -> medial, audial, radial aswvdial.src: W: spelling-error Summary(de) Dockapp -> Dock, Andocke, Documenta aswvdial.src: W: spelling-error Summary(de) wvdial -> radial, Dialog, Dialyse aswvdial.src: W: spelling-error %description -l en_US wvdial -> medial, audial, radial aswvdial.src: W: spelling-error %description -l de wvdial -> radial, Dialog, Dialyse aswvdial.src: W: spelling-error %description -l de conf -> Connor, contra, Conferencier aswvdial.x86_64: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage aswvdial.x86_64: W: spelling-error Summary(de) Dockapp -> Dock, Andocke, Documenta aswvdial.x86_64: W: spelling-error %description -l de conf -> Connor, contra, Conferencier aswvdial.x86_64: E: incorrect-fsf-address /usr/share/doc/aswvdial-1.7/COPYING aswvdial.x86_64: W: no-manual-page-for-binary netdown aswvdial.x86_64: W: no-manual-page-for-binary aswvdial aswvdial.x86_64: W: no-manual-page-for-binary netup aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/aswvdial/fileio.c aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/aswvdial/aswvdial.h aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/wmgeneral/list.h aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/wmgeneral/list.c aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/aswvdial/display.c aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/wmgeneral/misc.c aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/aswvdial/main.c aswvdial-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aswvdial/aswvdial/misc.c 3 packages and 0 specfiles checked; 9 errors, 13 warnings. $ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 Robert Scheck changed: What|Removed |Added CC||tcall...@redhat.com Blocks||182235(FE-Legal) --- Comment #2 from Robert Scheck 2011-05-08 15:02:46 EDT --- Tom, may you please enlighten us regarding "incorrect-fsf-address" and its possible impact for Fedora? Which steps have to be taken here? Does it block the review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702861] Review Request: libidn2 - Library to support IDNA2008 internationalized domain names
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702861 Robert Scheck changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Robert Scheck 2011-05-08 15:06:20 EDT --- Mario, thank you very much for the review. New Package SCM Request === Package Name: libidn2 Short Description: Library to support IDNA2008 internationalized domain names Owners: robert Branches: el4 el5 el6 f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 --- Comment #3 from Mario Blättermann 2011-05-08 15:13:52 EDT --- Look here: https://bugzilla.redhat.com/show_bug.cgi?id=684475#c6 The incorrect FSF address doesn't affect the build process or the security of the package in no way. If there was an active upstream project, I would patch the package and send the patch to the maintainers. But in our case, it is impossible. BTW, I'm sure this affects some other packages whose upstream is dead and which are moved through the distribution releases over years. Well, it would be fine to have a common guideline for it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702846] Review Request: mingw32-gdb - MinGW Windows port of the GDB debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702846 --- Comment #2 from Kalev Lember 2011-05-08 15:21:05 EDT --- One way to debug MinGW cross compiled programs is to use gdb's remote debugging features: gdbserver.exe would run under wine and control the execution of the program we are debugging; native gdb (running on the same host) can then communicate with gdbserver's process over a TCP connection. The technique is explained at http://mingw-cross.sourceforge.net/cross_debug.html There have been numerous requests for MinGW cross compiled gdb, and quite frankly I just got tired of telling everyone that they have to build gdb themselves. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 --- Comment #4 from Mario Blättermann 2011-05-08 15:22:55 EDT --- There is a similar upstream project in Launchpad: https://launchpad.net/aswvdial It reuses the original code and applies a patch to make this WindowMaker dockapp available in the GNOME panel. I could report a bug there, but this wouldn't affect the sources used in my package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688421] Review Request: pyicu - Python extension wrapping IBM's ICU C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688421 David Nalley changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|da...@gnsa.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688421] Review Request: pyicu - Python extension wrapping IBM's ICU C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688421 David Nalley changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from David Nalley 2011-05-08 15:34:57 EDT --- OK - you fixed the remaining blockers. APPROVED I'll sponsor you in FAS in just a few moments. Please remove FE-NEEDSPONSOR from your other packages. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698362] Review Request: writetype - Light word processor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698362 PRABIN KUMAR DATTA changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701815] Review Request: vo-amrwbenc - VisualOn AMR-WB encoder library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701815 PRABIN KUMAR DATTA changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701811] Review Request: vo-aacenc - VisualOn AAC encoder library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701811 PRABIN KUMAR DATTA changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692131] Review Request: sflphone - SIP/IAX2 compatible enterprise-class softphone for multi-way conferencing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692131 PRABIN KUMAR DATTA changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 687875] Review Request: aarddict - Multi-platform dictionary and offline Wikipedia reader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=687875 PRABIN KUMAR DATTA changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702987] New: Review Request: stdair - C++ Standard Airline IT Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: stdair - C++ Standard Airline IT Library https://bugzilla.redhat.com/show_bug.cgi?id=702987 Summary: Review Request: stdair - C++ Standard Airline IT Library Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Linux Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: denis.arnaud_fed...@m4x.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://denisarnaud.fedorapeople.org/stdair/stdair-0.30.0-1.spec SRPM URL: https://downloads.sourceforge.net/project/stdair/fedora_14/stdair-0.30.0-1.fc14.src.rpm === Description: StdAir aims at providing a clean API, and the corresponding C++ implementation, for the basis of Airline IT Business Object Model (BOM), that is, to be used by several other Open Source projects, such as RMOL, Air-Sched, Travel-CCM, OpenTREP, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=614036 Denis Arnaud changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2011-05-08 17:13:54 --- Comment #13 from Denis Arnaud 2011-05-08 17:13:54 EDT --- *** This bug has been marked as a duplicate of bug 702987 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702987] Review Request: stdair - C++ Standard Airline IT Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702987 Denis Arnaud changed: What|Removed |Added CC||nguyenk...@gmail.com --- Comment #1 from Denis Arnaud 2011-05-08 17:13:54 EDT --- *** Bug 614036 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702987] Review Request: stdair - C++ Standard Airline IT Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702987 --- Comment #2 from Denis Arnaud 2011-05-08 17:24:15 EDT --- StdAir does no longer depends on ExtraCC (see bug #616881); so, the second issue in https://bugzilla.redhat.com/show_bug.cgi?id=614036#c4 does no longer apply. And, as all the other issues had already been addressed, that package should now be correct. Moreover, of course, rpmlint does not report any error/warning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701815] Review Request: vo-amrwbenc - VisualOn AMR-WB encoder library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701815 --- Comment #4 from PRABIN KUMAR DATTA 2011-05-08 17:22:03 EDT --- Upstream Comment on FE-Legal issue: vo-aacenc is one library implementing an AAC encoder, libfaac is another. The patents don't cover any particular implementation - they're essential to implementing the standard and thus cover all implementations. So there can not be any implementations of AAC (nor AMR-WB) that isn't covered by patents. Copyrightwise, however, they are proper opensource, contrary to some earlier AAC and AMR-WB libraries, which were either totally unredistributable (libamr) or that have dubious origin and thus aren't considered properly redistributable either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701811] Review Request: vo-aacenc - VisualOn AAC encoder library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701811 --- Comment #3 from PRABIN KUMAR DATTA 2011-05-08 17:23:05 EDT --- Upstream Comment on FE-Legal issue: vo-aacenc is one library implementing an AAC encoder, libfaac is another. The patents don't cover any particular implementation - they're essential to implementing the standard and thus cover all implementations. So there can not be any implementations of AAC (nor AMR-WB) that isn't covered by patents. Copyrightwise, however, they are proper opensource, contrary to some earlier AAC and AMR-WB libraries, which were either totally unredistributable (libamr) or that have dubious origin and thus aren't considered properly redistributable either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688421] Review Request: pyicu - Python extension wrapping IBM's ICU C++ libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688421 --- Comment #6 from PRABIN KUMAR DATTA 2011-05-08 17:25:25 EDT --- > OK - you fixed the remaining blockers. > APPROVED > I'll sponsor you in FAS in just a few moments. Thank You! > Please remove FE-NEEDSPONSOR from your other packages. Done! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702989] New: Review Request: itstool - Translate XML files with PO using ITS rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: itstool - Translate XML files with PO using ITS rules https://bugzilla.redhat.com/show_bug.cgi?id=702989 Summary: Review Request: itstool - Translate XML files with PO using ITS rules Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sha...@gnome.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.gnome.org/~shaunm/itstool-rpm/itstool.spec SRPM URL: http://people.gnome.org/~shaunm/itstool-rpm/itstool-1.0.1-1.fc14.src.rpm Description: ITS Tool is a Python program that converts between XML and PO using rules from the W3C Internationalization Tag Set (ITS). It's slated to replace xml2po from gnome-doc-utils in GNOME. This is the first time I've made an RPM for others to use. I tried to follow the guidelines on the wiki. Please let me know if I've done anything wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702998] New: Review Request: pyttsx - Cross platform text-to-speech
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pyttsx - Cross platform text-to-speech https://bugzilla.redhat.com/show_bug.cgi?id=702998 Summary: Review Request: pyttsx - Cross platform text-to-speech Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: linux.n@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://prabindatta.fedorapeople.org/SPECS/pyttsx.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/pyttsx-1.0-1.fc14.src.rpm Description: pyttsx is a Python package supporting common text-to-speech engines. It currently supports SAPI5, NSSpeechSynthesizer, and espeak. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702998] Review Request: pyttsx - Cross platform text-to-speech
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702998 --- Comment #2 from PRABIN KUMAR DATTA 2011-05-08 18:46:10 EDT --- Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3058818 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702998] Review Request: pyttsx - Cross platform text-to-speech
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702998
--- Comment #1 from PRABIN KUMAR DATTA 2011-05-08
18:45:36 EDT ---
Just for testing:
//-- Python code--
import pyttsx
engine = pyttsx.init()
engine.say('What is your name?')
engine.say('My name is Prabin Kumar Datta')
engine.runAndWait()
//
Works fine!!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701494] Review Request: wlmproxy - An advanced proxy for the MSN Messenger protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701494 --- Comment #10 from Fedora Update System 2011-05-08 19:45:22 EDT --- wlmproxy-0.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wlmproxy-0.1.2-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #17 from Fedora Update System 2011-05-08 21:52:45 EDT --- sudoku-savant-1.3-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Fedora Update System changed: What|Removed |Added Fixed In Version|sudoku-savant-1.3-3.fc15|sudoku-savant-1.3-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648758 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||supybot-notify-0.2.1-1.fc14 Resolution||ERRATA Last Closed||2011-05-08 21:51:33 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648758] Review Request: supybot-notify - Notification plugin for Supybot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648758 --- Comment #7 from Fedora Update System 2011-05-08 21:51:27 EDT --- supybot-notify-0.2.1-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676216] Review Request: sugar-calendario - agenda/calendar for sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676216 --- Comment #18 from Fedora Update System 2011-05-08 21:53:15 EDT --- sugar-calendario-3-4.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676216] Review Request: sugar-calendario - agenda/calendar for sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676216 Fedora Update System changed: What|Removed |Added Fixed In Version|sugar-calendario-3-4.fc15 |sugar-calendario-3-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701982 Jeffrey C. Ollie changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jeffrey C. Ollie 2011-05-08 22:25:03 EDT --- Michael, thanks for the review. Yes, the cairo-gobject-devel is not necessary, I added that when I was testing the gobject introspection but forgot to take it back out. I'll fix that when I import the package. New Package SCM Request === Package Name: osm-gps-map Short Description: Gtk+ widget for displaying OpenStreetMap tiles Owners: jcollie Branches: devel f15 f14 f13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #22 from Fedora Update System 2011-05-08 23:55:58 EDT --- openvas-manager-2.0.3-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Fedora Update System changed: What|Removed |Added Fixed In Version|openvas-manager-2.0.3-1.fc1 |openvas-manager-2.0.3-1.fc1 |4 |5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701785] Review Request: puzzle-master - Fun and addictive jigsaw puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701785 --- Comment #12 from Fedora Update System 2011-05-08 23:57:07 EDT --- puzzle-master-1.2.2-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701785] Review Request: puzzle-master - Fun and addictive jigsaw puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701785 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||puzzle-master-1.2.2-2.fc15 Resolution||ERRATA Last Closed||2011-05-08 23:57:13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678442] Review Request: os-prober - Probes disks on the system for installed operating systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678442 --- Comment #19 from Fedora Update System 2011-05-09 00:03:57 EDT --- os-prober-1.46-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #22 from Fedora Update System 2011-05-09 00:03:41 EDT --- postler-0.1.1-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System changed: What|Removed |Added Fixed In Version|postler-0.1.1-4.fc14|postler-0.1.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678442] Review Request: os-prober - Probes disks on the system for installed operating systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678442 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||os-prober-1.46-2.fc15 Resolution||ERRATA Last Closed||2011-05-09 00:04:03 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691189] Review Request: wmbinclock - Dockapp which shows the actual system time as binary clock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691189 Iain Arnell changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Iain Arnell 2011-05-09 01:56:30 EDT --- + source files match upstream. ba268e66b59b100edb9da1cee064c258 wmbinclock-0.5.tar.bz2 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + license field matches the actual license. GPLv2+ + license is open source-compatible. + license text included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + package builds in mock (locally) + package installs properly. + rpmlint has no meaningful complaints: wmbinclock.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock wmbinclock.src: I: enchant-dictionary-not-found de wmbinclock.src: W: spelling-error %description -l en_US Dockapp -> Dock app, Dock-app, Paddock wmbinclock.x86_64: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Paddock wmbinclock.x86_64: W: spelling-error %description -l en_US Dockapp -> Dock app, Dock-app, Paddock wmbinclock.x86_64: E: incorrect-fsf-address /usr/share/doc/wmbinclock-0.5/COPYING wmbinclock.x86_64: W: no-manual-page-for-binary wmBinClock wmbinclock-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmbinclock-0.5/wmBinClock_mask.xbm wmbinclock-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmbinclock-0.5/wmBinClock.c 3 packages and 0 specfiles checked; 3 errors, 5 warnings. + final provides and requires are sane + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Again, you should advise upstream of the fsf address change and ask them to update their code. Would also be nice to get a man page too. Otherwise, all appears okay. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701284] Review Request: python-py2pack - Generate distribution packages from Python packages on PyPI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701284 --- Comment #3 from Jerome Soyer 2011-05-09 02:49:36 EDT --- Hi, First, thanks for the review, i will correct with your hints. For Python 3 support, the module don't support it upstream, i just added things in the spec for further release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699205] Review Request: perl-Graph-Easy - Convert or render graphs as ASCII, HTML, SVG or via Graphviz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699205 --- Comment #2 from Iain Arnell 2011-05-09 02:54:20 EDT --- (In reply to comment #1) > Just a spelling error. But in my mind, "layouter" is a common spelling, too. > Could be kept as is. I think the dictionaries haven't caught up with the usage yet. It's a derivative noun formed by extending "layout" with "-er" suffix, meaning "one who or that which deals with layouts". (From the verb "to lay out", you would end up with "layer-out", definitely not "lay-outer"). > I'm not sure at all if "examples" in %doc should be followed by a / to let the > package own the whole folder including its contents. rpm -ql shows that the resulting rpm already owns both the directory and its contents. A trailing slash isn't necessary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
