[Bug 670088] Review Request: smlnj - Standard ML of New Jersey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670088 --- Comment #1 from Ricky Zhou 2011-05-30 03:20:16 EDT --- Spec URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj.spec SRPM URL: http://ricky.fedorapeople.org/pkgs/smlnj/smlnj-110.73-1.fc15.src.rpm Updated to latest upstream version (110.73). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701079
Fabian Affolter changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #1 from Fabian Affolter 2011-05-30
03:23:48 EDT ---
Just a quick comment: $RPM_BUILD_ROOT and %{buildroot} are mixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 658164] Review Request: python-asciitable - Extensible ASCII table reader and writer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658164 --- Comment #6 from Fabian Affolter 2011-05-30 03:29:09 EDT --- Please use %global instead of %define [1]. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708371] Review Request: perl-RPM-VersionCompare - Compare RPM version strings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708371 --- Comment #2 from Petr Pisar 2011-05-30 03:31:18 EDT --- New Package SCM Request === Package Name: perl-RPM-VersionCompare Short Description: Compare RPM version strings Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708371] Review Request: perl-RPM-VersionCompare - Compare RPM version strings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708371 Petr Pisar changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707613
--- Comment #10 from Mario Ceresa 2011-05-30 03:41:40 EDT
---
Great work Ankur!
+ koji can correctly build the package
http://koji.fedoraproject.org/koji/taskinfo?taskID=3099815
! rpmlint is *not* silent
[mario@shadow koji]$ rpmlint *.rpm
dcm4che-test.noarch: W: no-documentation
this is ok: we have a separate package for documentation
dcm4che-test.noarch: W: non-conffile-in-etc /etc/maven/fragments/dcm4che-test
dcm4che-test.src: W: invalid-url Source0: dcm4che2-test-2.6.tar.gz
this is ok, the package is taken from svn
dcm4che-test-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
docs, Java-docs, Avocados
Harmless
dcm4che-test-javadoc.noarch: E: script-without-shebang
/usr/share/javadoc/dcm4che-test/apidocs/javadoc.sh
just add the build root to the find line that you already put in the spec. This
made the trick for me:
find $RPM_BUILD_ROOT%{_javadocdir}/%{name} -name "javadoc.sh" -exec chmod a-x
'{}' \;
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
! md5sum
Still md5sums are different:
477961623e091b2d5f7119f2a69fc1ff dcm4che2-test-svn-2.6.tar.gz
381ce690ad2c5deff411f79eeea9c1d9 dcm4che2-test-2.6-srpm.tar.gz
Thi is strange, I obtain two different tarballs:
-rw-rw-r--. 1 mario mario 36713364 May 29 21:25 dcm4che2-test-2.6-srpm.tar.gz
-rw-rw-r--. 1 mario mario 36706444 May 30 08:51 dcm4che2-test-svn-2.6.tar.gz
however, after extracting, diff shows no differences:
diff -r dcm4che2-test-2.6-srpm/ dcm4che2-test-svn-2.6/
*puzzled*
So, the package is basically ok: if you don't mind, please repost the srpm with
the changed find line so that the last error in rpmlint disappears.
In the meantime I'll investigate why md5sum outputs differ. It is probably
nothing important or a mistake on my side because the tarballs look identical
with diff.
Best
Mario
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705361] Review Request: perl-Proc-SyncExec - Spawn processes but report exec() errors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705361 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Proc-SyncExec-1.01-1.f ||c16 Resolution||RAWHIDE Last Closed||2011-05-30 03:52:44 --- Comment #7 from Petr Pisar 2011-05-30 03:52:44 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708934] New: Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS https://bugzilla.redhat.com/show_bug.cgi?id=708934 Summary: Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vondr...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.redhat.com/vondruch/rubygem-pg.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-pg-0.11.0-1.fc16.src.rpm Description: This is the extension library to access a PostgreSQL database from Ruby. This library works with PostgreSQL 7.4 and later. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3099904 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708934] Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708934 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657405] Review Request: lbzip2 - fast, multi-threaded bzip2 utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657405 Lukáš Zapletal changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Lukáš Zapletal 2011-05-30 04:47:30 EDT --- Setting CVS flag for the EPEL request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664912 --- Comment #8 from Petr Pisar 2011-05-30 04:50:20 EDT --- (In reply to comment #7) > (In reply to comment #6) > > Yeap. It's possible not to specify version for > > perl(HTML::TreeBuilder::XPath). > > Does that mean the package is now approved since both FIX items have been > resolved? > No, the perl(HTML::TreeBuilder::XPath) is still missing from requires of binary package (compiled in F14). I will re-check it in F16. Maybe the rpmbuild requires generator has been fixed in the meantime. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664912 --- Comment #9 from Petr Pisar 2011-05-30 05:15:26 EDT --- (In reply to comment #8) > (In reply to comment #7) > > Does that mean the package is now approved since both FIX items have been > > resolved? > > > No, the perl(HTML::TreeBuilder::XPath) is still missing from requires of > binary > package (compiled in F14). I will re-check it in F16. Maybe the rpmbuild > requires generator has been fixed in the meantime. So the same problem presents in my local F16 and in Koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=3099960). The Requires: perl(HTML::TreeBuilder::XPath) must be added into the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707613 --- Comment #11 from Ankur Sinha 2011-05-30 05:18:12 EDT --- Hi Mario, I've corrected the find command. I have no clue why the md5sum is coming different. Could it be different versions of tar? [ankur@ankur SRPMS]$ rpm -q tar tar-1.25-6.fc15.x86_64 Fresh spec, srpm: http://ankursinha.fedorapeople.org/dcm4che-test/dcm4che-test.spec http://ankursinha.fedorapeople.org/dcm4che-test/dcm4che-test-2.6-0.1.fc15.20110530svn15516.src.rpm Thanks!! Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707613 Mario Ceresa changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Mario Ceresa 2011-05-30 05:26:13 EDT --- No, do not worry: Peter just explained me that md5sum is not so useful in case of tarballs generated by svn checkout. They are identical when I checked with diff, so this is ok. The package is APPROVED. Congratulations Ankur! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707993] Review Request: 9base - A port of various original Plan 9 tools for Unix
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707993
--- Comment #2 from Petr Sabata 2011-05-30 05:28:06 EDT ---
New release, using %{_bindir}/plan9 as %{_p9bin}
Spec URL: http://psabata.fedorapeople.org/pkgs/9base/9base.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/9base/9base-6-2.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707613 --- Comment #13 from Ankur Sinha 2011-05-30 05:35:07 EDT --- Thanks Mario, Peter!!! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 658164] Review Request: python-asciitable - Extensible ASCII table reader and writer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=658164 --- Comment #7 from Sergio Pascual 2011-05-30 05:31:57 EDT --- New package Spec URL: http://sergiopr.fedorapeople.org/python-asciitable.spec SRPM URL: http://sergiopr.fedorapeople.org/python-asciitable-0.6.0-1.fc15.src.rpm I have changed %define by %global -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707613 Ankur Sinha changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #14 from Ankur Sinha 2011-05-30 05:37:38 EDT --- New Package SCM Request === Package Name: dcm4che-test Short Description: Test images for dcm4che2 Owners: ankursinha Branches: f15 f14 InitialCC: susmit mrceresa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com AssignedTo|nob...@fedoraproject.org|socho...@redhat.com Flag||fedora-review? --- Comment #2 from Stanislav Ochotnicky 2011-05-30 05:51:00 EDT --- Gonna review this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky changed: What|Removed |Added Depends on||708645 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708645] Review Request: fusesource-pom - Parent POM for FuseSource Maven projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708645 Stanislav Ochotnicky changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com Blocks||708670 AssignedTo|nob...@fedoraproject.org|socho...@redhat.com Flag||fedora-review? --- Comment #1 from Stanislav Ochotnicky 2011-05-30 05:53:57 EDT --- hawtjni needs this so blocking that review on this one and looking into it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708970] New: Review Request: rubygem-Platform - Hopefully robust platform sensing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-Platform - Hopefully robust platform sensing https://bugzilla.redhat.com/show_bug.cgi?id=708970 Summary: Review Request: rubygem-Platform - Hopefully robust platform sensing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vondr...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.redhat.com/vondruch/rubygem-Platform.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-Platform-0.4.0-1.fc16.src.rpm Description: Hopefully robust platform sensing Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=310 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708645] Review Request: fusesource-pom - Parent POM for FuseSource Maven projects
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708645
Stanislav Ochotnicky changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Stanislav Ochotnicky 2011-05-30
06:09:43 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
fusesource-pom.noarch: W: no-documentation
fusesource-pom.noarch: W: non-conffile-in-etc
/etc/maven/fragments/fusesource-pom
fusesource-pom.src: W: no-%build-section
fusesource-pom.src: W: invalid-url Source0: fusesource-pom-1.5.tar.bz2
fusesource-pom.spec: W: no-%build-section
fusesource-pom.spec: W: invalid-url Source0: fusesource-pom-1.5.tar.bz2
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Not a problem
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: ASL 2.0
It's nice that they actually included license in pom file, doesn't happen
often.
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: 764d5573f4686c81c574e35016f4c738
MD5SUM upstream package: 764d5573f4686c81c574e35016f4c738
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[-] Javadoc documentation files are generated and included in -javadoc
subpackage
[-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[-] Javadoc subpackages have Require: jpackage-utils
[-] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[-] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[x] Package uses %update_maven_depmap in %post/%postun
[x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)
=== Other suggestions ===
[-] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-x86_64
=== Issues ===
1. You have more BRs than are really needed (just jpackage-utils are required
for %add_to_maven_depmap macro to work. I know that guidelines state minimal
BRs, but those were meant for "normal" packages. I guess we'll have to add
exception for pom-only projects :-)
But this is not a major problem s
[Bug 708990] New: Review Request: rubygem-open4 - open4 is library for management of child processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-open4 - open4 is library for management of child processes https://bugzilla.redhat.com/show_bug.cgi?id=708990 Summary: Review Request: rubygem-open4 - open4 is library for management of child processes Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vondr...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.redhat.com/vondruch/rubygem-open4.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-open4-1.0.1-1.fc16.src.rpm Description: Manage child processes and their IO handles easily Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3100053gvim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708970 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708645] Review Request: fusesource-pom - Parent POM for FuseSource Maven projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708645 Marek Goldmann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Marek Goldmann 2011-05-30 06:46:00 EDT --- Stanislav, Thank you! I'll remove unnecessary BR's at the import time. New Package SCM Request === Package Name: fusesource-pom Short Description: Parent POM for FuseSource Maven projects Owners: goldmann Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708934] Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708934
--- Comment #1 from Marcela Mašláňová 2011-05-30 07:09:29
EDT ---
- rpmlint ?
rpmlint rubygem-pg-0.11.0-1.fc16.i686.rpm
rubygem-pg.i686: W: no-soname
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/lib/pg_ext.so
rubygem-pg.i686: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/ext/compat.c
rubygem-pg.i686: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/ext/compat.h
rubygem-pg.i686: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/ext/extconf.h
rubygem-pg.i686: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/ext/pg.c
rubygem-pg.i686: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/ext/pg.h
rubygem-pg.i686: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/pg-0.11.0/lib/pg.rb 0644L /usr/bin/env
1 packages and 0 specfiles checked; 1 errors, 6 warnings.
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license ?
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires ?
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
postgresql-server postgresql-devel should be >= as stated in README file.
Imho in license should be postgresql instead of BSD.
Why is 'gem install' in prep? I believe install is doing install, so it should
be in install part of spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #46 from Alec Leamas 2011-05-30 07:20:56 EDT --- Ping... Is the exception process under way? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708970 Vít Ondruch changed: What|Removed |Added Blocks||705515 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706934] Review Request: rubygem-rspec-rails - RSpec-2 for Rails-3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706934 Vít Ondruch changed: What|Removed |Added Blocks||705546 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708990] Review Request: rubygem-open4 - open4 is library for management of child processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708990 Vít Ondruch changed: What|Removed |Added Blocks||705527 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708670
--- Comment #3 from Stanislav Ochotnicky 2011-05-30
07:28:03 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
hawtjni.noarch: W: summary-ended-with-dot C Code generator that produces the
JNI code needed to implement java native methods.
hawtjni.noarch: E: summary-too-long C Code generator that produces the JNI code
needed to implement java native methods.
hawtjni.noarch: W: spelling-error %description -l en_US jnigen -> Nigerien
hawtjni.noarch: W: non-conffile-in-etc /etc/maven/fragments/hawtjni
hawtjni.src: W: summary-ended-with-dot C Code generator that produces the JNI
code needed to implement java native methods.
hawtjni.src: E: summary-too-long C Code generator that produces the JNI code
needed to implement java native methods.
hawtjni.src: W: spelling-error %description -l en_US jnigen -> Nigerien
hawtjni.src: W: invalid-url Source0: hawtjni-1.1.tar.gz
hawtjni-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs,
Java-docs, Avocados
3 packages and 0 specfiles checked; 2 errors, 7 warnings.
Fixing the summary is needed :-)
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[!] License field in the package spec file matches the actual license.
License type: ASL 2.0 and EPL
There is actually BSD file inside (stdint.h). Correct license for the package
is most probably "ASL 2.0 and EPL 1.0 and BSD". It would be good to let
upstream know that their licensing situation is not clear from their licensing
file. It's usually good idea to put such information into readme or separate
file listing all files with different licensing from the main one.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
javadoc subpackage needs included license file
[x] Spec file is legible and written in American English.
[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: d3c43b608bfe48b313e34b747983d1ae
MD5SUM upstream package: b437a1b8d84c5755bfd2b12b7dacde90
Your instructions to create tarball are not exactly incorrect, but they change
the md5sum each time archive is created. I'd suggest using lzma (xz)
compression instead of gzip. It doesn't add timestamps into tarball so it won't
change md5sum and it compresses better. If you need to support EPEL 5 with
this, then you can use bzip2 to prevent md5sum changes.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_
[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708970
Marcela Mašláňová changed:
What|Removed |Added
Blocks|705515 |
--- Comment #1 from Marcela Mašláňová 2011-05-30 07:33:22
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license ?
I found LGPL without version.
- text of the license in its own file must be included in %doc ?
You should add LGPL statement into doc.
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
resolvedeps-f16 ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm
rpm -qp --provides ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm
rubygem(Platform) = 0.4.0
rubygem-Platform = 0.4.0-1.fc16
rpm -qp --requires ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
ruby
ruby(abi) = 1.8
rubygems
rpmlib(PayloadIsXz) <= 5.2-1
So, only problem is the license.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708970 Marcela Mašláňová changed: What|Removed |Added Blocks||705515 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708990] Review Request: rubygem-open4 - open4 is library for management of child processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708990 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705760] Review request: retrace-server - Application for remote coredump analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705760 Ondrej Vasik changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ova...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691403] Review Request: perl-IO-Stty - Change and print terminal line settings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691403 Marcela Mašláňová changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #5 from Marcela Mašláňová 2011-05-30 08:11:54 EDT --- Package Change Request == Package Name: perl-IO-Stty New Branches: el5 el6 Owners: mmaslano InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708990] Review Request: rubygem-open4 - open4 is library for management of child processes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708990
--- Comment #1 from Marcela Mašláňová 2011-05-30 08:33:48
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license ?
- license field must match actual license ?
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires ?
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
Requires: rubygems >= 0
Why must be requires bigger than 0?
Where is Ruby license stated? I didn't find it in package.
You should have text of license in package.
'gem install' should be in install part of spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705760] Review request: retrace-server - Application for remote coredump analysis
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705760
Ondrej Vasik changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Ondrej Vasik 2011-05-30 08:33:47 EDT ---
Checked srpm:
$ sha256sum retrace-server-1.0-1.fc15.src.rpm
a9e53fe5651227206cd101c77dff268ee94102d3ac767d9612954df58dbe4c82
retrace-server-1.0-1.fc15.src.rpm
YES source files match upstream:
$ sha256sum retrace-server-1.0.tar.gz retrace-server-1.0.tar.gz.1
eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea
retrace-server-1.0.tar.gz
eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea
retrace-server-1.0.tar.gz.1
YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros
consistently.
YES dist tag is present.
INFO clean section and buildroot not present - but that's ok now
YES license field matches the actual license.
YES license is open source-compatible
YES License text included in package.
YES latest version is being packaged.
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.
NO rpmlint is silent.
Output already posted in description, confirmed. Manual pages would be nice to
have, but at the moment in the "release early, release often" stage ... I hope
this will improve in future. At lease info documentation is present.
YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES scriptlets must be sane.
YES code, not content.
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.
Few comments:
%{?el6:Requires: python-argparse} ... is this really only for el6? If so, it
probably could be dropped in Fedora, otherwise it should probably be extended
to rhel conditional.
You have requested retrace account in
https://bugzilla.redhat.com/show_bug.cgi?id=706012 ... it is no longer
required?
None of these comments is blocking the approval -> APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705760] Review request: retrace-server - Application for remote coredump analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705760 --- Comment #2 from Michal Toman 2011-05-30 08:47:36 EDT --- There is no python-argparse package in Fedora - it's a part of Python 2.7 The retrace account is used in upstream and will be a part of next release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705760] Review request: retrace-server - Application for remote coredump analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705760 --- Comment #3 from Ondrej Vasik 2011-05-30 08:53:07 EDT --- Ok, thanks for info... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #47 from Panos Christeas 2011-05-30 08:56:47 EDT --- Pong: I was waiting for your help on that: can't find some way through to the board. I'm not a member of the lists or bugzilla (closed registration?) or know a valid mail to post to. :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708990] Review Request: rubygem-open4 - open4 is library for management of child processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708990 --- Comment #2 from Marcela Mašláňová 2011-05-30 09:10:02 EDT --- 'gem install' could be in prep because otherwise after fedpkg prep will be there only packed gem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708934] Review Request: rubygem-pg - A Ruby interface to the PostgreSQL RDBMS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708934 --- Comment #2 from Marcela Mašláňová 2011-05-30 09:10:07 EDT --- 'gem install' could be in prep because otherwise after fedpkg prep will be there only packed gem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #4 from Marek Goldmann 2011-05-30 09:16:45 EDT --- Thanks for taking this review! Updated files with your comments applied: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3/hawtjni-1.1-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706984] Review Request: args4j - Small Java lib that makes it easy to parse command line options/args in CUI apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706984 --- Comment #9 from Jaromír Cápík 2011-05-30 09:22:31 EDT --- Hi Marek. I somehow haven't noticed You've done the review :] >>Which part of the lib is licensed under BSD? Homepage states only MIT. LICENSE.txt contained in the source tarball is BSD and the project homepage states MIT. I'll try to reach upstream again, but as I got no answer for my first question, I don't suppose I'll be more successful in case of license clarification -> don't know if we should wait for the clarification. >>It seems the instructions to get the source code from SVN are not working for me. Could you please check it? You have to register on java.net and upload Your personal ssh key to the server in order to be able to export the sources. It seems that it would be better to make a note in the spec file stating this fact. >>I don't know :) The download section on homepage gives 404. Any hints? Yes. They don't care about the link anymore. The only way how to obtain the source is via the svn export. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708842] Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708842 Marek Goldmann changed: What|Removed |Added Blocks||709051 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709051] Review Request: gossip - SLF4j Gossip Provider
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709051 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||708842 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709051] New: Review Request: gossip - SLF4j Gossip Provider
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gossip - SLF4j Gossip Provider https://bugzilla.redhat.com/show_bug.cgi?id=709051 Summary: Review Request: gossip - SLF4j Gossip Provider Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mgold...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://goldmann.fedorapeople.org/package_review/gossip/1/gossip.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/gossip/1/gossip-1.7-1.fc15.src.rpm Description: Gossip is a plugin for SLF4j which has simple and flexible configuration. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701347
--- Comment #5 from Thomas Sailer 2011-05-30 09:38:28
EDT ---
Fedora review mingw-gtkmm30-3.0.1-2.fc15.src.rpm 2011-05-30
+ OK
! needs attention
Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3100290
rpmlint:
$ rpmlint mingw-gtkmm30.spec mingw-gtkmm30-3.0.1-2.fc15.src.rpm
mingw32-gtkmm30-debuginfo-3.0.1-2.fc16.noarch.rpm
mingw32-gtkmm30-3.0.1-2.fc16.noarch.rpm
mingw-gtkmm30.src: W: spelling-error %description -l en_US gtkmm
mingw32-gtkmm30-debuginfo.noarch: E: debuginfo-without-sources
mingw32-gtkmm30.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw32-gtkmm30-3.0.1/COPYING
3 packages and 1 specfiles checked; 2 errors, 1 warnings.
! the fsf address issue should be addressed. Did you or do you know whether the
native package maintainer has contacted upstream?
! rpmlint output
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
169ed5b088538fa10483177f3035f77c gtkmm-3.0.1.tar.bz2
169ed5b088538fa10483177f3035f77c Download/gtkmm-3.0.1.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706984] Review Request: args4j - Small Java lib that makes it easy to parse command line options/args in CUI apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706984 --- Comment #10 from Jaromír Cápík 2011-05-30 09:38:30 EDT --- bundled lib dir removed + note about the ssh key added: Spec URL: http://jcapik.fedorapeople.org/files/args4j/3/args4j.spec SRPM URL: http://jcapik.fedorapeople.org/files/args4j/3/args4j-2.0.16-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708670
Stanislav Ochotnicky changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Stanislav Ochotnicky 2011-05-30
09:56:23 EDT ---
tarball is now OK (md5sum dc1a98b5cf60e90fb79a33fc003c2af9)
javadoc subpackage should have license file included as well.
maven plugin subpackage should have separate Group tag (even if it's the same
as in this case).
You now also have this in file section:
%{_mavendepmapfragdir}/
i.e. you own whole subdir, whereas you should only own file inside it i.e.
%{_mavendepmapfragdir}/%{name} (or *)
Otherwise the package looks OK now, so just fix those 3 small issues and you're
good to go. In good faith: APPROVED :-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708645] Review Request: fusesource-pom - Parent POM for FuseSource Maven projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708645 Stanislav Ochotnicky changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann changed: What|Removed |Added Summary|Review Request: hawtjni - |Review Request: hawtjni - |Code generator that |Code generator that |produces the JNI code |produces the JNI code |needed to implement java| |native methods | Flag||fedora-cvs? --- Comment #6 from Marek Goldmann 2011-05-30 10:10:55 EDT --- Thank you! I've applied your comments to this package: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3a/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/3a/hawtjni-1.1-3.fc15.src.rpm New Package SCM Request === Package Name: hawtjni Short Description: Code generator that produces the JNI code Owners: goldmann Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky changed: What|Removed |Added Flag|fedora-review+, fedora-cvs? |fedora-review? --- Comment #7 from Stanislav Ochotnicky 2011-05-30 10:26:34 EDT --- Bah, I somehow missed maven-shade-plugin being used to bundle all dependencies inside generator jar. You'll have to remove shade plugin use before proceeding. Removing cvs? and review+ in the meantime. Sorry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #8 from Marek Goldmann 2011-05-30 11:10:02 EDT --- Removed the maven-shade-plugin dependency. Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/4/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/4/hawtjni-1.1-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708664] Review Request: jp2a - an utility for converting JPEG images to ASCII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708664 yanchuan changed: What|Removed |Added CC||yanch...@nfs-china.com --- Comment #1 from yanchuan 2011-05-30 11:13:25 EDT --- Hi Andres, There are some problems with your package. (1)There is only one percent sign in your comment, but macros are expanded first, so you need to double it.See here: https://fedoraproject.org/wiki/How_to_create_an_RPM_package (2)The license must be specific instead of just "GPL". (3)The summary doesn't begin with a capital letter. Maybe you need run rpmlint first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Stanislav Ochotnicky changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Stanislav Ochotnicky 2011-05-30 11:20:52 EDT --- Yup, all OK now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Marek Goldmann 2011-05-30 11:21:49 EDT --- Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706984] Review Request: args4j - Small Java lib that makes it easy to parse command line options/args in CUI apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706984 Marek Goldmann changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Marek Goldmann 2011-05-30 11:38:27 EDT --- [x] License field in the package spec file matches the actual license. OK, thanks for clarification, specify both licenses then. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package: b765c9c25789884cb982e7c8fefc0de0 MD5SUM upstream package: b29f50e3dd5933fb7fe498a38f9fb191 It seems they way you create the package changes the timestamps. Use xz compression method - change the instructions (and update the file in srpm) to: # tar cafJ args4j-2.0.16.tar.xz args4j-2.0.16 [x] If source tarball includes bundled jar/class files these need to be removed prior to building Thanks! [x] Latest version is packaged. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706984] Review Request: args4j - Small Java lib that makes it easy to parse command line options/args in CUI apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706984 Marek Goldmann changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #8 from David Hannequin 2011-05-30 11:55:10 EDT --- Hi, For now, there is no unit test in the rpm Shinken because the author did not create a test section in the file setup.py. After some discussion with him we'll add a test section in the file setup.py in the future version. In addition there are tests that are already visible on this and realize url http://shinken-monitoring.de:8080/ and I also test the RPM version also works on Fedora 15. Best regard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 Mario Sanchez Prada changed: What|Removed |Added CC||msanc...@igalia.com --- Comment #1 from Mario Sanchez Prada 2011-05-30 13:51:43 EDT --- As the main developer of frogr so far, please let me say thanks for you reporting this bug and pushing for getting frogr integrated in Fedora. Thanks! Now, just a couple of comments that I hope you'll find useful: (In reply to comment #0) > Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/frogr.spec > SRPM URL: > http://mariobl.fedorapeople.org/Review/SRPMS/frogr-0.5-1.fc15.src.rpm > Description: > Frogr intends to be a complete GNOME application to remotely manage a flickr > account from the desktop. It uses flickcurl, from Dave Beckett to > communicate with the server through the publicly available flickr REST API. This description is not correct. Since frogr 0.3 flickcurl is not being used anymore, as we used our own libsoup-based library called flicksoup, which is not being released separately yet (its development happens inside the frogr tree at the moment). Nowadays, the "official" description that's used everywhere is something like this: "Frogr is a small application for the GNOME desktop that allows users to manage their accounts in the Flickr image hosting website. It supports all the basic tasks, including uploading pictures, adding descriptions, setting tags and managing sets." > The program doesn't provide all the expected features yet, seems it needs > additional libraries which are not requested during the build process. Stay > tuned, I try to find them out. I think you'll find useful the list I use to generate "homegrown" fedora packages while frogr is not shipped right from the distro: BuildRequires: gtk3-devel > 3.0, libsoup-devel > 2.24, libxml2-devel > 2.6.8, libexif-devel > 0.6.14 Requires: gtk3 > 3.0, libsoup > 2.24, libxml2 > 2.6.8, libexif > 0.6.14, gvfs, desktop-file-utils Also, you can take a look to the .spec file I used to build those "homegrown" packages for frogr 0.5: http://git.gnome.org/browse/frogr/tree/frogr.spec?id=003b3101cedb6e129eff60af4e4b6976afb3ab4c Hope this helps! Thanks, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #48 from Alec Leamas 2011-05-30 13:51:08 EDT --- A cute deadlock, indeed. Nice job you have done w upstream! Seems that FPC nowadays are using a ticket system at https://fedorahosted.org/fpc/. Besides that, there is http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702846] Review Request: mingw32-gdb - MinGW Windows port of the GDB debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702846 --- Comment #4 from Thomas Sailer 2011-05-30 13:58:00 EDT --- Correction: + Upstream sources match sources in the srpm. md5sum: 64260e6c56979ee750a01055f16091a5 gdb-7.2.tar.bz2 64260e6c56979ee750a01055f16091a5 Download/gdb-7.2.tar.bz2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702846] Review Request: mingw32-gdb - MinGW Windows port of the GDB debugger
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702846
Thomas Sailer changed:
What|Removed |Added
CC||t.sai...@alumni.ethz.ch
AssignedTo|nob...@fedoraproject.org|t.sai...@alumni.ethz.ch
--- Comment #3 from Thomas Sailer 2011-05-30 13:56:41
EDT ---
Fedora review mingw32-gdb-7.2-1.fc15.src.rpm 2011-05-30
+ OK
! needs attention
Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3100605
rpmlint:
$ rpmlint mingw32-gdb.spec mingw32-gdb-7.2-1.fc15.src.rpm
mingw32-gdb-7.2-1.fc16.noarch.rpm mingw32-gdb-debuginfo-7.2-1.fc16.noarch.rpm
mingw32-gdb.noarch: W: obsolete-not-provided mingw32-gdb-gdbserver
mingw32-gdb-debuginfo.noarch: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 1 warnings.
These errors and warnings can be ignored.
+ rpmlint output
+ The package is named according to Fedora MinGW packaging guidelines
! please modify it to anticipate the "MinGW_future" packaging guidelines
(i.e. rename it to mingw-gdb)
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING3 COPYING COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
169ed5b088538fa10483177f3035f77c gtkmm-3.0.1.tar.bz2
169ed5b088538fa10483177f3035f77c Download/gtkmm-3.0.1.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
! while the built gdb.exe does work on native Windows, wine gdb.exe just hangs.
I would expect to be able to enter help etc. Since the MinGW project goal is
to minimize windows use, I think gdb.exe working with wine should be a goal
if we are to include the mingw32-gdb package in fedora
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709125] Review Request: obdgpslogger - OBDII and GPS data logger for your car
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709125 Gary Briggs changed: What|Removed |Added URL||http://icculus.org/obdgpslo ||gger/ Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Gary Briggs 2011-05-30 14:02:03 EDT --- Adding FE-NEEDSPONSOR to blocking bugs, this will hopefully be my first package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709125] New: Review Request: obdgpslogger - OBDII and GPS data logger for your car
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: obdgpslogger - OBDII and GPS data logger for your car https://bugzilla.redhat.com/show_bug.cgi?id=709125 Summary: Review Request: obdgpslogger - OBDII and GPS data logger for your car Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: chu...@icculus.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://icculus.org/obdgpslogger/downloads/fedorapackaging/obdgpslogger.spec SRPM URL: http://icculus.org/obdgpslogger/downloads/fedorapackaging/obdgpslogger-0.16-1.fc15.src.rpm Description: obdgpslogger has been my pet project for a few years, now. It's a tool to log OBDII and GPS data from your car, and convert it into useful formats such as GPX or KML. It's entirely scratching an itch; there's almost no software out there for working with OBDII as well as GPS, even less that's open source, and absolutely none that's made it into any distributions yet. It also contains a simulator I've written, that's used more extensively than the logger itself; most of the OBDII software developers I know of, even the closed source ones, are now using my sim. I've been building this on a Fedora 15 x86_64 VM. At time of writing, rpmlint(1) has no errors, and one warning: A spelling error, "obdsim", which I feel is excusable since it's the name of the sim. I see no errors or warnings from mock(1). If you wish to test the software itself or see that it executes without problems, use obdsim with the "-o" flag. That will launch the sim [which creates a PTY on Linux], and connect obdgpslogger to the slave end of the PTY with verbose output turned on; if you see spam to stdout, that means that both the sim and the logger are functioning correctly. The warning, "close(9) on netlib_connectsock()", is created by the gpsd library, not my software. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 --- Comment #2 from Mario Blättermann 2011-05-30 14:09:16 EDT --- (In reply to comment #1) > As the main developer of frogr so far, please let me say thanks for you > reporting this bug and pushing for getting frogr integrated in Fedora. Thanks! > > Now, just a couple of comments that I hope you'll find useful: > > (In reply to comment #0) > > Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/frogr.spec > > SRPM URL: > > http://mariobl.fedorapeople.org/Review/SRPMS/frogr-0.5-1.fc15.src.rpm > > Description: > > Frogr intends to be a complete GNOME application to remotely manage a flickr > > account from the desktop. It uses flickcurl, from Dave Beckett to > > communicate with the server through the publicly available flickr REST API. > > This description is not correct. Since frogr 0.3 flickcurl is not being used > anymore, as we used our own libsoup-based library called flicksoup, which is > not being released separately yet (its development happens inside the frogr > tree at the moment). Nowadays, the "official" description that's used > everywhere is something like this: > > "Frogr is a small application for the GNOME desktop that allows users > to manage their accounts in the Flickr image hosting website. It > supports all the basic tasks, including uploading pictures, adding > descriptions, setting tags and managing sets." The description from my spec file is picked up from Frogr's website: http://live.gnome.org/Frogr Or, actually, what I recognize as Frogr's website. Could be there is another website which isn't known to me. If I'm right, someone should update this. Regarding your hints, I will have a look at the dependencies tomorrow. Many thanks for your help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 --- Comment #3 from Mario Sanchez Prada 2011-05-30 14:21:25 EDT --- (In reply to comment #2) > [...] > > "Frogr is a small application for the GNOME desktop that allows users > > to manage their accounts in the Flickr image hosting website. It > > supports all the basic tasks, including uploading pictures, adding > > descriptions, setting tags and managing sets." > > The description from my spec file is picked up from Frogr's website: > > http://live.gnome.org/Frogr > > Or, actually, what I recognize as Frogr's website. Could be there is another > website which isn't known to me. If I'm right, someone should update this. Hmm.. I think you're doing something wrong, since what is stated in http://live.gnome.org/Frogr, in the "Overview" section, is the following: """ Frogr is a small application for the GNOME desktop that allows users to manage their accounts in the Flickr image hosting website. It supports all the basic Flickr features, including uploading pictures, adding descriptions, setting tags and managing sets and groups pools. This application is written in C and uses flicksoup, a libsoup-based library to communicate with the server through the publicly available flickr REST API. This project is Free Software and published under the terms of the GNU Public License v3." """ As you can see, the first paragraph is basically what I pasted you before, with the simple addition of "... and group pools" (which would be a nice addition to Fedora's description, if you ask me). There's an old and deprecated site at Google Code (http://code.google.com/p/frogr) but no mention to flickcurl is being made there nowadays either... you must be getting that description from somewhere else. If you find it and it's my fault please let me know and I'll change it. > Regarding your hints, I will have a look at the dependencies tomorrow. Many > thanks for your help! Glad to see you found it useful. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 --- Comment #4 from Mario Blättermann 2011-05-30 14:49:08 EDT --- (In reply to comment #3) > Hmm.. I think you're doing something wrong, since what is stated in > http://live.gnome.org/Frogr, in the "Overview" section, is the following: > > """ > Frogr is a small application for the GNOME desktop that allows users to manage > their accounts in the Flickr image hosting website. It supports all the basic > Flickr features, including uploading pictures, adding descriptions, setting > tags and managing sets and groups pools. > > This application is written in C and uses flicksoup, a libsoup-based library > to > communicate with the server through the publicly available flickr REST API. > > This project is Free Software and published under the terms of the GNU Public > License v3." > """ > > As you can see, the first paragraph is basically what I pasted you before, > with > the simple addition of "... and group pools" (which would be a nice addition > to > Fedora's description, if you ask me). > Yes, you are right. Now I know it again: I had googled for "frogr fedora" and got the spec file. Don't know the source, but I've downloaded it and began to edit it to match the new upstream version. In any case, thanks for your hints. I was surprised about the spec file in Git, which shows that you was working continuously on the Fedora package. And never thought about to publish it...? OK, no problem, once we have a reviewer and all the mistakes related to the package are fixed, Frogr will become part of the official Fedora package pool. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 --- Comment #5 from Mario Sanchez Prada 2011-05-30 15:40:38 EDT --- (In reply to comment #4) > [...] > > As you can see, the first paragraph is basically what I pasted you before, > > with > > the simple addition of "... and group pools" (which would be a nice > > addition to > > Fedora's description, if you ask me). > > > Yes, you are right. Now I know it again: I had googled for "frogr fedora" and > got the spec file. Don't know the source, but I've downloaded it and began to > edit it to match the new upstream version. In any case, thanks for your hints. Ah, ok. So you started from an old version of the .spec file I was using. That explains everything :-) > I was surprised about the spec file in Git, which shows that you was working > continuously on the Fedora package. And never thought about to publish it...? :-) Yes, I was using the .spec file a lot, at first just to generate .rpm files when I made a release, but very often lately since I switched from Ubuntu to Fedora, to generate pacakges that I could easily install in my system to dog food frogr. However, I never thought about publishing it myself because I had no clue about the .spec file being correct or not. For me it was a "just works" file that easily generated .rpm files when I needed it, without needed to worry too much about being a proper spec file, which would probably need to follow some guidelines/rules/whatever that I, as an unexperienced Fedora user, had no idea about. Actually the initial version of that .spec file was not written by me and I just cared about updating it whenever needed to keep generating rpms when I needed it. Anyway, I agree with you that it's weird to have that .spec file in there and not having pushed for integrating frogr in Fedora before, but as I said in a comment to my last post about frogr, the simple reason for that is that I lacked the self-confidence and the knowledge on the processes in the Fedora community for doing that, so I just went for the "dear lazyweb" approach of asking the world to help me with packaging issues :-) > OK, no problem, once we have a reviewer and all the mistakes related to the > package are fixed, Frogr will become part of the official Fedora package pool. Great! And glad again to see that frogr is reaching fedora in one way or another :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675587] Review Request: pytest - Simple powerful testing with Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675587 --- Comment #7 from Thomas Moschny 2011-05-30 16:00:52 EDT --- Spec URL: http://thm.fedorapeople.org/pytest/pytest.spec SRPM URL: http://thm.fedorapeople.org/pytest/pytest-2.0.3-1.fc15.src.rpm %changelog * Mon May 30 2011 Thomas Moschny <..> - 2.0.3-1 - Update to 2.0.3. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486687] Review Request: chisholm-rubbing-fonts - Decorative Sans Serif Font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486687 Paul Flo Williams changed: What|Removed |Added CC||p...@frixxon.co.uk Flag||needinfo?(jeremy.hankinson@ ||ingres.com) --- Comment #20 from Paul Flo Williams 2011-05-30 16:36:53 EDT --- Jay, are you still around? This package was approved over two years ago, and still hasn't been built for Fedora. Please take a look at this page: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers Your sponsor can help if you are unsure how to import your srpm into Fedora git. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 --- Comment #20 from nucleo 2011-05-30 16:45:12 EDT --- In kamoso-2.0.2 fixed sources license and added translations. Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/kamoso/2.0.2/kamoso.spec SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/kamoso/2.0.2/kamoso-2.0.2-1.fc15.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3101034 $ rpmlint kamoso-2.0.2-1.fc15.src.rpm kamoso-2.0.2-1.fc15.i686.rpm kamoso-2.0.2-1.fc15.x86_64.rpm kamoso-debuginfo-2.0.2-1.fc15.i686.rpm kamoso-debuginfo-2.0.2-1.fc15.x86_64.rpm kamoso.src: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.src: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.i686: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.i686: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.i686: W: no-manual-page-for-binary kamoso kamoso.i686: W: no-manual-page-for-binary kamosoPluginTester kamoso.x86_64: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.x86_64: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.x86_64: W: no-manual-page-for-binary kamoso kamoso.x86_64: W: no-manual-page-for-binary kamosoPluginTester 5 packages and 0 specfiles checked; 0 errors, 10 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 Need Real Name changed: What|Removed |Added CC||redhat_bugzilla@deadlychees ||e.endjunk.com --- Comment #35 from Need Real Name 2011-05-30 17:00:31 EDT --- patch for 0.9.7 spec file specifies '.xz' tarball ... should that instead be '.gz'? Also, website only provides 0.9.6 tarball at the time of this comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708554] Review Request: umph - Command line tool for parsing video links from Youtube feeds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708554 Thomas Spura changed: What|Removed |Added Blocks||708711 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708711
Thomas Spura changed:
What|Removed |Added
CC||toms...@fedoraproject.org
Depends on||708554
--- Comment #3 from Thomas Spura 2011-05-30
17:15:46 EDT ---
The compression of the man pages could change, so %{_mandir}/man1/%{name}.1.*
would be better.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709160] New: Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist https://bugzilla.redhat.com/show_bug.cgi?id=709160 Summary: Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@krakoa.dk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://krakoa.dk/fedora/activity-log-manager.spec SRPM URL: http://krakoa.dk/fedora/activity-log-manager-0.8.0-1.fc15.src.rpm Description: Activity Log Manager is a graphical user interface which lets you easily control what gets logged by Zeitgeist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700814] Review Request: din - A musical instrument using multiple Bezier curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700814 Andrew Nixon changed: What|Removed |Added CC||andrewnix...@gmail.com --- Comment #6 from Andrew Nixon 2011-05-30 17:36:09 EDT --- (In reply to comment #5) > Another new upstream release: > > http://verdurin.fedorapeople.org/reviews/din/din.spec > > http://verdurin.fedorapeople.org/reviews/din/din-1.6.1-1.fc14.src.rpm This now Segfaults on fc15, either from compiling the source files (for 1.6.2) directly or attempting to build your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502477 --- Comment #36 from Need Real Name 2011-05-30 18:11:18 EDT --- Created attachment 501888 --> https://bugzilla.redhat.com/attachment.cgi?id=501888 ugly hacks to get 0.9.6 building with Fedora 15 sorry, no time to do it right, inline sed hacks to fix setup.py on Fedora 15. After installing, app didn't work the first run, worked on 2nd run. Shell integration is broken; not sure what a proper fix would be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #49 from Panos Christeas 2011-05-30 18:18:50 EDT --- A little more help, please? (see personal email) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693363] Review Request: st - A simple terminal implementation for X
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693363 --- Comment #16 from Fedora Update System 2011-05-30 18:27:37 EDT --- st-0.1.1-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706421 --- Comment #10 from Fedora Update System 2011-05-30 18:28:57 EDT --- wmname-0.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701112] Review Request: mingw-wxWidgets - C++ cross-platform GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701112 --- Comment #14 from Fedora Update System 2011-05-30 18:27:24 EDT --- mingw-wxWidgets-2.8.12-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706421 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||wmname-0.1-1.fc15 Resolution||ERRATA Last Closed||2011-05-30 18:29:03 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693363] Review Request: st - A simple terminal implementation for X
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693363 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||st-0.1.1-2.fc15 Resolution||ERRATA Last Closed||2011-05-30 18:27:43 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701112] Review Request: mingw-wxWidgets - C++ cross-platform GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701112 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-wxWidgets-2.8.12-3.fc ||15 Resolution||ERRATA Last Closed||2011-05-30 18:27:29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679060] Review Request: mingw-antlr - MinGW Windows ANTLR C++ run-time library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679060 --- Comment #14 from Fedora Update System 2011-05-30 18:34:33 EDT --- mingw-antlr-2.7.7-5.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225672] Merge Review: cvs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225672 --- Comment #18 from Fedora Update System 2011-05-30 18:33:58 EDT --- cvs-1.11.23-15.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679060] Review Request: mingw-antlr - MinGW Windows ANTLR C++ run-time library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679060 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-antlr-2.7.7-5.fc15 Resolution||ERRATA Last Closed||2011-05-30 18:34:38 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663925 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||autoconf-archive-2011.04.12 ||-1.fc15 Resolution||ERRATA Last Closed||2011-05-30 18:32:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663925 --- Comment #18 from Fedora Update System 2011-05-30 18:32:36 EDT --- autoconf-archive-2011.04.12-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678910 --- Comment #8 from Fedora Update System 2011-05-30 18:32:22 EDT --- kde-plasma-activitymanager-0.5-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678910 Fedora Update System changed: What|Removed |Added Fixed In Version||kde-plasma-activitymanager- ||0.5-2.fc15 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225672] Merge Review: cvs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225672 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||cvs-1.11.23-15.fc15 Resolution||ERRATA Last Closed|2011-01-18 10:15:01 |2011-05-30 18:34:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709180] New: Review Request: jackctlmmc - control JACK transport via MIDI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jackctlmmc - control JACK transport via MIDI https://bugzilla.redhat.com/show_bug.cgi?id=709180 Summary: Review Request: jackctlmmc - control JACK transport via MIDI Product: Fedora Version: 15 Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: brendan.jones...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- QJackMMC is a Qt based program that can connect to a device or program that emits MIDI Machine Control (MMC) and allow it to drive JACK transport, which in turn can control other programs. JackCtlMMC is a slightly simpler command-line version of QJackMMC. This is a program I use daily - further details can be found here: http://jackctlmmc.sourceforge.net/ SPEC: http://bsjones.fedorapeople.org/jackctlmmc.spec SRPM: http://bsjones.fedorapeople.org/jackctlmmc-4-1.fc15.src.rpm Rpmlint: fedora15:~$ rpmlint /home/bsjones/rpmbuild/SRPMS/jackctlmmc-4-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. fedora15:~$ rpmlint /home/bsjones/rpmbuild/SPECS/jackctlmmc.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700350 --- Comment #2 from Nicholas van Oudtshoorn 2011-05-30 21:39:47 EDT --- Hi Iain, Thanks for that. I've already notified upstream about the FSF address - and have now removed the patch from the package. All your other suggested changes have also been applied. New URLs follow Spec URL: http://dl.dropbox.com/u/8648526/perl-CGI-Session-Driver-memcached.spec SRPM URL: http://dl.dropbox.com/u/8648526/perl-CGI-Session-Driver-memcached-0.04-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700349] Review Request: perl-Biblio-EndnoteStyle - Reference formatting using Endnote-like templates
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700349 --- Comment #6 from Nicholas van Oudtshoorn 2011-05-30 21:52:51 EDT --- The linked spec file should fix all of those problems (I hope!) SPEC: http://dl.dropbox.com/u/8648526/perl-Biblio-EndnoteStyle.spec SRPM: http://dl.dropbox.com/u/8648526/perl-Biblio-EndnoteStyle-0.05-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
