[Bug 715610] Review Request: perl-HTTP-Exception - Throw HTTP-Errors as (Exception::Class-) Exceptions

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715610

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-06-28 
02:07:38 EDT ---
perl-HTTP-Exception-0.03001-1.fc15 has been submitted as an update for Fedora
15.
https://admin.fedoraproject.org/updates/perl-HTTP-Exception-0.03001-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715610] Review Request: perl-HTTP-Exception - Throw HTTP-Errors as (Exception::Class-) Exceptions

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715610

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716844] Review Request: django-recaptcha - A Django application for adding ReCAPTCHA to a form

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716844

--- Comment #4 from Jitesh Shah jitesh.1...@gmail.com 2011-06-28 02:42:51 EDT 
---
Relevant revision control information included:

The new SPEC file is here:
https://sites.google.com/a/jiteshs.com/www/public/django-recaptcha.spec?attredirects=0d=1

New SRPM:
https://sites.google.com/a/jiteshs.com/www/public/django-recaptcha-0.1-1.20091212svn6.fc15.src.rpm?attredirects=0d=1

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3165314

rpmlint is clean (did the rephrase too).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716844] Review Request: django-recaptcha - A Django application for adding ReCAPTCHA to a form

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716844

--- Comment #5 from Jitesh Shah jitesh.1...@gmail.com 2011-06-28 02:48:33 EDT 
---
Is the package group needed? Its not an application that can be launched.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708402] Review Request: tophat - A spliced read mapper for RNA-Seq

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708402

--- Comment #4 from Adam Huffman bl...@verdurin.com 2011-06-28 03:00:00 EDT 
---
New bugfix release:

http://verdurin.fedorapeople.org/reviews/tophat/tophat.spec

http://verdurin.fedorapeople.org/reviews/tophat/tophat-1.3.1-1.fc14.src.rpm

I'll post my SeqAn request shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

Adam Huffman bl...@verdurin.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Adam Huffman bl...@verdurin.com 2011-06-28 03:03:49 EDT 
---
New Package SCM Request
===
Package Name: bowtie
Short Description: An ultrafast, memory-efficient short read aligner
Owners: verdurin
Branches: f14 f15 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #4 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
03:30:21 EDT ---
(In reply to comment #3)
 [X] rpmlint RPMS/noarch/grapefruit-0.1a3-2.20110627svn31.fc14.noarch.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 
   - ok.
 
   [?] md5sum/sha1sum of the sources in the SRPM and the one accessible
   from URL - https://code.google.com/p/grapefruit/downloads/list - do 
   NOT
  
  may be because I exported latest upstream.
 
 I tried the following
 
 $ svn export -r 31 http://grapefruit.googlecode.com/svn/trunk/ 
 grapefruit-0.1a3
 $ tar -czvf grapefruit-0.1a3svn31.tar.gz grapefruit-0.1a3/
 $
 $ md5sum grapefruit-0.1a3svn31.tar.gz \
  rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz 
 497f9c6af0063f4c866c7883cc14f8cd  grapefruit-0.1a3svn31.tar.gz
 2692d795fc5f3ea5af032c034a56cc3d  
 rpmbuild/SOURCES/grapefruit-0.1a3svn31.tar.gz
 
 The second one is from the SRPM.
Thanks for pointing out now it's fixed.
Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-3.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717160] New: Review Request: hunspell-haw - Hawaiian hunspell dictionaries

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hunspell-haw - Hawaiian hunspell dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=717160

   Summary: Review Request: hunspell-haw - Hawaiian hunspell
dictionaries
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: caol...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-haw.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/hunspell-haw-0.01-1.fc15.src.rpm
Description: Hawaiian hunspell dictionaries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 472639] Review Request: Scilab - Numerical Analysis toolkit

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472639

Anders Blomdell anders.blomd...@control.lth.se changed:

   What|Removed |Added

 CC||anders.blomd...@control.lth
   ||.se

Bug 472639 depends on bug 710115, which changed state.

Bug 710115 Summary: Review Request: jlatexmath - Implementation of LaTeX math 
mode wrote in Java
https://bugzilla.redhat.com/show_bug.cgi?id=710115

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|MODIFIED
 Status|MODIFIED|ON_QA
 Resolution||ERRATA
 Status|ON_QA   |CLOSED

--- Comment #46 from Anders Blomdell anders.blomd...@control.lth.se 
2011-06-28 06:12:39 EDT ---
Obviously not too active since 5.3.2 is out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

--- Comment #13 from Jon Ciesla l...@jcomserv.net 2011-06-28 08:00:01 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716844] Review Request: django-recaptcha - A Django application for adding ReCAPTCHA to a form

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716844

--- Comment #6 from pjp pj.pan...@yahoo.co.in 2011-06-28 08:55:34 EDT ---
(In reply to comment #5)
 Is the package group needed? Its not an application that can be launched.

  No, it's not necessary, but still could be handy to have.

Also about generating tarball from $ svn export ...

I think the - .gz - compression changes the tarball every time you create it.

=

$ echo 'hello, world'  1
$ tar -czf 1.tar.gz 1
$ tar -czf 2.tar.gz 1
$ md5sum 1.tar.gz 2.tar.gz 
12ef3047bf3a93b99fd82e57eb7eeef9  1.tar.gz
6eec3830961866140011554f20bc48fb  2.tar.gz

=

I'll suggest change the compression to .bz2 or .xz as

.xz - $ tar -cJvf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
.bz2 - $ tar -cjvf grapefruit-0.1a3svn31.tar.bz2 grapefruit-0.1a3/

Please notice the capital(-J) and small(-j) in the options above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #5 from pjp pj.pan...@yahoo.co.in 2011-06-28 08:51:06 EDT ---
 Thanks for pointing out now it's fixed.
 Updated SPEC : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
 SRPM : 
 http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-3.20110627svn31.fc15.src.rpm

  Hey, I tried the same sequence again, but it again shows different md5sums
for the two tarballs.

I think the - .gz - compression changes the tarball every time you create it.

=

$ echo 'hello, world'  1
$ tar -czf 1.tar.gz 1
$ tar -czf 2.tar.gz 1
$ md5sum 1.tar.gz 2.tar.gz 
12ef3047bf3a93b99fd82e57eb7eeef9  1.tar.gz
6eec3830961866140011554f20bc48fb  2.tar.gz

=

I'll suggest change the compression to .bz2 or .xz as

.xz - $ tar -cJvf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
.bz2 - $ tar -cjvf grapefruit-0.1a3svn31.tar.bz2 grapefruit-0.1a3/

Please notice the capital(-J) and small(-j) in the options above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226204] Merge Review: nss

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226204

--- Comment #17 from Jon Ciesla l...@jcomserv.net 2011-06-28 09:12:31 EDT ---
I can.  Do we have an upstream contact, or should I simply go through their
bugtracking systems?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2011-06-28 09:11:59 EDT ---
bowtie-0.12.7-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/bowtie-0.12.7-2.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #6 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
09:11:24 EDT ---
(In reply to comment #5)
   Hey, I tried the same sequence again, but it again shows different md5sums
 for the two tarballs.
 
 I think the - .gz - compression changes the tarball every time you create it.
 
 =
 
 $ echo 'hello, world'  1
 $ tar -czf 1.tar.gz 1
 $ tar -czf 2.tar.gz 1
 $ md5sum 1.tar.gz 2.tar.gz 
 12ef3047bf3a93b99fd82e57eb7eeef9  1.tar.gz
 6eec3830961866140011554f20bc48fb  2.tar.gz
 
 =
 
 I'll suggest change the compression to .bz2 or .xz as
 
 .xz - $ tar -cJvf grapefruit-0.1a3svn31.tar.xz grapefruit-0.1a3/
 .bz2 - $ tar -cjvf grapefruit-0.1a3svn31.tar.bz2 grapefruit-0.1a3/
 
 Please notice the capital(-J) and small(-j) in the options above.

Thanks for suggesting, made .xz tarball this time.
SPEC URL: http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-4.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2011-06-28 09:19:19 EDT ---
bowtie-0.12.7-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/bowtie-0.12.7-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #8 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
09:40:27 EDT ---

license fixes completed

Spec: http://lbazan.fedorapeople.org/perl-Term-Animation.spec
SRPM: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-2.fc15.src.rpm


Description: 
This module provides a framework to produce sprite animations using ASCII art.
Each ASCII 'sprite' is given one or more frames, and placed into the animation
as an 'animation object'. An animation object can have a callback routine that
controls the position and frame of the object.

If the constructor is passed no arguments, it assumes that it is running full
screen, and behaves accordingly. Alternatively, it can accept a curses window
(created with the Curses newwin call) as an argument, and will draw into that
window.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #9 from Ralf Corsepius rc040...@freenet.de 2011-06-28 09:55:09 
EDT ---
MUSTFIX:

* BuildRequires:  perl-Test-Simple

Perl modules should not BR: a perl-module's package but BR. the individual
perl modules (BR: perl(...)).

* Any particular reason why make test is commented out?

* Clean up the %files section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2011-06-28 10:12:30 EDT ---
bowtie-0.12.7-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/bowtie-0.12.7-2.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

--- Comment #17 from Fedora Update System upda...@fedoraproject.org 
2011-06-28 10:19:15 EDT ---
bowtie-0.12.7-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/bowtie-0.12.7-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #10 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
10:28:06 EDT ---
remove make test
BuildRequires: change :-)


SRPM: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-5.fc15.src.rpm
Spec: http://lbazan.fedorapeople.org/perl-Term-Animation.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #11 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
10:47:09 EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3166528

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717337] New: Review Request: URCU - Userspace RCU Implementation

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: URCU - Userspace RCU Implementation

https://bugzilla.redhat.com/show_bug.cgi?id=717337

   Summary: Review Request: URCU - Userspace RCU Implementation
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: greenscient...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SPECS/urcu.spec 
SRPM URL:
http://www.dorsal.polymtl.ca/~ybrosseau/fedora/SRPMS/liburcu-0.6.3-1.src.rpm
Description: Userspace RCU  (read-copy-update) Implementation from LTTng UST.
This data synchronization library provides read-side access which scales
linearly with the number of cores. It does so by allowing multiples copies of a
given data structure to live at the same time, and by monitoring the data
structure accesses to detect grace periods after which memory reclamation is
possible. 

http://www.lttng.org/urcu/

Needed by the UST - the LTTng Userspace tracer that will be posted shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226204] Merge Review: nss

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226204

--- Comment #18 from Elio Maldonado Batiz emald...@redhat.com 2011-06-28 
11:26:51 EDT ---
(In reply to comment #17)
It's best to go through the upstream bug tracking systems. You can assign the
upstream nss bug to me. The Mozilla bug would probably be for the xulrunner
component, Kai and Chris would know the best way to report that one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717337] Review Request: URCU - Userspace RCU Implementation

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717337

--- Comment #1 from Yannick Brosseau greenscient...@gmail.com 2011-06-28 
11:33:52 EDT ---
This is my first Fedora package, so I'll need a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717337] Review Request: URCU - Userspace RCU Implementation

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717337

Yannick Brosseau greenscient...@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627936] Review Request: bowtie - An ultrafast, memory-efficient short read aligner

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627936

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #18 from Fedora Update System upda...@fedoraproject.org 
2011-06-28 11:47:12 EDT ---
bowtie-0.12.7-2.el5 has been pushed to the Fedora EPEL 5 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716402] Review Request: ckermit - The quintessential all-purpose communications program

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716402

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-06-28 
11:46:40 EDT ---
ckermit-9.0-0.1.beta2.el6 has been pushed to the Fedora EPEL 6 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717345] New: csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: csync2-1.34 - cluster synchronization tool

https://bugzilla.redhat.com/show_bug.cgi?id=717345

   Summary: csync2-1.34 - cluster synchronization tool
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lba...@bakertillypanama.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec: http://lbazan.fedorapeople.org/csync2.spec
SRPM: http://lbazan.fedorapeople.org/csync2-1.34-4.fc15.src.rpm

Csync2 is a cluster synchronization tool. It can be used to keep files on 
multiple hosts in a cluster in sync. Csync2 can handle complex setups with 
much more than just 2 hosts, handle file deletions and can detect conflicts.
It is expedient for HA-clusters, HPC-clusters, COWs and server farms.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

--- Comment #1 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
12:08:24 EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3166843

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711047] Review Request: naev - 2d action, RPG space game

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711047

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review+

--- Comment #5 from Tom spot Callaway tcall...@redhat.com 2011-06-28 
12:11:01 EDT ---
Huh. The %{_mandir}/man6/* line should be correct, what was unnecessary was the
%doc in front of it. 

Good:

- rpmlint checks return clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(cbaa09d036188a22c0c9c70f1db6e00923b138ff897cdd37072adf4a438a503d)
- package compiles on F-15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3164092)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file OK

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711048] Review Request: naev-data - Data files for NAEV game

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711048

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com

--- Comment #3 from Tom spot Callaway tcall...@redhat.com 2011-06-28 
12:13:34 EDT ---
Two things:

* You don't need the %defattr line anymore. I probably should have called it
out on the other review too, but its really a minor item.

* The proper license for this data is: GPLv3 or GPLv3+ or GPLv2+ or Public
Domain or CC-BY or CC-BY-SA

(Yes, I looked it up when I did my package, thats how I know. :) )

Make those two changes and I'll approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683150

--- Comment #12 from Elder Marco elderma...@gmail.com 2011-06-28 12:23:47 EDT 
---
Oh, generate a patch with svn is very easy. :)

Added patch to fix FSF address (upstream revision 334)

SPEC URL:
http://eldermarco.fedorapeople.org/files/specs/yad.spec

SRPM URL:
http://eldermarco.fedorapeople.org/files/srpms/yad-0.12.3-3.fc15.src.rpm

Koji task Info:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3166957

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717354] New: Review Request: perl-YUM-RepoQuery - Query a YUM repository for package information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-YUM-RepoQuery - Query a YUM repository for 
package information

https://bugzilla.redhat.com/show_bug.cgi?id=717354

   Summary: Review Request: perl-YUM-RepoQuery - Query a YUM
repository for package information
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL:
http://ppisar.fedorapeople.org/perl-YUM-RepoQuery/perl-YUM-RepoQuery.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-YUM-RepoQuery/perl-YUM-RepoQuery-0.1.2-1.fc15.src.rpm
Description:
YUM::RepoQuery takes the URI to a package repository with YUM meta-data, and
allows one to query what packages, and versions of those packages, are
available in that repository.


Out-dated FSF address has been reported to upstream
(https://rt.cpan.org/Public/Bug/Display.html?id=69127).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683150

--- Comment #13 from Elder Marco elderma...@gmail.com 2011-06-28 12:28:32 EDT 
---
rpmlint output:

yad.x86_64: W: spelling-error Summary(en_US) dialogs - dialog, dialog s
yad.x86_64: W: spelling-error %description -l en_US zenity - zenith
yad.x86_64: W: spelling-error %description -l en_US dialogs - dialog, dialog s
yad.x86_64: W: no-manual-page-for-binary yad-icon-browser
yad.src: W: spelling-error Summary(en_US) dialogs - dialog, dialog s
yad.src: W: spelling-error %description -l en_US zenity - zenith
yad.src: W: spelling-error %description -l en_US dialogs - dialog, dialog s
yad.src: W: invalid-url Source0:
http://yad.googlecode.com/files/yad-0.12.3.tar.xz HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 8 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 604033] Review Request: openemr - Practice Management, Electronic Medical Record

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604033

--- Comment #8 from Ankur Sinha sanjay.an...@gmail.com 2011-06-28 12:43:25 
EDT ---
Closed. I'll update the trac.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716697] Review Request: perl-FusionInventory-Agent-Task-ESX - vCenter/ESX/ESXi remote inventory for FusionInventory Agent

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716697

--- Comment #1 from Remi Collet fed...@famillecollet.com 2011-06-28 12:57:39 
EDT ---
Update to 1.1.2 :
https://github.com/remicollet/remirepo/commit/35b68d8913ee75680c0f0538249e3102b25c4bcd

SRPM:
http://rpms.famillecollet.com/SRPMS/perl-FusionInventory-Agent-Task-ESX-1.1.2-1.remi.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 714336] Review Request: tetgen - A Quality Tetrahedral Mesh Generator and a 3D Delaunay Triangulator

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714336

--- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-06-28 13:02:26 
EDT ---
(In reply to comment #1)
 I think that caption doesn't belong into the package description:
 
 TetGen is written in C++. It can be compiled into either a 
 standalone program invoked from command-line or a library for 
 linking with other programs. All major operating systems, 
 e.g. Unix/Linux, MacOS, Windows, etc, are supported.
 
 There are no pictures:
 
 The following pictures respectively illustrate a 3D polyhedral
 domain (left), a boundary conforming Delaunay tetrahedral mesh
 (middle), and its dual - a Voronoi partition (right).
 
 No need to rm -rf $RPM_BUILD_ROOT.
 
 It might be a good idea to include the documentation you can download from the
 homepage.
 
 Your CFLAGS and CXXFLAGS are not worshiped:
 
 g++ -O0 -c predicates.cxx
 g++ -g -Wall -DSELF_CHECK -o tetgen tetgen.cxx predicates.o -lm


Hi Volker, 

updated packages:

http://ankursinha.fedorapeople.org/tetgen/tetgen.spec

http://ankursinha.fedorapeople.org/tetgen/tetgen-1.4.3-1.fc15.src.rpm

I'll package the docs as a separate package? Or I can always include them
later. 

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577951

--- Comment #22 from Andreas Bierfert andreas.bierf...@lowlatency.de 
2011-06-28 13:15:08 EDT ---
Thanks for you comments. Should be fixed/changed in this version:

http://fedora.lowlatency.de/review/mingw-wine-gecko.spec
http://fedora.lowlatency.de/review/mingw-wine-gecko-1.2.0-3.fc16.src.rpm
http://fedora.lowlatency.de/review/mingw32-wine-gecko-1.2.0-3.fc16.noarch.rpm
http://fedora.lowlatency.de/review/mingw64-wine-gecko-1.2.0-3.fc16.noarch.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226204] Merge Review: nss

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226204

--- Comment #19 from Jon Ciesla l...@jcomserv.net 2011-06-28 13:13:37 EDT ---
NSS bug filed, let me know if you need changes made:

https://bugzilla.mozilla.org/show_bug.cgi?id=667938

I CCd you, I can't reassign.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226204] Merge Review: nss

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226204

--- Comment #20 from Elio Maldonado Batiz emald...@redhat.com 2011-06-28 
13:31:54 EDT ---
(In reply to comment #19) Thanks, it's assigned to me now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 604971] Review Request: jwm - Joe's Window Manager

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604971

--- Comment #14 from Germán Racca gra...@gmail.com 2011-06-28 14:13:39 EDT ---
(In reply to comment #13)
 BTW, I'm missing a scriptlet for a proper *.desktop file installation, see
 http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage.

Hi Mario: please let me some time because I'm full of work :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 716352] Review Request: toothchart - A PHP script which graphically shows how a baby's primary teeth have erupted

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716352

Mario Blättermann mari...@freenet.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mari...@freenet.de
 AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
   Flag||fedora-review?

--- Comment #1 from Mario Blättermann mari...@freenet.de 2011-06-28 14:12:29 
EDT ---
Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3167503

$ rpmlint -i -v *
toothchart.src: I: checking
toothchart.src: I: checking-url http://sourceforge.net/projects/toothchart/
(timeout 10 seconds)
toothchart.src: I: checking-url
http://downloads.sourceforge.net/toothchart/toothchart-beta-0.02.0.tar.gz
(timeout 10 seconds)
toothchart.noarch: I: checking
toothchart.noarch: I: checking-url http://sourceforge.net/projects/toothchart/
(timeout 10 seconds)
toothchart.noarch: E: incorrect-fsf-address /usr/share/doc/toothchart/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

2 packages and 0 specfiles checked; 1 errors, 0 warnings.


Almost no issues, just the incorrect FSF address. You should file a bug
upstream, but it's no blocker for your package.

Informal review will follow immediately.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683150

Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #14 from Christoph Wickert cwick...@fedoraproject.org 2011-06-28 
14:29:29 EDT ---
Fixing the FSF address was not really needed to finish this review, but it
doesn't hurt either.

The package is APPROVED.

Before I sponsor you into the packagers group I'd like to know if you did other
packages or have participated in other reviews. You can always help by adding
useful comments and you can even do an informal pre-review as long as you
indicate it is not official and you don't set the fedora‑review+ flag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711047] Review Request: naev - 2d action, RPG space game

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711047

--- Comment #6 from Jonathan Dieter jdie...@gmail.com 2011-06-28 14:31:12 EDT 
---
Updated spec to remove defattr.  And, yeah, that was my stupid mistake on the
whole %{_mandir} thing.  I just removed the whole thing, and then put it back
without the %doc, without realizing that's what I did.

Spec URL:
http://www.lesloueizeh.com/jdieter/naev.spec
SRPM URL:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-3.fc15.src.rpm
32-bit F15 RPM:
http://www.lesloueizeh.com/jdieter/naev-0.5.0-3.fc15.i686.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711048] Review Request: naev-data - Data files for NAEV game

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711048

--- Comment #4 from Jonathan Dieter jdie...@gmail.com 2011-06-28 14:32:24 EDT 
---
I've removed the defattr line and fixed the license.  Thanks for looking that
up!

Spec URL:
http://www.lesloueizeh.com/jdieter/naev-data.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711048] Review Request: naev-data - Data files for NAEV game

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711048

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review+

--- Comment #5 from Tom spot Callaway tcall...@redhat.com 2011-06-28 
14:59:47 EDT ---
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716352] Review Request: toothchart - A PHP script which graphically shows how a baby's primary teeth have erupted

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716352

--- Comment #2 from Mario Blättermann mari...@freenet.de 2011-06-28 15:21:11 
EDT ---
-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[X] MUST: The package must be licensed with a Fedora approved license.
According to the license included in the package, it should be GPLv2 
(without +). The source itself doesn't say anything about the license.

[X] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
05b19b482ba86101694e63bf41d5a5e9  toothchart-beta-0.02.0.tar.gz
05b19b482ba86101694e63bf41d5a5e9  toothchart-beta-0.02.0.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available for f16.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
No BR needed anyway, the basic build environment is sufficient here.

[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
-p switch has applied to install.

[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. Don't know how to test it on my
system.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683150

--- Comment #15 from Elder Marco elderma...@gmail.com 2011-06-28 15:59:58 EDT 
---
Thanks Christoph. 

Yes, I did. For personal use 
http://eldermarco.fedorapeople.org/files/srpms/

There are another packages, but the packages aren't open source.

So, this is officially my first package. I'm new here because I was - and I'm
-- learning English before (my first language is Brazilian Portuguese).
However, I made comments here: 

https://bugzilla.redhat.com/show_bug.cgi?id=539693

There is a bug that I also registered:

https://bugzilla.redhat.com/show_bug.cgi?id=618447

I'll participate more from now. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 641957] Review Request: rubygem-database_cleaner - Strategies for cleaning databases

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641957

--- Comment #11 from Chris Lalancette clala...@redhat.com 2011-06-28 16:11:21 
EDT ---
(In reply to comment #10)
 Hello Chris, thank you for taking over this review. Since this package needs 
 to
 be patched, it is necessary to install the gem in %prep section. Furthemore,
 the gem should be always installed in %prep section although the guidelines 
 say
 something different atm. The reasons are:
 
 1) The patch may be required in any time during the life of the gem and moving
 gem installation from %install into the %prep section is therefore required. 
 If
 you install in %prep right from the start, you don't need to do this.

Note that you can reference patches via %{PATCH#} at any stage in the process
to apply patches.  Even so, I've rarely seen the case where that is strictly
necessary; you can most usually do it during %prep.

 2) It is common for all packages to be installed in %prep section. It is bit
 clumsy with gems, but still its the best place IMO.

See, the thing is, it is *not* common for packages to be installed in the %prep
section.  If you look at any non-gem RPM, the %prep section is all about
unpacking the sources and applying patches.  What you typically end up with at
that point is a development environment that you could do a make against. 
(as one example, fedpkg clone openssh ; cd openssh ; fedpkg prep)

Even amongst rubygems, it seems like the preferred way to do things is to leave
%prep and %build empty, and just install the gem in the %install section.  That
seems to make sense; you are installing the gem into the final destination at
that point.  %prep just seems like the wrong place to be doing it, in my
opinion, without a good reason.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 705382] Review Request: sympa - Mailing list manager

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705382

Bug 705382 depends on bug 705376, which changed state.

Bug 705376 Summary: Review Request: perl-MIME-Lite-HTML - Provide routine to 
transform a HTML page in a MIME-Lite mail
https://bugzilla.redhat.com/show_bug.cgi?id=705376

   What|Old Value   |New Value

 Resolution||ERRATA
 Status|ON_QA   |CLOSED

--- Comment #1 from Xavier Bachelot xav...@bachelot.org 2011-06-28 16:25:03 
EDT ---
Update to 6.1.5 :
Spec URL: http://www.bachelot.org/fedora/SPECS/sympa.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/sympa-6.1.5-1.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 705382] Review Request: sympa - Mailing list manager

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705382

Bug 705382 depends on bug 705377, which changed state.

Bug 705377 Summary: Review Request: perl-AuthCAS - Client library for CAS 2.0 
authentication server
https://bugzilla.redhat.com/show_bug.cgi?id=705377

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715610] Review Request: perl-HTTP-Exception - Throw HTTP-Errors as (Exception::Class-) Exceptions

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715610

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-06-28 
16:26:27 EDT ---
perl-HTTP-Exception-0.03001-1.fc15 has been pushed to the Fedora 15 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622151] Review Request: GLee - GL Easy Extension library

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622151

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-06-28 
16:26:44 EDT ---
GLee-5.4.0-1.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 705377] Review Request: perl-AuthCAS - Client library for CAS 2.0 authentication server

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705377

Xavier Bachelot xav...@bachelot.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-06-28 16:27:32

--- Comment #7 from Xavier Bachelot xav...@bachelot.org 2011-06-28 16:27:32 
EDT ---
Built and released for all branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716844] Review Request: django-recaptcha - A Django application for adding ReCAPTCHA to a form

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716844

--- Comment #7 from Rahul Sundaram methe...@gmail.com 2011-06-28 16:32:33 EDT 
---
(In reply to comment #5)
 Is the package group needed? Its not an application that can be launched.

Package group is optional but grouping has nothing to do with whether the
application is launched or not.  Yum and ffriends doesn't use the RPM groups
information at all anymore but instead we use comps
(http://fedoraproject.org/wiki/How_to_use_and_edit_comps.xml_for_package_groups).
 However the package group information is still used by other package managers
like apt, synaptic and smart. Just FYI.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 CC||methe...@gmail.com

--- Comment #7 from Rahul Sundaram methe...@gmail.com 2011-06-28 16:36:25 EDT 
---
Hate to be a stickler but using the same wording in two different changelog
isn't a good idea.  You might want to fix the last entry to note that you
changed the archive format or something else.  Don't have to bump the release. 
You are free to fix this before importing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716344] Review Request: elmer - Open Source Finite Element Software for Multiphysical Problems

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716344

--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2011-06-28 17:35:11 
EDT ---
This is a metapackage, and you're basically generating it from the elmer-fem
tarball.

This bug should be closed as duplicate of 715620 and the elmer-fem package made
to provide the elmer metapackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #2 from Volker Fröhlich volke...@gmx.at 2011-06-28 17:34:52 EDT 
---
URL is supposed to be the website of the project.

Please inform upstream, that the postal address of the FSF has changed and
should be updated.

ChangeLog, NEWS, TODO and INSTALL contain nothing useful.

Better use %{_mandir}/man1/csync2.1.* instead of %{_mandir}/man1/csync2.1.gz.

You can leave out defattr.

The _sharedstatedir macro is substituted with /var/lib. Please use -p along
with install to preserve the timestamps.

Why do you run make clean?

You can also leave out the build target all, as it is the first target, thus
default. mkdir -p $RPM_BUILD_ROOT%{_var}/lib/csync2 also seems to be
dispensable.

I think, BuildRequires one per line is more legible. BR xinetd doesn't seem to
be necessary.

I guess you're aiming for EPEL. There is no sqlite2 package there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 708402] Review Request: tophat - A spliced read mapper for RNA-Seq

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708402

--- Comment #5 from Adam Huffman bl...@verdurin.com 2011-06-28 17:40:35 EDT 
---
SeqAn request is at https://bugzilla.redhat.com/show_bug.cgi?id=717473

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708402] Review Request: tophat - A spliced read mapper for RNA-Seq

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708402

Adam Huffman bl...@verdurin.com changed:

   What|Removed |Added

 Depends on||717473

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717473] Review Request: SeqAn - Biological sequence analysis library

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717473

Adam Huffman bl...@verdurin.com changed:

   What|Removed |Added

 Blocks||708402

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715314] Review Request: metis - A set of serial programs for partitioning graphs, partitioning finite element meshes, and producing fill reducing orderings for sparse matrices

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715314

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717345] csync2-1.34 - cluster synchronization tool

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717345

Guillermo Gómez guillermo.go...@gmail.com changed:

   What|Removed |Added

 CC||guillermo.go...@gmail.com

--- Comment #3 from Guillermo Gómez guillermo.go...@gmail.com 2011-06-28 
17:37:11 EDT ---
Please remember to incluse rpmlint on your requests.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 715620] Review Request: elmer-fem - Open Source Finite Element Software for Multiphysical Problems

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715620

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||715314(metis)

--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2011-06-28 17:35:53 
EDT ---
This package depends on METIS, which is non-free.

You need to drop METIS support.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717473] New: Review Request: SeqAn - Biological sequence analysis library

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: SeqAn - Biological sequence analysis library

https://bugzilla.redhat.com/show_bug.cgi?id=717473

   Summary: Review Request: SeqAn - Biological sequence analysis
library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bl...@verdurin.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://verdurin.fedorapeople.org/reviews/SeqAn/SeqAn.spec
SRPM URL:
http://verdurin.fedorapeople.org/reviews/SeqAn/SeqAn-1.3-4.fc15.src.rpm
Description: 
SeqAn is an open source C++ library of efficient algorithms and data   
 structures for the analysis of sequences
with the focus on biological
data. Our library applies a unique generic design that guarantees high  
performance, generality, extensibility, and integration with other  
libraries. SeqAn is easy to use and simplifies the development of new   
software tools with a minimal loss of performance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 714336] Review Request: tetgen - A Quality Tetrahedral Mesh Generator and a 3D Delaunay Triangulator

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714336

--- Comment #3 from Volker Fröhlich volke...@gmx.at 2011-06-28 17:57:34 EDT 
---
Again: Please don't upload files using the same release number as before. It
makes work harder for the reviewer.

g++  -c predicates.cxx is still there.

What do you think of that other paragraph of the description? Does it help the
Fedora user? The package already built the binary, so it is pointless, from my
point of view. If I wanted to install this package, I wouldn't mind, if it
built on Windows too. And if I wanted to see what language it was written in,
I'd seek for the source code.

As of the documentation: If it is not very big, include it in the main package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 715127] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715127

--- Comment #2 from Olivier Samyn c...@oleastre.be 2011-06-28 18:07:56 EDT ---
I updated the spec and src.rpm files at the same place.

Changes:
- Updated URL
- Removed the BuildRoot, defattr and executable flag lines.
- Added -p to all install commands.
- Use %{_mandir}/man1/* in the %files section
- Removed VERSION file from the EOL modification list

I will inform upstream that the FSF address is an old one and that I started
the packaging process for fedora.

The doc/programming content describes the way the source code is written. From
my point of view, it is only interesting if you are reading the program source
(and so in the src.rpm).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717473] Review Request: SeqAn - Biological sequence analysis library

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717473

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich volke...@gmx.at 2011-06-28 18:25:32 EDT 
---
Rabema and Stellar are licensed as GPLv3+, other components are LGPLv3+.

Did you manage to use the system wide samtools?

The package doesn't build in Mock or with rpmbuild: rm: cannot remove
`SeqAn-1.3/apps/stellar/examples/reads.fasta': Permission denied
...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 715127] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715127

--- Comment #3 from Volker Fröhlich volke...@gmx.at 2011-06-28 18:40:27 EDT 
---
Aha, I see.

Please don't update at the same place, but make a new release next time. The
changelog should go to the file as well!

rm -rf $RPM_BUILD_ROOT and the clean section are useless too.

http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

Did you avoid make install for a specific reason?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713963] Review Request: rpkg - Utility for interacting with rpm+git packaging systems

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713963

Jesse Keating jkeat...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE
Last Closed||2011-06-28 18:43:11

--- Comment #11 from Jesse Keating jkeat...@redhat.com 2011-06-28 18:43:11 
EDT ---
Built for rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708826] Review Request: python-gitdb - A pure-Python git object database

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708826

Jesse Keating jkeat...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-06-28 19:00:33

--- Comment #8 from Jesse Keating jkeat...@redhat.com 2011-06-28 19:00:33 EDT 
---
Built for rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

Luis Bazan lba...@bakertillypanama.com changed:

   What|Removed |Added

 CC||lba...@bakertillypanama.com

--- Comment #2 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
19:05:22 EDT ---
$ rpmlint -v *
rubygem-rhc.src: I: checking
rubygem-rhc.src: I: checking-url https://openshift.redhat.com (timeout 10
seconds)
rubygem-rhc.src: I: checking-url http://rubygems.org/downloads/rhc-0.71.2.gem
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[lbazan@BAKER-FEDORA ruby]$ rpmlint *.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

I think after a review, the package is good.
the spec is complete without failure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

--- Comment #3 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
19:11:34 EDT ---
APROVED!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

Luis Bazan lba...@bakertillypanama.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717354] Review Request: perl-YUM-RepoQuery - Query a YUM repository for package information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717354

Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||emmanuel.seyman@club-intern
   ||et.fr
 AssignedTo|nob...@fedoraproject.org|emmanuel.seyman@club-intern
   ||et.fr
   Flag||fedora-review?

--- Comment #1 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 
2011-06-28 20:04:53 EDT ---
Taking.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715127] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715127

--- Comment #4 from Olivier Samyn c...@oleastre.be 2011-06-28 20:08:29 EDT ---
As I started from an existing spec file, I just adapted it to the latest
upstream source code, without removing historic stuff (like %clean or
BuildRoot), nor checking if make install should be used instead of manual
install.
(I started from the latest spec at
http://pkgs.fedoraproject.org/gitweb/?p=abcMIDI.git)

I created a new version located at:
http://www.oleastre.be/fedora/abcMIDI/2/abcMIDI.spec
http://www.oleastre.be/fedora/abcMIDI/2/abcMIDI-20110610-1.fc15.src.rpm

This one uses make install.
There is one problem, with the current upstream makefile: it concatenates
prefix and other variables, like docdir or mandir. So I cannot use the rpm
macros %{docdir} or %{_mandir} for those.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717354] Review Request: perl-YUM-RepoQuery - Query a YUM repository for package information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717354

Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 
2011-06-28 20:40:15 EDT ---
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3167959

 [x] Rpmlint output:
perl-YUM-RepoQuery.noarch: E: incorrect-fsf-address
/usr/share/doc/perl-YUM-RepoQuery-0.1.2/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: LGPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
62df709f4f908fbf471930cb3bbcae72  YUM-RepoQuery-0.1.2.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3167959

 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=2, Tests=1,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.92 cusr  0.06
csys =  1.00 CPU)
Result: PASS

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #12 from Luis Bazan lba...@bakertillypanama.com 2011-06-28 
22:09:03 EDT ---
$ rpmlint -i *
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v *
perl-Term-Animation.noarch: I: checking
perl-Term-Animation.noarch: I: checking-url
http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.6.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

Luis Bazan lba...@bakertillypanama.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WORKSFORME
Last Closed||2011-06-28 22:29:13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716808] Review Request: grapefruit - Python module for color information

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716808

--- Comment #8 from Praveen Kumar kumarpraveen.nit...@gmail.com 2011-06-28 
22:44:28 EDT ---
(In reply to comment #7)
 Hate to be a stickler but using the same wording in two different changelog
 isn't a good idea.  You might want to fix the last entry to note that you
 changed the archive format or something else.  Don't have to bump the 
 release. 
 You are free to fix this before importing.

Thanks,I just forgot, now fixed. I don't think I need to update release for
that. 
SPEC URL : http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit.spec
SRPM URL :
http://kumarpraveen.fedorapeople.org/grapefruit/grapefruit-0.1a3-4.20110627svn31.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717502] New: Review Request: i4uc - IDE for developing micro-controllers firmware

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: i4uc - IDE for developing micro-controllers firmware

https://bugzilla.redhat.com/show_bug.cgi?id=717502

   Summary: Review Request: i4uc - IDE for developing
micro-controllers firmware
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: germa...@fedoraproject.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://germanrs.fedorapeople.org/rpmdev/i4uc/i4uc.spec
SRPM URL:
http://germanrs.fedorapeople.org/rpmdev/i4uc/i4uc-0.5.6-1.fc15.i686.src.rpm
Description: i4uc is a multiple platform IDE for developing 
micro-controllers firmware.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

German Ruiz germa...@fedoraproject.org changed:

   What|Removed |Added

 CC||germa...@fedoraproject.org,
   ||larry.letel...@gmail.com
 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 611068] Review Request: django-picklefield - Implementation of a pickled object field

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611068

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 AssignedTo|r.landm...@redhat.com   |methe...@gmail.com
   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Rahul Sundaram methe...@gmail.com 2011-06-28 23:15:37 EDT 
---

I am taking over the review since reminders to Ruediger Landmann here as well
as offlist haven't been answered.  

The following is redundant unless you are building for EPEL as well

%if ! (0%{?fedora}  12 || 0%{?rhel}  5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print get_python_lib())}
%endif

BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-)

I would consider removing these.  Not a blocker however

    APPROVED 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 641957] Review Request: rubygem-database_cleaner - Strategies for cleaning databases

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641957

--- Comment #12 from Vít Ondruch vondr...@redhat.com 2011-06-29 01:36:56 EDT 
---
Chris, I had quite lengthy discussion on this topic with Mamoru at [1] and I
was convinced by him. There you can find few points why to install gem in %prep
section. 

 Even amongst rubygems, it seems like the preferred way to do things is to 
 leave
 %prep and %build empty, and just install the gem in the %install section.

There is only one preferred way amongst rubygems and that is the .spec file
produced by rubygem-gem2rpm. Most of the packager even do not fix the license
until review, so do not take other gems too seriously please.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=676308

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717160] Review Request: hunspell-haw - Hawaiian hunspell dictionaries

2011-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717160

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-06-29 01:47:15 EDT 
---
Review:
+ koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=3168125
+ rpmlint is silent
+ upstream source is verified as 

3ef7d7b1b4992771fc593d2d032f051e70b73ece 
hawaiian_spell_checker-0.01-fx+tb+sm.xpi
3ef7d7b1b4992771fc593d2d032f051e70b73ece 
../SOURCES/hawaiian_spell_checker-0.01-fx+tb+sm.xpi


Suggestions:
1) As per new guidelines you can remove
  a) buildroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review