[Bug 718415] Review Request: sushi - A quick previewer for the Nautilus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718415 Elad Alfassa changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-12 03:01:32 --- Comment #14 from Elad Alfassa 2011-07-12 03:01:32 EDT --- Built on rawhide. Closing :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713159] Review Request: rubygem-rbvmomi - Ruby interface to the VMware vSphere API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713159
Vít Ondruch changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Vít Ondruch 2011-07-12 03:23:26 EDT
---
* It doesn't look like you have uploaded the updated .spec file. However
that is not a showstopper. I'll take the .spec from .srpm for review.
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
- i.e. please name rename rubygem-rbvmomi-1.2.3.spec => rubygem-rbvmomi.spec
rpmlint output OK.
Koji build OK: http://koji.fedoraproject.org/koji/taskinfo?taskID=3193050
Please don't forget to rename the .spec file before import. Otherwise the
package looks good, so it is APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719854
--- Comment #8 from Ulrich Schwickerath
2011-07-12 03:45:41 EDT ---
As discussed offline, I have changed the package doing a cp of the sources
instead of using {SOURCES0} during the build step.
ad 1/ indeed, the explicit requirement on expat is not needed, removed it. For
build it is kept of course, else it won't build
ad 2/ config paths updated. Hope that is what you mean... Please let me know
ad 3/ changelog updated.
new version:
http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser.spec
http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser-0.6.81-4.el6.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 Steve Traylen changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719854
--- Comment #9 from Vít Ondruch 2011-07-12 04:36:52 EDT
---
Hi Ulrich, I am not sponsor so I cannot help with that, but I have several
comments to your package:
1) First of all, the gem seems to be rather old. It seems that upstream
released new version [1] but the update was never released in gem form. Also,
the expat upstream doesn't seems to be extremely vital. So are you really sure
that you like to import the gem into Fedora, instead of considering to
switching to Nokogiri for example?
2) License
The license should be probably "GPLv2+ or Ruby or MIT" and according to readme,
there are also some files licensed under the same terms as Perl.
3) You don't need the ruby_sitelib at all (btw you have type there).
4) BuildRoot is not required anymore
5) %clean section is not required
6) defattr is obsolete
7) You should submit standard build flags for building the C extension:
export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
8) Since the gem command itself merges all tree steps which are usually
required, i.e. %prep, %build, %install, it is preferred to install the gem in
%build section and then copy it in %install section into final place.
9) There has to be spaces between each changelog entry, otherwise "fedpkg clog"
fails to extract the log entries correctly. For example
* Wed Jul 06 2011 Ulrich Schwickerath - 0.6.81-4
- cleaner way to treat SOURCE
- remove explicit dependency on expat
- make globals conditional
* Wed Jul 06 2011 Ulrich Schwickerath - 0.6.81-3
- fix build problems
[1] http://www.yoshidam.net/Ruby.html#xmlparser
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 Steve Traylen changed: What|Removed |Added Status Whiteboard|BuildFails | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #10 from Steve Traylen 2011-07-12 04:45:16 EDT --- > 4) BuildRoot is not required anymore > > 5) %clean section is not required > > 6) defattr is obsolete But you can leave them in if you are targeting older platforms as well, e.g RHEL6 as well. The other comments look to all be valid. Once you provide some informal review examples I will complete the formal review of the package. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699335] Review Request: python-coffin - Jinja2 adapter for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699335 Rahul Sundaram changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #8 from Rahul Sundaram 2011-07-12 05:03:34 EDT --- Package Change Request == Package Name: python-coffin New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #36 from Rahul Sundaram 2011-07-12 05:06:31 EDT --- I am going to give this 2 more days and close this review request and open my own to make forward progress in this since this happens to be a dependency for Askbot, which I am packaging. I would happy to assist in Oded Arbel getting sponsored when he is more free. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511155] Review Request: python-dateutil - Extensions to the standard python datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511155 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Flag||fedora-cvs? --- Comment #3 from Rahul Sundaram 2011-07-12 05:47:14 EDT --- python-dateutil was apparently imported into extras before we started using Red Hat bugzilla for this. So latching on this duplicate review request for the EPEL branch. Package Change Request == Package Name: python-dateutil New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 189013] Review Request: python-sqlalchemy - Modular and flexible ORM library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=189013 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from Rahul Sundaram 2011-07-12 05:53:31 EDT --- Package Change Request == Package Name: python-sqlalchemy New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713361] Review Request: ghc-pcre-light - Haskell binding to pcre
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713361 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Jens Petersen 2011-07-12 05:57:41 EDT --- Built for f16 rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=3193222 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611080] Review Request: python-unittest2 - Backport of new unittest feature for Python 2.7 to Python 2.4+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611080 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #18 from Rahul Sundaram 2011-07-12 05:55:31 EDT --- Package Change Request == Package Name: python-unittest2 New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688499] Review Request: cabal-dev - Haskell package sandboxing tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688499 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662275] Review Request: hledger - A double-entry accounting tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662275 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648250] Review Request: ghc-xss-sanitize - Sanitize untrusted HTML to prevent XSS attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648250 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630206] Review Request: ghc-hledger-lib - Core types and utilities for working with hledger data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630206 Lakshmi Narasimhan changed: What|Removed |Added Flag||needinfo?(maths...@gmail.co ||m) --- Comment #10 from Lakshmi Narasimhan 2011-07-12 06:16:50 EDT --- I am taking up hledger. Please build this package for rawhide and f15. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662275] Review Request: hledger - A double-entry accounting tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662275 Lakshmi Narasimhan changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com Flag||needinfo?(maths...@gmail.co ||m) --- Comment #2 from Lakshmi Narasimhan 2011-07-12 06:17:26 EDT --- Needs hledger-lib to be built for rawhide at least. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648247] Review Request: ghc-tagged - Newtype wrappers for phantom types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648247 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com --- Comment #3 from Lakshmi Narasimhan 2011-07-12 06:20:06 EDT --- This is indirectly needed for yi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713361] Review Request: ghc-pcre-light - Haskell binding to pcre
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713361 --- Comment #6 from Fedora Update System 2011-07-12 06:23:32 EDT --- ghc-pcre-light-0.4-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-pcre-light-0.4-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713361] Review Request: ghc-pcre-light - Haskell binding to pcre
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713361 --- Comment #7 from Fedora Update System 2011-07-12 06:23:42 EDT --- ghc-pcre-light-0.4-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-pcre-light-0.4-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693950] Review Request: yagf - Graphical front-end for cuneiform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693950 --- Comment #9 from Dmitrij S. Kryzhevich 2011-07-12 06:40:06 EDT --- Very thanks! It works. I thought there would be double entries, but with %dir all work. Your link on locales guid does not mention qt scpecifics. Internal fedoraprject wiki search as well as google one did not show me anything. I know how to manage qt translations with find_lang now. Thanks one more time. Spec URL: http://krege.fedorapeople.org/yagf/yagf.spec SRPM URL: http://krege.fedorapeople.org/yagf/yagf-0.8.6-4.fc15.src.rpm Changes: spec clean up (is it realy needed? but it is done) and find_lang usage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673776] Review Request: leksah - An IDE for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673776 Bug 673776 depends on bug 696982, which changed state. Bug 696982 Summary: Review Request: ghc-strict - Haskell library providing strict data types https://bugzilla.redhat.com/show_bug.cgi?id=696982 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #15 from Lakshmi Narasimhan 2011-07-12 07:03:41 EDT --- Updated spec file and srpm http://narasim.fedorapeople.org/package_reviews/leksah.spec http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608574] Review Request: tinymce - Web based Javascript HTML WYSIWYG editor control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608574 Tim Lauridsen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Tim Lauridsen 2011-07-12 07:27:35 EDT --- Looks like the issues are fixed in the latest spec. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #21 from Eric Maeker 2011-07-12 07:32:07 EDT --- Hello, Thanks for your work. It is great success to represented in Fedora repositories. I'd to suggest some answer (as upstreamer) to your questionnings. - [?]MUST: The package must contain code, or permissible content. Pixmaps, sqlite databases and following text files /usr/share/freemedforms/textfiles/boys_surnames.csv /usr/share/freemedforms/textfiles/default_user_footer.htm /usr/share/freemedforms/textfiles/default_user_header.htm /usr/share/freemedforms/textfiles/girls_surnames.csv /usr/share/freemedforms/textfiles/listemotsfr.txt /usr/share/freemedforms/textfiles/pays.txt /usr/share/freemedforms/textfiles/surnames.txt /usr/share/freemedforms/textfiles/zipcodes.csv Do those text files come under permissable content category, especially those containing zip codes of places and surnames? - All data files, databases and extra content is licenced with the GPLv3. We can not add headers in files while these files are automatically processed by the app. - freemedforms-devel.i686: W: non-standard-group Development/Libraries/C and C++ The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". - Can I suggest the "Applications/Productivity" group. The FreeMedForms EMR, for medical doctors, is like OOo that a book writer will need to work. - freemedforms-debuginfo.i686: W: hidden-file-or-dir - All these dirs are created by the qmake step (build step) and are included in the original source. Another information, there is a new upstream version available: 0.5.9~alpha2 ready for packaging. Thanks for your work and time. Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Eric Maeker changed: What|Removed |Added Flag||needinfo? --- Comment #22 from Eric Maeker 2011-07-12 07:34:58 EDT --- Oooohhh I'm tired. > I'd to suggest some answer (as upstreamer) to your questionnings. I'd like to suggest some answers (as upstreamer) to your questionnings. > All these dirs are created by the qmake step (build step) and are included in > the original source. All these dirs are created by the qmake step (build step) and are *not* included in the original source tarball. Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693950] Review Request: yagf - Graphical front-end for cuneiform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693950 --- Comment #10 from Volker Fröhlich 2011-07-12 07:39:59 EDT --- /usr/lib/rpm/find-lang.sh is where it is at. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709949 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Jens Petersen 2011-07-12 07:46:07 EDT --- Built for f16 rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=3193280 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #11 from Ulrich Schwickerath 2011-07-12 08:21:55 EDT --- Hi, thanks for the additional comments! ad 1/ for the time being it is still needed. For a specific application (OpenNebula) a huge speedup is archived by using this package (in addition to nokogiri). I've contacted the developers, the problem seems to come from dependencies on a third package. So, yes, although this package is old it would be good to have it in Fedora. It'll be needed in EPEL for RHES5 and RHES6 ad 2/ should be ruby, from the README. Fixed. ad 3/ true. Removed it. ad 4/5/6 : I need to keep them as I need to build the package also on RHES5 and RHES6. Getting it for these distributions is the goal of this submission ad 7/ done ad 8/ This is what I'm doing in this spec. The copy in the prep step was requested by Steve. ad 9/ done http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser.spec http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser-0.6.81-5.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720254] Review Request: perl-Unicode-Casing - Perl extension to override system case changing functions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720254
Petr Sabata changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Petr Sabata 2011-07-12 08:28:58 EDT ---
Package: perl-Unicode-Casing
Version: 0.07
Release: 1.fc15
Sources: Unicode-Casing-0.07.tar.gz
Patches:
--
Package successfully built locally.
Package successfully built in mock, fedora-15-x86_64.
Package successfully built in mock, fedora-15-i386.
Package successfully built in koji, dist-rawhide.
MUST items:
[ OK ] Package does NOT include pre-built binaries or libraries
[ OK ] Spec file is legible and written in American english
[ OK ] Package successfully builds on at least one supported primary
architecture
[ -- ] All ExcludeArch tags valid, referencing proper bug reports
[ OK ] Package obeys FHS (with _libexecdir and /srv exceptions)
[ OK ] No errors reported by rpmlint
[ OK ] Changelog present and properly formatted
[ OK ] Package does NOT include Packager, Vendor, Copyright or PreReq tags
[ OK ] Source tags are working URLs and sources match upstream or justified
otherwise
[ OK ] Requires correct or justified otherwise
[ OK ] BuildRequires correct or justified otherwise
[ OK ] All file names are in proper UTF-8 encoding
[ OK ] All plain text failes are in proper UTF-8 encoding
[ -- ] Large documentation files are located in doc subpackage
[ OK ] All documentation prefixed with %doc
[ OK ] Documentation is NOT executable
[ OK ] No files in %doc are needed at run-time
[ OK ] Compiler flags honor Fedora defaults or are justified
[ OK ] Package generates useful debuginfo packages
[ -- ] Header files are placed in devel subpackage
[ -- ] Unversioned shared libraries are placed in devel subpackage
[ -- ] Pkgconfig files are placed in devel subpackage
[ -- ] Full-versioned Requires of the base package in subpackages
[ -- ] Package calls ldconfig in post and postun sections for all
subpackages, if applicable
[ -- ] Static libraries are provided by static subpackage
[ OK ] Package contains no static executables unless approved by FESCo
[ OK ] Package does NOT bundle any system libraries
[ OK ] RPath not used for anything besides internal libraries
[ -- ] All config files are marked noreplace or justified otherwise
[ OK ] No config files are located under /usr
[ -- ] Package contains a SystemV-compatible initscript
[ -- ] A GUI application installs a proper desktop file
[ -- ] All desktop files are installed by desktop-file-install or justified
otherwise
[ OK ] Package consistently uses macros
[ -- ] makeinstall macro is used only if make install DESTDIR=%{buildroot}
does NOT work
[ -- ] Macros in Summary and description are expandable at build-time
[ -- ] globals used in place of defines
[ -- ] Locales handled correctly -- package requires gettext and uses
find_lang, if applicable
[ -- ] Scriptlets are sane
[ OK ] Package is not relocatable unless justified
[ OK ] Package contains only acceptable code or content
[ OK ] Package owns all the files and directories it creates, installs and/or
uses unless those are already owned by another package
[ OK ] files sections do NOT contain duplicate files except for licenses
[ OK ] Package does NOT cause any conflicts
[ OK ] Package does NOT contain kernel modules
[ OK ] Package does NOT bundle fonts or other general purpose data
[ OK ] Final Requires and Provides are sane
SHOULD items:
[ OK ] The Summary does NOT end with a period
[ OK ] Package does NOT include BuildRoot tag, clean section or buildroot
removal in install section
[ OK ] Package should preserve files timestamps
[ OK ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio,
diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info,
make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip,
util-linux-ng, which or xz
[ OK ] Description does NOT consist of lines longer than 80 characters
[ OK ] Package uses parallel make
[ -- ] In case of a web application, package installs date into /usr/share
instead of /var/www
[ -- ] All patches have a comment or an upstream bug link
[ -- ] Package installs manpages for all executables
[ OK ] Package contains check section and all tests pass
[ ?? ] Package works as expected
NOTES:
--
Everything seems fine. Approving.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-r
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #2 from Chris Lalancette 2011-07-12 08:30:18 EDT --- OK, we've sorted the license out for this package with the imagefactory. This package will stay as GPLv3 for now, and the imagefactory as ASLv2, which is a valid combination. So we should be good to go with the package review here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #12 from Steve Traylen 2011-07-12 08:31:11 EDT --- (In reply to comment #9) > 2) License > The license should be probably "GPLv2+ or Ruby or MIT" and according to > readme, > there are also some files licensed under the same terms as Perl. > [1] http://www.yoshidam.net/Ruby.html#xmlparser Just to be clear I had not done the full review yet and had not checked the licensing. The licensing is impressively confused in fact. http://www.yoshidam.net/xmlparser_en.txt and the README gives part Ruby or "license of expat" and also bizarrely partly there is a Perl license on encoding.h In addition: xpath.rb is GPLv2+ so this all resolves to License: GPLv2+ and ( Ruby or GPLv2+ ) and ( GPLv2+ or Artistic ) which would definitely need some comments to explain which file is which. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720141] Review Request: python-grapefruit - Python module for color information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720141 Rahul Sundaram changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from Rahul Sundaram 2011-07-12 08:37:32 EDT --- Package Change Request == Package Name: python-grapefruit New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691114] Review Request: python-msgpack - A MessagePack (de)serializer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691114 --- Comment #17 from Jon Ciesla 2011-07-12 08:40:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511155] Review Request: python-dateutil - Extensions to the standard python datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511155 --- Comment #4 from Jon Ciesla 2011-07-12 08:38:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611043] Review Request: python-billiard - Multiprocessing Pool Extensions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611043 --- Comment #13 from Jon Ciesla 2011-07-12 08:39:31 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 189013] Review Request: python-sqlalchemy - Modular and flexible ORM library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=189013 --- Comment #8 from Jon Ciesla 2011-07-12 08:38:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611080] Review Request: python-unittest2 - Backport of new unittest feature for Python 2.7 to Python 2.4+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611080 --- Comment #19 from Jon Ciesla 2011-07-12 08:40:16 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720664 Praveen Kumar changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] New: Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps https://bugzilla.redhat.com/show_bug.cgi?id=720664 Summary: Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kumarpraveen.nit...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Spec URL: http://kumarpraveen.fedorapeople.org/django-threaded-multihost/django-threaded-multihost.spec SRPM URL: http://kumarpraveen.fedorapeople.org/django-threaded-multihost/django-threaded-multihost-1.4-0.fc15.src.rpm Description: django-threaded multihost provides support utilities to enable easy multi-site awareness in Django apps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696485] Review Request: django-countries - Provides a country field for Django models
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696485 --- Comment #8 from Jon Ciesla 2011-07-12 08:41:04 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 611068] Review Request: django-picklefield - Implementation of a pickled object field
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611068 --- Comment #9 from Jon Ciesla 2011-07-12 08:39:57 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720664 pjp changed: What|Removed |Added Status|NEW |ASSIGNED CC||pj.pan...@yahoo.co.in AssignedTo|nob...@fedoraproject.org|pj.pan...@yahoo.co.in -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699335] Review Request: python-coffin - Jinja2 adapter for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699335 --- Comment #9 from Jon Ciesla 2011-07-12 08:41:43 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697492] Review Request: django-keyedcache - Utilities for simplified development of cache aware objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697492 --- Comment #10 from Jon Ciesla 2011-07-12 08:41:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 456009] Review Request: python-jinja2 - General purpose template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456009 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #10 from Rahul Sundaram 2011-07-12 08:44:41 EDT --- Package Change Request == Package Name: python-jinja2 New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 716844] Review Request: django-recaptcha - A Django application for adding ReCAPTCHA to a form
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=716844 Rahul Sundaram changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #17 from Rahul Sundaram 2011-07-12 08:52:59 EDT --- Package Change Request == Package Name: django-recaptcha New Branches: el6 Owners: sundaram pjp InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720254] Review Request: perl-Unicode-Casing - Perl extension to override system case changing functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720254 Petr Pisar changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720254] Review Request: perl-Unicode-Casing - Perl extension to override system case changing functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720254 --- Comment #2 from Petr Pisar 2011-07-12 08:53:40 EDT --- New Package SCM Request === Package Name: perl-Unicode-Casing Short Description: Perl extension to override system case changing functions Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 Lakshmi Narasimhan changed: What|Removed |Added Flag|needinfo? | --- Comment #23 from Lakshmi Narasimhan 2011-07-12 08:57:19 EDT --- Thanks for the clarifications Eric. Ankur, we could leave the .moc folders as it is for the debuginfo package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719108
Paul W. Frields changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Comment #1 from Paul W. Frields 2011-07-12 08:59:42
EDT ---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint rpmbuild/SPECS/drupal6-mobile_tools.spec
rpmbuild/SRPMS/drupal6-mobile_tools-2.3-1.fc15.src.rpm
rpmbuild/RPMS/noarch/drupal6-mobile_tools-2.3-1.fc15.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Note: A copy of LICENSE.txt is added by the packager to correct the old FSF
address in the included LICENSE.txt. Packager should report this issue
upstream, and note the upstream bug URL in a comment so this package can be
updated in the event of a new upstream release that fixes the problem. This is
a minor issue only and should not block the package.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum rpmbuild/SOURCES/drupal6-mobile_tools-2.3/mobile_tools-6.x-2.3.tar.gz
; curl -s -o - http://ftp.drupal.org/files/projects/mobile_tools-6.x-2.3.tar.gz
| md5sum -
0f1bd3c4235f44694436df8fee30da44
rpmbuild/SOURCES/drupal6-mobile_tools-2.3/mobile_tools-6.x-2.3.tar.gz
0f1bd3c4235f44694436df8fee30da44 -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ O K ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ O K ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain code, or permissable content.
[ O K ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtim
[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719108 Paul W. Frields changed: What|Removed |Added CC||sticks...@gmail.com AssignedTo|nob...@fedoraproject.org|sticks...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693950] Review Request: yagf - Graphical front-end for cuneiform
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693950
--- Comment #11 from Ralf Corsepius 2011-07-12 09:02:51
EDT ---
(In reply to comment #10)
> /usr/lib/rpm/find-lang.sh is where it is at.
I don't understand what you are trying to say.
%find_lang as being utilized in *-4 seems to do what it is supposed to:
# cat
/var/lib/mock/fedora-15-x86_64/root/builddir/build/BUILD/yagf-0.8.6-Source/yagf.lang
%lang(de) /usr/share/yagf/translations/yagf_de.qm
%lang(lt) /usr/share/yagf/translations/yagf_lt.qm
%lang(uk) /usr/share/yagf/translations/yagf_uk.qm
%lang(pl) /usr/share/yagf/translations/yagf_pl.qm
%lang(ru) /usr/share/yagf/translations/yagf_ru.qm
One issue, however:
# rpm -qlp yagf-0.8.6-4.fc15.x86_64.rpm
...
/usr/share/yagf
/usr/share/yagf/translations/yagf_de.qm
...
=> /usr/share/yagf/translations/ is unowned.
Please add
%dir %{datadir}/%{name}/translations
to %files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #13 from Vít Ondruch 2011-07-12 09:01:46 EDT --- (In reply to comment #12) Since Expat is MIT licensed, there should be mentioned also MIT, otherwise I agree, the licensing is a mess :/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707002] Review Request: freemedforms - An open Electronic Medical Record Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707002 --- Comment #24 from Ankur Sinha 2011-07-12 09:05:33 EDT --- Yep. I left them in the debuginfo package. I'll push an updated version once the package hits stable. I just want to make sure it's working nicely :) Thanks Eric and Lakshmi :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699697 Paul W. Frields changed: What|Removed |Added CC||sticks...@gmail.com Flag||needinfo?(peter.borsa@gmail ||.com) --- Comment #3 from Paul W. Frields 2011-07-12 09:09:33 EDT --- Fixed LICENSE.txt problem -- the spelling errors can be ignored. http://pfrields.fedorapeople.org/packages/SPECS/drupal6-diff.spec http://pfrields.fedorapeople.org/packages/SRPMS/drupal6-diff-2.1-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 Mark McLoughlin changed: What|Removed |Added Status|NEW |ASSIGNED CC||mar...@redhat.com AssignedTo|nob...@fedoraproject.org|mar...@redhat.com Flag||fedora-review? --- Comment #3 from Mark McLoughlin 2011-07-12 09:12:33 EDT --- Okay, first up ... rpmlint output: python-psphere.spec: W: invalid-url Source0: http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error 500: Internal Server Error 0 packages and 1 specfiles checked; 0 errors, 1 warnings. python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere, spherule python-psphere.noarch: W: no-documentation python-psphere.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 4 warnings. What I think needs fixing: - There is no 0.1 release of psphere yet, so we should either wait for a release or (uggh) get into: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease - We need either a URL for the tarball created by upstream, or no URL at all and instructions on how to regenerate the tarball from a tag. See: http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source - The non-executable-script error can be fixed using a variant of: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries What can be ignored: - Spelling warnings about vSphere, it's correct - no-documentation warning - none is included in the tarball - The licensing change; no need to wait for that, GPLv3 is perfectly fine for inclusion into Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693118 Paul W. Frields changed: What|Removed |Added Flag||needinfo?(stickster@gmail.c ||om) --- Comment #2 from Paul W. Frields 2011-07-12 09:12:41 EDT --- LICENSE.txt problem corrected. The spelling errors can be safely ignored. http://pfrields.fedorapeople.org/packages/SPECS/drupal6-admin_menu.spec http://pfrields.fedorapeople.org/packages/SRPMS/drupal6-admin_menu-1.6-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #4 from Mark McLoughlin 2011-07-12 09:15:01 EDT
---
Okay, some more comments:
- no need for the BuildRoot tag anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
- no need for %clean section anymore
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
- the description should be longer and end with a period. Can just take
the "Welcome" text from the website
- the -n argument to %setup is redundant; you're using the default value
- no need for Prefix tag
- we should own the /usr/lib/python2.7/site-packages/psphere/ directory
- recommendation is to avoid using INSTALLED_FILES
http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
http://fedoraproject.org/wiki/Packaging:Python_Eggs
- use the %{__python} macro
- URL: instead of Url:
- should pass --skip-build argument to setuptools install
- I'd avoid the optimize argument to setuptools install, no reason to
override the default
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #6 from Mark McLoughlin 2011-07-12 09:19:04 EDT --- If you use the new spec, the only thing that you still need is an upstream release - either a released tarball, or a tag in hg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #5 from Mark McLoughlin 2011-07-12 09:17:41 EDT --- Created attachment 512426 --> https://bugzilla.redhat.com/attachment.cgi?id=512426 new spec Here's a new spec with all the comments above resolved if you want to use it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693118 Paul W. Frields changed: What|Removed |Added Flag|needinfo?(stickster@gmail.c |needinfo?(peter.borsa@gmail |om) |.com) --- Comment #3 from Paul W. Frields 2011-07-12 09:18:39 EDT --- Updated to upstream 6.x-1.8 -- sorry, didn't see this earlier. http://pfrields.fedorapeople.org/packages/SPECS/drupal6-admin_menu.spec http://pfrields.fedorapeople.org/packages/SRPMS/drupal6-admin_menu-1.8-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720664 --- Comment #1 from Praveen Kumar 2011-07-12 09:22:46 EDT --- resolved some mistakes Updated spec and srpm SPEC: http://kumarpraveen.fedorapeople.org/django-threaded-multihost/django-threaded-multihost.spec SRPM : http://kumarpraveen.fedorapeople.org/django-threaded-multihost/django-threaded-multihost-1.4.0-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709949 --- Comment #6 from Fedora Update System 2011-07-12 09:25:41 EDT --- ghc-pcre-light-0.4-4.fc15, highlighting-kate-0.2.9-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-pcre-light-0.4-4.fc15,highlighting-kate-0.2.9-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #14 from Ulrich Schwickerath 2011-07-12 09:35:33 EDT --- So, License: GPLv2+ and ( Ruby or GPLv2+ ) and ( GPLv2+ or Artistic ) and MIT + add something in the description ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719108 Peter Borsa changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Peter Borsa 2011-07-12 09:35:32 EDT --- New Package SCM Request === Package Name: drupal6-mobile_tools Short Description: The Mobile Tools module provides some tools to assist in making a site mobile Owners: asrob Branches: f15 el5 el6 InitialCC: pfrields -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709949 --- Comment #7 from Fedora Update System 2011-07-12 09:42:41 EDT --- ghc-pcre-light-0.4-4.fc14, highlighting-kate-0.2.9-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-pcre-light-0.4-4.fc14,highlighting-kate-0.2.9-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #7 from Chris Lalancette 2011-07-12 09:54:03
EDT ---
Thanks for the review, Mark.
(In reply to comment #3)
> Okay, first up ... rpmlint output:
>
> python-psphere.spec: W: invalid-url Source0:
> http://bitbucket.org/jkinred/psphere/get/python-psphere-0.1.tar.gz HTTP Error
> 500: Internal Server Error
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
>
> python-psphere.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere,
> sphere, spherule
> python-psphere.noarch: W: summary-not-capitalized C vSphere SDK for Python
> python-psphere.noarch: W: spelling-error %description -l en_US vSphere -> v
> Sphere, sphere, spherule
> python-psphere.noarch: W: no-documentation
> python-psphere.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/psphere/scripting.py 0644L /usr/bin/env
> 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
>
> What I think needs fixing:
>
> - There is no 0.1 release of psphere yet, so we should either wait for a
> release or (uggh) get into:
>
>
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
This is the nastiest one here. When you run "python setup.py sdist" on the hg
sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the
"Referencing_Source" link below, I feel like we should stick with that version
number, even though there is no official upstream release.
>
> - We need either a URL for the tarball created by upstream, or no
> URL at all and instructions on how to regenerate the tarball from
> a tag. See:
>
> http://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source
Right, fixed this up according to the link above.
>
> - The non-executable-script error can be fixed using a variant of:
>
>
> http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
Stolen from your example SPEC, and fixed.
>
> What can be ignored:
>
> - Spelling warnings about vSphere, it's correct
>
> - no-documentation warning - none is included in the tarball
>
> - The licensing change; no need to wait for that, GPLv3 is perfectly
> fine for inclusion into Fedora
(In reply to comment #4)
> Okay, some more comments:
>
> - no need for the BuildRoot tag anymore
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Removed.
>
> - no need for %clean section anymore
> http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
Removed.
>
> - the description should be longer and end with a period. Can just take
>the "Welcome" text from the website
Fixed.
>
> - the -n argument to %setup is redundant; you're using the default value
Fixed.
>
> - no need for Prefix tag
Removed.
>
> - we should own the /usr/lib/python2.7/site-packages/psphere/ directory
Fixed.
>
> - recommendation is to avoid using INSTALLED_FILES
> http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
> http://fedoraproject.org/wiki/Packaging:Python_Eggs
Fixed.
>
> - use the %{__python} macro
Fixed.
>
> - URL: instead of Url:
Fixed.
>
> - should pass --skip-build argument to setuptools install
Fixed.
>
> - I'd avoid the optimize argument to setuptools install, no reason to
>override the default
Fixed.
I've uploaded a new SPEC:
http://people.redhat.com/clalance/python-psphere/python-psphere.spec and new
SRPM:
http://people.redhat.com/clalance/python-psphere/python-psphere-0.1-4.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693950] Review Request: yagf - Graphical front-end for cuneiform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693950 --- Comment #12 from Volker Fröhlich 2011-07-12 10:12:28 EDT --- Oh, I wanted to point out where the actual script is and how to find out the options, like --with-qt. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #15 from Ulrich Schwickerath 2011-07-12 10:29:15 EDT --- How about ... License: GPLv2+ and ( Ruby or GPLv2+ or MIT ) and ( GPLv2+ or Artistic ) ... %description Ruby bindings to the Expat XML parsing library. For details about the license conditions of individual files in this package please refer to the README. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #16 from Steve Traylen 2011-07-12 10:37:10 EDT --- Look at an example for how to add comments explaining the license, the comment is to describe the License: in the spec file. http://pkgs.fedoraproject.org/gitweb/?p=gridsite.git;a=blob;f=gridsite.spec;h=9ee371d19a1c50cfabe0a2b89c880cc4c6e4df41;hb=HEAD In particular read http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Dual_Licensing_Scenarios -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708535] Review Request: xenserverjava - Java SDK for XenServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708535 Fedora Update System changed: What|Removed |Added Fixed In Version|xenserverjava-5.6.100.1-1.f |xenserverjava-5.6.100.1-1.e |c15 |l6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708535] Review Request: xenserverjava - Java SDK for XenServer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708535 --- Comment #8 from Fedora Update System 2011-07-12 10:56:53 EDT --- xenserverjava-5.6.100.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 --- Comment #15 from Fedora Update System 2011-07-12 11:00:07 EDT --- mmseq-0.9.11-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706565] Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706565 --- Comment #23 from Fedora Update System 2011-07-12 10:58:15 EDT --- sheepdog-0.2.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633063] Review Request: python-txamqp - A Python library for communicating with AMQP peers and brokers using Twisted
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633063 --- Comment #6 from Fedora Update System 2011-07-12 10:59:36 EDT --- python-txamqp-0.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678680] Review Request: transifex-client - Command line tool for Transifex translation management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678680 --- Comment #35 from Fedora Update System 2011-07-12 10:58:00 EDT --- transifex-client-0.5.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678680] Review Request: transifex-client - Command line tool for Transifex translation management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678680 Fedora Update System changed: What|Removed |Added Fixed In Version|transifex-client-0.5.2-1.fc |transifex-client-0.5.2-1.el |15 |6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633063] Review Request: python-txamqp - A Python library for communicating with AMQP peers and brokers using Twisted
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633063 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-txamqp-0.3-1.el6 Resolution||ERRATA Last Closed||2011-07-12 10:59:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 234667] Review Request: dwarves - DWARF Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=234667 Fedora Update System changed: What|Removed |Added Fixed In Version|dwarves-1.9-2.el6 |dwarves-1.9-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706565] Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706565 Fedora Update System changed: What|Removed |Added Fixed In Version|sheepdog-0.2.3-1.fc15 |sheepdog-0.2.3-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mmseq-0.9.11-1.el5 Resolution||ERRATA Last Closed||2011-07-12 11:00:14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 234667] Review Request: dwarves - DWARF Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=234667 --- Comment #30 from Fedora Update System 2011-07-12 11:01:37 EDT --- dwarves-1.9-2.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643140] Review Request: autokey - A desktop automation utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643140 Raghu Udiyar changed: What|Removed |Added CC||rudi...@redhat.com --- Comment #23 from Raghu Udiyar 2011-07-12 11:25:18 EDT --- Sent a message to upstream, to confirm if the licence is GPLv3 or "GPLv3 or later" Once I receive the confirmation, I will rebuild the package in koji and provide the link. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #17 from Ulrich Schwickerath 2011-07-12 11:44:45 EDT --- I've updated the spec file and bumped up the release to 6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 465511] Review Request: itext - A Free Java-PDF library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465511 Jochen Schmitt changed: What|Removed |Added CC||joc...@herr-schmitt.de Flag|fedora-cvs+ |fedora-cvs? --- Comment #19 from Jochen Schmitt 2011-07-12 11:52:47 EDT --- Package Change Request == Package Name: itext New Branches: el5 el6 Owners: s4504kr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 465511] Review Request: itext - A Free Java-PDF library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465511 Jochen Schmitt changed: What|Removed |Added Blocks||720156 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710995] Review Request: kradview - An image viewer oriented to images obtained by X-Ray machines
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710995
--- Comment #6 from Ankur Sinha 2011-07-12 12:03:35
EDT ---
(In reply to comment #5)
> Don't parse "ls". Using the find command is a lot cleaner. Something like:
>
> find . -type f \( -name "*.cpp" -o -name "*.h" -o -name "*.c" -o -name
> "*.xpm"
> \) -exec chmod a-x {} \;
>
find gives me a "too many open files error" at times.
> You're missing the .desktop file and icons though. I'd just chmod the whole
> src
> directory.
Done
>
> Don't install the documentation manually. Use the %doc macro instead (and put
> it first under %files -- that is common). Please visit the RPM documentation
> on
> how to use it.
Done
>
> Ad iconv: Try iconv -f iso-8859-1 -t utf-8 dicomfformat_8c.xml
Done
>
> (Probably put that desktop file comment above the three seds. You might want
> to
> start your comments with either a capital letter or not, but not mix it, but
> that is just a question of style and not necessary for the review.)
Corrected.
http://ankursinha.fedorapeople.org/kradview/kradview-1.1.0-4.fc15.src.rpm
http://ankursinha.fedorapeople.org/kradview/kradview.spec
Thanks!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=716469 Toshio Ernie Kuratomi changed: What|Removed |Added Flag||fedora-review+ --- Comment #6 from Toshio Ernie Kuratomi 2011-07-12 12:08:19 EDT --- Problems noted before have been taken care of. rpmlint warnings are ignorable. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699697
Peter Borsa changed:
What|Removed |Added
Flag|needinfo?(peter.borsa@gmail |fedora-review+, needinfo+
|.com) |
--- Comment #4 from Peter Borsa 2011-07-12 12:28:09 EDT
---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint drupal6-diff.spec ../SRPMS/drupal6-diff-2.1-2.fc15.src.rpm
../RPMS/noarch/drupal6-diff-2.1-2.fc15.noarch.rpm
drupal6-diff.src: W: spelling-error %description -l en_US permissioned ->
permission ed, permission-ed, permission
drupal6-diff.noarch: W: spelling-error %description -l en_US permissioned ->
permission ed, permission-ed, permission
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Note: A copy of LICENSE.txt is added by the packager to correct the old FSF
address in the included LICENSE.txt. Packager should report this issue
upstream, and note the upstream bug URL in a comment so this package can be
updated in the event of a new upstream release that fixes the problem. This is
a minor issue only and should not block the package.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum ../SOURCES/diff-6.x-2.1.tar.gz ; curl -s -o -
http://ftp.drupal.org/files/projects/diff-6.x-2.1.tar.gz | md5sum -
83f3bc87f3e01cb4fbb0d149c22ad9f6 ../SOURCES/diff-6.x-2.1.tar.gz
83f3bc87f3e01cb4fbb0d149c22ad9f6 -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ O K ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ O K ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain code, or permissable content.
[ O K ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quanti
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #8 from Mark McLoughlin 2011-07-12 12:48:01 EDT
---
> %{!?python_sitelib: %global python_sitelib %(python -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib()")}
Not needed anymore:
http://fedoraproject.org/wiki/Packaging:Python#Macros
> %dir %attr(0755, root, root) %{python_sitelib}/psphere
> %{python_sitelib}/psphere/*
A simple:
%{python_sitelib}/psphere/
does the exact same. See:
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717966 --- Comment #9 from Mark McLoughlin 2011-07-12 13:03:07 EDT --- (In reply to comment #7) > (In reply to comment #3) > > - There is no 0.1 release of psphere yet, so we should either wait for a > > release or (uggh) get into: > > > > > > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease > > This is the nastiest one here. When you run "python setup.py sdist" on the hg > sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given the > "Referencing_Source" link below, I feel like we should stick with that version > number, even though there is no official upstream release. Nope, that doesn't cut it - upstream could release 0.1 some time in the future with newer code 0.1 as a version number is meaningless right now - it doesn't refer to a specific version of the code It sounds like you're in good contact with upstream - how about suggesting a release? That might be the simplest way of resolving it? Otherwise, it should be python-vsphere-0.1-0.1.42accc3ffe67hg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719324 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-12 13:07:54 --- Comment #17 from Rex Dieter 2011-07-12 13:07:54 EDT --- imported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719327] Review Request: libksane - SANE Library interface for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719327 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-12 13:08:41 --- Comment #9 from Rex Dieter 2011-07-12 13:08:41 EDT --- imported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719325] Review Request: libkexiv2 - An Exiv2 wrapper library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719325 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-12 13:08:23 --- Comment #14 from Rex Dieter 2011-07-12 13:08:23 EDT --- imported -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720664 pjp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from pjp 2011-07-12 13:21:28 EDT --- Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720664 --- Comment #2 from pjp 2011-07-12 13:20:58 EDT --- [X] Package name - ok. [X] Package group - ok. [X] Package license - ok. [X] Builid successful - ok. [X] rpmlint SRPMS/django-threaded-multihost-1.4-0.fc14.src.rpm django-threaded-multihost.src: W: spelling-error Summary(en_US) multi -> mulch, mufti django-threaded-multihost.src: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - ok. [X] rpmlint RPMS/noarch/django-threaded-multihost-1.4-0.fc14.noarch.rpm django-threaded-multihost.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti django-threaded-multihost.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - ok. [X] Install/Uninstall - ok. Overall good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717966] Review Request: python-psphere - vSphere SDK for Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717966
--- Comment #10 from Chris Lalancette 2011-07-12 13:24:02
EDT ---
(In reply to comment #8)
> > %{!?python_sitelib: %global python_sitelib %(python -c "from
> > distutils.sysconfig import get_python_lib; print get_python_lib()")}
>
> Not needed anymore:
>
> http://fedoraproject.org/wiki/Packaging:Python#Macros
Ah, I had no idea about that one. Fixed.
>
> > %dir %attr(0755, root, root) %{python_sitelib}/psphere
> > %{python_sitelib}/psphere/*
>
> A simple:
>
> %{python_sitelib}/psphere/
And fixed.
(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #3)
> > > - There is no 0.1 release of psphere yet, so we should either wait for a
> > > release or (uggh) get into:
> > >
> > >
> > > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
> >
> > This is the nastiest one here. When you run "python setup.py sdist" on the
> > hg
> > sources, you get a tarball out that is named "psphere-0.1.tar.gz". Given
> > the
> > "Referencing_Source" link below, I feel like we should stick with that
> > version
> > number, even though there is no official upstream release.
>
> Nope, that doesn't cut it - upstream could release 0.1 some time in the future
> with newer code
>
> 0.1 as a version number is meaningless right now - it doesn't refer to a
> specific version of the code
>
> It sounds like you're in good contact with upstream - how about suggesting a
> release? That might be the simplest way of resolving it?
>
> Otherwise, it should be python-vsphere-0.1-0.1.42accc3ffe67hg
I've written to the upstream maintainer, I'll wait on his reply.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693118
Peter Borsa changed:
What|Removed |Added
Flag|needinfo?(peter.borsa@gmail |fedora-review+, needinfo+
|.com) |
--- Comment #4 from Peter Borsa 2011-07-12 13:31:39 EDT
---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint drupal6-admin_menu.spec
../SRPMS/drupal6-admin_menu-1.8-1.fc15.src.rpm
../RPMS/noarch/drupal6-admin_menu-1.8-1.fc15.noarch.rpm
drupal6-admin_menu.src: W: spelling-error %description -l en_US Devel -> Revel,
Level, Bevel
drupal6-admin_menu.noarch: W: spelling-error %description -l en_US Devel ->
Revel, Level, Bevel
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Note: A copy of LICENSE.txt is added by the packager to correct the old FSF
address in the included LICENSE.txt. Packager should report this issue
upstream, and note the upstream bug URL in a comment so this package can be
updated in the event of a new upstream release that fixes the problem. This is
a minor issue only and should not block the package.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum ../SOURCES/admin_menu-6.x-1.8.tar.gz ; curl -s -o -
http://ftp.drupal.org/files/projects/admin_menu-6.x-1.8.tar.gz | md5sum -
abd97546f7382c325de3a5fa8dc8d83f ../SOURCES/admin_menu-6.x-1.8.tar.gz
abd97546f7382c325de3a5fa8dc8d83f -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ O K ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ O K ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain code, or permissable content.
[ O K ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[
[Bug 720447] Review Request: python-unidecode - US-ASCII transliterations of Unicode text
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720447 --- Comment #2 from pjp 2011-07-12 13:32:42 EDT --- I've made the changes. Please see the files below: SPEC: http://pjp.dgplug.org/tools/python-unidecode.spec SRPM: http://pjp.dgplug.org/tools/python-unidecode-0.04.7-2.fc14.src.rpm Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
