[Bug 716700] Review Request: perl-FusionInventory-Agent-Task-OcsDeploy - OCS Inventory NG Software deployment support for FusionInventory Agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=716700 --- Comment #1 from Remi Collet 2011-08-06 03:19:17 EDT --- Adapt filter for fedora 16 https://github.com/remicollet/remirepo/commit/aaa022af9f06b100bb3dfc2c05502b4ea128f55d SRPM: http://rpms.famillecollet.com/SRPMS/perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.remi.src.rpm Kohi scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=3255855 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714327] Review Request: libtpcimgio - Turku PET Centre for image file input and output procedures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714327 --- Comment #9 from Fedora Update System 2011-08-06 03:36:08 EDT --- libtpcimgio-1.5.10-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714327] Review Request: libtpcimgio - Turku PET Centre for image file input and output procedures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714327 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714327] Review Request: libtpcimgio - Turku PET Centre for image file input and output procedures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714327 --- Comment #10 from Fedora Update System 2011-08-06 03:36:16 EDT --- libtpcimgio-1.5.10-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714327] Review Request: libtpcimgio - Turku PET Centre for image file input and output procedures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714327 --- Comment #11 from Fedora Update System 2011-08-06 03:36:24 EDT --- libtpcimgio-1.5.10-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libtpcimgio-1.5.10-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728662] New: Review Request: python-pylibmc - Memcached client for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-pylibmc - Memcached client for Python https://bugzilla.redhat.com/show_bug.cgi?id=728662 Summary: Review Request: python-pylibmc - Memcached client for Python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kumarpraveen.nit...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://kumarpraveen.fedorapeople.org/pylibmc/python-pylibmc.spec SRPM URL: http://kumarpraveen.fedorapeople.org/pylibmc/python-pylibmc-1.2.0-1.20110805gitf01c31.fc15.src.rpm Description: pylibmc is a client in Python for memcached. It is a wrapper around TangentOrg‘s libmemcached library. The interface is intentionally made as close to python-memcached as possible, so that applications can drop-in replace it. Koji Buid : http://koji.fedoraproject.org/koji/taskinfo?taskID=3255889 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728662] Review Request: python-pylibmc - Memcached client for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728662 Praveen Kumar changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728403] Review Request: libepc - Easy Publish and Consume library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728403 --- Comment #2 from Haïkel Guémar 2011-08-06 04:06:09 EDT --- @remi: thank you for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728403] Review Request: libepc - Easy Publish and Consume library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728403 Haïkel Guémar changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Haïkel Guémar 2011-08-06 04:07:07 EDT --- Package Change Request == Package Name: libepc New Branches: f16 Owners: hguemar InitialCC: This package was deprecated, following our deprecated package ownership claim policy, i announced my intention on the mailing-list, and made libepc re-reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728664] New: Review Request: django-pylibmc - Django cache backend using pylibmc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-pylibmc - Django cache backend using pylibmc https://bugzilla.redhat.com/show_bug.cgi?id=728664 Summary: Review Request: django-pylibmc - Django cache backend using pylibmc Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kumarpraveen.nit...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc.spec SRPM URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc-0.2.1-1.20110806gitb56e74.fc15.src.rpm Description: Django-pylibmc package provides a memcached cache backend for Django using pylibmc. You want to use pylibmc because it's fast. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728662] Review Request: python-pylibmc - Memcached client for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728662 Praveen Kumar changed: What|Removed |Added Depends on||728664 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728664 Praveen Kumar changed: What|Removed |Added Blocks||728662 Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707617] Review Request: libircclient-qt - Cross-platform IRC client library written with Qt 4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707617 Michael Schwendt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Michael Schwendt 2011-08-06 06:58:56 EDT --- APPROVED Except for one thing the rpmdev-diff output reveals: -%post -p /sbin/ldconfig +%post -p /bin/echo +1 -%postun -p /sbin/ldconfig +%postun -p /bin/echo +1 Probably you've tested something there, but it makes no sense to keep that change. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723326] Review Request: dolibarr - ERP & CRM for small companies, freelances or foundations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=723326
--- Comment #2 from Remi Collet 2011-08-06 08:22:02
EDT ---
First comments
Don't define name, version, release (Name, Version and Release directives are
enough)
Release must include %{?dist}
For readilibilty clean the spec of all non-fedora stuff
Requiring mysql-server is probably a bad idea (you can install the web-app on a
server and the DB on another)
Most stuff in %post should go to %install (and %file)
Most stuff in %postun should be obsoleted by previous comment
Don't create /usr/share/doc/dolibar.
Use %doc
File will be added to /usr/share/doc/dolibar-3.1.0 which is the standard
default location.
Lang file must be tag as lang file.
You must not bundle library (artichow, tcpdf, ..) but use system ones (and
submit new packages if not available).
Use desktop-file-install to install .desktop (not install)
Please confirm the requires PHP extensions / version required (phpci reports
php 5.3.0 and lot extensions, probably some "false/positive" due to embedded
libraries)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] New: Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-registration - A user-registration application for Django https://bugzilla.redhat.com/show_bug.cgi?id=728691 Summary: Review Request: django-registration - A user-registration application for Django Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kumarpraveen.nit...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://kumarpraveen.fedorapeople.org/registration/django-registration.spec SRPM URL: http://kumarpraveen.fedorapeople.org/registration/django-registration-0.7-1.fc15.src.rpm Description: This is a fairly simple user-registration application for Django_, designed to make allowing user signups as painless as possible. It requires a functional installation of Django 1.0 or newer, but has no other dependencies. Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3256067 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Praveen Kumar changed: What|Removed |Added CC||michel+...@sylvestre.me --- Comment #1 from Praveen Kumar 2011-08-06 08:49:30 EDT --- *** Bug 526100 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Praveen Kumar changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526100] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526100 Praveen Kumar changed: What|Removed |Added CC||kumarpraveen.nitdgp@gmail.c ||om Resolution|NOTABUG |DUPLICATE --- Comment #7 from Praveen Kumar 2011-08-06 08:49:30 EDT --- *** This bug has been marked as a duplicate of bug 728691 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728178] Review Request: xfce4-wmdock-plugin - Compatibility layer for running dockapps in an Xfce panel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728178
--- Comment #2 from Mario Blättermann 2011-08-06 09:31:43
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3256082
$ rpmlint -i -v *
xfce4-wmdock-plugin.i686: I: checking
xfce4-wmdock-plugin.i686: W: spelling-error Summary(en_US) dockapps -> dock
apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.i686: W: spelling-error %description -l en_US dockapps ->
dock apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.i686: I: checking-url
http://goodies.xfce.org/projects/panel-plugins/xfce4-wmdock-plugin (timeout 10
seconds)
xfce4-wmdock-plugin.src: I: checking
xfce4-wmdock-plugin.src: W: spelling-error Summary(en_US) dockapps -> dock
apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.src: W: spelling-error %description -l en_US dockapps ->
dock apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.src: I: checking-url
http://goodies.xfce.org/projects/panel-plugins/xfce4-wmdock-plugin (timeout 10
seconds)
xfce4-wmdock-plugin.src: I: checking-url
http://archive.xfce.org/src/panel-plugins/xfce4-wmdock-plugin/0.3/xfce4-wmdock-plugin-0.3.4.tar.bz2
(timeout 10 seconds)
xfce4-wmdock-plugin.x86_64: I: checking
xfce4-wmdock-plugin.x86_64: W: spelling-error Summary(en_US) dockapps -> dock
apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.x86_64: W: spelling-error %description -l en_US dockapps ->
dock apps, dock-apps, paddocks
The value of this tag appears to be misspelled. Please double-check.
xfce4-wmdock-plugin.x86_64: I: checking-url
http://goodies.xfce.org/projects/panel-plugins/xfce4-wmdock-plugin (timeout 10
seconds)
xfce4-wmdock-plugin-debuginfo.i686: I: checking
xfce4-wmdock-plugin-debuginfo.i686: I: checking-url
http://goodies.xfce.org/projects/panel-plugins/xfce4-wmdock-plugin (timeout 10
seconds)
xfce4-wmdock-plugin-debuginfo.x86_64: I: checking
xfce4-wmdock-plugin-debuginfo.x86_64: I: checking-url
http://goodies.xfce.org/projects/panel-plugins/xfce4-wmdock-plugin (timeout 10
seconds)
xfce4-wmdock-plugin.spec: I: checking-url
http://archive.xfce.org/src/panel-plugins/xfce4-wmdock-plugin/0.3/xfce4-wmdock-plugin-0.3.4.tar.bz2
(timeout 10 seconds)
5 packages and 1 specfiles checked; 0 errors, 6 warnings.
Common ignorable spelling errors... No real issues so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+ according to COPYING and source file headers
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
b7e7f90add968dd71efd8d1b026b4373 xfce4-wmdock-plugin-0.3.4.tar.bz2
b7e7f90add968dd71efd8d1b026b4373
xfce4-wmdock-plugin-0.3.4.tar.bz2.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large do
[Bug 726080] Review Request: Xnee - X11 environment recorder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726080 --- Comment #7 from Matthieu Saulnier 2011-08-06 10:02:17 EDT --- Hello, (In reply to comment #6) > Some comments: > 1) xnee doesn't really requires cnee to work. You should remove the Requires > on > cnee for the main package xnee. Removed > 2) Without any header, libxnee-devel would be useless. Added > 3) Neither cnee nor xnee depend on GTK+ 1. So gtk+-devel as BR is useless. Removed > 4) If you don't call the "--enable-static-programs=no" option to ./configure, > your binaries will still be linked statically to libxnee. Enable this option > and your Requires on libxnee will be really useful. Notice that you may expect > some rpath issues. The guidelines may help you in such a case. Done Files are updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728178] Review Request: xfce4-wmdock-plugin - Compatibility layer for running dockapps in an Xfce panel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728178
--- Comment #3 from Martin Gieseking 2011-08-06
10:23:16 EDT ---
Mario, thank you for the review!
(In reply to comment #2)
> I'm unsure if desktop-file-install is needed here. Anyway, we have a
> *.desktop file, but other plugins for Xfce don't even have the
> desktop-file-install scriptlet. No idea what to do here.
Unfortunately, desktop-file-validate and desktop-file-install don't like Xfce
desktop files, i.e. they report errors although the file variants conform the
.desktop file specification. Thus, rpmbuild would fail spuriously if
desktop-file-FOO were called.
Additionally, xfce4-wmdock-plugin isn't a GUI application. Therefore it doesn't
provide a "valid" .desktop file in %{_datadir}/applications/ and doesn't create
a menu entry. I think the Xfce desktop files must be handled differently
compared to those of GUI apps. After having a quick look at several specs of
other Xfce plugins, this seems to be the common practice.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Arun SAG changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|saga...@gmail.com --- Comment #2 from Arun SAG 2011-08-06 10:30:49 EDT --- I will do the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Arun SAG changed: What|Removed |Added Status|NEW |ASSIGNED CC||saga...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 --- Comment #3 from Arun SAG 2011-08-06 10:33:16 EDT --- I see, you have taken the SPEC file from https://bugzilla.redhat.com/show_bug.cgi?id=526100 , It would be nice to credit the original author in the Changelog section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728701] New: Review Request: libalkimia - Financial library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libalkimia - Financial library https://bugzilla.redhat.com/show_bug.cgi?id=728701 Summary: Review Request: libalkimia - Financial library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rdie...@math.unl.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://rdieter.fedorapeople.org/rpms/libalkimia/libalkimia.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/libalkimia/libalkimia-4.3.1-1.fc14.src.rpm Description: Financial library This is required by newer versions of kmymoney -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728701] Review Request: libalkimia - Financial library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728701 Rex Dieter changed: What|Removed |Added Blocks||656997(kde-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 --- Comment #4 from Praveen Kumar 2011-08-06 10:51:16 EDT --- ok sure, done. Didn't bump the release. Spec URL: http://kumarpraveen.fedorapeople.org/registration/django-registration.spec SRPM URL: http://kumarpraveen.fedorapeople.org/registration/django-registration-0.7-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680174 --- Comment #9 from Fedora Update System 2011-08-06 11:08:30 EDT --- herqq-1.0.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/herqq-1.0.0-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680174 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644711] Review Request: diaser - disk based backup volume accumulator, replication and management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #34 from Fedora Update System 2011-08-06 11:37:35 EDT --- diaser-1.1.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/diaser-1.1.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 727646] Review Request: link-grammar - A Grammar Checking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727646 --- Comment #4 from Niels de Vos 2011-08-06 11:47:02 EDT --- I'm also not very interested in this package, but use abiword on occasion. Feel free to add me as a co-maintainer and I'll try to jump in if there are any issues with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644711] Review Request: diaser - disk based backup volume accumulator, replication and management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #35 from Fedora Update System 2011-08-06 11:47:07 EDT --- diaser-1.1.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/diaser-1.1.0-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com --- Comment #5 from Rahul Sundaram 2011-08-06 11:55:10 EDT --- You can't have two changelog entries with the same release number. Bump up the release everytime you do the change. Always -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644711] Review Request: diaser - disk based backup volume accumulator, replication and management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #36 from Damian L Brasher 2011-08-06 12:01:01 EDT --- master was built - there may have been a mid-air bugzilla collision as I submitted notes diaser-1.1.0-3.fc17 in Koji. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728691] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 --- Comment #6 from Praveen Kumar 2011-08-06 12:06:01 EDT --- ok, Thanks for pointing out. Spec URL: http://kumarpraveen.fedorapeople.org/registration/django-registration.spec SRPM URL: http://kumarpraveen.fedorapeople.org/registration/django-registration-0.7-2.fc15.src.rpm koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3256202 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657397] Review Request: sbackup - Simple Backup Suite for desktop use
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657397 Frank Danapfel changed: What|Removed |Added CC||fdana...@redhat.com --- Comment #12 from Frank Danapfel 2011-08-06 12:16:37 EDT --- I just tested sbackup-0.11.3-1 on Fedora 15, and it works almost without problems. The only small problem I found was that I could not start simple-backup-config as a regular user, I always got a dialog box with the message "The exec() call failed" after entering the root password. Starting sbackup-config-gtk directly as root worked without problems. After some investigation I found out that /etc/security/console.apps/simple-backup-config contains the line "PROGRAM=/usr/sbin/simple-backup-config" which is wrong. After changing the line to "PROGRAM=/usr/bin/sbackup-config-gtk" running simple-backup-config as a normal user to bring up sbackup-config-gtk works without error. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728722] Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728722 Rex Dieter changed: What|Removed |Added Blocks||656997(kde-reviews) Alias||ntrack -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728701] Review Request: libalkimia - Financial library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728701 Rex Dieter changed: What|Removed |Added Alias||libalkimia -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728722] New: Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications https://bugzilla.redhat.com/show_bug.cgi?id=728722 Summary: Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rdie...@math.unl.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://rdieter.fedorapeople.org/rpms/ntrack/ntrack.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/ntrack/ntrack-014-1.fc15.src.rpm Description: ntrack aims to be a lightweight and easy to use library for application developers that want to get events on network online status changes such as online, offline or route changes. The primary goal is to serve desktop applications in a network manager and desktop environment independent fashion. Also its supposed to be lightweight, resource un-intensive and extensible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728178] Review Request: xfce4-wmdock-plugin - Compatibility layer for running dockapps in an Xfce panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728178 Mario Blättermann changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Mario Blättermann 2011-08-06 15:13:37 EDT --- OK, that's what I thought anyway. PACKAGE APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728649] Review Request: airrac - C++ Simulated Revenue Accounting (RAC) System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728649 Denis Arnaud changed: What|Removed |Added Depends on||702987 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702987] Review Request: stdair - C++ Standard Airline IT Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702987 Denis Arnaud changed: What|Removed |Added Blocks||728649 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728737] New: Review Request: libinstpatch - MIDI instrument patch library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libinstpatch - MIDI instrument patch library https://bugzilla.redhat.com/show_bug.cgi?id=728737 Summary: Review Request: libinstpatch - MIDI instrument patch library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: oget.fed...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://oget.fedorapeople.org/review/libinstpatch.spec SRPM URL: http://oget.fedorapeople.org/review/libinstpatch-1.0.0-1.20110806svn386.fc15.src.rpm Description: libInstPatch stands for lib-Instrument-Patch and is a library for processing digital sample based MIDI instrument "patch" files. The types of files libInstPatch supports are used for creating instrument sounds for wavetable synthesis. libInstPatch provides an object framework (based on GObject) to load patch files into, which can then be edited, converted, compressed and saved. --- We need this package so that we can update our swami (based on gtk1) package to swami-2 (based on gtk2). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728737] Review Request: libinstpatch - MIDI instrument patch library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728737 --- Comment #1 from Orcan Ogetbil 2011-08-06 16:06:56 EDT --- Sorry, the correct SRPM link should be: SRPM URL: http://oget.fedorapeople.org/review/libinstpatch-1.0.0-2.20110806svn386.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728722] Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728722 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #1 from Kevin Kofler 2011-08-06 16:12:36 EDT --- Uhm, do we need this? Last I checked, this is only needed for systems which do not use NetworkManager… -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728403] Review Request: libepc - Easy Publish and Consume library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728403 --- Comment #4 from Jon Ciesla 2011-08-06 16:22:08 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 727646] Review Request: link-grammar - A Grammar Checking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727646 --- Comment #5 from Jon Ciesla 2011-08-06 16:25:13 EDT --- I've unretired the package. It's still owned by uwog in f15 and f14. Please take ownership of devel in pkgdb, and submit a Package Change request for an f16 branch. If you want ownership of the f15 and f14 branches, either have uwog release them or we can do that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728722] Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728722 Rex Dieter changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Last Closed||2011-08-06 16:49:57 --- Comment #2 from Rex Dieter 2011-08-06 16:49:57 EDT --- Oh rats, I bet you're right. I just blindly jumped in to package this after someone in #kde-devel was asking about it for fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728275] Review Request: perl-Data-Section-Simple - Read data from __DATA__
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728275 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mari...@freenet.de AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? --- Comment #1 from Mario Blättermann 2011-08-06 17:06:14 EDT --- Koji scratch build for f15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3256364 $ rpmlint -i -v *rpm perl-Data-Section-Simple.noarch: I: checking perl-Data-Section-Simple.noarch: I: checking-url http://search.cpan.org/dist/Data-Section-Simple/ (timeout 10 seconds) perl-Data-Section-Simple.src: I: checking perl-Data-Section-Simple.src: I: checking-url http://search.cpan.org/dist/Data-Section-Simple/ (timeout 10 seconds) perl-Data-Section-Simple.src: I: checking-url http://search.cpan.org/CPAN/authors/id/M/MI/MIYAGAWA/Data-Section-Simple-0.02.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 0 warnings. No issues so far. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728722] Review Request: ntrack - Network Connectivity Tracking library for Desktop Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728722 --- Comment #3 from Kevin Kofler 2011-08-06 17:15:19 EDT --- Well, they may have different plans for the future, but currently, it's only used in solid-networkstatus as an optional alternative to the NM backend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728275] Review Request: perl-Data-Section-Simple - Read data from __DATA__
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728275
--- Comment #2 from Mario Blättermann 2011-08-06 17:17:51
EDT ---
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
730256f8dcfdd3fb6f3b522aa58e9188 Data-Section-Simple-0.02.tar.gz
730256f8dcfdd3fb6f3b522aa58e9188 Data-Section-Simple-0.02.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[X] MUST: A package must own all directories that it creates.
Is it intended that your package owns the folder
/usr/share/perl5/vendor_perl/Data ?
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728275] Review Request: perl-Data-Section-Simple - Read data from __DATA__
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728275
--- Comment #3 from Paul Howarth 2011-08-06 17:25:25 EDT ---
(In reply to comment #2)
> [X] MUST: A package must own all directories that it creates.
> Is it intended that your package owns the folder
> /usr/share/perl5/vendor_perl/Data ?
Yes, this is standard practice for perl modules; modules named perl-XXX-YYY
will generally own the /usr/share/perl5/vendor_perl/XXX (noarch packages) or
%{_libdir}/perl5/vendor_perl/XXX (arch-specific packages) directory.
See: http://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720857] Review Request: datalog - A Lightweight Deductive Database using Datalog
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720857 --- Comment #5 from John D. Ramsdell 2011-08-06 17:48:45 EDT --- (In reply to comment #4) > John, is this your first Fedora package submission? My first package submission is: https://bugzilla.redhat.com/show_bug.cgi?id=683127 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720857] Review Request: datalog - A Lightweight Deductive Database using Datalog
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720857 --- Comment #6 from John D. Ramsdell 2011-08-06 17:58:37 EDT --- (In reply to comment #4) > - Fedora usually avoids providing static libraries. If there's no way to > build a shared library for this package, see the following page how to > handle the static one: > > https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries I have fixed all of the problems you identified but the static library issue. I have to think carefully about fixing this problem as I realize I should be linking against Fedora's liblua shared library, and not use the version of lua included in the package. This change will require a new source release. I also need to find the autoconf script used to find installed versions of Lua 5.1 and make sure Lua 5.0 is not found. The trouble is, Debian seems to want to call the package I need liblua51, not liblua. I'm working the problem. John -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709180] Review Request: jackctlmmc - control JACK transport via MIDI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709180 Orcan Ogetbil changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Orcan Ogetbil 2011-08-06 19:02:47 EDT --- Thanks Brendan, this is good to go - This package (jackctlmmc) is APPROVED by oget - Brendan, Martin, could you guys take a look at this review request if/when you get time? bug# 728737 ? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 726131] Review Request: yourls - your own url shortening service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726131 --- Comment #7 from Nathan Owe 2011-08-06 23:52:40 EDT --- @Martin: Sorry for the bit of disagreement. Some people that reviewed my packages recommend listing more files in some cases and others the opposite. Do as Michael has suggested, he has done this longer than I have. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537727] Review Request: Slack - A lazy systems administration configuration management toolkit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537727 Nathan Owe changed: What|Removed |Added CC||ndowen...@gmail.com --- Comment #8 from Nathan Owe 2011-08-07 00:36:49 EDT --- I would probably close this bug. Upstream activity is low, the latest version was released in 2008. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 727646] Review Request: link-grammar - A Grammar Checking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727646 hannes changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from hannes 2011-08-07 01:18:33 EDT --- Package Change Request == Package Name: link-grammar New Branches: f16 Owners: hannes devos fabiand InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
