[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769029
T.C. Hollingsworth tchollingswo...@gmail.com changed:
What|Removed |Added
CC||tchollingswo...@gmail.com
--- Comment #2 from T.C. Hollingsworth tchollingswo...@gmail.com 2011-12-21
03:13:45 EST ---
Just an informal review...
(In reply to comment #0)
rpmlint output:
rpmlint oxygen-gtk3.spec oxygen-gtk3-1.2.0-0.1.20111219.fc16.src.rpm
oxygen-gtk3.spec:13: W: macro-in-comment %{version}
oxygen-gtk3.spec:13: W: macro-in-comment %{version}
oxygen-gtk3.spec:13: W: macro-in-comment %{snap}
oxygen-gtk3.src:13: W: macro-in-comment %{version}
oxygen-gtk3.src:13: W: macro-in-comment %{version}
oxygen-gtk3.src:13: W: macro-in-comment %{snap}
Please escape RPM macros in comments like %%{version}.
Other than that, the packaging looks good, it builds fine, and works great!
Thanks a lot; I've been hoping to see this for awhile.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715581] Review Request: sonatype-forge-parent - Sonatype forge parent POM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715581 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED Last Closed||2011-12-21 03:50:28 --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com 2011-12-21 03:50:28 EST --- Even I forgot why I put this up for review. I might come back to it... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769002] Review Request: sugar-toolkit-gtk3 - the Sugar toolkit for gtk3
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769002
--- Comment #3 from Simon Schampijer si...@schampijer.de 2011-12-21 03:53:43
EST ---
Ok, the 'incorrect-fsf-address' was new to me. The address seem to be wrong in
all of the files of the sugar-toolkit, not just the ones that rpmlint reports.
Looking at FilesCheck.py in rpmlint the detecting of this error is not as
robust. The reg expression fsf_license_regex =
re.compile('(GNU((\s+(Library|Lesser|Affero))?(\s+General)?\s+Public|\s+Free\s+Documentation)\s+Licen[cs]e|(GP|FD)L)',
re.IGNORECASE) does not handle newlines and it seems to be very common that
GNU Lesser General Public License is not written on one line (maybe that is
one of the reasons why many sources still have the old address?).
Besides that: so the policy is to update all of the sources to the new address
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759758] Review Request: perl-Encode-HanExtra - Extra sets of Chinese encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759758 --- Comment #4 from Xavier Bachelot xav...@bachelot.org 2011-12-21 04:25:35 EST --- oops, I shouldn't do this sort of stuff too late at night. Sorry about that. Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-3.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #39 from Vít Ondruch vondr...@redhat.com 2011-12-21 04:51:56 EST --- (In reply to comment #38) Vít, I'd like to sponsor Ulrich as I know he knows what he is doing but while my packaging is generally good my ruby is less so. This package looks almost good to me but if you have further comment I would be grateful, this turns out to be a non-trivial ruby package. The alternative is I release this as being assigned to me. Steve. Problems I still see however: (1) Requires: ruby-libs is almost certainly not needed and is you get anyway from both libruby.so.1.8()(64bit) ruby(abi) = 1.8 the first one of which in particular is autogenerate, basically you should not added which is determined automatically anyway. Actaully the 'ruby-libs' should be replaced with 'ruby', as is stated in Ruby packaging guidelines. (2) The fact the package contains the origional gem seems bad. /usr/lib/ruby/gems/1.8/cache/xmlparser-0.6.81.gem it should not. Although there is a lot of gems which keeps the original gem in the RPM and it is not against packaging guidelines, I also recommend to use %exclude for the cached gem. Otherwise I am fine with the package. Feel free to approve it and sponsor Ulrich any time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768989 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2011-12-21 04:51:45 EST --- New Package SCM Request === Package Name: geronimo-jaspic-spec Short Description: Java Authentication SPI for Containers Owners: sochotni Branches: InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769012] Review Request: jetty-distribution-remote-resources - Jetty toolchain artifact for distribution remote resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769012 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2011-12-21 04:54:48 EST --- New Package SCM Request === Package Name: jetty-distribution-remote-resources Short Description: Jetty toolchain artifact for distribution remote resources Owners: sochotni Branches: InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756636 --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:11:32 EST --- any updates here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755054] Review Request: gnome-font-viewer - Utility for previewing fonts for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755054 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:11:57 EST --- any updates here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: CSSLint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:11:45 EST --- any updates here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769173] Review Request: english-typing booster - typing booster for english language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769173 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753676] Review Request: gnome-shell-extention-netspeed -an internet speed indicator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753676 --- Comment #11 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:13:13 EST --- any updates? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753855] Review Request: pslib - C-library to create PostScript files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753855 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728837] Review Request: python-xml2dict - Use attributes of dictionary to access xml elements.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728837 --- Comment #14 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:19:15 EST --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 748329] Review Request: ibus-panel-extensions - Additional UI service components for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=748329 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:16:25 EST --- ah! looks like I forgot this to review Looking at SPEC looks ok. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728823] Review Request: django-tinymce - TinyMCE form field editor for Django applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728823 --- Comment #16 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:20:13 EST --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700352] Review Request: perl-DublinCore-Record - Container for Dublin Core metadata elements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700352 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:22:17 EST --- Can you build the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728826] Review Request: wadofstuff-django-serializers - Extended Django Serializer Module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728826 --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:20:09 EST --- Can you request for SCM? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700344] Review Request: perl-Authen-CAS-Client - Interface for authentication via JA-SIG's Central Authentication Service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700344 --- Comment #11 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:22:22 EST --- Can you build the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700354] Review Request: perl-Locale-Currency-Format - Perl functions for formatting monetary values
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700354 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:22:10 EST --- Can you build the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722829] Review Request: python-bottle-sqlite - SQLite3 integration for Bottle Python WSGI framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722829 --- Comment #6 from Parag AN(पराग) panem...@gmail.com 2011-12-21 05:21:23 EST --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753676] Review Request: gnome-shell-extention-netspeed -an internet speed indicator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753676 --- Comment #12 from Amir Hedayaty heday...@gmail.com 2011-12-21 05:29:21 EST --- Again sorry, this is embarrassing. I have also submitted this extension to gnome, they have requested a few corrections which I am also applying them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769029 --- Comment #3 from nucleo alekc...@googlemail.com 2011-12-21 05:59:37 EST --- Thanks. I will fix comments with next snapshot or remove them if package will be reviewed when oxygen-gtk3-1.2.0 released (then snapshot comments will be not needed). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768989 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2011-12-21 06:07:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769012] Review Request: jetty-distribution-remote-resources - Jetty toolchain artifact for distribution remote resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769012 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2011-12-21 06:08:11 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756635] Review Request: gap - Computational discrete algebra
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756635 Scott Tsai scottt...@gmail.com changed: What|Removed |Added CC||scottt...@gmail.com AssignedTo|nob...@fedoraproject.org|scottt...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760033] Review Request: kde-plasma-publictransport - Public Transport plasma applet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760033
--- Comment #7 from Gregor Tätzner gre...@freenet.de 2011-12-21 06:18:19 EST
---
Spec URL: http://brummbq.fedorapeople.org/kde-plasma-publictransport.spec
SRPM Url:
http://brummbq.fedorapeople.org/kde-plasma-publictransport-0.10-0.2.20111204git.fc16.src.rpm
Thank you for your feedback.
(In reply to comment #6)
Release:%{snapshot}%{?dist}.1
should be:
Release:0.1.%{snapshot}%{?dist}
The next builds should then be 0.2.%{snapshot}%{?dist},
0.3.%{snapshot}%{?dist}
etc.
done
BuildRequires are global, so I'd list them all together at the beginning (but
putting them where you put them works, too).
done
#remove executable bit
chmod 644
%{buildroot}/%{_kde4_datadir}/applications/kde4/timetablemate.desktop
Not sure about that one… We don't normally do this, i.e. we keep the +x bit
upstream sets, but some non-KDE folks want us to do what you did everywhere.
In
practice, it will work either way because KDE Plasma does not require the +x
bit in the standard prefix.
So, I'll leave it as it is. Otherwise rpmlint is complaining.
You put the icon scriptlets into the main package and the actual icons
into -libs. They should be in the same package. (IMHO in the main package.
Those icons shouldn't be multilibbed.)
The problem is, in libs subpackage are also icons for timetablemate included.
This means I can't move them all together into the main package because
timetable doesn't need the rest of the main package. Well, and I was too lazy
to split up the icons suitably :) (Probably I would make horrible mistakes)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769444] Review Request: korundum - Ruby bindings for KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769444 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com Flag||fedora-review? --- Comment #2 from Bohuslav Kabrda bkab...@redhat.com 2011-12-21 06:48:41 EST --- I'm taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769444] Review Request: korundum - Ruby bindings for KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769444 --- Comment #3 from Bohuslav Kabrda bkab...@redhat.com 2011-12-21 07:30:20 EST --- - According to ruby naming guidelines [1], the name should be ruby-korundum. - License should be GPLv2+ and LGPLv2+: [bkabrda@localhost BUILD]$ licensecheck -r korundum-4.7.90/ | grep LGPL korundum-4.7.90/tools/rbkconfig_compiler/rbkconfig_compiler.cpp: LGPL (v2 or later) korundum-4.7.90/modules/akonadi/examples/akonamail/mainwidget.rb: LGPL (v2 or later) (also, see COPYING and COPYING.LIB, where GPLv2+, resp. LGPLv2+ are mentioned). - All the imports work only when you first require 'Qt', otherwise they throw NameError: uninitialized constant QtWebKit::Internal::Qt and similar. Because there is not much documentation available, I'm not sure if it should be that way or if it is bug. Could you please clarify this? - Also, one minority: Url should be uppercase, so URL :) - Otherwise, the package looks good, so when you correct these things, I think it will be ok. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Naming_Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Marcela Mašláňová mmasl...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] New: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools https://bugzilla.redhat.com/show_bug.cgi?id=769609 Summary: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mb...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data.spec SRPM URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data-0.0.1-1.fc17.src.rpm Description: thin-provisioning-tools contains dump,restore and repair tools to manage device-mapper thin provisioning target metadata devices. Notes: - package will later contain tools for another targets (like hierarchical storage management) that's why there is such generic name. - rpmlint E: description-line-too-long C This package provides debug information for package device-mapper-persistent-data. - filled bug #768393 - upstream tar location will perhaps change in future (removing URL warning) and will include pre-generated autoconf files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756435] Review Request: pytorctl - Python bindings for controlling the Tor router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756435 --- Comment #3 from Juan Orti Alcaine j.orti.alca...@gmail.com 2011-12-21 08:34:50 EST --- (In reply to comment #2) Thank you for your suggestions, I have updated the files: Spec URL: https://raw.github.com/jorti/pytorctl-fedora-package/v0-0.8.20111213git/SPECS/pytorctl.spec SRPM URL: https://github.com/jorti/pytorctl-fedora-package/raw/v0-0.8.20111213git/SRPMS/pytorctl-0-0.8.20111213git.fc16.src.rpm Why do you prevent RHEL5 from building this as noarch? RHEL 5 handles noarch packages just fine. (It's noarch *subpackages* of arch-dependent packages that are an issue.) Ok, I got it wrong, now it's fixed. Please use cp -p to retain timestamp information from upstream. Also, consider doing something like install -pm0755 to avoid having to chmod everything post-copy. (It's not necessary, but simpler.) I applied those permissions because rpmlint was giving errors. I have fixed this by installing the files without execution and removing the python shebang from the files as seen here: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #2 from Matthias Clasen mcla...@redhat.com 2011-12-21 08:39:30 EST --- Adam, will you get to this soon ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768989 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-21 08:43:05 --- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2011-12-21 08:43:05 EST --- Built done, thanks for review repo https://koji.fedoraproject.org/koji/buildinfo?buildID=279677 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769012] Review Request: jetty-distribution-remote-resources - Jetty toolchain artifact for distribution remote resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769012 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-21 08:43:36 --- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2011-12-21 08:43:36 EST --- Built done, thanks for review repo https://koji.fedoraproject.org/koji/buildinfo?buildID=279676 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #3 from Adam Huffman bl...@verdurin.com 2011-12-21 08:50:43 EST --- Yes, sorry for the delay - hoping to review properly on Friday. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #3 from Matthias Clasen mcla...@redhat.com 2011-12-21 08:58:53 EST --- Updated again for gcr-3.3.3.1. The build fix is no longer needed, and the license thing has been fixed upstream. http://mclasen.fedorapeople.org/gcr.spec http://mclasen.fedorapeople.org/gcr-3.3.3.1-1.fc16.src.rpm Can we wrap this up soon ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 --- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2011-12-21 08:56:07 EST --- [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. jthornber-thin-provisioning-tools-0.0.1-0-g4dcab4b.tar.gz : MD5SUM this package : 31920fb9428b9a02b7e2b5681fd287fc MD5SUM upstream package : upstream source not found The source should be placed somewhere. Instead of macros define, there should be used global. The global will work even in EL-6. Upstream comment: * in build.log is mentioned: configure: WARNING: unrecognized options: --disable-dependency-tracking The only real problem is missing source, when will you upload it somewhere? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #3 from Matthias Clasen mcla...@redhat.com 2011-12-21 09:08:48 EST --- Any update ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756636 --- Comment #3 from Matthias Clasen mcla...@redhat.com 2011-12-21 09:13:25 EST --- Thanks Parag, I'll address your suggestions when I do the initial upload. To answer your question: the desktop file extensions are being discussed on xdg-list, currently. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756636 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Matthias Clasen mcla...@redhat.com 2011-12-21 09:19:09 EST --- New Package SCM Request === Package Name: gnome-screenshot Short Description: A screenshot utility for GNOME Owners: mclasen, cosimoc Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 216755] Review Request: GLiv - OpenGL image viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=216755 Laszlo Ersek ler...@redhat.com changed: What|Removed |Added CC||a...@redhat.com, ||ler...@redhat.com --- Comment #12 from Laszlo Ersek ler...@redhat.com 2011-12-21 09:26:11 EST --- Package Change Request == Package Name: gliv New Branches: el6 Owners: ajax Justification: builds out of the box (http://koji.fedoraproject.org/koji/taskinfo?taskID=3598153), small, light, useful; less intrusive and more handy than gthumb for example, especially when zooming and rotating. Here's a comparison between the (install) deps: Need by both: /bin/sh libX11.so.6()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) rpmlib(CompressedFileNames) = 3.0.4-1 = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 = 4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 = 4.0-1 rpmlib(PayloadIsXz) = 5.2-1 = 5.2-1 rtld(GNU_HASH) Needed by gthumb only: /bin/bash GConf2 = 2.14 desktop-file-utils = 0.9 libORBit-2.so.0()(64bit) libXrender.so.1()(64bit) libart_lgpl_2.so.2()(64bit) libbonobo-2.so.0()(64bit) libbonobo-activation.so.4()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.7)(64bit) libexif.so.12()(64bit) libgconf-2.so.4()(64bit) libglade-2.0.so.0()(64bit) libgnome-2.so.0()(64bit) libgnomecanvas-2.so.0()(64bit) libgnomeui-2.so.0()(64bit) libgnomevfs-2.so.0()(64bit) libgphoto2.so.2()(64bit) libgphoto2_port.so.0()(64bit) libgthumb.so()(64bit) libiptcdata.so.0()(64bit) libjpeg.so.62()(64bit) libopenrawgnome.so.1()(64bit) libpng12.so.0()(64bit) libpng12.so.0(PNG12_0)(64bit) libtiff.so.3()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) scrollkeeper Needed by gliv only: libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libXmu.so.6()(64bit) libXt.so.6()(64bit) libatk-1.0.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdkglext-x11-1.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgtkglext-x11-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpangox-1.0.so.0()(64bit) librt.so.1()(64bit) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #4 from Daniel Berrange berra...@redhat.com 2011-12-21 09:30:46 EST --- Updated to 0.0.4 release, specfile in same location as before : http://berrange.fedorapeople.org/review/libosinfo/libosinfo-0.0.4-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #2 from Milan Broz mb...@redhat.com 2011-12-21 09:31:05 EST ---
comment in spec:
# The source for this package was pulled from upstream's git.
# Use the following URL to access the tarball:
# https://github.com/jthornber/thin-provisioning-tools/tarball/%%{version}
So
https://github.com/jthornber/thin-provisioning-tools/tarball/0.0.1
will redirect to tar.gz download used in the srpm.
unfortunately, github doesn't provide better way to access it
(usable directly in Source0:)
I hope Joe will place tar so some better location in future.
global - yes, will change that.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756636 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2011-12-21 09:37:05 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765652] Review Request: bvi - Display-oriented editor for binary files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765652 --- Comment #8 from Matthieu Saulnier casper.le.fan...@gmail.com 2011-12-21 09:35:47 EST --- Hello, this is the latest release: Spec URL: http://fantom.fedorapeople.org/bvi.spec SRPM URL: http://fantom.fedorapeople.org/bvi-1.3.2-4.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754245] Review Request: ocaml-menhir - LR(1) parser generator for OCaml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754245 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Jerry James loganje...@gmail.com 2011-12-21 09:44:51 EST --- New Package SCM Request === Package Name: ocaml-menhir Short Description: LR(1) parser generator for OCaml Owners: jjames Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Marcela Mašláňová mmasl...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #3 from Marcela Mašláňová mmasl...@redhat.com 2011-12-21 10:00:09 EST --- Bad github. Ok, conditionally APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752089 --- Comment #1 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-21 10:04:40 EST --- Taking. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752089 Mamoru Tasaka mtas...@fedoraproject.org changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mtas...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765652] Review Request: bvi - Display-oriented editor for binary files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=765652
--- Comment #9 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-21
10:09:59 EST ---
About the patches:
# Fix empty debuginfo package :
Patch0: %{name}-%{version}-no_strip.patch
# Move from /usr/lib64/bmore.help to /usr/share/bvi/bmore.help :
Patch1: %{name}-%{version}-fix_help_install.patch
You shoudn't use the version macro in patches, otherwise you'll have to rename
them each time bvi is updated. Just set the version explicetely, it's also a
way to keep an history of the included patches:
# Fix empty debuginfo package :
Patch0: %{name}-1.3.2-no_strip.patch
# Move from /usr/lib64/bmore.help to /usr/share/bvi/bmore.help :
Patch1: %{name}-1.3.2-fix_help_install.patch
Instead of using sed to fix the help file path in the man page, you'd better
merge this fix in the bvi-1.4.2-fix_help_install.patch file.
By the way, just for information, you can use a different separator (| or @,
for example) in sed, instead of escaping slashes:
sed -i s|/usr/local/share/bmore.help|/usr/share/bvi/bmore.help| bmore.1
sed -i s@/usr/local/share/bmore.help@/usr/share/bvi/bmore.help@ bmore.1
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754245] Review Request: ocaml-menhir - LR(1) parser generator for OCaml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754245 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:08:04 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760033] Review Request: kde-plasma-publictransport - Public Transport plasma applet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760033
--- Comment #8 from Kevin Kofler ke...@tigcc.ticalc.org 2011-12-21 10:12:20
EST ---
The problem is, in libs subpackage are also icons for timetablemate included.
This means I can't move them all together into the main package because
timetable doesn't need the rest of the main package.
Well, right now it does because you have a Requires…
To achieve what you want, please:
* remove the Requires: %{name} = %{version}-%{release} from -libs and
* make the icon scriptlets apply to the -libs subpackage where the icons
actually are. (You'll have to remove the -p /sbin/ldconfig and write
/sbin/ldconfig as a scriptlet line instead, so that the other stuff can be
added.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678674 --- Comment #4 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-21 10:15:15 EST --- http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-1.0.3-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec * Thu Dec 22 2011 Mamoru Tasaka mtas...@fedoraproject.org - 1.0.3-1 - 1.0.3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Milan Broz mb...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Milan Broz mb...@redhat.com 2011-12-21 10:21:52 EST --- New Package SCM Request === Package Name: device-mapper-persistent-data Short Description: device-mapper persistent data tools Owners: lvm-team mbroz agk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:22:53 EST --- lvm-team is not in the packager group. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678674 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added CC||dpie...@redhat.com AssignedTo|nob...@fedoraproject.org|dpie...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Milan Broz mb...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Milan Broz mb...@redhat.com 2011-12-21 10:28:56 EST --- It is group account, I think it cannot be in packager group see lvm2 package, lvm-team is the owner, here should be the same If it is not possible, please use me as the owner and I let Alasdair to complain somewhere, it is his idea to use lvm-team :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711899 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:36:38 EST --- Any updates? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648053] Review Request: libMicro - Portable micro-benchmarks for various system and library calls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648053 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:36:15 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768800] Review Request: libwacom - Tablet Information Client Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768800 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com QAContact|extras...@fedoraproject.org |mcla...@redhat.com --- Comment #1 from Matthias Clasen mcla...@redhat.com 2011-12-21 10:39:34 EST --- builds fine in mock, rpmlint says: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756856] Review Request: python-pyflag - Forensic and Log Analysis GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756856 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:38:27 EST --- Possibly move the files in /usr/lib to devel, unless they're needed at runtime. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769012] Review Request: jetty-distribution-remote-resources - Jetty toolchain artifact for distribution remote resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769012 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|652183(FE-JAVASIG) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768545] Review Request: blktap - blktap user space utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 Eric Christensen e...@christensenplace.us changed: What|Removed |Added Status|NEW |ASSIGNED CC||e...@christensenplace.us AssignedTo|nob...@fedoraproject.org|e...@christensenplace.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:51:10 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753016
--- Comment #4 from Tom Hughes t...@compton.nu 2011-12-21 10:52:19 EST ---
Mostly looks good, just a couple more comments:
MUST Package requires other packages for directories it uses.
MUST Package must own all directories that it creates.
need GConf2 for %{_datadir}/GConf/gsettings
need hicolor-icon-theme for %{_datadir}/icons/hicolor
need shared-mime-info for %{_datadir}/mime/packages
need dbus for %{_datadir}/dbus-1/services
need gtk-doc for %{_datadir}/gtk-doc/html
Some of those may already be required indirectly, but I haven't found a goot
way to work our the full list of indirect requirements.
MUST Rpath absent or only used for internal libs.
MUST Rpmlint output is silent.
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-3.so.1.0.0
['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gcr-viewer ['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-base-3.so.1.0.0
['/usr/lib64']
gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/gcr-prompter
['/usr/lib64']
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #8 from Jon Ciesla limburg...@gmail.com 2011-12-21 10:53:05 EST --- I think I've managed to do what you want. -ish. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Marcela Mašláňová mmasl...@redhat.com changed: What|Removed |Added Flag||needinfo?(limburgher@gmail. ||com) --- Comment #9 from Marcela Mašláňová mmasl...@redhat.com 2011-12-21 10:56:57 EST --- (In reply to comment #8) I think I've managed to do what you want. -ish. Hehe, now I am new maintainer. I assure you that I know nothing about device-mapper. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754245] Review Request: ocaml-menhir - LR(1) parser generator for OCaml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754245 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-12-21 11:03:46 EST --- ocaml-menhir-20111019-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ocaml-menhir-20111019-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754245] Review Request: ocaml-menhir - LR(1) parser generator for OCaml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754245 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752089
Mamoru Tasaka mtas...@fedoraproject.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Comment #2 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-21
11:01:21 EST ---
License
- The main license should be MIT as COPYING says so.
setup.rb is written by Minero Aoki and it seems
this script is used not only by this software
(by searching with google), so this script is not directly
this software's product.
So for now I think the license tag should be MIT or
MIT and LGPLv2 (not LGPLv2+, setup.rb is version 2.1
specific).
* Documents
- The following files should be moved to -doc
---
%{geminstdir}/Rakefile
%{geminstdir}/setup.rb
%{geminstdir}/wirble.gemspec
---
- The following files can be marked as %doc.
---
%{geminstdir}/_irbrc
---
* Macros
- %ruby_sitelib is just defined but not used anywhere.
Other things seems okay.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flag|needinfo?(limburgher@gmail. | |com)| --- Comment #10 from Jon Ciesla limburg...@gmail.com 2011-12-21 11:10:59 EST --- Do'h. I misread the comments. Marcela, if you orphan in pkgdb, Milan can take it. Sorry. :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751172] Review Request: cumin - management console for Red Hat MRG grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751172 Trevor McKay tmc...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Trevor McKay tmc...@redhat.com 2011-12-21 11:14:40 EST --- New Package SCM Request === Package Name: cumin Short Description: Red Hat MRG grid management web console Owners: tmckay matt Branches: f15 f16 f17 InitialCC: tmckay croberts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225637] Merge Review: castor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225637 Matt Wringe mwri...@redhat.com changed: What|Removed |Added AssignedTo|mwri...@redhat.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678674 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Darryl L. Pierce dpie...@redhat.com 2011-12-21 11:13:24 EST --- All looks good, with the following notes: * MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] OUTPUT: mcpierce@mcpierce-laptop:review $ rpmlint rubygem-goocanvas-1.0.3-1.fc.src.rpm rubygem-goocanvas.src: E: changelog-time-in-future 2011-12-22 rubygem-goocanvas.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1) 1 packages and 0 specfiles checked; 1 errors, 1 warnings. The changelog in the future may just be a timezone issue. * The package must have a Requires and a BuildRequires on rubygems I see no such elements in the specfile. All else looks good. With the Requires/BuildRequires changes made, I approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751172] Review Request: cumin - management console for Red Hat MRG grid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751172 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2011-12-21 11:18:55 EST --- Git done (by process-git-requests). f17==devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751344] Review Request: sesame - Red Hat MRG management system agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751344 Trevor McKay tmc...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Trevor McKay tmc...@redhat.com 2011-12-21 11:17:38 EST --- New Package SCM Request === Package Name: sesame Short Description: Red Hat MRG management system agent Owners: tmckay matt Branches: f15 f16 f17 InitialCC: tmckay croberts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #4 from Ryan H. Lewis (rhl) m...@ryanlewis.net 2011-12-21 11:19:27 EST --- I'm so sorry. I thought I had posted a month or so ago. the files on fedorapeople still don't fix the problem. I still seem to get: Transaction Check Error: file /usr/lib64/libgdict-1.0.so.6.0.7 from install of gnome-dictionary-3.3.2-1.fc16.x86_64 conflicts with file from package gnome-utils-libs-1:3.2.1-2.fc16.x86_64 file /usr/bin/gnome-dictionary from install of gnome-dictionary-3.3.2-1.fc16.x86_64 conflicts with file from package gnome-utils-1:3.2.1-2.fc16.x86_64 file /usr/share/applications/gnome-dictionary.desktop from install of gnome-dictionary-3.3.2-1.fc16.x86_64 conflicts with file from package gnome-utils-1:3.2.1-2.fc16.x86_64 file /usr/share/gdict-1.0/sources/default.desktop from install of gnome-dictionary-3.3.2-1.fc16.x86_64 conflicts with file from package gnome-utils-1:3.2.1-2.fc16.x86_64 file /usr/share/glib-2.0/schemas/org.gnome.dictionary.gschema.xml from install of gnome-dictionary-3.3.2-1.fc16.x86_64 conflicts with file from package gnome-utils-1:3.2.1-2.fc16.x86_64 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751344] Review Request: sesame - Red Hat MRG management system agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751344 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2011-12-21 11:21:51 EST --- Git done (by process-git-requests). f17==devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752089
--- Comment #3 from Darryl L. Pierce dpie...@redhat.com 2011-12-21 11:24:03
EST ---
(In reply to comment #2)
License
- The main license should be MIT as COPYING says so.
setup.rb is written by Minero Aoki and it seems
this script is used not only by this software
(by searching with google), so this script is not directly
this software's product.
So for now I think the license tag should be MIT or
MIT and LGPLv2 (not LGPLv2+, setup.rb is version 2.1
specific).
Fixed.
* Documents
- The following files should be moved to -doc
---
%{geminstdir}/Rakefile
%{geminstdir}/setup.rb
%{geminstdir}/wirble.gemspec
Done.
---
- The following files can be marked as %doc.
---
%{geminstdir}/_irbrc
Done.
---
* Macros
- %ruby_sitelib is just defined but not used anywhere.
Removed.
Other things seems okay.
Updated Spec: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-2.fc16.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768545] Review Request: blktap - blktap user space utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 --- Comment #1 from Eric Christensen e...@christensenplace.us 2011-12-21 11:30:41 EST --- I'm done with the review. All looks good except the license. I see no references to GPLv2 or BSD. What am I missing? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756636 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-21 11:32:16 --- Comment #6 from Matthias Clasen mcla...@redhat.com 2011-12-21 11:32:16 EST --- build underway -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #5 from Matthias Clasen mcla...@redhat.com 2011-12-21 11:35:17 EST --- See my initial comment: I haven't added the necessary Obsoletes yet to deal with upgrade situations. Let me produce a package with the Obsoletes, if that makes things easier for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769609] Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769609 Milan Broz mb...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-12-21 11:36:53 --- Comment #11 from Milan Broz mb...@redhat.com 2011-12-21 11:36:53 EST --- np, we fixed that already, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #6 from Matthias Clasen mcla...@redhat.com 2011-12-21 11:48:00 EST --- I've put up new srpm/spec (same location), which has obsoletes for all gnome-utils subpackages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 --- Comment #23 from Chitlesh GOORAH chitl...@gmail.com 2011-12-21 11:54:25 EST --- You have been sponsored. Congratulations :) Please follow the guidelines to commit and build fritzing on F-15, F-16 and rawhide. http://fedoraproject.org/wiki/Using_git_FAQ_for_package_maintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 --- Comment #23 from Chitlesh GOORAH chitl...@gmail.com 2011-12-21 11:54:25 EST --- You have been sponsored. Congratulations :) Please follow the guidelines to commit and build fritzing on F-15, F-16 and rawhide. http://fedoraproject.org/wiki/Using_git_FAQ_for_package_maintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-12-21 11:55:52 EST --- vmpk-0.4.0-4.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710904] Review Request: octave-communications - Communications for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-12-21 11:59:50 EST --- octave-communications-1.1.0-2.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737550] Review Request: rubygem-mg - Minimal gem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737550 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||rubygem-mg-0.0.8-2.fc16 Resolution|NEXTRELEASE |ERRATA --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-12-21 11:57:29 EST --- rubygem-mg-0.0.8-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #7 from Matthias Clasen mcla...@redhat.com 2011-12-21 12:09:15 EST --- srpm: http://mclasen.fedorapeople.org/gnome-dictionary-3.3.2-2.fc16.src.rpm spec: http://mclasen.fedorapeople.org/gnome-dictionary.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755066] Review Request: chromaprint - Library implementing the AcoustID fingerprinting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755066 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|chromaprint-0.5-4.fc16 |chromaprint-0.5-4.fc15 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-12-21 12:09:34 EST --- chromaprint-0.5-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737550] Review Request: rubygem-mg - Minimal gem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737550 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|rubygem-mg-0.0.8-2.fc16 |rubygem-mg-0.0.8-2.fc15 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-12-21 12:12:24 EST --- rubygem-mg-0.0.8-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753016
--- Comment #5 from Matthias Clasen mcla...@redhat.com 2011-12-21 12:45:59
EST ---
http://mclasen.fedorapeople.org/gcr.spec
http://mclasen.fedorapeople.org/gcr-3.3.3.1-2.fc16.src.rpm
I've deleted the rpaths.
As for the directories,
- hicolor-icon-theme is a dependency of gtk3
- shared-mime-info gets pulled in by glib2
- dbus is a dependency of systemd, so kinda unavoidable
- gtk-doc has been ruled by the packaging committee to be ok to omit
- GConf2 is pretty much in the same situation as gtk-doc, I'd say.
gcr does not actually use GConf, it merely installs convert files
to trigger conversion of preexisting gconf keys to gsettings. The
directory it installs those conversion files in is pure 'file drop',
much like %{_datadir}/gtk-doc/html. And given that the purpose
of these conversion files is to help getting rid of GConf, it
would be just wrong to add a GConf dependency for them.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752993] gnome-dictionary - A dictionary application for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752993 --- Comment #8 from Matthias Clasen mcla...@redhat.com 2011-12-21 12:54:15 EST --- I've fixed the obsoletes to take the epoch into account now (files in the same spot) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749885 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Depends on|182235(FE-Legal)| --- Comment #33 from Rex Dieter rdie...@math.unl.edu 2011-12-21 13:13:28 EST --- So, seems we've been spinning doing nothing constructive here for about a month now. Pavel, thank you for your diligence and input so far, but if you're not able or willing to contribute toward bringing this review to completion any time soon, I humbly ask you to recuse yourself, to allow another reviewer to help finish the work here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666311] Review Request: fritzing - Intuitive EDA platform from prototype to product
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666311 Ed Marshall e...@logic.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #24 from Ed Marshall e...@logic.net 2011-12-21 13:24:17 EST --- New Package SCM Request === Package Name: fritzing Short Description: Electronic Design Automation software; from prototype to product Owners: logic Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com Flag||fedora-review? --- Comment #2 from Jerry James loganje...@gmail.com 2011-12-21 13:30:01 EST --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757368] Review Request: telepathy-kde-integration-module - KDE integration for telepathy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757368 nucleo alekc...@googlemail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|alekc...@googlemail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753016] gcr - A library for bits of crypto UI and parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #6 from Tom Hughes t...@compton.nu 2011-12-21 13:31:58 EST --- Sure it's OK not to require some of those, but if you do that then you have to own the directory instead, as described in the packaging guidelines here: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
