[Bug 771171] New: Review Request: django-tastypie

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: django-tastypie

https://bugzilla.redhat.com/show_bug.cgi?id=771171

   Summary: Review Request: django-tastypie
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bkab...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Tastypie is an webservice API framework for Django. It provides a convenient,
yet powerful and highly customizable, abstraction for creating REST-style
interfaces.

SPEC: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie-0.9.11-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3613483

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749885

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #34 from Pavel Alexeev (aka Pahan-Hubbitus)  
2012-01-02 04:48:56 EST ---
Rex, please excuse me for the so long time silence. End or year was very-very
hot for me on my workplace.

$ rpmlint iris-1.0.0-0.8.20110904svn812.fc16.src.rpm
iris.src:77: W: configure-without-libdir-spec
iris.src:27: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 27)
iris.src: W: invalid-url Source0: iris-1.0.0-r812.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Mix of space trivial to fix.

Other issues lifted. So, PACKAGE APPROVED.

P.S. Again sorry for such long delay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=77

--- Comment #13 from Ofer Schreiber  2012-01-02 04:57:05 
EST ---
I've uploaded a new TAR/SRPM/SPEC into
http://oschreib.fedorapeople.org/ovirt-engine-sdk/ with fixes for all the
issues mentioned above.

upstream notified about the licensing issues, I hope to get a new license files
soon (and a official tarball release as well).

Few questions/notes:
1. I've noticed that after removing the BuildArch, rpmlint complains "E:
no-binary", is that OK?
2. About the unowned dir: I thought that specifying a dir name without the
"dir" prefix includes the dir with all the content inside. after fixing that,
rpmbuild complains "warning: File listed twice:
/usr/lib/python2.7/site-packages/ovirtsdk", is that OK?
3. About *-devel naming: the upstream project is called "ovirt-engine-sdk", So
I thought it's the right name for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 738590] Review request: rubygem-gettext_i18n_rails - Simple FastGettext Rails integration

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738590

--- Comment #7 from Bohuslav Kabrda  2012-01-02 05:13:45 
EST ---
- The license has been clarified - the gettext_i18n_rails is now the official
upstream and the problematic license note has been removed from
ruby_gettext_extractor.rb, so everything is now under Public Domain.
- I moved the %{geminstdir}/init.rb to -doc subpackage as suggested, the
package works fine without it.
- I also upgraded to the newest version and fixed dependencies accordingly.

SPEC:
http://bkabrda.fedorapeople.org/pkgs/gettext_i18n_rails/rubygem-gettext_i18n_rails.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/gettext_i18n_rails/rubygem-gettext_i18n_rails-0.3.6-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3613621

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 742388] Review Request: polybori - Framework for Boolean Rings

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742388

Brendan Jones  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #11 from Brendan Jones  2012-01-02 
05:33:33 EST ---
Hi Jerry,

Now all good. This package is APPROVED

Required

+ - OK
- - N/A
X - attention
? - comment please

[+] named according to the Package Naming Guidelines 
[+] The spec file name must match the base package %{name}, in the format
%{name}.spec 
[+] Meet the Packaging Guidelines
unless building for F12 and below  or EPEL   
[+] Be licensed with a Fedora approved license and meet the Licensing
Guidelines 
[+] The License field in the package spec file must match the actual license 
[+] License file must be included in %doc
[+] The spec file must be written in American English
[+] The spec file for the package MUST be legible
[+] The sources used to build the package must match the upstream source
266218f3ccee05854dac6ea3e68ddbc570c16c45 
rpmbuild/SOURCES/polybori-0.8.0.tar.gz
[+] Successfully compile and build into binary rpms on at least one primary
architecture
[-] Proper use of ExcludeArch 
[+] All build dependencies must be listed in BuildRequires
[-] The spec file MUST handle locales properly
[+] Shared library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun
[+] Packages must NOT bundle copies of system libraries
[-] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package
[+] A package must own all directories that it creates
directories under this
[+] A Fedora package must not list a file more than once in the spec file's
%files listings
[+] Permissions on files must be set properly.
[+] Each package must consistently use macros
[+] The package must contain code, or permissable content
[+] Large documentation files must go in a -doc subpackage
[+] If a package includes something as %doc, it must not affect the runtime of
the application
[+] Header files must be in a -devel package
[+] Static libraries must be in a -static package
[+] library files that end in .so (without suffix) must go in a -devel package
[+] devel packages must require the base package using a fully versioned
dependency
[+] Packages must NOT contain any .la libtool archives
[+] GUI apps must include a %{name}.desktop file, properly installed with
desktop-file-install in the %install section 
[+] Packages must not own files or directories already owned by other packages
[+] All filenames in rpm packages must be valid UTF-8

[+] Has BuildRequires: python2-devel and/or python3-devel

[-] Python eggs must be built from source. They cannot simply drop an egg from
upstream into the proper directory.
[+] Python eggs must not download any dependencies during the build process.
[-] If egg-info files are generated by the modules build scripts they must be
included in the package.
[-] When building a compat package, it must install using easy_install -m so it
won't conflict with the main package.
[-] When building multiple versions (for a compat package) one of the packages
must contain a default version that is usable via "import MODULE" with no prior
setup.
[-] A package which is used by another package via an egg interface should
provide egg info. 
[+] Requires OK

[-] Egg install:
%install
%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT 

Should Items

[-] the packager SHOULD query upstream for any missing license text files to
include it
[-] Non-English language support for description and summary sections in the
package spec if available
[+] The reviewer should test that the package builds in mock
[+] The package should compile and build into binary rpms on all supported
architectures
[-] The reviewer should test that the package functions as described
[+] If scriptlets are used, those scriptlets must be sane
[+] Usually, subpackages other than devel should require the base package using
a fully versioned dependency
Do you need an explicit Requires: apron-debug in package ocaml-apron-debug?
[-] The placement of pkgconfig(.pc) should usually be placed in a -devel pkg
[-] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself
[+] Should contain man pages for binaries/scripts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
h

[Bug 755510] Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755510

--- Comment #9 from nicolas.vievi...@univ-valenciennes.fr 2012-01-02 06:44:54 
EST ---
Hello,

First, happy new year 2012 to Fedora's community!

As usual, new SPEC and SRPMS files according to the last upstream release. New
rpmlint reports provided too. 

Caution: according to the new naming scheme dealing with git commits, previous
SRPMS files are no longer available on my dropbox shared folder. I've also
added links to the RPMS files to ease largest testing and installing this
gnome-shell extension.

F-16 Spec URL:
http://dl.dropbox.com/u/25699833/Fedora/F-16/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet.spec

F-16 SRPM URL:
http://dl.dropbox.com/u/25699833/Fedora/F-16/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc16.src.rpm

F-16 RPM URL:
http://dl.dropbox.com/u/25699833/Fedora/F-16/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc16.noarch.rpm

F-17 Spec URL:
http://dl.dropbox.com/u/25699833/Fedora/Rawhide/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet.spec

F-17 SRPM URL:
http://dl.dropbox.com/u/25699833/Fedora/Rawhide/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc17.src.rpm

F-17 RPM URL:
http://dl.dropbox.com/u/25699833/Fedora/Rawhide/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc17.noarch.rpm

Project URL: https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet

$ rpmlint gnome-shell-extension-system-monitor-applet.spec 
gnome-shell-extension-system-monitor-applet.spec: W: invalid-url Source0:
paradoxxxzero-gnome-shell-system-monitor-applet-1.99-93-g8149a27.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc16.src.rpm 
gnome-shell-extension-system-monitor-applet.src: W: invalid-url Source0:
paradoxxxzero-gnome-shell-system-monitor-applet-1.99-93-g8149a27.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint gnome-shell-extension-system-monitor-applet.spec 
gnome-shell-extension-system-monitor-applet.spec: W: invalid-url Source0:
paradoxxxzero-gnome-shell-system-monitor-applet-1.99-93-g8149a27.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
gnome-shell-extension-system-monitor-applet-1.99-0.1.git8149a27.fc17.src.rpm 
gnome-shell-extension-system-monitor-applet.src: W: invalid-url Source0:
paradoxxxzero-gnome-shell-system-monitor-applet-1.99-93-g8149a27.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Any comment are welcome!

Cordially,


-- 
NVieville

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 736262] Review Request: proxyfuzz - man-in-the-middle non-deterministic network fuzzer

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736262

Petr Sklenar  changed:

   What|Removed |Added

   Flag||needinfo?(mno...@redhat.com
   ||)

--- Comment #8 from Petr Sklenar  2012-01-02 07:27:08 EST 
---
Spec URL: http://people.redhat.com/psklenar/pub/proxyfuzz/proxyfuzz.spec
SRPM URL:
http://people.redhat.com/psklenar/pub/proxyfuzz/proxyfuzz-20110923-1.fc14.src.rpm

mock -r fedora-16-x86_64 ~/rpmbuild/SRPMS/proxyfuzz-20110923-1.fc14.src.rpm
# progress seems good, results in :
http://people.redhat.com/psklenar/pub/proxyfuzz/mock-result/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768976] Review Request: perl-Dancer-Session-Cookie - Encrypted cookie-based session back-end for Dancer

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768976

Petr Pisar  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768976] Review Request: perl-Dancer-Session-Cookie - Encrypted cookie-based session back-end for Dancer

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768976

--- Comment #2 from Petr Pisar  2012-01-02 07:33:59 EST ---
New Package SCM Request
===
Package Name: perl-Dancer-Session-Cookie 
Short Description: Encrypted cookie-based session back-end for Dancer
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769444] Review Request: korundum - Ruby bindings for KDE libraries

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769444

--- Comment #6 from Jaroslav Reznik  2012-01-02 07:38:03 
EST ---
The package is ok from the kde/qt packaging view. Already packaged in Fedora,
this is a split of previously monolithic kdebindings package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769444] Review Request: korundum - Ruby bindings for KDE libraries

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769444

Bohuslav Kabrda  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com
   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Bohuslav Kabrda  2012-01-02 07:41:58 
EST ---
Ok, since there are no other blockers, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 767583] Review Request: python-poppler-qt4

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767583

--- Comment #14 from Brendan Jones  2012-01-02 
08:56:48 EST ---
Thanks for that, I have updated in rawhide, Will issue and update for the other
branches

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 738590] Review request: rubygem-gettext_i18n_rails - Simple FastGettext Rails integration

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738590

Vít Ondruch  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Vít Ondruch  2012-01-02 10:02:07 EST 
---
rpmlint reports following warning:

rubygem-gettext_i18n_rails.src: W: strange-permission
rubygem-gettext_i18n_rails.spec 0666L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

* Please consider removing of "Requires: rubygem(gettext)", since it is rails
  application development dependency, not a runtime think.
* Similarly "Requires: rubygem(ruby_parser)" should be removed for the same
  reason. Unfortunately, this dependency is now enforced by upstream. I have
  already opened issue [1] because of this.

Nevertheless, since these are just minor nits, I APPROVE the package. Please
fix them before commit if possible.


[1] https://github.com/grosser/gettext_i18n_rails/issues/49

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770721] Review Request: substance - Swing look-and-feel library

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770721

Jussi Lehtola  changed:

   What|Removed |Added

Summary|Review Request: substance   |Review Request: substance -
   ||Swing look-and-feel library

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770615] Review Request: baobab - A graphical directory tree analyzer

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770615

Jussi Lehtola  changed:

   What|Removed |Added

Summary|baobab -  A graphical   |Review Request: baobab -  A
   |directory tree analyzer |graphical directory tree
   ||analyzer

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771070

Jussi Lehtola  changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi

--- Comment #7 from Jussi Lehtola  2012-01-02 10:06:23 
EST ---
Ivan: if you are going to review this, then please set the status, assigned to
and fedora-review flags accordingly.

**

The reason why the build fails is revealed from root.log:

DEBUG util.py:257:  warning: group taurus does not exist - using root
DEBUG util.py:257:  ##
DEBUG util.py:257:  error: unpacking of archive failed on file
/builddir/build/SOURCES/nwipe-0.05.tar.gz;4f012b0b: cpio: MD5 sum mismatch

I guess this is because new versions of rpm use sha1 sums instead of md5 sums,
so the srpm should be created with md5 checksum.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 755291] Review Request: mod_pagespeed - Page Speed is an open-source project started at Google to help developers optimize their web pages by applying web performance best practices

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755291

Jussi Lehtola  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   | -  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 754246] Review Request: TV-Browser - A TV Browsing application

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754246

Jussi Lehtola  changed:

   What|Removed |Added

Summary|Review Request: TV-Browser  |Review Request: TV-Browser
   ||- A TV Browsing application

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771070

--- Comment #8 from Ivan Romanov  2012-01-02 10:32:24 EST ---
Hm ... how do I make such rpm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=757657

--- Comment #2 from Marcela Mašláňová  2012-01-02 11:06:11 
EST ---
(In reply to comment #1)
New version of the specfile.
http://mmaslano.fedorapeople.org/review/perl-Wx-Scintilla.spec

> Source tar ball is original. Ok.
> Summary verified from lib/Wx/Scintilla.pm. Ok.
> 
> FIX: License tag does not cover bundled Scintilla sources
> (wx-scintilla/src/scintilla/).
I can attach an email from the upstream if comments in the specfile are not
enough. 

> FIX: Do not bundle Scintilla (wx-scintilla/src/scintilla/).
Scintilla must be bundled. According to upstream development of the main source
is slow and it doesn't have some features, which they need. So, they've also
changed some files for specific usage in Padre. qtscintilla made the same
thing, but for their own use.
Another reason is the portability.
> 
> TODO: Augment description with other paragraphs from lib/Wx/Scintilla.pm POD.
> The first one does not define what this package delivers.
Fixed.
> 
> FIX: Build-require perl(Exporter) (lib/Wx/Scintilla/Constant.pm:12)
> FIX: Build-require perl(Caro) (lib/Wx/Scintilla.pm:6)
> FIX: Build-require perl(XSLoader) (lib/Wx/Scintilla.pm:8)
> 
> FIX: Build-require perl(base) (t/lib/Tests_Helper.pm:197)
> FIX: Build-require perl(Wx::App) (t/lib/Tests_Helper.pm:197)
> FIX: Build-require perl(Wx::Frame) (t/lib/Tests_Helper.pm:218)
> FIX: Build-require perl(Wx::Event) (t/03_editor.t:27)
> FIX: Build-require perl(lib) (t/02_inheritance.t:10)
> 
Fixed.

> TODO: Do not %doc-package META.json (as you do not package META.yml)
> 
Fixed.
> All tests pass. Ok.
> 
> $ rpmlint  perl-Wx-Scintilla.spec 
> ../SRPMS/perl-Wx-Scintilla-0.34-1.fc17.src.rpm
> ../RPMS/x86_64/perl-Wx-Scintilla-*
> perl-Wx-Scintilla.spec:22: W: comparison-operator-in-deptoken font(:lang=en)
> perl-Wx-Scintilla.src: W: spelling-error Summary(en_US) wxWidgets -> caskets,
> gaskets, casket's
> perl-Wx-Scintilla.src: W: spelling-error %description -l en_US StyledTextCtrl
> perl-Wx-Scintilla.src: W: spelling-error %description -l en_US wxWidgets ->
> caskets, gaskets, casket's
> perl-Wx-Scintilla.src: W: spelling-error %description -l en_US timeline -> 
> time
> line, time-line, timberline
> perl-Wx-Scintilla.src:22: W: comparison-operator-in-deptoken font(:lang=en)
> perl-Wx-Scintilla.x86_64: W: spelling-error Summary(en_US) wxWidgets ->
> caskets, gaskets, casket's
> perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US
> StyledTextCtrl
> perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US wxWidgets ->
> caskets, gaskets, casket's
> perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US timeline ->
> time line, time-line, timberline
> perl-Wx-Scintilla.x86_64: W: private-shared-object-provides
> /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so
> Scintilla.so()(64bit)
> perl-Wx-Scintilla.x86_64: W: private-shared-object-provides
> /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so
> libwx_gtk2u_scintilla-2.8.so()(64bit)
> perl-Wx-Scintilla.x86_64: W: private-shared-object-provides
> /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so
> Scintilla.so()(64bit)
> perl-Wx-Scintilla.x86_64: W: private-shared-object-provides
> /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so
> libwx_gtk2u_scintilla-2.8.so()(64bit)
> perl-Wx-Scintilla.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/  ['$ORIGIN']
> perl-Wx-Scintilla-debuginfo.x86_64: E: debuginfo-without-sources
> 3 packages and 1 specfiles checked; 2 errors, 14 warnings.
> 
> FIX: Do not provide private libraries (unbundle or use %perl_default_filter).
Filter is used.

> FIX: Do not set RPATH in Scintilla.so (unbundle or use
> LDFLAGS+=--enable-new-dtags to convert RPATH to RUN_PATH).
I guess RPATH is not a problem here. They are using the bundled version, so
they want to use this specific Scintilla.so.

> 
> TODO: You can package some tools/*.
Not sure if they are useful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770174

--- Comment #14 from Mattia  2012-01-02 11:37:59 EST 
---
> 
> This looks good now -> approved!
> 
> If you create a FAS account (if you've not done so already) and let me know
> your FAS login then I'll sponsor you.
> 
> Regards,
> 
> Hans
> 
> p.s.
> 
> I guess you should drop the chmod -x I made you add, given Kevin comments.
> Please do this either before importing the package into git, or change it in
> git before building the package.

Thank you all, I will correct the SRPM before importing it into git.
My FAS login is "mattia" (I really lack fantasy). After being sponsored I
think I must apply for ownership of the package: can I do that directly in the
Fedora Package Database web interface or should I use this bug as described in
https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages
?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770174

--- Comment #15 from Rex Dieter  2012-01-02 12:04:37 EST 
---
that's correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771230] New: Review Request: gemrb - GemRB is a port of BioWare's Infinity Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale, Icewind Dale II and Pl

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gemrb - GemRB is a port of BioWare's Infinity 
Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of 
Amn, Icewind Dale, Icewind Dale II and Planescape: Torment

https://bugzilla.redhat.com/show_bug.cgi?id=771230

   Summary: Review Request: gemrb - GemRB is a port of BioWare's
Infinity Engine-based games, fine RPGs like Baldur's
Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale,
Icewind Dale II and Planescape: Torment
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: schluss...@schlussarz.pl
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://db.tt/2pM55Q4X
SRPM URL: http://db.tt/mEJ8jLi3
Description: FE-NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771231] New: Review Request: gemrb - GemRB is a port of BioWare's Infinity Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale, Icewind Dale II and Pl

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gemrb - GemRB is a port of BioWare's Infinity 
Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of 
Amn, Icewind Dale, Icewind Dale II and Planescape: Torment

https://bugzilla.redhat.com/show_bug.cgi?id=771231

   Summary: Review Request: gemrb - GemRB is a port of BioWare's
Infinity Engine-based games, fine RPGs like Baldur's
Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale,
Icewind Dale II and Planescape: Torment
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: schluss...@schlussarz.pl
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://db.tt/2pM55Q4X
SRPM URL: http://db.tt/mEJ8jLi3
Description: FE-NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771230] Review Request: gemrb - GemRB is a port of BioWare's Infinity Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale, Icewind Dale II and Planesc

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771230

--- Comment #1 from Schlussarz  2012-01-02 12:28:20 
EST ---
*** Bug 771231 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771231] Review Request: gemrb - GemRB is a port of BioWare's Infinity Engine-based games, fine RPGs like Baldur's Gate, Baldur's Gate II: Shadows of Amn, Icewind Dale, Icewind Dale II and Planesc

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771231

Schlussarz  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
Last Closed||2012-01-02 12:28:19

--- Comment #1 from Schlussarz  2012-01-02 12:28:19 
EST ---


*** This bug has been marked as a duplicate of bug 771230 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749885

Rex Dieter  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #35 from Rex Dieter  2012-01-02 12:46:44 EST 
---
Thanks!

New Package SCM Request
===
Package Name: iris
Short Description: A library for working with the XMPP/Jabber protocol 
Owners: rdieter
Branches: f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769444] Review Request: ruby-korundum - Ruby bindings for KDE libraries

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769444

Rex Dieter  changed:

   What|Removed |Added

Summary|Review Request: korundum -  |Review Request:
   |Ruby bindings for KDE   |ruby-korundum - Ruby
   |libraries   |bindings for KDE libraries
  Alias||ruby-korundum
   Flag||fedora-cvs?

--- Comment #8 from Rex Dieter  2012-01-02 13:23:34 EST 
---
New Package SCM Request
===
Package Name: ruby-korundum
Short Description: Ruby bindings for KDE libraries
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771233] New: Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-rack-protection - Ruby gem that protects 
against typical web attacks

https://bugzilla.redhat.com/show_bug.cgi?id=771233

   Summary: Review Request: rubygem-rack-protection - Ruby gem
that protects against typical web attacks
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mfoj...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://omicron.mifo.sk/rubygem-rack-protection.spec
SRPM URL: http://omicron.mifo.sk/rubygem-rack-protection-1.2.0-1.fc14.src.rpm
Description:

This gem protects against typical web attacks.
Should work for all Rack apps, including Rails.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771233

--- Comment #1 from Michal Fojtik  2012-01-02 13:44:23 EST 
---
This package is need for updating Sinatra to 1.3.2.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@redhat.com
 AssignedTo|nob...@fedoraproject.org|l...@redhat.com

--- Comment #1 from Lukáš Zapletal  2012-01-02 14:02:36 EST ---
Taking the review.

First look:

rpmlint subscription-manager-0.99.2-1.fc16.src.rpm 
subscription-manager.src:11: W: macro-in-comment %{version}
subscription-manager.src:11: W: macro-in-comment %{release}
subscription-manager.src:162: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/subscription-manager.py*
subscription-manager.src:163: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/product-id.py*
subscription-manager.src:164: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/katello.py*
subscription-manager.src: W: invalid-url Source0:
subscription-manager-0.99.2.tar.gz

All errors and warning above are properly commented in the spec and are not
problems. Formal review will follow later on.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771237] New: Review Request: rubygem-showoff - Ruby web app that reads simple configuration files for a presentation

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-showoff - Ruby web app that reads simple 
configuration files for a presentation

https://bugzilla.redhat.com/show_bug.cgi?id=771237

   Summary: Review Request: rubygem-showoff - Ruby web app that
reads simple configuration files for a presentation
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mfoj...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec
SRPM URL: http://omicron.mifo.sk/rubygem-showoff-0.0.7-1.fc14.src.rpm
Description:

ShowOff is a Sinatra web app that reads simple configuration files for a
presentation. It is sort of like a Keynote web app engine - think S5 +
Slidedown.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

   Flag||fedora-review?

--- Comment #2 from Lukáš Zapletal  2012-01-02 14:27:19 EST ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3614692

FORMAL REVIEW

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

The LICENSE file is missing, distribution for all subpackages is recommended.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

I would suggest to add one line instructing user to install tito, not all of
use know what tito is. Not a blocker.

Excelent work for such a complicated package, only minor points.

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

 AssignedTo|l...@redhat.com |dgood...@redhat.com
   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Lukáš Zapletal  2012-01-02 14:31:07 EST ---
Devan, please fix the minor issue (LICENSE file distribution) before you commit
to the distgit.

*** PACKAGE IS APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

--- Comment #4 from Lukáš Zapletal  2012-01-02 14:35:29 EST ---
For completeness I am attaching rpmlint for binaries:

subscription-manager-firstboot.i686: W: no-documentation
subscription-manager-gnome.i686: W: non-conffile-in-etc
/etc/pam.d/subscription-manager-gui
subscription-manager-gnome.i686: W: non-conffile-in-etc
/etc/security/console.apps/subscription-manager-gui
subscription-manager.src:11: W: macro-in-comment %{version}
subscription-manager.src:11: W: macro-in-comment %{release}
subscription-manager.src:162: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/subscription-manager.py*
subscription-manager.src:163: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/product-id.py*
subscription-manager.src:164: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/katello.py*
subscription-manager.src: W: invalid-url Source0:
subscription-manager-0.99.2.tar.gz
subscription-manager.i686: W: only-non-binary-in-usr-lib
subscription-manager.i686: W: non-conffile-in-etc
/etc/bash_completion.d/subscription-manager
subscription-manager.i686: W: non-conffile-in-etc
/etc/security/console.apps/subscription-manager
subscription-manager.i686: W: no-dependency-on usermode
subscription-manager.i686: W: manual-page-warning
/usr/share/man/man8/subscription-manager.8.gz 672: warning: macro `pp' not
defined
subscription-manager.i686: W: non-conffile-in-etc
/etc/pam.d/subscription-manager
subscription-manager.i686: W: service-default-enabled
/etc/rc.d/init.d/rhsmcertd
subscription-manager.i686: W: incoherent-init-script-name rhsmcertd
('subscription-manager', 'subscription-managerd')
5 packages and 0 specfiles checked; 3 errors, 14 warnings.

No blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 765651] Review Request: asterisk-gui - Graphical interface for Asterisk configuration

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=765651

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #16 from Fedora Update System  
2012-01-02 14:54:39 EST ---
asterisk-gui-2.0-3.20111230svn5218.el6 has been pushed to the Fedora EPEL 6
testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 588428] Review Request: rubygem-addressable - Improved URI/URL handling

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588428

--- Comment #21 from Shawn Starr  2012-01-02 15:06:30 
EST ---
New Package SCM Request
===
Package Name: rubygem-addressable
Short Description: Improved URI/URL handling
Owners: spstarr

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 728088] Review Request: rubygem-idn - Ruby Bindings for the GNU LibIDN library

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728088

--- Comment #18 from Shawn Starr  2012-01-02 15:07:26 
EST ---
New Package SCM Request
===
Package Name: rubygem-idn
Short Description: Ruby Bindings for the GNU LibIDN library
Owners: spstarr

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 598860] Review Request: httpd-itk - MPM Itk for Apache HTTP Server

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598860

--- Comment #11 from Ryan H. Lewis (rhl)  2012-01-02 
15:16:32 EST ---
"P.S. Spec file formatted by tabs with 5 space width (
http://fedoraproject.org/wiki/PavelAlexeev/tabsize ). Please, do not start
review if it is a problem for you."

Make it so that I don't need to do this. 

I should be able to view the spec file so that it is legible:
http://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility

I'm not modifying my tabsize to deal with your spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 598860] Review Request: httpd-itk - MPM Itk for Apache HTTP Server

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598860

--- Comment #12 from Pavel Alexeev (aka Pahan-Hubbitus)  
2012-01-02 15:26:11 EST ---
How I can known what tab size you are using? Now, today, tomorrow??

May be we start real work? Or do not start it.
I'm ready continue this discussion if you want, but I think mail list or
private conversation, forum or jabber will be much more appropriate place for
that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-CGI-Session-Driver-mem
   ||cached-0.04-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:48:27

--- Comment #10 from Fedora Update System  
2012-01-02 16:48:27 EST ---
perl-CGI-Session-Driver-memcached-0.04-2.fc16 has been pushed to the Fedora 16
stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700344] Review Request: perl-Authen-CAS-Client - Interface for authentication via JA-SIG's Central Authentication Service

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700344

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Authen-CAS-Client-0.05
   ||-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:49:31

--- Comment #15 from Fedora Update System  
2012-01-02 16:49:31 EST ---
perl-Authen-CAS-Client-0.05-2.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

Shawn Starr  changed:

   What|Removed |Added

   Flag|fedora-review+  |fedora-review-

--- Comment #28 from Shawn Starr  2012-01-02 16:49:37 
EST ---
Change flag from + -> - we're not done reviewing yet

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

--- Comment #27 from Shawn Starr  2012-01-02 16:47:09 
EST ---
Updated, bumped to 0.9.15 also.

See updates spec:

Spec URL: http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib.spec
SRPM URL:
http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib-0.9.15-2.fc17.src.rpm

rpmlint: PASS (with usual ruby doc warnings)
mock build: PASS

Please re-review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 758470] Review Request: vmmlib

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758470

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version||vmmlib-1.0-0.2.rc1.fc16
 Resolution|NEXTRELEASE |ERRATA

--- Comment #11 from Fedora Update System  
2012-01-02 16:55:35 EST ---
vmmlib-1.0-0.2.rc1.fc16 has been pushed to the Fedora 16 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700352] Review Request: perl-DublinCore-Record - Container for Dublin Core metadata elements

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700352

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-DublinCore-Record-0.03
   ||-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:53:54

--- Comment #13 from Fedora Update System  
2012-01-02 16:53:54 EST ---
perl-DublinCore-Record-0.03-2.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700354] Review Request: perl-Locale-Currency-Format - Perl functions for formatting monetary values

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700354

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Locale-Currency-Format
   ||-1.30-1.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:50:58

--- Comment #11 from Fedora Update System  
2012-01-02 16:50:58 EST ---
perl-Locale-Currency-Format-1.30-1.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700349] Review Request: perl-Biblio-EndnoteStyle - Reference formatting using Endnote-like templates

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700349

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Biblio-EndnoteStyle-0.
   ||05-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:56:12

--- Comment #15 from Fedora Update System  
2012-01-02 16:56:12 EST ---
perl-Biblio-EndnoteStyle-0.05-2.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #7 from Jon Masters  2012-01-02 17:19:43 EST ---
I am presently completing the review, sorry about that. Should have some
comments for you in a few.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771252] New: Review Request: cinnamon - Window management and application launching for GNOME

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cinnamon - Window management and application launching 
for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=771252

   Summary: Review Request: cinnamon - Window management and
application launching for GNOME
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: leigh123li...@googlemail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL:
http://leigh123linux.fedorapeople.org/pub/review/cinnamon/1/cinnamon.spec
SRPM URL:
http://leigh123linux.fedorapeople.org/pub/review/cinnamon/1/cinnamon-1.1.3-1.fc16.src.rpm

Cinnamon provides core user interface functions for the GNOME 3 desktop,
like switching to windows and launching applications. Cinnamon takes
advantage of the capabilities of modern graphics hardware and introduces
innovative user interface concepts to provide a visually attractive and
easy to use experience.
The desktop layout is similar to Gnome 2. 
The underlying technology is forked from Gnome Shell.e>

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771254] New: Review Request: libva-vdpau-driver - HW video decode support for VDPAU platforms

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libva-vdpau-driver - HW video decode support for VDPAU 
platforms

https://bugzilla.redhat.com/show_bug.cgi?id=771254

   Summary: Review Request: libva-vdpau-driver - HW video decode
support for VDPAU platforms
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kwiz...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL:
http://kwizart.fedorapeople.org/review/libva-vdpau-driver.spec
SRPM URL:
http://kwizart.fedorapeople.org/review/libva-vdpau-driver-0.7.3-2.fc16.src.rpm
Description: HW video decode support for VDPAU platforms

This package is a bridge between vdpau and vaapi, there is no actual hardware
back-end provided here. (instead a given back-end may rely on this package to
HW decode a video stream from a VA-API enabled player)

There seem to have proof of concept of a vdpau backend for an open source
driver (untested yet) http://cgit.freedesktop.org/~emericg
So that make the package interest to rise up for fedora itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 519652] Review Request: sabnzbdplus - Heavily Featured Automatic Binary Newsgrabber

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519652

Major Hayden  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|ma...@mhtx.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 519652] Review Request: sabnzbdplus - Heavily Featured Automatic Binary Newsgrabber

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519652

Major Hayden  changed:

   What|Removed |Added

 CC||ma...@mhtx.net
   Flag||needinfo?(kon...@tylerc.org
   ||)

--- Comment #10 from Major Hayden  2012-01-02 18:13:39 EST ---
Conrad -

Are you still working on this package?  If not, I'll be glad to pick it up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 519652] Review Request: sabnzbdplus - Heavily Featured Automatic Binary Newsgrabber

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519652

Conrad Meyer  changed:

   What|Removed |Added

   Flag|needinfo?(kon...@tylerc.org |
   |)   |

--- Comment #11 from Conrad Meyer  2012-01-02 18:17:59 EST 
---
Still waiting for a review ;-).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #8 from Jon Masters  2012-01-02 18:26:48 EST ---
Terje raised the main issues I had already. Python dep might be extraneous.
Also very unlikely but I'm honestly not sure if SysV is a legacy trademark. Its
use is so profuse that I don't intend to object to it, just mention it here.

Summary: I think otherwise this package is ready, so it passes review. However
I am unable to set the flag (due to a quirk of BZ) so I filed a request with
rel-eng just now that they do so on my behalf.

Review
--

* PASS: rpmlint must be run on the source rpm and all binary rpms the build
produces

- The output pertains to a few false-positive spelling "errors", none
of
  which are actual errors. Therefore this part of the test is passed.

** The output should be posted in the review:

$ rpmlint icfg-0.9-1.fc15.src.rpm
icfg.src: W: spelling-error %description -l en_US sysconfig -> configure
icfg.src: W: spelling-error %description -l en_US kickstart -> kick start,
kick-start, kicks tart
icfg.src: W: spelling-error %description -l en_US scriptable -> scrip table,
scrip-table, script able
icfg.src: W: spelling-error %description -l en_US sed -> tied, ed, seed
icfg.src: W: spelling-error %description -l en_US awk -> awl, aw, wk
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

$ rpmlint icfg-0.9-1.fc16.noarch.rpm
icfg.noarch: W: spelling-error %description -l en_US sysconfig -> configure
icfg.noarch: W: spelling-error %description -l en_US kickstart -> kick start,
kick-start, kicks tart
icfg.noarch: W: spelling-error %description -l en_US scriptable -> scrip table,
scrip-table, script able
icfg.noarch: W: spelling-error %description -l en_US sed -> tied, ed, seed
icfg.noarch: W: spelling-error %description -l en_US awk -> awl, aw, wk
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

(additionally no errors detected during package build)

* The package must be named according to the Package Naming Guidelines: PASS
* The spec file name must match the base package %{name}.spec unles your
package has an exemption: PASS
* The package must meet the Packaging Guidelines
- Naming guidelines already confirmed
- Version and Release is consistent
- License is consistent with FPG
- Package is useful without external bits (just scripts, NA)
- No inclusion of pre-built binaries or libraries (noarch scripts!)
- Obfuscated Code Contest: not entered. SPEC is clean.
- Architecture support: noarch, and not limited
- FHS: use seems to be consistent
- Libexec: not applicable
- /run: not applicable
- Binaries not dependent upon separate libraries: correct
- rpmlint has already been run (above)
- Changelogs: appear to be correct
- No use of deprecated packager tag
- No use of deprecated vendor tag
- No use of deprecated copyright tag
- Summary does not end in a period
- No use of pre-requires
- Source URL is correct and works
- Buildroot tag is allowed and ignored
- Clean section is present and allowed
- No build requires
- No use of pre-requires
- No use of file requires
- Assume python binary dep not automatic??? (check)
- No use of autogenerated provide filtering
- Exception not applicable
- Summary: seems concise and reasonable
- Description: seems fine, is "SysV" a trademark?
- Encoding: meets the requirement for ASCII
- Documentation: is included using correct macro
- Compiler flags: not applicable
- PIE: not applicable
- Debuginfo packages: not applicable
- Devel packages: not applicable
- Pkgconfig files: not applicable
- Requiring base package: not applicable
- Shared libraries: not applicable
- Packaging static libraries: not applicable
- Statically linking executables: not applicable
- Duplication of system libraries: not appliable
- Beware of Rpath: not applicable
- Configuration files: not applicable
- Configuration of package managers: not applicable
- Systemd: not a startup service and not applicable
- Initscripts: not applicable
- Desktop files: not applicable
- Macro use is consistent
- Correct use of RPM_BUILD_ROOT macros
- No use of makeinstall macro (correct)
- No macros used in Summary and Description
- No improper use of _sourcedir macro
- No local or global macro defines
- No locale translations
- Preserve file timestamps - install command does so
- Parallel make is not applicable
- Scriptlets are not used
- Transactions are not manipulated
- Condition

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #9 from Jon Masters  2012-01-02 18:28:30 EST ---
Apologies for the delay in completing this. If you need any further assistance,
I'll endeavor to turn it around swiftly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722640] Review Request: R-qcc - SQC package for R

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722640

John J. McDonough  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 519652] Review Request: sabnzbdplus - Heavily Featured Automatic Binary Newsgrabber

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519652

--- Comment #12 from Major Hayden  2012-01-02 20:42:39 EST ---
I'm not a reviewer but I'll give the package a look and try to find someone to
review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 519652] Review Request: sabnzbdplus - Heavily Featured Automatic Binary Newsgrabber

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519652

Major Hayden  changed:

   What|Removed |Added

 AssignedTo|ma...@mhtx.net  |nob...@fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #11 from Neil Horman  2012-01-02 21:13:44 EST 
---
nm, seems I'm able to do it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

Neil Horman  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #10 from Neil Horman  2012-01-02 21:12:32 EST 
---
Thank you, Jon, I appreciate the review.  Terje's notes have been incorporated
into the package already, and it appears that you have not other objections. If
you could please set the fedora review flag to + so that I can get the SCM
request submitted, I'd appreciate it.

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

Neil Horman  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Neil Horman  2012-01-02 21:16:35 EST 
---
New Package SCM Request
===
Package Name: icfg
Short Description: sysv network configuration file command line editor
Owners: nhor...@redhat.com, agosp...@redhat.com
Branches: rawhide, fc16
InitialCC: nhor...@redhat.com, agosp...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

Itamar Reis Peixoto  changed:

   What|Removed |Added

   Flag||needinfo?(nhor...@redhat.co
   ||m)

--- Comment #13 from Itamar Reis Peixoto  2012-01-02 
21:22:24 EST ---
owners must be your fedora account username (fas)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=766932

--- Comment #14 from Jon Masters  2012-01-02 21:28:43 EST ---
Yea, per my email I was unable to set it as I have a BZ account
(j...@redhat.com) that differs from my personal Fedora information and the
various systems really don't like that. I guess I might just set everything to
j...@redhat.com eventually. I filed a ticket before so I assume they'll just
close that since you were able to set the flags now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 742388] Review Request: polybori - Framework for Boolean Rings

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742388

Jerry James  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Jerry James  2012-01-02 22:56:20 EST 
---
New Package SCM Request
===
Package Name: polybori
Short Description: Framework for Boolean Rings
Owners: jjames
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770695

Pravin Satpute  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2012-01-03 00:22:12

--- Comment #5 from Pravin Satpute  2012-01-03 00:22:12 
EST ---
Thanks Jon for git
Built for master, f16 and f15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 755275] Review Request: CSSLint - Detecting potential problems in CSS code

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755275

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from Guillaume Kulakowski  2012-01-03 
01:39:19 EST ---
New Package SCM Request
===
Package Name: csslint
Short Description: Detecting potential problems in CSS code
Owners:
Branches: f15 f16 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] New: Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-delorean - lets you travel in time with Ruby 
by mocking Time.now

https://bugzilla.redhat.com/show_bug.cgi?id=771295

   Summary: Review Request: rubygem-delorean - lets you travel in
time with Ruby by mocking Time.now
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bkab...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Delorean lets you travel in time with Ruby by mocking Time.now.

SPEC: http://bkabrda.fedorapeople.org/pkgs/delorean/rubygem-delorean.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/delorean/rubygem-delorean-1.2.0-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3615002

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review