[Bug 769173] Review Request: english-typing booster - typing booster for english language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769173 --- Comment #6 from anish apa...@redhat.com 2012-01-04 03:51:12 EST --- New Package SCM Request === Package Name: english-typing booster Short Description: dictionary for English language Owners: anishpatil,pravins Branches: f16 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730620] Review Request: infiniband-diags - OpenFabrics Alliance InfiniBand Diagnostic Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730620 --- Comment #3 from Albert Strasheim full...@gmail.com 2012-01-04 05:19:20 EST --- rpmlint output: infiniband-diags.spec:11: W: unversioned-explicit-provides perl(IBswcountlimits) infiniband-diags.x86_64: W: spelling-error %description -l en_US subnet - subset, sublet, sub net infiniband-diags.x86_64: W: no-manual-page-for-binary check_lft_balance.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibdiscover.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_mfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibqueryerrors.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_lfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibswportwatch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibfindnodesusing.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintca.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintswitch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary iblinkinfo.pl infiniband-diags.x86_64: W: no-manual-page-for-binary set_nodedesc.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibidsverify.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintrt.pl infiniband-diags-devel.x86_64: W: manual-page-warning /usr/share/man/man3/ibnd_discover_fabric.3.gz 8: warning: macro `bi' not defined infiniband-diags-devel-static.x86_64: W: no-documentation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730620] Review Request: infiniband-diags - OpenFabrics Alliance InfiniBand Diagnostic Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730620 Albert Strasheim full...@gmail.com changed: What|Removed |Added CC||dledf...@redhat.com Version|rawhide |16 --- Comment #2 from Albert Strasheim full...@gmail.com 2012-01-04 05:17:39 EST --- I have made an updated package based on Doug's new IB packages here: https://admin.fedoraproject.org/updates/FEDORA-2012-0092/libibmad-1.3.8-1.fc16,libmlx4-1.0.2-3.fc16,libcxgb3-1.3.1-1.fc16,librdmacm-1.0.15-1.fc16,libibverbs-1.1.6-1.fc16,libnes-1.1.3-1.fc16,opensm-3.3.12-1.fc16 Spec URL: http://bekstil.net/~albert/SPECS/infiniband-diags.spec SRPM URL: http://bekstil.net/~albert/SRPMS/infiniband-diags-1.5.12-1.fc16.src.rpm rpmlint looks good, except for a warning about Provides: perl(IBswcountlimits) in the spec file. Not quite sure how to fix that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730620] Review Request: infiniband-diags - OpenFabrics Alliance InfiniBand Diagnostic Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730620 Albert Strasheim full...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771485] Review Request: libcxgb4 - Chelsio T4 iWARP HCA Userspace Driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771485 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Summary|New Package: libcxgb4 |Review Request: libcxgb4 - ||Chelsio T4 iWARP HCA ||Userspace Driver -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771480] Review Request: trident - A Java animation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771480 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Summary|trident |Review Request: trident - A ||Java animation library --- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 05:26:44 EST --- Please fill in your full name in bugzilla. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757657 --- Comment #4 from Marcela Mašláňová mmasl...@redhat.com 2012-01-04 06:04:36 EST --- (In reply to comment #3) Spec file changes: FIX: wx-scintilla/src/scintilla/License.txt looks like MIT but it is not exact copy of any wordings from https://fedoraproject.org/wiki/Licensing/MIT. Please get confirmation by Fedora legal department. Scintiall variant should appear on the web page. I've already sent email to legal. Spot answered it's MIT and my wording of license is correct. FIX: Do not bundle Scintilla (wx-scintilla/src/scintilla/). Scintilla must be bundled. FIX: Then you need exception from Fedora Packaging Committee Will do. TODO: Augment description with other paragraphs from lib/Wx/Scintilla.pm FIX: Remove POD mark-up from Description text. Done. FIX: Do not set RPATH in Scintilla.so (unbundle or use LDFLAGS+=--enable-new-dtags to convert RPATH to RUN_PATH). I guess RPATH is not a problem here. They are using the bundled version, so they want to use this specific Scintilla.so. RPATH cannot be overridden by environment variables (if requested by user) in contrast to RUN_PATH. Thus converting RPATH to RUN_PATH is good. Apparently the LDFLAGS value did not pass to linker. However this is not blocker, especially if the second library is in private directory. So you can remove the useless variable export. Done. New specfile http://mmaslano.fedorapeople.org/review/perl-Wx-Scintilla.spec FPC ticket: https://fedorahosted.org/fpc/ticket/126 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771233
--- Comment #7 from Michal Fojtik mfoj...@redhat.com 2012-01-04 06:24:51 EST
---
(In reply to comment #6)
- Move %{geminstdir}/README.md to the -doc subpackage, if it is not
needed for
runtime (which I believe it isn't) and mark it with %doc.
- Also, mark %{gemdir}/doc/%{gemname}-%{version} with %doc.
Actually I don't think marking -doc subpackage files with %doc is necessary.
Could you point me to a guideline where this is required?
I believe that there is no specific guideline for this. But if you take a look
at it from the logical point of view, you have two types of files in your
-doc
subpackage:
- The Rakefile and spec/ directory, which are not needed for runtime, so you
moved them to -doc subpackage (which is completely ok, I think), but they are
not documentation.
- The real documentation (README.md and the doc directory).
So, to me, it makes sense to distinct these two.
Good point. My general through was that once the subpackage is marked as '-doc'
the files are already recognized as %doc and thus don't need additional
marking.
Anyway, I'll mark them, not a blocker for me of course ;-)
Additional comments:
- I think it is clearer not to remove the files by rm, but use %exclude in
%files. But this is just my opinion, so not a blocker.
- As for the macros vs. commands thing: There are also macros for commands
like
rm, so it may be good to use them, once you decide to use macros for some
commands. But at this stage, it doesn't have the feeling of inconsistency, so
not a blocker. (BTW, I think that using macros for things like mkdir -p is
not necessary, but again, just my opinion.)
- The link in comment #5 points to the first release srpm, so when importing
to
fedpkg, please make sure to import the second one :)
Sure, I'll try to fix that before importing to Fedora (EPEL). Thanks for review
Bohuslav!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #9 from Adam Huffman bl...@verdurin.com 2012-01-04 06:28:10 EST --- Looks okay now, though I think it's a little odd that you have the directory /usr/share/gtk-doc/html/Libosinfo/, when everything else uses the name in all lower-case. Is that deliberate? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Michal Fojtik mfoj...@redhat.com 2012-01-04 06:26:25 EST --- New Package SCM Request === Package Name: rubygem-rack-protection Short Description: Ruby gem that protects against typical web attacks Owners: mfojtik Branches: f16 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770152
--- Comment #6 from Adam Huffman bl...@verdurin.com 2012-01-04 06:31:51 EST
---
Thanks for the new version. Continuing the theme of pedantry, shouldn't it be
%{buildroot} rather than %{_buildroot}?
I know it's annoyingly inconsistent with the other tags...
Also, could you update the changelog with these latest updates?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #10 from Daniel Berrange berra...@redhat.com 2012-01-04 06:41:40 EST --- That docs naming is just what the upstream Makefile produces. I'll re-examine it for a future upstream release. BTW, If you consider this approved, could you twiddle the fedora-review=+ flag on the BZ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771252] Review Request: cinnamon - Window management and application launching for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771252 --- Comment #1 from leigh scott leigh123li...@googlemail.com 2012-01-04 06:46:21 EST --- Spec URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon/2/cinnamon.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon/2/cinnamon-1.1.3-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Adam Huffman bl...@verdurin.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Adam Huffman bl...@verdurin.com 2012-01-04 06:58:34 EST --- Just wanted to clarify that point first. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Daniel Berrange berra...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Daniel Berrange berra...@redhat.com 2012-01-04 07:37:28 EST --- New Package SCM Request === Package Name: libosinfo Short Description: A library for managing OS information for virtualization Owners: berrange Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756321] Review Request: csmith - Tool to generate random C programs for compiler testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756321 --- Comment #12 from Jon Ciesla limburg...@gmail.com 2012-01-04 07:58:35 EST --- https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Can you document that these headers meet the criteria for an exception? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771135] Review Request: pykde4 - Python bindings for KDE4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771135 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 738590] Review request: rubygem-gettext_i18n_rails - Simple FastGettext Rails integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738590 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-01-04 08:38:42 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: CSSLint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-01-04 08:39:26 EST --- Summary and SCM pacakge names don't match, please rectify. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-01-04 08:40:20 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-01-04 08:42:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Summary|Review Request: CSSLint - |Review Request: csslint - |Detecting potential |Detecting potential |problems in CSS code|problems in CSS code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-01-04 08:46:42 EST --- This is already done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=77
David Nalley da...@gnsa.us changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|da...@gnsa.us
Flag||fedora-review?
--- Comment #14 from David Nalley da...@gnsa.us 2012-01-04 09:00:23 EST ---
So a couple of additional comments:
1. Please increment the changelog and release every time you make a change.
2. So while I can appreciate that there isn't yet a 'release' and thus you are
building from a point in time - I really have some issues with versioning here,
and think that calling this 1.0 will create headaches for you down the road. (I
am presuming that we don't know if the next release will be 1.0 or 0.1, but
regardless there will be version conflicts.)
I'd propose you take a look at:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
If it were me, I'd set version to:
0.0
and I'd set release to something like:
2.20120104git9e88d7e%{dist}
Also, it's well and fine (if a bit of extra work for the person reviewing your
packages) for you to host your own tarball - but you need to add comments to
tell us how you got their. One of the things about packages is that it should
provide some auditability and repeatability, and while I have faith that you
aren't changing source from upstream, I need to be able to create an identical
tarball, so provide comments under the source URL that shows me how you
generated it so I can generate a replica myself.
See: https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771135] Review Request: pykde4 - Python bindings for KDE4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771135 --- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2012-01-04 09:22:30 EST --- Name: ok, renamed from PyKDE4 Version: ok Summary: ok License: ok URL: not ok (http://techbase.kde.org/Language-bindings leads to empty wiki page), please use http://techbase.kde.org/Development/Languages Sources: ok MD5SUM this package : 30c6201ac88f488bc09b39e572b416d7 MD5SUM upstream package : 30c6201ac88f488bc09b39e572b416d7 Buildroot not needed BRs: ok Obsoletes/provides: ok Package builds: ok This is a package rename of the package already present in Fedora. rpmlint pykde4-4.7.95-10.fc17.src.rpm pykde4.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2012-01-04 09:20:45 EST --- I see only master as a heads. See-http://pkgs.fedoraproject.org/gitweb/?p=ibus-european-table.git I think you got confused with anish's repeated requests. He is still learning to SCM requests. Please add f16 branch for this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771135] Review Request: pykde4 - Python bindings for KDE4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771135 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Jaroslav Reznik jrez...@redhat.com 2012-01-04 09:28:33 EST --- I'm not going to block the review on this warnings but please take care of it = APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-04 09:26:05 EST --- rubygem-rack-protection-1.2.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-rack-protection-1.2.0-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771135] Review Request: pykde4 - Python bindings for KDE4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771135 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Rex Dieter rdie...@math.unl.edu 2012-01-04 09:39:09 EST --- New Package SCM Request === Package Name: pykde4 Short Description: Python bindings for KDE4 Owners: than jreznik ltinkl rnovacek rdieter kkofler dmalcolm Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 --- Comment #9 from anish apa...@redhat.com 2012-01-04 09:43:53 EST --- Thanks Parag and Jon Ciesla. Jon Ciesla , please add f16 branch for this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757657 --- Comment #6 from Petr Pisar ppi...@redhat.com 2012-01-04 09:42:57 EST --- This is not everything. I can still see Lhttp://wxwidgets.org and LWx. FIX: Clean all the marks Oops. I read old spec file. The latest one still contains LWx. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757657
--- Comment #5 from Petr Pisar ppi...@redhat.com 2012-01-04 09:41:00 EST ---
Spec file changes:
--- perl-Wx-Scintilla.spec 2012-01-02 16:58:24.0 +0100
+++ perl-Wx-Scintilla.spec.12012-01-04 11:57:07.0 +0100
@@ -44,7 +44,7 @@
While we already have a good scintilla editor component support via
Wx::StyledTextCtrl in Perl, we already suffer from an older scintilla package
and thus lagging Perl support in the popular Wx Scintilla component. wxWidgets
-Lhttp://wxwidgets.org has a *very slow* release timeline. Scintilla is a
+http://wxwidgets.org has a *very slow* release timeline. Scintilla is a
contributed project which means it will not be the latest by the time a new
wxWidgets distribution is released. And on the scintilla front, the Perl 5
lexer
is not 100% bug free even and we do not have any kind of Perl 6 support in
@@ -61,7 +61,6 @@
rm -rf ./Wx-Scintilla-%{version}/wx-scintilla
%build
-export LDFLAGS=--enable-new-dtags
%{__perl} Build.PL installdirs=vendor optimize=$RPM_OPT_FLAGS
./Build
FIX: wx-scintilla/src/scintilla/License.txt looks like MIT but it is not
exact copy of any wordings from
https://fedoraproject.org/wiki/Licensing/MIT. Please get confirmation
by Fedora legal department. Scintiall variant should appear on the web
page.
I've already sent email to legal. Spot answered it's MIT
http://lists.fedoraproject.org/pipermail/legal/2011-December/001767.html
Ok.
and my wording of license is correct.
I didn't thought your wording. I thought copy of Scintilla MIT variant would
appear on the web page. I thought that each unique wording recognized as a
variant should appear there. Maybe my assumption is wrong.
FIX: Remove POD mark-up from Description text.
-Lhttp://wxwidgets.org has a *very slow* release timeline. Scintilla is a
+http://wxwidgets.org has a *very slow* release timeline. Scintilla is a
This is not everything. I can still see Lhttp://wxwidgets.org and LWx.
FIX: Clean all the marks
FPC ticket: https://fedorahosted.org/fpc/ticket/126
Once you obtain exception, drop a notice here and refer to new spec file with
cleaned description.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771135] Review Request: pykde4 - Python bindings for KDE4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771135 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-01-04 09:49:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-01-04 09:47:52 EST --- File a package change request: https://fedoraproject.org/wiki/Package_SCM_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 738590] Review request: rubygem-gettext_i18n_rails - Simple FastGettext Rails integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738590 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-04 09:54:29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-01-04 09:59:42 EST --- libosinfo-0.0.4-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libosinfo-0.0.4-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 --- Comment #2 from Jaroslav Reznik jrez...@redhat.com 2012-01-04 09:58:18 EST --- Name: ok Summary: ok Version: ok (should be rebased to 4.7.97) License: ok Url: ok (maybe use http://techbase.kde.org/Development/Languages/Qyoto to be consistent?) Sources: ok MD5SUM this package : 1c4d546a57ea7bd772f88312f18d4d4a MD5SUM upstream package : 1c4d546a57ea7bd772f88312f18d4d4a BuildRequires: ok Description: ok (but too long -devel) Macros used consistently: ok Ldconfig found: ok Package builds: ok Doc files: please include also COPYING.LIB and ChangeLog Devel package: ok (no .la, all .so) rpmlint qyoto-4.7.90-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ok rpmlint qyoto-4.7.90-1.fc17.i686.rpm qyoto.i686: W: shared-lib-calls-exit /usr/lib/libqyoto.so.2.0.0 exit@GLIBC_2.0 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ok rpmlint qyoto-devel-4.7.90-1.fc17.i686.rpm qyoto-devel.i686: E: description-line-too-long C This package contains development files for the .NET/Mono bindings for the Qt4 libraries. not ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #16 from Daniel Berrange berra...@redhat.com 2012-01-04 10:02:24 EST --- Built into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-01-04 10:00:31 EST --- libosinfo-0.0.4-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libosinfo-0.0.4-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769437] Review Request: kimono - .NET/Mono bindings for the KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769437 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Daniel Berrange berra...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-04 10:02:39 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770152 Bug 770152 depends on bug 756772, which changed state. Bug 756772 Summary: Review Request: libosinfo - A library for managing OS information for virtualization https://bugzilla.redhat.com/show_bug.cgi?id=756772 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770152 --- Comment #7 from Christophe Fergeau cferg...@redhat.com 2012-01-04 10:15:35 EST --- Updated the .spec, and put an additional srpm at Spec URL: SRPM URL: http://teuf.fedorapeople.org/reviews/gnome-boxes/gnome-boxes-3.3.3-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769450] Review Request: gap-pkg-tomlib - GAP Table of Marks package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769450 --- Comment #1 from Jerry James loganje...@gmail.com 2012-01-04 10:20:01 EST --- I have decided to adopt the Debian naming convention for GAP packages. Accordingly, this package is now named gap-table-of-marks, although (following Debian again) it also Provides: gap-pkg-tomlib. New URLs: http://jjames.fedorapeople.org/gap-table-of-marks/gap-table-of-marks.spec http://jjames.fedorapeople.org/gap-table-of-marks/gap-table-of-marks-1.2.2-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765988] Review Request: mobipocket - A collection of plugins to handle mobipocket files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765988 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730233] Review Request: jboss-jaxrpc-1.1-api - Java API for XML-Based RPC (JAX-RPC) 1.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730233 --- Comment #8 from Pierre-YvesChibon pin...@pingoured.fr 2012-01-04 10:44:09 EST --- ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769437] Review Request: kimono - .NET/Mono bindings for the KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769437 --- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2012-01-04 10:45:25 EST --- Name: ok Summary: ok Version: ok (rebase to 4.7.97) License: GPLv2+ and LGPLv2+ (please, take a look) Url: ok (looks like there's only Qyoto techbase page :( ) Sources: ok MD5SUM this package : 76b3eb69fcc068f4c58995fb1840952b MD5SUM upstream package : 76b3eb69fcc068f4c58995fb1840952b BuildRequires: ok Summary: ok No ldconfig Shouldn't the package structure match the qyoto one with -devel? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770371] Review Request: libva-intel-driver - HW video decode support for Intel integrated graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770371 Adam Jackson a...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||CANTFIX Last Closed||2012-01-04 10:48:27 --- Comment #8 from Adam Jackson a...@redhat.com 2012-01-04 10:48:27 EST --- (In reply to comment #7) That been said, I may have missed another side of the problem raised by ajax: https://bugzilla.redhat.com/show_bug.cgi?id=518546#c38 In this case, it will mean the code may touch codec internals that can be covered. And given that this logic is not implemented in hardware, this will put a perpetual end to any libva intel backend in Fedora. So please close the review if you think it doesn't worth to re-evaluate. From a quick look at the libva-intel driver, it's still clearly doing motion compensation and in-loop-deblocking and a bunch of other actual video codec work in the shaders, not in the hardware. So I don't think this can land in Fedora, sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769437] Review Request: kimono - .NET/Mono bindings for the KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769437 --- Comment #2 from Rex Dieter rdie...@math.unl.edu 2012-01-04 10:47:54 EST --- how does it not match? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768174] Review Request: srm-ifce - Storage Resources Manager client implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768174
--- Comment #12 from Pierre-YvesChibon pin...@pingoured.fr 2012-01-04
10:47:50 EST ---
I believe the following files should be marked as %doc:
%{_docdir}/srm-ifce/LICENSE
%{_docdir}/srm-ifce/RELEASE-NOTES
%{_docdir}/srm-ifce/VERSION
Out of curiosity, is there a reason for the README to be in the -devel package?
Good practices tend to leave an empty line between each entry in the changelog
(entry as in release entry, not every other line).
That all I can see with a quick glance to the spec.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 --- Comment #3 from Rex Dieter rdie...@math.unl.edu 2012-01-04 10:52:15 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdebindings/qyoto.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdebindings/qyoto-4.7.97-1.fc16.src.rpm %changelog * Wed Jan 04 2012 Rex Dieter rdie...@fedoraproject.org 4.7.97-1 - 4.7.97 - devel: make %%description shorter - update URL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225708] Merge Review: dovecot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225708 Michal Hlavinka mhlav...@redhat.com changed: What|Removed |Added AssignedTo|jspal...@gmail.com |nob...@fedoraproject.org Flag|fedora-review?, | |needinfo?(jspal...@gmail.co | |m) | --- Comment #19 from Michal Hlavinka mhlav...@redhat.com 2012-01-04 11:02:24 EST --- no response for a looong time, I've reset assignee of this bug, so anyone else can take it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768174] Review Request: srm-ifce - Storage Resources Manager client implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768174
--- Comment #13 from Mohamed El Morabity pikachu.2...@gmail.com 2012-01-04
11:19:35 EST ---
(In reply to comment #12)
I believe the following files should be marked as %doc:
%{_docdir}/srm-ifce/LICENSE
%{_docdir}/srm-ifce/RELEASE-NOTES
%{_docdir}/srm-ifce/VERSION
It's useless since any file installed in %{_docdir} is automatically tagged as
%doc.
By the way, documentation files are usually installed in
%{_docdir}/%{name}-%{version} (this is where the %doc macro installs standalone
documentation files), even if it's not mandatory (there is no explicit
guidelines about this).
Is there anyway a way to set through cmake the installation path of
documentation?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=765953
--- Comment #4 from Steve ulat...@yahoo.com 2012-01-04 11:41:00 EST ---
I just wanted to point out that on 22-Dec-2011, version 4.7.4 (stable) of qyoto
was released to the kde.org site.
So perhaps the version number should be changed to 4.7.4 and the Source0 URL
should be changed to
ftp://ftp.kde.org/pub/kde/stable/%{version}/src/%{name}-%{version}.tar.bz2 .
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 --- Comment #5 from Rex Dieter rdie...@math.unl.edu 2012-01-04 11:47:04 EST --- We can consider doing 4.7.4 releases, sure, but let's get this into rawhide first (matching kde-4.7.97, aka kde-4.8rc2). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754754] Review Request: perl-Gtk3 - Perl interface to the 3.x series of the gtk+ toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720339] Review Request: perl-smartmatch-engine-core - Default smartmatch implementation from 5.10---5.14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720339 Bug 720339 depends on bug 720267, which changed state. Bug 720267 Summary: Review Request: perl-smartmatch - Pluggable smart matching back-ends https://bugzilla.redhat.com/show_bug.cgi?id=720267 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED Bug 720339 depends on bug 754159, which changed state. Bug 754159 Summary: perl-Devel-CallChecker checks for build-time Perl version https://bugzilla.redhat.com/show_bug.cgi?id=754159 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #3 from Petr Pisar ppi...@redhat.com 2012-01-04 11:51:34 EST --- perl-Devel-CallChecker has been rebuilt. This package build in F17 now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Jaroslav Reznik jrez...@redhat.com 2012-01-04 12:04:57 EST --- Thanks Rex, APPROVED For 4.7.97 I agree with Rex here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Summary|Review Request: qyoto - |Review Request: qyoto - |.NET/Mono Qt bindings |.NET/Mono Qt bindings |library | Flag||fedora-cvs? --- Comment #7 from Rex Dieter rdie...@math.unl.edu 2012-01-04 12:09:00 EST --- New Package SCM Request === Package Name: qyoto Short Description: .NET/Mono Qt bindings Owners: than jreznik ltinkl rnovacek rdieter kkofler Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769437] Review Request: kimono - .NET/Mono bindings for the KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769437 --- Comment #3 from Rex Dieter rdie...@math.unl.edu 2012-01-04 12:16:25 EST --- oh, I guess I just assumed there were not -devel pieces since there were no headers, cmake or pkgconfig pieces. I think I messed up qyoto packaging, that lib*-sharp.so pieces should be in main for runtime use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765953] Review Request: qyoto - .NET/Mono Qt bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765953 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-01-04 12:27:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754754] Review Request: perl-Gtk3 - Perl interface to the 3.x series of the gtk+ toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 --- Comment #5 from Petr Pisar ppi...@redhat.com 2012-01-04 12:38:32 EST --- Source tar ball is original. Ok. Summary verified from lib/Gtk3.pm. TODO: Capitalize the `GTK+' to comply with official name (http://www.gtk.org/). License verified from lib/Gtk3.pm and LICENSE. Ok. URL and Source0 are usable. Ok. Package does not contain any architecture depended code. noarch BuildArch is Ok. Description verified from lib/Gtk3.pm. TODO: Capitalize the `GTK+' to comply with official name (http://www.gtk.org/). TODO: Append slash to the URL as conforming HTTP URL must contain path. FIX: Build-require perl(Carp) for tests (lib/Gtk3.pm:8) TODO: Build-require perl(Exporter) for tests (lib/Gtk3.pm:10) FIX: Build-require perl(Test::More) for tests (t/00-init.t:6) FIX: Build-require perl(Scalar::Util) for tests (t/floating-refs.t:7) TODO: Run tests against Xvfb to perform X11 tests (https://fedoraproject.org/wiki/Perl/Tips#Tests_require_X11_server; actually there is easier way using xvfb-run tool). TODO: Remove useless %defattr from %files section. TODO: Do not package dist.ini and perl-Gtk3.doap. They do not provide any useful data not mentioned anywhere else. All tests pass. Ok. $ rpmlint perl-Gtk3.spec ../SRPMS/perl-Gtk3-0.002-1.fc17.src.rpm ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm perl-Gtk3.src: W: spelling-error Summary(en_US) gtk - Gk, gt, GTE perl-Gtk3.src: W: spelling-error %description -l en_US gtk - Gk, gt, GTE perl-Gtk3.noarch: W: spelling-error Summary(en_US) gtk - Gk, gt, GTE perl-Gtk3.noarch: W: spelling-error %description -l en_US gtk - Gk, gt, GTE 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm drwxr-xr-x2 rootroot0 Jan 4 18:27 /usr/share/doc/perl-Gtk3-0.002 -rw-r--r--1 rootroot24657 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/LICENSE -rw-r--r--1 rootroot 285 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/NEWS -rw-r--r--1 rootroot 289 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/README -rw-r--r--1 rootroot 712 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/dist.ini -rw-r--r--1 rootroot 799 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/perl-Gtk3.doap -rw-r--r--1 rootroot 2632 Jan 4 18:27 /usr/share/man/man3/Gtk3.3pm.gz -rw-r--r--1 rootroot 9665 Dec 9 11:37 /usr/share/perl5/vendor_perl/Gtk3.pm File permissions and layout Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm |sort |uniq -c 1 gtk3 1 perl(Carp) 1 perl(Exporter) 1 perl(Glib) = 1.240 1 perl(Glib::Object::Introspection) 1 perl(Glib::Object::Introspection) = 0.002 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires Ok. TODO: Do not export perl(Glib::Object::Introspection) without version. $ rpm -q --provides -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm |sort |uniq -c 1 perl(Gtk3) = 0.002 1 perl-Gtk3 = 0.002-1.fc17 Binary provides Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3619080). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770152
--- Comment #8 from Adam Huffman bl...@verdurin.com 2012-01-04 13:37:21 EST
---
Thanks for the update. I've installed the requirements from your repo and
tried building the SRPM. It didn't work on F16, but I did manage to build,
install and run it on F17 by manually building some of the dependencies.
Some comments:
- in the changelog, you need to escape the macro, so %%{buildroot}
- did you intend to put something in the %pre section?
- the address in the COPYING file is wrong - please use the most recent version
- it's not required for the review, but please consider including a manpage
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #11 from Guillaume Kulakowski llaum...@gmail.com 2012-01-04 14:39:21 EST --- Summary is Review Request: csslint - Detecting potential problems in CSS code - Review Request: Package Name - Short Description. Where is the problem ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728302
--- Comment #14 from Rex Dieter rdie...@math.unl.edu 2012-01-04 14:41:41 EST
---
point 5 is look in
%{_libdir}/libpjproject.pc file
it's containing
libdir=${exec_prefix}/lib
is wrong on many fedora 64bit platforms (like x86_64) where
_%libdir = /usr/lib64
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 Guillaume Kulakowski llaum...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Guillaume Kulakowski llaum...@gmail.com 2012-01-04 14:42:18 EST --- OK: CSSLINT != csslint. Thanks parag for fix this: https://bugzilla.redhat.com/show_activity.cgi?id=755275 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #5 from Alejandro_Perez alejandro.perez.tor...@gmail.com 2012-01-04 14:44:55 EST --- Added a patch to remove the sheban issue. Added man page generated using this package tool documented in the spec file also added nested.desktop file as Source1 You can review changes at: http://aeperezt.fedorapeople.org/rpmdev/nested-1.2.2-5.fc16.src.rpm http://aeperezt.fedorapeople.org/rpmdev/nested.spec rpmlint results: rpmlint -v SPECS/nested.spec SPECS/nested.spec: I: checking-url http://sourceforge.net/projects/nestededitor/files/nested-1.2.2.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -v RPMS/noarch/nested-1.2.2-5.fc16.noarch.rpm nested.noarch: I: checking nested.noarch: I: checking-url http://nestededitor.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks for you support and advice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #6 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 14:56:58 EST --- I think you didn't quite understand what I said in comment #4. Please don't use macros for mv, rm and so on. They just make the spec file harder to read. ** Also, don't use mv to install files from the build directory to the buildroot. Use cp or install, instead. ** Be sure to preserve time stamps using the -p switch to cp and install. ** Please break %install into columns, it's a mess. ** Also, please separate the %clean section from %install. ** Last, you need to properly install the desktop file as in http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769697
--- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 14:57:40
EST ---
That is: please change %{__python} to python, %{__mv} to mv, %{__cp}
to cp and so on.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-01-04 14:57:31 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #8 from Alejandro_Perez alejandro.perez.tor...@gmail.com 2012-01-04 15:32:53 EST --- Sorry about the misunderstanding here are the changes http://aeperezt.fedorapeople.org/rpmdev/nested-1.2.2-6.fc16.src.rpm http://aeperezt.fedorapeople.org/rpmdev/nested.spec result from rpmlint rpmlint -v RPMS/noarch/nested-1.2.2-6.fc16.noarch.rpm nested.noarch: I: checking nested.noarch: I: checking-url http://nestededitor.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Once again thanks for you support and patients. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #10 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 15:59:21 EST --- Oh, one more thing: the desktop file should simply have Name=Nested -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769697
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 15:58:05
EST ---
Much better.
**
You don't need to use both desktop-file-install and desktop-validate; the
latter is used when the desktop file is installed by, e.g., make install.
**
What does patch1 do? It should be documented in the spec file.
...
I see now that the patch removes the shebang from the txt2tags.py file. In this
case, the patch should be named, e.g., nested-1.2.2-shebang.patch.
The purpose is twofold: first, it identifies which version the patch was
written for, and second, it identifies what the patch does.
Patches are usually prefixed by the name of the package, since in the old days
all sources were in the same directory (but this is of course no longer the
case).
**
Same goes for sources without source URLs (
http://fedoraproject.org/wiki/Packaging/SourceURL ). In this case:
# Desktop file, sent upstream for inclusion
Source1: nested.desktop
**
You are missing
BuildRequires: desktop-file-utils
**
I think you should use %F instead of %f in the desktop file; %F supports
multiple files to be opened.
Also, I think you should add the Utility; category.
**
AFAIK it is standard Fedora practice to use
%{_datadir}/man/man1/nested.1.*
instead of
%{_datadir}/man/man1/nested.1.gz
since it is conceivable that the compression format of man pages might change
in the future. But this is nitpicking.
Please address the issues above before import to git, and send the updated
desktop file upstream. This package has been
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #4 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-04 16:12:54 EST --- It is rather odd that the package uses autotools in some way, but doesn't really use them for the compilation or for the generation of the libraries... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752311 Cédric OLIVIER cedric.oliv...@free.fr changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Cédric OLIVIER cedric.oliv...@free.fr 2012-01-04 16:26:06 EST --- New Package SCM Request === Package Name: gitso Short Description: Gitso is a front-end to reverse VNC connections. It is meant to be a simple two-step process that connects one person to another screen. Owners: cquad Branches: f15 f16 el6 InitialCC: cquad -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 --- Comment #11 from Alejandro_Perez alejandro.perez.tor...@gmail.com 2012-01-04 17:13:33 EST --- Thanks suggestions notice and added. http://aeperezt.fedorapeople.org/rpmdev/nested-1.2.2-7.fc16.src.rpm http://aeperezt.fedorapeople.org/rpmdev/nested.spec Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:19:53 EST --- ruby-rhubarb-0.4.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ruby-rhubarb-0.4.1-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711229] Review Request: ruby-spqr - easy QMF agent framework for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711229 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:24:32 EST --- ruby-spqr-0.3.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ruby-spqr-0.3.5-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711229] Review Request: ruby-spqr - easy QMF agent framework for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711229 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:25:14 EST --- ruby-spqr-0.3.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ruby-spqr-0.3.5-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711229] Review Request: ruby-spqr - easy QMF agent framework for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711229 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711230 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:21:55 EST --- ruby-rhubarb-0.4.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ruby-rhubarb-0.4.1-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769697] Review Request: nested - A specialized editor focused on creating structured documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769697 Alejandro_Perez alejandro.perez.tor...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Alejandro_Perez alejandro.perez.tor...@gmail.com 2012-01-04 17:22:47 EST --- New Package SCM Request === Package Name: Nested Short Description: Specialized editor focused on creating structured documents Owners: aeperezt Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702143] Review Request: wallaby - configuration service for Condor pools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702143 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702143] Review Request: wallaby - configuration service for Condor pools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702143 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:27:33 EST --- wallaby-0.12.4-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wallaby-0.12.4-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502609] Review Request: sblim-cmpi-syslog - SBLIM syslog instrumentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502609 Bug 502609 depends on bug 468400, which changed state. Bug 468400 Summary: getting the SBLIM, openwsman, OMC stacks into Fedora https://bugzilla.redhat.com/show_bug.cgi?id=468400 What|Old Value |New Value Resolution||CURRENTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 702143] Review Request: wallaby - configuration service for Condor pools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702143 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-01-04 17:26:56 EST --- wallaby-0.12.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/wallaby-0.12.4-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756321] Review Request: csmith - Tool to generate random C programs for compiler testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756321 --- Comment #13 from Shakthi Kannan shakthim...@gmail.com 2012-01-04 23:36:51 EST --- I have made a FPC request for this package to include the headers at: https://fedorahosted.org/fpc/ticket/127 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769173] Review Request: english-typing booster - typing booster for english language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769173 anish apa...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771837] New: Review Request: gubbi-fonts - Free Kannada Opentype serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gubbi-fonts - Free Kannada Opentype serif font https://bugzilla.redhat.com/show_bug.cgi?id=771837 Summary: Review Request: gubbi-fonts - Free Kannada Opentype serif font Product: Fedora Version: 16 Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: psatp...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- SPEC Url: http://pravins.fedorapeople.org/gubbi-fonts.spec SRPM Url: http://pravins.fedorapeople.org/gubbi-fonts-1.0-1.fc16.src.rpm Scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3621137 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
