[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 --- Comment #2 from Petr Pisar ppi...@redhat.com 2012-01-06 03:21:13 EST --- TODO: The following BRs are not essential at the moment, however it might change some time in the future. Please, add them: perl(ExtUtils::Installed), Already presents on line 20. perl(File::Find), Done. perl(File::Spec), Already presents on line 11. perl(GetOpt::Long), Why? I cannot find any occurrence of this module in the sources. and perl(File::Temp). Done. TODO: The following BRs are needed for the package to build in f17 mock/koji. Those were originally bundled: perl(CPAN::Meta) Done and perl(Parse::CPAN::Meta) Done. In addition, I've appended perl(ExtUtils::CBuilder) to BuildRequires to proceed optional t/xs.t test. Updated spec and SRPM files are located on the same place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767622] Review Request: unixODBC-gui-qt - Qt tools for unixODBC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767622 --- Comment #8 from Honza Horak hho...@redhat.com 2012-01-06 03:21:38 EST --- (In reply to comment #5) - the source archive is not compressed although it has .gz suffix, you can use fedora-getsvn tool for grabbing the sources Sources are grabbed with fedora-getsvn now. - instead of using cp for installing files you should use either cp -p or (better) install -p -m 644, so the timestamp is kept for the files install -p -m 644 is used now. - licenses as written in README and source files would be GPL+ and LGPL+ because no version is specified, included license texts are irrelevant here (see https://fedoraproject.org/wiki/Licensing/FAQ), clarification with upstream is required, ODBCTestQ4 seems to be GPLv2+, unixODBC library itself is LGPLv2+ Upstream points explicitly to GPL.txt/LGPL.txt files in source now, so GPLv3/LGPLv3 is used. - passing --disable-static to configure should let only the shared libs build, removing the need to rm them Unneeded rm removed. - rpmlint complains a bit: unixODBC-gui-qt.x86_64: W: spelling-error Summary(en_US) plugins - plug ins, plug-ins, plugging ... unixODBC-gui-qt.src: W: spelling-error %description -l en_US plugin - plug in, plug-in, plugging = please fix Fixed. - shouldn't a devel subpackage exist? if not then the *.so links shouldn't be packaged at all unixODBC-gui-qt.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libgtrtstQ4.so unixODBC-gui-qt.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libodbcinstQ4.so = see point above See comment #6. unixODBC-gui-qt-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/unixODBC-gui-qt/ODBCTestQ4/* = should be reported/fixed upstream Reported upstream. Spec URL: http://hhorak.fedorapeople.org/unixodbc-gui-qt/unixODBC-gui-qt.spec SRPM URL: http://hhorak.fedorapeople.org/unixodbc-gui-qt/unixODBC-gui-qt-0-0.3.20120105svn98.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771842] Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771842 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2012-01-06 03:30:35 EST --- Review: + koji scratch build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3621205 + rpmlint on rpms gave navilu-fonts.noarch: W: spelling-error Summary(en_US) opentype - open type, open-type, phenotype navilu-fonts.noarch: W: spelling-error %description -l en_US opentype - open type, open-type, phenotype navilu-fonts.src: W: spelling-error Summary(en_US) opentype - open type, open-type, phenotype navilu-fonts.src: W: spelling-error %description -l en_US opentype - open type, open-type, phenotype 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + source verified with upstream as (sha1sum) eb71807bdfcc479ad5eac07d18da82100a2fd349 navilu-1.1.tar.gz eb71807bdfcc479ad5eac07d18da82100a2fd349 ../SOURCES/navilu-1.1.tar.gz + follows fonts packaging guidelines Suggestions 1) you should drop the versioned dependency. Change BuildRequires: fontforge = 20080429 to BuildRequires: fontforge 2)you don't need to clean buildroot now. remove following from spec BuildRequires: fontforge = 20080429 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771837] Review Request: gubbi-fonts - Free Kannada Opentype serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771837 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2012-01-06 03:30:48 EST --- Review: + koji scratch build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3621137 + rpmlint on rpms gave gubbi-fonts.noarch: W: spelling-error %description -l en_US opentype - open type, open-type, phenotype gubbi-fonts.src: W: spelling-error %description -l en_US opentype - open type, open-type, phenotype 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + source verified with upstream as (sha1sum) 91dd2e35ab6ac58dd3efcf0ee63109e1901a54bb gubbi-1.0.tar.gz 91dd2e35ab6ac58dd3efcf0ee63109e1901a54bb ../SOURCES/gubbi-1.0.tar.gz + follows fonts packaging guidelines Suggestions: 1) you should drop the versioned dependency. Change BuildRequires: fontforge = 20080429 to BuildRequires: fontforge 2)you don't need to clean buildroot now. remove following from spec BuildRequires: fontforge = 20080429 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 --- Comment #3 from Petr Šabata psab...@redhat.com 2012-01-06 03:38:40 EST --- (In reply to comment #2) TODO: The following BRs are not essential at the moment, however it might change some time in the future. Please, add them: perl(ExtUtils::Installed), Already presents on line 20. This was a typo, I meant ExtUtils::Install (in addition to Installed) perl(File::Find), Done. OK perl(File::Spec), Already presents on line 11. True. perl(GetOpt::Long), Why? I cannot find any occurrence of this module in the sources. ./lib/ExtUtils/Command/MM.pm and perl(File::Temp). Done. OK TODO: The following BRs are needed for the package to build in f17 mock/koji. Those were originally bundled: perl(CPAN::Meta) Done OK and perl(Parse::CPAN::Meta) Done. OK In addition, I've appended perl(ExtUtils::CBuilder) to BuildRequires to proceed optional t/xs.t test. Updated spec and SRPM files are located on the same place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771171
--- Comment #2 from Matthias Runge mru...@matthias-runge.de 2012-01-06
04:06:40 EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint django-tastypie-0.9.11-1.fc17.src.rpm
django-tastypie.src: W: spelling-error Summary(en_US) webservice - web
service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US webservice - web
service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US customizable -
customization
django-tastypie.src: W: strange-permission django-tastypie.spec 0666L
django-tastypie.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab:
line 18)
django-tastypie.src: W: invalid-url Source1: django-tastypie-tests.tgz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
rpmlint django-tastypie-0.9.11-1.fc17.noarch.rpm
django-tastypie.noarch: W: spelling-error Summary(en_US) webservice - web
service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US webservice -
web service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US customizable -
customization
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint django-tastypie-doc-0.9.11-1.fc17.noarch.rpm
django-tastypie-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/django-tastypie-0.9.11/html/.buildinfo
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/mrunge/771171/django-tastypie-0.9.11.tar.gz :
MD5SUM this package : 711b29265917405c226f4594782e7e9b
MD5SUM upstream package : 711b29265917405c226f4594782e7e9b
django-tastypie-tests.tgz :
MD5SUM this package : 0e7372f4994b39d7951a3846696a972f
MD5SUM upstream package : upstream source not found
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com Flag||fedora-review? --- Comment #1 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 04:18:14 EST --- I'm taking this one for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=759757
Petr Pisar ppi...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppi...@redhat.com 2012-01-06 04:19:39 EST ---
SPEC file changes:
--- perl-Encode-EUCJPASCII.spec 2011-11-29 11:16:42.0 +0100
+++ perl-Encode-EUCJPASCII.spec.1 2012-01-05 17:19:24.0 +0100
@@ -1,6 +1,6 @@
Name: perl-Encode-EUCJPASCII
Version:0.03
-Release:1%{?dist}
+Release:2%{?dist}
Summary:EucJP-ascii - An eucJP-open mapping
License:GPL+ or Artistic
Group: Development/Libraries
@@ -10,6 +10,12 @@
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Test::More)
BuildRequires: perl(Test::Pod)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Encode)
+BuildRequires: perl(XSLoader)
+BuildRequires: perl(base)
+BuildRequires: perl(Encode::CJKConstants)
+BuildRequires: perl(Encode::JP::JIS7)
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
%{?perl_default_filter}
@@ -22,17 +28,16 @@
%setup -q -n Encode-EUCJPASCII-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE=$RPM_OPT_FLAGS
make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2/dev/null \;
-
+make pure_install DESTDIR=$RPM_BUILD_ROOT
+find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
+# Remove the next line from noarch packages (unneeded)
+find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
+find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2/dev/null ';'
%{_fixperms} $RPM_BUILD_ROOT/*
%check
@@ -45,7 +50,12 @@
%defattr(-,root,root,-)
%doc Changes README
%{perl_vendorarch}/*
+%exclude %dir %{perl_vendorarch}/auto/
%changelog
+* Thu Jan 05 2012 Xavier Bachelot xav...@bachelot.org 0.03-2
+- Follow the rpmdevtools perl spec template to fix packaging bugs.
+- Add missing BuildRequires.
+
* Tue Nov 29 2011 Xavier Bachelot xav...@bachelot.org 0.03-1
- Initial Fedora release.
TODO: Remove useless BuildRoot definition, it's cleaning in %install
section, and whole %clean section. They are not needed anymore.
TODO: Remove useless %defattr from %files section.
Needed for EPEL5, so I'd rather keep them.
Ok.
TODO: Build-require perl(Encode) for tests (EUCJPASCII.pm:6)
TODO: Build-require perl(XSLoader) for tests (EUCJPASCII.pm:7)
TODO: Build-require perl(base) for tests (EUCJPASCII.pm:18)
TODO: Build-require perl(Encode::CJKConstants) for tests (EUCJPASCII.pm:23)
TODO: Build-require perl(Encode::JP::JIS7) for tests (EUCJPASCII.pm:23)
Added.
FIX: Build-require perl(File::Spec) (Makefile.PL:18)
Added.
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Encode)
+BuildRequires: perl(XSLoader)
+BuildRequires: perl(base)
+BuildRequires: perl(Encode::CJKConstants)
+BuildRequires: perl(Encode::JP::JIS7)
Ok.
FIX: Remove empty *.bs files. (These empty bootstrap files for DynaLoader
are
useless.)
Done. The spec is now following more closely the perl spec template, while the
previous version was generated with cpanspec.
+find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
Ok.
I've compared the build log from both the older spec and the newer with the
BuildRequires added, but I don't see a difference, so I'm a bit puzzled... Are
the BRs really needed ?
The Perl modules are used directly by this code, so you need to build-require
them directly too. You cannot assume a module keeps in the the same RPM package
forever (e.g. the Encode is currently part of perl, but If someone decides to
sub-package it into perl-Encode or even dual-live it as packe sourced from
CPAN, this will not be true anymore) or a module keeps available through
indirect dependency (like File::Spec packaged as perl-PathTools).
$ rpmlint perl-Encode-EUCJPASCII.spec
../SRPMS/perl-Encode-EUCJPASCII-0.03-2.fc17.src.rpm
../RPMS/x86_64/perl-Encode-EUCJPASCII-*
perl-Encode-EUCJPASCII.src: W: spelling-error Summary(en_US) eucJP - eggcup,
equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US eucJP -
eggcup, equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US ascii -
ASCII, ASCIIs, As
perl-Encode-EUCJPASCII.x86_64: W: spelling-error Summary(en_US) eucJP -
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US eucJP -
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US ascii -
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 --- Comment #3 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 04:41:42 EST --- Thanks for your review! - I corrected the permissions and tabs/spaces. - As for the test error Error: No module named oauth_provider, this would need django-oauth-plus (see [1]), which is not yet in Fedora (and some of its dependencies aren't there too, if I recall it correctly), so I would leave it this way for the time being. As soon as django-oauth-plus gets into Rawhide (if I manage to get some time, I will package it), I will rebuild with all the tests. Is this a blocker for you? - The upstream source for the tests doesn't in fact exist - you have to download them separately from the Github, as they are not included in the package downloaded from pypy. I believe that running tests is important and this is probably the best way to get them. These are the files with your comments incorporated: SPEC: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie-0.9.11-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624230 [1] https://github.com/toastdriven/django-tastypie/issues/323 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Matthias Runge mru...@matthias-runge.de 2012-01-06 04:50:45 EST --- Great, APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759757 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Xavier Bachelot xav...@bachelot.org 2012-01-06 04:55:21 EST --- Thanks for the review and explanations. New Package SCM Request === Package Name: perl-Encode-EUCJPASCII Short Description: EucJP-ascii - An eucJP-open mapping Owners: xavierb Branches: f15 f16 el5 el6 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771851
--- Comment #2 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 05:02:32
EST ---
- BuildRequires: python-devel should be BuildRequires: python2-devel, see [1].
- When packaging for Fedora 13 or greater, you don't need to define
%python_sitelib yourself, because its in a macro file in python2-devel, see
[2].
- Could you please specify why you need the two identical files in %{_bindir},
only with different names? It is an upstream decision, but maybe you could
query them about this?
- The package seems to have a bundled library python-chardet, which is already
in Fedora. You should unbundle it and make the Fedora package runtime
dependency. (Perhaps query the upstream not to bundle it at all?)
- You probably don't need to use the CFLAGS in %build section, as your package
doesn't contain any binary extensions.
- rm -rf $RPM_BUILD_ROOT is not needed, if you don't plan on getting the
package to EPEL.
- Could you please clarify the LICENSE? Your specfile says GPLv2+, but PKG-INFO
only says GPL.
[1] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[2] https://fedoraproject.org/wiki/Packaging:Python#Macros
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #3 from Matthias Runge mru...@matthias-runge.de 2012-01-06 05:09:11 EST --- Thank you for your review. I'll resolve those questions/issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 --- Comment #4 from Petr Pisar ppi...@redhat.com 2012-01-06 05:06:18 EST --- This was a typo, I meant ExtUtils::Install (in addition to Installed) I add it into build-time and run-time dependencies. perl(GetOpt::Long), Why? I cannot find any occurrence of this module in the sources. ./lib/ExtUtils/Command/MM.pm I see, Getopt::Long. I added it into run-time dependencies too. New package published on the same address. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com 2012-01-06 05:15:04 EST --- Looks good now, approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767622] Review Request: unixODBC-gui-qt - Qt tools for unixODBC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767622 Dan Horák d...@danny.cz changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Dan Horák d...@danny.cz 2012-01-06 05:31:17 EST --- All issues are fixed or explained, the package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 05:39:16 EST --- Thanks again, Matthias. New Package SCM Request === Package Name: django-tastypie Short Description: Tastypie is an webservice API framework for Django Owners: bkabrda Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 --- Comment #6 from Petr Pisar ppi...@redhat.com 2012-01-06 05:53:49 EST --- New Package SCM Request === Package Name: perl-ExtUtils-MakeMaker Short Description: Create a module Makefile Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766083] Fedora 17 feature Derelict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766083 --- Comment #7 from MERCIER Jonathan bioinfornat...@gmail.com 2012-01-06 06:29:52 EST --- fix License to Boost: http://bioinfornatics.fedorapeople.org/derelict-2-17.2006svn593.fc16.src.rpm http://bioinfornatics.fedorapeople.org/derelict.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 734531] Review Request: unison240 - File synchronisation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734531 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com AssignedTo|nob...@fedoraproject.org|brendan.jones...@gmail.com Flag||fedora-review? --- Comment #17 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 07:09:11 EST --- I will review this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767622] Review Request: unixODBC-gui-qt - Qt tools for unixODBC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767622 Honza Horak hho...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Honza Horak hho...@redhat.com 2012-01-06 07:12:57 EST --- New Package SCM Request === Package Name: unixODBC-gui-qt Short Description: Several GUI (Qt) programs and plug-ins for unixODBC Owners: hhorak tgl Branches: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765988] Review Request: mobipocket - A collection of plugins to handle mobipocket files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765988 --- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2012-01-06 07:11:43 EST --- Seems like upstream wants to rename this package to kdegraphics-mobipocket for final 4.8 release due to worries from Amazon. So it'd would be great to update it now to this new name (not yet done but I expect it's going to be done for final) now before we would need to go through another re-review due to package rename. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648549] Review Request: spice-vdagent - Agent for Spice guests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648549 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #16 from Hans de Goede hdego...@redhat.com 2012-01-06 07:34:21 EST --- Package Change Request == Package Name: spice-vdagent New Branches: el5 Owners: jwrdegoede I would like to introduce spice-vdagent as an EPEL-package for EL5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 --- Comment #17 from Hans de Goede hdego...@redhat.com 2012-01-06 07:40:24 EST --- (In reply to comment #16) Hans, do I need to do something more before being sponsored or you missed my reply in comment #14 to your request of my FAS login? I missed your reply. I've added you to the packager group in FAS and sponsored you now. So you can now continue with the next steps of: http://fedoraproject.org/wiki/PackageMaintainers/Join -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754754] Review Request: perl-Gtk3 - Perl interface to the 3.x series of the GTK+ toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 Daniel Berrange berra...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-06 08:05:08 --- Comment #10 from Daniel Berrange berra...@redhat.com 2012-01-06 08:05:08 EST --- Built into rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754754] Review Request: perl-Gtk3 - Perl interface to the 3.x series of the GTK+ toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-06 08:05:47 EST --- perl-Gtk3-0.002-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Gtk3-0.002-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772217] New: Review Request: libyuv - YUV conversion and scaling functionality library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libyuv - YUV conversion and scaling functionality library https://bugzilla.redhat.com/show_bug.cgi?id=772217 Summary: Review Request: libyuv - YUV conversion and scaling functionality library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lemen...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://peter.fedorapeople.org/WebRTC/libyuv.spec SRPM URL: http://peter.fedorapeople.org/WebRTC/libyuv-0-0.1.20120105svn127.fc16.src.rpm Description: libyuv is an open source project that includes YUV conversion and scaling functionality. Converts all webcam formats to YUV (I420). Convert YUV to formats for rendering/effects. Rotate by 90 degrees to adjust for mobile devices in portrait mode. Scale YUV to prepare content for compression, with point, bilinear or box filter. This is one of the requirements for WebRTC. Koji scratchbuild for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624661 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #3 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:15:06 EST --- I'll review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:14:29 EST --- I'll review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754004 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:14:48 EST --- I'll review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 --- Comment #14 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:23:23 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648549] Review Request: spice-vdagent - Agent for Spice guests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648549 --- Comment #17 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:20:42 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767622] Review Request: unixODBC-gui-qt - Qt tools for unixODBC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767622 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:23:57 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:21:17 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759757 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:22:55 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #2 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:25:26 EST --- Failed to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624781 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769173] Review Request: english-typing-booster typing booster for english language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769173 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:29:27 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772229] New: Review Request: perftest - Performance testing programs for InfiniBand networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perftest - Performance testing programs for InfiniBand networks https://bugzilla.redhat.com/show_bug.cgi?id=772229 Summary: Review Request: perftest - Performance testing programs for InfiniBand networks Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- The perftest utilities are used to perform performance testing on InfiniBand or other RDMA based networks. They do not run on non-RDMA networks. Sample packages can be found at the URL above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754004 --- Comment #2 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:29:44 EST --- Failed to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624813 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 --- Comment #4 from Peter Lemenkov lemen...@gmail.com 2012-01-06 09:30:26 EST --- Failed to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624818 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:32:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772233] New: Review Request: mstflint - Mellanox firmware burning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mstflint - Mellanox firmware burning utility https://bugzilla.redhat.com/show_bug.cgi?id=772233 Summary: Review Request: mstflint - Mellanox firmware burning utility Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- The mstflint package is used to burn new firmware to Mellanox based InfiniBand or 10GigE network adapters. As the Mellanox cards are highly intelligent, the firmware is used to enable various advanced features. Frequently, bugs are fixed via new firmware versions. The ability to update the firmware is consequently very important on Mellanox cards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770796] Review Request: rubygem-gstreamer - Ruby binding of GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770796 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-01-06 09:31:52 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772234] New: Review Request: qperf - Performance testing utility for RDMA networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: qperf - Performance testing utility for RDMA networks https://bugzilla.redhat.com/show_bug.cgi?id=772234 Summary: Review Request: qperf - Performance testing utility for RDMA networks Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- qperf is another testing program for InfiniBand/RDMA networks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754004 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 09:56:28 EST --- lv2core has been updated prior to raising this bug. I thought this would come up. Removed lv2config SPEC: http://bsjones.fedorapeople.org/lv2-abGate.spec SRPM: http://bsjones.fedorapeople.org/lv2-abGate-1.1.3-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 Guillermo Gómez guillermo.go...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Guillermo Gómez guillermo.go...@gmail.com 2012-01-06 10:00:34 EST --- New Package SCM Request === Package Name: rubygem-kgio Short Description: Kinder, gentler I/O for Ruby Owners: gomix Branches: f15 f16 el5 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 --- Comment #5 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 10:04:31 EST --- Updated for new lv2core SPEC: http://bsjones.fedorapeople.org/lv2-avw-plugins.spec SRPM: http://bsjones.fedorapeople.org/lv2-avw-plugins-0.0.5-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 10:02:37 EST --- Updated for new lv2core (see bug #771997) SRPM: http://bsjones.fedorapeople.org/lv2-kn0ck0ut-1.1-0.2.gitd03e8db0.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/lv2-kn0ck0ut.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758211] Review Request: perl-ExtUtils-MakeMaker - Create a module Makefile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758211 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-ExtUtils-MakeMaker-6.6 ||2-1.fc17 Resolution||RAWHIDE Last Closed||2012-01-06 10:03:04 --- Comment #8 from Petr Pisar ppi...@redhat.com 2012-01-06 10:03:04 EST --- Thank you for the (very important) review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added Flag||fedora-cvs? --- Comment #18 from Mattia Verga mattia.ve...@tiscali.it 2012-01-06 10:06:29 EST --- Package Change Request == Package Name: kde-partitionmanager Owners: [Orphaned] I would like to own the orphaned package 'kde-partitionmanager'. My FAS login is 'mattia'. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] New: Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rds-tools - utilities for testing rds protocol networking https://bugzilla.redhat.com/show_bug.cgi?id=772243 Summary: Review Request: rds-tools - utilities for testing rds protocol networking Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- The rds network protocol was created mainly for Oracle and is used heavily by Oracle in the latest generation RAC products. The protocol is basically UDP with a reliability guarantee, and RDS stands for Reliable Datagram Service. These utilities allow a user to test the RDS stack in the kernel to make sure it is properly configured and operational. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-01-06 10:17:07 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 --- Comment #19 from Jon Ciesla limburg...@gmail.com 2012-01-06 10:16:34 EST --- I'm not sure what you need here. You already own this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 --- Comment #20 from Kevin Kofler ke...@tigcc.ticalc.org 2012-01-06 10:19:37 EST --- The procedure to take ownership of packages which are orphaned but not retired is to log in at: https://admin.fedoraproject.org/pkgdb/acls/name/kde-partitionmanager and take ownership of the package. I see that either you have already done that or an administrator has done that for you. So no (further) admin action is needed. (I see Jon Ciesla has already cleared the fedora-cvs flag.) By the way, rereviews are normally not needed for packages which recently got orphaned and are not retired yet. (In this case, you had to get sponsored though. But now that you are sponsored, you can just claim (recently) orphaned packages.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Peter Lemenkov lemen...@gmail.com 2012-01-06 10:30:39 EST
---
Successful Koji scratchbuild for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3624978
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~/temp: rpmlint *
lv2-abGate.src: I: enchant-dictionary-not-found en_US
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
work ~/temp:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv3
or later).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum abGate-1.1.3.tar.gz*
f1f65e4e05038c7cbff05463ebb423213ce99603db58f7802a10f4d8e735abf5
abGate-1.1.3.tar.gz
f1f65e4e05038c7cbff05463ebb423213ce99603db58f7802a10f4d8e735abf5
abGate-1.1.3.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
0 The package DOESN'T have a %clean section, so it won't build cleanly on
systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755079] Review Request: condor-wallaby-base-db - A condor database for wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755079 Robert Rati rr...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Robert Rati rr...@redhat.com 2012-01-06 10:44:47 EST --- New Package SCM Request === Package Name: condor-wallaby-base-db Short Description: A wallaby database containing condor configuration data Owners: rrati Branches: f15 f16 InitialCC: matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576591] Review Request: iptraf-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576591 --- Comment #30 from Terje Røsten terje...@phys.ntnu.no 2012-01-06 10:42:47 EST --- Please create a proper SCM request: http://fedoraproject.org/wiki/Package_SCM_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #4 from Peter Lemenkov lemen...@gmail.com 2012-01-06 10:45:39 EST --- Koji build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624984 Unfortunately I found one unexpected legal issue. It is written in readme.txt that Kn0ck0ut is freeware and beta. No warranty, no support. The plugin may be redistributed but only for free, and only with this readme file. We do allow distributing Fedora for profit so this will violate our policies (and this isn't compatible with GPL as well). Could you please clarify what exactly original authors mean by this clause? This could be a leftover from some ancient times btw. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765988] Review Request: kdegraphics-mobipocket - A collection of plugins to handle mobipocket files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765988 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Summary|Review Request: mobipocket |Review Request: |- A collection of plugins |kdegraphics-mobipocket - A |to handle mobipocket files |collection of plugins to ||handle mobipocket files --- Comment #2 from Rex Dieter rdie...@math.unl.edu 2012-01-06 10:45:51 EST --- SPEC: http://rdieter.fedorapeople.org/rpms/kdegraphics/kdegraphics-mobipocket.spec http://rdieter.fedorapeople.org/rpms/kdegraphics/kdegraphics-mobipocket-4.7.97-1.fc16.src.rpm %changelog * Fri Jan 06 2012 Rex Dieter rdie...@fedoraproject.org 4.7.97-1 - 4.7.97 - pkg renamed to kdegraphics-mobipocket -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 --- Comment #6 from Peter Lemenkov lemen...@gmail.com 2012-01-06 10:55:00 EST --- Koji scratchbuild for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624981 Please build it using system-wide waf (see yum info waf for details) of explain why it's necessary to use bundled version over system-wide one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755079] Review Request: condor-wallaby-base-db - A condor database for wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755079 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-01-06 11:00:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772260] New: Review Request: srptools - utilities for mounting SRP shared resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: srptools - utilities for mounting SRP shared resources https://bugzilla.redhat.com/show_bug.cgi?id=772260 Summary: Review Request: srptools - utilities for mounting SRP shared resources Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- SRP is the SCSI RDMA Protocol and servers that provide SRP devices allow clients to treat them as local SCSI disks. The srptools package includes a daemon that is responsible for connecting to remote SRP devices and presenting them to the kernel as a local SCSI disk. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730620] Review Request: infiniband-diags - OpenFabrics Alliance InfiniBand Diagnostic Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730620 Doug Ledford dledf...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2012-01-06 11:25:05 --- Comment #4 from Doug Ledford dledf...@redhat.com 2012-01-06 11:25:05 EST --- Closing this out so I can submit the request myself as agreed with Albert. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 726690] Review Request: rubygem-rails2.3 - rails 2 alongside rails 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726690 Bug 726690 depends on bug 728256, which changed state. Bug 728256 Summary: Review Request: rubygem-activesupport2.3 - rails 2 alongside rails 3 https://bugzilla.redhat.com/show_bug.cgi?id=728256 What|Old Value |New Value Resolution||NEXTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728249] Review Request: rubygem-activerecord2.3 - rails 2 alongside rails 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728249 Bug 728249 depends on bug 728256, which changed state. Bug 728256 Summary: Review Request: rubygem-activesupport2.3 - rails 2 alongside rails 3 https://bugzilla.redhat.com/show_bug.cgi?id=728256 What|Old Value |New Value Resolution||NEXTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728255] Review Request: rubygem-activeresource2.3 - rails 2 alongside rails 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728255 Bug 728255 depends on bug 728256, which changed state. Bug 728256 Summary: Review Request: rubygem-activesupport2.3 - rails 2 alongside rails 3 https://bugzilla.redhat.com/show_bug.cgi?id=728256 What|Old Value |New Value Resolution||NEXTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770740
adev ade...@gmail.com changed:
What|Removed |Added
CC||ade...@gmail.com
--- Comment #3 from adev ade...@gmail.com 2012-01-06 11:25:57 EST ---
Hi,
Quick comments about your spec file :
- use the %{_isa} macro for your Requires dependencies on binary packages.
- -DCMAKE_INSTALL_PREFIX=/usr is useless, it is already included in the
%cmake macro
- %{_libdir} could be used instead of /usr/lib64/ with your cmake command
- same with %{_includedir} instead of /usr/include
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755104] Review Request: condor-wallaby - condor related tools for interacting with wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 --- Comment #2 from Robert Rati rr...@redhat.com 2012-01-06 11:27:21 EST --- Fixed the issues, with a few exceptions. The obsolete not provided is for a package that never existed in fedora. I've handled it with a conditional for the binaries, but the srpm will still show the warning. I've also changed the config without noreplace file to a regular non-config file. The file is in /etc, but contains condor config snipets that shouldn't be edited by the user. If the user wants to modify things, they should create their own config file and have it parsed last. Spec URL: http://rrati.fedorapeople.org/condor-wallaby.spec SRPM URL: http://rrati.fedorapeople.org/condor-wallaby-4.1.2-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 --- Comment #7 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 11:48:11 EST --- Thanks for the review! I've come across this before - there is no Fedora packaging policy regarding waf (for good reason). waf upstream actually recommends bundling within the package - it was never designed to be like autotools. Backwards compatibility has never been a design requirement of waf. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755079] Review Request: condor-wallaby-base-db - A condor database for wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755079 Robert Rati rr...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-01-06 11:50:31 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755079] Review Request: condor-wallaby-base-db - A condor database for wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755079 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-01-06 11:56:13 EST --- condor-wallaby-base-db-1.18-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/condor-wallaby-base-db-1.18-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755079] Review Request: condor-wallaby-base-db - A condor database for wallaby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755079 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-01-06 11:58:14 EST --- condor-wallaby-base-db-1.18-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/condor-wallaby-base-db-1.18-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #5 from Brendan Jones brendan.jones...@gmail.com 2012-01-06 12:02:21 EST --- Thanks again for the review! I was just about to hit send to upstream about this and then realised that the text you quoted is from the original readme of the VST plugin. I'm not sure it applies to the package in this case but the port author has included it as per the readme. I will still send upstream a query however... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772284] New: Review Request: libnl3 - convenience library for kernel netlink API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libnl3 - convenience library for kernel netlink API https://bugzilla.redhat.com/show_bug.cgi?id=772284 Summary: Review Request: libnl3 - convenience library for kernel netlink API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: d...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://bigw.org/~dan/libnl3.spec SRPM URL: http://bigw.org/~dan/libnl3-3.2.3-1.fc16.src.rpm Description: libnl3 is intended to supplant the existing libnl package over time, but to ensure smooth updates we need to keep the old libnl package around for a while too since many things depend on it, and the API/ABI changed significantly between libnl1 and libnl3. Since libnl3 is parallel installable with libnl1, I elected to create a new libnl3 package much like we have glib/glib2 etc. NetworkManager 0.9.4 will depend on libnl3 for features such as bonding, bridging, and VLANs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #12 from Michal Ambroz re...@seznam.cz 2012-01-06 12:07:23 EST --- Hello Ivan, (In reply to comment #11) Did you increase the version? Add this to changelog too. I am not quite sure what you mean? Yes I used new version. Yes it is in the change log of the SPEC file: * Thu Jan 05 2012 Michal Ambroz rebus at, seznam.cz 0.06-1 - added Group field - FSF address and manpage was fixed upstream Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226327] Merge Review: pvm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226327 Doug Ledford dledf...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Last Closed||2012-01-06 12:15:29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772288] New: Review Request: infiniband-diags - various InfiniBand fabric test utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: infiniband-diags - various InfiniBand fabric test utilities https://bugzilla.redhat.com/show_bug.cgi?id=772288 Summary: Review Request: infiniband-diags - various InfiniBand fabric test utilities Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dledf...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- The infiniband-diags package provides a number of utilities for querying the state of an InfiniBand fabric. It can get the detailed information on any given port on the fabric for diagnostic purposes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768545] Review Request: blktap - blktap user space utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 David Nalley da...@gnsa.us changed: What|Removed |Added Status|VERIFIED|ASSIGNED --- Comment #4 from David Nalley da...@gnsa.us 2012-01-06 12:23:13 EST --- (In reply to comment #3) FAILSHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [25] https://github.com/xen-org/blktap/issues/1 Done FAILSHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [26] There's no i18n support in this, so NA IMO. - moreover, I can't translate to anything. FAILSHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.[32] I requested that upstream should create said man pages here: https://github.com/xen-org/blktap/issues/2 In addition I discovered that libtool archives were being built and packaged. I stripped these from the -devel package. New SPEC: http://ke4qqq.fedorapeople.org/blktap.spec New SRPM: http://ke4qqq.fedorapeople.org/blktap-2.0.90-2.git20111216.62de90d.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768545] Review Request: blktap - blktap user space utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 --- Comment #5 from David Nalley da...@gnsa.us 2012-01-06 12:24:11 EST --- Eric - I see that you flagged this as fedora-review+ - does that mean you approved, or just a mis-selection? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #13 from Ivan Romanov dr...@land.ru 2012-01-06 12:50:05 EST --- * Thu Jan 05 2012 Michal Ambroz rebus at, seznam.cz 0.06-1 - added Group field - FSF address and manpage was fixed upstream - updated to nwipe 0.06 I looked at last .spec and not immediately understood that you upgrade app. When you update program version you should note it in changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760270
--- Comment #8 from Peter Lemenkov lemen...@gmail.com 2012-01-06 12:45:57 EST
---
(In reply to comment #7)
Thanks for the review! I've come across this before - there is no Fedora
packaging policy regarding waf (for good reason). waf upstream actually
recommends bundling within the package - it was never designed to be like
autotools. Backwards compatibility has never been a design requirement of waf.
Ok, understood.
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent
work ~/temp: rpmlint *
lv2-avw-plugins.src: I: enchant-dictionary-not-found en_US
lv2-avw-plugins.x86_64: E: incorrect-fsf-address
/usr/share/doc/lv2-avw-plugins-0.0.5/COPYING
^^^ You should notice upstream about that but this is not a blocker. Also there
is another licensing issue (see below).
3 packages and 0 specfiles checked; 1 errors, 0 warnings.
work ~/temp:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
- The package looks like licensed with a Fedora approved license but it's
unclear under which one exactly. The sources doesn't contain any traces of
licensing headers, the attached COPYING contains GPLv2 and website claims that
the software is licensed under GPLv3. Please ask upstream developer(s) about
the exact licensing status of this software.
0 The file, containing the text of the license(s) for the package, is included
in %doc. Well this is useless until previous issue is unresolved.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
work ~/temp: sha256sum avw.lv2.0.0.5.tar.gz*
ae43e9b9ae8d7043b03d372e2ba4a54968c699309ea4a59f75a65313cd866850
avw.lv2.0.0.5.tar.gz
ae43e9b9ae8d7043b03d372e2ba4a54968c699309ea4a59f75a65313cd866850
avw.lv2.0.0.5.tar.gz.1
work ~/temp:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See Koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+/- The package does NOT bundle copies of system libraries (except waf, which
is used only for building). Honestly I advise you try to build it with a
system-wide copy.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
0 The package DOESN'T have a %clean section, so it won't build cleanly on
systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application. Well, not a stand-alone GUI app. It doesn lonks
against graphical libraries but it seems that it isn't intended to run from a
user's desktop.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Almost finished.
Please,
* Clarify licensing.
* Try to build it with system-wide waf.
And I will finish this review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-01-06 13:15:10 EST --- rubygem-kgio-2.7.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-kgio-2.7.0-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731515] Review Request: qtweetlib - Qt Twitter library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731515 Magnus Tuominen magnus.tuomi...@gmail.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731515] Review Request: qtweetlib - Qt Twitter library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731515
Magnus Tuominen magnus.tuomi...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||magnus.tuomi...@gmail.com
--- Comment #2 from Magnus Tuominen magnus.tuomi...@gmail.com 2012-01-06
13:24:09 EST ---
This is the review:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
rpmlint -iv qtweetlib.spec
qtweetlib.spec: I: checking-url
https://github.com/downloads/minimoog/QTweetLib/QTweetLib-0.3.0.tar.gz (timeout
10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint -iv qtweetlib-0.3.0-1.fc16.src.rpm
qtweetlib.src: I: checking
qtweetlib.src: I: checking-url https://github.com/minimoog/QTweetLib/ (timeout
10 seconds)
qtweetlib.src: I: checking-url
https://github.com/downloads/minimoog/QTweetLib/QTweetLib-0.3.0.tar.gz (timeout
10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: The package must be named according to the Package Naming Guidelines.
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
MUST: The package must meet the Packaging Guidelines.
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK GPLv2.1
MUST: The License field in the package spec file must match the actual license.
OK GPLv2.1
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
MUST: The spec file must be written in American English.
OK
MUST: The spec file for the package MUST be legible.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
src.rpm:a37055e7c081049294efb42126933cef
upstream: a37055e7c081049294efb42126933cef
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK, x86_64 tested
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
NA
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
OK
MUST: Packages must NOT bundle copies of system libraries.
OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
NA
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK
MUST: Each package must consistently use macros.
OK
MUST: The package must contain code, or permissable content.
OK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
OK
MUST: Header files must be in a -devel package.
OK
MUST: Static libraries must be in a -static package.
OK
MUST: If a package contains library
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-06 13:21:57 EST --- rubygem-kgio-2.7.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-kgio-2.7.0-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731515] Review Request: qtweetlib - Qt Twitter library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731515 Magnus Tuominen magnus.tuomi...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|magnus.tuomi...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-06 13:26:46 EST --- rubygem-kgio-2.7.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-kgio-2.7.0-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731515] Review Request: qtweetlib - Qt Twitter library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731515 Magnus Tuominen magnus.tuomi...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Magnus Tuominen magnus.tuomi...@gmail.com 2012-01-06 13:42:11 EST --- Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 --- Comment #28 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-01-06 13:57:29 EST --- I think we can continue there than? Please provide package which use shared qjdns. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #14 from Michal Ambroz re...@seznam.cz 2012-01-06 14:17:09 EST --- Will do ... please do you have got some more blocking comments? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 Ivan Romanov dr...@land.ru changed: What|Removed |Added Flag||fedora-review? --- Comment #15 from Ivan Romanov dr...@land.ru 2012-01-06 14:26:09 EST --- I don't yet do a formal review. But now I can start. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 --- Comment #29 from Rex Dieter rdie...@math.unl.edu 2012-01-06 14:38:19 EST --- yes, here you go... http://rdieter.fedorapeople.org/rpms/tomahawk/jreen.spec http://rdieter.fedorapeople.org/rpms/tomahawk/jreen-1.0.1-1.fc16.src.rpm %changelog * Fri Jan 06 2012 Rex Dieter rdie...@fedoraproject.org 1.0.1-1 - 1.0.1 - -DJREEN_USE_SYSTEM_JDNS:BOOL=ON -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771123] Review Request: fex - Field split/extraction like cut/awk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771123 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771123] Review Request: fex - Field split/extraction like cut/awk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771123 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added CC||mattia.ve...@tiscali.it AssignedTo|nob...@fedoraproject.org|mattia.ve...@tiscali.it Flag||fedora-review? --- Comment #1 from Mattia Verga mattia.ve...@tiscali.it 2012-01-06 14:40:55 EST --- I'm going to review this in the next few days (maybe tomorrow). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771851
--- Comment #4 from Matthias Runge mru...@matthias-runge.de 2012-01-06
14:46:16 EST ---
updated version:
SPEC: http://www.matthias-runge.de/fedora/python-ladon.spec
(old version, for reference:
http://www.matthias-runge.de/fedora/python-ladon-1.spec )
SRPM: http://www.matthias-runge.de/fedora/python-ladon-0.6.5-2.fc16.src.rpm
Upstream clarified, license is lgpv3+, updated PKG-INFO on
http://pypi.python.org/pypi/ladon
Bundled library is kept upstream for missing reference for chardet (chardet's
upstream is gone). It should be save to remove ladons bundled lib chardet_py2
and replace the only reference to bundled lib to fedoras version of chardet.
CFLAGS removed, buildroot-removal deleted.
for easier reference:
[mrunge@sofja SPECS]$ diff -u python-ladon-1.spec python-ladon.spec ---
python-ladon-1.spec 2012-01-06 20:31:08.574775992 +0100
+++ python-ladon.spec 2012-01-06 20:44:47.248475349 +0100
@@ -1,18 +1,17 @@
-%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
-
Name: python-ladon
Version:0.6.5
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Multiprotocol approach to creating a webservice
-License:GPLv2
+License:LGPLv3+
URL:http://ladonize.org
Source0:
http://pypi.python.org/packages/source/l/ladon/ladon-%{version}.tar.gz
# #md5=07dd1d395d0d7123448d7710bb3da32a
BuildArch: noarch
-BuildRequires: python-devel
+BuildRequires: python2-devel
Requires: python-jinja2
+Requires: python-chardet
%description
Ladon is a framework for exposing methods to several internet service
@@ -24,22 +23,33 @@
%prep
%setup -q -n ladon-%{version}
+# replace reference to bundled lib with fedora's reference
+sed -i 's/chardet_py2/chardet/' src/ladon/ladonizer/collection.py
%build
-CFLAGS=$RPM_OPT_FLAGS %{__python} setup.py build
+%{__python} setup.py build
%install
-rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
-chmod 755 /%{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+chmod 755 %{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+
+# remove file included for windows-builds
+rm %{buildroot}/%{_bindir}/ladon2.7ctl.py
+
+# remove bundled library
+rm -rf %{buildroot}/%{python_sitelib}/chardet_py2
%files
%doc PKG-INFO
%{python_sitelib}/*
%{_bindir}/ladon2.7ctl
-%{_bindir}/ladon2.7ctl.py
%changelog
+* Fri Jan 06 2012 Matthias Runge mru...@matthias-runge.de - 0.6.5-2
+- remove unecessary definition, buildroot cleaning
+- remove bundled library chardet_py2, correct reference to use fedora's
version
+- correct build requirements
+
* Wed Jan 04 2012 Matthias Runge mru...@matthias-runge.de - 0.6.5-1
- initial fedora package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 --- Comment #12 from Rex Dieter rdie...@math.unl.edu 2012-01-06 15:05:03 EST --- http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.3.3-1.fc16.src.rpm %changelog * Fri Jan 06 2012 Rex Dieter rdie...@fedoraproject.org 0.3.3-1 - 0.3.3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 --- Comment #30 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-01-06 15:02:04 EST --- $ rpmlint * jreen.src: W: invalid-url URL: https://github.com/eurolessar/jreen HTTP Error 404: Not Found 1) It must be https://github.com/euroelessar/jreen jreen.src: W: invalid-url Source0: jreen-1.0.1.tar.xz jreen.spec: W: invalid-url Source0: jreen-1.0.1.tar.xz 1 packages and 1 specfiles checked; 0 errors, 3 warnings. 2) As you built stable versions please use upstream tarballs from tags: https://github.com/euroelessar/jreen/tags 3) Please delete bundled libs instead of renaming directory. 4) Build of package failed on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3625703 5) require libidn as runtime requirement (not BuildRequires) missed. 6) Don't see libnice in any requirements. 7) Runtime dependency to qca-ossl also not in spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
