[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772504
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at 2012-01-09 03:12:12 EST
---
I think the package summary does not describe the package very well. The
description gave me a completely different view.
Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
the clean section, buildroot definition and the rm in the install section.
Please use the name macro, as you did in Source. Looking at your manpage, you
forgot a d in %{_localstatedir}/lib/btkbd.
There's a macro called sharedstatedir, by the way, that is equivalent to
%{_localstatedir}/lib.
The FSF address is outdated.
Why do you want to own %{_sysconfdir}/udev/rules.d?
Why do you require pod2man explicitly?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|needinfo?(hdegoede@redhat.c | |om) | --- Comment #5 from Hans de Goede hdego...@redhat.com 2012-01-09 03:46:39 EST --- Dan, Brendan, I was not aware that FlightCrew and ZipArchive were separate standalone libs. I agree that separating them seems to be the right thing. I'll look into this all as time permits and submit reviews for standalone FlightCrew and ZipArchive packages when I've them + put a link to a new sigil package using them here. Dan, I assume it is ok with you if I base my work of your work? Also I would not mind you submitting them for review, me reviewing them and then co-maintaining them in the future? Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728256] Review Request: rubygem-activesupport2.3 - rails 2 alongside rails 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728256 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-09 03:46:29 EST --- rubygem-activesupport2.3-2.3.14-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-activesupport2.3-2.3.14-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772504
--- Comment #2 from Lubomir Rintel lkund...@v3.sk 2012-01-09 04:34:57 EST ---
Thank you for your suggestions. Here are the updated packages:
SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
(In reply to comment #1)
I think the package summary does not describe the package very well. The
description gave me a completely different view.
What view did it give you? I can't really think of a better description and
would appreciate help here.
Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
the clean section, buildroot definition and the rm in the install section.
I choose not to break compatibility with el5 rebuilds for packages that rebuild
cleanly. As it gets more obsolete, I'll remove those parts.
Please use the name macro, as you did in Source. Looking at your manpage, you
forgot a d in %{_localstatedir}/lib/btkbd.
The manpage was actually wrong (the example udev rules wrote to
/var/lib/btkbd). However, it makes more sense with two ds, so I adjusted that
appropriately.
There's a macro called sharedstatedir, by the way, that is equivalent to
%{_localstatedir}/lib.
This would break el5 builds:
$ rpm --eval %_sharedstatedir
/usr/com
The FSF address is outdated.
Changed that to http://fsf.org, which seems to be used in GPLv3.
Why do you want to own %{_sysconfdir}/udev/rules.d?
That was a mistake. Removed it.
Why do you require pod2man explicitly?
I choose to :)
It is not intuitively obvious (to me) that it is part of perl, nor that it
won't change in future or that perl will stay in build group forever. Though
all of that is unlikely, I like it to be specified explicitly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #12 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-09 05:08:35 EST --- Ping Fabien? Any progress on the incorporation? ** I am willing to sponsor you if you show me your knowing of the Fedora guidelines, most importantly http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines In addition to the Packaging Guidelines, there are a bunch of language / application specific guidelines that are linked to in the Packaging Guidelines. Here are some tricks of the trade: http://fedoraproject.org/wiki/Packaging_tricks http://fedoraproject.org/wiki/Packaging/ScriptletSnippets http://fedoraproject.org/wiki/Common_Rpmlint_issues I will sponsor you if you have at least one other submission and perform a couple of informal reviews of packages of other people. Please review only packages *not* marked with FE-NEEDSPONSOR. I will have to do the full formal review after you to check that you have got everything correctly. Once I have sponsored you you will be able to do formal reviews of your own. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772582] New: Review Request: python-rest-client - A REST Client for use in python, using httplib2 and urllib2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-rest-client - A REST Client for use in python, using httplib2 and urllib2 https://bugzilla.redhat.com/show_bug.cgi?id=772582 Summary: Review Request: python-rest-client - A REST Client for use in python, using httplib2 and urllib2 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mru...@matthias-runge.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://www.matthias-runge.de/fedora/python-rest-client.spec SRPM URL: http://www.matthias-runge.de/fedora/python-rest-client-0.3-1.fc16.src.rpm Description: A REST Client for use in python, using httplib2 and urllib2. Includes a version that is suitable for use in the Google App Engine environment. Scratch-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3632897 [mrunge@mrungexp SPECS]$ rpmlint -i ../SRPMS/python-rest-client-0.3-1.fc16.src.rpm ../RPMS/noarch/python-rest-client-0.3-1.fc16.noarch.rpm ./python-rest-client.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #13 from Fabien Archambault marbolan...@gmail.com 2012-01-09 05:42:24 EST --- Hi Jussi, I replied by email to your proposition to integrate your spec and I believe it should be faster to do it with your spec. If needed I can close this bug and you can open yours. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760943] Review Request: perl-Messaging-Message - This perl module provides an abstraction of a message, as used in messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760943 laurence.fi...@cern.ch changed: What|Removed |Added Flag|needinfo?(Laurence.Field@ce | |rn.ch) | --- Comment #3 from laurence.fi...@cern.ch 2012-01-09 05:49:27 EST --- Spec URL: http://lfield.web.cern.ch/lfield/fedora/perl-Messaging-Message.spec SRPM URL: http://lfield.web.cern.ch/lfield/fedora/perl-Messaging-Message-0.7-1.fc16.src.rpm Sorry, finger trouble. Please find the correct URL above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770740
adev ade...@gmail.com changed:
What|Removed |Added
CC||pin...@pingoured.fr
--- Comment #5 from adev ade...@gmail.com 2012-01-09 05:49:39 EST ---
Hi, This is an informal review, I am not a sponsor.
[PASS] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
morse.src: I: enchant-dictionary-not-found en_US
morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz
morse.x86_64: W: no-manual-page-for-binary morseexec
morse.x86_64: W: no-manual-page-for-binary morse
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
- no man pages
[PASS] MUST: The package must be named according to the Package Naming
Guidelines .
[PASS] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[PASS] MUST: The package must meet the Packaging Guidelines.
[PASS] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[PASS] MUST: The License field in the package spec file must match the actual
license.
[PASS] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[PASS] MUST: The spec file must be written in American English.
[PASS] MUST: The spec file for the package MUST be legible.
[PASS] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
rpmdev-md5 morse-0.4.1-2.fc16.src.rpm
293849e6e24b0b3adf2dbd9ae0064300 morse-0.4.1-2.fc16.src.rpm
0e9c30808c82062d284a528c052e16f2 morse.desktop
794f77239d535d61861426d450b66850 morse-0.4.1-lsbpathfix.patch
a2b9c70415653665ad5d90504ffebc5e morse-0.4.1.usepythonsitearch.patch
b57e3f3dd1eed67ce201ddfa14b920ad laas-morse-0.4.1-0-g15dc857.tar.gz
5ced6d1eec3f7a66e6f0e41bc64de92d morse.spec
md5sum 0.4.1
b57e3f3dd1eed67ce201ddfa14b920ad 0.4.1
[PASS] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
- see koji
[PASS] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[PASS] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[PASS] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[PASS] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[PASS] MUST: Packages must NOT bundle copies of system libraries.
[PASS] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[PASS] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[PASS] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[PASS] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[PASS] MUST: Each package must consistently use macros.
[PASS] MUST: The package must contain code, or permissable content.
[PASS] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[PASS] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[PASS] MUST: Header files must be in a -devel package.
[PASS] MUST: Static
[Bug 766622] Review Request: perl-Authen-Credential - Abstraction of a credential
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766622 --- Comment #3 from laurence.fi...@cern.ch 2012-01-09 05:54:14 EST --- Spec URL: http://lfield.web.cern.ch/lfield/fedora/perl-Authen-Credential.spec SRPM URL: http://lfield.web.cern.ch/lfield/fedora/perl-Authen-Credential-0.5-2.fc16.src.rpm Here is an updated version with the suggested improvements. Please note that we are targeting EPEL5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728249] Review Request: rubygem-activerecord2.3 - rails 2 alongside rails 3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728249 --- Comment #2 from Emanuel Rietveld codehot...@gmail.com 2012-01-09 06:06:33 EST --- This package will probably not work on F16 and F17. It requires rubygem-sqlite3-ruby which was renamed to rubygem-sqlite3. I will upload updated srpms shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768800] Review Request: libwacom - Tablet Information Client Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768800 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com QAContact|mcla...@redhat.com |extras...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] New: Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Summary: Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kdan...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command/felix-gogo-command-0.12.0-1.fc15.src.rpm Description: Apache Felix Gogo is a subproject of Apache Felix implementing the OSGi RFC 147, which describes a standard shell for OSGi-based environments. Felix Gogo Command command implements a set of basic commands. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 06:29:58 EST --- I'll do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #14 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-09 06:59:33 EST --- You can use my spec. But someone else will then have to review this bug. I can sponsor you in any case, provided you make another submission and perform some informal reviews. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772608] New: Review Request: ovirt-guest-agent - oVirt Guest Agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ovirt-guest-agent - oVirt Guest Agent https://bugzilla.redhat.com/show_bug.cgi?id=772608 Summary: Review Request: ovirt-guest-agent - oVirt Guest Agent Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gham...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://ghammer.fedorapeople.org/ovirt-guest-agent.spec SRPM URL: http://ghammer.fedorapeople.org/ovirt-guest-agent-1.0.0-1.fc16.src.rpm Description: This is the oVirt managment agent running inside the guest. The agent interfaces with the oVirt manager, supplying heart-beat info as well as runtime data from within the guest itself. The agent also accepts control commands to be run executed within the OS (like: shutdown and restart). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772616] New: Review Request: epstool - A utility to create or extract preview images in EPS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: epstool - A utility to create or extract preview images in EPS files https://bugzilla.redhat.com/show_bug.cgi?id=772616 Summary: Review Request: epstool - A utility to create or extract preview images in EPS files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jussi.leht...@iki.fi QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/epstool.spec SRPM URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/epstool-3.08-1.fc16.src.rpm Description: Epstool is a utility to create or extract preview images in EPS files, fix bounding boxes and convert to bitmaps. Features: * Add EPSI, DOS EPS or Mac PICT previews. * Extract PostScript from DOS EPS files. * Uses Ghostscript to create preview bitmaps. * Create a TIFF, WMF, PICT or Interchange preview from part of a bitmap created by Ghostscript. * works under Win32, Win64, OS/2 and Unix. * works on little-endian machines (Intel) or big endian (Sun Sparc, Motorola) machines. rpmlint output: epstool.src: W: spelling-error %description -l en_US endian - Indian, Dianne, Diane epstool.x86_64: W: spelling-error %description -l en_US endian - Indian, Dianne, Diane epstool.x86_64: E: incorrect-fsf-address /usr/share/doc/epstool-3.08/LICENCE 3 packages and 0 specfiles checked; 1 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772617] New: Review Request: perl-BSD-Resource - BSD process resource limit and priority functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-BSD-Resource - BSD process resource limit and priority functions https://bugzilla.redhat.com/show_bug.cgi?id=772617 Summary: Review Request: perl-BSD-Resource - BSD process resource limit and priority functions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kana...@kanarip.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-BSD-Resource.spec SRPM URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-BSD-Resource-1.29.04-6.fc17.src.rpm Description: A module providing an interface for testing and setting process limits and priorities. Remarks: Necessary for Cyrus IMAP test suite Cassandane. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772620] New: Review Request: perl-Encode-IMAPUTF7 - Perl extension to deal with UTF-7 modification for IMAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Encode-IMAPUTF7 - Perl extension to deal with UTF-7 modification for IMAP https://bugzilla.redhat.com/show_bug.cgi?id=772620 Summary: Review Request: perl-Encode-IMAPUTF7 - Perl extension to deal with UTF-7 modification for IMAP Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kana...@kanarip.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-Encode-IMAPUTF7.spec SRPM URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-Encode-IMAPUTF7-1.05-1.fc17.src.rpm Description: IMAP mailbox names are encoded in a modified UTF-7 when names contains international characters outside of the printable ASCII range. The modified UTF-7 encoding is defined in RFC2060 (section 5.1.3). Remark: Necessary for Cyrus IMAP test suite Cassandane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772616] Review Request: epstool - A utility to create or extract preview images in EPS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772616 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Blocks||772577 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772618] New: Review Request: perl-News-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-News-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server https://bugzilla.redhat.com/show_bug.cgi?id=772618 Summary: Review Request: perl-News-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kana...@kanarip.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-News-NNTPClient.spec SRPM URL: http://hosted.kolabsys.com/~vanmeeuwen/perl-News-NNTPClient-0.37-1.fc17.src.rpm Description: This module implements a client interface to NNTP, enabling a Perl 5 application to talk to NNTP servers. It uses the OOP (Object Oriented Programming) interface introduced with Perl 5. Remark: Necessary for Cyrus IMAP test suite Cassandane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772288] Review Request: infiniband-diags - various InfiniBand fabric test utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Albert Strasheim full...@gmail.com changed:
What|Removed |Added
CC||full...@gmail.com
--- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 07:52:44
EST ---
I suggest that a devel and devel-static are added for this package:
%description devel
Header files for the infiniband-diags library.
%package devel-static
Summary: Static development files for the infiniband-diags library
Group: System Environment/Libraries
Requires: %{name}-devel = %{version}-%{release}
%description devel-static
Static libraries for the infiniband-diags library.
%files devel
%defattr(-,root,root,-)
%{_libdir}/lib*.so
%{_includedir}/infiniband/*
%{_mandir}/man3/*
%files devel-static
%defattr(-,root,root,-)
%{_libdir}/*.a
The ibnetdisc library that is part of this package is very useful when writing
custom admin tools.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772288] Review Request: infiniband-diags - various InfiniBand fabric test utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772288 --- Comment #2 from Albert Strasheim full...@gmail.com 2012-01-09 07:57:09 EST --- $ rpmlint infiniband-diags.spec infiniband-diags.spec:12: W: unversioned-explicit-provides perl(IBswcountlimits) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint infiniband-diags-1.5.12-1.fc15.x86_64.rpm infiniband-diags.x86_64: W: spelling-error %description -l en_US subnet - subset, sublet, sub net infiniband-diags.x86_64: W: obsolete-not-provided openib-diags infiniband-diags.x86_64: W: non-conffile-in-etc /etc/infiniband-diags/error_thresholds infiniband-diags.x86_64: W: no-manual-page-for-binary check_lft_balance.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibdiscover.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_mfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibqueryerrors.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_lfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibswportwatch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibfindnodesusing.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintca.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintswitch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary iblinkinfo.pl infiniband-diags.x86_64: W: no-manual-page-for-binary set_nodedesc.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibidsverify.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintrt.pl 1 packages and 0 specfiles checked; 0 errors, 16 warnings. Looks like the file in sysconfdir needs a %config(noreplace). I noticed on the linux-rdma mailing list that these scripts aren't supported anymore: http://www.spinics.net/lists/linux-rdma/msg10669.html Do we want to package them? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772260] Review Request: srptools - utilities for mounting SRP shared resources
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772260
Albert Strasheim full...@gmail.com changed:
What|Removed |Added
CC||full...@gmail.com
--- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 08:02:54
EST ---
$ rpmlint srptools.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint srptools-0.0.4-11.fc15.x86_64.rpm
srptools.x86_64: W: spelling-error %description -l en_US ib - bi, ob, iv
srptools.x86_64: W: spelling-error %description -l en_US srp - rps, sip, sap
srptools.x86_64: W: obsolete-not-provided openib-srptools
srptools.x86_64: W: no-manual-page-for-binary run_srp_daemon
srptools.x86_64: W: no-manual-page-for-binary srp_daemon.sh
srptools.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/srpd
srptools.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/srpd
srptools.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/srpd
srptools.x86_64: W: incoherent-init-script-name srpd ('srptools', 'srptoolsd')
1 packages and 0 specfiles checked; 2 errors, 7 warnings.
/etc/rc.d/init.d/srpd should probably converted to a systemd .service file?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-01-09 08:08:59 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771842] Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771842 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-01-09 08:08:23 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=574586 Adrien Kunysz a...@acunu.com changed: What|Removed |Added CC||a...@acunu.com --- Comment #6 from Adrien Kunysz a...@acunu.com 2012-01-09 08:05:54 EST --- It seems that spec file cannot be processed properly when python26 is not installed: $ rpmbuild -bp SPECS/python26-psycopg2.spec sh: /usr/bin/python2.6: No such file or directory error: Macro %pyver has empty body sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory sh: /usr/bin/python2.6: No such file or directory error: Failed build dependencies: python26-devel is needed by python26-psycopg2-2.0.14-2.x86_64 postgresql-devel is needed by python26-psycopg2-2.0.14-2.x86_64 The error: Failed build dependencies is expected but as far as I can tell, the sh: /usr/bin/python2.6: No such file or directory and error: Macro %pyver has empty body should not happen. Otherwise it seems to work fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771837] Review Request: gubbi-fonts - Free Kannada Opentype serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771837 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-01-09 08:07:51 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772234] Review Request: qperf - Performance testing utility for RDMA networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772234 Albert Strasheim full...@gmail.com changed: What|Removed |Added CC||full...@gmail.com --- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 08:14:35 EST --- $ rpmlint qperf.spec qperf.spec:6: W: non-standard-group Networking/Diagnostic 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint qperf-0.4.6-4.fc15.x86_64.rpm qperf.x86_64: W: non-standard-group Networking/Diagnostic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. qperf works fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 Albert Strasheim full...@gmail.com changed: What|Removed |Added CC||full...@gmail.com --- Comment #3 from Albert Strasheim full...@gmail.com 2012-01-09 08:10:59 EST --- $ rpmlint rds-tools.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint rds-tools-2.0.6-1.fc15.x86_64.rpm rds-tools.x86_64: W: spelling-error %description -l en_US iWARP - i Warp, warp, antiwar rds-tools.x86_64: W: non-conffile-in-etc /etc/modprobe.d/rds.conf rds-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/rds-tools-2.0.6/examples/rds-sample.c 1 packages and 0 specfiles checked; 1 errors, 2 warnings. The tools run fine here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772233 Albert Strasheim full...@gmail.com changed: What|Removed |Added CC||full...@gmail.com --- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 08:18:58 EST --- $ rpmlint mstflint.spec mstflint-1.4-6.fc15.x86_64.rpm mstflint.x86_64: W: spelling-error Summary(en_US) Mellanox - Melanoma mstflint.x86_64: W: obsolete-not-provided openib-mstflint mstflint.x86_64: W: obsolete-not-provided openib-tvflash mstflint.x86_64: W: obsolete-not-provided tvflash mstflint.x86_64: W: no-manual-page-for-binary mstmread mstflint.x86_64: W: no-manual-page-for-binary mstflint mstflint.x86_64: W: no-manual-page-for-binary mstvpd mstflint.x86_64: W: no-manual-page-for-binary mstregdump mstflint.x86_64: W: no-manual-page-for-binary mstmwrite 1 packages and 1 specfiles checked; 0 errors, 9 warnings. How does mstflint relate to the mft packages provided by Mellanox? http://www.mellanox.com/content/pages.php?pg=management_toolsmenu_section=34 For some reason I got the idea that mstflint is older software, but I could easily be mistaken. Is it worth packaging this for Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772229] Review Request: perftest - Performance testing programs for InfiniBand networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772229 --- Comment #2 from Albert Strasheim full...@gmail.com 2012-01-09 08:24:59 EST --- Sorry, I thought your comment was the package description. Actually, your comment is more useful than the package description, which simply says gen2 uverbs microbenchmarks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772229] Review Request: perftest - Performance testing programs for InfiniBand networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772229 Albert Strasheim full...@gmail.com changed: What|Removed |Added CC||full...@gmail.com --- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 08:23:56 EST --- The description says Sample packages can be found at the URL above. which is a bit unclear. Is that the package URL or something else? $ rpmlint perftest* perftest.x86_64: W: spelling-error %description -l en_US uverbs - verbs, u verbs perftest.x86_64: W: spelling-error %description -l en_US microbenchmarks - micro benchmarks, micro-benchmarks, benchmarks perftest.x86_64: W: non-standard-group Productivity/Networking/Diagnostic perftest.x86_64: W: obsolete-not-provided openib-perftest perftest.x86_64: W: no-manual-page-for-binary ib_read_bw perftest.x86_64: W: no-manual-page-for-binary ib_clock_test perftest.x86_64: W: no-manual-page-for-binary ib_read_lat perftest.x86_64: W: no-manual-page-for-binary ib_write_bw_postlist perftest.x86_64: W: no-manual-page-for-binary ib_send_bw perftest.x86_64: W: no-manual-page-for-binary ib_write_bw perftest.x86_64: W: no-manual-page-for-binary rdma_lat perftest.x86_64: W: no-manual-page-for-binary ib_write_lat perftest.x86_64: W: no-manual-page-for-binary rdma_bw perftest.x86_64: W: no-manual-page-for-binary ib_send_lat perftest.spec:6: W: non-standard-group Productivity/Networking/Diagnostic 1 packages and 1 specfiles checked; 0 errors, 15 warnings. /usr/share/doc/perftest-1.3.0/runme probably doesn't have to be packaged. tools seem to work fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 509965] Review Request: snmptt - SNMPTT (SNMP Trap Translator) is an SNMP trap handler written in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509965 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #19 from Volker Fröhlich volke...@gmx.at 2012-01-09 08:28:39 EST --- I guess we could close this as stalled review, as of: http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772504
--- Comment #3 from Volker Fröhlich volke...@gmx.at 2012-01-09 08:26:17 EST
---
(In reply to comment #2)
Thank you for your suggestions. Here are the updated packages:
SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
(In reply to comment #1)
I think the package summary does not describe the package very well. The
description gave me a completely different view.
What view did it give you? I can't really think of a better description and
would appreciate help here.
The way you put it now sounds a lot better to me! :)
Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
the clean section, buildroot definition and the rm in the install section.
(Defattr is not necessary for EPEL 5 either.)
I choose not to break compatibility with el5 rebuilds for packages that
rebuild
cleanly. As it gets more obsolete, I'll remove those parts.
Please use the name macro, as you did in Source. Looking at your manpage,
you
forgot a d in %{_localstatedir}/lib/btkbd.
The manpage was actually wrong (the example udev rules wrote to
/var/lib/btkbd). However, it makes more sense with two ds, so I adjusted
that
appropriately.
There's a macro called sharedstatedir, by the way, that is equivalent to
%{_localstatedir}/lib.
This would break el5 builds:
$ rpm --eval %_sharedstatedir
/usr/com
Ah, I wasn't aware of that.
The FSF address is outdated.
Changed that to http://fsf.org, which seems to be used in GPLv3.
No, I meant the postal address. They moved from Temple Place to Franklin Street
in 2005.
Why do you want to own %{_sysconfdir}/udev/rules.d?
That was a mistake. Removed it.
Why do you require pod2man explicitly?
I choose to :)
It is not intuitively obvious (to me) that it is part of perl, nor that it
won't change in future or that perl will stay in build group forever. Though
all of that is unlikely, I like it to be specified explicitly.
I tried your software but messed up somehow. Let's see if I can get it working
for me! :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771485] Review Request: libcxgb4 - Chelsio T4 iWARP HCA Userspace Driver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771485
Albert Strasheim full...@gmail.com changed:
What|Removed |Added
CC||full...@gmail.com
--- Comment #1 from Albert Strasheim full...@gmail.com 2012-01-09 08:30:07
EST ---
$ rpmlint libcxgb4*
libcxgb4.x86_64: W: spelling-error Summary(en_US) Chelsio - Chelsea
libcxgb4.x86_64: W: spelling-error Summary(en_US) iWARP - i Warp, warp,
antiwar
libcxgb4.x86_64: W: spelling-error %description -l en_US Userspace - User
space, User-space, Users pace
libcxgb4.x86_64: W: spelling-error %description -l en_US libibverbs -
verbalizes
libcxgb4.x86_64: W: spelling-error %description -l en_US iWARP - i Warp, warp,
antiwar
libcxgb4.x86_64: W: obsolete-not-provided libcxgb4-devel
libcxgb4.x86_64: W: non-conffile-in-etc /etc/modprobe.d/libcxgb4.conf
libcxgb4.x86_64: W: non-conffile-in-etc /etc/libibverbs.d/cxgb4.driver
libcxgb4.spec:13: W: unversioned-explicit-obsoletes %{name}-devel
libcxgb4.spec:15: W: unversioned-explicit-provides libibverbs-driver.%{_arch}
libcxgb4-static.x86_64: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 11 warnings.
I don't have this hardware, so I can't test further unfortunately.
I noticed that libmlx4-static provides libmlx4-devel-static. What's up with
that? Should libcxgb4-static do the same?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713461] Review Request: tomahawk - The Social Music Player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713461 Bug 713461 depends on bug 731456, which changed state. Bug 731456 Summary: Review Request: jreen - Qt XMPP Library https://bugzilla.redhat.com/show_bug.cgi?id=731456 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-09 08:47:38 --- Comment #43 from Rex Dieter rdie...@math.unl.edu 2012-01-09 08:47:38 EST --- imported into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 Bug 731456 depends on bug 752454, which changed state. Bug 752454 Summary: Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture https://bugzilla.redhat.com/show_bug.cgi?id=752454 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-09 08:47:56 --- Comment #5 from Rex Dieter rdie...@math.unl.edu 2012-01-09 08:47:56 EST --- imported into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769487 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #2 from Volker Fröhlich volke...@gmx.at 2012-01-09 08:54:06 EST --- The spec looks pretty good. A few comments: - Usually Name comes before Summary - Is Development/Languages really the correct group? - You could shorten that for-loop by using sed -i there as well. - Did you consider to Require ipython? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 08:55:25 EST --- It fails to build in mock. [ERROR] The build could not read 1 project - [Help 1] [ERROR] [ERROR] The project org.apache.felix:org.apache.felix.gogo.command:0.12.0 (/builddir/build/BUILD/org.apache.felix.gogo.command-0.12.0/pom.xml) has 1 error [ERROR] Non-resolvable parent POM: The repository system is offline but the artifact org.apache.felix:gogo-parent:pom:0.6.0 is not available in the local repository. and 'parent.relativePath' points at wrong local POM @ line 22, column 11 - [Help 2] You should try a mock build in order to verify you have all the buildrequires specified. In this case there is a missing BuildRequires: felix-gogo-parent. Details on using mock are at http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds or at http://fedoraproject.org/wiki/Fedora_Packager_For_Eclipse_User_Guide . Please also fill the changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772504 --- Comment #4 from Lubomir Rintel lkund...@v3.sk 2012-01-09 09:15:13 EST --- (In reply to comment #3) (In reply to comment #2) Thank you for your suggestions. Here are the updated packages: SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm (In reply to comment #1) I think the package summary does not describe the package very well. The description gave me a completely different view. What view did it give you? I can't really think of a better description and would appreciate help here. The way you put it now sounds a lot better to me! :) Oh, I reworded the summary. I thought you were referring to the description. Defattr is no longer necessary. If you're not going for EPEL 5, you can drop the clean section, buildroot definition and the rm in the install section. (Defattr is not necessary for EPEL 5 either.) rpmlint whines then :( Would you mind if I leave it there just to make el6 rpmlint (that I use) happy? The FSF address is outdated. Changed that to http://fsf.org, which seems to be used in GPLv3. No, I meant the postal address. They moved from Temple Place to Franklin Street in 2005. Yes. The GPLv3 text does not include the postal address, just an URL, thus I just leave just an URL here as well. I tried your software but messed up somehow. Let's see if I can get it working for me! :) Let me know then please. Be sure not to skip manual's BUGS section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769487 --- Comment #3 from Thibault North thibault.no...@gmail.com 2012-01-09 09:22:30 EST --- Thanks. - Name position: fixed - Indeed, that's not the good group. I forgot to change that one. What about Development/Libraries ? (same as matplotlib) - The for loop was used to keep the original timestamps. Does it matter? - Included ipython Spec URL: http://tnorth.fedorapeople.org/python-glumpy.spec SRPM URL: http://tnorth.fedorapeople.org/python-glumpy-0.2.1-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 --- Comment #9 from Brendan Jones brendan.jones...@gmail.com 2012-01-09 09:34:22 EST --- OK, I have tried with system waf to no avail. It fails with on a dependency only present in the bundled waf script not in Fedora: .waf-1.6.9-d91409dba2155c73b1f8394139b82995/waflib/autowaf.py I have queried upstream about the license and will report back. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720339] Review Request: perl-smartmatch-engine-core - Default smartmatch implementation from 5.10---5.14
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720339
--- Comment #4 from Petr Šabata psab...@redhat.com 2012-01-09 09:37:43 EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[!]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/contyk/src/review/720339/smartmatch-engine-core-0.02-TRIAL.tar.gz :
MD5SUM this package : ee936646804a609e0e32a3e15f98a390
MD5SUM upstream package : ee936646804a609e0e32a3e15f98a390
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[-]: SHOULD Spec use %global instead of %define.
Issues:
TODO: BuildRequire perl(Carp)
TODO: BuildRequire perl(File::Temp)
Generated by fedora-review 0.1.1
External plugins:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728302 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks||182235(FE-Legal) --- Comment #22 from Tom spot Callaway tcall...@redhat.com 2012-01-09 09:45:13 EST --- Blocking FE-Legal, pending iLBC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772504 --- Comment #5 from Volker Fröhlich volke...@gmx.at 2012-01-09 10:09:26 EST --- (In reply to comment #4) (In reply to comment #3) (In reply to comment #2) Thank you for your suggestions. Here are the updated packages: SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm (In reply to comment #1) I think the package summary does not describe the package very well. The description gave me a completely different view. What view did it give you? I can't really think of a better description and would appreciate help here. The way you put it now sounds a lot better to me! :) Oh, I reworded the summary. I thought you were referring to the description. Defattr is no longer necessary. If you're not going for EPEL 5, you can drop the clean section, buildroot definition and the rm in the install section. (Defattr is not necessary for EPEL 5 either.) rpmlint whines then :( Would you mind if I leave it there just to make el6 rpmlint (that I use) happy? No, just keep it, it doesn't hurt! The FSF address is outdated. Changed that to http://fsf.org, which seems to be used in GPLv3. No, I meant the postal address. They moved from Temple Place to Franklin Street in 2005. Yes. The GPLv3 text does not include the postal address, just an URL, thus I just leave just an URL here as well. I see! I tried your software but messed up somehow. Let's see if I can get it working for me! :) Let me know then please. Be sure not to skip manual's BUGS section. Hm, I still don't manage, nevermind! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-avw-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Summary|Review Request: |Review Request: |lv2-ams-plugins - LV2 port |lv2-avw-plugins - LV2 port |of the Alsa Modular Synth |of the Alsa Modular Synth |modules |modules -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769487 --- Comment #4 from Volker Fröhlich volke...@gmx.at 2012-01-09 10:20:29 EST --- No, I don't think it matters. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=77
--- Comment #15 from Ofer Schreiber oschr...@redhat.com 2012-01-09 10:22:06
EST ---
Official tarball is now available:
http://www.ovirt.org/releases/stable/binary/ovirt-engine-sdk-1.0-1.tar.gz
SRPM:
http://oschreib.fedorapeople.org/ovirt-engine-sdk/ovirt-engine-sdk-1.0-1.fc16.src.rpm
SPEC: http://oschreib.fedorapeople.org/ovirt-engine-sdk/ovirt-engine-sdk.spec
Now, about the release/version: I'm not sure I completely understood the
convention.
1. Should the rpm version/release match the upstream one?
2. If I'll name it 0.0-2.20120104git9e88d7e%{dist} should I update the
changelog accordingly?
#2 is a bit problematic since the upstream already contains the spec file, so
I'll have to commit it after every build I'll do for this review.
I thought it would be better to first pass this review with the right version
(e.g. 1.0-1) and then add updates to the changelog.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #18 from Ivan Romanov dr...@land.ru 2012-01-09 10:22:56 EST --- rpmlint output for all packages $ rpmlint /home/taurus/rpmbuild/SRPMS/nwipe-0.06-2.fc15.src.rpm /home/taurus/rpmbuild/RPMS/i686/nwipe-0.06-2.fc15.i686.rpm /home/taurus/rpmbuild/RPMS/i686/nwipe-debuginfo-0.06-2.fc15.i686.rpm nwipe.src: W: spelling-error %description -l en_US dwipe - swipe, wipe, wiped nwipe.src: W: spelling-error %description -l en_US dban - ban, band, dean nwipe.src: W: spelling-error %description -l en_US pthreads - threads, p threads, thread nwipe.src: W: spelling-error %description -l en_US gcc - cc, g cc nwipe.i686: W: spelling-error %description -l en_US dwipe - swipe, wipe, wiped nwipe.i686: W: spelling-error %description -l en_US dban - ban, band, dean nwipe.i686: W: spelling-error %description -l en_US pthreads - threads, p threads, thread nwipe.i686: W: spelling-error %description -l en_US gcc - cc, g cc 3 packages and 0 specfiles checked; 0 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665901] Review Request: perl-Gravatar-URL - Make URLs for Gravatars from an email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665901 Petr Šabata psab...@redhat.com changed: What|Removed |Added CC||psab...@redhat.com --- Comment #1 from Petr Šabata psab...@redhat.com 2012-01-09 11:07:41 EST --- I'm not a sponsor but my quick notes: The package doesn't build in mock since you're missing some key dependencies (Digest::MD5, to be specific). You should also buildrequire Carp, and Unicornify::URL, which is not in Fedora and has to be packaged first. Also remove the explicit perl BR. Moreover, Buildroot tag (line 9) and buildroot cleaning (lines 35, 45, 46) are no longer needed in Fedora. The same applies to %defattr (line 49). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=77 --- Comment #16 from David Nalley da...@gnsa.us 2012-01-09 11:10:19 EST --- Glad the tarball is out, that greatly simplifies things. I don't know how closely you are working with upstream - but typically release is something that the distro handles e.g. if they have a choice in future naming of their tarballs only include name and version, and let release be handled by Fedora. RPM version should generally always match upstream versioning. There are some exceptions, largely documented in this section: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning Release however tends to be distro specific - so every time you change the spec file you'll increment the release. While it seems bothersome now, and the problem you cite with including spec file is an issue. There are lots of builds that will increment the changelog/release and you'll have no control over, so for instance, there's a mass rebuild of all Fedora packages going on now (or very shortly) for a new gcc version. That means an incremented release and an additional changelog entry (and new builds of the software going out). Also keep in mind that others (those in the provenpackager group) can touch your packages, modify spec files, etc. So you might get $version-1 into the repo for a given tag. Most folks who include a spec files make it a pretty generalized, working spec file in the source repo. Sheepdog is a decent example of this: https://github.com/collie/sheepdog/blob/master/sheepdog.spec.in Keep in mind you'll be checking your spec file into a package-specific git repo and maintaining it there for Fedora and EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772504 --- Comment #6 from Lubomir Rintel lkund...@v3.sk 2012-01-09 11:47:19 EST --- I tried your software but messed up somehow. Let's see if I can get it working for me! :) Let me know then please. Be sure not to skip manual's BUGS section. Hm, I still don't manage, nevermind! :) I am quite interested, since you probably are second person (apart from me) that uses the thing and I really intended to make it 'just work' :) Feel free to reach me at IRC (lkundrak at freenode) or drop a mail at lubo.rin...@gooddata.com if you don't feel like polluting this review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=77 --- Comment #17 from Ofer Schreiber oschr...@redhat.com 2012-01-09 11:48:07 EST --- I think we're fine here, we don't include the spec file itself in the git/tarball, we include ovirt-engine-sdk.spec.in, which is pretty generalized, although we can do some better job there. About versioning - I think that if tarball version is 1.0-1, the first rpm will be 1.0-1 and we will add .1/2/3 in the end of the release for every additional build. anyhow, I didn't thought of adding changelog entries during this review (only afterwards), if it's required, I'll add it. Anything more I should do before starting the official review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772616] Review Request: epstool - A utility to create or extract preview images in EPS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772616 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #1 from Orion Poplawski or...@cora.nwra.com 2012-01-09 12:10:22 EST --- First comment, has the fsf-address issue been reported upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756856] Review Request: python-pyflag - Forensic and Log Analysis GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756856 --- Comment #8 from Soumya Kanti Chakraborty sou...@dgplug.org 2012-01-09 12:12:45 EST --- Sorry somehow, did miss this notification of the edit .. will check it and let you know -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 --- Comment #4 from Albert Strasheim full...@gmail.com 2012-01-09 12:29:33 EST --- By the way, running rds-info causes the following kernel warning: [38559.194671] [ cut here ] [38559.194752] WARNING: at kernel/softirq.c:159 _local_bh_enable_ip+0x44/0x8e() [38559.194824] Hardware name: MacPro3,1 [38559.194893] Modules linked in: rds_rdma rds_tcp rds bluetooth rfkill appletalk ipx p8022 psnap llc p8023 rose ax25 lockd nf_conntrack_tftp nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ftp xt_state ib_srp scsi_transport_srp scsi_tgt ib_ipoib rdma_ucm ipt_MASQUERADE ib_ucm coretemp ib_uverbs iptable_nat nf_nat nf_conntrack_ipv4 nf_conntrack ib_umad ip6_tables nf_defrag_ipv4 rdma_cm ib_cm iw_cm ib_addr ib_sa mlx4_ib ib_mad ib_core mlx4_en snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm joydev fglrx(P) snd_timer snd i5400_edac ioatdma edac_core soundcore iTCO_wdt iTCO_vendor_support shpchp igb e1000e mlx4_core applesmc i2c_i801 input_polldev i5k_amb snd_page_alloc dca microcode virtio_net kvm_intel kvm binfmt_misc sunrpc raid10 firewire_ohci firewire_core crc_itu_t radeon ttm drm_kms_helper drm i2c_algo_bit i2c_core [last unloaded: scsi_wait_scan] [38559.195007] Pid: 24813, comm: rds-info Tainted: P I 3.1.1-1.fc16.x86_64 #1 [38559.195007] Call Trace: [38559.195007] [81057a1e] warn_slowpath_common+0x83/0x9b [38559.195007] [81057a50] warn_slowpath_null+0x1a/0x1c [38559.195007] [8105d42a] _local_bh_enable_ip+0x44/0x8e [38559.195007] [8105d482] local_bh_enable_ip+0xe/0x10 [38559.195007] [814b72ed] _raw_read_unlock_bh+0x15/0x17 [38559.195007] [813cb0bc] sock_i_ino+0x38/0x40 [38559.195007] [a073a786] rds_sock_info+0xa7/0x10e [rds] [38559.195007] [a073c35d] rds_info_getsockopt+0x11a/0x1b9 [rds] [38559.195007] [a073a886] rds_getsockopt+0x70/0xcc [rds] [38559.195007] [813c955b] sys_getsockopt+0x7a/0x98 [38559.195007] [814bd8c2] system_call_fastpath+0x16/0x1b [38559.195007] ---[ end trace 40181a0855375f5a ]--- I reported it here: https://bugzilla.redhat.com/show_bug.cgi?id=718790 but that bug got closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772616] Review Request: epstool - A utility to create or extract preview images in EPS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772616 --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-09 12:32:15 EST --- It has now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #3 from Krzysztof Daniel kdan...@redhat.com 2012-01-09 12:42:26 EST --- I have updated the spec. Here is a new version: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772709] New: Review Request: TeXamator - Helping you making your exercise sheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: TeXamator - Helping you making your exercise sheets https://bugzilla.redhat.com/show_bug.cgi?id=772709 Summary: Review Request: TeXamator - Helping you making your exercise sheets Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@marionline.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://marionline.fedorapeople.org/packages/SPECS/texamator.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/TeXamator-1.7.3-0.fc16.src.rpm Description: TeXamator is written in Python/Qt4. It is aimed at helping you making your exercise sheets. Basically, it browses a specified directory, looks for .tex files containing exercises and builds a tree with all your exercises in it. You can click on an element of the tree to have a preview of the exercise and add it to a list if you wish to. Then you can save your work to a .tex file or you can generate a .dvi file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772710] New: Review Request: pkpgcounter - Computes number of pages or quantity of ink needed to print documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pkpgcounter - Computes number of pages or quantity of ink needed to print documents https://bugzilla.redhat.com/show_bug.cgi?id=772710 Summary: Review Request: pkpgcounter - Computes number of pages or quantity of ink needed to print documents Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jpope...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://jpopelka.fedorapeople.org/pkpgcounter.spec SRPM URL: http://jpopelka.fedorapeople.org/pkpgcounter-3.50-1.fc16.src.rpm Description: pkpgcounter parses files and outputs the number of pages needed to print them. It can also, for certain file formats, compute the percentage of ink colors covering each page. It currently recognizes almost 20 Page Description Languages or file formats, including the most used ones like Postscript, PDF, the PCL family, DVI, OpenDocument, or even Microsoft Word, corresponding to hundreds of different printer drivers. This utility and Python library is often used as the PDL parsing engine in print accounting software like PyKota or JASMine, but can of course be used independently. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #17 from Philip Prindeville phil...@redfish-solutions.com 2012-01-09 13:42:22 EST --- (In reply to comment #16) If you don't intend to use this spec file for an EPEL package, then you can delete the following spec file elements, all of which are unnecessary in every current Fedora release: the BuildRoot tag, rm -rf $RPM_BUILD_ROOT at the top of %install, the entire %clean script, and %defattr in the %files sections. Actually, I do intend to publish it on EPEL just as soon as it gets accepted on Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 13:49:45 EST --- Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command-0.12.0-1.fc15.src.rpm For completeness (and fedora-review ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753262
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
CC||rdie...@math.unl.edu
--- Comment #2 from Rex Dieter rdie...@math.unl.edu 2012-01-09 13:46:32 EST
---
OK, here's an initial review :
1. -devel MUST depend on main pkg. add to -devel
Requires: %{name}%{?_isa} = %{version}-%{release}
2. SHOULD track ABI, replace
%{_libdir}/lib%{name}.so.*
with
%{_libdir}/libqxmpp-dev.so.2
(or whatever the proper soname is).
3. SHOULD: better to patch/fix lib64 handling properly, instead of current
hack:
%ifarch x86_64
%__mv ${RPM_BUILD_ROOT}/usr/{lib,lib64}
%endif
if you can't patch, this is better,
%if %{_lib} = lib64
...
%endif
(there's more platforms using lib64 than just x86_64)
4. SHOULD use
BuildRequires: qt4-devel
(instead of qt-devel)
5. MUST fix -devel summary/description to reference qxmpp-dev instead of qxmpp
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 13:51:15 EST --- One more time correct links. Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command-0.12.0-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #18 from Philip Prindeville phil...@redfish-solutions.com 2012-01-09 13:56:15 EST --- Applied patches in comment 14 and comment 15 upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739367] Review Request: php-pecl-mysqlnd-qc - A query cache plugin for mysqlnd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739367 --- Comment #2 from Remi Collet fed...@famillecollet.com 2012-01-09 14:17:07 EST --- I delay this package review request because this extension is broken for PHP 5.4. Will update it ASAP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772288] Review Request: infiniband-diags - various InfiniBand fabric test utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772288 --- Comment #3 from Doug Ledford dledf...@redhat.com 2012-01-09 14:16:51 EST --- New files (although with the same n-v-r) uploaded to my package page listed in the URL above that address the comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772260] Review Request: srptools - utilities for mounting SRP shared resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772260 --- Comment #2 from Doug Ledford dledf...@redhat.com 2012-01-09 14:18:27 EST --- Yes and no. I plan to add this package to f15/f16/rawhide. The rest of the IB stack in both f15 and f16 are still SysV init based and I don't want to mix SysV and systemd unit files. So, the plan is to put this package as it is in, then update the rdma, opensm, and this package at the same time to systemd units in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772233 --- Comment #2 from Doug Ledford dledf...@redhat.com 2012-01-09 14:22:25 EST --- I believe they are the same thing or at least as close as they can be given that the mft packages are Windows/Linux capable while mstflint is linux specific. The older software you are referring to is tvflash. Both mstflint and mft tools supersede the old tvflash software. I'm not bothering to submit that for Fedora although it exists in both EL4 and EL5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772229] Review Request: perftest - Performance testing programs for InfiniBand networks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772229 --- Comment #3 from Doug Ledford dledf...@redhat.com 2012-01-09 14:27:09 EST --- Updated the package description and dropped the runme file from docs. New packages uploading to site as I type. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771485] Review Request: libcxgb4 - Chelsio T4 iWARP HCA Userspace Driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771485 --- Comment #2 from Doug Ledford dledf...@redhat.com 2012-01-09 14:29:05 EST --- libmlx4 provides libmlx4-devel-static because early versions of the package provided that. We switched the package naming over to the more standard compliant base base-devel base-static long ago and the old provides is in libmlx4 to keep any software that didn't get updated from breaking. Libcxgb4 has no such broken history and need not provide -devel-static as a package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772485
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com 2012-01-09
14:25:46 EST ---
(In reply to comment #2)
BTW, shouldn't this have WindowMaker or something in Requires:?
(sorry i'm not WindowMaker user)
No, not needed. Windowmaker dockapps are *designed* for Windowmaker and any
other window manager which supports these applets (Fluxbox, Openbox, Pekwm,
Afterstep...) but you can run them in any environment in windowed mode, too.
(In reply to comment #3)
Some more comments on SPEC file:
Replace:
zcat %{_sourcedir}/%{name}-%{version}.tar.gz | tar -xvzf -
with:
%setup -q
Doesn't work in this case. The package seems to be gzipped in an odd manner,
and the setup macro seems to be unable to detect it correctly.
I will have a look at the other issues next days.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772485 --- Comment #5 from Christos Triantafyllidis christos.triantafylli...@gmail.com 2012-01-09 15:02:20 EST --- Hi Mario, There should be some issue with the tar.gz you are using. Try re-downloading it from vendor: Your tar.gz: $ file wmnd-0.4.16.tar.gz wmnd-0.4.16.tar.gz: gzip compressed data, from Unix, last modified: Mon Aug 16 20:10:53 2010 $ tar -ztf wmnd-0.4.16.tar.gz tar: This does not look like a tar archive tar: Skipping to next header tar: Exiting with failure status due to previous errors The one at vendor's website: $ file wmnd-0.4.16.tar.gz wmnd-0.4.16.tar.gz: gzip compressed data, from Unix, last modified: Mon Aug 16 20:10:11 2010, max compression $ tar -ztf wmnd-0.4.16.tar.gz wmnd-0.4.16/ (other filenames) wmnd-0.4.16/src/README.master.xpm It looks like your SRPM embedded .tar.gz is gzipped: $ gunzip wmnd-0.4.16.tar.gz $ file wmnd-0.4.16.tar wmnd-0.4.16.tar: gzip compressed data, from Unix, last modified: Mon Aug 16 20:10:11 2010, max compression $ tar -ztf wmnd-0.4.16.tar wmnd-0.4.16/ (other filenames) wmnd-0.4.16/src/README.master.xpm This should also fix the file size mismatch. Regards, Christos -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 --- Comment #5 from Doug Ledford dledf...@redhat.com 2012-01-09 15:15:24 EST --- (In reply to comment #1) Just some comments: - License seems to be GPLv2 or BSD -- not GPLv2+ or BSD - You can use the name macro in Source0 - Comment on the patches in the spec file, if possible All done. - FSF address is wrong in rds-sample.c While checking on this, I noted that the main source files redirect a person to a copy of the GPLv2 in the file COPYING, yet that file isn't present. - Please harmonize the use of RPM_BUILD_ROOT and buildroot macro Done. - If you don't go for EPEL 5, you can delete the buildroot definition, the clean section and the rm in the install section The package will be shared with RHEL, including RHEL5, so these should stay for now. - defattr is no longer necessary See above. - Remove README from the documentation as it holds no valuable information Done. - The optflags are not used when compiling This is fixed, but it's kind of ugly. The upstream build files simply do not honor passed in CFLAGS via the environment, only if you explicitly set CFLAGS to the make comment are they honored (and this is in contradiction with the fact that configure says you can do CFLAGS=blah and it will put it in the makefile, it doesn't actually do so however). And the makefile doesn't append its own stuff to the passed in CFLAGS, it's either the built in CFLAGS or the passed in, no merging. So, I had to include the one item that the makefile needs in addition to the rpm opt stuff in order for it to compile. - You can patch the permissions for the executables in rds-tools-make.patch instead of changing them in the install section Done. - What is that rds.conf file about? The rds protocol is autoloaded if anyone attempts to open an rds socket. However, there is no method in place to determine if either the tcp transport, rdma transport, or both should be loaded in order to satisfy the needs of the rds protocol. So, whenever we load the rds protocol, also load both transport modules. That way, whatever one is appropriate can be used to service the request versus failing to open an rds socket even though the rds protocol was successfully loaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 --- Comment #6 from Doug Ledford dledf...@redhat.com 2012-01-09 15:19:19 EST --- (In reply to comment #5) (In reply to comment #1) - FSF address is wrong in rds-sample.c While checking on this, I noted that the main source files redirect a person to a copy of the GPLv2 in the file COPYING, yet that file isn't present. I meant to continue on to say that this is a legitimate issue that upstream needs to address. I'll contact them about both adding a COPYING file and making sure that the address in it is correct and also about updating the rds-sample.c file to have the proper address. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772243] Review Request: rds-tools - utilities for testing rds protocol networking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 --- Comment #7 from Doug Ledford dledf...@redhat.com 2012-01-09 15:21:01 EST --- (In reply to comment #4) By the way, running rds-info causes the following kernel warning: [38559.194671] [ cut here ] [38559.194752] WARNING: at kernel/softirq.c:159 _local_bh_enable_ip+0x44/0x8e() Yes, the upstream rds kernel support is somewhat lacking. Last I knew, Oracle carried over 50 patches in their kernel that they haven't bothered to send upstream, and presumably the fix for such an obvious DOA type issue as this one is among them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 --- Comment #3 from Minh Ngo nlmin...@gmail.com 2012-01-09 15:37:00 EST --- Fixed SRPM: https://github.com/Ignotus/qxmpp-fedora/blob/a76e05b841b02d6a34ac0af48c7d3f56ce57c60e/qxmpp-dev-0.3.45.1-4.fc16.src.rpm?raw=true SPEC: https://github.com/Ignotus/qxmpp-fedora/blob/a76e05b841b02d6a34ac0af48c7d3f56ce57c60e/qxmpp-dev.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2012-01-09 15:41:45 EST --- naming: ok scriptlets: ok sources: ok md5sum *.bz2 9498edd097631d321d48b12f8ad99da1 qxmpp-0.3.45.1-extras.tar.bz2 macros: ok licensing: ok looks good, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #19 from Michal Ambroz re...@seznam.cz 2012-01-09 16:03:40 EST --- False positives - thee are not spelling errors. I can change dban to DBAN to avoid one of those if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759779] Review Request: rachota - Straightforward timetracking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759779 --- Comment #8 from Sébastien Willmann sebastien.willm...@gmail.com 2012-01-09 16:02:34 EST --- The patch has been integrated upstream, so I removed it from the package. http://wilqu.fr/rpms/rachota/rachota.spec http://wilqu.fr/rpms/rachota/rachota-2.3-3.20120110cvs.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693370] Review Request: elementary-gtk-theme - elementary GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693370 --- Comment #12 from Christoph Wickert cwick...@fedoraproject.org 2012-01-09 16:09:17 EST --- Chris, are you still with me? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 --- Comment #5 from Rex Dieter rdie...@math.unl.edu 2012-01-09 16:07:00 EST --- Need to provide the information listed here, http://fedoraproject.org/wiki/Package_SCM_admin_requests in addition to seeing the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772751] New: Review Request: git-review - Helper for Gerrit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: git-review - Helper for Gerrit https://bugzilla.redhat.com/show_bug.cgi?id=772751 Summary: Review Request: git-review - Helper for Gerrit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: zait...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://people.redhat.com/zaitcev/tmp/git-review-1.9-2.fc16.spec SRPM URL: http://people.redhat.com/zaitcev/tmp/git-review-1.9-2.fc16.src.rpm Description: An extension for source control system git that creates and manages review requests in the patch management system Gerrit. It replaces the rfc.sh script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672555] Review Request: icc-profiles-openicc - The OpenICC profiles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672555 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2012-01-09 16:27:54 EST --- New Package SCM Request === Package Name: icc-profiles-openicc Short Description: The OpenICC profiles Owners: kwizart Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flag|fedora-cvs? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 --- Comment #6 from Minh Ngo nlmin...@gmail.com 2012-01-09 16:41:23 EST --- New Package SCM Request === Package Name: qxmpp-dev Short Description: Qt XMPP Library Owners: ignotusp Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] New: Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers https://bugzilla.redhat.com/show_bug.cgi?id=772766 Summary: Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@marionline.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://marionline.fedorapeople.org/packages/SPECS/stylus-toolbox.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/stylus-toolbox-0.2.7-0.fc16.src.rpm Description: Stylus Toolbox is a printer utility for Epson Stylus® inkjet printers that is designed to replace the Epson Printer Utility that comes with the Epson drivers for the Windows platform on Linux, Mac OS X, FreeBSD and other Unix and Unix-like operating systems that are supported by the Python programming language and the Gutenprint inkjet drivers. Stylus Toolbox is a graphical (GUI) front-end for Gutenprint's escputil command-line Epson printer utility. As a reult, it supports all printers supported by escputil and Gutenprint, including many recent-model Epson Stylus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flag|fedora-cvs? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #7 from Tomasz Torcz zdzi...@irc.pl 2012-01-09 17:50:28 EST --- Upstream did not answer for over a week. I've checked what other distribution do, and I will provide urec.h as uptimed.h in -devel package. Debian apparently does it this way for 7 years now. So, shipping uptimed.h is only change in -4 Spec URL: http://pipebreaker.pl/dump/uptimed.spec SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-4.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3634073 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753262] Review Request: qxmpp-dev - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769487 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kwiz...@gmail.com AssignedTo|nob...@fedoraproject.org|kwiz...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772786] New: Review Request: Converseen - A batch image conversion tool written in C++ with Qt4 and Magick++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Converseen - A batch image conversion tool written in C++ with Qt4 and Magick++ https://bugzilla.redhat.com/show_bug.cgi?id=772786 Summary: Review Request: Converseen - A batch image conversion tool written in C++ with Qt4 and Magick++ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@marionline.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://marionline.fedorapeople.org/packages/SPECS/converseen.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/converseen-0.4.7-29.fc16.src.rpm Description: Converseen is a batch image conversion tool and resizer written in C++ with Qt4 and Magick++. Converseen allows you to convert images in more than 100 different formats! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771123] Review Request: fex - Field split/extraction like cut/awk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771123 Mark McKinstry mmcki...@nexcess.net changed: What|Removed |Added Flag|needinfo?(mmckinst@nexcess. | |net)| --- Comment #3 from Mark McKinstry mmcki...@nexcess.net 2012-01-09 19:01:32 EST --- Mattia, Thank you for the review. I have: 1. Added a %clean section since I do plan on putting this in EPEL too. 2. Fixed the spelling issue. tokenizeing is now spelled tokenizing. rpmlint is still unhappy with the word but tokenizing is commonly used including the wikipedia article on lexical analysis. 3. Added a Group to the spec file. It wasn't in the original spec and it looks like rpmlint doesn't check for it. Updated spec and src.rpm: http://mmckinst.fedorapeople.org/packages/fex/fex.spec http://mmckinst.fedorapeople.org/packages/fex/fex-1.20100416.2814-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
