[Bug 783632] New: Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can 
generate skeleton test classes

https://bugzilla.redhat.com/show_bug.cgi?id=783632

   Summary: Review Request: php-phpunit-PHPUnit-SkeletonGenerator
- Tool that can generate skeleton test classes
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fed...@famillecollet.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL:
https://raw.github.com/remicollet/remirepo/master/php-phpunit-PHPUnit-SkeletonGenerator/php-phpunit-PHPUnit-SkeletonGenerator.spec
SRPM URL:
http://rpms.famillecollet.com/SRPMS/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.remi.src.rpm
Description: 
Tool that can generate skeleton test classes from production code classes
and vice versa.

--

PHPUnit 3.6.8 have marked `--skeleton-class` and `--skeleton-test` as
deprecated. Please use the `phpunit-skelgen` tool that is provided by the
`PHPUnit_SkeletonGenerator` package instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783414] Review Request: python-rdfextras - Python library for working with RDF

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783414

--- Comment #3 from Pierre-YvesChibon  2012-01-21 06:12:45 
EST ---
(In reply to comment #2)
> Comments:
> * licensing: Ok (BSD 2 clauses according upstream website), lacks a LICENSE
> file, you should request upstream to include it. Not a blocker (NAB).

The file is already included in the sources so the next release will have it.

> * rpmlint is not silent: you should request that upstream includes a man page
> for rdfpipe (NAB).

Will do.

> in %install you didn't remove the shebang in all files, i suggest you this
> one-liner:
> find %{buildroot}%{python_sitelib}/rdfextras -name '*.py' -exec sed -i
> '/#!.*python/d' {} \;
> => Blocker

Done

> * since you plan to maintain this package on Fedora and EPEL6, you must remove
> any reference to BuildRoot or buildroot cleaning.
> => Blocker
> 
> * i strongly suggest that you remove the %defattr macros too.
> 
> * you should use consistently macros (both $RPM_BUILD_ROOT and %{buildroot}),
> anyone is fine.
> => Blocker

Done

Updated version:
Spec URL: http://pingou.fedorapeople.org/RPMs//python-rdfextras.spec
SRPM URL:
http://pingou.fedorapeople.org/RPMs//python-rdfextras-0.1-2.el6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783414] Review Request: python-rdfextras - Python library for working with RDF

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783414

Haïkel Guémar  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Haïkel Guémar  2012-01-21 06:48:14 
EST ---
Since all valid points are still Ok, that blockers have been fixed and you
accepted my suggestions, there's no reasons to hold this package anymore as it
is fully compliant with Fedora guidelines.

I hereby approve python-rdfextras into Fedora Packages Collection.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783414] Review Request: python-rdfextras - Python library for working with RDF

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783414

--- Comment #5 from Pierre-YvesChibon  2012-01-21 07:01:32 
EST ---
Thanks a bunch for the review.

New Package SCM Request
===
Package Name: python-rdfextras
Short Description: Python library for working with RDF
Owners: pingou
Branches: f16 f15 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

Haïkel Guémar  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
 AssignedTo|nob...@fedoraproject.org|karlthe...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Haïkel Guémar  2012-01-21 07:29:26 
EST ---
Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[-]: MUST Buildroot is not present
 Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[-]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[-]: MUST Each %files section contains %defattr if rpm < 4.4
 Note: defattr() present in %files section. This is OK if packaging
 for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[-]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf is only needed if supporting EPEL5
[!]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[-]: MUST Rpmlint output is silent.

rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.src.rpm

php-phpunit-PHPUnit-SkeletonGenerator.src: W: spelling-error %description -l
en_US versa -> avers, verse, verso
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc17.noarch.rpm

php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: spelling-error %description -l
en_US versa -> avers, verse, verso
php-phpunit-PHPUnit-SkeletonGenerator.noarch: W: no-manual-page-for-binary
phpunit-skelgen
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
/home/builder/783632/PHPUnit_SkeletonGenerator-1.0.0.tgz :
  MD5SUM this package : c879684cfdbafb0c629df93a58c3e50e
  MD5SUM upstream package : c879684cfdbafb0c629df93a58c3e50e

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the pack

[Bug 752223] Review Request: racoon2 - an implementation of key management system for IPsec

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752223

Pavel Simerda  changed:

   What|Removed |Added

 Attachment #532589|0   |1
is obsolete||
 Attachment #532682|0   |1
is obsolete||

--- Comment #39 from Pavel Simerda  2012-01-21 07:35:36 EST 
---
Created attachment 556688
  --> https://bugzilla.redhat.com/attachment.cgi?id=556688
SRPM release 12

The wiki pages about initscripts and systemd units packaging is rather
confusing. I decided to remove the sysvinit package because the wiki
recommendations simply don't work.

The current package is still intended for both Fedora and EPEL, tested on
Fedora, and this is accomplished by two simple conditionals. It can be split
into branches when it gets to Git if needed.

rpmlint output:

racoon2.i686: E: non-standard-dir-perm /etc/racoon2 0700L

/etc/racoon2 contains IPsec configuration. Administrator
can include keys in there and forget to set proper permissions.

Setting mode 700 is *not* necessary but it helps to prevent ordinary
users from accessing IPsec configuration.

Upstream protects individual files but we have the advantage
of knowing the diretory name.

Please see also Bug 753354, review request for Strongswan.

racoon2.i686: E: non-standard-dir-perm /var/run/racoon2 0700L

Setting mode 700 helps users prevent accessing runtime data of Racoon2.

racoon2.i686: W: dangerous-command-in-%post chmod

Running chmod is necessary to protect a key generated during %post.

Changes:

* Sun Jan 15 2012 Pavel Šimerda  - 20100526a-12
- Removed sysvinit subpackage
- Added conditionals to handle different init systems
- Changed initrd macro to initd
- Marked functions as config file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 741626] Review Request: packmol - Packing optimization for molecular dynamics simulations

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741626

Martin Gieseking  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||martin.giesek...@uos.de
 AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
   Flag||fedora-review?

--- Comment #6 from Martin Gieseking  2012-01-21 
08:52:06 EST ---
I take this one. The package looks good to me -- I just recommend to explicitly
remove cenmass.o in %prep in order to prevent linking this object file.

Also, upstream has released a new version of packmol. Maybe you'd like to
update the package. The license headers are still missing but there's a file
LICENSE present now which refers to GPLv2 only while COPYING still contains the
GPLv3 license text. Upstream should definitely fix this. The license tag GPL+
is nonetheless correct, though.


$ rpmlint  *.rpm
packmol.src: W: spelling-error %description -l en_US lamellar -> Carmella,
Mallarme, Marcella
packmol.src:58: W: macro-in-comment %{buildroot}
packmol.src:58: W: macro-in-comment %{_bindir}
packmol.src:68: W: macro-in-comment %{_bindir}
packmol.src: W: invalid-url Source0:
http://packmol.googlecode.com/files/packmol-1.1.1.258.tar.gz HTTP Error 404:
Not Found
packmol.x86_64: W: spelling-error %description -l en_US lamellar -> Carmella,
Mallarme, Marcella
packmol.x86_64: W: no-manual-page-for-binary packmol
packmol.x86_64: W: no-manual-page-for-binary packmol_solvate
3 packages and 0 specfiles checked; 0 errors, 8 warnings.

The above warnings can safely be ignored:
- macros in comments are expected
- invalid url warning is false positive
- spelling errors are false positive
- no manual pages available for the binaries

-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv3 license text present
- no copyright information in sources
=> GPL+

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum packmol-1.1.1.258.tar.gz*
d1b12036b94f48c92595e9c4d3180009  packmol-1.1.1.258.tar.gz
d1b12036b94f48c92595e9c4d3180009  packmol-1.1.1.258.tar.gz.upstream

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm package

[Bug 760033] Review Request: kde-plasma-publictransport - Public Transport plasma applet

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760033

Gregor Tätzner  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #16 from Gregor Tätzner  2012-01-21 09:30:49 EST 
---
Hurray, thanks Brendan. I have already contacted upstream.

New Package SCM Request
===
Package Name: kde-plasma-publictransport
Short Description: Public Transport plasma applet
Owners: brummbq
Branches: f15 f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783655] New: Review Request: aimage - Advanced Disk Imager

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: aimage - Advanced Disk Imager

https://bugzilla.redhat.com/show_bug.cgi?id=783655

   Summary: Review Request: aimage - Advanced Disk Imager
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kwiz...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL:
http://kwizart.fedorapeople.org/review/aimage.spec
SRPM URL:
http://kwizart.fedorapeople.org/review/aimage-3.2.5-1.fc17.src.rpm
Description: Advanced Disk Imager

Upstream has resurrected this package to make it compliant with newer afflib.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783656] New: Review Request: python-pybloomfiltermmap - A Bloom filter (bloomfilter) for Python built on mmap

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-pybloomfiltermmap - A Bloom filter 
(bloomfilter) for Python built on mmap

https://bugzilla.redhat.com/show_bug.cgi?id=783656

   Summary: Review Request: python-pybloomfiltermmap - A Bloom
filter (bloomfilter) for Python built on mmap
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: athma...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://athmane.fedorapeople.org/pkgs/python-pybloomfiltermmap.spec
SRPM URL:
http://athmane.fedorapeople.org/pkgs/python-pybloomfiltermmap-0.3.2-1.fc16.src.rpm
Description: 
The goal of pybloomfiltermmap is to provide a fast, simple, scalable,
correct library for Bloom Filters in Python.

Notes:
- This is my first package and I need a sponsor
- I needed this package to run w3af so it might be useful for others.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783657] New: Review Request: fiwalk - Batch analysis of a disk image

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: fiwalk - Batch analysis of a disk image

https://bugzilla.redhat.com/show_bug.cgi?id=783657

   Summary: Review Request: fiwalk - Batch analysis of a disk
image
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kwiz...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec
SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-1.fc17.src.rpm
Description: Batch analysis of a disk image

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783656] Review Request: python-pybloomfiltermmap - A Bloom filter (bloomfilter) for Python built on mmap

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783656

Athmane Madjoudj  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783656] Review Request: python-pybloomfiltermmap - A Bloom filter (bloomfilter) for Python built on mmap

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783656

--- Comment #1 from Athmane Madjoudj  2012-01-21 10:09:15 
EST ---
Koji scratch build (rawhide): 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3720009

rpmlint output (*.rpm *.spec):

python-pybloomfiltermmap.src: W: spelling-error Summary(en_US) bloomfilter ->
bloom filter, bloom-filter, Bloomfield
python-pybloomfiltermmap.src: W: spelling-error Summary(en_US) mmap -> map, m
map, mamma
python-pybloomfiltermmap.src: W: spelling-error %description -l en_US scalable
-> salable, callable, calculable
python-pybloomfiltermmap.x86_64: W: spelling-error Summary(en_US) bloomfilter
-> bloom filter, bloom-filter, Bloomfield
python-pybloomfiltermmap.x86_64: W: spelling-error Summary(en_US) mmap -> map,
m map, mamma
python-pybloomfiltermmap.x86_64: W: spelling-error %description -l en_US
scalable -> salable, callable, calculable
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

--- Comment #2 from Remi Collet  2012-01-21 10:20:25 
EST ---
LICENSE, provided by upstream is in the %doc

rpm -ql --docfiles php-phpunit-PHPUnit-SkeletonGenerator
/usr/share/doc/pear/PHPUnit_SkeletonGenerator/ChangeLog.markdown
/usr/share/doc/pear/PHPUnit_SkeletonGenerator/LICENSE
/usr/share/doc/pear/PHPUnit_SkeletonGenerator/README.markdown

%{pear_docdir} is the common place for doc, when provided and installed by
upstream (PHP Guidelines)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 767050] Review Request: hibernate-validator - Bean Validation (JSR 303) Reference Implementation

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767050

--- Comment #5 from Marek Goldmann  2012-01-21 11:46:17 
EST ---
I packaged jaxb2-maven-plugin. This allowed me to compile the full
hibernate-validator. I'll start submitting all required specs soon. In total -
13 new packages must be added...

In the meantime, here is what my spec looks like:

SPEC:
http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator.spec
SRPM:
http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator-4.2.0-3.fc17.src.rpm

Feel free to make changes to this spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

Haïkel Guémar  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Haïkel Guémar  2012-01-21 12:09:18 
EST ---
Ok, rpmls confirmed that so i hereby approve this package into Fedora Packages
Collection.

I was terrified by the idea that you might be fallible. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

Remi Collet  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Remi Collet  2012-01-21 12:21:24 
EST ---
Thanks for the review

New Package SCM Request
===
Package Name: php-phpunit-PHPUnit-SkeletonGenerator
Short Description: Tool that can generate skeleton test classes
Owners: remi
Branches: f15 f16 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 781884] Review Request: rubygem-raindrops - Real-time stats for preforking Rack servers

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=781884

Alejandro_Perez  changed:

   What|Removed |Added

 CC||alejandro.perez.torres@gmai
   ||l.com
 AssignedTo|nob...@fedoraproject.org|alejandro.perez.torres@gmai
   ||l.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772362

--- Comment #9 from Mihai Limbășan  2012-01-21 12:40:33 EST 
---
Ping: Sigil 0.5.0 stable was just released.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 781884] Review Request: rubygem-raindrops - Real-time stats for preforking Rack servers

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=781884

Alejandro_Perez  changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783683] New: Review Request: cptutils - Utilities to manipulate and translate color gradients

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cptutils - Utilities to manipulate and translate color 
gradients

https://bugzilla.redhat.com/show_bug.cgi?id=783683

   Summary: Review Request: cptutils - Utilities to manipulate and
translate color gradients
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: volke...@gmx.at
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://www.geofrogger.net/review/cptutils.spec
SRPM URL: http://www.geofrogger.net/review/cptutils-1.41-1.fc16.src.rpm
Description:

The cptutils package contains a number of utilities for the manipulation of
color gradients; mainly for translating between different formats. Formats
supported include ggr (GIMP gradient), cpt (GMT color palette table),
avl (Arcview Legend), lut (xmedcon), svg, and version 3 of the grd format. 

The cptutils package was written to aid the construction of the cpt archive
cpt-city http://soliton.vm.bytemark.co.uk/pub/cpt-city where thousands of
gradients can be downloaded.

http://koji.fedoraproject.org/koji/taskinfo?taskID=3720229

rpmlint:

cptutils.src: W: spelling-error %description -l en_US ggr -> gr, gar, mgr
cptutils.src: W: spelling-error %description -l en_US cpt -> pct, cot, ct
cptutils.src: W: spelling-error %description -l en_US avl -> val, av, lav
cptutils.src: W: spelling-error %description -l en_US lut -> loot, ult, lit
cptutils.src: W: spelling-error %description -l en_US xmedcon -> consumed
cptutils.src: W: spelling-error %description -l en_US svg -> avg, sag, VG
cptutils.src: W: spelling-error %description -l en_US grd -> gr, rd, grid
cptutils.x86_64: W: spelling-error %description -l en_US ggr -> gr, gar, mgr
cptutils.x86_64: W: spelling-error %description -l en_US cpt -> pct, cot, ct
cptutils.x86_64: W: spelling-error %description -l en_US avl -> val, av, lav
cptutils.x86_64: W: spelling-error %description -l en_US lut -> loot, ult, lit
cptutils.x86_64: W: spelling-error %description -l en_US xmedcon -> consumed
cptutils.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG
cptutils.x86_64: W: spelling-error %description -l en_US grd -> gr, rd, grid
cptutils.x86_64: E: incorrect-fsf-address /usr/share/doc/cptutils-1.41/COPYING

I'll take care of that wrong address in COPYING.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 741626] Review Request: packmol - Packing optimization for molecular dynamics simulations

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741626

--- Comment #7 from Jussi Lehtola  2012-01-21 13:21:57 
EST ---
(In reply to comment #6)
> I take this one. The package looks good to me -- I just recommend to 
> explicitly
> remove cenmass.o in %prep in order to prevent linking this object file.

Done.

> Also, upstream has released a new version of packmol. Maybe you'd like to
> update the package. The license headers are still missing but there's a file
> LICENSE present now which refers to GPLv2 only while COPYING still contains 
> the
> GPLv3 license text. Upstream should definitely fix this. The license tag GPL+
> is nonetheless correct, though.

Done; but the correct license tag is now GPLv2.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/packmol.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/packmol-1.1.2.017-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 742729] Review Request: php-pecl-mysqlnd-ms - A replication and load balancing plugin for mysqlnd

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742729

--- Comment #4 from Remi Collet  2012-01-21 13:25:46 
EST ---
Update spec to include conditional ZTS extension build (for fedora 17)

Changes:
https://github.com/remicollet/remirepo/commit/d622a98b78ff25f94537c6ef4cc25df82bdea8bd

New SRPM:
http://rpms.famillecollet.com/SRPMS/php-pecl-mysqlnd-ms-1.1.2-4.remi.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 781884] Review Request: rubygem-raindrops - Real-time stats for preforking Rack servers

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=781884

--- Comment #1 from Alejandro_Perez  
2012-01-21 13:54:22 EST ---
Every seems ok however the home page of the software 
http://raindrops.bogomips.org/ on the license section
http://raindrops.bogomips.org/LICENSE.html assign a GNU Lesser General Public
License (LGPL) v2 or v3 and in the spec file you set it as GPLv2+ please verify
license.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783317] Review Request: akonadi-google - Akonadi Resources for accessing Google services

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783317

Mario Santagiuliana  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
Last Closed||2012-01-21 14:03:09

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783317] Review Request: akonadi-google - Akonadi Resources for accessing Google services

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783317

--- Comment #7 from Fedora Update System  2012-01-21 
14:05:40 EST ---
akonadi-google-0.2-11.20120121gitbe021c6.fc16 has been submitted as an update
for Fedora 16.
https://admin.fedoraproject.org/updates/akonadi-google-0.2-11.20120121gitbe021c6.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783317] Review Request: akonadi-google - Akonadi Resources for accessing Google services

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783317

--- Comment #8 from Fedora Update System  2012-01-21 
14:06:43 EST ---
akonadi-google-0.2-11.20120121gitbe021c6.fc15 has been submitted as an update
for Fedora 15.
https://admin.fedoraproject.org/updates/akonadi-google-0.2-11.20120121gitbe021c6.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

--- Comment #5 from Jon Ciesla  2012-01-21 14:35:26 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760033] Review Request: kde-plasma-publictransport - Public Transport plasma applet

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760033

--- Comment #17 from Jon Ciesla  2012-01-21 14:33:54 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 615508] Review Request: nut-nutrition - A nutritional Software

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615508

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@tiscali.it

--- Comment #10 from Mattia Verga  2012-01-21 14:39:21 
EST ---
Review stalled.
Ankur do you plan to continue this submission and provide valid links to spec
and src.rpm files?

Without response within one week I will proceed closing this ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 509965] Review Request: snmptt - SNMPTT (SNMP Trap Translator) is an SNMP trap handler written in Perl

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509965

Mattia Verga  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||mattia.ve...@tiscali.it
 Blocks||201449(FE-DEADREVIEW)
 Resolution||NOTABUG
Last Closed||2012-01-21 14:34:06

--- Comment #20 from Mattia Verga  2012-01-21 14:34:06 
EST ---
No response from the submitter, closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 773487] Review Request: trac-batchmodify-plugin - Batch modification of tickets

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=773487

Kevin Fenzi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ke...@scrye.com
   Flag||fedora-review?

--- Comment #1 from Kevin Fenzi  2012-01-21 14:47:33 EST ---
I'll review this. Look for a full review hopefully later today.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 619380] Review Request: giis - Solution to undelete files "gET iT i sAY"

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619380

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@tiscali.it

--- Comment #5 from Mattia Verga  2012-01-21 14:48:54 
EST ---
Pavel, is this review request still valid? Do you plan continue and provide
working URLs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 562226] Review Request: ccl - Free Common Lisp implementation

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562226

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@tiscali.it

--- Comment #21 from Mattia Verga  2012-01-21 14:46:23 
EST ---
Alexander, is this review request still valid? Can you provide working URLs for
spec and src.rpm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

--- Comment #8 from Fedora Update System  2012-01-21 
15:03:45 EST ---
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.el6 has been submitted as an
update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

--- Comment #6 from Fedora Update System  2012-01-21 
15:01:43 EST ---
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16 has been submitted as an
update for Fedora 16.
https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

--- Comment #7 from Fedora Update System  2012-01-21 
15:02:18 EST ---
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc15 has been submitted as an
update for Fedora 15.
https://admin.fedoraproject.org/updates/php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 532241] Review Request: emacs-identica-mode - Identica mode for emacs.

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532241

Arun SAG  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770986

--- Comment #13 from Fedora Update System  
2012-01-21 15:33:46 EST ---
rubygem-kgio-2.7.0-3.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752311

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gitso-0.6-6.el6
 Resolution||ERRATA
Last Closed||2012-01-21 15:34:40

--- Comment #15 from Fedora Update System  
2012-01-21 15:34:40 EST ---
gitso-0.6-6.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 532241] Review Request: emacs-identica-mode - Identica mode for emacs.

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532241

Arun SAG  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WONTFIX
Last Closed||2012-01-21 15:15:10

--- Comment #9 from Arun SAG  2012-01-21 15:15:10 EST ---
Closing this. No one seems to be interested in reviewing this!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 782786] Review Request: equalx - A graphical editor for writing LaTeX equations

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=782786

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System  
2012-01-21 16:53:12 EST ---
equalx-0.5.1-2.fc16 has been pushed to the Fedora 16 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 770755] Review Request: gnome-shell-extension-calc - A simple calculator in the search overview

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770755

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2012-01-21 
16:51:05 EST ---
gnome-shell-extension-calc-0-0.3.git2fca097.fc16 has been pushed to the Fedora
16 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771070] Review Request: nwipe - Securely erase disks using a variety of recognized methods

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771070

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||nwipe-0.06-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-21 16:51:37

--- Comment #31 from Fedora Update System  
2012-01-21 16:51:37 EST ---
nwipe-0.06-2.fc16 has been pushed to the Fedora 16 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753354] Review Request: strongswan - IKEv1 and IKEv2 daemon

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753354

Pavel Simerda  changed:

   What|Removed |Added

 Attachment #556578|0   |1
is obsolete||
 Attachment #556587|0   |1
is obsolete||

--- Comment #12 from Pavel Simerda  2012-01-21 17:13:28 EST 
---
Created attachment 556722
  --> https://bugzilla.redhat.com/attachment.cgi?id=556722
strongswan-4.6.1-4 SRPM

For now I'm implementing the safe way, i.e. to protect the whole configuration
directory. This is the same I'm doing to Racoon2 but also the same that is done
in Fedora's Openswan package.

This change introduces rpmlint's:

strongswan.i686: E: non-standard-dir-perm /etc/strongswan 0700L

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753354] Review Request: strongswan - IKEv1 and IKEv2 daemon

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753354

--- Comment #13 from Pavel Simerda  2012-01-21 17:14:03 EST 
---
Created attachment 556723
  --> https://bugzilla.redhat.com/attachment.cgi?id=556723
Updated SPEC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783655] Review Request: aimage - Advanced Disk Imager

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783655

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich  2012-01-21 18:51:28 EST 
---
You can remove defattr.

It seems to me, there is no afflib in EL. If I'm right and you don't want to
introduce it there, you can drop everything specific for EPEL 5 packaging:

- Buildroot definition
- rm in install section
- clean section

More important things:

- Add COPYING to %doc
- Resolve the format warnings in the build
- "WARNING: unrecognized options: --enable-opt"
- Does aimage make use of ncurses and readline? It seeks for them and also
tries to link.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783716] New: Review Request:gmail-notify-ext - Gmail checker Gnome Online Accounts based

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request:gmail-notify-ext - Gmail checker Gnome Online Accounts 
based

https://bugzilla.redhat.com/show_bug.cgi?id=783716

   Summary: Review Request:gmail-notify-ext - Gmail checker Gnome
Online Accounts based
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jablona...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL:
http://dl.dropbox.com/u/47812293/gmail_notify/V3.4/fedora/gmail-notify-ext.spec
SRPM URL:
http://dl.dropbox.com/u/47812293/gmail_notify/V3.4/fedora/gmail-notify-ext-0.3.4-1.fc16.src.rpm
Description: Gnome 3 shell extension to check gmail accounts for new emails
checker. Utilizes Gnome Online Accounts OAuth to connect to Gmail

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783657] Review Request: fiwalk - Batch analysis of a disk image

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783657

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich  2012-01-21 19:17:04 EST 
---
Correct these permissions in the prep section:

fiwalk-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/fiwalk-0.6.16/src/fiwalk.cpp
fiwalk-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/fiwalk-0.6.16/src/base64.h
fiwalk-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/fiwalk-0.6.16/src/base64.cpp

COPYING states Public Domain.

I think the description could be better. Maybe you can make up something
together with http://afflib.org/software/fiwalk?

Consider to install the example Python scripts as documentation. Though I
wonder about where the Python module is.


(The stuff I wrote on defattr and EPEL on the aimage review also applies here.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783268] Review Request: goffice08 - Goffice support libraries

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783268

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich  2012-01-21 19:45:09 EST 
---
Requires:   %{name} = %{version}-%{release} should have "isa".

You can drop defattr.

%{_datadir}/gtk-doc/html/goffice-0.8/ should be marked as documentation, I
guess.

BUGS and MAINTAINERS could be included as documentation.

"gnome" as mentioned is in the description should probably start with a capital
letter, being a name.

goffice08.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
17)
goffice08.src: W: invalid-url Source0:
http://ftp.gnome.org/pub/gnome/sources/goffice/0.8.17/goffice-0.8.17.tar.xz
HTTP Error 404: Not Found

http://ftp.gnome.org/pub/gnome/sources/goffice/0.8/goffice-0.8.17.tar.xz works

Rpmlint warns about wrong FSF address, but that is pretty minor, given the
whole GPLv2/+ issue.

Scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3720752

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 773487] Review Request: trac-batchmodify-plugin - Batch modification of tickets

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=773487

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Kevin Fenzi  2012-01-21 19:54:35 EST ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Might be good to ask upstream to be more clear about the license and include 
a copy of it. Not a blocker. 

2. rpmlint says: 
trac-batchmodify-plugin.noarch: W: no-documentation
trac-batchmodify-plugin.src: W: invalid-url Source0:
trac-batchmodify-plugin-0.8.0.svn11133.tar.gz

both can be ignored. 

I see no blockers here, so this package is APPROVED. 

Happy to co-maintain.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 736577] Review Request: ghc-snap-core - Snap web framework core library

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736577

--- Comment #17 from Lakshmi Narasimhan  2012-01-21 
23:59:34 EST ---
Just a headsup. This package depends on ghc-mwc-random 0.10.0. Rawhide has
ghc-mwc-random-0.11.0.0

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664151] Review Request: ghc-Diff - A O(ND) diff algorithm in Haskell

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664151

Lakshmi Narasimhan  changed:

   What|Removed |Added

  Status Whiteboard|notready|Ready

--- Comment #3 from Lakshmi Narasimhan  2012-01-22 
00:13:23 EST ---
SRPM file :
http://narasim.fedorapeople.org/package_reviews/ghc-Diff-0.1.3-1.fc15.src.rpm
Spec file : http://narasim.fedorapeople.org/package_reviews/ghc-Diff.spec

rpmlint output:
rpmlint  -i ghc-Diff-0.1.3-1.fc15.src.rpm  ghc-Diff-0.1.3-1.fc15.x86_64.rpm
ghc-Diff-devel-0.1.3-1.fc15.x86_64.rpm ../ghc-Diff.spec
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769919] Review Request: hydra - Very fast network log-on cracker

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769919

Athmane Madjoudj  changed:

   What|Removed |Added

  Alias||hydra

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769056] Review Request: wbox - HTTP testing tool and configuration-less HTTP server

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769056

Athmane Madjoudj  changed:

   What|Removed |Added

  Alias||wbox

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 461385] Review Request: hydra - A very fast network logon cracker

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461385

Athmane Madjoudj  changed:

   What|Removed |Added

 CC||athma...@gmail.com
  Alias|hydra   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783294] Review Request: picolisp - Lisp Interpreter

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783294

Lakshmi Narasimhan  changed:

   What|Removed |Added

   Priority|unspecified |medium
 Status|NEW |ASSIGNED
 CC||lakshminaras2...@gmail.com
 AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com
   Severity|unspecified |medium

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752311

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|gitso-0.6-6.el6 |gitso-0.6-6.fc16

--- Comment #16 from Fedora Update System  
2012-01-22 00:24:00 EST ---
gitso-0.6-6.fc16 has been pushed to the Fedora 16 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752311

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|gitso-0.6-6.fc16|gitso-0.6-6.fc15

--- Comment #17 from Fedora Update System  
2012-01-22 00:27:49 EST ---
gitso-0.6-6.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769450] Review Request: gap-table-of-marks - GAP Table of Marks package

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769450

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System  
2012-01-22 00:25:52 EST ---
gap-table-of-marks-1.2.2-1.fc16 has been pushed to the Fedora 16 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783632] Review Request: php-phpunit-PHPUnit-SkeletonGenerator - Tool that can generate skeleton test classes

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783632

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2012-01-22 
00:27:23 EST ---
php-phpunit-PHPUnit-SkeletonGenerator-1.0.0-1.fc16 has been pushed to the
Fedora 16 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 664151] Review Request: ghc-Diff - A O(ND) diff algorithm in Haskell

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664151

--- Comment #4 from Lakshmi Narasimhan  2012-01-22 
00:44:24 EST ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3721049

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 758966] Review Request: ghc-warp - Fast webserver library for WAI apps

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758966

Lakshmi Narasimhan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lakshminaras2...@gmail.com
   Flag||fedora-review+

--- Comment #3 from Lakshmi Narasimhan  2012-01-22 
01:21:19 EST ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.

rpmlint  -i ghc-warp-0.4.6.3-1.fc15.src.rpm ghc-warp-0.4.6.3-1.fc15.x86_64.rpm 
ghc-warp-devel-0.4.6.3-1.fc15.x86_64.rpm  ../ghc-warp.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag  - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK, in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
BSD license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
 md5sum warp-0.4.6.3.tar.gz 
e9f232303445224b28184b1bfb5eedad  warp-0.4.6.3.tar.gz

md5sum ghc-warp-0.4.6.3-1.fc16.src/warp-0.4.6.3.tar.gz 
e9f232303445224b28184b1bfb5eedad 
ghc-warp-0.4.6.3-1.fc16.src/warp-0.4.6.3.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
API documentation is in -devel package
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-warp
error: Failed dependencies:
ghc(warp-0.4.6.3) = 4a882afc5ec83d107d700af68bd33bf0 is needed by
(installed) ghc-warp-devel-0.4.6.3-1.fc15.x86_64
ghc-warp = 0.4.6.3-1.fc15 is needed by (installed)
ghc-warp-devel-0.4.6.3-1.fc15.x86_64

[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the packages. Loaded Network.Wai.Handler.Warp into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.
[+]SHOULD: License header is mentioned in each source file.

cabal2spec-diff is OK.

APPROVED.

Latest version is 1.0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
__

[Bug 664151] Review Request: ghc-Diff - A O(ND) diff algorithm in Haskell

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664151

Kalpa Welivitigoda  changed:

   What|Removed |Added

 CC||callka...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 781884] Review Request: rubygem-raindrops - Real-time stats for preforking Rack servers

2012-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=781884

--- Comment #2 from Guillermo Gómez  2012-01-22 
01:43:04 EST ---
Right ! fixed

SPEC: http://gomix.fedorapeople.org/rubygem-raindrops/rubygem-raindrops.spec
SRPM:
http://gomix.fedorapeople.org/rubygem-raindrops/rubygem-raindrops-0.8.0-2.fc16.src.rpm

thanks for reviewing

$ rpmlint -v SPECS/rubygem-raindrops.spec 
SPECS/rubygem-raindrops.spec: I: checking-url
http://rubygems.org/gems/raindrops-0.8.0.gem (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v
/var/lib/mock/fedora-16-x86_64/result/rubygem-raindrops-0.8.0-2.fc16.x86_64.rpm 
rubygem-raindrops.x86_64: I: checking
rubygem-raindrops.x86_64: W: spelling-error Summary(en_US) preforking ->
preforming, preferring
rubygem-raindrops.x86_64: W: spelling-error %description -l en_US preforking ->
preforming, preferring
rubygem-raindrops.x86_64: I: checking-url http://raindrops.bogomips.org/
(timeout 10 seconds)
rubygem-raindrops.x86_64: W: no-soname
/usr/lib/ruby/gems/1.8/gems/raindrops-0.8.0/lib/raindrops_ext.so
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review