[Bug 809843] Review Request: perl-Test-Reporter - Sends test results to cpan-test...@perl.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809843 --- Comment #1 from Petr Pisar ppi...@redhat.com 2012-04-05 02:43:41 EDT --- This package is licensed as (GPL+ or Artistic) despite the COPYING file is GPLv3 copy. Thus spake upstream: From: David Golden dagol...@cpan.org To: Petr Pisar ppi...@redhat.com Subject: Re: Test::Report lincense The COPYING file is incorrect. The license is Artistic 1 or GPL 1 (or later GPL). David On Wed, Apr 4, 2012 at 9:25 AM, Petr Pisar ppi...@redhat.com wrote: Hello, I have a question regarding Test-Report-1.58 license. The lib/Test/Reporter.pm POD states: This is free software; you can redistribute it and/or modify it under the same terms as the Perl 5 programming language system itself. and LICENSE file confirms it: Terms of the Perl programming language system itself a) the GNU General Public License as published by the Free Software Foundation; either version 1, or (at your option) any later version, or b) the Artistic License But the distributed COPYING file quotes GPLv3 license. It's confusing for me. Is Test-Report licensed as (GPLv1+ or Artistic) or (GPLv3+ or Artistic)? -- Petr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809748] Review Request: xz-java - Java implementation of XZ data compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809748 --- Comment #3 from Mikolaj Izdebski mizde...@redhat.com 2012-04-05 03:03:47 EDT --- Thank you for the review. I have fixed the issues you found. The new package is: Spec URL: http://mizdebsk.fedorapeople.org/review/xz-java/xz-java.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/xz-java/xz-java-1.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com AssignedTo|nob...@fedoraproject.org|psab...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810059
Alec Leamas leamas.a...@gmail.com changed:
What|Removed |Added
CC||leamas.a...@gmail.com
--- Comment #1 from Alec Leamas leamas.a...@gmail.com 2012-04-05 04:13:20 EDT
---
Just some initial remarks, no references (drop a line if need be).
- Package does not build in mock. Patch below fixes.
- As for the missing doc, file a bug upstream to add the license file.
- The examples might just go into -devel IMHO.
- You need to somehow use %{optflags} in the Makefile.
- Makefile contains a 'strip' command which should be removed.
- opencl-utils-debuginfo.i686: E: empty-debuginfo-package related to above.
- Since this a library intended to be used by other programs, the Makefile
should be patched to include a soname (a %global macro), and symlinks setup
accordingly. That patch should be acceptable upstream.
- The description for -devel says 'source code'; shouldn't that be 'header
files'?
- The debug package name opencl-utils-debuginfo is not consistent w the others.
--- *spec.ORG 2012-04-05 09:16:17.211177855 +0200
+++ opencl-utils.spec 2012-04-05 09:17:25.477104941 +0200
@@ -18,6 +18,8 @@
#http://code.google.com/p/dolphin-emu/source/browse/Externals/CLRun/clrun/generateClRun.pl
Patch1: %{name}-trimwhitespace.patch
+BuildRequires: mesa-libGL-devel
+
%package -n CLRun
Summary:Dynamic loader for OpenCL
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810049] Review Request: netbeans - Integrated Development Environment (IDE)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810049 --- Comment #2 from gil cattaneo punto...@libero.it 2012-04-05 04:55:18 EDT --- if it is not a problem... yes thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810059 --- Comment #2 from Alec Leamas leamas.a...@gmail.com 2012-04-05 05:12:43 EDT --- A second thought on naming: the %name macro is set to upstream's name opencl-utils. However, you override it everywhere and the package is effectively named CLrun. This does *not* match the upstream name. I suggest that you name the packages to the default opencl-utils-*. Just live with the fact that only clrun is packaged, making a note in the %descr about it. If/when someone else needs more packaged it's just to fix, but without changing the package name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755033] Review Request: openstack-quantum - Virtual network service for OpenStack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755033 Pádraig Brady p...@draigbrady.com changed: What|Removed |Added CC||p...@draigbrady.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #10 from Pádraig Brady p...@draigbrady.com 2012-04-05 05:17:52 EDT --- Package Change Request == Package Name: openstack-quantum New Branches: el6 Owners: rkukura apevec chrisw gkotton markmc pbrady rackerjoe This is to support the Essex upgrade in EPEL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805864] Review Request: glassfish-jsp-api - Glassfish J2EE JSP API specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805864 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #4 from Krzysztof Daniel kdan...@redhat.com 2012-04-05 05:30:31 EDT --- Indeed in koji it works, it must be something wrong with my system then. http://koji.fedoraproject.org/koji/taskinfo?taskID=3965378 *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809348] Review Request: darkclient - A command line tool for the darkroom service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809348 Kushal Das kushal...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Kushal Das kushal...@gmail.com 2012-04-05 05:32:54 EDT --- New Package SCM Request === Package Name: darkclient Short Description: A command line tool for the darkroom service. server Owners: kushal Branches: el6 f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810205] New: Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ https://bugzilla.redhat.com/show_bug.cgi?id=810205 Summary: Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mihkule...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://mkulemin.fedorapeople.org/erlang-erlzmq2.spec SRPM URL: https://koji.fedoraproject.org/koji/getfile?taskID=3965433name=erlang-erlzmq2-0-2.20120404gitd9e8614.fc16.src.rpm Description: NIF based Erlang binding for ZeroMQ messaging library. This implementation is faster than port driver based. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810205] Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810205 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com QAContact|extras...@fedoraproject.org |lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2012-04-05 06:44:38 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 448292] Review Request: fbpanel - a lightweight X11 desktop panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448292 Damien Durand splinu...@gmail.com changed: What|Removed |Added CC||splinu...@gmail.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #24 from Damien Durand splinu...@gmail.com 2012-04-05 07:26:17 EDT --- Package Change Request == Package Name: fbpanel New Branches: el6 Owners: splinux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805864] Review Request: glassfish-jsp-api - Glassfish J2EE JSP API specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805864 --- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2012-04-05 07:41:29 EDT --- Thanks for the review, I'll commit with the whitespace fixes as well New Package SCM Request === Package Name: glassfish-jsp-api Short Description: Glassfish J2EE JSP API specification Owners: sochotni Branches: F17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809950] Review Request: gradle - Groovy based build system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809950 --- Comment #1 from gil cattaneo punto...@libero.it 2012-04-05 07:43:01 EDT --- Spec URL: http://gil.fedorapeople.org/gradle.spec SRPM URL: http://gil.fedorapeople.org/gradle-1.0-2.fc16.src.rpm - add changelog - built apis documentation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805864] Review Request: glassfish-jsp-api - Glassfish J2EE JSP API specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805864 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226222] Merge Review: oprofile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226222 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ Last Closed|2010-07-07 23:33:04 |2012-04-05 08:04:58 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:04:58 EDT --- Fantastic, thanks for the quick response! APPROVED, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 448292] Review Request: fbpanel - a lightweight X11 desktop panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448292 --- Comment #25 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:08:40 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807113] Review Request: zanata-util - Helper scripts for using Zanata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807113 --- Comment #15 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:11:32 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805864] Review Request: glassfish-jsp-api - Glassfish J2EE JSP API specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805864 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:10:55 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635511 --- Comment #45 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:09:05 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:10:34 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 234331] Review Request: linuxdcpp - Direct Connect client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=234331 --- Comment #23 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:08:10 EDT --- This has been orphaned more than two weeks and should be re-reviewed, contact me if you need a reviewer. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Petr Šabata psab...@redhat.com changed: What|Removed |Added Blocks||809948 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809348] Review Request: darkclient - A command line tool for the darkroom service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809348 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:12:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809395] Review Request: jboss-as - JBoss Application Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809395 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:12:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755033] Review Request: openstack-quantum - Virtual network service for OpenStack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755033 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:15:42 EDT --- Git done (by process-git-requests). Removed rackerjoe, not a sponsored packager. Add later in pkgdb once this changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226222] Merge Review: oprofile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226222 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2012-04-05 08:18:15 EDT --- Wow! this review is finished. Few years back I tried to review this but failed due to lack of package maintainer response. Thanks Jon! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809530] Review Request: qt-at-spi - Qt plugin that bridges Qt's accessibility API to AT-SPI2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809530 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Jaroslav Reznik jrez...@redhat.com 2012-04-05 08:21:12 EDT --- Thanks Rex, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Petr Šabata psab...@redhat.com changed: What|Removed |Added External Bug ID||CPAN 76312 --- Comment #1 from Petr Šabata psab...@redhat.com 2012-04-05 08:22:00 EDT --- (In reply to comment #0) (...) perl-WWW-Shorten.noarch: W: file-not-utf8 /usr/share/doc/perl-WWW-Shorten-3.02/LICENCE This is about the copyright symbols in it. I guess it's Latin1. You should convert it in your spec (in your %prep section, for example). perl-WWW-Shorten.noarch: E: incorrect-fsf-address /usr/share/doc/perl-WWW-Shorte n-3.02/COPYING I have opened CPAN issue #76312 about this, but I don't consider it fatal. Indeed, this is okay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810028
--- Comment #2 from Petr Šabata psab...@redhat.com 2012-04-05 08:40:36 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
(OK)
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/contyk/src/review/810028/WWW-Shorten-3.02.tar.gz :
MD5SUM this package : 4a9be4d5c34b5726cd11a143dae0e0b8
MD5SUM upstream package : 4a9be4d5c34b5726cd11a143dae0e0b8
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[-]: SHOULD Spec use %global instead of %define.
Issues:
TODO: BuildRequire perl(base), perl(Carp)
TODO: Remove explicit perl dependency from BR
FIX: Convert the LICENCE file to utf8.
Otherwise the package is fine.
Generated by fedora-review 0.2.0git
External plugins:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 226222] Merge Review: oprofile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226222 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-04-05 09:10:34 EDT --- No problem. :) A lot of packages sort of eventually fall into compliance anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 448292] Review Request: fbpanel - a lightweight X11 desktop panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448292 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2012-04-05 08:30:26 EDT --- fbpanel-6.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fbpanel-6.1-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225255] Merge Review: arptables_jf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225255 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-04-05 09:25:02 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225622] Merge Review: boost
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225622 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #44 from Jon Ciesla limburg...@gmail.com 2012-04-05 09:25:29 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225647] Merge Review: compat-db
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225647
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||limburg...@gmail.com
AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com
Flag||fedora-review?
--- Comment #2 from Jon Ciesla limburg...@gmail.com 2012-04-05 09:55:39 EDT
---
Good:
- rpmlint checks return:
Lots of unversion-explicit provides and obsolete-not-provided which should be
fixed/dropped etc.
compat-db.spec:209: W: macro-in-comment %{_libdir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
Trivial fix.
compat-db45.x86_64: E: devel-dependency compat-db-headers
Your package has a dependency on a devel package but it's not a devel package
itself.
Fix, if possible.
compat-db45.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
Ignore, I suspect.
Lots of no-man-page-for-binary. Ignore.
Lots of rpath warning. Fix if at all possible.
- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package N/A
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r N/A
The requires situation is unorthodox, but logical given the nature of the
package.
Really looks like it's just the rpmlint stuff, let me know if you'd like me to
commit any of this.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785016] Review Request: python-quantumclient - API and CLI for Openstack Quantum
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785016 Pádraig Brady p...@draigbrady.com changed: What|Removed |Added CC||p...@draigbrady.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from Pádraig Brady p...@draigbrady.com 2012-04-05 10:07:49 EDT --- Package Change Request == Package Name: python-quantumclient New Branches: el6 Owners: rkukura pbrady To support the OpenStack Essex upgrade in EPEL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785016] Review Request: python-quantumclient - API and CLI for Openstack Quantum
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785016 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-04-05 10:12:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805864] Review Request: glassfish-jsp-api - Glassfish J2EE JSP API specification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805864 --- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2012-04-05 10:14:55 EDT --- I realized why your build failed. I am using %add_maven_depmap macro without arguments which works only in F17+ (no plans for making package for F16). I've built the package for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3965795 Keeping this open until tomcat is rebuilt in F17 and I can build this as well -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225652] Merge Review: comps-extras
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225652 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Resolution||RAWHIDE Flag|fedora-review?, needinfo? |fedora-review+ Last Closed||2012-04-05 10:13:09 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-04-05 10:13:09 EDT --- Fresh review. Good: - rpmlint checks return: comps-extras.src: W: invalid-license LGPL+ Should be LGPLv2+ - package meets naming guidelines - package meets packaging guidelines - license ( ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file I've fixed in rawhide and rebuilt, APPROVED, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760153 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2012-04-05 10:29:47 EDT --- xcb-util-wm-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-wm-0.3.8-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
--- Comment #1 from Thomas Moschny thomas.mosc...@gmx.de 2012-04-05 10:39:52
EDT ---
Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec
SRPM URL:
http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-2.fc18.src.rpm
Spec file updates:
- Drop BR on pkgconfig
- Drop BuildRoot tag
- Drop defattr lines
- Use %{_isa} in explicit dependency
- Remove chrpath, seems unnecessary
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736870] Review Request: netcdf4-python - Python/numpy interface to netCDF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736870 Mathew Topper damm_ho...@yahoo.co.uk changed: What|Removed |Added CC||damm_ho...@yahoo.co.uk --- Comment #1 from Mathew Topper damm_ho...@yahoo.co.uk 2012-04-05 10:48:41 EDT --- I think this would be a good additional inclusion to Fedora. Considering other Jeff Whitaker packages are already included (such as python-basemap) and some of the examples for that package use netcdf4-python, I'm surprised its not already available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760155 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tcall...@redhat.com AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com Flag||fedora-review+ --- Comment #2 from Tom spot Callaway tcall...@redhat.com 2012-04-05 10:57:35 EDT --- Review === - rpmlint checks return: xcb-util-image.src: W: spelling-error Summary(en_US) libxcb - Libby xcb-util-image.x86_64: W: spelling-error Summary(en_US) libxcb - Libby 4 packages and 0 specfiles checked; 0 errors, 2 warnings. All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225674] Merge Review: dasher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225674 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? --- Comment #1 from Jon Ciesla limburg...@gmail.com 2012-04-05 11:00:16 EDT --- Good: - rpmlint checks return: dasher.spec:6: W: non-standard-group Desktop/Accessibility The value of the Group tag in the package is not valid. Valid groups are: Amusements/Games, Amusements/Graphics, Applications/Archiving, Applications/Communications, Applications/Databases, Applications/Editors, Applications/Emulators, Applications/Engineering, Applications/File, Applications/Internet, Applications/Multimedia, Applications/Productivity, Applications/Publishing, Applications/System, Applications/Text, Development/Debug, Development/Debuggers, Development/Languages, Development/Libraries, Development/System, Development/Tools, Documentation, System Environment/Base, System Environment/Daemons, System Environment/Kernel, System Environment/Libraries, System Environment/Shells, Unspecified, User Interface/Desktops, User Interface/X, User Interface/X Hardware Support. Fix. Should be User Interface/Desktops dasher.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 62) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Fix. dasher.x86_64: E: incorrect-fsf-address /usr/share/doc/dasher-4.10.1/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. Ignore, but maybe file upstream. dasher.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/dasher.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. Ignore. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2 ) OK, text in %doc, matches source MUSTFIX should be GPLv2+ - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So it's just the rpmlint things. Also, 4.11 is out. Since it's all so minor I'll do it all shortly unless you object. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736870] Review Request: netcdf4-python - Python/numpy interface to netCDF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736870 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||505154(FE-SCITECH) --- Comment #2 from Orion Poplawski or...@cora.nwra.com 2012-04-05 11:09:21 EDT --- Yeah, well, just need someone to review it :) http://www.cora.nwra.com/~orion/fedora/netcdf4-python.spec http://www.cora.nwra.com/~orion/fedora/netcdf4-python-0.9.9-1.fc16.src.rpm * Thu Apr 5 2012 Orion Poplawski or...@cora.nwra.com - 0.9.9-1 - Update to 0.9.9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225622] Merge Review: boost
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225622 --- Comment #45 from Petr Machata pmach...@redhat.com 2012-04-05 11:28:50 EDT --- I uploaded the package for review here: http://people.redhat.com/~pmachata/boost-review/ note that that's simply today's master. Looking into what's in GIT will give you up to date results. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760155 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Thomas Moschny thomas.mosc...@gmx.de 2012-04-05 11:28:05 EDT --- Thanks for the review, spot! New Package SCM Request === Package Name: xcb-util-image Short Description: Port of Xlib's XImage and XShmImage functions on top of libxcb Owners: thm Branches: f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225622] Merge Review: boost
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225622 Matěj Cepl mc...@redhat.com changed: What|Removed |Added AssignedTo|pmach...@redhat.com |mc...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810059
--- Comment #3 from Jeremy Newton alexjn...@hotmail.com 2012-04-05 11:36:26
EDT ---
(In reply to comment #1)
Just some initial remarks, no references (drop a line if need be).
- As for the missing doc, file a bug upstream to add the license file.
Yeah I plan to focus on that once I get the rest working
- The examples might just go into -devel IMHO.
Hmmm, I figure I should look into building them in that case, it maybe more
convienient to have them built along with the source; I've seen some packages
work like this.
- You need to somehow use %{optflags} in the Makefile.
- Makefile contains a 'strip' command which should be removed.
- opencl-utils-debuginfo.i686: E: empty-debuginfo-package related to above.
Noted, I'll see what I can do.
- Since this a library intended to be used by other programs, the Makefile
should be patched to include a soname (a %global macro), and symlinks setup
accordingly. That patch should be acceptable upstream.
I have no idea how to do the symlink part, the soname part seems easy though. I
would think the soname part can be fixed like so:
sed -i 's/ldl/ldl -Wl,-soname,libclrun.so.0/g' src/clrun/Makefile
Although can you lend me a hand for the symlink? :)
- The description for -devel says 'source code'; shouldn't that be 'header
files'?
Not necessarily, it can be the source too, though it maynot be necessary if I
can figure out how to patch dolphin-emu to use the *.so instead of rebuilding
it.
- The debug package name opencl-utils-debuginfo is not consistent w the
others.
I just realized I need to make a opencl-utils-devel along with a CLRun-devel; I
by accident put all the files in CLRun-devel instead.
--- *spec.ORG 2012-04-05 09:16:17.211177855 +0200
+++ opencl-utils.spec 2012-04-05 09:17:25.477104941 +0200
@@ -18,6 +18,8 @@
#http://code.google.com/p/dolphin-emu/source/browse/Externals/CLRun/clrun/generateClRun.pl
Patch1: %{name}-trimwhitespace.patch
+BuildRequires: mesa-libGL-devel
+
%package -n CLRun
Summary:Dynamic loader for OpenCL
Thanks! I knew I forgot something.
(In reply to comment #2)
A second thought on naming: the %name macro is set to upstream's name
opencl-utils. However, you override it everywhere and the package is
effectively named CLrun. This does *not* match the upstream name.
I suggest that you name the packages to the default opencl-utils-*. Just live
with the fact that only clrun is packaged, making a note in the %descr about
it. If/when someone else needs more packaged it's just to fix, but without
changing the package name.
Good point, that would make more sense, thanks! :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810336] Review Request: ga - Global Arrays Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810336 David Brown david.br...@pnl.gov changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from David Brown david.br...@pnl.gov 2012-04-05 11:51:26 EDT --- Since I don't have a package already in there I'll need to get a sponsor for this one. Also, this is licensed with a Battelle License that's BSD like so it'd be nice if someone from fedora legal could look at it and check it off as being okay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] New: Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-fabulous - Makes your terminal output totally fabulous https://bugzilla.redhat.com/show_bug.cgi?id=810335 Summary: Review Request: python-fabulous - Makes your terminal output totally fabulous Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rb...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://threebean.org/rpm/python-fabulous.spec SRPM URL: http://threebean.org/rpm/python-fabulous-0.1.5-1.fc16.src.rpm Description: fabulous is a python module for producing fabulously colored terminal output. koji-f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3966149 koji-el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3966184 rpmlint output: % rpmlint SPECS/python-fabulous.spec SRPMS/python-fabulous-0.1.5-1.fc16.src.rpm RPMS/noarch/python-fabulous-0.1.5-1.fc17.noarch.rpm python-fabulous.noarch: W: no-documentation python-fabulous.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/fabulous/_xterm256.c 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810336] New: Review Request: ga - Global Arrays Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ga - Global Arrays Toolkit https://bugzilla.redhat.com/show_bug.cgi?id=810336 Summary: Review Request: ga - Global Arrays Toolkit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: david.br...@pnl.gov QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://dmlb2000.homelinux.org/packages/ga.spec SRPM URL: http://dmlb2000.homelinux.org/packages/ga-5.1-1.f18.src.rpm Description: The Global Arrays (GA) toolkit provides an efficient and portable shared-memory programming interface for distributed-memory computers. Each process in a MIMD parallel program can asynchronously access logical blocks of physically distributed dense multi- dimensional arrays, without need for explicit cooperation by other processes. Unlike other shared-memory environments, the GA model exposes to the programmer the non-uniform memory access (NUMA) characteristics of the high performance computers and acknowledges that access to a remote portion of the shared data is slower than to the local portion. The locality information for the shared data is available, and a direct access to the local portions of shared data is provided. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505154] Tracker: Review Requests for Science and Technology related packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505154 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Depends on||736870 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760155 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-04-05 12:11:52 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225674] Merge Review: dasher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225674 --- Comment #2 from Jon Ciesla limburg...@gmail.com 2012-04-05 12:10:24 EDT --- Revision, I'll do just the fixes, not 4.11, I can't get it to build on f16. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225622] Merge Review: boost
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225622
--- Comment #46 from Matěj Cepl mc...@redhat.com 2012-04-05 12:19:41 EDT ---
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ MUST: rpmlint must be run on every package. The output should be posted in
the review
mitmanek:boost $ rpmlint -i boost-1.48.0-10.fc18.src.rpm
boost.src: W: patch-not-applied Patch1: boost-cmake-soname.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.
boost.src: W: patch-not-applied Patch12: boost-1.48.0-polygon.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.
boost.src: W: no-rhel-conditional boost.spec
There is a check for fedora version but no check for version of RHEL.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
mitmanek:boost $
Packager, could you please comment on these, specifically I am a little bit
concerned about the last one (I don't care that much whether you keep some
patch in the package without applying it). Of course, if you have different
specs in different branches and you don't merge them it is OK, otherwise it may
get problematic in some future version of RHEL.
+ MUST: package named according to the Package Naming Guidelines
+ MUST: The spec file name must match the base package %{name}
+ MUST: The package must meet the Packaging Guidelines .
+ MUST: The package licensed with a Fedora approved license and meets the
Licensing Guidelines
+ MUST: The License field in the package spec file matches the actual
license
Boost and MIT and Python
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
License is included.
+ MUST: The spec file must be written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task
MD5: d1e9a7a7f532bb031a3c175d86688d95
+ MUST: The package successfully compiles and builds into binary rpms on at
least one primary architecture - built many times in koji and brew
0 MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch
+ MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines
0 MUST: The spec file handles locales properly. This is done by using the
%find_lang macro
No locales are present.
+ MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
+ MUST: Packages must NOT bundle copies of system libraries
0 MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker
+ MUST: Package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory
+ MUST: Package must not list a file more than once in the spec file's %files
listings
+ MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
+ MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
+ MUST: Each package must consistently use macros
+ MUST: The package must contain code, or permissible content
+ MUST: Large documentation files must go in a -doc subpackage
+ MUST: If a package includes something as %doc, it must not affect the runtime
of the application
+ MUST: Header files must be in a -devel package
+ MUST: Static libraries must be in a -static package
0 MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
+ MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package
+ MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built
0 MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
+ MUST: Packages must not own files or directories already owned by other
packages
+ MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810059 --- Comment #4 from Jeremy Newton alexjn...@hotmail.com 2012-04-05 12:24:44 EDT --- Here's the new files, though it's still a work in progress as I have to fix a no-ldconfig-symlink and a debuginfo-without-sources error. SPEC: http://dl.dropbox.com/u/42480493/opencl-utils.spec SRPM: http://dl.dropbox.com/u/42480493/opencl-utils-0-2.svn16.fc16.src.rpm RPMLINT OUTPUT: opencl-utils-CLRun.x86_64: E: no-ldconfig-symlink /usr/lib64/libclrun.so opencl-utils-debuginfo.x86_64: E: debuginfo-without-sources I'm going to need some insight on this on as I'm a little shaky on this, I plan to contact my sponsor if he can help. opencl-utils-CLRun.x86_64: W: no-documentation opencl-utils-CLRun-devel.x86_64: W: no-documentation opencl-utils-devel.x86_64: W: no-documentation http://code.google.com/p/opencl-utils/issues/detail?id=1 opencl-utils.src: W: invalid-url Source0: opencl-utils.tar.xz This is a SVN checkout, not an issue 5 packages and 0 specfiles checked; 2 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225795] Merge Review: ghostscript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225795 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-04-05 12:44:34 EDT --- Fresh review: Good: - rpmlint checks return: ghostscript.src: W: spelling-error Summary(en_US) renderer - tenderer, rendered, render er The value of this tag appears to be misspelled. Please double-check. ghostscript.src: W: spelling-error %description -l en_US bitmapped - bit mapped, bit-mapped, bitmap The value of this tag appears to be misspelled. Please double-check. Ignore these. ghostscript.src: W: no-version-in-last-changelog The latest changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. Trivial, fix. ghostscript.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/ghostscript/9.05/Resource/Init/Fontmap A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var. ghostscript.x86_64: W: conffile-without-noreplace-flag /usr/share/ghostscript/9.05/Resource/Init/Fontmap A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here ghostscript.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/ghostscript/9.05/Resource/Init/gs_init.ps A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var. ghostscript.x86_64: W: conffile-without-noreplace-flag /usr/share/ghostscript/9.05/Resource/Init/gs_init.ps A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here ghostscript.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/ghostscript/9.05/Resource/Init/Fontmap.GS A file not in /etc or /var is marked as being a configuration file. Please put your conf files in /etc or /var. ghostscript.x86_64: W: conffile-without-noreplace-flag /usr/share/ghostscript/9.05/Resource/Init/Fontmap.GS A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here ghostscript.x86_64: E: zero-length /etc/ghostscript/9.05/Fontmap.local ghostscript.x86_64: E: zero-length /etc/ghostscript/9.05/CIDFnmap.local ghostscript.x86_64: E: zero-length /etc/ghostscript/9.05/cidfmap.local ghostscript.x86_64: W: no-manual-page-for-binary lprsetup.sh Each executable in standard binary directories should have a man page. ghostscript.x86_64: W: no-manual-page-for-binary ps2ps2 Each executable in standard binary directories should have a man page. ghostscript.x86_64: W: no-manual-page-for-binary dumphint Each executable in standard binary directories should have a man page. ghostscript.x86_64: W: no-manual-page-for-binary pphs Each executable in standard binary directories should have a man page. ghostscript.x86_64: W: no-manual-page-for-binary unix-lpr.sh Each executable in standard binary directories should have a man page. ghostscript-cups.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghostscript-cups.x86_64: E: incorrect-fsf-address /usr/lib/cups/filter/gstopxl The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. ghostscript-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ghostscript-9.05/contrib/gdevcd8.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. ghostscript-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ghostscript-9.05/contrib/gdevlx32.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. ghostscript-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ghostscript-9.05/contrib/opvp/gdevopvp.c The Free Software Foundation address in this file seems to be outdated or
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 --- Comment #3 from Julian C. Dunn jd...@aquezada.com 2012-04-05 13:02:53 EDT --- http://jdunn.fedorapeople.org/perl-WWW-Shorten/perl-WWW-Shorten-3.02-2.fc18.src.rpm http://jdunn.fedorapeople.org/perl-WWW-Shorten/perl-WWW-Shorten.spec Fixed: - BR added for perl(base), perl(Carp), glibc-common (for iconv) - BR removed for explicit Perl version - Converted LICENCE to UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809530] Review Request: qt-at-spi - Qt plugin that bridges Qt's accessibility API to AT-SPI2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809530 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2012-04-05 13:03:05 EDT --- New Package SCM Request === Package Name: qt-at-spi Short Description: Qt plugin that bridges Qt's accessibility API to AT-SPI2 Owners: jreznik,rdieter Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809530] Review Request: qt-at-spi - Qt plugin that bridges Qt's accessibility API to AT-SPI2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809530 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-04-05 13:10:09 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Julian C. Dunn jd...@aquezada.com changed: What|Removed |Added See Also|https://bugzilla.redhat.com | |/show_bug.cgi?id=809948 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807476] Review Request:evm-utils -IMA/EVM support utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807476 --- Comment #4 from Paul Wouters pwout...@redhat.com 2012-04-05 13:40:35 EDT --- Upstream renamed the package ima-evm-utils. Upstream now publishes proper tar archives. Spec URL: ftp://ftp.nohats.ca/ima/ima-evm-utils.spec SRPM URL: ftp://ftp.nohats.ca/ima/ima-evm-utils-0.2.0-1.fc17.src.rpm $ rpmlint /home/paul/SRPMS/ima-evm-utils-0.2-1.fc17.src.rpm /home/paul/RPMS/x86_64/ima-evm-utils-0.2-1.fc17.x86_64.rpm /home/paul/RPMS/x86_64/ima-evm-utils-debuginfo-0.2-1.fc17.x86_64.rpm ima-evm-utils.src: W: spelling-error %description -l en_US runtime - run time, run-time, rudiment ima-evm-utils.src: W: spelling-error %description -l en_US executables - executable, executable s, executrices ima-evm-utils.src: W: spelling-error %description -l en_US unauthorised - unauthorized, authorized ima-evm-utils.src: W: spelling-error %description -l en_US filesystem - file system, file-system, systemically ima-evm-utils.x86_64: W: spelling-error %description -l en_US runtime - run time, run-time, rudiment ima-evm-utils.x86_64: W: spelling-error %description -l en_US executables - executable, executable s, executrices ima-evm-utils.x86_64: W: spelling-error %description -l en_US unauthorised - unauthorized, authorized ima-evm-utils.x86_64: W: spelling-error %description -l en_US filesystem - file system, file-system, systemically ima-evm-utils.x86_64: E: zero-length /usr/share/doc/ima-evm-utils-0.2/COPYING ima-evm-utils.x86_64: E: zero-length /usr/share/doc/ima-evm-utils-0.2/NEWS ima-evm-utils.x86_64: W: no-manual-page-for-binary evmctl 3 packages and 0 specfiles checked; 2 errors, 10 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225902] Merge Review: intltool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225902 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-04-05 13:41:53 EDT --- Fresh review: Good: - rpmlint checks return: intltool.spec:18: W: unversioned-explicit-obsoletes xml-i18n-tools The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. intltool.noarch: W: self-obsoletion xml-i18n-tools obsoletes xml-i18n-tools = 0.11 The package obsoletes itself. This is known to cause errors in various tools and should thus be avoided, usually by using appropriately versioned Obsoletes and/or Provides and avoiding unversioned ones Fix. intltool.src: W: spelling-error %description -l en_US bonobo - Bono, bonbon, Bonn The value of this tag appears to be misspelled. Please double-check. intltool.src: W: spelling-error %description -l en_US ui - ii, u, i The value of this tag appears to be misspelled. Please double-check. intltool.src: W: spelling-error %description -l en_US po - PO, pew, op The value of this tag appears to be misspelled. Please double-check. Ignore. intltool.noarch: E: devel-dependency gettext-devel Your package has a dependency on a devel package but it's not a devel package itself. Does this really need gettext-devel or just gettext? Should perhaps the Requires and BuildRequires for gettext and gettext-devel be reversed? If this is correct, that's fine. Several incorrect FSF address errors, not a huge issue, fix bugs upstream if you like. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2 with exceptions ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Otherwise it looks pretty good. Just the dependency questions. Let me know if you'd like me to commit anything. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225904] Merge Review: iprutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225904 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #2 from Jon Ciesla limburg...@gmail.com 2012-04-05 13:54:08 EDT --- FYI, this is ppc/ppc64 only, and so might be difficult to review for many. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810059
--- Comment #5 from Alec Leamas leamas.a...@gmail.com 2012-04-05 14:10:42 EDT
---
Referring to dolphin-emu, you can add a pkgconfig file without much effort.
First, add the opencl-utils.pc file (SourceX):
prefix=@prefix@
includedir=${prefix}/include
Name: opencl-utils
Description: OpenCL tools and utilities.
Version: @version@
Libs: -lclrun???
Cflags: -I${includedir}
Then, in %prep:
sed -i -e 's/@version@/%{version}/' -e 's/@prefix@/%{prefix}/' %SOURCEX
Add a Requires: pkgconfig to the devel package, and installthe file in
%_libdir/pkgconfig. List the file in the devel package. Done!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #35 from Fedora Update System upda...@fedoraproject.org 2012-04-05 14:24:24 EDT --- love-0.8.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800797] Review Request: ghc-vault - Persistent store for typed values
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800797 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-04-05 14:27:01 EDT --- ghc-vault-0.1.0.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809633] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809633 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-04-05 14:26:41 EDT --- perl-HTML-TreeBuilder-LibXML-0.16-2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226132] Merge Review: mcelog
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226132
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||limburg...@gmail.com
AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com
Flag||fedora-review?
--- Comment #1 from Jon Ciesla limburg...@gmail.com 2012-04-05 14:24:13 EDT
---
Good:
- rpmlint checks return:
mcelog.spec:28: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
mcelog.spec:29: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT/%{_sysconfdir}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
mcelog.spec:30: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT/%{_sbindir}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
mcelog.spec:31: W: rpm-buildroot-usage %build mkdir -p
$RPM_BUILD_ROOT/%{_mandir}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
mcelog.spec:39: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/systemd/system
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
mcelog.spec:50: E: hardcoded-library-path in
$RPM_BUILD_ROOT/lib/systemd/system/mcelog.service
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
mcelog.spec:82: E: hardcoded-library-path in /lib/systemd/system/mcelog.service
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
Fix. For /lib/systemd/system, use %{_unitdir}.
mcelog.spec: W: invalid-url Source0: mcelog-6e4e2a00.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.
Fix if there's a URL for git checkouts.
mcelog.x86_64: W: summary-ended-with-dot C Tool to translate x86-64 CPU Machine
Check Exception data.
Summary ends with a dot.
Fix.
mcelog.x86_64: W: spelling-error %description -l en_US cron - corn, con, crone
The value of this tag appears to be misspelled. Please double-check.
Ignore.
Lots of wrong fsf address, file a bug upstream.
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2 ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream N/A, git checkout
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistentSee above
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
You also need the following requires:
Requires(post): systemd-units
Requires(preun): systemd-units
Requires(postun): systemd-units
Other than the things from rpmlint and the requires, no major issues. Let me
know if you'd like me to commit anything.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808254] Review Request: twirssi - Allows you to post to Twitter from Irssi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808254 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-04-05 14:28:09 EDT --- twirssi-2.5.1-2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810059
--- Comment #6 from Alec Leamas leamas.a...@gmail.com 2012-04-05 14:31:46 EDT
---
The soname stuff. First, add a new linker flag
-Wl,-soname=libclrun.so.%{version} to the gcc link phase, which sets the
soname on the library libclrun.
Now, if you define version to 0.0.16 you should rename the resulting library to
libclrun.so.0.0.16 i. e., libclrun.so.%{version}
You will need the links lbclrun.so.0.0, libclrun.so.0 and libclrun.so, all
linked to libclrun.so.%{version}. These can be setup using following in
%install:
sofile=libclrun.so.%{version}
mkdir -p %{buildroot}%{_libdir}
install -m 755 $sofile %{buildroot}%{_libdir}
cd %{buildroot}%{_libdir}
ln -sf $sofile ${sofile%%.*}
ln -sf $sofile ${sofile%%.*.*}
ln -sf $sofile ${sofile%%.*.*.*}
The libclrun.so (*.so) link belongs to the devel package, the rest (*.so.*)
goes to base package. Standard ldconfig %post and %postun scriptlets.
There are certainly other ways to do this. In particular, there's a debate on
how to choose so-name. Since we havn't really any stable API:s here, I think
this schema makes most sense, though.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226114] Merge Review: m2crypto
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226114 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? --- Comment #1 from Jon Ciesla limburg...@gmail.com 2012-04-05 14:39:27 EDT --- Good: ! rpmlint checks return: m2crypto.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/m2crypto-0.21.1/tests/thawte.pem This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. Fix until that would break the tests. m2crypto.x86_64: E: zero-length /usr/share/doc/m2crypto-0.21.1/demo/Zope/lib/python/Products/GuardedFile/refresh.txt Ignore or remove. ! package meets naming guidelines Should really be python-m2crypto. If you submit a rename review I'll do it. Or this could be it, really. - package meets packaging guidelines ! license ( MIT ) I see BSD-style, Apache 2.0, MIT, Zope Public License, should this not reflect all of those? - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So just rpmlint, name and license, otherwise OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810374] New: Review Request: xpl4linux - An xPLHub based on xPL framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: xpl4linux - An xPLHub based on xPL framework https://bugzilla.redhat.com/show_bug.cgi?id=810374 Summary: Review Request: xpl4linux - An xPLHub based on xPL framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cedric.oliv...@free.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://cquad.dyndns.org/hg/xpl4linux/raw-file/13aecad7d3a6/SPECS/xpl4linux.spec SRPM URL: http://cquad.dyndns.org/hg/xpl4linux/raw-file/13aecad7d3a6/SRPMS/xpl4linux-1.3a-5.fc16.src.rpm Hi, I just finished packaging up xpl4linux, I would appreciate a review so that I can get it into EL6 and Fedora Extras xpl4linux is an xPL Hub based on xPL framework that hides most of the details of dealing with xPL.It will handle filtering messages, sending heartbeats, formatting and parsing messages, directing messages to handlers based on where they were bound from, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810376] New: Review Request: pypng - Python PNG encoder/decoder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pypng - Python PNG encoder/decoder https://bugzilla.redhat.com/show_bug.cgi?id=810376 Summary: Review Request: pypng - Python PNG encoder/decoder Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mat...@mattdm.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://mattdm.org/misc/fedora/pypng.spec SRPM URL: http://mattdm.org/misc/fedora/pypng-0.0.12-1.fc16.mattdm.src.rpm Description: Python PNG encoder/decoder -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Caghan Demirci cagh...@gmail.com changed: What|Removed |Added Flag|fedora-review+, needinfo? |fedora-review? --- Comment #46 from Caghan Demirci cagh...@gmail.com 2012-04-05 15:31:09 EDT --- This is the second attempt to contact the maintainer of rabbitvcs, nushio (= Juan). Please see comment 45. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810374] Review Request: xpl4linux - An xPLHub based on xPL framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810374 --- Comment #1 from Cédric OLIVIER cedric.oliv...@free.fr 2012-04-05 15:31:13 EDT --- rpmlint output : xpl4linux.x86_64: W: spelling-error Summary(en_US) xPLHub xpl4linux.x86_64: W: spelling-error Summary(en_US) xPL - x Pl, cpl, pl xpl4linux.x86_64: W: spelling-error %description -l en_US xPL - x Pl, cpl, pl xpl4linux.x86_64: W: no-manual-page-for-binary xPLSend xpl4linux.x86_64: W: no-manual-page-for-binary xPL_Clock xpl4linux.x86_64: W: no-manual-page-for-binary xPL_Logger xpl4linux.x86_64: W: no-manual-page-for-binary xPL_ConfigClock For spelling-error xpl is a protocol. For no-manual-page, I have only a man page for principal binary xPLHub. rpmlint is silent for other packages (devel, libs and debug) except same spelling-errors -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Caghan Demirci cagh...@gmail.com changed: What|Removed |Added Flag||needinfo? --- Comment #47 from Caghan Demirci cagh...@gmail.com 2012-04-05 15:34:40 EDT --- Adding needinfo flag... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557760] Merge Review: sabayon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557760 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com, ||tbza...@redhat.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? --- Comment #1 from Jon Ciesla limburg...@gmail.com 2012-04-05 15:34:59 EDT --- Good: - rpmlint checks return: sabayon.spec:98: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 98) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Trivial to fix. sabayon.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/sabayon/xlib.so xlib.so()(64bit) A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator. Fix. sabayon.x86_64: W: dangerous-command-in-%postun userdel FIX. We don't remove users, ever. https://fedoraproject.org/wiki/Packaging:UsersAndGroups sabayon-apply.x86_64: E: executable-marked-as-config-file /etc/X11/xinit/xinitrc.d/sabayon-xinitrc.sh Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. Fix. sabayon-apply.x86_64: E: script-without-shebang /etc/X11/xinit/xinitrc.d/sabayon-xinitrc.sh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. Fix. sabayon-apply.x86_64: W: no-manual-page-for-binary sabayon-apply Each executable in standard binary directories should have a man page. Fix if possible. Lots of wrong fsf address, file upstream. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So it's just what's from rpmlint, let me know if you want me to commit any fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] New: Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-txzmq - Twisted bindings for ZeroMQ https://bugzilla.redhat.com/show_bug.cgi?id=810382 Summary: Review Request: python-txzmq - Twisted bindings for ZeroMQ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rb...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://threebean.org/rpm/python-txzmq.spec SRPM URL: http://threebean.org/rpm/python-txzmq-0.3.1-1.fc16.src.rpm Description: txZMQ allows to integrate easily `ZeroMQ http://zeromq.org`_ sockets into Twisted event loop (reactor). koji-f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967084 koji-el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967086 rpmlint output: % rpmlint SPECS/python-txzmq.spec SRPMS/python-txzmq-0.3.1-1.fc16.src.rpm RPMS/noarch/python-txzmq-0.3.1-1.fc17.noarch.rpm python-txzmq.src: W: spelling-error %description -l en_US http - HTTP python-txzmq.src: W: spelling-error %description -l en_US zeromq - zero python-txzmq.noarch: W: spelling-error %description -l en_US http - HTTP python-txzmq.noarch: W: spelling-error %description -l en_US zeromq - zero -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] New: Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-txws - Twisted WebSockets wrapper https://bugzilla.redhat.com/show_bug.cgi?id=810386 Summary: Review Request: python-txws - Twisted WebSockets wrapper Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rb...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://threebean.org/rpm/python-txws.spec SRPM URL: http://threebean.org/rpm/python-txws-0.7-1.fc16.src.rpm Description: txWS (prounounced Twisted WebSockets) is a small, short, simple library for adding WebSockets server support to your favorite Twisted applications. koji-f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967101 koji-el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967103 rpmlint output: % rpmlint SPECS/python-txws.spec SRPMS/python-txws-0.7-1.fc16.src.rpm RPMS/noarch/python-txws-0.7-1.fc17.noarch.rpm SPECS/python-txws.spec:36: W: macro-in-comment %check python-txws.src: W: spelling-error %description -l en_US prounounced - pronounced, pronounce, renounced python-txws.src:36: W: macro-in-comment %check python-txws.noarch: W: spelling-error %description -l en_US prounounced - pronounced, pronounce, renounced 2 packages and 1 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809748] Review Request: xz-java - Java implementation of XZ data compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809748 Juan Hernández juan.hernan...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Juan Hernández juan.hernan...@redhat.com 2012-04-05 15:57:44 EDT --- I think everything is correct now. Thanks for fixing the issues Mikolaj! *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com Flag|fedora-review?, needinfo?, |fedora-review+, fedora-cvs? |fedora-cvs+ | --- Comment #48 from Jon Ciesla limburg...@gmail.com 2012-04-05 16:24:58 EDT --- Package Change Request == Package Name: rabbitvcs New Branches: el6 Owners: limb nushio -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #49 from Jon Ciesla limburg...@gmail.com 2012-04-05 16:27:41 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 235189] Review Request: nautilus-python - Python bindings for Nautilus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=235189 Caghan Demirci cagh...@gmail.com changed: What|Removed |Added Flag|needinfo? | --- Comment #12 from Caghan Demirci cagh...@gmail.com 2012-04-05 16:40:51 EDT --- nautilus-python will be built for EPEL within the context of bug 771262. There is nothing more to do here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225902] Merge Review: intltool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225902 --- Comment #5 from Matthias Clasen mcla...@redhat.com 2012-04-05 18:08:24 EDT --- (In reply to comment #4) Otherwise it looks pretty good. Just the dependency questions. Let me know if you'd like me to commit anything. By all means, if you want to change that to your liking, go ahead and commit. Thanks ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760155 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760155] Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760155 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-04-05 18:25:12 EDT --- xcb-util-image-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-image-0.3.8-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #20 from Sergio Monteiro Basto ser...@serjux.com 2012-04-05 21:25:10 EDT --- Package Change Request == Package Name: smb4k Branches: f15 Owners: sergiomb InitialCC: KDE New Branches: f16 f17 According https://admin.fedoraproject.org/pkgdb/acls/name/smb4k is orphan since Fedora 15 As I read on https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages, For unretirement of branches, please simply state which branches should be unretired (and raise the fedora-cvs flag as usual) I want unretirement of a package on f15 branch and add branches f16 and f17 . but I don't have permission to raise fedora-cvs flag ! The Package Name field is mandatory. Please only include other fields which need to be changed or updated. In the Owners field list the branch owner and any comaintainers. Well, Rex Dieter, you are welcome as comaintainers or owner, just don't know what is your fas account . Please note that when the new branch is created, ownership or CC information will not be copied to the new branch, so be sure to specify in the request all of the owners and initialCC members the new branch should have. how I do that ? I arrive here : https://fedoraproject.org/wiki/SIGs/KDE/Packaging/Requests so InitialCC may be KDE ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Blocks||656997(kde-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag||fedora-cvs? --- Comment #22 from Rex Dieter rdie...@math.unl.edu 2012-04-05 21:49:57 EDT --- Package Change Request == Package Name: smb4k Branches: f15 Owners: sergiomb InitialCC: New Branches: f16 f17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #21 from Rex Dieter rdie...@math.unl.edu 2012-04-05 21:48:57 EDT --- Don't worry about me, I'll probably add myself afterward. I would recommend leaving InitialCC: blank, the KDE entry there isn't valid (though it probably would be nice if we created some kde-sig meta-user and/or group someday). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] New: Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: geome - Obtain your geolocation data from Google using NetworkManager https://bugzilla.redhat.com/show_bug.cgi?id=810417 Summary: Review Request: geome - Obtain your geolocation data from Google using NetworkManager Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pwout...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: https://nohats.ca/geome/geome.spec SRPM URL: https://nohats.ca/geome/geome-1.0-1.fc16.src.rpm Description: geome queries NetworkManager for its wifi information, such as ESSID's and signal strength, and sends it to Google Location to obtain your geographic location. It can return all of the information Google returns, or with the -s flag, only return the latitude/longitude. This last mode is used by the Pidgin OTR nearby friends plugin. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810059] opencl-utils - Useful OpenCL tools and utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810059 --- Comment #7 from Jeremy Newton alexjn...@hotmail.com 2012-04-05 23:18:25 EDT --- Awesome! Thanks for your help :) New files SPEC: http://dl.dropbox.com/u/42480493/opencl-utils.spec SRPM: http://dl.dropbox.com/u/42480493/opencl-utils-0-3.svn16.fc16.src.rpm I just have to work out the debuginfo-without-sources issue -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797330] Review request: xsensors - An X11 interface to lm_sensors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797330 --- Comment #7 from Jeremy Newton alexjn...@hotmail.com 2012-04-06 01:05:00 EDT --- (In reply to comment #6) If this is only the debian project that keeps this project for a long time, it might well be asking them to formally regain control of xsensors. Packaging a death project is for me a problem. Usually every patch must be submitted to upstream. For me if debian isn't upstream for this project, they can't change copying file. Licence choice is made by upstream and nobody can alter its content, even to update a link. Apologies for the delay. Due to inactivity upstream, I've decided to maintain it myself as some sort of fork for personal interest. I don't see a reason why this would be a problem as the project is GPL and I didn't do anything that violates such (or at least not on purpose), but please let me know if there is so I can fix it. I updated the addresses but the licenses are intact. Anyway, I've also updated the files to reflect this new upstream SPEC: http://dl.dropbox.com/u/42480493/xsensors.spec SRPM: http://dl.dropbox.com/u/42480493/xsensors-0.71-1.fc16.src.rpm Only the spelling RPMLINT warnings are left. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797330] Review request: xsensors - An X11 interface to lm_sensors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797330 Jeremy Newton alexjn...@hotmail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797330] Review request: xsensors - An X11 interface to lm_sensors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797330 --- Comment #8 from Jeremy Newton alexjn...@hotmail.com 2012-04-06 01:07:54 EDT --- Also I have been recently sponsored :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
