[Bug 809348] Review Request: darkclient - A command line tool for the darkroom service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809348 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809348] Review Request: darkclient - A command line tool for the darkroom service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809348 --- Comment #10 from Fedora Update System 2012-04-11 02:18:15 EDT --- darkclient-0.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/darkclient-0.1-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808336] Review Request: dia-gnomeDIAicons - Beautiful icon set for dia diagram editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808336 --- Comment #19 from Arthur Buliva 2012-04-11 00:34:16 EDT --- fedora-cvs flag raised to ? successfully -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808336] Review Request: dia-gnomeDIAicons - Beautiful icon set for dia diagram editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808336 Arthur Buliva changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807113] Review Request: zanata-util - Helper scripts for using Zanata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807113 Ding-Yi Chen changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=730237 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806641] Review Request: perl-Test-TinyMocker - A very simple tool to mock external modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806641 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Test-TinyMocker-0.03-2 ||.fc16 Resolution||ERRATA Last Closed||2012-04-10 23:57:32 --- Comment #10 from Fedora Update System 2012-04-10 23:57:32 EDT --- perl-Test-TinyMocker-0.03-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806643] Review Request: perl-End - Generalized END blocks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806643 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-End-2009110401-1.fc15 Resolution||ERRATA Last Closed||2012-04-10 23:58:41 --- Comment #8 from Fedora Update System 2012-04-10 23:58:41 EDT --- perl-End-2009110401-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||trac-agilo-plugin-0.9.7-2.f ||c16 Resolution||ERRATA Last Closed||2012-04-11 00:00:45 Bug 786213 depends on bug 786093, which changed state. Bug 786093 Summary: Review Request: python-windmill - A web application testing framework https://bugzilla.redhat.com/show_bug.cgi?id=786093 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Fedora Update System 2012-04-11 00:00:45 EDT --- trac-agilo-plugin-0.9.7-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804625] Review Request: perl-MooseX-Has-Options - Succinct options for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804625 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-MooseX-Has-Options-0.0 |perl-MooseX-Has-Options-0.0 |02-1.fc16 |02-1.fc15 --- Comment #10 from Fedora Update System 2012-04-10 23:59:11 EDT --- perl-MooseX-Has-Options-0.002-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806654] Review Request: perl-IPC-Filter - Filter data through an external process
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806654 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-IPC-Filter-0.004-1.fc1 |perl-IPC-Filter-0.004-1.fc1 |5 |6 --- Comment #9 from Fedora Update System 2012-04-10 23:59:02 EDT --- perl-IPC-Filter-0.004-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713313 Fedora Update System changed: What|Removed |Added Fixed In Version|msktutil-0.4.1-1.fc16 |msktutil-0.4.1-1.fc15 --- Comment #51 from Fedora Update System 2012-04-10 23:58:51 EDT --- msktutil-0.4.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806654] Review Request: perl-IPC-Filter - Filter data through an external process
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806654 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-IPC-Filter-0.004-1.fc1 ||5 Resolution||ERRATA Last Closed||2012-04-10 23:56:52 --- Comment #8 from Fedora Update System 2012-04-10 23:56:52 EDT --- perl-IPC-Filter-0.004-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806646] Review Request: perl-Data-Pond - Perl-based open notation for data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806646 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Data-Pond-0.004-2.fc15 Resolution||ERRATA Last Closed||2012-04-10 23:52:54 --- Comment #11 from Fedora Update System 2012-04-10 23:52:54 EDT --- perl-Data-Pond-0.004-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808518] Review Request: perl-Time-OlsonTZ-Download - Olson timezone database from source
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808518 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Time-OlsonTZ-Download- |perl-Time-OlsonTZ-Download- |0.003-1.fc15|0.003-1.fc16 --- Comment #10 from Fedora Update System 2012-04-10 23:54:13 EDT --- perl-Time-OlsonTZ-Download-0.003-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804625] Review Request: perl-MooseX-Has-Options - Succinct options for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804625 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-MooseX-Has-Options-0.0 ||02-1.fc16 Resolution||ERRATA Last Closed||2012-04-10 23:51:58 --- Comment #9 from Fedora Update System 2012-04-10 23:51:58 EDT --- perl-MooseX-Has-Options-0.002-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713313 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||msktutil-0.4.1-1.fc16 Resolution||ERRATA Last Closed|2011-12-27 17:55:38 |2012-04-10 23:55:10 --- Comment #50 from Fedora Update System 2012-04-10 23:55:10 EDT --- msktutil-0.4.1-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801092] Review Request: sumwars - a hack and slash role playing game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801092 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sumwars-0.5.6-5.fc16 Resolution||ERRATA Last Closed||2012-04-10 23:56:38 --- Comment #22 from Fedora Update System 2012-04-10 23:56:38 EDT --- sumwars-0.5.6-5.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808518] Review Request: perl-Time-OlsonTZ-Download - Olson timezone database from source
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808518 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Time-OlsonTZ-Download- ||0.003-1.fc15 Resolution||ERRATA Last Closed||2012-04-10 23:51:24 --- Comment #9 from Fedora Update System 2012-04-10 23:51:24 EDT --- perl-Time-OlsonTZ-Download-0.003-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750394] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750394 --- Comment #26 from Kapil Arya 2012-04-10 21:51:01 EDT --- Hi All, We were finally able to resolve the issues with fPIC and missing symbols. Here are the links to the latest SPEC and SRPM: Spec URL: http://www.ccs.neu.edu/home/kapil/fedora_rpms/dmtcp.spec SRPM URL: http://www.ccs.neu.edu/home/kapil/fedora_rpms/dmtcp-1.2.4-1.svn1608.fc16.src.rpm Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811418] New: Review Request: rubygem-hydra - distributes tests for speed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-hydra - distributes tests for speed https://bugzilla.redhat.com/show_bug.cgi?id=811418 Summary: Review Request: rubygem-hydra - distributes tests for speed Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mhi...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra.spec SRPM URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra-0.24.0-1.fc16.src.rpm Description: Note - this is my first package and I will need it sponsored. Hydra is a distributed testing framework. It allows you to distribute your tests locally across multiple cores and processors, as well as run your tests remotely over SSH. Hydra’s goals are to make distributed testing easy. So as long as you can ssh into a computer and run the tests, you can automate the distribution with Hydra. $ rpmlint -v ~/rpmbuild/SPECS/rubygem-hydra.spec /home/mhicks/rpmbuild/SPECS/rubygem-hydra.spec: I: checking-url http://rubygems.org/gems/hydra-0.24.0.gem (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v /var/lib/mock/fedora-17-i386/result/rubygem-hydra-0.24.0-1.fc17.noarch.rpm rubygem-hydra.noarch: I: checking rubygem-hydra.noarch: I: checking-url http://github.com/ngauthier/hydra (timeout 10 seconds) rubygem-hydra.noarch: W: hidden-file-or-dir /usr/share/gems/gems/hydra-0.24.0/.document 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811418] Review Request: rubygem-hydra - distributes tests for speed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811418 Matt Hicks changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806665] Review Request: mosh - Mobile shell that supports roaming and intelligent local echo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806665 Alex Chernyakhovsky changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806665] Review Request: mosh - Mobile shell that supports roaming and intelligent local echo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806665 --- Comment #13 from Alex Chernyakhovsky 2012-04-10 20:59:22 EDT --- Package Change Request == Package Name: mosh New Branches: el6 Owners: achernya InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651591] Review Request: partiwm - partitioning window manager and related tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651591 --- Comment #29 from Joel 2012-04-10 20:19:42 EDT --- Martin, will you be doing resubmitting this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787364] Review Request: clipgrab - Streaming videos plate-forms grabber
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787364 --- Comment #10 from Jeremy Newton 2012-04-10 20:13:03 EDT --- On second thought, the distributing rights of the artwork are not technically "free" therefore it cannot be included in Fedora unless forked or patched with new artwork. Even if this was accepted into RPMFusion as is, it would still need to be included in non-free as it has non-commercial distributed artwork. You could ask permission from the author but I would doubt he would give free use to the artwork. As for the codec issue, I can't confirm that it uses a MPEG codec, but I know it endorses the use of MPEG and WMV which are not accepted codecs in Fedora due to legal reasons. Though it has OGG support, the other codec support in Clipgrab may cause legal issues. I would need to ask someone who is more knowledgeable on the legal know how of these software patents to know if this is a legal blocking issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651591] Review Request: partiwm - partitioning window manager and related tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651591 --- Comment #28 from Ben Boeckel 2012-04-10 19:46:34 EDT --- Open up a new RR bug (the name and summary are wrong for this bug and it'd be better if whoever will be the maintainer is the one who opened the bug). I can review it (I'm sure I'll have something to trade). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570862] Review Request: drupal6-securepages - Redirect the required pages to a SSL version of the page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570862 Orion Poplawski changed: What|Removed |Added Status Whiteboard||Stalled --- Comment #9 from Orion Poplawski 2012-04-10 18:33:01 EDT --- Hmm, well if the drupal 7 version ever gets released (see http://drupal.org/project/securepages) I'll probably update this to that. Not sure if it is better to just close this one in the meantime though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #37 from Volker Fröhlich 2012-04-10 18:17:49 EDT --- The problem seems to be in the pkgconfig file of new libgee. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #36 from Volker Fröhlich 2012-04-10 18:02:18 EDT --- Larry, I just saw, you haven't entered your builds into Bodhi yet. I also noticed there are no working builds for F17 and 18. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570862] Review Request: drupal6-securepages - Redirect the required pages to a SSL version of the page
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570862 --- Comment #8 from Volker Fröhlich 2012-04-10 17:57:42 EDT --- Orion, is this review still necessary? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787364] Review Request: clipgrab - Streaming videos plate-forms grabber
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787364 --- Comment #9 from Volker Fröhlich 2012-04-10 17:56:18 EDT --- Jeremy, if you're sure about the legal situation, we could close this ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756465] Review Request: usbsoftrock - Command line utility for interfacing with Si570 based SDR kits
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756465 --- Comment #2 from Volker Fröhlich 2012-04-10 17:54:20 EDT --- Are you still interested in this package, Lucian? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771137] Review Request: decibel-audio-player - straightforward music player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771137 --- Comment #4 from Volker Fröhlich 2012-04-10 17:52:29 EDT --- Any news, Lukáš? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693158] Review Request: python-viper - A minimalistic scientific plotter and run-time visualization module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693158 --- Comment #4 from Volker Fröhlich 2012-04-10 17:49:01 EDT --- Any news, Fabian? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757314] Review Request: ipgrab - A verbose packet sniffer for hosts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757314 --- Comment #2 from Volker Fröhlich 2012-04-10 17:51:36 EDT --- How's it going here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756443] Review Request: python-cagraph - A PyGTK widget for plotting charts and graphs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756443
--- Comment #6 from Volker Fröhlich 2012-04-10 17:47:32 EDT
---
Notice, you need a sponsor.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[-]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[-]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
This comment was created by a script. As far as I know, defattr was only
necessary in EPEL 4, but somebody might prove me wrong. I don't mind it -- it
doesn't hurt.
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[-]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[-]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
rpmlint python-cagraph-1.2-9.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint python-cagraph-1.2-9.fc18.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/media/speicher1/makerpm/756443/cagraph-1.2.tar.gz :
MD5SUM this package : 4b0e024cfb4b94d80a57128d1cae82fc
MD5SUM upstream package : 4b0e024cfb4b94d80a57128d1cae82fc
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[!]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
Please contact the developer on the shebangs. While at it, he should also
complete the information in PKG-INFO.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch0: python-cagraph-fsf_address_fix.patch (python-cagraph-
fsf_address_fix.patch)
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contai
[Bug 755498] Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755498 --- Comment #2 from Volker Fröhlich 2012-04-10 17:50:27 EDT --- Any news, Minh? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722713] Review Request: pyace - Optimal route search in a complete graph
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722713 --- Comment #19 from Volker Fröhlich 2012-04-10 17:01:19 EDT --- Any news here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720818] Review Request: python-tw2-core - Web widget creation toolkit based on TurboGears widgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720818 Marcelo Moreira de Mello changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mme...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #40 from Fedora Update System 2012-04-10 16:18:00 EDT --- Package smb4k-1.0.1-5.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing smb4k-1.0.1-5.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-5587/smb4k-1.0.1-5.fc17 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2012-04-10 16:18:27 EDT --- perl-WWW-Shorten-3.03-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System 2012-04-10 16:17:02 EDT --- ghc-resourcet-0.3.2-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787972] Review Request: ghc-dotgen - Simple interface to build .dot graph files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787972 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2012-04-10 16:14:01 EDT --- Package ghc-dotgen-0.4.1-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-dotgen-0.4.1-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-5557/ghc-dotgen-0.4.1-1.fc17 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787977] Review Request: ghc-data-reify - converts recursive data structures into graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787977 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2012-04-10 16:13:52 EDT --- ghc-data-reify-0.6-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System 2012-04-10 16:15:32 EDT --- perl-NetPacket-SpanningTree-0.01-5.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809530] Review Request: qt-at-spi - Qt plugin that bridges Qt's accessibility API to AT-SPI2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809530 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System 2012-04-10 16:15:14 EDT --- qt-at-spi-0.2-2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720818] Review Request: python-tw2-core - Web widget creation toolkit based on TurboGears widgets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720818
--- Comment #3 from Ralph Bean 2012-04-10 15:42:51 EDT ---
Just updated the spec again for an upstream release of tw2.core.
Also added the %{?dist} macro to the Release attribute.
Spec URL: http://threebean.org/rpm/python-tw2-core.spec
SRPM URL: http://threebean.org/rpm/python-tw2-core-2.0.2-1.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720818] Review Request: python-tw2-core - Web widget creation toolkit based on TurboGears widgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720818 --- Comment #4 from Ralph Bean 2012-04-10 15:46:30 EDT --- Whoops. I mis-pasted the link to the SRPM. Spec URL: http://threebean.org/rpm/python-tw2-core.spec SRPM URL: http://threebean.org/rpm/python-tw2-core-2.0.2-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720818] Review Request: python-tw2-core - Web widget creation toolkit based on TurboGears widgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720818 Ralph Bean changed: What|Removed |Added Summary|Review Request: python-tw2 |Review Request: |- Web widget creation |python-tw2-core - Web |toolkit based on TurboGears |widget creation toolkit |widgets |based on TurboGears widgets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809540] Review Request: eclipselink - Eclipse Persistence Services Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809540 --- Comment #1 from gil cattaneo 2012-04-10 15:20:26 EDT --- (In reply to comment #0) > Spec URL: http://gil.fedorapeople.org/eclipselink.spec > SRPM URL: http://gil.fedorapeople.org/eclipselink-2.3.2-1.fc16.src.rpm > Description: Eclipse Persistence Services Project, more commonly known as > EclipseLink, > is a Java comprehensive persistence framework delivering a set of persistence > services based around standards. This lets you rapidly build applications > that combine the best aspects of object technology and the specific data > source. > . > EclipseLink was started by a donation of the full source code and > test suites of Oracle's TopLink product. > . > EclipseLink's services currently include object-relational with JPA, > object-XML binding in MOXy (with support for JAXB), a Service Data Objects > (SDO) implementation and support for another technologies like: Database Web > Services (DWS), XML-Relational (XRM) and Non-Relational (EIS via JCA). > > depend on > > https://bugzilla.redhat.com/show_bug.cgi?id=809536 https://bugzilla.redhat.com/show_bug.cgi?id=809532 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 --- Comment #3 from gil cattaneo 2012-04-10 15:07:34 EDT --- builds correctly http://koji.fedoraproject.org/koji/taskinfo?taskID=3977524 http://koji.fedoraproject.org/koji/taskinfo?taskID=3977523 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806670] Review Request: jcifs - Common Internet File System Client in 100% Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806670 --- Comment #5 from gil cattaneo 2012-04-10 15:06:55 EDT --- (In reply to comment #4) > builds correctly http://koji.fedoraproject.org/koji/taskinfo?taskID=3977473 http://koji.fedoraproject.org/koji/taskinfo?taskID=3977474 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 --- Comment #2 from gil cattaneo 2012-04-10 15:00:24 EDT --- Spec URL: http://gil.fedorapeople.org/bouncycastle-pg.spec SRPM URL: http://gil.fedorapeople.org/bouncycastle-pg-1.46-2.fc16.src.rpm add BuildRequires: zip -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810928] Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810928 --- Comment #3 from Kevin Fenzi 2012-04-10 14:49:48 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. There seem to be two bundled projects in addons: geshi - http://qbnz.com/highlighter/ (already packaged as php-geshi) jquery - under review at https://bugzilla.redhat.com/show_bug.cgi?id=805587 Should require those and fix it work with them. 2. Probibly shouldn't Requires mysql-server. It's very likely that someone could have their database on a remote machine and just install this on a frontend. 3. rpmlint says: sticky-notes.src: W: invalid-url Source0: sticky-notes-20120407git.tar Can be ignored. 4. Non package blockers, but suggestions for upstream: - Add possiblity to use captchas on configurable kinds of pastes. - Add possiblity to blacklist some words in pastes to block spam (Viagra, etc) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806670] Review Request: jcifs - Common Internet File System Client in 100% Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806670 --- Comment #4 from gil cattaneo 2012-04-10 14:47:48 EDT --- builds correctly http://koji.fedoraproject.org/koji/taskinfo?taskID=3977473 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798738] Review request: mysqlenum - is an automatic blind SQL injection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798738 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235(FE-Legal)| --- Comment #24 from Tom "spot" Callaway 2012-04-10 14:44:51 EDT --- That license is actually ASL 1.0, which is Free but GPL-incompatible. Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809950] Review Request: gradle - Groovy based build system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809950 --- Comment #2 from gil cattaneo 2012-04-10 14:38:45 EDT --- depend on https://bugzilla.redhat.com/show_bug.cgi?id=806680 https://bugzilla.redhat.com/show_bug.cgi?id=806670 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810928] Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810928 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@scrye.com Flag||fedora-review? --- Comment #2 from Kevin Fenzi 2012-04-10 14:28:37 EDT --- I'll review this. Look for a full review in a bit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810676] Review Request: aws - Ada Web Server (Web framework for Ada)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810676 --- Comment #3 from Pavel Zhukov 2012-04-10 14:13:35 EDT --- https://koji.fedoraproject.org/koji/taskinfo?taskID=3977389 Spec URL: http://landgraf.fedorapeople.org/packages/requested/aws/aws.spec(In reply to comment #2) > · The license differs between the main package and the -devel subpackage. Is > that really true? If not, please remove the license field from the subpackage. > > · The -devel subpackage lacks a dependency on fedora-gnat-project-common. > > · The version field says 2.10.0 but in the changelog it says 2.8.0. > > · I think the URL field should point to a page that describes AWS, that is > http://libre.adacore.com/libre/tools/AWS/ instead of Adacore's front page. fixed all > · According to the copyright notices in aws.gpr and template_parser.gpr those > files were written by Adacore. Is that true? If so, why are they in > aws-fedora.tgz and not in aws-gpl-2.10.0-src.tgz? No. This files as well as makefile and other ones in aws-fedora.tgz have been changed (or even rewritten) by Ludovic Brenta for Debian and me for Fedora because AdaCpre prefers static libs instead dynamic. Do I have to change Copyrights for this files? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811330] New: Review Request: pcsc-cyberjack - driver for ReinerSCT cyberJack chipcart readers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pcsc-cyberjack - driver for ReinerSCT cyberJack chipcart readers https://bugzilla.redhat.com/show_bug.cgi?id=811330 Summary: Review Request: pcsc-cyberjack - driver for ReinerSCT cyberJack chipcart readers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: p...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://pcfe.net/pcsc-cyberjack-3.99.5final.SP03/pcsc-cyberjack.spec SRPM URL: http://pcfe.net/pcsc-cyberjack-3.99.5final.SP03/pcsc-cyberjack-3.99.5final.SP03-5.fc16.src.rpm Description: This is the current driver for ReinerSCT chipcard readers the vendor switched from ctapi to pcsc (dropping ctapi support completely as far as I can tell) and this causes some confusion, I think I got everything right but this package definitely needs more eyeballs. Until fox is in Fedora (and I'm not sure the license exceptions will make this possible), the package needs building 'withGUI 0'. AFAICT the GUI components are just a nice to have but not a functional requirement. I only use my reader very sparingly, in bug 767657 another user reported partial success. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810926] Review Request: rubygem-qpid - Ruby bindings for the Qpid messaging framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810926 --- Comment #2 from Darryl L. Pierce 2012-04-10 13:44:59 EDT --- (In reply to comment #1) > Hi Darryl, > > Are you aware of ruby-qpid? What is the relation between your gem and this > package? Shouldn't this gem obsolete the ruby-qpid? > > BTW it seems that this gem is not available on RubyGems.org nor in the listed > source URL. This is at least a bit unusual. The old ruby-qpid package is based on the old pure Ruby Qpid and is obsolete. This new package is based on the current, Swig-based bindings and is how we're providing the language bindings in future releases. The gem isn't available on rubygems.org ATM: I haven't explored how to make it available there yet. I will be making it available there at some point in future, actually will look into that right now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758734] Review Request: fatrat-subtitlesearch - FatRat plugin enabling OpenSubtitles.org and Sublight.si integration
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=758734
--- Comment #8 from Volker Fröhlich 2012-04-10 13:14:22 EDT
---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: The package did not built BR could therefore not be checked or the
package failed to build because of missing BR
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
I guess you added the epoch when you changed the release style to
pre-release. Since no actual package was published yet, we can and should step
back from that and just drop the epoch.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.
This package owns %{_datadir}/fatrat/lang, owned by fatrat
[ ]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/makerpm/758734/fatrat-subtitlesearch-1.2.0_beta1.tar.gz :
MD5SUM this package : ad8a24060826bcde1d85581e6844ea29
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
[!]: MUST Spec file is legible and written in American English.
Please make it: "FatRat is a download manager" and "built"
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[!]: SHOULD Package functions as described.
After starting fatrat-1.2.0-0.3.beta1.fc16.x86_64 , I see ...
"2012-04-10 18:57:17 - Loaded a plugin: libfatrat-subtitlesearch.so
2012-04-10 18:57:17 - WARNING: the plugin is incompatible:
libfatrat-subtitlesearch.so"
... on the log tab.
[x]: SHOULD Package does not include license text files separate from
upstream.
[!]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
Please inform the developer, that we want to be able to use a system-wide
qtsoap. They could either un-bundle it or change their build system to allow
for it without patching.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch100: fatrat-subtitlesearch-qtsoap.patch (fatrat-
subtitlesea
[Bug 806669] Review Request: janino - An embedded Java compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806669 --- Comment #5 from gil cattaneo 2012-04-10 13:10:22 EDT --- Spec URL: http://gil.fedorapeople.org/janino.spec SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-3.fc16.src.rpm removed janino-parent commons-compiler modules. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #9 from Fedora Update System 2012-04-10 12:57:08 EDT --- python-txzmq-0.3.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txzmq-0.3.1-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #8 from Fedora Update System 2012-04-10 12:44:24 EDT --- python-txzmq-0.3.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-txzmq-0.3.1-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 Paul Wouters changed: What|Removed |Added Status|MODIFIED|ON_QA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811286] New: Review Request: -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: - https://bugzilla.redhat.com/show_bug.cgi?id=811286 Summary: Review Request: - Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: whe...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Fedora 16: Spec URL: http://jknife.fedorapeople.org/F16/SPECS/rubygem-rhc-rest.spec SRPM URL: http://jknife.fedorapeople.org/F16/SRPMS/rubygem-rhc-rest-0.0.7-1.fc16.src.rpm Fedora 17: Spec URL: http://jknife.fedorapeople.org/F17/SPECS/rubygem-rhc-rest.spec SRPM URL: http://jknife.fedorapeople.org/F17/SRPMS/rubygem-rhc-rest-0.0.7-1.fc17.src.rpm Description: Ruby bindings for OpenShift REST API -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811286] Review Request: rubygem-rhc-rest - Ruby bindings for OpenShift REST API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811286 Wesley Hearn changed: What|Removed |Added Summary|Review Request: -|bindings for OpenShift REST ||API -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 --- Comment #15 from Fedora Update System 2012-04-10 11:49:57 EDT --- geome-1.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/geome-1.1-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787713] Review request: FreeSOLID - A 3D collision detection C++ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787713 --- Comment #25 from MartinKG 2012-04-10 11:28:13 EDT --- Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/speed-dreams/rc2_r4687.21/speed-dreams.spec?a=fqTzUFodk4Y SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/speed-dreams/rc2_r4687.21/speed-dreams-2.0.0-0.1.rc2_r4687.21.fc16.src.rpm?a=WGv8MVL1YIE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811239] Review Request: perl-Data-Dumper - Stringify perl data structures, suitable for printing and eval
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811239 --- Comment #1 from Petr Pisar 2012-04-10 11:25:11 EDT --- The Data::Dumper module has been sub-packaged in perl-5.14.2-213.fc18. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #9 from Fedora Update System 2012-04-10 11:13:40 EDT --- python-txws-0.7-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txws-0.7-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #7 from Fedora Update System 2012-04-10 11:09:46 EDT --- python-txws-0.7-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txws-0.7-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 --- Comment #14 from Fedora Update System 2012-04-10 10:59:58 EDT --- geome-1.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/geome-1.1-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 --- Comment #13 from Fedora Update System 2012-04-10 10:59:17 EDT --- geome-1.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/geome-1.1-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #8 from Fedora Update System 2012-04-10 10:52:47 EDT --- python-txws-0.7-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-txws-0.7-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806669] Review Request: janino - An embedded Java compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806669 --- Comment #4 from Mary Ellen Foster 2012-04-10 10:39:24 EDT --- commons-compiler and janino-parent are both now packaged for F17+, so you should probably modify this spec to only build the actual "janino" part. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809747] Review Request: glassfish-jsp - Glassfish J2EE JSP API implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809747
--- Comment #2 from Krzysztof Daniel 2012-04-10 10:23:18
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
glassfish-jsp.spec:37: W: unversioned-explicit-provides jsp%{jspspec}
glassfish-jsp.spec:27: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab:
line 5)
glassfish-jsp.spec: W: invalid-url Source0: javax.servlet.jsp-2.2.3.tar.xz
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[?] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: CDDL and GPLv2 with exceptions
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[?] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:
MD5SUM upstream package:
[?] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[?] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[!] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[?] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[x] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[?] Reviewer should test that the package builds in mock.
Tested on:
=== Issues ===
1. glassfish-jsp.spec:37: W: unversioned-explicit-provides jsp%{jspspec}
2. glassfish-jsp.spec:27: W: mixed-use-of-spaces-and-tabs (spaces: line 27,
tab: line 5)
3. package does not have BuildRequires/Requires on jpackage-utils.
4. I have not found add_maven_depmap in pom
I will check the rest when the package will have all prerequisities built.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772608] Review Request: ovirt-guest-agent - oVirt Guest Agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772608 --- Comment #23 from Gal Hammer 2012-04-10 10:22:12 EDT --- New version: Spec URL: http://ghammer.fedorapeople.org/ovirt-guest-agent.spec SRPM URL: http://ghammer.fedorapeople.org/ovirt-guest-agent-1.0.3-1.fc16.src.rpm - package was renamed to rhevm-guest-agent in RHEL distribution. - fixed gdm-plugin build requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805037] Review Request: commons-compiler - Interfaces for an embedded Java compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805037 --- Comment #8 from Jon Ciesla 2012-04-10 10:19:02 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 Ralph Bean changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #7 from Jon Ciesla 2012-04-10 10:21:40 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #6 from Jon Ciesla 2012-04-10 10:21:16 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 Ralph Bean changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #6 from Ralph Bean 2012-04-10 10:17:08 EDT --- New Package SCM Request === Package Name: python-txws Short Description: Twisted WebSockets wrapper Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #5 from Ralph Bean 2012-04-10 10:16:44 EDT --- New Package SCM Request === Package Name: python-txzmq Short Description: Twisted bindings for ZeroMQ Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608509] Review Request: python-subvertpy - Python bindings for Subversion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608509 --- Comment #14 from Jason Tibbitts 2012-04-10 10:15:59 EDT --- Hmm, honestly I didn't notice the updates that came nearly five months after my initial review. Let me take a look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809747] Review Request: glassfish-jsp - Glassfish J2EE JSP API implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809747 Krzysztof Daniel changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|kdan...@redhat.com Flag||fedora-review? --- Comment #1 from Krzysztof Daniel 2012-04-10 10:07:26 EDT --- I will take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811239] New: Review Request: perl-Data-Dumper - Stringify perl data structures, suitable for printing and eval
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Data-Dumper - Stringify perl data structures, suitable for printing and eval https://bugzilla.redhat.com/show_bug.cgi?id=811239 Summary: Review Request: perl-Data-Dumper - Stringify perl data structures, suitable for printing and eval Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ppi...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://ppisar.fedorapeople.org/perl-Data-Dumper/perl-Data-Dumper.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Data-Dumper/perl-Data-Dumper-2.131-1.fc18.src.rpm Description: Given a list of scalars or reference variables, writes out their contents in perl syntax. The references can also be objects. The content of each variable is output in a single Perl statement. Handles self-referential structures correctly. - This package can go under review after sub-packaging perl-Data-Dumper in perl SPEC file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805037] Review Request: commons-compiler - Interfaces for an embedded Java compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805037 Mary Ellen Foster changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Mary Ellen Foster 2012-04-10 09:59:18 EDT --- (Oops, this slipped through -- sorry!) New Package SCM Request === Package Name: commons-compiler Short Description: Interfaces for an embedded Java compiler Owners:mef Branches: f17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 Haïkel Guémar changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Haïkel Guémar 2012-04-10 09:56:00 EDT --- All valid points above remain ok, and requested changes were done. Since this package respects Fedora general and python specific guidelines, i hereby approve it into Fedora Packages Collection. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642773] Review Request: iguanaIR - Driver for Iguanaworks USB IR transceiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642773 Alec Leamas changed: What|Removed |Added CC||leamas.a...@gmail.com --- Comment #9 from Alec Leamas 2012-04-10 09:48:35 EDT --- Somewhat unhappy about rebuilding this package for each release, but otherwise very happy with it... is there any help I can provide to push things forward? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784594] Review Request: spin - A transparent threading solution for non-freezing Swing applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784594 --- Comment #5 from Mary Ellen Foster 2012-04-10 09:43:49 EDT --- Updated: - Remove pre-built jar files before building - Don't clean buildroot before compiling - Include most recent version of the LGPL Spec URL: http://mef.fedorapeople.org/packages/jabref/spin.spec SRPM URL: http://mef.fedorapeople.org/packages/jabref/spin-1.5-5.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 Haïkel Guémar changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Haïkel Guémar 2012-04-10 09:32:08 EDT --- All valid points above are ok, the requested changes were done so i have no more reason to hold this review. I hereby approve this package into Fedora Packages Collection since it complies with all Fedora general and python specific guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784594] Review Request: spin - A transparent threading solution for non-freezing Swing applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784594
--- Comment #4 from Tomas Radej 2012-04-10 09:15:48 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[!]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint spin-javadoc-1.5-4.fc18.noarch.rpm
spin-javadoc.noarch: E: incorrect-fsf-address
/usr/share/doc/spin-javadoc-1.5/license.txt
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
rpmlint spin-1.5-4.fc18.noarch.rpm
spin.noarch: E: explicit-lib-dependency cglib
spin.noarch: E: incorrect-fsf-address /usr/share/doc/spin-1.5/license.txt
1 packages and 0 specfiles checked; 2 errors, 0 warnings.
rpmlint spin-1.5-4.fc18.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/tradej/reviews/784594/spin-1.5-all.zip :
MD5SUM this package : b8d6d7fa1ebaf1a2a52d7a8ec9e14319
MD5SUM upstream package : b8d6d7fa1ebaf1a2a52d7a8ec9e14319
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Packa
[Bug 225253] Merge Review: apr
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225253
Jon Ciesla changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution||ERRATA
Flag|fedora-review? |fedora-review+
Last Closed||2012-04-10 08:23:01
--- Comment #24 from Jon Ciesla 2012-04-10 08:23:01 EDT
---
(In reply to comment #23)
> (In reply to comment #22)
> > Fresh review.
> >
> > Good:
> >
> > - rpmlint checks return:
> >
> > apr-devel.x86_64: E: rpath-in-buildconfig /usr/bin/apr-1-config lines ['46']
> > This build configuration file contains rpaths which will be introduced into
> > dependent packages.
>
> This isn't correct, when -rpath passed to libtool when linking a library it
> does not introduce RPATHs; that is the intended use here.
Ok, reasonable.
> > apr-devel.x86_64: W: no-manual-page-for-binary apr-1-config
> > Each executable in standard binary directories should have a man page.
> >
> > Fix if possible.
>
> Patches welcome for that one!
If it doesn't exist, it doesn't exist. :)
>
> > There is one .la file, in -devel, %{_libdir}/libapr-1.la.
> >
> > This needs to go either in -static, or -devel needs Provides: apr-static =
> > %{version}-%{release}
>
> Why? There is no static library in this package, per comment 21.
Ah, I see. Thanks, that should be it then.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225902] Merge Review: intltool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225902 Jon Ciesla changed: What|Removed |Added CC||peter...@redhat.com --- Comment #8 from Jon Ciesla 2012-04-10 08:19:55 EDT --- (In reply to comment #7) > Hi Jon, > > Thanks for taking care of this. I took a look at the changes done here because > of new build failures on rawhide. A few comments: > > > > -BuildRequires: gettext > > +BuildRequires: gettext-devel > > Why is it necessary to change this? It used to build fine with BR: gettext as > it only needs the tools from gettext package for building and doesn't use the > headers that are in -devel. > > > > -Requires: gettext-devel > > +Requires: gettext > > Requiring gettext-devel was a deliberate change in > http://pkgs.fedoraproject.org/gitweb/?p=intltool.git;a=commit;h=b5cc8a4b . If > you ever need to find out why some line is the way it is, 'git blame' can help > for history digging. Because typically, bits that are needed to build other tools against a given package live in -devel, and bits needed at runtime are in the base package. -devel requires base. I understand that this may not always be the case, especially with tools used in development, such as intltool, but that this breaks builds suggests that gettext's file layout might bear re-examination. Looking at that commit simply tells me that the BR was changed, not why. No BZ or problem is mentioned. > Packages that used to rely on intltool dragging in gettext-devel are now > failing to build, e.g. gtranslator: > http://koji.fedoraproject.org/koji/buildinfo?buildID=312458 > > If you think it's important to depend on gettext instead of gettext-devel, can > you send out a heads up to fedora-devel list that packages will now have to > explicitly BR gettext-devel, instead of relying on intltool dragging it in? I > fear the ARM secondary arch people aren't very happy about new FTBFS failures, > so it's best to try to get package maintainers to fix these early. Agreed. I'm adding the gettext maintainer for his thoughts on the best resolution to this. > > > -Obsoletes: xml-i18n-tools > > -Provides: xml-i18n-tools = 0.11 > > +#Obsoletes: xml-i18n-tools > > +#Provides: xml-i18n-tools = 0.11 > > Perhaps remove these lines completely, to avoid cluttering the spec file with > commented out lines? Any changes are permanently recorded in git history, so > it's always possible to revert them at a later date. I do that on my specs, but typically leave them in place for faster reverting on those belonging to others. > > Thanks again for taking care of the merge review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
